Repository navigation
fix(website): hide the workflows that do not run yet - #19288
benjcooley wants to merge 1 commit into
Conversation
The 2026-09-28 live sweep left three workflows failing on production: product-photo-to-video (worker lost past the 10 GiB CPU-job limit while building its combined video, BE-6855), and remove-object and virtual-try-on (their default examples fail their own validation). Each is disabled in the availability manifest with its reason until the PR that fixes it re-enables it (#19284, #19272).
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThree workshop workflows are marked disabled in the availability data. Tests update validation and catalog expectations to reflect 27 published workflows. ChangesWorkshop workflow availability
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The three unavailable workflows will be omitted from the website’s normal catalog and detail routes. No actionable merge-blocking risk is evident in this change. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — review of #19288 at bec0b2f70a.
Verdict: the code is accepted. One SHOULD FIX in the merge coordination, because #19256 will break whichever of the two lands second.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 1 (cross-PR) |
| TRIVIAL | 0 |
The PR itself is correct
- The three manifest entries carry specific, dated reasons and name the PR that re-enables each.
- The counts are right:
productlosesproduct-photo-to-videoandvirtual-try-on(6→4),cleanuplosesremove-object(6→5), for 27 in total. - The route-parity filter matches the manifest.
- Dropping the
partialExamplestable is safe: both partial examples are now unpublished, so "every published default validates" holds and guards against new partial examples. - The new table test asserts each of the three is disabled, has no page and has no route.
SHOULD FIX (cross-PR): #19256 × this PR. Git merges them cleanly, but the website e2e will fail after both land. #19256's test (e2e/workshop-workflows.spec.ts, "workflow launch groups lead to the existing shared form") opens "Change a material", follows its shelf link to ?type=workflows&category=product and asserts toHaveCount(6). With this PR, that shelf holds 4 cards. It becomes 5 after #19284 and 6 after #19272. Fix: whichever merges second updates that assertion. Better still, make it count-independent (for example, assert every card on the filtered shelf is a product workflow and the count is above zero), so the re-enable PRs don't have to chase it.
What each re-enable PR must do after this lands (all three edits, or its tests go red):
- #19284: remove the
workflows/product-photo-to-videomanifest entry, remove its row from the "withholds %s" table, and setproduct4→5 and total 27→28 in the unit test and the e2e counts. - #19272: this one already conflicts textually in
workshop-workflow-content.test.ts(both PRs droppartialExamples). Remove both entries and both table rows, setcleanup5→6 andproduct+1 (to 5 or 6, depending on order), and raise the total and e2e counts to match. - #19282: already closed, so nothing to do.
Verification: 218 tests pass locally on this head (workshop-workflow-content, src/content). CI was 5 passed, 28 pending when I posted.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e4229433c30c410a096594c064ba2298c7013398
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ECaution Some tests failed.
Warning 1 non-screenshot failure — these require manual review. 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19288.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-3yyqhe83m-comfyui.vercel.app Last updated: 2026-09-28T20:31:38Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19288 +/- ##
==========================================
- Coverage 84.21% 84.18% -0.04%
==========================================
Files 3209 3172 -37
Lines 156522 155731 -791
Branches 40640 40444 -196
==========================================
- Hits 131813 131099 -714
+ Misses 23016 22985 -31
+ Partials 1693 1647 -46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: bec0b2f | Docs | View more details | Give us feedback! |
|
Superseded by #19291. All three workflows this PR would hide are fixed there (product-photo-to-video via ConcatenateVideo; remove-object and virtual-try-on via complete default examples), so hiding and then re-enabling them nets to nothing. |
## Summary Makes every published Cloud workflow run. Combines the remaining workflow fixes into one PR: #19284 (product-photo-to-video) and #19272 (remove-object, virtual-try-on). #19288's temporary disables are no longer needed because all three are fixed here. Together with #19251 (already merged), all 30 published workflows pass live on production. ## Changes - **product-photo-to-video** (Bob's commits from #19284): Cloud lost the worker at ~700 s decoding the three MiniMax videos to stitch them. The combined video now uses core `ConcatenateVideo` (joins VIDEO objects without decoding); the downloadable graph and SVG match. - **remove-object**: the example now includes a website-owned 1024×1024 mask over the apple (`public/workflow-inputs/remove-object-apple-mask.png`). - **virtual-try-on**: the example now includes the template's own subject (pinned workflow_templates revision). - **Tests**: every published workflow's example must validate in the shared form; a browser test opens remove-object and virtual-try-on and asserts their inputs are pre-filled. ## Review Focus Live evidence on production (`test:workflow-pages --execute`): - product-photo-to-video at `7c3f7304e4`: 3/3 passed, all 4 outputs incl. the combined video — runs `56635afd…` (191 s), `daff6b57…` (184 s), `98babfa5…` (213 s). - remove-object with this mask: run `1de167fa-7317-4963-b3aa-24e3535a016b`; virtual-try-on with this subject: run `33160fe7-ea1e-46a4-b4cf-e8531cc335f9`. - Every other published workflow passed in the full sweep after #19251. Post-deploy: the mask is served from comfy.org once this ships; run remove-object once through the site. Previously accepted by Bill as #19272 and #19284 (same commits). CI's `/models/` JavaScript-budget failure is fixed by #19256, which merges first. Validation: 7,377 website unit tests, website typecheck, 15 workflow browser tests on the CI-equivalent build. ## Why product-photo-to-video has no new browser test The change is inside the Cloud graph (`ConcatenateVideo` replacing the decode-and-stitch subgraph) and only has an effect when Cloud executes it. The website's Playwright suites stub Cloud's `/api/prompt` and `/api/jobs` (`e2e/workshop-workflow-runs.spec.ts`), so no browser test can observe whether Cloud keeps the worker alive or produces the combined video. The page, its form and its submission path are unchanged and remain covered by the existing workflow browser tests; the graph change is verified where it runs — three live production runs above (all four outputs, combined video included) — and by the scheduled live sweep in #19274.
Summary
Ben asked that every workflow that doesn't currently run be hidden, with the reason recorded in the availability manifest. The 2026-09-28 live sweep of all 30 published workflows on production left three failing, and each is now disabled until its fix merges.
Changes
What: three entries in
src/data/workshop-model-availability.json:workflows/product-photo-to-videoworkflows/remove-objectworkflows/virtual-try-onTests:
productand 5 incleanup.Review Focus