Repository navigation
fix(website): make product-photo-to-video's combined video run on Cloud - #19284
benjcooley wants to merge 2 commits into
Conversation
Building the combined video decodes MiniMax's clips into frames, and
that step takes the Cloud worker down ("RIP to the server") on every
run, even at 768p with a quarter-size stitch. The three clips alone
complete (167s, all three delivered), so the workflow now outputs just
those. The downloadable graph and preview drop the same Combine Video
subgraph and save node so they stay consistent with the Cloud request.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe product photo-to-video workflow now combines the rotation, texture-zoom, and cinematic-pan clips with a ChangesProduct photo-to-video workflow
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The workflow retains its combined and individual video outputs, with no identified issue preventing merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — review of #19284 at 74782547e2.
Verdict: accepted. No code findings. One merge-order point below.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
Downloadable graph: well-formed. I checked every link reference in both the old and new files.
- Root nodes 27 and 30, links 33/34/35/41 and the Combine Video subgraph definition are gone, and nothing references the removed subgraph type.
- Nodes 5, 18 and 20 each output only to their own
SaveVideo(links 16, 18 and 20). No node input or output points at a missing link, and every link's endpoints exist. - Keeping
last_link_id/last_node_idat 41/30 is correct: ids aren't reused.
Cloud graph and outputs: consistent.
- The graph goes from 16 to 9 nodes, with no
27:*or30left and no dangling[nodeId, slot]references. The input bindings are untouched. outputsis exactlyvideo-2/video-3/video-4→SaveVideo16/17/19, andoutputsis the only non-graph field that changed.- The page matches: the description and example promise "a sequence of showcase clips" / "several complementary showcase shots", never a combined video. Output lookups go through the returned
outputId, so nothing hard-codes the droppedvideoid.
SVG: regenerating with workflowPreviewSvg from the new JSON is byte-identical to the committed file.
Merge order: #19282 (disabling this same workflow) is still OPEN. If it merges after this PR, it switches off the workflow this PR just fixed. Close #19282 when this lands. If #19282 merges first, this PR also needs to remove the workflows/product-photo-to-video availability entry and restore the 30/6 counts.
Verification: 181 tests pass locally on this head (prepare-workflow-previews, workflow catalog, workflow content). CI was still running when I posted.
|
Live verification on prod against 7478254, from Jim's sweep with 3 concurrent repeats: 3/3 passed, and every output downloaded.
The free page, graph and media checks passed 5/5. #19282 (the temporary disable) is closed, so the page stays enabled once this merges. |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e4229433c30c410a096594c064ba2298c7013398
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ECaution Some tests failed.
Warning 1 non-screenshot failure — these require manual review. 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19284.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-k8g7o23di-comfyui.vercel.app Last updated: 2026-09-28T20:36:31Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19284 +/- ##
==========================================
- Coverage 84.20% 84.17% -0.04%
==========================================
Files 3195 3170 -25
Lines 155999 155607 -392
Branches 40488 40416 -72
==========================================
- Hits 131364 130987 -377
+ Misses 22992 22977 -15
Partials 1643 1643
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Cloud's core ConcatenateVideo node joins VIDEO objects without decoding them into frames (the BE-6855 fix), so the combined video no longer needs the decode-and-batch stitch that exceeded the 10 GiB CPU-job limit. The three MiniMax clips feed ConcatenateVideo, and its output is saved as before. The downloadable graph swaps the Combine Video subgraph for the same node and keeps its links. Verified on prod: 157s, all four outputs.
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — re-review of #19284 at 7c3f7304e4 (the ConcatenateVideo approach, one commit on 74782547e2).
Verdict: accepted. No findings. The manifest and count edits come after #19288, as agreed.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
Cloud graph
- Against main, only two things change: the six
27:*subgraph nodes become one27ConcatenateVideo(videos.video0/1/2=["5",0]/["18",0]/["20",0],codec: "auto"), andSaveVideo30 is re-pointed from["27:27",0]to["27",0]. - No references dangle, and
outputsis identical to main's (video→ 30,video-2/3/4→ 16/17/19).
Downloadable graph
- Against main, node 27 is the only node that changed, and the
linksarray is identical. - Links 33/34/35 target node 27 at slots 0/1/2, which match
videos.video0..2. Link 41 (27 → 30) is unchanged. - The Combine Video subgraph definition is removed, and no link id dangles in either direction.
- The autogrow shape matches the frontend.
autogrowOrdinalToName(src/core/graph/widgets/dynamicWidgets.ts) builds${group}.${prefix}${ordinal}for a single-spec template, which givesvideos.video0. The prod Cloud run accepted those exact keys, which confirms the group and prefix. Autogrow also keeps one empty slot after the last connected one, so three linked slots plus an emptyvideos.video3is what ComfyUI itself serializes.widgets_values: ["auto"]carries the codec.
SVG: regenerating with workflowPreviewSvg is byte-identical (7,296 bytes).
Verification: 181 tests pass locally on this head (prepare-workflow-previews, workflow catalog, workflow content). Prod job 6080c332 delivered 4 outputs in 157s, and JIM's 3× repeat is pending. CI was 5 passed, 27 pending when I posted.
|
Live verification on prod against 7c3f730 (ConcatenateVideo), from Jim's sweep with 3 repeats: 3/3 passed. Each run delivered all 4 outputs, including the combined video (206 video/mp4).
The free page, graph and media checks passed 5/5. My earlier run, 6080c332-410c-4409-98bc-5772276338ac, also succeeded in 157s. |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 7c3f730 | Docs | View more details | Give us feedback! |
|
Superseded by #19291, which carries both commits here unchanged (graph, download and preview byte-identical to 7c3f730) together with #19272's fixes, as one PR at Ben's request. The live evidence here (6080c332 plus Jim's 3/3: 56635afd, daff6b57, 98babfa5) applies to #19291's product-photo-to-video graph. |
## Summary Makes every published Cloud workflow run. Combines the remaining workflow fixes into one PR: #19284 (product-photo-to-video) and #19272 (remove-object, virtual-try-on). #19288's temporary disables are no longer needed because all three are fixed here. Together with #19251 (already merged), all 30 published workflows pass live on production. ## Changes - **product-photo-to-video** (Bob's commits from #19284): Cloud lost the worker at ~700 s decoding the three MiniMax videos to stitch them. The combined video now uses core `ConcatenateVideo` (joins VIDEO objects without decoding); the downloadable graph and SVG match. - **remove-object**: the example now includes a website-owned 1024×1024 mask over the apple (`public/workflow-inputs/remove-object-apple-mask.png`). - **virtual-try-on**: the example now includes the template's own subject (pinned workflow_templates revision). - **Tests**: every published workflow's example must validate in the shared form; a browser test opens remove-object and virtual-try-on and asserts their inputs are pre-filled. ## Review Focus Live evidence on production (`test:workflow-pages --execute`): - product-photo-to-video at `7c3f7304e4`: 3/3 passed, all 4 outputs incl. the combined video — runs `56635afd…` (191 s), `daff6b57…` (184 s), `98babfa5…` (213 s). - remove-object with this mask: run `1de167fa-7317-4963-b3aa-24e3535a016b`; virtual-try-on with this subject: run `33160fe7-ea1e-46a4-b4cf-e8531cc335f9`. - Every other published workflow passed in the full sweep after #19251. Post-deploy: the mask is served from comfy.org once this ships; run remove-object once through the site. Previously accepted by Bill as #19272 and #19284 (same commits). CI's `/models/` JavaScript-budget failure is fixed by #19256, which merges first. Validation: 7,377 website unit tests, website typecheck, 15 workflow browser tests on the CI-equivalent build. ## Why product-photo-to-video has no new browser test The change is inside the Cloud graph (`ConcatenateVideo` replacing the decode-and-stitch subgraph) and only has an effect when Cloud executes it. The website's Playwright suites stub Cloud's `/api/prompt` and `/api/jobs` (`e2e/workshop-workflow-runs.spec.ts`), so no browser test can observe whether Cloud keeps the worker alive or produces the combined video. The page, its form and its submission path are unchanged and remain covered by the existing workflow browser tests; the graph change is verified where it runs — three live production runs above (all four outputs, combined video included) — and by the scheduled live sweep in #19274.
Summary
product-photo-to-videocrashed the Cloud worker (ServiceError: RIP to the server your workflow was running on) on every recent run. Its combined video decoded all three MiniMax clips into frames and batched them, which exceeds the 10 GiB RAM limit for CPU-only Cloud jobs (BE-6855). The combined video now comes from Cloud's coreConcatenateVideonode, which joins VIDEO objects without decoding them.Changes
workshop-workflows.jsonl: the Combine Video subgraph (27:*: threeGetVideoComponents, twoImageBatch,CreateVideo) is replaced by27ConcatenateVideo(videos.video0..2= the three MiniMax clips, codecauto).SaveVideo30 saves its output as before, and all four outputs are unchanged.public/workflow-graphs/product-photo-to-video.jsonand.svg: node 27 becomes the sameConcatenateVideonode with its original links (33, 34, 35 → 41), and the unused subgraph definition is removed. The file keeps its original formatting.Review Focus
Production Cloud runs with the example input, through
workflow_render:ConcatenateVideo)