Repository navigation
test(workspace): guard the pending-invite menu against raw i18n keys - #19307
dante01yoon wants to merge 1 commit into
Conversation
The pending-invite row menu shipped a raw
workspacePanel.members.actions.copyInviteLink label to production on the
cloud/1.54 release line. main has the locale entry, but nothing stops it
being dropped again: every existing test in this file builds i18n with
`messages: { en: {} }` and asserts the raw key strings, so a missing
translation is indistinguishable from a present one.
Renders the menu against the shipped en bundle instead and asserts no
button is left with a name in the workspacePanel namespace. Verified it
fails when copyInviteLink is removed from src/locales/en/main.json.
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 11 days. Promotion and pricing detailsOn-demand reviews are free for the next 11 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 13 minutes for your next included review. Limit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Comment |
|
Asked to rebase this onto The strings already exist on Retargeting this PR's base would not produce a rebase, it would produce a merge of the release line into
What I did instead: opened #19307 against This PR stays based on Also addressed the review feedback on the test itself: replaced the If the intent was that the reported bug should just ride 1.55 rather than be patched on 1.54, say so and I'll close this — but note |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4dde68ba9e6a3f29691a353abb1301cd4e291b94
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🎨 Storybook: ✅ Built — View Storybook |
|
No code changes from this — the review was paused by the org's included-review quota (8/8 used), not by anything in the diff. Zero technical feedback was given. Worth getting it to actually run rather than leaving it: I waited for the included window to reset and am triggering through the included quota rather than ticking the on-demand checkbox — that path is tied to the promo/pricing meter, and spending org review budget isn't my call to make. For context while it runs: this is 33 added lines in one test file. It already went through a two-model deep review, which caught a real issue I've since fixed — a Also confirmed the one commit @coderabbitai review |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19307 +/- ##
==========================================
+ Coverage 84.22% 85.12% +0.89%
==========================================
Files 3213 2341 -872
Lines 156702 134730 -21972
Branches 40693 36458 -4235
==========================================
- Hits 131989 114692 -17297
+ Misses 23020 19684 -3336
+ Partials 1693 354 -1339
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
PR Created by the Glary-Bot Agent
Companion to #19300, based on
mainas requested.Why this is a test and not a locale fix
All six locale keys from #17315 are already present on
main— I verified each one againstorigin/main:src/locales/en/main.json:So there is no string to add here. What
mainis missing is a guard: every existing test inPendingInvitesList.test.tsbuilds i18n withmessages: { en: {} }and asserts the raw key strings as accessible names, so a present translation and a missing one are indistinguishable. That is exactly howworkspacePanel.members.actions.copyInviteLinkreached production oncloud/1.54with every gate green.Change
One test that renders the menu against the shipped
enbundle and asserts no button is left with a name in theworkspacePanelnamespace, plus the three expected labels.Verification
mainas-is (7/7 in the file)copyInviteLinkfromsrc/locales/en/main.jsononmainfails it withexpected [ <button …> ] to have a length of +0 but got 1; restored afterwardspnpm typecheckexit 0 (matters here — a large JSON bundle is fed intocreateI18n's typedmessages), eslint exit 0, oxfmt cleanKnown limits
workspacePanel.members.actions.*keys this menu renders. The other three in that namespace (changeRole,setCreditLimit,removeMember) are consumed viauseMembersPanel.ts, whose tests use a hand-written stub bundle and so share the original blind spot.scripts/check-unused-i18n-keys.tsscans the opposite direction today, and@intlify/vue-i18n/no-missing-keysis not enabled ineslint.config.ts(onlyno-raw-textis). Both are follow-ups, noted on FE-1225.Related
cloud/1.54(that is the only branch missing the strings; retargeting it tomainwould diff 999 files across 139 commits of release-branch divergence)