Repository navigation
fix(website): give remove-object and virtual-try-on complete default examples - #19272
benjcooley wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e4229433c30c410a096594c064ba2298c7013398
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ECaution Some tests failed.
Warning 1 non-screenshot failure — these require manual review. 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19272.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-9wsrajytp-comfyui.vercel.app Last updated: 2026-09-28T20:33:27Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 11 days. Promotion and pricing detailsOn-demand reviews are free for the next 11 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 1 minute for your next included review. Limit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe remove-object and virtual-try-on examples now include initial image values and updated descriptions. Tests cover initial-value validation, the Bria mask asset, and image controls on both workflow pages. ChangesWorkshop workflow examples
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The added examples and their required image values have test coverage. No actionable merge-blocking risk remains after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19272 +/- ##
==========================================
- Coverage 84.21% 84.18% -0.04%
==========================================
Files 3209 3172 -37
Lines 156522 155731 -791
Branches 40640 40444 -196
==========================================
- Hits 131813 131099 -714
+ Misses 23016 22985 -31
+ Partials 1693 1647 -46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a8858bd to
74dd5ee
Compare
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — review of #19272 at 74dd5ee84d.
Verdict: accepted. No findings.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
- Data: exactly two example values change,
remove-object'smaskandvirtual-try-on'simage1, plus their descriptions. No ids or other fields change. - Mask asset:
public/workflow-inputs/remove-object-apple-mask.pngis a 1024×1024 8-bit grayscale PNG.LoadImageMaskconverts it to RGBA, so the node'sredchannel reads it as intended. - Fetchability:
comfy.orgserves the apex directly (200, no redirect, which matters becauseloadWorkshopExampleFileusesredirect: 'error'). Its static assets sendaccess-control-allow-origin: *, so the browser-side example fetch at Run time works from prod, previews and local dev once this deploys. - Try-on subject: the jsDelivr URL is pinned to a commit (
90c71fb78b), so it can't drift. - Tests: the content test now requires every workflow example to validate, replacing the
partialExamplesallow-list, which is the right guard. The new e2e test answers CodeRabbit's pre-merge coverage check.
After deploy: the mask is 404 on prod until this ships, so this PR's own preview can't complete a remove-object run, and the e2e test checks the pre-filled input rather than the fetch. After deploy, one live remove-object Run through the site would confirm the whole path. Your runs so far went straight to Cloud.
Verification: 225 tests pass locally on this head (workshop-workflow-content, src/content). CI was still running when I posted (22 passed, 23 pending), so merge on green.
The 2026-09-28 live sweep left three workflows failing on production: product-photo-to-video (worker lost past the 10 GiB CPU-job limit while building its combined video, BE-6855), and remove-object and virtual-try-on (their default examples fail their own validation). Each is disabled in the availability manifest with its reason until the PR that fixes it re-enables it (#19284, #19272).
…examples Both workflow pages shipped examples missing a required input (the Bria mask, the try-on subject), so the default Run could not submit. Add a website-owned apple mask matching the example image, and the template's own try-on subject from the pinned workflow_templates revision.
|
Now stacked on #19288 (merge that first): this PR re-enables remove-object and virtual-try-on by removing their availability entries and restores the counts (29 total, cleanup 6, product 5); product-photo-to-video stays disabled until #19284. Until #19288 merges, the diff here also shows its commit; I'll rebase onto main as soon as it lands. 15 workflow browser tests and 168 content tests pass on the stacked branch. |
74dd5ee to
e9909dc
Compare
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — re-review of #19272 at e9909dc297, now stacked on #19288 (bec0b2f70a).
Verdict: accepted. No findings.
- Content unchanged:
workshop-display.jsonandremove-object-apple-mask.pngare byte-identical to what I accepted at74dd5ee84d, and the pre-filled-inputs e2e is intact. - Re-enable is complete: exactly the two manifest entries (
remove-object,virtual-try-on) and their two rows in "withholds %s" are removed. Onlyproduct-photo-to-videostays withheld. - Counts are right: computed from the data, this head publishes 29 workflows (
product5,cleanup6, the other three categories 6 each), matching every unit and e2e assertion.
Merge-order notes:
- This lands after #19288. Whichever of this PR and #19284 lands second takes
product6 and total 30. - #19256's
product-shelf e2e must become count-independent (in progress in the Mar chat), or it fails against 5 here.
Verification: 223 tests pass locally on this head (workshop-workflow-content, src/content). CI was 6 passed, 26 pending when I posted.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: e9909dc | Docs | View more details | Give us feedback! |
## Summary Makes every published Cloud workflow run. Combines the remaining workflow fixes into one PR: #19284 (product-photo-to-video) and #19272 (remove-object, virtual-try-on). #19288's temporary disables are no longer needed because all three are fixed here. Together with #19251 (already merged), all 30 published workflows pass live on production. ## Changes - **product-photo-to-video** (Bob's commits from #19284): Cloud lost the worker at ~700 s decoding the three MiniMax videos to stitch them. The combined video now uses core `ConcatenateVideo` (joins VIDEO objects without decoding); the downloadable graph and SVG match. - **remove-object**: the example now includes a website-owned 1024×1024 mask over the apple (`public/workflow-inputs/remove-object-apple-mask.png`). - **virtual-try-on**: the example now includes the template's own subject (pinned workflow_templates revision). - **Tests**: every published workflow's example must validate in the shared form; a browser test opens remove-object and virtual-try-on and asserts their inputs are pre-filled. ## Review Focus Live evidence on production (`test:workflow-pages --execute`): - product-photo-to-video at `7c3f7304e4`: 3/3 passed, all 4 outputs incl. the combined video — runs `56635afd…` (191 s), `daff6b57…` (184 s), `98babfa5…` (213 s). - remove-object with this mask: run `1de167fa-7317-4963-b3aa-24e3535a016b`; virtual-try-on with this subject: run `33160fe7-ea1e-46a4-b4cf-e8531cc335f9`. - Every other published workflow passed in the full sweep after #19251. Post-deploy: the mask is served from comfy.org once this ships; run remove-object once through the site. Previously accepted by Bill as #19272 and #19284 (same commits). CI's `/models/` JavaScript-budget failure is fixed by #19256, which merges first. Validation: 7,377 website unit tests, website typecheck, 15 workflow browser tests on the CI-equivalent build. ## Why product-photo-to-video has no new browser test The change is inside the Cloud graph (`ConcatenateVideo` replacing the decode-and-stitch subgraph) and only has an effect when Cloud executes it. The website's Playwright suites stub Cloud's `/api/prompt` and `/api/jobs` (`e2e/workshop-workflow-runs.spec.ts`), so no browser test can observe whether Cloud keeps the worker alive or produces the combined video. The page, its form and its submission path are unchanged and remain covered by the existing workflow browser tests; the graph change is verified where it runs — three live production runs above (all four outputs, combined video included) — and by the scheduled live sweep in #19274.
Summary
Two workflow pages shipped default examples missing a required input, so the default Run could not submit: remove-object had no mask and virtual-try-on had no subject.
Changes
public/workflow-inputs/remove-object-apple-mask.png(a 1024×1024 white-on-black mask over the apple and its leaf, matching the example image). virtual-try-on's example now includes the template's own subject,subject-templates_rob_fashion_shoot_vton-4in1.png, pinned to the same workflow_templates revision as its outfit.Review Focus
https://comfy.org/workflow-inputs/…, CORS*,image/png), so it resolves once this deploys; previews at other origins fetch it from production.subject.pngis 21 MB, which jsDelivr refuses (403) and raw GitHub serves asapplication/octet-stream(rejected by the uploader), hence the 2 MB subject from the same template set.Verified live on production: remove-object with this mask (run
1de167fa-7317-4963-b3aa-24e3535a016b) and virtual-try-on with this subject (run33160fe7-ea1e-46a4-b4cf-e8531cc335f9, five images) both completed. The try-on run needs the partner-node auth in #19251, which is not in this PR.