Skip to content

fix(website): give remove-object and virtual-try-on complete default examples - #19272

Closed
benjcooley wants to merge 3 commits into
mainfrom
benjcooley/workflow-page-fixes
Closed

benjcooley wants to merge 3 commits into
mainfrom
benjcooley/workflow-page-fixes

Conversation

@benjcooley

@benjcooley benjcooley commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Two workflow pages shipped default examples missing a required input, so the default Run could not submit: remove-object had no mask and virtual-try-on had no subject.

Changes

  • What: remove-object's example now includes public/workflow-inputs/remove-object-apple-mask.png (a 1024×1024 white-on-black mask over the apple and its leaf, matching the example image). virtual-try-on's example now includes the template's own subject, subject-templates_rob_fashion_shoot_vton-4in1.png, pinned to the same workflow_templates revision as its outfit.
  • Tests: a browser test opens both pages and asserts the mask and the try-on subject are pre-filled.
  • Tests (unit): every published workflow now opens with an example that passes the shared form (the previous partial-example exceptions are removed); the Bria test asserts the website-owned mask and that the file ships.

Review Focus

  • The mask is served from comfy.org (https://comfy.org/workflow-inputs/…, CORS *, image/png), so it resolves once this deploys; previews at other origins fetch it from production.
  • The template's original subject.png is 21 MB, which jsDelivr refuses (403) and raw GitHub serves as application/octet-stream (rejected by the uploader), hence the 2 MB subject from the same template set.

Verified live on production: remove-object with this mask (run 1de167fa-7317-4963-b3aa-24e3535a016b) and virtual-try-on with this subject (run 33160fe7-ea1e-46a4-b4cf-e8531cc335f9, five images) both completed. The try-on run needs the partner-node auth in #19251, which is not in this PR.

@benjcooley
benjcooley requested review from a team September 28, 2026 18:54
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 8:29pm UTC
billing-web-test Skipped Skipped Sep 28, 2026 8:29pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since e4229433c30c410a096594c064ba2298c7013398

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Caution

Some tests failed.

Status ❌ Failed
Report View Report
Screenshot diffs 0
Other failures 1

Warning

1 non-screenshot failure — these require manual review.

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19272.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-9wsrajytp-comfyui.vercel.app

Last updated: 2026-09-28T20:33:27Z for e9909dc

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review paused — included plan limit reached

Keep your review moving with free on-demand reviews.

  • Run this review for free

On-demand reviews are free for the next 11 days.

Promotion and pricing details

On-demand reviews are free for the next 11 days. After that, they cost $0.25 per reviewed file.

Review limit details

Or wait 1 minute for your next included review.

Check out review usage here.

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 62f9c7cd-6b3b-423c-826b-a838a3505a78

📥 Commits

Reviewing files that changed from the base of the PR and between 74dd5ee and e9909dc.

⛔ Files ignored due to path filters (1)
  • apps/website/public/workflow-inputs/remove-object-apple-mask.png is excluded by !**/*.png
📒 Files selected for processing (4)
  • apps/website/e2e/workshop-workflows.spec.ts
  • apps/website/src/config/workshop-workflow-content.test.ts
  • apps/website/src/content/workshop-display.json
  • apps/website/src/data/workshop-model-availability.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2b5fe4fa-d870-47ef-8e97-d1af61aa5de8

📥 Commits

Reviewing files that changed from the base of the PR and between a8858bd and 74dd5ee.

⛔ Files ignored due to path filters (1)
  • apps/website/public/workflow-inputs/remove-object-apple-mask.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • apps/website/e2e/workshop-workflows.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The remove-object and virtual-try-on examples now include initial image values and updated descriptions. Tests cover initial-value validation, the Bria mask asset, and image controls on both workflow pages.

Changes

Workshop workflow examples

Layer / File(s) Summary
Add example image values
apps/website/src/content/workshop-display.json
The remove-object example now includes a mask value and identifies the white masked area as the removal target. The virtual-try-on example now includes the character image as image1 and describes the four-look fashion grid.
Validate example values and image controls
apps/website/src/config/workshop-workflow-content.test.ts, apps/website/e2e/workshop-workflows.spec.ts
The shared-form test expects every workflow’s initial values to validate without errors. The Bria test checks the initial mask URL and confirms that its file exists in the public directory. End-to-end tests check Replace and Remove controls for required images on the remove-object and virtual-try-on pages.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: anupreet-comfy, comfyrob

Merge Risk: ⚪ Minimal · up to 74dd5

The added examples and their required image values have test coverage. No actionable merge-blocking risk remains after normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 74dd5

The change affects 1 system.

Changed systems: apps/website

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/website (service) was modified; 3 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/website/src/config/workshop-workflow-content.test.ts: The shared-form test now expects validation to return an empty object for every workflow, replacing the per-workflow partial-error expectations.
  • observed — Modified behavior in apps/website/src/config/workshop-workflow-content.test.ts: The Bria example assertion now verifies that the initial mask value is the website-owned apple-mask URL and that the referenced file exists under the public directory; it replaces the assertion about the example description.
  • observed — Modified behavior in apps/website/src/content/workshop-display.json: The remove-object example now supplies a black-and-white apple mask and updates its description to identify the white masked area as the removal target; previously, the example omitted the mask value.
  • observed — Modified behavior in apps/website/src/content/workshop-display.json: The virtual-try-on example now supplies the character reference as image1 and replaces the generic upload description with a description of the four-look fashion grid.
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The title and commit subjects use the bug-fix signal fix. However, all listed changed files are under apps/website, and the check explicitly excludes changes exclusively in apps/website. The PR …
Website End-To-End Regression Coverage ✅ Passed The PR changes website runtime behavior by adding default inputs to the remove-object and virtual-try-on workflow examples. It also adds Playwright tests in `apps/website/e2e/workshop-workflows.spec.t…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only website workflow content, tests, and end-to-end tests. It does not include src/lib/litegraph/, src/ecs/, or files related to graph entities. The ADR-LAYOUT and …
Title check ✅ Passed The title clearly and concisely describes the main change: adding complete default examples for the remove-object and virtual-try-on workflows.
Description check ✅ Passed The description includes the required Summary, Changes, and Review Focus sections. It explains the missing inputs, implementation details, tests, deployment considerations, and related authentication …
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19272      +/-   ##
==========================================
- Coverage   84.21%   84.18%   -0.04%     
==========================================
  Files        3209     3172      -37     
  Lines      156522   155731     -791     
  Branches    40640    40444     -196     
==========================================
- Hits       131813   131099     -714     
+ Misses      23016    22985      -31     
+ Partials     1693     1647      -46     
Flag Coverage Δ
billing-web-unit ?
website-unit 78.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026
@benjcooley
benjcooley force-pushed the benjcooley/workflow-page-fixes branch from a8858bd to 74dd5ee Compare September 28, 2026 19:34
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 28, 2026 19:35 Inactive

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL — review of #19272 at 74dd5ee84d.

Verdict: accepted. No findings.

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0
  • Data: exactly two example values change, remove-object's mask and virtual-try-on's image1, plus their descriptions. No ids or other fields change.
  • Mask asset: public/workflow-inputs/remove-object-apple-mask.png is a 1024×1024 8-bit grayscale PNG. LoadImageMask converts it to RGBA, so the node's red channel reads it as intended.
  • Fetchability: comfy.org serves the apex directly (200, no redirect, which matters because loadWorkshopExampleFile uses redirect: 'error'). Its static assets send access-control-allow-origin: *, so the browser-side example fetch at Run time works from prod, previews and local dev once this deploys.
  • Try-on subject: the jsDelivr URL is pinned to a commit (90c71fb78b), so it can't drift.
  • Tests: the content test now requires every workflow example to validate, replacing the partialExamples allow-list, which is the right guard. The new e2e test answers CodeRabbit's pre-merge coverage check.

After deploy: the mask is 404 on prod until this ships, so this PR's own preview can't complete a remove-object run, and the e2e test checks the pre-filled input rather than the fetch. After deploy, one live remove-object Run through the site would confirm the whole path. Your runs so far went straight to Cloud.

Verification: 225 tests pass locally on this head (workshop-workflow-content, src/content). CI was still running when I posted (22 passed, 23 pending), so merge on green.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 28, 2026
The 2026-09-28 live sweep left three workflows failing on production:
product-photo-to-video (worker lost past the 10 GiB CPU-job limit while
building its combined video, BE-6855), and remove-object and
virtual-try-on (their default examples fail their own validation). Each
is disabled in the availability manifest with its reason until the PR
that fixes it re-enables it (#19284, #19272).
…examples

Both workflow pages shipped examples missing a required input (the Bria mask, the try-on subject), so the default Run could not submit. Add a website-owned apple mask matching the example image, and the template's own try-on subject from the pinned workflow_templates revision.
@benjcooley

Copy link
Copy Markdown
Collaborator Author

Now stacked on #19288 (merge that first): this PR re-enables remove-object and virtual-try-on by removing their availability entries and restores the counts (29 total, cleanup 6, product 5); product-photo-to-video stays disabled until #19284. Until #19288 merges, the diff here also shows its commit; I'll rebase onto main as soon as it lands. 15 workflow browser tests and 168 content tests pass on the stacked branch.

@benjcooley
benjcooley force-pushed the benjcooley/workflow-page-fixes branch from 74dd5ee to e9909dc Compare September 28, 2026 20:29
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 28, 2026 20:29 Inactive

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL — re-review of #19272 at e9909dc297, now stacked on #19288 (bec0b2f70a).

Verdict: accepted. No findings.

  • Content unchanged: workshop-display.json and remove-object-apple-mask.png are byte-identical to what I accepted at 74dd5ee84d, and the pre-filled-inputs e2e is intact.
  • Re-enable is complete: exactly the two manifest entries (remove-object, virtual-try-on) and their two rows in "withholds %s" are removed. Only product-photo-to-video stays withheld.
  • Counts are right: computed from the data, this head publishes 29 workflows (product 5, cleanup 6, the other three categories 6 each), matching every unit and e2e assertion.

Merge-order notes:

  • This lands after #19288. Whichever of this PR and #19284 lands second takes product 6 and total 30.
  • #19256's product-shelf e2e must become count-independent (in progress in the Mar chat), or it fails against 5 here.

Verification: 223 tests pass locally on this head (workshop-workflow-content, src/content). CI was 6 passed, 26 pending when I posted.

@datadog-official

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

CI: Website E2E | website-e2e-shard (3, 4) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Website E2E | website-e2e

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e9909dc | Docs | View more details | Give us feedback!

@benjcooley

Copy link
Copy Markdown
Collaborator Author

Superseded by #19291, which combines this with #19284 in one PR (Ben's request). Same commits; no disables needed.

@benjcooley benjcooley closed this Sep 28, 2026
benjcooley added a commit that referenced this pull request Sep 28, 2026
## Summary

Makes every published Cloud workflow run. Combines the remaining
workflow fixes into one PR: #19284 (product-photo-to-video) and #19272
(remove-object, virtual-try-on). #19288's temporary disables are no
longer needed because all three are fixed here. Together with #19251
(already merged), all 30 published workflows pass live on production.

## Changes

- **product-photo-to-video** (Bob's commits from #19284): Cloud lost the
worker at ~700 s decoding the three MiniMax videos to stitch them. The
combined video now uses core `ConcatenateVideo` (joins VIDEO objects
without decoding); the downloadable graph and SVG match.
- **remove-object**: the example now includes a website-owned 1024×1024
mask over the apple
(`public/workflow-inputs/remove-object-apple-mask.png`).
- **virtual-try-on**: the example now includes the template's own
subject (pinned workflow_templates revision).
- **Tests**: every published workflow's example must validate in the
shared form; a browser test opens remove-object and virtual-try-on and
asserts their inputs are pre-filled.

## Review Focus

Live evidence on production (`test:workflow-pages --execute`):
- product-photo-to-video at `7c3f7304e4`: 3/3 passed, all 4 outputs
incl. the combined video — runs `56635afd…` (191 s), `daff6b57…` (184
s), `98babfa5…` (213 s).
- remove-object with this mask: run
`1de167fa-7317-4963-b3aa-24e3535a016b`; virtual-try-on with this
subject: run `33160fe7-ea1e-46a4-b4cf-e8531cc335f9`.
- Every other published workflow passed in the full sweep after #19251.

Post-deploy: the mask is served from comfy.org once this ships; run
remove-object once through the site.

Previously accepted by Bill as #19272 and #19284 (same commits). CI's
`/models/` JavaScript-budget failure is fixed by #19256, which merges
first.

Validation: 7,377 website unit tests, website typecheck, 15 workflow
browser tests on the CI-equivalent build.


## Why product-photo-to-video has no new browser test

The change is inside the Cloud graph (`ConcatenateVideo` replacing the
decode-and-stitch subgraph) and only has an effect when Cloud executes
it. The website's Playwright suites stub Cloud's `/api/prompt` and
`/api/jobs` (`e2e/workshop-workflow-runs.spec.ts`), so no browser test
can observe whether Cloud keeps the worker alive or produces the
combined video. The page, its form and its submission path are unchanged
and remain covered by the existing workflow browser tests; the graph
change is verified where it runs — three live production runs above (all
four outputs, combined video included) — and by the scheduled live sweep
in #19274.

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — e9909dc2 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant