Skip to content

test(website): raise models catalogue JS budget to 1.83MB - #19289

Closed
benjcooley wants to merge 1 commit into
mainfrom
benjcooley/website-js-budget-1-83mb
Closed

benjcooley wants to merge 1 commit into
mainfrom
benjcooley/website-js-budget-1-83mb

Conversation

@benjcooley

Copy link
Copy Markdown
Collaborator

Summary

main is 430 bytes over the /models/ JavaScript budget (1,820,430 against a ceiling of 1,820,000 decoded bytes). So catalogue browsing stays within its JavaScript budget fails on every website PR, for example #19288. #19255 (Hub V2) and #19243 each passed against their own base, and together they cross the line.

Changes

Review Focus

  • Measured locally on a CI-env build of main at 399630a: 1,820,430 bytes with the old ceiling (fails) and passes with the new one. fix(website): hide the workflows that do not run yet #19288 measures the same 1,820,430, so it adds nothing.
  • Headroom is about 9.5KB. Trimming the Hub V2 catalogue code to restore the old ceiling is a possible follow-up.

#19255 (Hub V2) and #19243 each passed the 1.82MB ceiling on its own
base, but together main now loads 1,820,430 bytes on /models/, so every
website PR fails this check. Raise the whole-route ceiling by 10KB; the
900KB catalogue-delta budget is unchanged.
@benjcooley
benjcooley requested review from a team September 28, 2026 20:48
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 8:48pm UTC
billing-web-test Skipped Skipped Sep 28, 2026 8:48pm UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 28, 2026 20:48 Inactive

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL — review of #19289 at 9db4ed6926.

Verdict: accepted. No findings.

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0
  • The change is one line: the /models/ whole-route ceiling in models-performance.spec.ts moves from 1_820_000 to 1_830_000. The 900 KB catalogue-delta budget (line 51) is unchanged, so the check that /models/-specific code stays small still applies.
  • The failure is real and deterministic. I confirmed it in CI, not just locally: #19288's website-e2e-shard (3, 4) fails with Expected: < 1820000, Received: 1820430, and the retry measured the identical 1,820,430. That's the combined weight of #19255 and #19243 on main, not flake and not #19288's content.
  • Headroom: the new ceiling leaves 9,570 bytes (about 0.5%%). That's the right size for a guard, but the next feature that adds JS to /models/ will hit it again. That's intended: the next increase should also be a deliberate decision.

CI when I posted: 14 pass, 24 pending. Merge on green; once this lands, rebase the website PRs that are red on this test.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

⚡ Performance

⏳ Performance tests in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 21e7421e0bbd8d518581ab8d345070f6840243b1

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19289.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-2rgowt5fd-comfyui.vercel.app

Last updated: 2026-09-28T20:50:47Z for 9db4ed6

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0077c24f-729d-40d8-98ac-5509b3138c21

📥 Commits

Reviewing files that changed from the base of the PR and between 21e7421 and 9db4ed6.

📒 Files selected for processing (1)
  • apps/website/e2e/models-performance.spec.ts
 __________________________________________________________
< Your types are so loose they're in an open relationship. >
 ----------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@benjcooley

Copy link
Copy Markdown
Collaborator Author

Closing: #19256 (commit 2518279) raises the same whole-route ceiling to 1,825,000, and Ben chose that fix. Main measured 1,820,430 locally, which leaves about 4.5KB of headroom under 1,825,000.

@benjcooley benjcooley closed this Sep 28, 2026
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19289      +/-   ##
==========================================
- Coverage   84.22%   84.19%   -0.04%     
==========================================
  Files        3210     3173      -37     
  Lines      156567   155776     -791     
  Branches    42568    42372     -196     
==========================================
- Hits       131867   131153     -714     
+ Misses      23007    22976      -31     
+ Partials     1693     1647      -46     
Flag Coverage Δ
billing-web-unit ?
website-unit 78.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — 9db4ed69 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant