Repository navigation
test(website): raise models catalogue JS budget to 1.83MB - #19289
benjcooley wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL — review of #19289 at 9db4ed6926.
Verdict: accepted. No findings.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
- The change is one line: the
/models/whole-route ceiling inmodels-performance.spec.tsmoves from1_820_000to1_830_000. The 900 KB catalogue-delta budget (line 51) is unchanged, so the check that/models/-specific code stays small still applies. - The failure is real and deterministic. I confirmed it in CI, not just locally: #19288's
website-e2e-shard (3, 4)fails withExpected: < 1820000,Received: 1820430, and the retry measured the identical 1,820,430. That's the combined weight of #19255 and #19243 on main, not flake and not #19288's content. - Headroom: the new ceiling leaves 9,570 bytes (about 0.5%%). That's the right size for a guard, but the next feature that adds JS to
/models/will hit it again. That's intended: the next increase should also be a deliberate decision.
CI when I posted: 14 pass, 24 pending. Merge on green; once this lands, rebase the website PRs that are red on this test.
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md ⚡ Performance
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 21e7421e0bbd8d518581ab8d345070f6840243b1
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19289.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-2rgowt5fd-comfyui.vercel.app Last updated: 2026-09-28T20:50:47Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19289 +/- ##
==========================================
- Coverage 84.22% 84.19% -0.04%
==========================================
Files 3210 3173 -37
Lines 156567 155776 -791
Branches 42568 42372 -196
==========================================
- Hits 131867 131153 -714
+ Misses 23007 22976 -31
+ Partials 1693 1647 -46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
mainis 430 bytes over the/models/JavaScript budget (1,820,430 against a ceiling of 1,820,000 decoded bytes). Socatalogue browsing stays within its JavaScript budgetfails on every website PR, for example #19288. #19255 (Hub V2) and #19243 each passed against their own base, and together they cross the line.Changes
e2e/models-performance.spec.tsgoes from 1,820,000 to 1,830,000 bytes. The 900KB catalogue-delta budget is unchanged. Same approach as test(website): raise models catalogue JS budget to 1.81MB #17971.Review Focus