Skip to content

[backport core/1.55] feat(agent): tailor starter prompts to cloud and local (#19283) - #19569

Merged
christian-byrne merged 1 commit into
Comfy-Org:core/1.55from
christian-byrne:backport-19283-to-core-1.55
Sep 30, 2026
Merged

christian-byrne merged 1 commit into
Comfy-Org:core/1.55from
christian-byrne:backport-19283-to-core-1.55

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports #19283 to core/1.55.

Conflict resolution

The release branch already contains the manually backported #18991 implementation, but its test scaffolding differs from main. Conflicted test-only hunks were resolved against the release line, then the slot-ID assertions needed by this feature were applied directly. Production prompt selection, copy, localization, and telemetry types are preserved from the source PR.

Verification

  • pnpm typecheck:app
  • focused Vitest: 7 files, 270 tests passed
  • pre-push knip --cache
  • git diff --check

Source

- give Cloud prompts focused on ready-to-run creation, video, workflow
discovery, and repair
- give local/Desktop prompts focused on local GPU workflows, workflow
repair, and missing-node setup
- apply Jo's exact five Cloud and five local prompt strings from the
[example-prompts
thread](https://comfy-organization.slack.com/archives/C0A8Z4U7Y1K/p1790573450258129)
- preserve the five stable telemetry slots from Comfy-Org#18991 so copy changes
remain measurable

This is stacked on Comfy-Org#18991 (starter-prompt click and send attribution);
merge that PR first.

Exact head: `acf46b77f9e7f6242dd5d2bb25eaeac66dca1bf6`

- application unit suite: 1,707 files; 24,337 passed, 32 expected-fail,
7 skipped (24,376 total) —
[run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36487711019)
- Cloud Playwright: 454 tests; 452 passed, 1 skipped, 1 unrelated flaky
retry in `agentRateLimitDuplicateSubmit.spec.ts` —
[job](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36487711311/job/109152438679)
- full rollup: 95 successful checks, 14 intentional skips, 0 failed,
cancelled, or pending
- focused local verification: 4 files, 326 passed; application/browser
typecheck, ESLint, formatting, Knip, Fallow, and `git diff --check` all
passed

The ten prompt strings match Jo's approved Slack copy byte-for-byte. The
stable IDs remain `generate_image`, `list_workflows`, `find_workflow`,
`explain_selected_node`, and `build_video_workflow`.

human approval and must land before this stacked PR can merge.

---------

Co-authored-by: jojodecayz <121620462+jojodecayz@users.noreply.github.com>
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: b11c8b07-97bb-4a7e-b132-c2db34a05fea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne merged commit dd3a880 into Comfy-Org:core/1.55 Sep 30, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant