Repository navigation
[backport core/1.55] feat(agent): tailor starter prompts to cloud and local (#19283) - #19569
Merged
christian-byrne merged 1 commit intoSep 30, 2026
Conversation
- give Cloud prompts focused on ready-to-run creation, video, workflow discovery, and repair - give local/Desktop prompts focused on local GPU workflows, workflow repair, and missing-node setup - apply Jo's exact five Cloud and five local prompt strings from the [example-prompts thread](https://comfy-organization.slack.com/archives/C0A8Z4U7Y1K/p1790573450258129) - preserve the five stable telemetry slots from Comfy-Org#18991 so copy changes remain measurable This is stacked on Comfy-Org#18991 (starter-prompt click and send attribution); merge that PR first. Exact head: `acf46b77f9e7f6242dd5d2bb25eaeac66dca1bf6` - application unit suite: 1,707 files; 24,337 passed, 32 expected-fail, 7 skipped (24,376 total) — [run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36487711019) - Cloud Playwright: 454 tests; 452 passed, 1 skipped, 1 unrelated flaky retry in `agentRateLimitDuplicateSubmit.spec.ts` — [job](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36487711311/job/109152438679) - full rollup: 95 successful checks, 14 intentional skips, 0 failed, cancelled, or pending - focused local verification: 4 files, 326 passed; application/browser typecheck, ESLint, formatting, Knip, Fallow, and `git diff --check` all passed The ten prompt strings match Jo's approved Slack copy byte-for-byte. The stable IDs remain `generate_image`, `list_workflows`, `find_workflow`, `explain_selected_node`, and `build_video_workflow`. human approval and must land before this stacked PR can merge. --------- Co-authored-by: jojodecayz <121620462+jojodecayz@users.noreply.github.com> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports #19283 to
core/1.55.Conflict resolution
The release branch already contains the manually backported #18991 implementation, but its test scaffolding differs from
main. Conflicted test-only hunks were resolved against the release line, then the slot-ID assertions needed by this feature were applied directly. Production prompt selection, copy, localization, and telemetry types are preserved from the source PR.Verification
pnpm typecheck:appknip --cachegit diff --checkSource