Skip to content

[backport core/1.54] Tailor starter prompts to cloud and local (#19283) - #19567

Merged
christian-byrne merged 1 commit into
Comfy-Org:core/1.54from
christian-byrne:backport-19283-to-core-1.54
Sep 30, 2026
Merged

christian-byrne merged 1 commit into
Comfy-Org:core/1.54from
christian-byrne:backport-19283-to-core-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #19283 to core/1.54.

This gives cloud and local distributions distinct starter-prompt sets, replaces semantic prompt telemetry IDs with stable slot IDs, and keeps the experiment instrumentation aligned across the composer and empty state.

Conflict resolution preserved the release branch’s older test structure and applied the source PR’s localized prompt and slot-ID assertions without importing unrelated newer test scaffolding.

Source commit for review: d60b4bb

Validation:

  • 74 focused unit tests passed across starter prompts, empty state, draft submission, composer, and composer store
  • focused AgentPanel localized-prompt test passed
  • formatting check passed for all 14 changed source/data files
  • locale structure check passed (new English strings correctly reported pending translation in non-English locales)
  • focused AgentPanelRoot telemetry assertion is currently blocked by an inherited core/1.54 test-fixture failure: the branch’s billing mock does not provide billingType required by the already-landed exhaustion logic

@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 322a7d34-33ae-46b9-8df6-ae422e1b4d83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne merged commit fd6782b into Comfy-Org:core/1.54 Sep 30, 2026
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant