Skip to content

[backport cloud/1.54] feat(agent): tailor starter prompts to cloud and local (#19283) - #19568

Merged
christian-byrne merged 1 commit into
Comfy-Org:cloud/1.54from
christian-byrne:backport-19283-to-cloud-1.54
Sep 30, 2026
Merged

christian-byrne merged 1 commit into
Comfy-Org:cloud/1.54from
christian-byrne:backport-19283-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports #19283 (tailors the five starter prompts for Cloud versus local/Desktop while retaining stable telemetry slots) to cloud/1.54.

Source merge: d60b4bbf9d
Backport commit: 6fff5464ee

Conflict resolution

Three conflicts were confined to tests whose harnesses have advanced on main. The backport preserves the cloud/1.54 test structure and applies the source PR’s localized prompt lookup and stable slot_2 telemetry expectations. Production feature files applied cleanly.

Verification

  • 6 focused test files: 472 passed
  • oxfmt --check on all changed supported files: passed
  • git diff --check: passed
  • pre-push Knip check: passed

Review

Review the complete backport diff

- give Cloud prompts focused on ready-to-run creation, video, workflow
discovery, and repair
- give local/Desktop prompts focused on local GPU workflows, workflow
repair, and missing-node setup
- apply Jo's exact five Cloud and five local prompt strings from the
[example-prompts
thread](https://comfy-organization.slack.com/archives/C0A8Z4U7Y1K/p1790573450258129)
- preserve the five stable telemetry slots from Comfy-Org#18991 so copy changes
remain measurable

This is stacked on Comfy-Org#18991 (starter-prompt click and send attribution);
merge that PR first.

Exact head: `acf46b77f9e7f6242dd5d2bb25eaeac66dca1bf6`

- application unit suite: 1,707 files; 24,337 passed, 32 expected-fail,
7 skipped (24,376 total) —
[run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36487711019)
- Cloud Playwright: 454 tests; 452 passed, 1 skipped, 1 unrelated flaky
retry in `agentRateLimitDuplicateSubmit.spec.ts` —
[job](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36487711311/job/109152438679)
- full rollup: 95 successful checks, 14 intentional skips, 0 failed,
cancelled, or pending
- focused local verification: 4 files, 326 passed; application/browser
typecheck, ESLint, formatting, Knip, Fallow, and `git diff --check` all
passed

The ten prompt strings match Jo's approved Slack copy byte-for-byte. The
stable IDs remain `generate_image`, `list_workflows`, `find_workflow`,
`explain_selected_node`, and `build_video_workflow`.

human approval and must land before this stacked PR can merge.

---------

Co-authored-by: jojodecayz <121620462+jojodecayz@users.noreply.github.com>
Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 3463f75f-a057-432d-8e5e-97a4f3022e73

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne merged commit bc4c5fa into Comfy-Org:cloud/1.54 Sep 30, 2026
26 of 29 checks passed
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19568   +/-   ##
=============================================
  Coverage              ?   79.16%           
=============================================
  Files                 ?     2031           
  Lines                 ?   113898           
  Branches              ?    34366           
=============================================
  Hits                  ?    90171           
  Misses                ?    23547           
  Partials              ?      180           
Flag Coverage Δ
unit 79.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/i18n.ts 97.39% <100.00%> (ø)
src/platform/telemetry/types.ts 97.91% <ø> (ø)
...h/extensions/agent/components/agent/EmptyState.vue 100.00% <100.00%> (ø)
...workbench/extensions/agent/utils/starterPrompts.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant