Repository navigation
[backport cloud/1.54] feat(agent): tailor starter prompts to cloud and local (#19283) - #19568
Conversation
- give Cloud prompts focused on ready-to-run creation, video, workflow discovery, and repair - give local/Desktop prompts focused on local GPU workflows, workflow repair, and missing-node setup - apply Jo's exact five Cloud and five local prompt strings from the [example-prompts thread](https://comfy-organization.slack.com/archives/C0A8Z4U7Y1K/p1790573450258129) - preserve the five stable telemetry slots from Comfy-Org#18991 so copy changes remain measurable This is stacked on Comfy-Org#18991 (starter-prompt click and send attribution); merge that PR first. Exact head: `acf46b77f9e7f6242dd5d2bb25eaeac66dca1bf6` - application unit suite: 1,707 files; 24,337 passed, 32 expected-fail, 7 skipped (24,376 total) — [run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36487711019) - Cloud Playwright: 454 tests; 452 passed, 1 skipped, 1 unrelated flaky retry in `agentRateLimitDuplicateSubmit.spec.ts` — [job](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36487711311/job/109152438679) - full rollup: 95 successful checks, 14 intentional skips, 0 failed, cancelled, or pending - focused local verification: 4 files, 326 passed; application/browser typecheck, ESLint, formatting, Knip, Fallow, and `git diff --check` all passed The ten prompt strings match Jo's approved Slack copy byte-for-byte. The stable IDs remain `generate_image`, `list_workflows`, `find_workflow`, `explain_selected_node`, and `build_video_workflow`. human approval and must land before this stacked PR can merge. --------- Co-authored-by: jojodecayz <121620462+jojodecayz@users.noreply.github.com> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19568 +/- ##
=============================================
Coverage ? 79.16%
=============================================
Files ? 2031
Lines ? 113898
Branches ? 34366
=============================================
Hits ? 90171
Misses ? 23547
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports #19283 (tailors the five starter prompts for Cloud versus local/Desktop while retaining stable telemetry slots) to
cloud/1.54.Source merge:
d60b4bbf9dBackport commit:
6fff5464eeConflict resolution
Three conflicts were confined to tests whose harnesses have advanced on
main. The backport preserves thecloud/1.54test structure and applies the source PR’s localized prompt lookup and stableslot_2telemetry expectations. Production feature files applied cleanly.Verification
oxfmt --checkon all changed supported files: passedgit diff --check: passedReview
Review the complete backport diff