Repository navigation
feat(agent): use the confirmed Cloud and local starter prompt copy - #19310
jojodecayz merged 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
No code change needed for this one — the skip is expected and the base branch is deliberate. This is the third PR in a stack: #18991 (
@coderabbitai review |
At the panel's default width (PANEL_MIN_WIDTH, 420px) "Find an image-to-video workflow that works on my GPU" needed 375px in a 344px label box, so it ellipsized to "…workflow that works o…" and cut off the GPU — the part doing the work. Kai's shorter line measures 304px and fits, and with it all five local chips render in full at the default width. The slot ids stay exactly as they are. Per Christian, #18991 measures the same five positions across copy and distribution variants, so identity is positional by design and `prompt_text_hash` is what separates one wording from the next. This is a copy variant under a stable slot, which is the case that design was built for.
176edbd to
1dcd974
Compare
|
| text | label box | result | |
|---|---|---|---|
| before | 375px | 344px | ellipsized — …workflow that works o…, cutting the GPU part |
| after | 304px | 304px | fits |
With this change all five local chips render in full at the default width.
Verification
EmptyState.test.ts,starterPrompts.test.ts,AgentPanel.test.ts,AgentPanelRoot.test.ts— 326 passedpnpm typecheck·pnpm typecheck:browser·format:check— clean- Rendered the local build in a real browser and measured the before/after strings in the same slot at 420px
One thing worth a separate look
The chip icons on the base branch are still the ones chosen for the original pre-split prompts, and no longer match the approved copy — a list icon beside "An image-to-video workflow…", a search icon beside "Explain the selected nodes", a speech bubble beside "Help me install the missing nodes", and a workflow icon beside "Fix the errors in this workflow". Not touched here to keep this the single-slot change it claims to be. Happy to open a separate PR if you want it fixed.
Screenshots
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since acf46b77f9e7f6242dd5d2bb25eaeac66dca1bf6
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2140 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T23:24:44.530Z",
"gitSha": "9562a8abfa622586b919dc4b77fc34fc79c0e3e9",
"branch": "glary/agent-starter-prompt-copy",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.9970000000026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1309999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.706,
"heapDeltaBytes": 8860012,
"heapUsedBytes": 71097216,
"domNodes": -228,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.532000000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1993.112999999994,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9759999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.163,
"heapDeltaBytes": -6811208,
"heapUsedBytes": 55710120,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.750999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1686.2650000000485,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.523000000000001,
"layouts": 12,
"layoutDurationMs": 3.9709999999999996,
"taskDurationMs": 663.597,
"heapDeltaBytes": 3472164,
"heapUsedBytes": 70687816,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 122.458,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.6340000000646,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.725999999999999,
"layouts": 12,
"layoutDurationMs": 3.5449999999999995,
"taskDurationMs": 647.106,
"heapDeltaBytes": 6944784,
"heapUsedBytes": 69478692,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 122.67300000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.2569999999796,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.846,
"layouts": 6,
"layoutDurationMs": 1.163,
"taskDurationMs": 259.95,
"heapDeltaBytes": 2210468,
"heapUsedBytes": 64633956,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.974,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.4900000000498,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.045,
"layouts": 6,
"layoutDurationMs": 0.9910000000000001,
"taskDurationMs": 258.26300000000003,
"heapDeltaBytes": 2202768,
"heapUsedBytes": 64831448,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.222,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 550.0979999999913,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.4859999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.797,
"heapDeltaBytes": 18432164,
"heapUsedBytes": 80897456,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 137.428,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 534.909999999968,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.770000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.916,
"heapDeltaBytes": 18163216,
"heapUsedBytes": 80697324,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 137.515,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1051.0590000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.7179999999998,
"heapDeltaBytes": -14281244,
"heapUsedBytes": 71990228,
"domNodes": -259,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 49.085,
"eventListeners": -207,
"totalBlockingTimeMs": 407,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1012.1169999999893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.725,
"heapDeltaBytes": 34462484,
"heapUsedBytes": 101180152,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 51.306000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 405,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 768.0280000000153,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.606,
"heapDeltaBytes": 14880612,
"heapUsedBytes": 90022880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.66200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 163,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.6729999999452,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.8080000000002,
"heapDeltaBytes": 14961336,
"heapUsedBytes": 90667924,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.91500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7546.289000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6727.8820000000005,
"heapDeltaBytes": -2341416,
"heapUsedBytes": 81018428,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 5424.232,
"eventListeners": 0,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6367.947000000072,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5853.734,
"heapDeltaBytes": 10377244,
"heapUsedBytes": 92843776,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 4859.376,
"eventListeners": 0,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7264.952999999991,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.562,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6438.348,
"heapDeltaBytes": 13307964,
"heapUsedBytes": 90393948,
"domNodes": -228,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5167.794,
"eventListeners": -164,
"totalBlockingTimeMs": 68,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7144.629000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6445.179999999999,
"heapDeltaBytes": 19968648,
"heapUsedBytes": 95617856,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 5173.051,
"eventListeners": 0,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2024.9999999999773,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9310000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.26499999999993,
"heapDeltaBytes": -13865612,
"heapUsedBytes": 73291420,
"domNodes": -228,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 28.898999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.8640000000223,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8240000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.9169999999999,
"heapDeltaBytes": -13631072,
"heapUsedBytes": 73110784,
"domNodes": -228,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 29.565,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2144.437000000039,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.572999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1331.115,
"heapDeltaBytes": -1339716,
"heapUsedBytes": 80848808,
"domNodes": -198,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 685.8349999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2151.5340000000833,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1319.016,
"heapDeltaBytes": 9194220,
"heapUsedBytes": 92141372,
"domNodes": -230,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 658.4830000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3168.245000000013,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.580999999999998,
"layouts": 60,
"layoutDurationMs": 13.270999999999999,
"taskDurationMs": 1351.627,
"heapDeltaBytes": 7398704,
"heapUsedBytes": 73736296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 636.078,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3222.0539999999573,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.618,
"layouts": 60,
"layoutDurationMs": 13.447000000000001,
"taskDurationMs": 1417.2439999999997,
"heapDeltaBytes": -9596132,
"heapUsedBytes": 74217044,
"domNodes": -228,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 633.915,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2463.961999999981,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.419000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1597.569,
"heapDeltaBytes": -8610252,
"heapUsedBytes": 74937092,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 810.093,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2241.2180000000035,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.807999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1526.9740000000002,
"heapDeltaBytes": 17242672,
"heapUsedBytes": 83694828,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 777.5060000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.197999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4700000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.4210000000001,
"heapDeltaBytes": -9610780,
"heapUsedBytes": 72441652,
"domNodes": -228,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 28.317999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.4949999999399,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5850000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.57899999999995,
"heapDeltaBytes": -13933376,
"heapUsedBytes": 73955004,
"domNodes": -228,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 29.106000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.7510000000093,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.697999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.904,
"heapDeltaBytes": 13682608,
"heapUsedBytes": 77428092,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 123.781,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 504.87199999997756,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.084999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.91999999999996,
"heapDeltaBytes": 13509812,
"heapUsedBytes": 77333204,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 115.938,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1991.6299999999865,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.103999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.80199999999996,
"heapDeltaBytes": 11651300,
"heapUsedBytes": 75191916,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.574,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.3729999999732,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.688,
"heapDeltaBytes": 14458464,
"heapUsedBytes": 77939696,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.792999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.141000000002,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.516,
"layouts": 16,
"layoutDurationMs": 4.9239999999999995,
"taskDurationMs": 615.058,
"heapDeltaBytes": 5609968,
"heapUsedBytes": 75285872,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 85.30600000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.2269999999553,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.809,
"layouts": 16,
"layoutDurationMs": 4.831,
"taskDurationMs": 622.3910000000001,
"heapDeltaBytes": 5601948,
"heapUsedBytes": 75300056,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 88.13799999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.1810000000205,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.580000000000002,
"layouts": 5,
"layoutDurationMs": 9.158000000000001,
"taskDurationMs": 686.356,
"heapDeltaBytes": 21677116,
"heapUsedBytes": 103769984,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.346999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 87,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.037000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.272999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4590.072,
"heapDeltaBytes": 9112860,
"heapUsedBytes": 89553388,
"domNodes": -228,
"jsHeapTotalBytes": 5459968,
"scriptDurationMs": 2211.8129999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8163.362000000006,
"styleRecalcs": 252,
"styleRecalcDurationMs": 34.499,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4533.021000000001,
"heapDeltaBytes": -20836628,
"heapUsedBytes": 66190940,
"domNodes": -228,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 2171.394,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14006.820000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13701.024,
"heapDeltaBytes": -35534888,
"heapUsedBytes": 178489224,
"domNodes": -8049,
"jsHeapTotalBytes": -13615104,
"scriptDurationMs": 217.745,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14216.249000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13674.899,
"heapDeltaBytes": -21035480,
"heapUsedBytes": 192351388,
"domNodes": -8049,
"jsHeapTotalBytes": -11517952,
"scriptDurationMs": 199.37099999999998,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16934.81900000006,
"styleRecalcs": 118,
"styleRecalcDurationMs": 13.730999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16698.349000000002,
"heapDeltaBytes": -56175860,
"heapUsedBytes": 180894576,
"domNodes": -8049,
"jsHeapTotalBytes": -16101376,
"scriptDurationMs": 707.009,
"eventListeners": -14923,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14007.544000000053,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.81299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13258.23,
"heapDeltaBytes": -46992908,
"heapUsedBytes": 174786840,
"domNodes": -8049,
"jsHeapTotalBytes": -6610944,
"scriptDurationMs": 658.2679999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5111.614000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.49499999999999,
"layouts": 20,
"layoutDurationMs": 21.184999999999995,
"taskDurationMs": 5087.465,
"heapDeltaBytes": -40480884,
"heapUsedBytes": 178907016,
"domNodes": -8049,
"jsHeapTotalBytes": 18534400,
"scriptDurationMs": 85.076,
"eventListeners": -14923,
"totalBlockingTimeMs": 209,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5108.693000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.42099999999997,
"layouts": 20,
"layoutDurationMs": 20.721000000000004,
"taskDurationMs": 5021.56,
"heapDeltaBytes": -39782704,
"heapUsedBytes": 197164136,
"domNodes": -8049,
"jsHeapTotalBytes": 17715200,
"scriptDurationMs": 83.149,
"eventListeners": -14923,
"totalBlockingTimeMs": 166,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7099.3310000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6930.392999999999,
"heapDeltaBytes": -719384,
"heapUsedBytes": 178117060,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 97.55600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7120.997999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6895.705,
"heapDeltaBytes": 23688436,
"heapUsedBytes": 188297744,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 95.70800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 85.32200000001922,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.365,
"layouts": 3,
"layoutDurationMs": 0.874,
"taskDurationMs": 68.292,
"heapDeltaBytes": 3266096,
"heapUsedBytes": 65241092,
"domNodes": 98,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.586,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 439.9839999999813,
"styleRecalcs": 15,
"styleRecalcDurationMs": 15.688,
"layouts": 4,
"layoutDurationMs": 1.621,
"taskDurationMs": 96.40499999999999,
"heapDeltaBytes": 4966596,
"heapUsedBytes": 66630160,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.197000000000003,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## feat/agent-distribution-starter-prompts #19310 +/- ##
==========================================================================
Coverage 84.92% 84.93%
==========================================================================
Files 2309 2309
Lines 132906 132906
Branches 35915 34008 -1907
==========================================================================
+ Hits 112870 112878 +8
+ Misses 19724 19716 -8
Partials 312 312
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
The shortened local image-to-video chip renders in full at the default panel width, keeps the existing positional telemetry identity, and the focused component suite passes (10/10). No blocking findings.
suggestion: The superseding PR comment says all five local chips now render in full, but its attached screenshot still shows “Help me install the missing nodes for this wor…” truncated. That is pre-existing and outside this two-line change, so it does not block this PR, but the verification note should be corrected or tracked separately.
|
@dante01yoon Good catch — thank you. You're right that the screenshot contradicted the sentence it was attached to. The claim is correct but the evidence wasn't, and that's my error. No code change; correcting the record. What went wrong: that screenshot was captured from the Storybook story, whose decorator pins the panel to Why 420px is the right width to judge against — 400px isn't reachable in the product. From const PANEL_MIN_WIDTH = 420
const width = ref(PANEL_MIN_WIDTH)
function setWidth(px: number): void {
width.value = Math.min(PANEL_MAX_WIDTH, Math.max(PANEL_MIN_WIDTH, px))
}
Re-measured on the rendered DOM at 420px — nothing ellipsizes:
Replacement screenshot attached, taken at 420px, showing slot 3 in full. This also retracts an earlier false alarm of mine. In the Slack thread I flagged "Help me install the missing nodes…" to @kai as truncating and worth shortening. That was the same 400px artifact — it does not truncate at any width the panel can reach, so there's nothing to track or follow up. Sorry for the noise. The verification note should read: at the panel's minimum and default width of 420px, all five local chips render in full. Screenshots |
0494355
into
feat/agent-distribution-starter-prompts
…19310) ## Summary Shortens the second local/Desktop starter prompt so its full capability hint fits at the panel's default width: ```diff - Find an image-to-video workflow that works on my GPU + An image-to-video workflow that fits my GPU ``` This is a stacked, copy-only follow-up: #19310 → #19283 → #18991. Merge the parent instrumentation PR #18991 first, then the Cloud/local copy PR #19283, then this PR. ## Scope - Changes `src/locales/en/main.json` and the matching `EmptyState.test.ts` fixture only (2 insertions, 2 deletions). - Preserves the five stable positional `AgentStarterPromptId` values from #18991 byte-for-byte: `generate_image`, `list_workflows`, `find_workflow`, `explain_selected_node`, and `build_video_workflow`. - Does not add contextual prompt selection, distribution-scoped IDs, flags, allocation, or telemetry-contract changes. Jo approved the shortened line in the example-prompts Slack thread after the original local copy ellipsized at the default panel width. The rendered measurement reported on this PR is 304 px for the approved line versus 375 px for the prior line in a 344 px label box. ## Verification At exact head `1dcd9740db5c19eeb14643f3ef753fbdfea48102`, the complete GitHub matrix is terminal green: **95 successful checks, 15 intentional skips, and 0 failed, cancelled, queued, or running checks**. The focused local verification published with the change is 326 passing tests across the four affected Agent files, plus clean `typecheck`, `typecheck:browser`, and format checks. The full matrix independently covers unit, browser, ecosystem, lint/typecheck, security, performance, Storybook, and affected web suites. ## Review and merge gate `dante01yoon` is the named human reviewer across this stack. This PR is ready for review, but remains parent-first: #18991 and #19283 must be approved and land before #19310 can merge. Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>


Summary
Shortens the second local/Desktop starter prompt so its full capability hint fits at the panel's default width:
This is a stacked, copy-only follow-up: #19310 → #19283 → #18991. Merge the parent instrumentation PR #18991 first, then the Cloud/local copy PR #19283, then this PR.
Scope
src/locales/en/main.jsonand the matchingEmptyState.test.tsfixture only (2 insertions, 2 deletions).AgentStarterPromptIdvalues from feat(agent): instrument starter-prompt clicks, and attribute the send they produce #18991 byte-for-byte:generate_image,list_workflows,find_workflow,explain_selected_node, andbuild_video_workflow.Jo approved the shortened line in the example-prompts Slack thread after the original local copy ellipsized at the default panel width. The rendered measurement reported on this PR is 304 px for the approved line versus 375 px for the prior line in a 344 px label box.
Verification
At exact head
1dcd9740db5c19eeb14643f3ef753fbdfea48102, the complete GitHub matrix is terminal green: 95 successful checks, 15 intentional skips, and 0 failed, cancelled, queued, or running checks.The focused local verification published with the change is 326 passing tests across the four affected Agent files, plus clean
typecheck,typecheck:browser, and format checks. The full matrix independently covers unit, browser, ecosystem, lint/typecheck, security, performance, Storybook, and affected web suites.Review and merge gate
dante01yoonis the named human reviewer across this stack. This PR is ready for review, but remains parent-first: #18991 and #19283 must be approved and land before #19310 can merge.