Repository navigation
[backport core/1.55] fix(agent): show onboarding after first scoped consent (#19061) - #19083
Conversation
- Preserve legacy device-wide onboarding migration for scopes that already accepted consent. - Do not consume that legacy flag for a new scope before its first consent; clicking Start now shows the scoped coach once. - Cover both new-consent and already-consented migration paths. Linear: PM-1301, PM-1308 Replaces the repro-only #18094 with the confirmed fix. - `pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` (309 passed) - Full `pnpm typecheck:app` via pre-commit - ESLint, oxlint, stylelint, and oxfmt via pre-commit Justification: narrow state-migration fix with focused regression coverage; requested as part of the PM-1308 thread takeover.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6ddb354bba1dd2af8d906003c720ec37ae716682
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T07:58:31.749Z",
"gitSha": "668615b6b3d6e3865b9e9d1955b3bd8710657dd3",
"branch": "backport-19061-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.9390000000121,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.696,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.13599999999997,
"heapDeltaBytes": 8047580,
"heapUsedBytes": 75553088,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.631,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2007.885999999985,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.538,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.912,
"heapDeltaBytes": -7105048,
"heapUsedBytes": 60495660,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.377000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.008000000022,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 798.55,
"heapDeltaBytes": 12321148,
"heapUsedBytes": 79921268,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 161.76399999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.6359999999713,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.632,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.936,
"heapDeltaBytes": -5544616,
"heapUsedBytes": 62327576,
"domNodes": -261,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 164.99,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.7059999999528,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.499,
"layouts": 6,
"layoutDurationMs": 1.035,
"taskDurationMs": 342.08099999999996,
"heapDeltaBytes": 3143192,
"heapUsedBytes": 70979084,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.827,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0779999999495,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.767,
"layouts": 6,
"layoutDurationMs": 1.105,
"taskDurationMs": 325.758,
"heapDeltaBytes": 3099748,
"heapUsedBytes": 71061420,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.487,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 643.271000000027,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.072000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.63000000000005,
"heapDeltaBytes": 18551368,
"heapUsedBytes": 86002300,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 173.637,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 627.8819999999996,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.99099999999993,
"heapDeltaBytes": 18159980,
"heapUsedBytes": 85988496,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.777,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.5049999999546,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 855.527,
"heapDeltaBytes": 35334584,
"heapUsedBytes": 100344972,
"domNodes": -265,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 75.512,
"eventListeners": -195,
"totalBlockingTimeMs": 573,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1222.4120000000767,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 918.5970000000001,
"heapDeltaBytes": -17621004,
"heapUsedBytes": 72920104,
"domNodes": -297,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 71.70899999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 563,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.3600000000183,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.98200000000014,
"heapDeltaBytes": 14669016,
"heapUsedBytes": 90991328,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.06000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.1420000000526,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.6639999999996,
"heapDeltaBytes": 14812344,
"heapUsedBytes": 90219872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.41300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11164.250999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10182.077,
"heapDeltaBytes": 14100160,
"heapUsedBytes": 96134096,
"domNodes": -18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8658.367,
"eventListeners": 0,
"totalBlockingTimeMs": 1616,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11095.640000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10196.471000000001,
"heapDeltaBytes": 12631652,
"heapUsedBytes": 94788848,
"domNodes": -18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8437.555,
"eventListeners": 0,
"totalBlockingTimeMs": 1347,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10459.26499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9652.905,
"heapDeltaBytes": -8924664,
"heapUsedBytes": 73147104,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7927.064,
"eventListeners": 0,
"totalBlockingTimeMs": 1029,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10432.783000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9563.762999999999,
"heapDeltaBytes": -7679772,
"heapUsedBytes": 68783656,
"domNodes": -12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7879.527,
"eventListeners": 0,
"totalBlockingTimeMs": 1016,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2050.9530000000495,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.5889999999999,
"heapDeltaBytes": -2779288,
"heapUsedBytes": 83648068,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 36.914,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.7449999999817,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.926,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.52900000000005,
"heapDeltaBytes": -3283116,
"heapUsedBytes": 83607444,
"domNodes": -240,
"jsHeapTotalBytes": -2068480,
"scriptDurationMs": 34.372,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2803.0800000000227,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1829.2489999999998,
"heapDeltaBytes": 26729696,
"heapUsedBytes": 91494672,
"domNodes": -247,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 993.773,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2308.8020000000142,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.822000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1699.7700000000002,
"heapDeltaBytes": -11541700,
"heapUsedBytes": 75523820,
"domNodes": -218,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 896.766,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3576.3489999999365,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.584000000000001,
"layouts": 60,
"layoutDurationMs": 14.104999999999999,
"taskDurationMs": 1665.447,
"heapDeltaBytes": 7759020,
"heapUsedBytes": 73705360,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 857.91,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3538.0539999999883,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.632000000000003,
"layouts": 60,
"layoutDurationMs": 13.457999999999998,
"taskDurationMs": 1674.8709999999999,
"heapDeltaBytes": 9814132,
"heapUsedBytes": 99061760,
"domNodes": 14,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 793.794,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3128.771000000029,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.522999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1956.266,
"heapDeltaBytes": 22028556,
"heapUsedBytes": 88180500,
"domNodes": 4,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 988.882,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3118.612999999982,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.142999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1929.5900000000001,
"heapDeltaBytes": 25539956,
"heapUsedBytes": 91599072,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 994.1809999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.518000000091,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.632,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.021,
"heapDeltaBytes": -4418308,
"heapUsedBytes": 84163964,
"domNodes": -245,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.037,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2016.0759999999982,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.333000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.4689999999999,
"heapDeltaBytes": -4688976,
"heapUsedBytes": 83984744,
"domNodes": -249,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.398999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.6629999999877,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.113000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.62699999999995,
"heapDeltaBytes": 13779312,
"heapUsedBytes": 83651652,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.865,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.9679999999607,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.442999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.27,
"heapDeltaBytes": 13655536,
"heapUsedBytes": 83604396,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 147.397,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.274000000009,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.690000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.30600000000004,
"heapDeltaBytes": -5183000,
"heapUsedBytes": 64775220,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.838000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.9129999999877,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.176,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.7530000000001,
"heapDeltaBytes": 6386360,
"heapUsedBytes": 76306428,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.995999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.675999999955,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.153000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.313,
"heapDeltaBytes": 9713664,
"heapUsedBytes": 79178208,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 109.23399999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.2530000000133,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.845999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.641,
"heapDeltaBytes": 9849452,
"heapUsedBytes": 79659636,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 110.89099999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.9410000000262,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.809,
"layouts": 5,
"layoutDurationMs": 12.873000000000003,
"taskDurationMs": 949.205,
"heapDeltaBytes": -6297624,
"heapUsedBytes": 81132596,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 31.308999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8542.614999999954,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.088,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6091.986,
"heapDeltaBytes": -5855872,
"heapUsedBytes": 80844812,
"domNodes": -242,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2878.214,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8324.787000000015,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.559,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5275.995,
"heapDeltaBytes": -10739472,
"heapUsedBytes": 76124260,
"domNodes": -244,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2900.382,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17282.126999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16818.317,
"heapDeltaBytes": -70315396,
"heapUsedBytes": 170854780,
"domNodes": -8061,
"jsHeapTotalBytes": -18026496,
"scriptDurationMs": 267.177,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16868.90799999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16432.088999999996,
"heapDeltaBytes": -62248548,
"heapUsedBytes": 175840592,
"domNodes": -8061,
"jsHeapTotalBytes": -19595264,
"scriptDurationMs": 290.13,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21053.398000000016,
"styleRecalcs": 158,
"styleRecalcDurationMs": 18.088999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20765.635,
"heapDeltaBytes": -57503224,
"heapUsedBytes": 180859892,
"domNodes": -8061,
"jsHeapTotalBytes": -17043456,
"scriptDurationMs": 949.5089999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21098.200999999903,
"styleRecalcs": 153,
"styleRecalcDurationMs": 19.613999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20914.536,
"heapDeltaBytes": -50522816,
"heapUsedBytes": 189534108,
"domNodes": -8061,
"jsHeapTotalBytes": -18051072,
"scriptDurationMs": 914.363,
"eventListeners": -14928,
"totalBlockingTimeMs": 49,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5917.454000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.63900000000001,
"layouts": 20,
"layoutDurationMs": 22.907999999999998,
"taskDurationMs": 5810.082,
"heapDeltaBytes": -5621956,
"heapUsedBytes": 195338996,
"domNodes": -632,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 106.573,
"eventListeners": 0,
"totalBlockingTimeMs": 423,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4968.440999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.85999999999999,
"layouts": 20,
"layoutDurationMs": 25.343000000000004,
"taskDurationMs": 4911.776,
"heapDeltaBytes": -27896400,
"heapUsedBytes": 199907412,
"domNodes": -8061,
"jsHeapTotalBytes": 18411520,
"scriptDurationMs": 155.538,
"eventListeners": -14928,
"totalBlockingTimeMs": 222,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8693.733000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8390.691,
"heapDeltaBytes": -22983528,
"heapUsedBytes": 165016696,
"domNodes": 0,
"jsHeapTotalBytes": -28049408,
"scriptDurationMs": 129.52000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8837.928000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8720.591,
"heapDeltaBytes": -5853660,
"heapUsedBytes": 176050572,
"domNodes": 0,
"jsHeapTotalBytes": -30408704,
"scriptDurationMs": 198.22300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 108.60800000000381,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.309,
"layouts": 3,
"layoutDurationMs": 1.7650000000000001,
"taskDurationMs": 88.95299999999997,
"heapDeltaBytes": 3157028,
"heapUsedBytes": 68782744,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.377,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 473.8670000000411,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.324,
"layouts": 3,
"layoutDurationMs": 1.538,
"taskDurationMs": 131.483,
"heapDeltaBytes": 5023440,
"heapUsedBytes": 70715836,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.077,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19083 +/- ##
==========================================
Coverage 84.60% 84.61%
==========================================
Files 2298 2298
Lines 131671 131671
Branches 35560 35560
==========================================
+ Hits 111403 111411 +8
+ Misses 19954 19946 -8
Partials 314 314
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against #19061 before approving: identical file list, no conflict markers in the diff. All three required checks green.
…consent (#19061) (#19084) Backport of #19061 to `cloud/1.55`. Same conflict/resolution as #19083 (the core/1.55 backport): the automated backport hit a merge conflict in `AgentPanelRoot.test.ts` because `cloud/1.55` also lacks the unrelated, unbackported "replay tour from header" (`Take the tour` button) feature whose tests sat as unchanged context around #19061's own new tests in the merge-commit diff. Resolved by keeping only the two tests #19061 actually added and dropping the two tests belonging to that unbackported feature. Verified on this branch: - `pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 260 passed - `pnpm exec vue-tsc --noEmit` — clean - lint-staged (oxfmt/oxlint/eslint) via commit hook — clean <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729?thread_ts=1789700733.927729&cid=C0BGH348Z0C)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1 --- _Generated by [Claude Code](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1)_ Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Backport of #19061 to
core/1.55.The automated backport (label-driven) hit a merge conflict in
AgentPanelRoot.test.tsbecausecore/1.55lacks an unrelated, unbackported feature ("replay tour from header" / theTake the tourbutton) whose test bodies sat as unchanged context around #19061's own new tests in the merge-commit diff. Manually resolved by keeping only the two tests #19061 actually added (shows the scoped coach after first consent despite a legacy seen flag,still carries the legacy seen flag for an already-consented scope) and dropping the two tests belonging to that unbackported feature, which do not apply here (their target UI, theTake the tourbutton, does not exist oncore/1.55).Verified on this branch:
pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts— 260 passedpnpm exec vue-tsc --noEmit— cleanRequested by Christian Byrne · Slack thread
🤖 Generated with Claude Code
https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1
Generated by Claude Code