Repository navigation
[backport cloud/1.54] fix(agent): show onboarding after first scoped consent (#19061) - #19070
Conversation
- Preserve legacy device-wide onboarding migration for scopes that already accepted consent. - Do not consume that legacy flag for a new scope before its first consent; clicking Start now shows the scoped coach once. - Cover both new-consent and already-consented migration paths. Linear: PM-1301, PM-1308 Replaces the repro-only #18094 with the confirmed fix. - `pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` (309 passed) - Full `pnpm typecheck:app` via pre-commit - ESLint, oxlint, stylelint, and oxfmt via pre-commit Justification: narrow state-migration fix with focused regression coverage; requested as part of the PM-1308 thread takeover.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe onboarding-key watcher now adopts the legacy completion flag only when consent has been accepted. Tests cover behavior before and after consent. ChangesOnboarding flag adoption
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains from the reviewed changes. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR contains bug-fix signals: the title and commit subject use "fix". It changes
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1956 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-27T06:31:22.447Z",
"gitSha": "22eb8ce751bf8cd7a7e6eb67fe124da7ca7d47a2",
"branch": "backport-19061-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.7079999999903,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.532,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.16999999999996,
"heapDeltaBytes": -11339652,
"heapUsedBytes": 59000252,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.028999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2019.993999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.28,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.019,
"heapDeltaBytes": -12516808,
"heapUsedBytes": 57729972,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.324999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.365000000034,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.724000000000002,
"layouts": 14,
"layoutDurationMs": 2.2050000000000005,
"taskDurationMs": 606.3190000000001,
"heapDeltaBytes": 8750816,
"heapUsedBytes": 78955748,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 92.536,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.8070000000162,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.351000000000003,
"layouts": 14,
"layoutDurationMs": 2.2659999999999996,
"taskDurationMs": 611.3329999999999,
"heapDeltaBytes": 11919224,
"heapUsedBytes": 83012348,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 90.759,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.1019999999853,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.504000000000001,
"layouts": 6,
"layoutDurationMs": 0.812,
"taskDurationMs": 272.104,
"heapDeltaBytes": 4687316,
"heapUsedBytes": 75877240,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.825,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.3669999999988,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.027000000000003,
"layouts": 6,
"layoutDurationMs": 0.7050000000000001,
"taskDurationMs": 272.64500000000004,
"heapDeltaBytes": 4524708,
"heapUsedBytes": 75094800,
"domNodes": 79,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.773000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 532.2840000000042,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.594999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.38,
"heapDeltaBytes": -8211476,
"heapUsedBytes": 63149620,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 108.633,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 523.885000000007,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.79800000000006,
"heapDeltaBytes": 18733500,
"heapUsedBytes": 89270616,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 108.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2020.105000000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.0770000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.959,
"heapDeltaBytes": 10875992,
"heapUsedBytes": 87586344,
"domNodes": -268,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 20.208999999999996,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.953999999961,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.342000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.26700000000005,
"heapDeltaBytes": 9389456,
"heapUsedBytes": 85987336,
"domNodes": -268,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 26.397000000000006,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2106.573000000026,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.827000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1154.9420000000002,
"heapDeltaBytes": 9549428,
"heapUsedBytes": 86427884,
"domNodes": -271,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 534.623,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.4060000000213,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1199.3559999999998,
"heapDeltaBytes": -7350968,
"heapUsedBytes": 70015544,
"domNodes": -278,
"jsHeapTotalBytes": 1208320,
"scriptDurationMs": 549.353,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3080.964999999992,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.502,
"layouts": 60,
"layoutDurationMs": 7.5729999999999995,
"taskDurationMs": 1221.4370000000001,
"heapDeltaBytes": -5511196,
"heapUsedBytes": 75843684,
"domNodes": -271,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 495.24100000000004,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3055.749999999989,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.273999999999999,
"layouts": 60,
"layoutDurationMs": 7.928000000000001,
"taskDurationMs": 1211.9460000000001,
"heapDeltaBytes": 12097484,
"heapUsedBytes": 79997176,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 502.04099999999994,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2138.328999999999,
"styleRecalcs": 42,
"styleRecalcDurationMs": 3.5640000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1323.867,
"heapDeltaBytes": 17141432,
"heapUsedBytes": 84847120,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 642.1729999999999,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2288.566000000003,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.406999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1414.452,
"heapDeltaBytes": 3088300,
"heapUsedBytes": 83742548,
"domNodes": -248,
"jsHeapTotalBytes": 315392,
"scriptDurationMs": 651.378,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.0589999999897,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.842999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.67899999999986,
"heapDeltaBytes": 5534380,
"heapUsedBytes": 84016188,
"domNodes": -274,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 23.03800000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.238999999981,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.448999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.539,
"heapDeltaBytes": 4234732,
"heapUsedBytes": 82531272,
"domNodes": -273,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 20.206999999999997,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 475.97100000001547,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.2639999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 284.87399999999997,
"heapDeltaBytes": 14724368,
"heapUsedBytes": 87081588,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 91.612,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.4510000000132,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.538000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.709,
"heapDeltaBytes": 15124088,
"heapUsedBytes": 88279196,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 91.444,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2001.8309999999815,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.933999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.96000000000004,
"heapDeltaBytes": 5953884,
"heapUsedBytes": 79323100,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.202000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.543000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.777999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.81499999999994,
"heapDeltaBytes": -9248876,
"heapUsedBytes": 63437556,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 6.728,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.244000000007,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.862000000000002,
"layouts": 18,
"layoutDurationMs": 2.7099999999999995,
"taskDurationMs": 588.586,
"heapDeltaBytes": -11820608,
"heapUsedBytes": 61793816,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 65.43,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.014000000001,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.645,
"layouts": 18,
"layoutDurationMs": 3.3369999999999997,
"taskDurationMs": 609.547,
"heapDeltaBytes": -9671396,
"heapUsedBytes": 62591252,
"domNodes": -298,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 70.53099999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.3859999999772,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.116999999999997,
"layouts": 16,
"layoutDurationMs": 9.829,
"taskDurationMs": 680.2850000000001,
"heapDeltaBytes": 23694732,
"heapUsedBytes": 107593400,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 17.327,
"eventListeners": 2385,
"totalBlockingTimeMs": 110,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8130.882999999983,
"styleRecalcs": 248,
"styleRecalcDurationMs": 20.119,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4199.017,
"heapDeltaBytes": 9908160,
"heapUsedBytes": 86307112,
"domNodes": -272,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 1819.6,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8187.726999999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4120.195,
"heapDeltaBytes": 2187932,
"heapUsedBytes": 78184976,
"domNodes": -274,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 1789.875,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10883.662000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10487.394,
"heapDeltaBytes": -33179400,
"heapUsedBytes": 184138796,
"domNodes": -8068,
"jsHeapTotalBytes": -2093056,
"scriptDurationMs": 155.337,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10672.411000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10121.206,
"heapDeltaBytes": -40079076,
"heapUsedBytes": 177078224,
"domNodes": -8068,
"jsHeapTotalBytes": -9420800,
"scriptDurationMs": 123.14099999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13509.777000000042,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.253999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12855.132000000001,
"heapDeltaBytes": -31449468,
"heapUsedBytes": 185916800,
"domNodes": -8068,
"jsHeapTotalBytes": -10551296,
"scriptDurationMs": 622.278,
"eventListeners": -14935,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13129.636000000006,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.208999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12696.542000000001,
"heapDeltaBytes": -44786092,
"heapUsedBytes": 166895892,
"domNodes": -8068,
"jsHeapTotalBytes": -18391040,
"scriptDurationMs": 566.1370000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3992.592000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.998,
"layouts": 20,
"layoutDurationMs": 18.250000000000004,
"taskDurationMs": 3844.8070000000002,
"heapDeltaBytes": -57157404,
"heapUsedBytes": 182433360,
"domNodes": -8068,
"jsHeapTotalBytes": 12668928,
"scriptDurationMs": 61.44400000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 3988.9670000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.603,
"layouts": 20,
"layoutDurationMs": 18.00099999999999,
"taskDurationMs": 3802.005,
"heapDeltaBytes": -41441992,
"heapUsedBytes": 177507248,
"domNodes": -8068,
"jsHeapTotalBytes": 10706944,
"scriptDurationMs": 57.05900000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 6,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5336.195999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5186.287,
"heapDeltaBytes": 5364012,
"heapUsedBytes": 176729760,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 65.023,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5303.824999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5138.579999999999,
"heapDeltaBytes": 9588628,
"heapUsedBytes": 180415412,
"domNodes": 0,
"jsHeapTotalBytes": -20185088,
"scriptDurationMs": 59.51199999999995,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 437.75800000003073,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.679000000000002,
"layouts": 4,
"layoutDurationMs": 1.2790000000000001,
"taskDurationMs": 90.99899999999998,
"heapDeltaBytes": 5098880,
"heapUsedBytes": 73432376,
"domNodes": 153,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.41,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 431.5649999999778,
"styleRecalcs": 14,
"styleRecalcDurationMs": 12.191,
"layouts": 2,
"layoutDurationMs": 0.37,
"taskDurationMs": 75.18,
"heapDeltaBytes": 4796668,
"heapUsedBytes": 73163292,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.965,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19070 +/- ##
=============================================
Coverage ? 83.93%
=============================================
Files ? 2116
Lines ? 126054
Branches ? 34104
=============================================
Hits ? 105805
Misses ? 20072
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
Backport self-review correction: the conflict hunk included two neighboring replay-tour tests that were context on main, not part of #19061. I removed them. The branch diff now exactly matches upstream: 25 test lines plus the 5-line production change (29 insertions, 1 deletion across two files). |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
|
CodeRabbit review only reported pre-merge checks in progress. All checks are now complete and green; no code finding was raised.
Backport of #19061 to
cloud/1.54.Manual backport because automation encountered a context-only conflict in
AgentPanelRoot.test.ts; resolved by retaining the four upstream regression tests in the release branch’s existing onboarding suite. Production code cherry-picked cleanly.Justification: release backport of an already-reviewed and merged fix; validation is delegated to this PR’s exact-branch CI because local dependency installation exhausted the runner disk.