Repository navigation
test(agent): repro PM-1308 onboarding coach missing after consent Start - #18094
claude[bot] wants to merge 1 commit into
Conversation
Adds one failing e2e per hypothesis for the coach not opening after Start on the consent card. The direct flow, the first-run tour hand-off (Hypothesis A) and the scoped onboarding key (Hypothesis B) pass, ruling those out. Hypothesis D reproduces the bug under test.fail(): a device carrying the legacy device-wide Comfy.AgentPanel.onboarded flag has it adopted onto the first consented scope, so the panel opens with no guide. Exports agentFeatures from agentPanelMocks so the first-run variant can layer the onboarding tour flags over the agent boot mocks.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2041 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T03:28:14.907Z",
"gitSha": "9f715465dd8d841144b2144e874ed4e7edccd512",
"branch": "test/pm-1301-onboarding-guide-not-opening-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.0980000000236,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.157,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.7130000000001,
"heapDeltaBytes": 7760120,
"heapUsedBytes": 68223204,
"domNodes": -263,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.515000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2003.7020000000894,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.466999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.19,
"heapDeltaBytes": 11188876,
"heapUsedBytes": 73156660,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.298000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1794.179999999983,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.881,
"layouts": 14,
"layoutDurationMs": 4.0409999999999995,
"taskDurationMs": 805.638,
"heapDeltaBytes": -7487256,
"heapUsedBytes": 54842160,
"domNodes": -263,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 159.448,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.7580000000426,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.791999999999998,
"layouts": 14,
"layoutDurationMs": 4.24,
"taskDurationMs": 836.5819999999999,
"heapDeltaBytes": 9868236,
"heapUsedBytes": 71900232,
"domNodes": -264,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 167.33,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.1299999999083,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.513,
"layouts": 6,
"layoutDurationMs": 1.164,
"taskDurationMs": 320.077,
"heapDeltaBytes": 2121244,
"heapUsedBytes": 64135720,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.705000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.506000000104,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.370000000000001,
"layouts": 6,
"layoutDurationMs": 1.0270000000000001,
"taskDurationMs": 310.565,
"heapDeltaBytes": 2173672,
"heapUsedBytes": 64160156,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.881,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 632.4489999999514,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.43899999999996,
"heapDeltaBytes": 18213852,
"heapUsedBytes": 80195404,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 166.03,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 631.3649999999598,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.839,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.887,
"heapDeltaBytes": 18227324,
"heapUsedBytes": 80196132,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.214,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.9940000000306,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.097,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.9390000000001,
"heapDeltaBytes": 2759680,
"heapUsedBytes": 82616828,
"domNodes": -248,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 37.831999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2026.106000000027,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.059999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.7600000000001,
"heapDeltaBytes": 4130456,
"heapUsedBytes": 83495028,
"domNodes": -247,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 28.613,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2196.8519999999216,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.428999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1540.1379999999997,
"heapDeltaBytes": 18433264,
"heapUsedBytes": 82620752,
"domNodes": 6,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 832.5669999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2294.0130000000636,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.096999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1649.558,
"heapDeltaBytes": -4622840,
"heapUsedBytes": 75869116,
"domNodes": -249,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 870.87,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3505.178000000001,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.679,
"layouts": 60,
"layoutDurationMs": 12.254999999999999,
"taskDurationMs": 1644.3770000000002,
"heapDeltaBytes": 4464848,
"heapUsedBytes": 70226828,
"domNodes": -257,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 795.137,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3497.327000000041,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.123,
"layouts": 60,
"layoutDurationMs": 12.444,
"taskDurationMs": 1636.4349999999997,
"heapDeltaBytes": 7531664,
"heapUsedBytes": 73878040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 776.742,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3078.8029999999935,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.44,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1855.0019999999997,
"heapDeltaBytes": 19042732,
"heapUsedBytes": 84383716,
"domNodes": -9,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 973.4540000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3175.3909999999905,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.693,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1929.7009999999996,
"heapDeltaBytes": 26973796,
"heapUsedBytes": 92924324,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1030.848,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.765000000044,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3029999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.7529999999999,
"heapDeltaBytes": 20104676,
"heapUsedBytes": 84078716,
"domNodes": -5,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.42700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.8889999999737,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.490999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.3480000000001,
"heapDeltaBytes": -6089412,
"heapUsedBytes": 81770096,
"domNodes": -255,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 29.51200000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.3379999999588,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.35299999999995,
"heapDeltaBytes": 13313224,
"heapUsedBytes": 76723884,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.358,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.5980000000309,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.868,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.8829999999999,
"heapDeltaBytes": 13431300,
"heapUsedBytes": 76307292,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.276,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.953999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.350999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.63300000000004,
"heapDeltaBytes": 7979204,
"heapUsedBytes": 71357332,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.858,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.8739999999725,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.597999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.132,
"heapDeltaBytes": 8603476,
"heapUsedBytes": 71895052,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.200000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.0990000000047,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.343,
"layouts": 18,
"layoutDurationMs": 4.760999999999999,
"taskDurationMs": 746.5619999999999,
"heapDeltaBytes": 9510700,
"heapUsedBytes": 72808864,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 101.743,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.853,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.291000000000004,
"layouts": 18,
"layoutDurationMs": 5.697,
"taskDurationMs": 765.068,
"heapDeltaBytes": 17585852,
"heapUsedBytes": 80539788,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 111.14200000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.60699999996,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.413000000000007,
"layouts": 5,
"layoutDurationMs": 12.864,
"taskDurationMs": 894.8299999999998,
"heapDeltaBytes": -8381412,
"heapUsedBytes": 81282196,
"domNodes": 13587,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.823000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8274.752000000035,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.472,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5518.576,
"heapDeltaBytes": -5066284,
"heapUsedBytes": 74720060,
"domNodes": -250,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 2732.104,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8399.833000000057,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.760999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5832.912,
"heapDeltaBytes": -7367912,
"heapUsedBytes": 72850536,
"domNodes": -248,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 2959.8050000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12350.659999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11261.739000000001,
"heapDeltaBytes": -34569108,
"heapUsedBytes": 173893264,
"domNodes": -8061,
"jsHeapTotalBytes": -4235264,
"scriptDurationMs": 234.03799999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16562.781000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15869.107,
"heapDeltaBytes": -15261520,
"heapUsedBytes": 188061376,
"domNodes": -8061,
"jsHeapTotalBytes": -14487552,
"scriptDurationMs": 266.198,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20372.492999999962,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.69900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20081.682999999997,
"heapDeltaBytes": -70634912,
"heapUsedBytes": 167570260,
"domNodes": -8061,
"jsHeapTotalBytes": -19632128,
"scriptDurationMs": 886.1210000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 61,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20221.010999999977,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.658000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19845.387,
"heapDeltaBytes": -30069584,
"heapUsedBytes": 191711424,
"domNodes": -8061,
"jsHeapTotalBytes": -17047552,
"scriptDurationMs": 867.0939999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6038.127000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.77099999999999,
"layouts": 20,
"layoutDurationMs": 23.253999999999998,
"taskDurationMs": 5948.629000000001,
"heapDeltaBytes": -60987824,
"heapUsedBytes": 173828816,
"domNodes": -8061,
"jsHeapTotalBytes": 13500416,
"scriptDurationMs": 106.70800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 376,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5927.171999999928,
"styleRecalcs": 20,
"styleRecalcDurationMs": 94.716,
"layouts": 20,
"layoutDurationMs": 33.26899999999999,
"taskDurationMs": 5810.402,
"heapDeltaBytes": -42355268,
"heapUsedBytes": 174237392,
"domNodes": -8061,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 106.73100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 318,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8422.902000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8120.178000000001,
"heapDeltaBytes": -8227996,
"heapUsedBytes": 176464124,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 123.65100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8346.490000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7981.210999999998,
"heapDeltaBytes": -17059940,
"heapUsedBytes": 167178232,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 116.48799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 137.51999999999498,
"styleRecalcs": 10,
"styleRecalcDurationMs": 20.807000000000002,
"layouts": 4,
"layoutDurationMs": 1.8150000000000002,
"taskDurationMs": 102.575,
"heapDeltaBytes": 3304824,
"heapUsedBytes": 64815124,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.373000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 118.41500000002725,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.684,
"layouts": 3,
"layoutDurationMs": 1.427,
"taskDurationMs": 81.382,
"heapDeltaBytes": 3016760,
"heapUsedBytes": 64761332,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.3660000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18094 +/- ##
==========================================
+ Coverage 82.77% 83.80% +1.03%
==========================================
Files 2936 2242 -694
Lines 144439 127635 -16804
Branches 39004 32564 -6440
==========================================
- Hits 119562 106967 -12595
+ Misses 23620 20378 -3242
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The "test" ( What failed: all 1609 test files and 22,153 tests passed; the job still exited 1 because Vitest caught an unhandled error outside any test assertion: This originated in This PR's actual diff only touches Playwright e2e files ( Re-ran the failed job (run 35418079615) and it's now green (attempt 2, Generated by Claude Code |
Root cause, confirmed
const onboardingKey = computed(() =>
scopedOnboardingKey(resolvedUserInfo.value?.id, workspaceStore.activeWorkspaceId)
)
watch(
onboardingKey,
(key) => {
if (key) adoptSharedOnboardingFlag(key)
},
{ immediate: true }
)
Net effect: any device that ever opened the agent panel before the consent card shipped (2026-08-30 This matches Hypothesis D in the PR body, and Why this isn't a trivial fixThe existing unit tests pin
Both change onboarding state shared across surfaces (device-wide flag semantics affect every workspace a device ever touches) and both need a product decision on the intended UX for "device has seen it, new workspace hasn't" — not just a code fix. Per the PR's own framing: "Whether the fix is 'consent acceptance re-arms the coach' or 'drop the legacy carry-over' is a product call; the failing test pins the observable either way." RecommendationLeaving Generated by Claude Code |
|
Root cause is now fixed in #19061 with focused unit coverage for both migration paths. Closing this repro-only branch in favor of that current-main replacement. |
## Summary - Preserve legacy device-wide onboarding migration for scopes that already accepted consent. - Do not consume that legacy flag for a new scope before its first consent; clicking Start now shows the scoped coach once. - Cover both new-consent and already-consented migration paths. Linear: PM-1301, PM-1308 Replaces the repro-only #18094 with the confirmed fix. ## Test plan - `pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` (309 passed) - Full `pnpm typecheck:app` via pre-commit - ESLint, oxlint, stylelint, and oxfmt via pre-commit Justification: narrow state-migration fix with focused regression coverage; requested as part of the PM-1308 thread takeover.
Requested by Christian Byrne · Slack thread
Summary
Failing e2e repro for PM-1301 / PM-1308: clicking Start on the agent consent card opens the panel but the onboarding coach marks never appear. The earlier RCA pass could not decide between several hypotheses, so this adds one test per hypothesis in
browser_tests/tests/agent/agentConsentOnboarding.spec.tsand drives each one end to end against the mocked cloud boot (agentTestfromagentPanelMocks). Exactly one reproduces the bug and carriestest.fail(); the others pass and stay as regression coverage for the paths they rule out.Before: no e2e ever asserted that the coach appears after consent (
agentConsent.spec.tsstops at "panel opens",agentOnboarding.spec.tsstarts with consent already accepted), and the coach's hand-off from the general onboarding tour had zero coverage.After: four tests pin the mount gate
consentAccepted && onboardingKey && !linearMode && activeTour === nullfrom four angles; the one that reproduces PM-1308 is red undertest.fail()and turns the PR green again the moment the behaviour is fixed (Playwright then reports "expected to fail but passed").Hypotheses tested
activeTour !== null) and the coach never comes back once it endsHypothesis A (PM-1308): the coach appears once the first-run tour ends after consent was accepted mid-tour?template=image_z_image_turbo(first-run tour auto-starts), lands the consent card over the running tour, clicks Start: the coach correctly yields while the tour runs and appears as soon as the tour is skipped. The reactive hand-off works.onboardingKeyis transiently null at the moment of accept, so thev-ifnever re-evaluatesHypothesis B (PM-1308): the coach mounts for the resolved user and workspace scope right after StartWorkspaceAuthGateawaitsworkspaceStore.initialize()before the app renders, andconsentStore.acceptedis derived from the same user + workspace identity asonboardingKey, so the key cannot be null while consent reads true. The test proves the gate passed by observing the scopeduseStoragekey (Comfy.AgentPanel.onboarded.<user>.<workspace>) being written the moment the coach mounts.agentPanelStore.enabledenabledflag, so a flag problem would keep the panel closed too.PM-1308: Start on the consent card opens the onboarding coachComfy.AgentPanel.onboarded=true, andadoptSharedOnboardingFlagmoves it onto the first scope the user consents inHypothesis D (PM-1308): Start opens the coach for a scope that never saw ittest.fail()). The panel opens, the scoped key is created astrue, and no coach ever appears.Why D is the real-world path
f954e479shippedOnboardingCoachkeyed on the device-wideComfy.AgentPanel.onboarded; every agent open since then wrote it, and finishing or skipping the marks set it totrue.c4afd475shipped the consent card (Agent opt-in consent card (PM-514): support local and cloud #16177).7ca9c6a0(feat(agent): offer the consent card without a button click #17912) scoped the seen-flag per user and workspace and addedadoptSharedOnboardingFlag, which copies the oldtrueonto whatever scope is in front of the user and deletes the shared key.So every account that used the agent before the consent card existed (which is every internal tester) now sees the consent card, clicks Start, and gets the panel without the guide because the coach considers this device already onboarded. A brand-new device does get the guide, which is why the flow looks fine in isolation and why the earlier wiring checks found nothing broken. Whether the fix is "consent acceptance re-arms the coach" or "drop the legacy carry-over" is a product call; the failing test pins the observable either way.
Side finding (not addressed here)
useTemplateWorkflows.tscallsdialogStore.closeDialog()when a template loads, which closes whatever dialog is active. When the consent card auto-offers itself on a first boot with?template=(or a Getting Started pick), the template load sweeps the card away andComfy.AgentConsent.AutoShownhas already been written, so the automatic offer is consumed without the user ever seeing it. The Hypothesis A test holds the consent read until the tour is up to sidestep this; it deserves its own ticket.Linear: PM-1301 (parent), PM-1308.
Test Plan
pnpm exec playwright test --project=cloud browser_tests/tests/agent/agentConsentOnboarding.spec.tslocally against aDISTRIBUTION=clouddev server and a--multi-userbackend: direct, A and B pass; D fails onexpect(agent-coach-spotlight).toBeVisible()and is annotatedtest.fail()panel-after-start,panel-open-during-tour,after-tour-skipped) and runs with trace + video for visual proof; D's screenshot shows the open panel with no spotlight or coach cardoxfmt --check,oxlint --type-aware,eslinton the changed filestsc -p browser_tests/tsconfig.json: no errors in the changed files (fullvue-tscwas OOM-killed on the shared dev box; CI runs it)cloudproject: D reports as expected failure, the other three pass🤖 Generated with Claude Code
https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1
Generated by Claude Code