Repository navigation
[backport cloud/1.55] fix(agent): show onboarding after first scoped consent (#19061) - #19084
Conversation
- Preserve legacy device-wide onboarding migration for scopes that already accepted consent. - Do not consume that legacy flag for a new scope before its first consent; clicking Start now shows the scoped coach once. - Cover both new-consent and already-consented migration paths. Linear: PM-1301, PM-1308 Replaces the repro-only #18094 with the confirmed fix. - `pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` (309 passed) - Full `pnpm typecheck:app` via pre-commit - ESLint, oxlint, stylelint, and oxfmt via pre-commit Justification: narrow state-migration fix with focused regression coverage; requested as part of the PM-1308 thread takeover.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since efb3ebdae5e9c5084ee218122a756fe26502745a
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-27T08:03:03.350Z",
"gitSha": "16ea5c9c62cf23612412bfdb6e340f98bdaeca3a",
"branch": "backport-19061-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.195999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.28299999999996,
"heapDeltaBytes": 6154280,
"heapUsedBytes": 73720396,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.726999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2007.8649999999243,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.511000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.09799999999996,
"heapDeltaBytes": 8516544,
"heapUsedBytes": 75939064,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 11.669999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.9680000000208,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.837999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 867.8839999999999,
"heapDeltaBytes": 7081320,
"heapUsedBytes": 74700912,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 157.336,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.678000000018,
"styleRecalcs": 45,
"styleRecalcDurationMs": 17.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 899.8439999999998,
"heapDeltaBytes": 3602248,
"heapUsedBytes": 71342592,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 159.78300000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.7870000000298,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.324000000000002,
"layouts": 6,
"layoutDurationMs": 1.144,
"taskDurationMs": 341.95799999999997,
"heapDeltaBytes": 2239620,
"heapUsedBytes": 64622936,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.890999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.2550000000183,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.419,
"layouts": 6,
"layoutDurationMs": 1.23,
"taskDurationMs": 348.178,
"heapDeltaBytes": 3107264,
"heapUsedBytes": 70835352,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.509999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 645.1749999999947,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.38199999999995,
"heapDeltaBytes": 18588488,
"heapUsedBytes": 80976048,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 172.684,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 675.8379999999988,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.639999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.65500000000003,
"heapDeltaBytes": 18650424,
"heapUsedBytes": 86321368,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 162.87300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1154.277000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 829.914,
"heapDeltaBytes": 35209712,
"heapUsedBytes": 106007312,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 64.49199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 537,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1207.2430000000622,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.1750000000001,
"heapDeltaBytes": -16368700,
"heapUsedBytes": 73733876,
"domNodes": -296,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 68.7,
"eventListeners": -217,
"totalBlockingTimeMs": 535,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.7039999999884,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.09899999999993,
"heapDeltaBytes": 16158072,
"heapUsedBytes": 91698388,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.76,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.1809999999487,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.94400000000013,
"heapDeltaBytes": 14317804,
"heapUsedBytes": 90591940,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.722,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8889.117999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8003.657,
"heapDeltaBytes": -9362568,
"heapUsedBytes": 73087984,
"domNodes": -20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6532.84,
"eventListeners": 0,
"totalBlockingTimeMs": 319,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8817.843000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8103.294999999999,
"heapDeltaBytes": 1953932,
"heapUsedBytes": 84191368,
"domNodes": -14,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 6511.460999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 280,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9079.877000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8342.09,
"heapDeltaBytes": 10028888,
"heapUsedBytes": 92001440,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6673.880999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 239,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8808.987000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8040.02,
"heapDeltaBytes": -10732476,
"heapUsedBytes": 71043680,
"domNodes": -12,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6425.05,
"eventListeners": 0,
"totalBlockingTimeMs": 175,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2038.5459999999966,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.860999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 731.6729999999999,
"heapDeltaBytes": -3523788,
"heapUsedBytes": 76145108,
"domNodes": -256,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 41.373000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2071.3000000000648,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.292000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 708.8590000000002,
"heapDeltaBytes": -7595064,
"heapUsedBytes": 79189400,
"domNodes": -249,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 39.61400000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2370.1829999999973,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.638999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1694.359,
"heapDeltaBytes": -7316996,
"heapUsedBytes": 80649504,
"domNodes": -246,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 824.2900000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2647.1629999999777,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.155999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1805.033,
"heapDeltaBytes": 22235380,
"heapUsedBytes": 86736312,
"domNodes": -245,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 915.291,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3624.5589999999765,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.423,
"layouts": 60,
"layoutDurationMs": 15.290000000000001,
"taskDurationMs": 1748.885,
"heapDeltaBytes": 7668856,
"heapUsedBytes": 73816552,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 812.5830000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3677.1999999999707,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.389999999999999,
"layouts": 60,
"layoutDurationMs": 15.328999999999999,
"taskDurationMs": 1796.724,
"heapDeltaBytes": 9416968,
"heapUsedBytes": 74657728,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 820.158,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3192.017999999962,
"styleRecalcs": 44,
"styleRecalcDurationMs": 11.759000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2087.968,
"heapDeltaBytes": 5294648,
"heapUsedBytes": 88896532,
"domNodes": -255,
"jsHeapTotalBytes": 1196032,
"scriptDurationMs": 1061.499,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3190.977000000089,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.289000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2056.0460000000003,
"heapDeltaBytes": -2908804,
"heapUsedBytes": 87544544,
"domNodes": -254,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 1020.2610000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.1899999999573,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.245999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.1089999999999,
"heapDeltaBytes": -4688320,
"heapUsedBytes": 84190804,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.75299999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2026.6379999999344,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.972999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.6899999999999,
"heapDeltaBytes": -4149924,
"heapUsedBytes": 84147384,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 37.88999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.8890000000042,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.31,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.933,
"heapDeltaBytes": 14083604,
"heapUsedBytes": 83891524,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.9,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.0339999999615,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.059000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.71399999999994,
"heapDeltaBytes": 14030084,
"heapUsedBytes": 82981464,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 153.882,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.342999999978,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.975999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.489,
"heapDeltaBytes": 7911108,
"heapUsedBytes": 78163420,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.700999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2005.4900000000089,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.433,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.68,
"heapDeltaBytes": 10985776,
"heapUsedBytes": 80884272,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.422999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.4309999999955,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 763.5840000000001,
"heapDeltaBytes": 11401248,
"heapUsedBytes": 81192920,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 105.325,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.3909999999214,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.503,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 775.861,
"heapDeltaBytes": -8465592,
"heapUsedBytes": 61671272,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 109.794,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.1429999999182,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.311999999999998,
"layouts": 5,
"layoutDurationMs": 11.87,
"taskDurationMs": 885.9590000000002,
"heapDeltaBytes": -6291672,
"heapUsedBytes": 81400724,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.938999999999993,
"eventListeners": 2383,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8406.920000000013,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.78,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5777.351,
"heapDeltaBytes": -17964208,
"heapUsedBytes": 69164820,
"domNodes": -215,
"jsHeapTotalBytes": 6844416,
"scriptDurationMs": 2744.2980000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8378.490000000056,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.956999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5837.3279999999995,
"heapDeltaBytes": 3017008,
"heapUsedBytes": 89571060,
"domNodes": -254,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2744.0919999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17278.741000000082,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16923.405000000002,
"heapDeltaBytes": -49195132,
"heapUsedBytes": 165283456,
"domNodes": -8062,
"jsHeapTotalBytes": -7090176,
"scriptDurationMs": 266.25699999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17773.389000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17574.636000000002,
"heapDeltaBytes": -49470768,
"heapUsedBytes": 184125468,
"domNodes": -8061,
"jsHeapTotalBytes": -16625664,
"scriptDurationMs": 296.499,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21262.469000000012,
"styleRecalcs": 148,
"styleRecalcDurationMs": 19.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21116.451,
"heapDeltaBytes": -38445484,
"heapUsedBytes": 189542492,
"domNodes": -8061,
"jsHeapTotalBytes": -17047552,
"scriptDurationMs": 878.317,
"eventListeners": -14928,
"totalBlockingTimeMs": 230,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16555.706999999984,
"styleRecalcs": 94,
"styleRecalcDurationMs": 15.351000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16309.443000000001,
"heapDeltaBytes": -50892772,
"heapUsedBytes": 190749732,
"domNodes": -8061,
"jsHeapTotalBytes": -19668992,
"scriptDurationMs": 881.776,
"eventListeners": -14928,
"totalBlockingTimeMs": 86,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6345.797999999945,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.819,
"layouts": 20,
"layoutDurationMs": 25.472999999999995,
"taskDurationMs": 6270.875,
"heapDeltaBytes": -60741216,
"heapUsedBytes": 180638032,
"domNodes": -8061,
"jsHeapTotalBytes": 8974336,
"scriptDurationMs": 118.68900000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 340,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6316.342999999961,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.78200000000001,
"layouts": 20,
"layoutDurationMs": 26.019000000000002,
"taskDurationMs": 6291.031000000001,
"heapDeltaBytes": -26224628,
"heapUsedBytes": 195846688,
"domNodes": -8061,
"jsHeapTotalBytes": 12644352,
"scriptDurationMs": 111.838,
"eventListeners": -14927,
"totalBlockingTimeMs": 521,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8690.826000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8595.336,
"heapDeltaBytes": -17588688,
"heapUsedBytes": 173497108,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 143.05099999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8791.593999999917,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8737.257,
"heapDeltaBytes": -17308944,
"heapUsedBytes": 177649848,
"domNodes": 0,
"jsHeapTotalBytes": -27525120,
"scriptDurationMs": 138.18400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 470.41300000000774,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.244,
"layouts": 3,
"layoutDurationMs": 1.556,
"taskDurationMs": 127.73500000000001,
"heapDeltaBytes": 5198068,
"heapUsedBytes": 70869528,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.093000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 99.73200000001725,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.61,
"layouts": 3,
"layoutDurationMs": 1.76,
"taskDurationMs": 75.852,
"heapDeltaBytes": 2988900,
"heapUsedBytes": 68612664,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.859000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19084 +/- ##
=============================================
Coverage ? 84.61%
=============================================
Files ? 2298
Lines ? 131862
Branches ? 35622
=============================================
Hits ? 111580
Misses ? 19963
Partials ? 319
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against #19061 before approving: identical file list, no conflict markers in the diff. All three required checks green.
Backport of #19061 to
cloud/1.55.Same conflict/resolution as #19083 (the core/1.55 backport): the automated backport hit a merge conflict in
AgentPanelRoot.test.tsbecausecloud/1.55also lacks the unrelated, unbackported "replay tour from header" (Take the tourbutton) feature whose tests sat as unchanged context around #19061's own new tests in the merge-commit diff. Resolved by keeping only the two tests #19061 actually added and dropping the two tests belonging to that unbackported feature.Verified on this branch:
pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts— 260 passedpnpm exec vue-tsc --noEmit— cleanRequested by Christian Byrne · Slack thread
🤖 Generated with Claude Code
https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1
Generated by Claude Code