Skip to content

fix(website): bump the Router catalog model count to 212 - #18843

Merged
dante01yoon merged 1 commit into
mainfrom
fix/website-router-catalog-count-212
Sep 25, 2026
Merged

dante01yoon merged 1 commit into
mainfrom
fix/website-router-catalog-count-212

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Why

website-unit is red on main and on every core/1.55 / cloud/1.55 PR: router-providers.test.ts › "counts the models the docs catalog lists" fails with expected 212 to be 209. It blocks unrelated PRs, including the billing backports.

Root cause

The test reads the live docs catalog (docs.comfy.org/development/comfy-router/models.md) in CI and compares it with ROUTER_CATALOG_MODEL_COUNT. The docs added three models after #18489 pinned the count at 209. The code is fine; the constant fell behind the docs.

How

  • ROUTER_CATALOG_MODEL_COUNT 209 → 212, matching the live catalog today (212 unique model paths).
  • ROUTER_PROVIDER_COVERAGE_VERIFIED_AT → 2026-09-25; the provider rows were re-checked against the docs in the same run.

CI=1 pnpm exec vitest run src/config/router-providers.test.ts src/templates/platform/RouterProviderCoverageSection.test.ts passes 11/11 locally, including the live-docs checks. The page's "Browse all N models" link and the Comfy-only count follow the constant.

Same change as #18804, which was closed without merging. Labelled for core/1.55 and cloud/1.55 so the release branches go green too.

AS IS / TO BE

AS IS: placeholder ("Browse all 209 models")
TO BE: placeholder ("Browse all 212 models")

@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.55 Backport PRs for core 1.55 cloud/1.55 Backport PRs for cloud 1.55 labels Sep 25, 2026
@dante01yoon
dante01yoon requested review from a team September 25, 2026 11:53
@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.55 Backport PRs for core 1.55 cloud/1.55 Backport PRs for cloud 1.55 labels Sep 25, 2026
@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 25, 2026 11:53am UTC
billing-web-test Skipped Skipped Sep 25, 2026 11:53am UTC

Request Review

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 4c04e82cb7e182e45b355bc268213632e8e94573

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-18843.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-r6v17w6sm-comfyui.vercel.app

Last updated: 2026-09-25T11:55:27Z for ca29a45

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8b5ea7b2-c872-4090-b0ec-bbac1b239ae9

📥 Commits

Reviewing files that changed from the base of the PR and between 4c04e82 and ca29a45.

📒 Files selected for processing (1)
  • apps/website/src/config/router-providers.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The router provider coverage verification date changed to 2026-09-25. The catalog model count changed from 209 to 212.

Changes

Router provider catalog metadata

Layer / File(s) Summary
Update catalog coverage metadata
apps/website/src/config/router-providers.ts
The coverage verification date changed to 2026-09-25, and the catalog model count increased from 209 to 212.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: shrimbly

Merge Risk: ⚪ Minimal · up to ca29a

This change updates the displayed catalog total and coverage date. No concrete regression is established, so it is mergeable subject to normal checks.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating the Router catalog model count to 212.
Description check ✅ Passed The description provides the reason, root cause, implementation details, test results, and expected behavior change. It does not use the template headings exactly, and it omits explicit review-focus a…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PASS. The PR uses the bug-fix signal “fix,” but the only changed file is under apps/website. The check explicitly excludes changes exclusively in apps/website from this failure condition.
Website End-To-End Regression Coverage ✅ Passed The PR changes apps/website/src/config/router-providers.ts, but the diff only updates the Router catalog count and verification date. This is a catalog text/data update, not a change to a route, int…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed file is apps/website/src/config/router-providers.ts. It is not under src/lib/litegraph/ or src/ecs/, and it is not related to graph entities. The ADR-LAYOUT and ADR-ECS checks are th…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

dante01yoon added a commit that referenced this pull request Sep 25, 2026
…t to 212 (#18844)

Backport of #18843 to `core/1.55` (cherry-pick -x of ca29a45), opened
ahead of the main merge because `website-unit` is red on every
`core/1.55` PR.

## Why

`router-providers.test.ts` fails on `core/1.55` with `expected 212 to be
209`, blocking the release-branch backports.

## Root cause

The CI-only test compares the live docs catalog (now 212 models) with
`ROUTER_CATALOG_MODEL_COUNT` (209).

## How

Same two-line change as #18843: count → 212, verified date → 2026-09-25.

## AS IS / TO BE

Same as #18843.
dante01yoon added a commit that referenced this pull request Sep 25, 2026
…nt to 212 (#18845)

Backport of #18843 to `cloud/1.55` (cherry-pick -x of ca29a45),
opened ahead of the main merge because `website-unit` is red on every
`cloud/1.55` PR.

## Why

`router-providers.test.ts` fails on `cloud/1.55` with `expected 212 to
be 209`, blocking the release-branch backports.

## Root cause

The CI-only test compares the live docs catalog (now 212 models) with
`ROUTER_CATALOG_MODEL_COUNT` (209).

## How

Same two-line change as #18843: count → 212, verified date → 2026-09-25.

## AS IS / TO BE

Same as #18843.
@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #18843      +/-   ##
==========================================
- Coverage   84.91%   83.91%   -1.00%     
==========================================
  Files        2339     3027     +688     
  Lines      133169   150860   +17691     
  Branches    35933    40991    +5058     
==========================================
+ Hits       113081   126601   +13520     
- Misses      19741    22882    +3141     
- Partials      347     1377    +1030     
Flag Coverage Δ
billing-web-unit ?
website-unit 76.88% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/router-providers.ts 100.00% <100.00%> (ø)

... and 757 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon
dante01yoon added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 1c2a416 Sep 25, 2026
135 of 136 checks passed
@dante01yoon
dante01yoon deleted the fix/website-router-catalog-count-212 branch September 25, 2026 12:45
@comfy-pr-bot

Copy link
Copy Markdown
Member

⚠️ Backport to core/1.55 failed

Reason: Merge conflicts detected during cherry-pick of 1c2a416

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-18843-to-core-1.55 (from origin/core/1.55) and
open a PR to core/1.55.

This may be a stacking conflict rather than a real one. #18846, #18668 are still open against core/1.55. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the needs-backport label to re-run this workflow.

📄 Conflicting files

🤖 Prompt for AI Agents
Backport PR #18843 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/18843) to core/1.55.
Cherry-pick merge commit 1c2a416900b2d146792a2ce037edccacd652437b onto new branch
backport-18843-to-core-1.55 from origin/core/1.55.
Resolve conflicts in: .

> **This may be a stacking conflict rather than a real one.** #18846, #18668 are still open against `core/1.55`. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the `needs-backport` label to re-run this workflow.

For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.55] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @dante01yoon

@comfy-pr-bot

Copy link
Copy Markdown
Member

⚠️ Backport to cloud/1.55 failed

Reason: Merge conflicts detected during cherry-pick of 1c2a416

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-18843-to-cloud-1.55 (from origin/cloud/1.55) and
open a PR to cloud/1.55.

This may be a stacking conflict rather than a real one. #18847 are still open against cloud/1.55. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the needs-backport label to re-run this workflow.

📄 Conflicting files

🤖 Prompt for AI Agents
Backport PR #18843 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/18843) to cloud/1.55.
Cherry-pick merge commit 1c2a416900b2d146792a2ce037edccacd652437b onto new branch
backport-18843-to-cloud-1.55 from origin/cloud/1.55.
Resolve conflicts in: .

> **This may be a stacking conflict rather than a real one.** #18847 are still open against `cloud/1.55`. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the `needs-backport` label to re-run this workflow.

For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.55] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @dante01yoon

@christian-byrne christian-byrne removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Sep 28, 2026
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
Comfy-Org#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including Comfy-Org#19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as Comfy-Org#18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_

Co-authored-by: Claude <noreply@anthropic.com>
claude Bot added a commit that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_

Co-authored-by: Claude <noreply@anthropic.com>
claude Bot added a commit that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_

Co-authored-by: Claude <noreply@anthropic.com>
christian-byrne pushed a commit that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
christian-byrne pushed a commit that referenced this pull request Sep 30, 2026
<!-- ccr-slack-attribution -->
_Requested by **Robert Paige** · [Slack
thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_

## Summary

`website-unit` / `website-unit-gate` is red on `main` and on every PR
because the live docs catalog has drifted past the hardcoded model
count.

## Changes

- **What**: `router-providers.test.ts` › "counts the models the docs
catalog lists" fetches
`docs.comfy.org/development/comfy-router/models.md` and asserts the
count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The
live catalog now lists 213 models while the constant was still pinned at
212, so the assertion fails on every run. Bumped
`ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed
`ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of
#18843 (which did the same 209 → 212 bump for the same reason on Sep
25). Only the count assertion was failing in CI, not any per-provider
row assertion, so the provider rows themselves were left untouched.

## Before / After

- **Before**: `website-unit` fails with `expected 213 to be 212`; blocks
unrelated PRs, including #19565.
- **After**: count matches the live catalog; `website-unit` /
`website-unit-gate` pass again.

## Review Focus

Minimal, scoped change: only the two constants in
`apps/website/src/config/router-providers.ts` were touched, following
the same pattern as #18843.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — ca29a458 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.55 Backport PRs for cloud 1.55 core/1.55 Backport PRs for core 1.55 risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants