Repository navigation
fix(website): bump the Router catalog model count to 212 - #18843
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4c04e82cb7e182e45b355bc268213632e8e94573
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-18843.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-r6v17w6sm-comfyui.vercel.app Last updated: 2026-09-25T11:55:27Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe router provider coverage verification date changed to 2026-09-25. The catalog model count changed from 209 to 212. ChangesRouter provider catalog metadata
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change updates the displayed catalog total and coverage date. No concrete regression is established, so it is mergeable subject to normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…t to 212 (#18844) Backport of #18843 to `core/1.55` (cherry-pick -x of ca29a45), opened ahead of the main merge because `website-unit` is red on every `core/1.55` PR. ## Why `router-providers.test.ts` fails on `core/1.55` with `expected 212 to be 209`, blocking the release-branch backports. ## Root cause The CI-only test compares the live docs catalog (now 212 models) with `ROUTER_CATALOG_MODEL_COUNT` (209). ## How Same two-line change as #18843: count → 212, verified date → 2026-09-25. ## AS IS / TO BE Same as #18843.
…nt to 212 (#18845) Backport of #18843 to `cloud/1.55` (cherry-pick -x of ca29a45), opened ahead of the main merge because `website-unit` is red on every `cloud/1.55` PR. ## Why `router-providers.test.ts` fails on `cloud/1.55` with `expected 212 to be 209`, blocking the release-branch backports. ## Root cause The CI-only test compares the live docs catalog (now 212 models) with `ROUTER_CATALOG_MODEL_COUNT` (209). ## How Same two-line change as #18843: count → 212, verified date → 2026-09-25. ## AS IS / TO BE Same as #18843.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18843 +/- ##
==========================================
- Coverage 84.91% 83.91% -1.00%
==========================================
Files 2339 3027 +688
Lines 133169 150860 +17691
Branches 35933 40991 +5058
==========================================
+ Hits 113081 126601 +13520
- Misses 19741 22882 +3141
- Partials 347 1377 +1030
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 757 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of Comfy-Org#18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including Comfy-Org#19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as Comfy-Org#18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_ Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_ Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_ Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
Why
website-unitis red on main and on everycore/1.55/cloud/1.55PR:router-providers.test.ts› "counts the models the docs catalog lists" fails withexpected 212 to be 209. It blocks unrelated PRs, including the billing backports.Root cause
The test reads the live docs catalog (
docs.comfy.org/development/comfy-router/models.md) in CI and compares it withROUTER_CATALOG_MODEL_COUNT. The docs added three models after #18489 pinned the count at 209. The code is fine; the constant fell behind the docs.How
ROUTER_CATALOG_MODEL_COUNT209 → 212, matching the live catalog today (212 unique model paths).ROUTER_PROVIDER_COVERAGE_VERIFIED_AT→2026-09-25; the provider rows were re-checked against the docs in the same run.CI=1 pnpm exec vitest run src/config/router-providers.test.ts src/templates/platform/RouterProviderCoverageSection.test.tspasses 11/11 locally, including the live-docs checks. The page's "Browse all N models" link and the Comfy-only count follow the constant.Same change as #18804, which was closed without merging. Labelled for
core/1.55andcloud/1.55so the release branches go green too.AS IS / TO BE
AS IS: placeholder ("Browse all 209 models")
TO BE: placeholder ("Browse all 212 models")