Repository navigation
fix(website): polish comfy-api hero animation, badges, and page content - #19565
Conversation
Swap the /platform Comfy API card's visual from ServerlessIsometricStudy (the yellow block-growth study) to ServerlessJsonApiGpuAnimation, the same JSON-pipeline/GPU-orchestration animation used on the /platform/comfy-api hero. Both components share identical wrapper sizing classes, so no layout changes were needed.
- Center compact ProductHeroBadge labels (API, Router, Builds) and fix PlatformHeroBadge centering for standalone/large usage - Give the Router badge the Comfy wordmark, matching the API badge - Reduce the Builder hero heading weight from bold to light - Fix the comfy-api hero animation's iframe framing (viewBox, sizing) and restore the centered API lettering on the lid with fixed coordinates instead of a runtime bbox measurement - Mount the hero animation iframe only after the component mounts to avoid an intermittent disappearance - Right-align outgoing chat messages and give each exchange its own fixed workflow endpoint instead of sharing one across the animation - Add a copy-to-clipboard control to the deploy terminal that copies only the runnable commands - Reinstate and reposition the Silverside customer quote section between "Built for teams" and pricing on the Comfy API page
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (19 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6404d3d07e6506a987649577c83bb137b448887a
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19565.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-97nvir6u7-comfyui.vercel.app Last updated: 2026-09-30T05:13:45Z for |
CI red:
|
…ks (#19473) ## ELI5 Right now we can see when someone opens a Workshop model's API tab, but not whether they go any further. This PR records the two actions that come next — copying the code snippet and clicking "Get API key" — and tags each with the model, so we can tell which models turn visitors into developers. ## Motivation Before this change, `website:workshop_api_viewed` was the last Workshop signal on the API tab, so PostHog could not tell a visitor who read the snippet from one who copied it or went on to get an API key. Tracking those two clicks per model is needed to measure how far API-tab visitors get toward actually calling a model. ## Provenance - **Authored by:** interactive session - **Verified:** after merging main (#19494 — feat(website): Workshop /models SEO integration branch): `vitest run` on ModelDetail, WorkflowPlayground, WorkflowApi, ApiTab, ApiTab.execution and `src/scripts` (12 files): 305 passed. Playwright against a fresh production build: `workshop-api-analytics` and `workshop-delivery` pass; `workshop-api-actions` "the model API tab opens with the key action…" fails intermittently (5/8 with `--repeat-each=8`) on this branch and identically on an unmodified main build, so it predates this PR. The new copy tests fail when their wiring is removed, and flag-off tests assert nothing is sent. `eslint` and `oxfmt` on the changed files: clean. - **Deviations:** the legacy `pages/workshop/models/[slug].astro` playground keeps its own "Get API key" link and is not tracked. `models-render-guard.spec.ts` › `/hub/models/` "settles without a loader" fails on an unmodified main build too (2/20 desktop cases locally), so it is left to a separate fix. ## Reviewer context - **Type:** feature, two new PostHog events on the Workshop API tabs - **Slots into:** follows #19451 — feat(website): tell Workshop models, workflows and apps apart in analytics; the new events carry the same `page_type` split ## Summary - `website:workshop_api_snippet_copied` fires on the API tab's copy button. It carries the model analytics fields (`model_slug`, `page_type`, `router_id`/`workflow_id`, `provider`, `modality`, `render_engine`) plus `snippet_language` (`python` | `typescript` | `curl`). - `website:workshop_api_key_clicked` fires on the API tab's "Get API key" button, with the same model fields. - Both fire on the model API tab (`page_type: 'model'`) and the workflow API tab (`page_type: 'workflow'`). `ApiTab` and `WorkflowApi` emit `copy` / `getKey`, and `ModelDetail` / `WorkflowPlayground` send the events with the model's analytics fields, the same way `api_viewed` works. - New e2e spec `workshop-api-analytics.spec.ts` copies the cURL snippet and clicks Get API key on a model page and a workflow page, and checks the PostHog requests. The PostHog request decoding moved from `workshop-delivery.spec.ts` into a shared `e2e/fixtures/posthogEvents.ts`. - Also adds the missing trailing slash to the Svedka customer story link on the comfy-api page (`ServerlessCustomerProofSection.vue`, from #19565 on main), which was failing the website build's internal-link check for this PR. - Like `api_viewed`, nothing is sent while the Workshop flag (plus the Workflows flag on workflow pages) is off. Neither event goes to Datadog, because `workshopHealthLog` only logs run events. ## Test plan - [ ] On a Vercel preview with Workshop enabled, open a model's API tab, copy a snippet, and confirm `website:workshop_api_snippet_copied` with the right `model_slug` and `snippet_language` in PostHog - [ ] Click "Get API key" and confirm `website:workshop_api_key_clicked` with the right `model_slug` - [ ] Repeat on a workflow page and confirm `page_type: 'workflow'` - [ ] No feature flag of its own: the events are analytics-only and sit behind the existing Workshop flags --------- Co-authored-by: eric.sun <shengkai.sun@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: benjcooley <benjcooley@gmail.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of Comfy-Org#18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including Comfy-Org#19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as Comfy-Org#18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_ Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_ Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_ Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
<!-- ccr-slack-attribution --> _Requested by **Robert Paige** · [Slack thread](https://comfy-organization.slack.com/archives/C0B61J7QCJW/p1790743770365959?thread_ts=1790743770.365959&cid=C0B61J7QCJW)_ ## Summary `website-unit` / `website-unit-gate` is red on `main` and on every PR because the live docs catalog has drifted past the hardcoded model count. ## Changes - **What**: `router-providers.test.ts` › "counts the models the docs catalog lists" fetches `docs.comfy.org/development/comfy-router/models.md` and asserts the count of distinct model paths equals `ROUTER_CATALOG_MODEL_COUNT`. The live catalog now lists 213 models while the constant was still pinned at 212, so the assertion fails on every run. Bumped `ROUTER_CATALOG_MODEL_COUNT` 212 → 213 and refreshed `ROUTER_PROVIDER_COVERAGE_VERIFIED_AT` to today, matching the shape of #18843 (which did the same 209 → 212 bump for the same reason on Sep 25). Only the count assertion was failing in CI, not any per-provider row assertion, so the provider rows themselves were left untouched. ## Before / After - **Before**: `website-unit` fails with `expected 213 to be 212`; blocks unrelated PRs, including #19565. - **After**: count matches the live catalog; `website-unit` / `website-unit-gate` pass again. ## Review Focus Minimal, scoped change: only the two constants in `apps/website/src/config/router-providers.ts` were touched, following the same pattern as #18843. --- _Generated by [Claude Code](https://claude.ai/code/session_01QByuWtiNix7Q4BY6kvhgPR)_
Requested by Robert Paige · Slack thread
Summary
Follow-up round of
/platformand/platform/comfy-apipolish: badge centering and the Router wordmark, the Builder hero weight, the comfy-api hero animation's framing/lettering/mount timing, the how-it-works chat alignment and endpoints, a copy button on the deploy terminal, and the Silverside customer quote.Changes
/platform:ProductHeroBadge.vueonly nudges compact badge text down when non-compact (fixes vertical centering of the API/Router/Builds labels);PlatformHeroBadge.vueonly applies the centering offset whencenterTextis set (fixes the large standalone Developer Platform/API/Builds badges).ProductsSection.vue's Router badge now uses:show-connector="false"(was:show-logo="false") so it renders the Comfy wordmark the same way the API badge does, with a newplatform.products.models.badgeLabel("ROUTER") string./platform/builder:BuilderHero.vue's title class switches fromfont-boldtofont-light./platform/comfy-api:json-api-gpu-animation.html: the "API" lid lettering is centered with a fixed transform instead of a runtimegetBBox()measurement (the measurement could land off-center depending on font load timing), the sceneviewBoxis adjusted to remove clipping, and the redundant<title>element is dropped in favor ofaria-label(the accessible name was duplicated between the two).ServerlessJsonApiGpuAnimation.vue: the iframe only mounts afteronMounted(mitigates an intermittent disappearance) and the wrapper switches toabsolute inset-0sizing with a taller aspect ratio onlg.TeamSharingChat.vue: outgoing messages are right-aligned (flex-row-reverse), the sharedendpointprop is replaced with a fixed endpoint per exchange (try-on-x7k2,product-photos,upscale-4k) so each bubble keeps its own link instead of all three syncing to one, andServerlessHowItWorksSection.vueno longer passes the now-removed prop.ServerlessDeploySection.vue: adds a copy-to-clipboard button in the terminal's corner that copies only the three$-prefixed commands (prompts and sample output excluded), viauseClipboard.ServerlessCustomerProofSection(already built, previously unused on this page) is now rendered withshowCustomerProofand moved to sit between "Built for teams" and pricing; its quote/name/role strings are updated to the Silverside AI testimonial from Allie Wrubel, Head of Technology.translations.ts: adds/updates the strings above for bothenandzh-CN.@vueuse/coreand@lucide/vuewere already workspace dependencies)Review Focus
viewBoxare now fixed values tuned against the current markup; if the SVG content above them changes again, these will need re-tuning rather than falling back to a measured center.Verification
pnpm --filter @comfyorg/website test:unit src/templates/platform/ServerlessDeploySection.test.ts src/templates/platform/ServerlessHero.test.ts src/templates/platform/TeamSharingChat.test.ts src/templates/platform/PlatformHeroBadge.test.ts src/templates/platform/ProductsSection.test.ts: 11 passedpnpm exec eslinton every changed file: cleanpnpm typecheck:website: 0 errorspnpm format:astro:check: cleanknip/fallowaudit both passed on this branch.Screenshots (if applicable)
None captured in this sandbox — see Verification.
Generated by Claude Code