Repository navigation
[backport cloud/1.55] fix(website): bump the Router catalog model count to 212 - #18845
Conversation
(cherry picked from commit ca29a45)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8da5a92142fb7c235112fbd71ed30b235d8f4488
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #18845 +/- ##
=============================================
Coverage ? 83.63%
=============================================
Files ? 2985
Lines ? 148107
Branches ? 40142
=============================================
Hits ? 123866
Misses ? 22986
Partials ? 1255
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #18843 to
cloud/1.55(cherry-pick -x of ca29a45), opened ahead of the main merge becausewebsite-unitis red on everycloud/1.55PR.Why
router-providers.test.tsfails oncloud/1.55withexpected 212 to be 209, blocking the release-branch backports.Root cause
The CI-only test compares the live docs catalog (now 212 models) with
ROUTER_CATALOG_MODEL_COUNT(209).How
Same two-line change as #18843: count → 212, verified date → 2026-09-25.
AS IS / TO BE
Same as #18843.