Skip to content

[backport core/1.55] fix(website): bump the Router catalog model count to 212 - #18844

Merged
dante01yoon merged 1 commit into
core/1.55from
backport-18843-to-core-1.55
Sep 25, 2026
Merged

dante01yoon merged 1 commit into
core/1.55from
backport-18843-to-core-1.55

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Backport of #18843 to core/1.55 (cherry-pick -x of ca29a45), opened ahead of the main merge because website-unit is red on every core/1.55 PR.

Why

router-providers.test.ts fails on core/1.55 with expected 212 to be 209, blocking the release-branch backports.

Root cause

The CI-only test compares the live docs catalog (now 212 models) with ROUTER_CATALOG_MODEL_COUNT (209).

How

Same two-line change as #18843: count → 212, verified date → 2026-09-25.

AS IS / TO BE

Same as #18843.

@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 25, 2026 11:54am UTC
billing-web-test Skipped Skipped Sep 25, 2026 11:54am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4f779c17-a89a-4961-909b-b22ccfcc8b6d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Caution

Some tests failed.

Status ❌ Failed
Report View Report
Screenshot diffs 1
Other failures 1
  • Update website screenshots (1 screenshot diff)

Warning

1 non-screenshot failure — these require manual review.

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 940debe7feb8edf2e30d11fccc19d0e03c053401

Full docs: ADR-DEVEX-LINT-0015

@dante01yoon
dante01yoon enabled auto-merge (squash) September 25, 2026 11:56
@dante01yoon
dante01yoon merged commit f8e3085 into core/1.55 Sep 25, 2026
74 of 75 checks passed
@dante01yoon
dante01yoon deleted the backport-18843-to-core-1.55 branch September 25, 2026 11:56
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 25, 2026
@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##           core/1.55   #18844      +/-   ##
=============================================
- Coverage      84.58%   83.63%   -0.96%     
=============================================
  Files           2294     2985     +691     
  Lines         131243   148160   +16917     
  Branches       33524    38274    +4750     
=============================================
+ Hits          111013   123912   +12899     
- Misses         19931    22994    +3063     
- Partials         299     1254     +955     
Flag Coverage Δ
website-unit 76.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/router-providers.ts 100.00% <100.00%> (ø)

... and 690 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — aff5f2e4 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants