Repository navigation
[backport core/1.55] test(agent): pin the nested-subgraph-instance insert_workflow gap (PR #18607 follow-up) - #18676
Conversation
…18607 follow-up) (#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. ---------
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e1edc04062b3865d0fd0b1c66473539bdac36979
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T11:47:07.408Z",
"gitSha": "697f17d65fca46ff7b1874f5efc4212a96b9aef0",
"branch": "backport-18624-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.5670000000318,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.26000000000005,
"heapDeltaBytes": -1552300,
"heapUsedBytes": 66033492,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.570000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1999.225000000024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.322999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.52900000000005,
"heapDeltaBytes": -3979580,
"heapUsedBytes": 63562772,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.959999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1734.767999999974,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.943000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.003,
"heapDeltaBytes": -6398204,
"heapUsedBytes": 61266524,
"domNodes": -257,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 166.97099999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.0209999999752,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.581,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.352,
"heapDeltaBytes": -5266488,
"heapUsedBytes": 62588468,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 161.448,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.6440000000593,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.418,
"layouts": 6,
"layoutDurationMs": 1.001,
"taskDurationMs": 339.612,
"heapDeltaBytes": 3126772,
"heapUsedBytes": 70818724,
"domNodes": 79,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.407,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0620000000508,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.971,
"layouts": 6,
"layoutDurationMs": 1.0240000000000002,
"taskDurationMs": 350.324,
"heapDeltaBytes": 3134324,
"heapUsedBytes": 70890732,
"domNodes": 80,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.730999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 624.9139999999898,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.675,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.25899999999996,
"heapDeltaBytes": 18943732,
"heapUsedBytes": 86545836,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 164.841,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 633.1959999999981,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.980000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.0930000000001,
"heapDeltaBytes": 18309884,
"heapUsedBytes": 80706600,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 171.73,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.3480000000282,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.0849999999999,
"heapDeltaBytes": 33927864,
"heapUsedBytes": 104791820,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 71.815,
"eventListeners": 0,
"totalBlockingTimeMs": 558,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.4269999999424,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 839.5740000000001,
"heapDeltaBytes": 12153692,
"heapUsedBytes": 83687096,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 68.014,
"eventListeners": 0,
"totalBlockingTimeMs": 561,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.9760000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.5849999999998,
"heapDeltaBytes": 15851284,
"heapUsedBytes": 92164148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.33899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.3319999998903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.7290000000005,
"heapDeltaBytes": 14442604,
"heapUsedBytes": 89802032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.039,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11187.673000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10326.018999999998,
"heapDeltaBytes": -13331588,
"heapUsedBytes": 69028640,
"domNodes": -18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8590.452,
"eventListeners": 0,
"totalBlockingTimeMs": 1604,
"frameDurationMs": 20.003333333333405,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11212.791999999921,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0979999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10390.670999999998,
"heapDeltaBytes": -6505272,
"heapUsedBytes": 70798152,
"domNodes": -273,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8666.72,
"eventListeners": -174,
"totalBlockingTimeMs": 1495,
"frameDurationMs": 20,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10899.460999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10047.048999999999,
"heapDeltaBytes": 108572,
"heapUsedBytes": 81975012,
"domNodes": -12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8379.374,
"eventListeners": 0,
"totalBlockingTimeMs": 1278,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10376.077000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9516.398000000001,
"heapDeltaBytes": -1902820,
"heapUsedBytes": 72372608,
"domNodes": -4,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7919.223000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1097,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2021.6990000000123,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.172999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.974,
"heapDeltaBytes": -3933280,
"heapUsedBytes": 83360300,
"domNodes": -243,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 32.63099999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2024.1730000000189,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.0440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.74,
"heapDeltaBytes": -3544012,
"heapUsedBytes": 83227512,
"domNodes": -245,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.147999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2296.009999999967,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1630.191,
"heapDeltaBytes": 19706880,
"heapUsedBytes": 84001628,
"domNodes": -244,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 846.591,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2481.7070000000285,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.500000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1707.4579999999999,
"heapDeltaBytes": 20981060,
"heapUsedBytes": 85729732,
"domNodes": 6,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 933.191,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3525.2950000000283,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.152000000000003,
"layouts": 60,
"layoutDurationMs": 13.167,
"taskDurationMs": 1697.9599999999998,
"heapDeltaBytes": 7794620,
"heapUsedBytes": 73818792,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 794.2139999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3636.0050000000683,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.673,
"layouts": 60,
"layoutDurationMs": 13.682000000000002,
"taskDurationMs": 1760.6360000000004,
"heapDeltaBytes": -18682464,
"heapUsedBytes": 69456756,
"domNodes": -265,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 808.7410000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3190.915000000018,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.3939999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1994.9550000000002,
"heapDeltaBytes": 2672488,
"heapUsedBytes": 68714732,
"domNodes": 6,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 1072.044,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3066.416000000004,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.139999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1830.5450000000003,
"heapDeltaBytes": 24096244,
"heapUsedBytes": 90065812,
"domNodes": 8,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1031.557,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.0510000000713,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.192999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.23,
"heapDeltaBytes": -4060836,
"heapUsedBytes": 84128820,
"domNodes": -246,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 35.55,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.4839999999822,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.5569999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.5089999999999,
"heapDeltaBytes": -3732376,
"heapUsedBytes": 84558548,
"domNodes": -245,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.803,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.031999999951,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.088999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.14700000000005,
"heapDeltaBytes": 13568576,
"heapUsedBytes": 77445616,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.01,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 554.0960000000723,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.144000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.67800000000005,
"heapDeltaBytes": 13777396,
"heapUsedBytes": 83466180,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.461,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2006.9169999999872,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.213,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.7710000000001,
"heapDeltaBytes": 70488,
"heapUsedBytes": 69509988,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.908000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.7220000000716,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.889,
"heapDeltaBytes": 2988816,
"heapUsedBytes": 71956632,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.079000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.0639999999971,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.89,
"heapDeltaBytes": 4863068,
"heapUsedBytes": 74749172,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 104.235,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.1059999999825,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.153000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 748.894,
"heapDeltaBytes": 10740756,
"heapUsedBytes": 80102016,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 107.658,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.5060000000267,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.58899999999999,
"layouts": 5,
"layoutDurationMs": 13.106,
"taskDurationMs": 907.5210000000001,
"heapDeltaBytes": 23259052,
"heapUsedBytes": 96136480,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.702,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8423.186999999984,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.332,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5885.569,
"heapDeltaBytes": 18140768,
"heapUsedBytes": 97943200,
"domNodes": -254,
"jsHeapTotalBytes": 4640768,
"scriptDurationMs": 2885.977,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8464.727000000039,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5904.846,
"heapDeltaBytes": -18494776,
"heapUsedBytes": 68493256,
"domNodes": -215,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 2871.618,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12573.415000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11837.09,
"heapDeltaBytes": -87707116,
"heapUsedBytes": 173417936,
"domNodes": -8062,
"jsHeapTotalBytes": -26284032,
"scriptDurationMs": 208.373,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16880.043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16480.315,
"heapDeltaBytes": -31707700,
"heapUsedBytes": 188368100,
"domNodes": -8061,
"jsHeapTotalBytes": -16408576,
"scriptDurationMs": 293.21000000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19938.985,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.438999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19644.533,
"heapDeltaBytes": -61590964,
"heapUsedBytes": 180780336,
"domNodes": -8061,
"jsHeapTotalBytes": -24293376,
"scriptDurationMs": 877.887,
"eventListeners": -14928,
"totalBlockingTimeMs": 54,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20839.424000000006,
"styleRecalcs": 161,
"styleRecalcDurationMs": 17.389000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20593.439,
"heapDeltaBytes": -29130340,
"heapUsedBytes": 189358924,
"domNodes": -8061,
"jsHeapTotalBytes": -18165760,
"scriptDurationMs": 898.4870000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6094.053000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.41400000000002,
"layouts": 20,
"layoutDurationMs": 24.25899999999999,
"taskDurationMs": 6007.227999999999,
"heapDeltaBytes": -37425988,
"heapUsedBytes": 176718980,
"domNodes": -8061,
"jsHeapTotalBytes": 19075072,
"scriptDurationMs": 111.87199999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 427,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6165.391999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.22699999999999,
"layouts": 20,
"layoutDurationMs": 23.882,
"taskDurationMs": 6087.349,
"heapDeltaBytes": -63887580,
"heapUsedBytes": 176164744,
"domNodes": -8061,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 103.76100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 422,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8477.606000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8241.141999999998,
"heapDeltaBytes": -7395476,
"heapUsedBytes": 165062052,
"domNodes": 0,
"jsHeapTotalBytes": -25952256,
"scriptDurationMs": 129.96599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8477.821999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8217.103,
"heapDeltaBytes": 11048916,
"heapUsedBytes": 194070836,
"domNodes": 0,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 126.68600000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 117.78199999992012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.668999999999997,
"layouts": 5,
"layoutDurationMs": 2.1229999999999998,
"taskDurationMs": 94.023,
"heapDeltaBytes": 3253468,
"heapUsedBytes": 68855320,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.14,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 100.56900000006408,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.011,
"layouts": 3,
"layoutDurationMs": 1.8070000000000002,
"taskDurationMs": 73.302,
"heapDeltaBytes": 2970624,
"heapUsedBytes": 68471964,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.539000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @huang47.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 1 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #18676 +/- ##
=============================================
+ Coverage 83.65% 84.52% +0.86%
=============================================
Files 3019 2294 -725
Lines 148883 131383 -17500
Branches 40342 35466 -4876
=============================================
- Hits 124553 111051 -13502
+ Misses 23027 20032 -2995
+ Partials 1303 300 -1003
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
f42bcf4 to
89023d4
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
I force-pushed this branch to strip Co-authored-by trailers for claude/Amp from the commit messages, which is what Check for AI agent co-author trailers was failing on. Message-only rewrite: the tree hash is identical to before, so the code is untouched.
Backport of #18624 to
core/1.55Automatically created by backport workflow.