Repository navigation
chore: bump comfy-multi-player to 0.3.6 - #18626
Conversation
Pulls in the nested-subgraph-insert fix (comfy-multi-player#253).
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3878a52ee9c467a27295a7b9f87ee779fffe3e43
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.98 MB gzip 🔴 +286 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +17.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 124 kB (baseline 117 kB) • 🔴 +6.54 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.95 MB (baseline 3.6 MB) • 🔴 +349 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.8 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.43 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T19:38:45.170Z",
"gitSha": "dda1cc9ec1e46c561deffef624205378397e5dfc",
"branch": "chore/bump-comfy-multi-player-0.3.6-main",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.1790000000128,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.4339999999999,
"heapDeltaBytes": -7058892,
"heapUsedBytes": 60460120,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 14.133,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2022.6989999999887,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.497,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.513,
"heapDeltaBytes": 9972832,
"heapUsedBytes": 77511992,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.258999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.1410000000096,
"styleRecalcs": 44,
"styleRecalcDurationMs": 16.467999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 900.4590000000001,
"heapDeltaBytes": 10429024,
"heapUsedBytes": 78040824,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 174.25099999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.206000000002,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.573000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 874.136,
"heapDeltaBytes": -2263076,
"heapUsedBytes": 60182664,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 170.426,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.8670000000134,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.157,
"layouts": 6,
"layoutDurationMs": 1.2940000000000003,
"taskDurationMs": 424.592,
"heapDeltaBytes": 3109268,
"heapUsedBytes": 70951256,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 17.789,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6290000000736,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.241,
"layouts": 6,
"layoutDurationMs": 1.0569999999999997,
"taskDurationMs": 342.70199999999994,
"heapDeltaBytes": 2827380,
"heapUsedBytes": 70369348,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.516,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 718.4090000000083,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.11499999999995,
"heapDeltaBytes": 18857720,
"heapUsedBytes": 86492380,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 179.444,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 634.4249999999647,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.91700000000003,
"heapDeltaBytes": 18927432,
"heapUsedBytes": 86663292,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 173.132,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1341.2490000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1050.274,
"heapDeltaBytes": 38583012,
"heapUsedBytes": 107609592,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 77.66400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 727,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1208.0349999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 877.091,
"heapDeltaBytes": 12043448,
"heapUsedBytes": 84151096,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 71.335,
"eventListeners": 0,
"totalBlockingTimeMs": 584,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.7190000000219,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.97700000000003,
"heapDeltaBytes": 14463648,
"heapUsedBytes": 90807688,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.72800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 239,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4000000000169,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.1370000000004,
"heapDeltaBytes": 14666612,
"heapUsedBytes": 91094500,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.43200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11573.082999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10541.152,
"heapDeltaBytes": 1051316,
"heapUsedBytes": 83204784,
"domNodes": -16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8929.849,
"eventListeners": 0,
"totalBlockingTimeMs": 1735,
"frameDurationMs": 18.89333333333331,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11805.382000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10877.329000000002,
"heapDeltaBytes": 1969524,
"heapUsedBytes": 84024172,
"domNodes": -18,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 9030.791000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1906,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12417.777000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11428.676,
"heapDeltaBytes": 9246168,
"heapUsedBytes": 85527188,
"domNodes": -12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9472.133,
"eventListeners": 0,
"totalBlockingTimeMs": 1878,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11465.9190000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10447.196,
"heapDeltaBytes": 16172364,
"heapUsedBytes": 98500388,
"domNodes": -14,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 8949.962,
"eventListeners": 0,
"totalBlockingTimeMs": 1909,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2020.413000000019,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.963999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.356,
"heapDeltaBytes": -2767732,
"heapUsedBytes": 83958236,
"domNodes": -243,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 42.377999999999986,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2021.9670000000178,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.424,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.072,
"heapDeltaBytes": -3357608,
"heapUsedBytes": 83099204,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 39.895,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2612.62099999999,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.534000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1759.7460000000003,
"heapDeltaBytes": 19681700,
"heapUsedBytes": 84370312,
"domNodes": 8,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 883.407,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2136.920000000032,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.926,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1576.5969999999998,
"heapDeltaBytes": 18568796,
"heapUsedBytes": 83683344,
"domNodes": 6,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 827.767,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3826.457000000005,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.075,
"layouts": 60,
"layoutDurationMs": 14.602,
"taskDurationMs": 1912.0179999999998,
"heapDeltaBytes": 8480428,
"heapUsedBytes": 74597892,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 875.443,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3634.2639999999165,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.481,
"layouts": 60,
"layoutDurationMs": 13.548000000000002,
"taskDurationMs": 1750.052,
"heapDeltaBytes": 8511228,
"heapUsedBytes": 74257464,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 799.8420000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3203.687000000002,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.707000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2081.803,
"heapDeltaBytes": 25081820,
"heapUsedBytes": 91124864,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1063.796,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3119.93300000006,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.664,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1957.113,
"heapDeltaBytes": 587092,
"heapUsedBytes": 66557292,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1002.78,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.233999999955,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.534000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 723.506,
"heapDeltaBytes": -4504688,
"heapUsedBytes": 84208840,
"domNodes": -250,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 39.18299999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2012.7270000000408,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.974000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.79600000000005,
"heapDeltaBytes": 20221572,
"heapUsedBytes": 84296700,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.306000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 675.756999999976,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.893999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.137,
"heapDeltaBytes": 14105828,
"heapUsedBytes": 83932400,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 155.35800000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.4570000000676,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.040000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.626,
"heapDeltaBytes": 13725724,
"heapUsedBytes": 83501908,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.531,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2013.2520000000227,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.999999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.599,
"heapDeltaBytes": -14312536,
"heapUsedBytes": 55388864,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.771999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2008.6189999999533,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.548999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.0179999999999,
"heapDeltaBytes": -7364496,
"heapUsedBytes": 62813884,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.761999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.2259999999874,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.675,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 798.485,
"heapDeltaBytes": 2869476,
"heapUsedBytes": 72750200,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 118.99400000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.7020000000302,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.154000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 760.1830000000001,
"heapDeltaBytes": -3433088,
"heapUsedBytes": 65638560,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 108.89000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.1579999999349,
"styleRecalcs": 16,
"styleRecalcDurationMs": 30.923,
"layouts": 5,
"layoutDurationMs": 14.294999999999998,
"taskDurationMs": 1049.6460000000002,
"heapDeltaBytes": 20288032,
"heapUsedBytes": 103386732,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 36.83399999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9596.100000000035,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.55200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6505.582,
"heapDeltaBytes": -2163892,
"heapUsedBytes": 84519400,
"domNodes": -243,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 2989.082,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8507.925,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.44799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5968.537,
"heapDeltaBytes": -5595660,
"heapUsedBytes": 80854604,
"domNodes": -241,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2830.757,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17663.273000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17362.158,
"heapDeltaBytes": -17891344,
"heapUsedBytes": 190786068,
"domNodes": -8061,
"jsHeapTotalBytes": -12070912,
"scriptDurationMs": 289.885,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16870.671000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16413.525,
"heapDeltaBytes": -69625732,
"heapUsedBytes": 171683716,
"domNodes": -8061,
"jsHeapTotalBytes": -18550784,
"scriptDurationMs": 259.07500000000005,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21280.347000000005,
"styleRecalcs": 149,
"styleRecalcDurationMs": 20.608000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21138.699000000004,
"heapDeltaBytes": -53983252,
"heapUsedBytes": 180557944,
"domNodes": -8061,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 939.6,
"eventListeners": -14928,
"totalBlockingTimeMs": 134,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20853.073999999993,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.46800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20412.371,
"heapDeltaBytes": -57846144,
"heapUsedBytes": 180149564,
"domNodes": -8061,
"jsHeapTotalBytes": -17760256,
"scriptDurationMs": 900.449,
"eventListeners": -14928,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6372.685000000047,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.33600000000001,
"layouts": 20,
"layoutDurationMs": 25.836000000000013,
"taskDurationMs": 6337.858000000001,
"heapDeltaBytes": -40105028,
"heapUsedBytes": 178293404,
"domNodes": -8061,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 113.36699999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 479,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4615.415999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.60599999999998,
"layouts": 20,
"layoutDurationMs": 23.30399999999999,
"taskDurationMs": 4482.106999999999,
"heapDeltaBytes": -54615692,
"heapUsedBytes": 186486308,
"domNodes": -8061,
"jsHeapTotalBytes": 16314368,
"scriptDurationMs": 89.931,
"eventListeners": -14928,
"totalBlockingTimeMs": 163,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8818.268999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8689.630000000001,
"heapDeltaBytes": 14714716,
"heapUsedBytes": 191610176,
"domNodes": 0,
"jsHeapTotalBytes": -21757952,
"scriptDurationMs": 144.47199999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8363.993999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8140.002,
"heapDeltaBytes": 2435656,
"heapUsedBytes": 164598640,
"domNodes": 0,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 123.83699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 125.84400000002915,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.797999999999998,
"layouts": 2,
"layoutDurationMs": 0.708,
"taskDurationMs": 87.174,
"heapDeltaBytes": 3213364,
"heapUsedBytes": 68862404,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.787,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 469.88599999997405,
"styleRecalcs": 23,
"styleRecalcDurationMs": 25.378999999999998,
"layouts": 4,
"layoutDurationMs": 1.976,
"taskDurationMs": 120.54200000000002,
"heapDeltaBytes": 5047388,
"heapUsedBytes": 70716296,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.084,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18626 +/- ##
==========================================
- Coverage 83.64% 83.63% -0.01%
==========================================
Files 3018 3018
Lines 148750 148750
Branches 40307 38414 -1893
==========================================
- Hits 124417 124410 -7
- Misses 23032 23039 +7
Partials 1301 1301
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
comfy-multi-player was bumped to 0.3.6 (#18626) while this PR was queued, which carries the upstream fix (comfy-multi-player#253) for the nested-subgraph-instance insert_workflow gap this test pins. The merge queue caught it: with the pin bumped, the `it.fails` assertion unexpectedly passed, which Vitest treats as a failure ("Expect test to fail"), failing "CI: Tests Unit" on the gh-readonly-queue merge commit. Flip `it.fails` to a plain `it` and update the header comment now that the gap is fixed and pinned, per the PR's own documented follow-up. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
comfy-multi-player was bumped to 0.3.6 (#18626) while this PR was queued, which carries the upstream fix (comfy-multi-player#253) for the nested-subgraph-instance insert_workflow gap this test pins. The merge queue caught it: with the pin bumped, the `it.fails` assertion unexpectedly passed, which Vitest treats as a failure ("Expect test to fail"), failing "CI: Tests Unit" on the gh-readonly-queue merge commit. Flip `it.fails` to a plain `it` and update the header comment now that the gap is fixed and pinned, per the PR's own documented follow-up.
Requested by Christian Byrne · Slack thread
Before/After
Before: the pnpm catalog pinned
@comfyorg/comfy-multi-playerat0.3.5, which has the nested-subgraph-instanceinsert_workflowbug (an interior node that is itself a subgraph instance materializes widget-less becauseremapInsertedWorkflowIds()didn't resolve the flat-siblingtypereference litegraph's serializer actually emits).After: bumps the catalog pin (
pnpm-workspace.yaml+pnpm-lock.yaml,minimumReleaseAgeExcludeentry) to0.3.6, which carries the fix fromcomfy-multi-player#253.Note on scope
This PR is the pin bump only. PR #18624 (which added a
it.failsregression test for this exact bug, keyed to flip once this dependency lands) is still open/unmerged onmainas of this PR — itsmergeable_stateisblocked. Since the test doesn't exist onmainyet, there's nothing to flip here; once #18624 merges, a follow-up should flip itsit.failsto a plainit(it will pass — see verification below).Testing
pnpm install --frozen-lockfileresolves clean against0.3.6(verified installednode_modules/@comfyorg/comfy-multi-player/package.jsonreports0.3.6).pnpm exec vitest run src/workbench/extensions/agent/crdt/: 925 passed, 15 expected-fail (0.3.5 baseline, no regressions from the bump alone).0.3.6is actually live on the public npm registry (dist-tags.latest = 0.3.6, integrity matches the release workflow's packed tarball) before opening this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code