Repository navigation
chore: bump comfy-multi-player to 0.3.6 (core/1.54) - #18628
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Pulls in the nested-subgraph-insert fix (comfy-multi-player#253). core/1.54 landed at 0.3.5 (via #18617, concurrently with this PR's original 0.3.4 base) before this could merge; rebased onto that and bumped straight through to 0.3.6.
2730c67 to
875f832
Compare
🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 1942 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T19:45:07.321Z",
"gitSha": "083ec147a9d4192747c8e89888b4b8411f4e45a6",
"branch": "chore/bump-comfy-multi-player-0.3.6-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2002.839999999992,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.65,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.198,
"heapDeltaBytes": -1584820,
"heapUsedBytes": 67961532,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.474999999999998,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.7819999999065,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.465999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.841,
"heapDeltaBytes": 4633172,
"heapUsedBytes": 74716724,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.960999999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.4550000000304,
"styleRecalcs": 74,
"styleRecalcDurationMs": 24.479,
"layouts": 14,
"layoutDurationMs": 4.083,
"taskDurationMs": 620.668,
"heapDeltaBytes": -12984884,
"heapUsedBytes": 57552740,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 105.491,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1706.1390000000074,
"styleRecalcs": 73,
"styleRecalcDurationMs": 22.726,
"layouts": 14,
"layoutDurationMs": 3.979,
"taskDurationMs": 563.914,
"heapDeltaBytes": -9746520,
"heapUsedBytes": 59861248,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 96.07400000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.5379999999982,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.242999999999999,
"layouts": 6,
"layoutDurationMs": 1.0450000000000002,
"taskDurationMs": 226.50199999999998,
"heapDeltaBytes": 4360064,
"heapUsedBytes": 74272344,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.734999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.4809999999525,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.672,
"layouts": 6,
"layoutDurationMs": 1.0230000000000001,
"taskDurationMs": 239.34100000000004,
"heapDeltaBytes": 4352132,
"heapUsedBytes": 74312436,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.189999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 545.0340000000438,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.596,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.252,
"heapDeltaBytes": 18739176,
"heapUsedBytes": 88425540,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 113.28799999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 475.25099999995746,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.488999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.78499999999997,
"heapDeltaBytes": 18686828,
"heapUsedBytes": 88672368,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 100.327,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2022.991999999988,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.787,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.94999999999993,
"heapDeltaBytes": 4320784,
"heapUsedBytes": 80679732,
"domNodes": -275,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 25.685999999999993,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2019.9790000000348,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.49,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.027,
"heapDeltaBytes": 7924400,
"heapUsedBytes": 83846876,
"domNodes": -284,
"jsHeapTotalBytes": -106496,
"scriptDurationMs": 24.841,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2100.746000000015,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.031999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1077.9209999999998,
"heapDeltaBytes": 18591800,
"heapUsedBytes": 84975880,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 534.759,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2293.2449999999562,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.114,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1229.284,
"heapDeltaBytes": 5484368,
"heapUsedBytes": 82448812,
"domNodes": -235,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 598.091,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3235.7050000000527,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.376,
"layouts": 60,
"layoutDurationMs": 13.727,
"taskDurationMs": 1240.637,
"heapDeltaBytes": -695752,
"heapUsedBytes": 78297172,
"domNodes": -287,
"jsHeapTotalBytes": 3039232,
"scriptDurationMs": 522.616,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3163.9220000000705,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.979999999999999,
"layouts": 60,
"layoutDurationMs": 13.109,
"taskDurationMs": 1169.737,
"heapDeltaBytes": 8503212,
"heapUsedBytes": 76095092,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 513.708,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2309.035999999992,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.463,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1349.776,
"heapDeltaBytes": 264480,
"heapUsedBytes": 81075312,
"domNodes": -272,
"jsHeapTotalBytes": -212992,
"scriptDurationMs": 638.747,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2214.8389999999836,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.819000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1273.021,
"heapDeltaBytes": 17563448,
"heapUsedBytes": 85894552,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 621.7539999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2001.8739999999866,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.474,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.00000000000006,
"heapDeltaBytes": 21984816,
"heapUsedBytes": 87787764,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.193999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.0259999999726,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.504000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.665,
"heapDeltaBytes": 21846772,
"heapUsedBytes": 87673344,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.221999999999998,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 443.3599999999842,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.605000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 275.65000000000003,
"heapDeltaBytes": 14724892,
"heapUsedBytes": 87900344,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 92.606,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.03100000008,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.179,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.63800000000003,
"heapDeltaBytes": 15023272,
"heapUsedBytes": 88070056,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 92.81500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.9089999999546,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.556999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.733,
"heapDeltaBytes": -14353544,
"heapUsedBytes": 58769468,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 6.666,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.8440000000382,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.55,
"heapDeltaBytes": -8881188,
"heapUsedBytes": 64487216,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.435,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.7590000000005,
"styleRecalcs": 80,
"styleRecalcDurationMs": 26.843999999999998,
"layouts": 18,
"layoutDurationMs": 4.909999999999999,
"taskDurationMs": 591.224,
"heapDeltaBytes": -8041520,
"heapUsedBytes": 64116256,
"domNodes": -293,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 85.201,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.0409999999938,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.729,
"layouts": 18,
"layoutDurationMs": 4.890000000000001,
"taskDurationMs": 566.163,
"heapDeltaBytes": -14864152,
"heapUsedBytes": 57972500,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 79.939,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.4080000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.544,
"layouts": 16,
"layoutDurationMs": 10.828,
"taskDurationMs": 599.0629999999999,
"heapDeltaBytes": -7158508,
"heapUsedBytes": 82771420,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 19.664,
"eventListeners": 2385,
"totalBlockingTimeMs": 72,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8255.995999999981,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.7,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3978.3379999999997,
"heapDeltaBytes": 12249392,
"heapUsedBytes": 88897724,
"domNodes": -265,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 1835.864,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8167.670000000044,
"styleRecalcs": 250,
"styleRecalcDurationMs": 44.94,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4002.9080000000004,
"heapDeltaBytes": 4263428,
"heapUsedBytes": 80889152,
"domNodes": -274,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 1908.7130000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12730.009000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11794.016000000001,
"heapDeltaBytes": -39601308,
"heapUsedBytes": 176411568,
"domNodes": -8068,
"jsHeapTotalBytes": -25718784,
"scriptDurationMs": 196.397,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12695.487999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12017.076,
"heapDeltaBytes": -35874240,
"heapUsedBytes": 182401480,
"domNodes": -8068,
"jsHeapTotalBytes": -12054528,
"scriptDurationMs": 180.447,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15083.59100000007,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.98000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14562.077,
"heapDeltaBytes": -28717916,
"heapUsedBytes": 199656304,
"domNodes": -8068,
"jsHeapTotalBytes": -9707520,
"scriptDurationMs": 636.333,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15025.88000000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14536.838000000002,
"heapDeltaBytes": -34862736,
"heapUsedBytes": 185448928,
"domNodes": -8068,
"jsHeapTotalBytes": -15593472,
"scriptDurationMs": 623.9590000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4464.590000000044,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.27600000000002,
"layouts": 20,
"layoutDurationMs": 20.923,
"taskDurationMs": 4350.986,
"heapDeltaBytes": -41003428,
"heapUsedBytes": 185396344,
"domNodes": -8068,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 69.09999999999998,
"eventListeners": -14931,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4534.441000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.708000000000006,
"layouts": 20,
"layoutDurationMs": 21.478000000000012,
"taskDurationMs": 4419.325,
"heapDeltaBytes": -37325092,
"heapUsedBytes": 181042776,
"domNodes": -8068,
"jsHeapTotalBytes": 15208448,
"scriptDurationMs": 76.649,
"eventListeners": -14931,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6334.341000000109,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6015.176,
"heapDeltaBytes": 17385168,
"heapUsedBytes": 189610864,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 90.24600000000005,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6385.960000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6138.341,
"heapDeltaBytes": -9413300,
"heapUsedBytes": 171058756,
"domNodes": 0,
"jsHeapTotalBytes": -28311552,
"scriptDurationMs": 88.37800000000001,
"eventListeners": 16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 73.22599999997692,
"styleRecalcs": 5,
"styleRecalcDurationMs": 9.998999999999999,
"layouts": 2,
"layoutDurationMs": 1.04,
"taskDurationMs": 49.70500000000001,
"heapDeltaBytes": 3067288,
"heapUsedBytes": 71687796,
"domNodes": 125,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 4.157999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 74.91199999992659,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.284999999999998,
"layouts": 2,
"layoutDurationMs": 0.734,
"taskDurationMs": 49.756999999999984,
"heapDeltaBytes": 2997204,
"heapUsedBytes": 71423932,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.498000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18628 +/- ##
=============================================
- Coverage 83.65% 82.14% -1.51%
=============================================
Files 2098 2528 +430
Lines 124095 131777 +7682
Branches 31407 35129 +3722
=============================================
+ Hits 103810 108251 +4441
- Misses 20106 23012 +2906
- Partials 179 514 +335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Before/After
Before:
core/1.54pinned@comfyorg/comfy-multi-playerdirectly (not via the pnpm catalog). It started this PR at0.3.4(this branch never picked up the0.3.5catalog backport thatmain/cloud/1.54got); while this PR was open,core/1.54's tip independently moved to0.3.5(via #18617). Either way, the nested-subgraph-instanceinsert_workflowbug (an interior node that is itself a subgraph instance materializes widget-less) was present.After: rebased onto
core/1.54's current tip and bumpedpackage.json's direct dependency to0.3.6, plus theminimumReleaseAgeExcludeentry inpnpm-workspace.yaml/pnpm-lock.yaml.0.3.6carries the fix fromcomfy-multi-player#253.Note on scope
Pin bump only, opened directly against
core/1.54(not stacked). This branch does not have the nested-subgraph regression test that PR #18624 is adding tomain(that PR is itself still open/unmerged), so there is nothing to flip here.Testing
pnpm install --frozen-lockfileresolves clean against0.3.6(verified installednode_modules/@comfyorg/comfy-multi-player/package.jsonreports0.3.6).pnpm exec vitest run src/workbench/extensions/agent/crdt/: 715 passed, 3 expected-fail (baseline on this branch's current tip, no regressions from the bump alone).0.3.6is actually live on the public npm registry (dist-tags.latest = 0.3.6) before opening this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY