Repository navigation
[backport cloud/1.55] test(agent): pin the nested-subgraph-instance insert_workflow gap (PR #18607 follow-up) - #18678
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 13d3876180d7208d3cfaef252c0c0569f278d84a
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T11:46:26.446Z",
"gitSha": "0eed02e23fd31cb5712dea7169e50b6e8708d5c7",
"branch": "backport-18624-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.998000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.795000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.753,
"heapDeltaBytes": -7022444,
"heapUsedBytes": 60601504,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.230999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2005.345000000034,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.357999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.597,
"heapDeltaBytes": 2872432,
"heapUsedBytes": 70375300,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.154000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.699000000026,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.629000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.1540000000001,
"heapDeltaBytes": 10093216,
"heapUsedBytes": 77706500,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 164.027,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.0959999999332,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.813000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 836.559,
"heapDeltaBytes": 10583640,
"heapUsedBytes": 78157392,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 168.76200000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.8429999999953,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.357000000000003,
"layouts": 6,
"layoutDurationMs": 1.0530000000000002,
"taskDurationMs": 302.732,
"heapDeltaBytes": 3153344,
"heapUsedBytes": 70226336,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.231999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.7490000000116,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.898000000000003,
"layouts": 6,
"layoutDurationMs": 1.1430000000000002,
"taskDurationMs": 275.45,
"heapDeltaBytes": 2691408,
"heapUsedBytes": 70364016,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.008000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 709.8850000000425,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.810000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.129,
"heapDeltaBytes": 18956756,
"heapUsedBytes": 86454544,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 173.16199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 630.7649999999967,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.145000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.14599999999996,
"heapDeltaBytes": 18573856,
"heapUsedBytes": 86217640,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 165.86,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1164.0179999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.531,
"heapDeltaBytes": 35351792,
"heapUsedBytes": 102203832,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 72.42399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 553,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1186.947000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.189,
"heapDeltaBytes": 38267264,
"heapUsedBytes": 106101160,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 69.85799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 570,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.7399999999643,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.9090000000005,
"heapDeltaBytes": 14872812,
"heapUsedBytes": 90046384,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.095,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.3870000000497,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.13400000000007,
"heapDeltaBytes": 14450928,
"heapUsedBytes": 89810100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.05400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11965.148,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10971.118,
"heapDeltaBytes": 4443228,
"heapUsedBytes": 86501028,
"domNodes": -14,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 9075.438,
"eventListeners": 0,
"totalBlockingTimeMs": 1914,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10587.402999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9667.914,
"heapDeltaBytes": -13585308,
"heapUsedBytes": 68747272,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8243.380000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1251,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10965.229999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10145.863000000001,
"heapDeltaBytes": -49080,
"heapUsedBytes": 82463952,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8396.244,
"eventListeners": 0,
"totalBlockingTimeMs": 1292,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10700.108999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9854.662,
"heapDeltaBytes": 2765532,
"heapUsedBytes": 85114756,
"domNodes": -16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8148.334999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1262,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2027.528000000018,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.926000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.845,
"heapDeltaBytes": -2844444,
"heapUsedBytes": 83930880,
"domNodes": -243,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.36300000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2028.0850000000328,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.275,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.63399999999996,
"heapDeltaBytes": -3080016,
"heapUsedBytes": 83074596,
"domNodes": -245,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 34.397,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2325.052000000028,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1697.9389999999999,
"heapDeltaBytes": 20234516,
"heapUsedBytes": 84308324,
"domNodes": -247,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 863.9680000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2300.1649999999927,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.044000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1656.549,
"heapDeltaBytes": 19297192,
"heapUsedBytes": 83722680,
"domNodes": -249,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 865.9259999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3505.285000000015,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.318,
"layouts": 60,
"layoutDurationMs": 13.362,
"taskDurationMs": 1591.509,
"heapDeltaBytes": 9456520,
"heapUsedBytes": 74597040,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 814.307,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3592.0360000000073,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.893,
"layouts": 60,
"layoutDurationMs": 13.367,
"taskDurationMs": 1730.817,
"heapDeltaBytes": 8004544,
"heapUsedBytes": 74560988,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 815.805,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3153.4960000000183,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.971999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2035.6019999999999,
"heapDeltaBytes": 25625172,
"heapUsedBytes": 91669264,
"domNodes": -250,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1055.608,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3138.1020000000035,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.477000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1916.935,
"heapDeltaBytes": 18016220,
"heapUsedBytes": 83655424,
"domNodes": 6,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 991.9759999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.722999999985,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.551000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.0899999999999,
"heapDeltaBytes": -4622372,
"heapUsedBytes": 84011160,
"domNodes": -245,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 35.82099999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2032.9940000000306,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.711,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.9520000000001,
"heapDeltaBytes": -4725100,
"heapUsedBytes": 84199732,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.369,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.1780000000153,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.445000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.08000000000004,
"heapDeltaBytes": 14030876,
"heapUsedBytes": 83044440,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 155.60200000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.9759999999833,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.938,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.548,
"heapDeltaBytes": 13787340,
"heapUsedBytes": 83617724,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 140.28099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.309000000007,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.926,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.57099999999997,
"heapDeltaBytes": 11587132,
"heapUsedBytes": 81470168,
"domNodes": -276,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 10.081,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.0410000000347,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.4839999999999,
"heapDeltaBytes": -14436468,
"heapUsedBytes": 55254060,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.443,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.4540000000175,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.218,
"heapDeltaBytes": 6041320,
"heapUsedBytes": 75842256,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 113.64699999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.1410000000214,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.137999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 788.649,
"heapDeltaBytes": -3383440,
"heapUsedBytes": 65718772,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 113.97399999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 950.0439999999344,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.551000000000002,
"layouts": 5,
"layoutDurationMs": 13.844000000000003,
"taskDurationMs": 768.907,
"heapDeltaBytes": -6257612,
"heapUsedBytes": 83728196,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 26.997999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8552.120000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.551,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6107.251,
"heapDeltaBytes": -10339724,
"heapUsedBytes": 76453932,
"domNodes": -220,
"jsHeapTotalBytes": 1007616,
"scriptDurationMs": 2960.52,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8535.13499999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.702,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5908.777000000001,
"heapDeltaBytes": -6738832,
"heapUsedBytes": 80165108,
"domNodes": -243,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2837.034,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 13155.224999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12527.723000000002,
"heapDeltaBytes": -66312356,
"heapUsedBytes": 167885940,
"domNodes": -8061,
"jsHeapTotalBytes": -4206592,
"scriptDurationMs": 226.989,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17338.738000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17057.712,
"heapDeltaBytes": -57791488,
"heapUsedBytes": 183471684,
"domNodes": -8061,
"jsHeapTotalBytes": -19075072,
"scriptDurationMs": 264.28499999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20874.507000000052,
"styleRecalcs": 151,
"styleRecalcDurationMs": 18.343999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20672.417,
"heapDeltaBytes": -45549968,
"heapUsedBytes": 168998056,
"domNodes": -8061,
"jsHeapTotalBytes": -13438976,
"scriptDurationMs": 891.614,
"eventListeners": -14928,
"totalBlockingTimeMs": 71,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20706.28499999998,
"styleRecalcs": 153,
"styleRecalcDurationMs": 17.741000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20528.522,
"heapDeltaBytes": -49214212,
"heapUsedBytes": 191915724,
"domNodes": -8061,
"jsHeapTotalBytes": -21241856,
"scriptDurationMs": 911.875,
"eventListeners": -14928,
"totalBlockingTimeMs": 111,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6159.420999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.01100000000002,
"layouts": 20,
"layoutDurationMs": 22.988999999999997,
"taskDurationMs": 6070.062,
"heapDeltaBytes": -38863172,
"heapUsedBytes": 189295024,
"domNodes": -8061,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 106.07600000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 416,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4804.6359999999595,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.57000000000002,
"layouts": 20,
"layoutDurationMs": 24.31499999999999,
"taskDurationMs": 4747.093,
"heapDeltaBytes": -38759836,
"heapUsedBytes": 186743524,
"domNodes": -8061,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 95.22,
"eventListeners": -14928,
"totalBlockingTimeMs": 116,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6498.775999999907,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6237.178000000002,
"heapDeltaBytes": -9665252,
"heapUsedBytes": 169170752,
"domNodes": 0,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 110.80999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6623.964999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6391.518,
"heapDeltaBytes": 15699744,
"heapUsedBytes": 194974400,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 117.47700000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 475.4779999999528,
"styleRecalcs": 21,
"styleRecalcDurationMs": 31.687,
"layouts": 5,
"layoutDurationMs": 2.4080000000000004,
"taskDurationMs": 154.936,
"heapDeltaBytes": 5373400,
"heapUsedBytes": 71014892,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 18.298000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 119.90900000000693,
"styleRecalcs": 9,
"styleRecalcDurationMs": 22.652,
"layouts": 4,
"layoutDurationMs": 2.044,
"taskDurationMs": 93.946,
"heapDeltaBytes": 3100792,
"heapUsedBytes": 67922384,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.782000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @huang47.
Found 1 finding(s).
| Severity | Count |
|---|---|
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| ) | ||
| expect(interiorInstances).toHaveLength(1) | ||
| const [interiorInstance] = interiorInstances | ||
| expect(interiorInstance.has_errors).not.toBe(true) |
There was a problem hiding this comment.
⚪ Nit — This assertion is dead weight for the regression it appears to guard: the instanceof SubgraphNode filter three lines above already excludes a missingNode() fallback (a plain LGraphNode carrying has_errors = true), so toHaveLength(1) fails first whenever the interior node degrades. Either drop the line or assert over the unfiltered rootInstance.subgraph.nodes so the placeholder case is genuinely detected. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
There was a problem hiding this comment.
Confirmed accurate, but not fixing in this backport: it's a test-only nit, and fixing it here would diverge from the main-branch PR (#18624) that this backports.
Generated by Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #18678 +/- ##
=============================================
Coverage ? 84.58%
=============================================
Files ? 2294
Lines ? 131275
Branches ? 33535
=============================================
Hits ? 111043
Misses ? 19932
Partials ? 300
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…18607 follow-up) (#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. ---------
32f9283 to
52abcb6
Compare
52abcb6 to
7cdc706
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
I force-pushed this branch to strip Co-authored-by trailers for claude/Amp from the commit messages, which is what Check for AI agent co-author trailers was failing on. Message-only rewrite: the tree hash is identical to before, so the code is untouched.
Backport of #18624 to
cloud/1.55Automatically created by backport workflow.