Repository navigation
[backport core/1.54] fix: agent tool-call chat completion lags canvas materialization (PM-1575/PM-1576) - #18595
Conversation
Backport of the fixture corpus from #16764 and #17416 to core/1.54: 14 recorded agent-conversation JSON fixtures plus the derived empty- workflow seed, under browser_tests/fixtures/data/agent/. Data-only backport (no code): the loader (agentConversation.ts), the Playwright replay harness, and the production repaint fix bundled into #16764 are intentionally left out — none of it is needed for what requires this corpus on core/1.54 right now (the CANVAS_MUTATING_TOOLS pinning test added by PR #18391's backport), and the harness/mock-helper changes carry real conflict risk against core/1.54's independently- drifted test infra. This can be extended with the loader/harness in a follow-up if core/1.54 ever needs the full E2E replay spec. Verified byte-identical to origin/main's copies of the same files. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1946 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T11:18:51.803Z",
"gitSha": "f7d14b3a1142017aaf806a8467e693151970b50f",
"branch": "backport-18391-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2083.4029999999757,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.474000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.363,
"heapDeltaBytes": -12411660,
"heapUsedBytes": 57884856,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.613999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2023.8389999999526,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.355,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.54200000000003,
"heapDeltaBytes": 691484,
"heapUsedBytes": 64824524,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.858,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.121999999939,
"styleRecalcs": 81,
"styleRecalcDurationMs": 32.458,
"layouts": 14,
"layoutDurationMs": 4.593,
"taskDurationMs": 905.769,
"heapDeltaBytes": -6463920,
"heapUsedBytes": 63790472,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 153.684,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1797.0060000000103,
"styleRecalcs": 73,
"styleRecalcDurationMs": 28.168,
"layouts": 14,
"layoutDurationMs": 4.241,
"taskDurationMs": 867.774,
"heapDeltaBytes": -2874164,
"heapUsedBytes": 66846664,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 145.35299999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.7950000000792,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.425,
"layouts": 6,
"layoutDurationMs": 1.2300000000000002,
"taskDurationMs": 377.89099999999996,
"heapDeltaBytes": 4246224,
"heapUsedBytes": 74615140,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.85,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.145000000084,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.032000000000004,
"layouts": 6,
"layoutDurationMs": 1.2129999999999999,
"taskDurationMs": 372.959,
"heapDeltaBytes": 4608384,
"heapUsedBytes": 75416720,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.765,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 633.6150000000771,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.197000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.556,
"heapDeltaBytes": -7520944,
"heapUsedBytes": 62978228,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 154.739,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 709.793999999988,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.872,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.74,
"heapDeltaBytes": 18077352,
"heapUsedBytes": 88289248,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 157.224,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2062.347000000045,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.278000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.8499999999999,
"heapDeltaBytes": 11382724,
"heapUsedBytes": 87286304,
"domNodes": -268,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 35.526,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.7619999999342,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.312999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.8349999999999,
"heapDeltaBytes": 10691996,
"heapUsedBytes": 87067044,
"domNodes": -269,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 36.261,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2275.011999999947,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.701000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1676.759,
"heapDeltaBytes": 4466384,
"heapUsedBytes": 81683276,
"domNodes": -240,
"jsHeapTotalBytes": 1953792,
"scriptDurationMs": 798.4789999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2240.2339999999867,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.656000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1666.1439999999998,
"heapDeltaBytes": 11943116,
"heapUsedBytes": 89219444,
"domNodes": -278,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 809.8910000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3569.497999999953,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.084,
"layouts": 60,
"layoutDurationMs": 13.313000000000002,
"taskDurationMs": 1713.0440000000003,
"heapDeltaBytes": 12064468,
"heapUsedBytes": 80133908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.883,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3493.8319999999976,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.3,
"layouts": 60,
"layoutDurationMs": 13.279,
"taskDurationMs": 1683.299,
"heapDeltaBytes": 8184880,
"heapUsedBytes": 76457048,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.5260000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3122.115000000008,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.381999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1920.757,
"heapDeltaBytes": 17639568,
"heapUsedBytes": 85516768,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 942.3270000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3061.9839999999385,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.260999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1895.101,
"heapDeltaBytes": 21805360,
"heapUsedBytes": 90082516,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 946.762,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2055.6159999999863,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.389,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.3190000000001,
"heapDeltaBytes": 5915440,
"heapUsedBytes": 83009504,
"domNodes": -284,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 37.219,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2074.2309999999407,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.676999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.7469999999998,
"heapDeltaBytes": 5449132,
"heapUsedBytes": 82894356,
"domNodes": -282,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 36.129999999999995,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.0790000000361,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.19100000000003,
"heapDeltaBytes": 13934168,
"heapUsedBytes": 86338056,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.765,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.8199999999606,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.747,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.275,
"heapDeltaBytes": 14157372,
"heapUsedBytes": 86658412,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.216,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.72799999992,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.561999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.50000000000006,
"heapDeltaBytes": -11133824,
"heapUsedBytes": 60534936,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.309000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2016.114000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.687,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.5970000000001,
"heapDeltaBytes": -7079124,
"heapUsedBytes": 65835400,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.527,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.2519999999085,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.209999999999997,
"layouts": 18,
"layoutDurationMs": 5.1000000000000005,
"taskDurationMs": 804.401,
"heapDeltaBytes": -14527028,
"heapUsedBytes": 58201560,
"domNodes": -293,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 102.943,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.3040000000747,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.841,
"layouts": 18,
"layoutDurationMs": 5.133,
"taskDurationMs": 837.8859999999999,
"heapDeltaBytes": -7017900,
"heapUsedBytes": 65100020,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 105.772,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.520000000005,
"styleRecalcs": 21,
"styleRecalcDurationMs": 31.111,
"layouts": 17,
"layoutDurationMs": 14.773000000000001,
"taskDurationMs": 928.3590000000002,
"heapDeltaBytes": 20082060,
"heapUsedBytes": 103716472,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.863000000000007,
"eventListeners": 2385,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8403.022999999961,
"styleRecalcs": 245,
"styleRecalcDurationMs": 39.743,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5738.025000000001,
"heapDeltaBytes": 13253608,
"heapUsedBytes": 89600116,
"domNodes": -274,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 2574.9919999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8446.276000000013,
"styleRecalcs": 248,
"styleRecalcDurationMs": 44.190999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5768.776000000001,
"heapDeltaBytes": 5882384,
"heapUsedBytes": 82493812,
"domNodes": -243,
"jsHeapTotalBytes": 2740224,
"scriptDurationMs": 2599.564,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18049.065000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17382.416,
"heapDeltaBytes": -56960712,
"heapUsedBytes": 181852764,
"domNodes": -8068,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 293.99299999999994,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18283.111000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17799.046,
"heapDeltaBytes": -32651056,
"heapUsedBytes": 185717640,
"domNodes": -8068,
"jsHeapTotalBytes": -8138752,
"scriptDurationMs": 303.65200000000004,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21896.184000000063,
"styleRecalcs": 164,
"styleRecalcDurationMs": 20.47899999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21661.766999999996,
"heapDeltaBytes": -38146704,
"heapUsedBytes": 179057884,
"domNodes": -8068,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 904.2750000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22624.73,
"styleRecalcs": 167,
"styleRecalcDurationMs": 22.87699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22375.589,
"heapDeltaBytes": -33698252,
"heapUsedBytes": 192611524,
"domNodes": -8068,
"jsHeapTotalBytes": -16543744,
"scriptDurationMs": 929.062,
"eventListeners": -14927,
"totalBlockingTimeMs": 84,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6392.198000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.349,
"layouts": 20,
"layoutDurationMs": 24.578000000000003,
"taskDurationMs": 6321.425,
"heapDeltaBytes": -40620472,
"heapUsedBytes": 183154372,
"domNodes": -8068,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 112.236,
"eventListeners": -14927,
"totalBlockingTimeMs": 450,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6579.008000000044,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.519,
"layouts": 20,
"layoutDurationMs": 26.206999999999994,
"taskDurationMs": 6498.714000000001,
"heapDeltaBytes": -45720060,
"heapUsedBytes": 182438240,
"domNodes": -8068,
"jsHeapTotalBytes": 13668352,
"scriptDurationMs": 128.719,
"eventListeners": -14929,
"totalBlockingTimeMs": 524,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9176.690000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8833.208999999999,
"heapDeltaBytes": -5631612,
"heapUsedBytes": 167047624,
"domNodes": 0,
"jsHeapTotalBytes": -10747904,
"scriptDurationMs": 148.79199999999992,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9196.655999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8975.928999999998,
"heapDeltaBytes": 2996412,
"heapUsedBytes": 172461744,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 149.88299999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 110.89799999990646,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.932000000000002,
"layouts": 3,
"layoutDurationMs": 1.7670000000000001,
"taskDurationMs": 85.102,
"heapDeltaBytes": 3080300,
"heapUsedBytes": 71145736,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.794000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 478.430000000003,
"styleRecalcs": 13,
"styleRecalcDurationMs": 26.275999999999996,
"layouts": 3,
"layoutDurationMs": 0.922,
"taskDurationMs": 118.615,
"heapDeltaBytes": 4764192,
"heapUsedBytes": 73953632,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.421000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: ef5c234 | Docs | View more details | Give us feedback! |
8a57204 to
fa5d8bf
Compare
…1575/PM-1576) (#18391) Backport of #18391 to core/1.54. Cherry-picked the squash-merge commit fce6d77 onto a new branch from origin/core/1.54. The automated backport failed with conflicts in src/scripts/api.logs.test.ts, src/workbench/extensions/agent/AgentPanelRoot.vue, src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts, src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts, and src/workbench/extensions/agent/stores/agent/agentConversationStore.ts. Conflict resolution: - src/scripts/api.logs.test.ts: modify/delete. The file doesn't exist on core/1.54 because its introducing PR (#17773) was never backported here. Dropped rather than smuggling in unrelated test scaffolding. - useAgentCrdtFollower.ts: core/1.54 has an older, pre-refactor version of this file. The fix's `appliedLive` outcome counter needs to distinguish a live doc update from a subscribe's one-time catch-up frame; core/1.54's LayoutFollowerBridge already computed that distinction internally but never exposed it. Added a small, additive `ClassifiedDocUpdate` type to layoutFollowerBridge.ts (not one of the reported conflicts, but a necessary minimal dependency, mirroring main's own pre-existing mechanism) to expose the flag on the already-dispatched `doc_update` event, then wired `appliedLive` counting off it. - AgentPanelRoot.vue: kept the PR's teardown fix (reset canvasSyncGate on unmount); dropped `agentMinimapLayer.dispose()`, an unrelated feature not present on core/1.54. - agentConversationStore.ts / .test.ts: diff-alignment conflicts from upstream reordering; merged both sides' real content, kept core/1.54's Pinia test setup. - agentEventTransport.ts / .test.ts (auto-merged, not a reported conflict): imported STALE_AFTER_MS from agentCrdtDocLifecycle.ts, a module that doesn't exist on core/1.54 (a later extraction refactor not yet backported). Repointed both to useAgentCrdtFollower.ts, which still exports that same constant on this branch's older file layout. - browser_tests/tests/agent/agentCanvasLagsToolCallCompletion.spec.ts (new file, auto-merged): referenced @/platform/remote/comfyui/types (moved from @/schemas/apiSchema on main, not yet backported) and agent.entryButton (renamed from agent.askComfyAgent on main). Repointed to core/1.54's current locations/copy. Also called HostDoc.graph(), a method main's harness has that core/1.54's didn't; added it to agentConversationHostDoc.ts mirroring main exactly (readGraph from the already-installed @comfyorg/comfy-multi-player package). Its assertions also expected `WorkSummary.vue`'s "Worked for Xs" collapsing summary button, a UI feature from #17339 never backported to core/1.54. core/1.54's own equivalent is `ToolCallGroup.vue`, using the same reka-ui Collapsible primitive but a different trigger label ("Ran N tool call(s) [for Xs]" via agent.ranToolCalls/ranToolCallsTimed, not agent.worked). Retargeted the three `/^Worked/` button-name matchers to `/^Ran/` to match; the underlying mechanics under test (the tool row's own spinner/done glyph, role="listitem" rows, aria-expanded on the trigger) are identical between the two components. One more difference surfaced by CI: core/1.54's ToolCallGroup.vue keeps itself expanded for as long as any tool part is still 'streaming' (a v-model tied to that state), which main's WorkSummary.vue does not do -- so in the very scenario this fix creates (a tool part held at 'streaming' past the turn's own settle), the trigger is already open when the test gets to it, and an unconditional click was closing it instead of opening it. Added an expandToolCallGroup() helper that checks aria-expanded before clicking, used at both call sites. The CANVAS_MUTATING_TOOLS pinning unit test (agentEventTransport.test.ts) depends on the BE-11470 conversation-replay fixture corpus, backported separately in #18585 (which this branch is based on). Verification: pnpm typecheck, pnpm typecheck:browser, pnpm eslint, pnpm exec oxfmt all clean. Targeted pnpm vitest run across useAgentCrdtFollower, followerSubscription, AgentPanelRoot, agentConversationStore, agentEventTransport, CrdtDevPanel, crdtDebugReport: all green except 3 pre-existing Media-card upload failures (confirmed identical on unmodified origin/core/1.54, matching a prior backport's own documented note). <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_
fa5d8bf to
ef5c234
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18595 +/- ##
=============================================
- Coverage 83.64% 83.63% -0.01%
=============================================
Files 2098 2098
Lines 123971 123900 -71
Branches 31584 33411 +1827
=============================================
- Hits 103692 103624 -68
+ Misses 20100 20097 -3
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…roup UI (#18617) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Before `AgentPanelRoot.test.ts`'s "settles a mutating tool call immediately when no CRDT doc subscription is connected" test (added by the PM-1575/PM-1576 backport, #18595) asserted `screen.findByText(i18n.global.t('agent.working'))` — the "Working..." composing status that only `main`'s `AgentMessage.vue` renders (part of an unrelated, unbackported `WorkSummary`/`ActivityTrace` redesign). `core/1.54`'s `AgentMessage.vue` has no such row at all; `agent.working` has zero non-test usages on this branch. The test failed deterministically on `core/1.54`'s own tip, independent of any other PR's diff (reproduced on an unrelated push: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35856856362, job 107167326258), and was blocking the required "test" CI check on unrelated backport PRs such as #18600. ## After The assertion now matches what `core/1.54` actually — and correctly — renders: once the mutating tool call's part settles from `'streaming'` to `'done'` (the real PM-1575 behavior under test), `ToolCallGroup.vue`'s trigger shows the settled `"Ran 1 tool call for 0.1 seconds"` label. This mirrors how #18579 fixed the analogous `agent.worked`/`ToolCallGroup` mismatch elsewhere in this same file, rather than backporting the full main-branch UI redesign. ## Verification - `npx vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts -t "settles a mutating tool call immediately"`: passes. - `npx vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` (full file): 227/230 pass; the 3 remaining failures (`T-08 / PM-646 / FE-1314` attach-flow tests) are pre-existing on `core/1.54`'s tip regardless of this change (confirmed by running the same tests via `git stash` against the unmodified file) and are unrelated to this fix. - `npx eslint` on the changed file: clean. - `npx vue-tsc --noEmit`: no errors on the changed file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…sion test (#18391 follow-up) (#18602) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_ ## Before #18595 backported #18391's PM-1575 gate-wiring fix to `core/1.54`, but its new regression test `'settles a mutating tool call immediately when no CRDT doc subscription is connected'` asserted on the "Working..." composing status text. That text is rendered by `AgentMessage.vue`'s `composing`/`status` computed on `main` — code that doesn't exist on `core/1.54` (it was added by a separate, still-unbackported PR, #17339). #18595 merged with this one test still red on `core/1.54`. ## After The PM-1575 fix itself is correct and unaffected by this; only this one assertion's observation point doesn't exist on this branch. Retargeted it to check what `core/1.54` actually shows once the tool call settles: `ToolCallGroup.vue`'s own row flips from its spinner to the "Ran N tool call(s)" label (`agent.ranToolCalls`) — the same UI this backport's Playwright spec already asserts on with a `/^Ran/` matcher. ## How 3-line change in `src/workbench/extensions/agent/AgentPanelRoot.test.ts`: swapped `screen.findByText(i18n.global.t('agent.working'))` for `screen.findByRole('button', { name: /^Ran/ })`, and updated the adjacent comment. Verified: `pnpm vitest run AgentPanelRoot.test.ts` — 227 passed, 3 failed (the same pre-existing, unrelated "Media-card" upload flakes documented in #18595, confirmed identical on unmodified `core/1.54`). `pnpm exec oxfmt --check` and `pnpm eslint` on the file: clean. --- _Generated by [Claude Code](https://claude.ai/code/session_01NQDb2pk4BuLEgzkga3GhEs)_ Co-authored-by: Claude <noreply@anthropic.com>
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Backport of #18391 to
core/1.54. Stacked on #18585 (BE-11470 conversation-replay fixture corpus), which this branch is based on and which must merge first.Before
An agent tool call that touches the canvas (e.g. adding a node) reports done — the tool's row flips straight to its settled icon — while the canvas itself still shows nothing for the new content, for a stretch that can be close to 10 real seconds.
agentEventTransport.ts'singest()flipped a tool part'sstateto'done'purely from the chat-channelagent_tool_callframe's ownstatusfield, with zero coupling to whether the corresponding CRDTdoc_updatehad actually reached and been projected onto the canvas.After
createAgentEventTransportnow takes an optionalshouldAwaitCanvasSyncgate. While it returnstrue, a tool call that reports done holds its part's displayedstateat'streaming'instead of flipping straight to'done', until eithernotifyCanvasCaughtUp()is called orSTALE_AFTER_MS(30s) elapses.agentConversationStore.tsthreads this gate through every transport it creates;AgentPanelRoot.vuewires it to the CRDT follower's own catch-up signal.How (backport-specific)
Cherry-picked squash-merge commit
fce6d77e36b3f3ec7c00ce405c56628eabc55a12. The automated backport failed with conflicts in the 5 files it named; each is resolved and explained in the commit message. Two notable adaptations forcore/1.54's older code shape:useAgentCrdtFollower.ts/layoutFollowerBridge.ts: the fix'sappliedLiveoutcome counter needs to distinguish a live doc update from a subscribe's one-time catch-up frame.core/1.54'sLayoutFollowerBridgealready computed that distinction internally but never exposed it — added a small, additiveClassifiedDocUpdatetype (mirroringmain's own pre-existing mechanism) to expose it on the already-dispatcheddoc_updateevent.agentCanvasLagsToolCallCompletion.spec.ts) referenced a module path, an i18n key, and aHostDocmethod that only exist onmain's newer code shape. Repointed tocore/1.54's current equivalents (@/schemas/apiSchema,agent.askComfyAgent) and added the missingHostDoc.graph()method to the shared test harness, mirroringmainexactly.Verification
pnpm typecheck,pnpm typecheck:browser,pnpm eslint,pnpm exec oxfmtall clean. Targetedpnpm vitest runacross the touched agent test suites: all green except 3 pre-existing "Media-card" upload failures, confirmed identical on unmodifiedorigin/core/1.54(a documented pre-existing gap from an earlier backport).Generated by Claude Code