Repository navigation
[backport core/1.54] fix: render widgets on insert_workflow-materialized nodes - #18600
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1942 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T12:39:27.407Z",
"gitSha": "74d258f6bbaaebbd146dc4c1a6ca13dd0ab65fd6",
"branch": "backport-18598-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2113.0620000000135,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.549999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.957,
"heapDeltaBytes": 3221164,
"heapUsedBytes": 73625856,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.299999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.3199999999988,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.58599999999996,
"heapDeltaBytes": -2841700,
"heapUsedBytes": 66624096,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.006,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.4760000000342,
"styleRecalcs": 73,
"styleRecalcDurationMs": 27.476,
"layouts": 14,
"layoutDurationMs": 4.569,
"taskDurationMs": 693.5219999999999,
"heapDeltaBytes": 7111916,
"heapUsedBytes": 77943020,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 123.78300000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.9680000000662,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.353,
"layouts": 14,
"layoutDurationMs": 4.4559999999999995,
"taskDurationMs": 691.141,
"heapDeltaBytes": -9024492,
"heapUsedBytes": 61872652,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 116.85499999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1655.5869999999686,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.199,
"layouts": 6,
"layoutDurationMs": 1.188,
"taskDurationMs": 299.72,
"heapDeltaBytes": 4284780,
"heapUsedBytes": 74303840,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.699000000000002,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1675.3109999999651,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.295,
"layouts": 6,
"layoutDurationMs": 1.13,
"taskDurationMs": 304.231,
"heapDeltaBytes": 4737900,
"heapUsedBytes": 75891456,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.447,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 516.4549999999508,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.9479999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.726,
"heapDeltaBytes": -8169488,
"heapUsedBytes": 62827088,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 103.13799999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 556.577999999945,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.856,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.592,
"heapDeltaBytes": -7880264,
"heapUsedBytes": 63085724,
"domNodes": 20,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 121.68699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.323999999965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.2749999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.026,
"heapDeltaBytes": 4704584,
"heapUsedBytes": 80985824,
"domNodes": -278,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 29.43099999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.6569999998965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.6830000000001,
"heapDeltaBytes": 4576252,
"heapUsedBytes": 80650888,
"domNodes": -278,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 33.678000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2857.6189999999997,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.388999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1244.599,
"heapDeltaBytes": 27568628,
"heapUsedBytes": 93600608,
"domNodes": 10,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 601.812,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3129.670000000033,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.774,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1453.654,
"heapDeltaBytes": 12463512,
"heapUsedBytes": 89546792,
"domNodes": -245,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 670.003,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3550.167999999985,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.533999999999999,
"layouts": 60,
"layoutDurationMs": 13.944999999999999,
"taskDurationMs": 1301.372,
"heapDeltaBytes": -7590204,
"heapUsedBytes": 70988776,
"domNodes": -287,
"jsHeapTotalBytes": 3301376,
"scriptDurationMs": 529.814,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3634.350999999924,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.125000000000005,
"layouts": 60,
"layoutDurationMs": 14.399,
"taskDurationMs": 1328.854,
"heapDeltaBytes": 7808272,
"heapUsedBytes": 75497328,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 571.3580000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2569.6719999999686,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1391.5989999999997,
"heapDeltaBytes": 20603592,
"heapUsedBytes": 88580624,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 674.238,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3092.6190000000133,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.256,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1680.5620000000001,
"heapDeltaBytes": 5395104,
"heapUsedBytes": 85821204,
"domNodes": -250,
"jsHeapTotalBytes": 49152,
"scriptDurationMs": 788.3249999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.3390000000163,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.9900000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.824,
"heapDeltaBytes": 10220444,
"heapUsedBytes": 87692696,
"domNodes": -269,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 30.397999999999996,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.455999999991,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.917000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.22399999999993,
"heapDeltaBytes": 10211292,
"heapUsedBytes": 87944028,
"domNodes": -267,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 30.653999999999993,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 538.5680000000548,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.620000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.836,
"heapDeltaBytes": 14162860,
"heapUsedBytes": 86347252,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 103.449,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.0490000000764,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.517000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.276,
"heapDeltaBytes": 14197080,
"heapUsedBytes": 86708340,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 108.41499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.619999999988,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.576,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.457,
"heapDeltaBytes": 1911524,
"heapUsedBytes": 74595444,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.234,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.9430000000448,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.17199999999997,
"heapDeltaBytes": -6042000,
"heapUsedBytes": 60219304,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.683,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.2129999999825,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.406,
"layouts": 18,
"layoutDurationMs": 4.992,
"taskDurationMs": 666.466,
"heapDeltaBytes": 6208644,
"heapUsedBytes": 78415336,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 96.962,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.538000000076,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.121,
"layouts": 18,
"layoutDurationMs": 5.608999999999999,
"taskDurationMs": 717.5970000000001,
"heapDeltaBytes": 1419676,
"heapUsedBytes": 73881776,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 99.086,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1100.0290000000632,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.952,
"layouts": 16,
"layoutDurationMs": 12.44,
"taskDurationMs": 754.5079999999999,
"heapDeltaBytes": -3501740,
"heapUsedBytes": 88355356,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 25.35300000000001,
"eventListeners": 2387,
"totalBlockingTimeMs": 84,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10389.895000000024,
"styleRecalcs": 249,
"styleRecalcDurationMs": 44.695,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4712.44,
"heapDeltaBytes": 11000472,
"heapUsedBytes": 87459524,
"domNodes": -243,
"jsHeapTotalBytes": 86016,
"scriptDurationMs": 2138.419,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11621.307999999999,
"styleRecalcs": 248,
"styleRecalcDurationMs": 46.78300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5028.1359999999995,
"heapDeltaBytes": -35964164,
"heapUsedBytes": 66858976,
"domNodes": -265,
"jsHeapTotalBytes": -593920,
"scriptDurationMs": 2219.542,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 12591.86000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12078.195000000002,
"heapDeltaBytes": -74565972,
"heapUsedBytes": 162443636,
"domNodes": -8068,
"jsHeapTotalBytes": -25456640,
"scriptDurationMs": 173.845,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12974.615999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12276.838000000002,
"heapDeltaBytes": -54790556,
"heapUsedBytes": 179203272,
"domNodes": -8068,
"jsHeapTotalBytes": -18550784,
"scriptDurationMs": 189.405,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15864.102000000003,
"styleRecalcs": 82,
"styleRecalcDurationMs": 17.32599999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15401.558,
"heapDeltaBytes": -52698224,
"heapUsedBytes": 182365784,
"domNodes": -8068,
"jsHeapTotalBytes": -11964416,
"scriptDurationMs": 707.4910000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15001.636999999959,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.668000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14595.774000000001,
"heapDeltaBytes": -34668808,
"heapUsedBytes": 169969680,
"domNodes": -8068,
"jsHeapTotalBytes": -11530240,
"scriptDurationMs": 678.046,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4974.460000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.54100000000001,
"layouts": 20,
"layoutDurationMs": 24.396,
"taskDurationMs": 4900.699999999999,
"heapDeltaBytes": -62806016,
"heapUsedBytes": 171636908,
"domNodes": -8068,
"jsHeapTotalBytes": 16875520,
"scriptDurationMs": 85.891,
"eventListeners": -14929,
"totalBlockingTimeMs": 248,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4676.3650000000325,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.13300000000002,
"layouts": 20,
"layoutDurationMs": 23.19,
"taskDurationMs": 4594.580000000001,
"heapDeltaBytes": -23842736,
"heapUsedBytes": 200577500,
"domNodes": -8068,
"jsHeapTotalBytes": 18145280,
"scriptDurationMs": 82.68299999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 130,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7005.141999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6608.1309999999985,
"heapDeltaBytes": -2152452,
"heapUsedBytes": 183556416,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 102.98500000000004,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6238.7410000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6041.156000000001,
"heapDeltaBytes": 15893640,
"heapUsedBytes": 183803748,
"domNodes": 0,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 89.65699999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 430.8849999999893,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.143,
"layouts": 3,
"layoutDurationMs": 0.9510000000000003,
"taskDurationMs": 91.744,
"heapDeltaBytes": 4768836,
"heapUsedBytes": 73170728,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.667999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 81.27700000000004,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.152999999999999,
"layouts": 2,
"layoutDurationMs": 1.1789999999999998,
"taskDurationMs": 51.04600000000001,
"heapDeltaBytes": 2976096,
"heapUsedBytes": 71476000,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.594,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 4ff3051 | Docs | View more details | Give us feedback! |
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Fixes a bug where an agent's `insert_workflow` batch (e.g. the in-app agent loading a template like "Z Image Turbo") materialized nodes with correct positions and types, and links between them materialized correctly (#18458 / PM-1562), but every inserted node's **widgets rendered as empty/blank bodies** even though the widget values, `MarkdownNote` text, `SaveImage` `filename_prefix`, etc. were present in the CRDT document and in the widget store. Two independent, compounding bugs, both specific to how `insert_workflow` differs from `add_node`: **Bug 1 — widgets undiscoverable (blank node body, zero widget rows).** `comfy-multi-player`'s `insert_workflow` applier remaps every inserted node's id to a derived string carrying colons for reasons that have nothing to do with subgraph scoping (`remap.ts`'s `derivedId`, e.g. `insert:<opId>:root:node:<originalId>`). `add_node` never does this — it keeps the id comfy-cli minted. Widget registration (`attachNodeToStores`/`BaseWidget.setNodeId` in `nodeShellLifecycle.ts`/`BaseWidget.ts`) always keys on that full id. The node-render path reads widget ids back through `stripGraphPrefix` (`src/stores/widgetValueStore.ts`) — used by `LGraphNode.vue`, `processedWidgetRenderModel.ts`, `WidgetItem.vue`, and `WidgetTextPreview.vue`. It used to strip *everything up to the last colon* unconditionally, which is correct for a genuine subgraph-scoped id (`<uuid>:<localId>`) but wrong for `insert_workflow`'s derived id: it collapsed `insert:<opId>:root:node:9` down to bare `9`, a key nothing was ever registered under (and, if a second `insert_workflow` op happened to reuse the same original id, a key two unrelated nodes would collapse onto). The lookup came back empty, so the node rendered with **zero widget rows**. Fixed `stripGraphPrefix` to only strip a prefix that is actually a subgraph UUID (repeating for nested subgraphs), leaving any other colon-bearing id untouched. **Bug 2 — widget discoverable but stuck at its constructor default.** Once bug 1 is fixed, `agentNodeMaterializer.ts`'s `materialize()` still didn't restore the real value. The op layer stores an ordinary node's `widgets_values` **by name** (`readSemanticNode`), but `LGraphNode.configure()`'s named-value restore is gated behind the experimental `Comfy.Workflow.NamedValuesRestore` setting (off by default) or a `fallbackNames` list that is never populated for real catalog nodes. Without either, `configure()` falls back to *positional* restore against `widgets_values` — for a named payload that's a plain object, not an array, so nothing restores and the widget keeps whatever value its constructor set. This file already has a `withNamedValuesRestore()` helper that flips `LiteGraph.namedValuesRestore` on for the duration of a call — it was used only when configuring a subgraph *definition*, never for the node's own `configure()` call in `materialize()`. `add_node`-created nodes mostly dodge this because the agent's add-node tool typically follow-ups with discrete `set_widget` ops (a direct, always-correct value write), whereas `insert_workflow` bakes every widget value into the node's initial creation payload, hitting this path on every single widget of every inserted node. **Fix:** wrap `materialize()`'s `node.configure(...)` call in `withNamedValuesRestore()` too, so a named payload actually lands. **Tests:** - `agentInsertWorkflowWidgets.regression.test.ts` (new): drives the real pipeline (comfy-multi-player's `insert_workflow` applier → `EcsFollowerAdapter`/`AgentCrdtProjection` → `graphMutations` → `agentNodeMaterializer`), then reads widget ids back exactly the way `LGraphNode.vue` does (`stripGraphPrefix` + `getNodeWidgetIds`), asserting the widget is both discoverable and correctly-valued. Also covers two `insert_workflow` ops that reuse the same original node id, proving they no longer collide. - `widgetValueStore.test.ts`: focused unit coverage for `stripGraphPrefix` — bare id passthrough, single/nested subgraph-uuid stripping, the derived-id passthrough case, the same-trailing-segment non-collision case, and the empty-id case. **Verified:** `pnpm typecheck`, `pnpm lint` (eslint + oxlint), `pnpm format:check` (via the repo's pre-commit hook) and the full `src/workbench/extensions/agent/crdt` + `src/stores` Vitest suites (2148 passed, 16 pre-existing expected-fails unrelated to this change, 1 skipped) all pass, plus the render-adjacent `LGraphNode.widgetOrder.test.ts`, `WidgetItem.test.ts`, and `WidgetTextPreview.test.ts`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_
a7e8783 to
4ff3051
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18600 +/- ##
==========================================
Coverage 83.63% 83.63%
==========================================
Files 2098 2098
Lines 123900 123904 +4
Branches 31367 31367
==========================================
+ Hits 103618 103626 +8
+ Misses 20103 20099 -4
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
The "test" job's failure ( Root cause: the PM-1575/PM-1576 backport (#18595) carried over a test asserting
Generated by Claude Code |
…ets when execId derivation fails (PM-1580 follow-up) (#18608) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Backport of #18604 to `cloud/1.54`. Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only runs when the PR carries the `needs-backport` label — `core/1.54` + `cloud/1.54` alone (added manually before merge) don't trigger it, so it never ran at merge time. After adding `needs-backport`, the workflow did run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly, but the run's overall job still failed because the `core/1.54` target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged against `core/1.54`) — and the workflow's "Cleanup stranded backport branches" step then deleted the `cloud/1.54` branch it had just successfully pushed, because it runs on `failure()` for the *job*, not per-target. So this clean backport never got a PR from the bot despite succeeding. Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has #18598 via #18601) by hand — clean apply, no conflicts. `core/1.54` is intentionally not backported here: it needs #18600 (the #18598 backport) merged first. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…roup UI (#18617) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Before `AgentPanelRoot.test.ts`'s "settles a mutating tool call immediately when no CRDT doc subscription is connected" test (added by the PM-1575/PM-1576 backport, #18595) asserted `screen.findByText(i18n.global.t('agent.working'))` — the "Working..." composing status that only `main`'s `AgentMessage.vue` renders (part of an unrelated, unbackported `WorkSummary`/`ActivityTrace` redesign). `core/1.54`'s `AgentMessage.vue` has no such row at all; `agent.working` has zero non-test usages on this branch. The test failed deterministically on `core/1.54`'s own tip, independent of any other PR's diff (reproduced on an unrelated push: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35856856362, job 107167326258), and was blocking the required "test" CI check on unrelated backport PRs such as #18600. ## After The assertion now matches what `core/1.54` actually — and correctly — renders: once the mutating tool call's part settles from `'streaming'` to `'done'` (the real PM-1575 behavior under test), `ToolCallGroup.vue`'s trigger shows the settled `"Ran 1 tool call for 0.1 seconds"` label. This mirrors how #18579 fixed the analogous `agent.worked`/`ToolCallGroup` mismatch elsewhere in this same file, rather than backporting the full main-branch UI redesign. ## Verification - `npx vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts -t "settles a mutating tool call immediately"`: passes. - `npx vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` (full file): 227/230 pass; the 3 remaining failures (`T-08 / PM-646 / FE-1314` attach-flow tests) are pre-existing on `core/1.54`'s tip regardless of this change (confirmed by running the same tests via `git stash` against the unmodified file) and are unrelated to this fix. - `npx eslint` on the changed file: clean. - `npx vue-tsc --noEmit`: no errors on the changed file. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ets when execId derivation fails (PM-1580 follow-up) (#18608) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Backport of #18604 to `cloud/1.54`. Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only runs when the PR carries the `needs-backport` label — `core/1.54` + `cloud/1.54` alone (added manually before merge) don't trigger it, so it never ran at merge time. After adding `needs-backport`, the workflow did run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly, but the run's overall job still failed because the `core/1.54` target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged against `core/1.54`) — and the workflow's "Cleanup stranded backport branches" step then deleted the `cloud/1.54` branch it had just successfully pushed, because it runs on `failure()` for the *job*, not per-target. So this clean backport never got a PR from the bot despite succeeding. Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has #18598 via #18601) by hand — clean apply, no conflicts. `core/1.54` is intentionally not backported here: it needs #18600 (the #18598 backport) merged first. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ (cherry picked from commit a55ce3d)
Backport of #18598 to
core/1.54Automatically created by backport workflow.