Skip to content

fix: assert core/1.54's own settled-tool-call label in PM-1575 regression test (#18391 follow-up) - #18602

Merged
christian-byrne merged 2 commits into
core/1.54from
fix-pm1575-core154-test-assertion
Sep 23, 2026
Merged

christian-byrne merged 2 commits into
core/1.54from
fix-pm1575-core154-test-assertion

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread

Before

#18595 backported #18391's PM-1575 gate-wiring fix to core/1.54, but its new regression test 'settles a mutating tool call immediately when no CRDT doc subscription is connected' asserted on the "Working..." composing status text. That text is rendered by AgentMessage.vue's composing/status computed on main — code that doesn't exist on core/1.54 (it was added by a separate, still-unbackported PR, #17339). #18595 merged with this one test still red on core/1.54.

After

The PM-1575 fix itself is correct and unaffected by this; only this one assertion's observation point doesn't exist on this branch. Retargeted it to check what core/1.54 actually shows once the tool call settles: ToolCallGroup.vue's own row flips from its spinner to the "Ran N tool call(s)" label (agent.ranToolCalls) — the same UI this backport's Playwright spec already asserts on with a /^Ran/ matcher.

How

3-line change in src/workbench/extensions/agent/AgentPanelRoot.test.ts: swapped screen.findByText(i18n.global.t('agent.working')) for screen.findByRole('button', { name: /^Ran/ }), and updated the adjacent comment.

Verified: pnpm vitest run AgentPanelRoot.test.ts — 227 passed, 3 failed (the same pre-existing, unrelated "Media-card" upload flakes documented in #18595, confirmed identical on unmodified core/1.54). pnpm exec oxfmt --check and pnpm eslint on the file: clean.


Generated by Claude Code

…sion test (#18391 follow-up)

#18595 backported #18391's PM-1575 gate-wiring fix to core/1.54, but its new
regression test 'settles a mutating tool call immediately when no CRDT doc
subscription is connected' asserted on the "Working..." composing status
text, which is rendered by AgentMessage.vue's composing/status computed on
main -- code that doesn't exist on core/1.54 (added by the separate,
still-unbackported #17339). That merged into core/1.54 with the test still
red.

The PM-1575 fix itself is correct and unaffected by this; it's only this
one assertion's observation point that doesn't exist on this branch.
Retargeted it to check what core/1.54 actually shows once the tool call
settles: ToolCallGroup.vue's own row flips from its spinner to the "Ran N
tool call(s)" label (agent.ranToolCalls), the same UI this backport's
Playwright spec already asserts on with a /^Ran/ matcher.

Verified: pnpm vitest run AgentPanelRoot.test.ts -- 227 passed, 3 failed
(the same pre-existing, unrelated "Media-card" upload flakes documented in
#18595, confirmed identical on unmodified core/1.54). pnpm exec oxfmt
--check and pnpm eslint on the file: clean.

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 5:46pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e9221ef4-ad19-47fc-9637-6e7d16fdf379

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1946 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1925 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 11:55:23 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At exact head b2cb3adc4b7154b4f16eef05b80ca16f54b6fef2, the complete one-file diff replaces the unavailable agent.working observation with the core/1.54 tool-row settlement surface, findByRole('button', { name: /^Ran/ }). There are no unresolved review threads, and the change stays scoped to the PM-1575 regression assertion. Hosted lint is green; broader hosted checks are still running, so this is evidence for independent disposition rather than merge approval.

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##           core/1.54   #18602      +/-   ##
=============================================
+ Coverage      83.63%   83.65%   +0.02%     
=============================================
  Files           2098     2098              
  Lines         123900   124087     +187     
  Branches       31367    33259    +1892     
=============================================
+ Hits          103618   103805     +187     
  Misses         20103    20103              
  Partials         179      179              
Flag Coverage Δ
e2e 66.72% <ø> (-0.01%) ⬇️
unit 78.65% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne enabled auto-merge (squash) September 23, 2026 17:40
core/1.54 already landed a more specific fix for the same test
assertion mismatch (e092a8b, #18617), so this branch's own
assertion-fix diff is superseded; took core/1.54's version for
AgentPanelRoot.test.ts.
@christian-byrne
christian-byrne merged commit 858af2b into core/1.54 Sep 23, 2026
58 checks passed
@christian-byrne
christian-byrne deleted the fix-pm1575-core154-test-assertion branch September 23, 2026 17:55
@github-actions github-actions Bot added risk:medium PR risk grade (advisory shadow check; grader-owned) and removed risk:high PR risk grade (advisory shadow check; grader-owned) labels Sep 23, 2026
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch risk:medium PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants