Repository navigation
fix: assert core/1.54's own settled-tool-call label in PM-1575 regression test (#18391 follow-up) - #18602
Conversation
…sion test (#18391 follow-up) #18595 backported #18391's PM-1575 gate-wiring fix to core/1.54, but its new regression test 'settles a mutating tool call immediately when no CRDT doc subscription is connected' asserted on the "Working..." composing status text, which is rendered by AgentMessage.vue's composing/status computed on main -- code that doesn't exist on core/1.54 (added by the separate, still-unbackported #17339). That merged into core/1.54 with the test still red. The PM-1575 fix itself is correct and unaffected by this; it's only this one assertion's observation point that doesn't exist on this branch. Retargeted it to check what core/1.54 actually shows once the tool call settles: ToolCallGroup.vue's own row flips from its spinner to the "Ran N tool call(s)" label (agent.ranToolCalls), the same UI this backport's Playwright spec already asserts on with a /^Ran/ matcher. Verified: pnpm vitest run AgentPanelRoot.test.ts -- 227 passed, 3 failed (the same pre-existing, unrelated "Media-card" upload flakes documented in #18595, confirmed identical on unmodified core/1.54). pnpm exec oxfmt --check and pnpm eslint on the file: clean. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1946 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
|
christian-byrne
left a comment
There was a problem hiding this comment.
At exact head b2cb3adc4b7154b4f16eef05b80ca16f54b6fef2, the complete one-file diff replaces the unavailable agent.working observation with the core/1.54 tool-row settlement surface, findByRole('button', { name: /^Ran/ }). There are no unresolved review threads, and the change stays scoped to the PM-1575 regression assertion. Hosted lint is green; broader hosted checks are still running, so this is evidence for independent disposition rather than merge approval.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18602 +/- ##
=============================================
+ Coverage 83.63% 83.65% +0.02%
=============================================
Files 2098 2098
Lines 123900 124087 +187
Branches 31367 33259 +1892
=============================================
+ Hits 103618 103805 +187
Misses 20103 20103
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Before
#18595 backported #18391's PM-1575 gate-wiring fix to
core/1.54, but its new regression test'settles a mutating tool call immediately when no CRDT doc subscription is connected'asserted on the "Working..." composing status text. That text is rendered byAgentMessage.vue'scomposing/statuscomputed onmain— code that doesn't exist oncore/1.54(it was added by a separate, still-unbackported PR, #17339). #18595 merged with this one test still red oncore/1.54.After
The PM-1575 fix itself is correct and unaffected by this; only this one assertion's observation point doesn't exist on this branch. Retargeted it to check what
core/1.54actually shows once the tool call settles:ToolCallGroup.vue's own row flips from its spinner to the "Ran N tool call(s)" label (agent.ranToolCalls) — the same UI this backport's Playwright spec already asserts on with a/^Ran/matcher.How
3-line change in
src/workbench/extensions/agent/AgentPanelRoot.test.ts: swappedscreen.findByText(i18n.global.t('agent.working'))forscreen.findByRole('button', { name: /^Ran/ }), and updated the adjacent comment.Verified:
pnpm vitest run AgentPanelRoot.test.ts— 227 passed, 3 failed (the same pre-existing, unrelated "Media-card" upload flakes documented in #18595, confirmed identical on unmodifiedcore/1.54).pnpm exec oxfmt --checkandpnpm eslinton the file: clean.Generated by Claude Code