Repository navigation
fix: match settle-immediately test assertion to core/1.54's ToolCallGroup UI - #18617
Conversation
…roup UI The PM-1575/PM-1576 backport (#18595) carried over a test that asserts the main-branch-only "agent.working" / "Working..." composing status, which core/1.54's AgentMessage.vue never renders (that status row is part of an unrelated, unbackported WorkSummary/ActivityTrace redesign). On this branch a settled mutating tool call is only observable through ToolCallGroup.vue's own trigger label ("Ran N tool calls..."), so this updates the assertion to match core/1.54's actual, working UI -- mirroring how #18579 fixed the analogous agent.worked/ToolCallGroup mismatch.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1946 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T17:05:45.293Z",
"gitSha": "e239fb3834facdfb841c69ca867c3c634e27f897",
"branch": "fix/agent-panel-working-status-core-1-54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.2860000000237,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.262000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.9459999999999,
"heapDeltaBytes": -12987784,
"heapUsedBytes": 56430856,
"domNodes": 16,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.471999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2050.0539999999887,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.062999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.278,
"heapDeltaBytes": -1426512,
"heapUsedBytes": 68854696,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.474,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1901.6240000000266,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.761000000000003,
"layouts": 14,
"layoutDurationMs": 4.023000000000001,
"taskDurationMs": 903.456,
"heapDeltaBytes": 8067912,
"heapUsedBytes": 79181516,
"domNodes": -284,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 162.107,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1940.8520000000067,
"styleRecalcs": 79,
"styleRecalcDurationMs": 35.098000000000006,
"layouts": 14,
"layoutDurationMs": 4.439,
"taskDurationMs": 964.3539999999999,
"heapDeltaBytes": 9669360,
"heapUsedBytes": 80790888,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 169.21,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.431999999993,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.390000000000004,
"layouts": 6,
"layoutDurationMs": 0.9769999999999998,
"taskDurationMs": 373.376,
"heapDeltaBytes": 4320952,
"heapUsedBytes": 74625184,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.315,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1678.765999999996,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.438000000000002,
"layouts": 6,
"layoutDurationMs": 1.1869999999999998,
"taskDurationMs": 363.14300000000003,
"heapDeltaBytes": 4312080,
"heapUsedBytes": 74632500,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.092999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 679.7490000000153,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.809,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.734,
"heapDeltaBytes": -7875776,
"heapUsedBytes": 63232164,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 169.685,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 693.5870000000364,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.982999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.546,
"heapDeltaBytes": 18288068,
"heapUsedBytes": 88657440,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 163.547,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.6870000000013,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.0580000000001,
"heapDeltaBytes": 10952412,
"heapUsedBytes": 86635356,
"domNodes": -270,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 36.468,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2057.1690000000444,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.690999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.1400000000001,
"heapDeltaBytes": 10539444,
"heapUsedBytes": 86977340,
"domNodes": -270,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 35.24200000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2324.674000000016,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.317000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1717.0769999999998,
"heapDeltaBytes": -8963944,
"heapUsedBytes": 68840496,
"domNodes": -282,
"jsHeapTotalBytes": -106496,
"scriptDurationMs": 845.9789999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2399.226999999996,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.981000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1700.1,
"heapDeltaBytes": 11929800,
"heapUsedBytes": 89161996,
"domNodes": -276,
"jsHeapTotalBytes": -1454080,
"scriptDurationMs": 840.904,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3626.0449999999764,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.040000000000001,
"layouts": 60,
"layoutDurationMs": 11.861,
"taskDurationMs": 1737.8969999999997,
"heapDeltaBytes": 10559404,
"heapUsedBytes": 76066256,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 800.6809999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3684.417999999937,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.268000000000002,
"layouts": 60,
"layoutDurationMs": 12.205,
"taskDurationMs": 1735.4860000000003,
"heapDeltaBytes": 8183172,
"heapUsedBytes": 76119244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.744,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3134.2880000000264,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.798000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1956.6970000000001,
"heapDeltaBytes": 25962364,
"heapUsedBytes": 94270356,
"domNodes": 2,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 983.754,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3086.8659999999863,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.092000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1946.37,
"heapDeltaBytes": 21863980,
"heapUsedBytes": 90190580,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 941.3410000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2052.4369999999976,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.911,
"heapDeltaBytes": 7703736,
"heapUsedBytes": 86132544,
"domNodes": -274,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 34.63899999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.679999999952,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4969999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.1639999999999,
"heapDeltaBytes": 22105276,
"heapUsedBytes": 88553560,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.06099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.7750000000506,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.380000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.12899999999996,
"heapDeltaBytes": 15027728,
"heapUsedBytes": 87893872,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 149.004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.6629999999632,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.812000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.65599999999995,
"heapDeltaBytes": 14716488,
"heapUsedBytes": 87710848,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.66400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.1909999999639,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.076999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.16800000000006,
"heapDeltaBytes": 6928020,
"heapUsedBytes": 79816600,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.596,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.298999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.630999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.772,
"heapDeltaBytes": -14697248,
"heapUsedBytes": 58381408,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.750999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.1159999999968,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.560000000000002,
"layouts": 18,
"layoutDurationMs": 4.916,
"taskDurationMs": 894.499,
"heapDeltaBytes": 757164,
"heapUsedBytes": 74057604,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 113.296,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1786.3270000000284,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.237,
"layouts": 18,
"layoutDurationMs": 5.991,
"taskDurationMs": 887.7560000000001,
"heapDeltaBytes": 5109404,
"heapUsedBytes": 78434912,
"domNodes": -298,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 120.923,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.5859999999993,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.357000000000006,
"layouts": 14,
"layoutDurationMs": 16.11,
"taskDurationMs": 952.4140000000001,
"heapDeltaBytes": 21236504,
"heapUsedBytes": 110163672,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 32.818000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8658.145999999988,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.666999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5970.8730000000005,
"heapDeltaBytes": 23955304,
"heapUsedBytes": 89515036,
"domNodes": -269,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2773.2200000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9247.282000000041,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.888000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6208.3009999999995,
"heapDeltaBytes": 9080120,
"heapUsedBytes": 85551496,
"domNodes": -269,
"jsHeapTotalBytes": 348160,
"scriptDurationMs": 2835.482,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17750.95299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17004.173,
"heapDeltaBytes": -57826532,
"heapUsedBytes": 181567548,
"domNodes": -8068,
"jsHeapTotalBytes": -17739776,
"scriptDurationMs": 297.995,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17362.99800000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16834.267999999996,
"heapDeltaBytes": -75309912,
"heapUsedBytes": 164209896,
"domNodes": -8068,
"jsHeapTotalBytes": -16736256,
"scriptDurationMs": 283.972,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21390.67700000004,
"styleRecalcs": 162,
"styleRecalcDurationMs": 19.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20989.48,
"heapDeltaBytes": -56871984,
"heapUsedBytes": 168749984,
"domNodes": -8068,
"jsHeapTotalBytes": -19881984,
"scriptDurationMs": 942.872,
"eventListeners": -14923,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21783.745999999952,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.791000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21409.286,
"heapDeltaBytes": -39149188,
"heapUsedBytes": 178932268,
"domNodes": -8068,
"jsHeapTotalBytes": -9187328,
"scriptDurationMs": 958.508,
"eventListeners": -14927,
"totalBlockingTimeMs": 53,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6394.667000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.93,
"layouts": 20,
"layoutDurationMs": 23.203000000000003,
"taskDurationMs": 6301.4220000000005,
"heapDeltaBytes": -49392360,
"heapUsedBytes": 178408192,
"domNodes": -8068,
"jsHeapTotalBytes": 5873664,
"scriptDurationMs": 116.55699999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 443,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6289.413999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.86499999999997,
"layouts": 20,
"layoutDurationMs": 24.774000000000004,
"taskDurationMs": 6159.5419999999995,
"heapDeltaBytes": -57182860,
"heapUsedBytes": 175860144,
"domNodes": -8068,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 117.759,
"eventListeners": -14929,
"totalBlockingTimeMs": 624,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8795.883000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8460.68,
"heapDeltaBytes": 22356628,
"heapUsedBytes": 179263328,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 143.51100000000005,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8842.659000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8439.297000000002,
"heapDeltaBytes": 12257508,
"heapUsedBytes": 178522408,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 155.86600000000007,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 174.52099999997017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.437,
"layouts": 3,
"layoutDurationMs": 1.087,
"taskDurationMs": 116.24299999999998,
"heapDeltaBytes": 3119064,
"heapUsedBytes": 71168084,
"domNodes": 116,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.762999999999999,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 470.91199999999844,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.711,
"layouts": 4,
"layoutDurationMs": 1.6139999999999999,
"taskDurationMs": 114.653,
"heapDeltaBytes": 4910284,
"heapUsedBytes": 69322132,
"domNodes": 140,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.826,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18617 +/- ##
=============================================
+ Coverage 83.63% 83.65% +0.02%
=============================================
Files 2098 2098
Lines 123900 124087 +187
Branches 31367 33259 +1892
=============================================
+ Hits 103618 103805 +187
Misses 20103 20103
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Exact-head hosted checks are terminal/non-adverse and Christian’s approval covers |
Pulls in the nested-subgraph-insert fix (comfy-multi-player#253). core/1.54 landed at 0.3.5 (via #18617, concurrently with this PR's original 0.3.4 base) before this could merge; rebased onto that and bumped straight through to 0.3.6.
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Before/After **Before:** `core/1.54` pinned `@comfyorg/comfy-multi-player` directly (not via the pnpm catalog). It started this PR at `0.3.4` (this branch never picked up the `0.3.5` catalog backport that `main`/`cloud/1.54` got); while this PR was open, `core/1.54`'s tip independently moved to `0.3.5` (via #18617). Either way, the nested-subgraph-instance `insert_workflow` bug (an interior node that is itself a subgraph instance materializes widget-less) was present. **After:** rebased onto `core/1.54`'s current tip and bumped `package.json`'s direct dependency to `0.3.6`, plus the `minimumReleaseAgeExclude` entry in `pnpm-workspace.yaml`/`pnpm-lock.yaml`. `0.3.6` carries the fix from `comfy-multi-player#253`. ## Note on scope Pin bump only, opened directly against `core/1.54` (not stacked). This branch does not have the nested-subgraph regression test that PR #18624 is adding to `main` (that PR is itself still open/unmerged), so there is nothing to flip here. ## Testing - `pnpm install --frozen-lockfile` resolves clean against `0.3.6` (verified installed `node_modules/@comfyorg/comfy-multi-player/package.json` reports `0.3.6`). - `pnpm exec vitest run src/workbench/extensions/agent/crdt/`: 715 passed, 3 expected-fail (baseline on this branch's current tip, no regressions from the bump alone). - Confirmed `0.3.6` is actually live on the public npm registry (dist-tags.latest = 0.3.6) before opening this PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Requested by Christian Byrne · Slack thread
Before
AgentPanelRoot.test.ts's "settles a mutating tool call immediately when no CRDT doc subscription is connected" test (added by the PM-1575/PM-1576 backport, #18595) assertedscreen.findByText(i18n.global.t('agent.working'))— the "Working..." composing status that onlymain'sAgentMessage.vuerenders (part of an unrelated, unbackportedWorkSummary/ActivityTraceredesign).core/1.54'sAgentMessage.vuehas no such row at all;agent.workinghas zero non-test usages on this branch. The test failed deterministically oncore/1.54's own tip, independent of any other PR's diff (reproduced on an unrelated push: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35856856362, job 107167326258), and was blocking the required "test" CI check on unrelated backport PRs such as #18600.After
The assertion now matches what
core/1.54actually — and correctly — renders: once the mutating tool call's part settles from'streaming'to'done'(the real PM-1575 behavior under test),ToolCallGroup.vue's trigger shows the settled"Ran 1 tool call for 0.1 seconds"label. This mirrors how #18579 fixed the analogousagent.worked/ToolCallGroupmismatch elsewhere in this same file, rather than backporting the full main-branch UI redesign.Verification
npx vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts -t "settles a mutating tool call immediately": passes.npx vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts(full file): 227/230 pass; the 3 remaining failures (T-08 / PM-646 / FE-1314attach-flow tests) are pre-existing oncore/1.54's tip regardless of this change (confirmed by running the same tests viagit stashagainst the unmodified file) and are unrelated to this fix.npx eslinton the changed file: clean.npx vue-tsc --noEmit: no errors on the changed file.🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code