Skip to content

[backport cloud/1.54] chore: backport BE-11470 conversation-replay fixtures - #18586

Merged
comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-be11470-fixtures-to-cloud-1.54
Sep 23, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-be11470-fixtures-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Before

cloud/1.54 has no browser_tests/fixtures/data/agent/conversations/ directory at all. #18391's backport adds a regression test (agentEventTransport CANVAS_MUTATING_TOOLS pinning (PM-1575)) that does a bare fs.readdirSync + JSON.parse over that directory to pin every tool name seen in the recorded conversation corpus — with the directory missing, that test fails with ENOENT.

After

The 16 pure JSON fixture files from the BE-11470 work land at the same paths: the 13 recorded conversations from #16764, plus 2 more conversations and 1 seed workflow from #17416. Zero code.

How

Deliberately narrow: this pulls only the JSON data files via git checkout <sha> -- <path> from the original commits, not the harness/loader/host-doc/capability-matrix code those PRs also added. cloud/1.54 already has its own independently-evolved replay and fake-host-doc test infrastructure (used by several other e2e specs), and re-introducing main's older version of that harness would conflict with it and risk regressing those specs. The one thing that's actually needed here — the new pinning test from #18391 — only reads these files off disk directly, so the fixture data alone fully unblocks it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NQDb2pk4BuLEgzkga3GhEs


Generated by Claude Code

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 5:41pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c70f9ad8-eaf5-47df-99de-57f212417545

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1945 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1924 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 143ms TBT · 101.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 47ms TBT · 177.0 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 501ms TBT · 171.9 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 504ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.3 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 978ms
canvas-mouse-sweep: script duration 176ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -165
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 353ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 449ms
dom-widget-clipping: script duration 161ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.4 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 619ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.4 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1681ms
large-graph-pan: script duration 840ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.1 MB
large-graph-pan: DOM nodes -269
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1764ms
large-graph-zoom: script duration 782ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.9 MB
large-graph-zoom: DOM nodes -283
large-graph-zoom: event listeners -193
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1941ms
legacy-node-drag: script duration 969ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.2 MB
legacy-node-drag: DOM nodes -124
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 634ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.6 MB
minimap-idle: DOM nodes -274
minimap-idle: event listeners -193
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 418ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.2 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 488ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.9 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 812ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.6 MB
subgraph-mouse-sweep: DOM nodes -294
subgraph-mouse-sweep: event listeners -211
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 932ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 143ms
subgraph-transition-enter: heap used 101.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5918ms
viewport-pan-sweep: script duration 2797ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.0 MB
viewport-pan-sweep: DOM nodes -255
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16518ms
vue-large-graph-idle: script duration 303ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 20431ms
vue-large-graph-pan: script duration 958ms
vue-large-graph-pan: TBT 47ms
vue-large-graph-pan: heap used 177.0 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 86ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6040ms
vue-node-resize-workload: script duration 123ms
vue-node-resize-workload: TBT 501ms
vue-node-resize-workload: heap used 171.9 MB
vue-node-resize-workload: DOM nodes -8083
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8298ms
vue-zoom-out-idle: script duration 133ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 15
workflow-execution: task duration 107ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.6 MB
workflow-execution: DOM nodes 131
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-23T17:53:15.793Z",
  "gitSha": "8d524877b30a46ff7b6caad86c6d854d0251409d",
  "branch": "backport-be11470-fixtures-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.6030000000233,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 11.548999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.9509999999999,
      "heapDeltaBytes": -9594912,
      "heapUsedBytes": 60695992,
      "domNodes": -276,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.498000000000003,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.3749999999973,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.224999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.4289999999999,
      "heapDeltaBytes": -3150496,
      "heapUsedBytes": 67818284,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.986,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2088.8949999999795,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 37.039,
      "layouts": 14,
      "layoutDurationMs": 4.854,
      "taskDurationMs": 1047.241,
      "heapDeltaBytes": 7872488,
      "heapUsedBytes": 78068208,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 183.734,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1892.0569999999657,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.822,
      "layouts": 14,
      "layoutDurationMs": 4.164000000000001,
      "taskDurationMs": 909.281,
      "heapDeltaBytes": -6112096,
      "heapUsedBytes": 64113028,
      "domNodes": -280,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 168.669,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.4389999999848,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 14.642000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.0250000000000001,
      "taskDurationMs": 349.509,
      "heapDeltaBytes": 4302548,
      "heapUsedBytes": 74982704,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.517,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.0000000000036,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.611,
      "layouts": 6,
      "layoutDurationMs": 1.0739999999999998,
      "taskDurationMs": 356.51,
      "heapDeltaBytes": 4691776,
      "heapUsedBytes": 75693600,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.175,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 671.7219999999884,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.911000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.80299999999994,
      "heapDeltaBytes": -7193116,
      "heapUsedBytes": 63600380,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 160.84599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 647.7970000000255,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.949999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.836,
      "heapDeltaBytes": 18679772,
      "heapUsedBytes": 88177620,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 160.70499999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.5890000000209,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.7509999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 604.858,
      "heapDeltaBytes": -16290648,
      "heapUsedBytes": 87147072,
      "domNodes": -268,
      "jsHeapTotalBytes": -331776,
      "scriptDurationMs": 30.980999999999995,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2070.9209999999985,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.809000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 633.086,
      "heapDeltaBytes": 5592932,
      "heapUsedBytes": 81477392,
      "domNodes": -279,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 34.672999999999995,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2379.4980000000123,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.822,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1709.1129999999998,
      "heapDeltaBytes": 8139216,
      "heapUsedBytes": 85836400,
      "domNodes": -270,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 859.968,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2231.514000000061,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.254,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1652.2289999999998,
      "heapDeltaBytes": -13763220,
      "heapUsedBytes": 90620532,
      "domNodes": -268,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 819.4449999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3646.5310000000386,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.551,
      "layouts": 60,
      "layoutDurationMs": 11.844999999999997,
      "taskDurationMs": 1769.1080000000002,
      "heapDeltaBytes": -2931800,
      "heapUsedBytes": 75975096,
      "domNodes": -280,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 784.512,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3584.9660000000085,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.493000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.034999999999998,
      "taskDurationMs": 1759.714,
      "heapDeltaBytes": -7587100,
      "heapUsedBytes": 70567396,
      "domNodes": -286,
      "jsHeapTotalBytes": 4087808,
      "scriptDurationMs": 779.888,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3147.4289999999883,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.355999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1975.5179999999996,
      "heapDeltaBytes": 3463608,
      "heapUsedBytes": 84069412,
      "domNodes": -248,
      "jsHeapTotalBytes": 311296,
      "scriptDurationMs": 989.465,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3049.8999999999796,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.633000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1907.0170000000003,
      "heapDeltaBytes": 19906516,
      "heapUsedBytes": 88218956,
      "domNodes": 0,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 948.054,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.3599999999929,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.009000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 630.205,
      "heapDeltaBytes": 5227684,
      "heapUsedBytes": 82283548,
      "domNodes": -274,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 39.21200000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2089.264999999955,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 7.099999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 638.4540000000001,
      "heapDeltaBytes": 6680104,
      "heapUsedBytes": 84713120,
      "domNodes": -274,
      "jsHeapTotalBytes": -630784,
      "scriptDurationMs": 33.399,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.3819999999964,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.181,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.539,
      "heapDeltaBytes": 15110348,
      "heapUsedBytes": 88559828,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 145.982,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.3129999999765,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.214999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.178,
      "heapDeltaBytes": 15004996,
      "heapUsedBytes": 88086592,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 146.494,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.8940000000316,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.478999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.66,
      "heapDeltaBytes": -13050716,
      "heapUsedBytes": 59658924,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.046,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.7250000000317,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.034999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.37199999999996,
      "heapDeltaBytes": -7094776,
      "heapUsedBytes": 65861412,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.7200000000000015,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1768.0890000000318,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 30.544,
      "layouts": 18,
      "layoutDurationMs": 5.226,
      "taskDurationMs": 826.356,
      "heapDeltaBytes": -14783200,
      "heapUsedBytes": 58389412,
      "domNodes": -293,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 110.204,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1740.2910000000134,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.497999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.7540000000000004,
      "taskDurationMs": 798.4579999999999,
      "heapDeltaBytes": 5847320,
      "heapUsedBytes": 79164396,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 109.23500000000001,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1402.183999999977,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.633000000000003,
      "layouts": 16,
      "layoutDurationMs": 15.746999999999996,
      "taskDurationMs": 931.751,
      "heapDeltaBytes": 21945464,
      "heapUsedBytes": 106705740,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 30.966999999999995,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 143,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8605.210999999998,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.762,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6014.972999999999,
      "heapDeltaBytes": 7626684,
      "heapUsedBytes": 84144504,
      "domNodes": -243,
      "jsHeapTotalBytes": 348160,
      "scriptDurationMs": 2909.7120000000004,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8373.325999999906,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.382999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5820.194,
      "heapDeltaBytes": 13882924,
      "heapUsedBytes": 89932816,
      "domNodes": -266,
      "jsHeapTotalBytes": -405504,
      "scriptDurationMs": 2683.571,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17045.76800000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16476.212999999996,
      "heapDeltaBytes": -40108108,
      "heapUsedBytes": 178022148,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12324864,
      "scriptDurationMs": 283.94399999999996,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17034.82800000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16560.314000000002,
      "heapDeltaBytes": -41127032,
      "heapUsedBytes": 176415924,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8445952,
      "scriptDurationMs": 322.746,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20792.016999999985,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 18.245999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20449.042999999998,
      "heapDeltaBytes": -21400652,
      "heapUsedBytes": 177779840,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8089600,
      "scriptDurationMs": 918.406,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 62,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20903.665000000045,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 17.011999999999972,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20412.895,
      "heapDeltaBytes": -34767044,
      "heapUsedBytes": 193479116,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17592320,
      "scriptDurationMs": 996.795,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6114.615000000014,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 86.50699999999995,
      "layouts": 20,
      "layoutDurationMs": 23.701,
      "taskDurationMs": 6013.076,
      "heapDeltaBytes": -40084280,
      "heapUsedBytes": 177115816,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11476992,
      "scriptDurationMs": 137.01000000000002,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 474,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6182.356000000027,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.31499999999997,
      "layouts": 20,
      "layoutDurationMs": 24.460000000000008,
      "taskDurationMs": 6067.044,
      "heapDeltaBytes": -35319708,
      "heapUsedBytes": 183299152,
      "domNodes": -8097,
      "jsHeapTotalBytes": 12812288,
      "scriptDurationMs": 108.7,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 528,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8464.409999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8273.668999999998,
      "heapDeltaBytes": 9701800,
      "heapUsedBytes": 179061460,
      "domNodes": 0,
      "jsHeapTotalBytes": -6291456,
      "scriptDurationMs": 134.405,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8533.925999999952,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8321.654000000002,
      "heapDeltaBytes": 22117372,
      "heapUsedBytes": 182115216,
      "domNodes": 0,
      "jsHeapTotalBytes": -6815744,
      "scriptDurationMs": 130.99799999999993,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 495.33700000000636,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 21.351000000000003,
      "layouts": 4,
      "layoutDurationMs": 2.437,
      "taskDurationMs": 119.893,
      "heapDeltaBytes": 4976452,
      "heapUsedBytes": 74235360,
      "domNodes": 143,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 10.834000000000001,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.2719999999981,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 18.597999999999995,
      "layouts": 2,
      "layoutDurationMs": 0.55,
      "taskDurationMs": 94.932,
      "heapDeltaBytes": 4755564,
      "heapUsedBytes": 73812056,
      "domNodes": 119,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.741999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50407 75602 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 05:43:08 PM UTC

Links

Backports only the pure JSON fixture data from the BE-11470
conversation-replay work to cloud/1.54: the 13 recorded-conversation
fixtures from #16764, plus the 2 additional conversations and 1 seed
workflow from #17416. No harness, loader, or capability-matrix code is
included -- cloud/1.54 already has its own independently-evolved
replay/host-doc test infrastructure, and #18391's regression test only
needs a bare fs.readdirSync + JSON.parse over this directory.
@claude
claude Bot force-pushed the backport-be11470-fixtures-to-cloud-1.54 branch from 5b1c7c1 to 29f34da Compare September 23, 2026 10:16
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.64804% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 60.00% 4 Missing ⚠️
...sions/agent/stores/agent/agentConversationStore.ts 96.55% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18586   +/-   ##
=============================================
  Coverage              ?   83.68%           
=============================================
  Files                 ?     2105           
  Lines                 ?   124769           
  Branches              ?    31694           
=============================================
  Hits                  ?   104418           
  Misses                ?    20172           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.68% <ø> (?)
unit 78.73% <96.64%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 97.65% <100.00%> (ø)
...nsions/agent/services/agent/agentEventTransport.ts 100.00% <100.00%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 97.36% <96.55%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 91.54% <60.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…s materialization (PM-1575/PM-1576) (#18593)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_

## Before

An agent tool call that touches the canvas (e.g. adding a node) reports
done — the tool's own row flips straight to its settled icon — while the
canvas itself still shows nothing for the new content, for a stretch
that can run close to 10 real seconds. `agentEventTransport.ts`'s
`ingest()` flipped a tool part's `state` to `'done'` purely from the
chat-channel `agent_tool_call` frame's own `status` field, with zero
coupling to whether the corresponding CRDT `doc_update` had actually
reached and been projected onto the canvas.

## After

`createAgentEventTransport` now takes an optional
`shouldAwaitCanvasSync` gate. While it returns `true`, a tool call that
reports done holds its part's displayed `state` at `'streaming'` instead
of flipping straight to `'done'`, until either `notifyCanvasCaughtUp()`
is called or `STALE_AFTER_MS` (30s) elapses. `agentConversationStore.ts`
threads this gate through every transport it creates and exposes
`setCanvasSyncGate` / `notifyCanvasCaughtUp`; `AgentPanelRoot.vue` wires
the gate to `agentPanelStore.enabled` and calls `notifyCanvasCaughtUp()`
whenever the CRDT follower's `outcomes.appliedLive` counter increases
for the bound workflow. The gate defaults to always-`false`, so any
caller that never wires it up keeps the old immediate-done behavior
unchanged.

## How

Cherry-picked #18391's merge commit onto `cloud/1.54` (stacked on
#18586, which backports the JSON fixture corpus this PR's new regression
test reads off disk). `cloud/1.54` has diverged architecturally from
`main` in this area since PM-1355/#18179: `useAgentCrdtFollower.ts`
inlines outcome tracking in its `onUpdate` handler instead of the
`incrementOutcome`/`applyAndReconcile` helpers #18391 was written
against, so the two real conflicts there were resolved by porting
#18391's actual upstream diff (the `appliedLive`/`!update.catchUp`
classification) into `cloud/1.54`'s current handler rather than
reintroducing stale helper functions. Three follow-up fixes for other
main-only references that only surfaced once the build/tests ran (not as
git conflicts): `STALE_AFTER_MS` now imports from
`useAgentCrdtFollower.ts` (its current home on this branch, not the
`agentCrdtDocLifecycle.ts` split that hasn't landed here), and the new
e2e spec's `UserDataFullInfo` import, open-agent button i18n key, and
`HostDoc` node-presence check were pointed at their current cloud/1.54
equivalents. `pnpm lint`, `pnpm typecheck`, `pnpm typecheck:browser`,
and the full targeted unit suite (`agentEventTransport.test.ts`,
`agentConversationStore.test.ts`, `useAgentCrdtFollower.test.ts` —
155/155) all pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01NQDb2pk4BuLEgzkga3GhEs

---
_Generated by [Claude
Code](https://claude.ai/code/session_01NQDb2pk4BuLEgzkga3GhEs)_

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
@comfy-pr-bot
comfy-pr-bot merged commit b8a52c2 into cloud/1.54 Sep 23, 2026
91 of 92 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-be11470-fixtures-to-cloud-1.54 branch September 23, 2026 20:47
comfy-pr-bot pushed a commit that referenced this pull request Sep 23, 2026
## Summary

Backports six merged `main` Agent fixes to `cloud/1.54` and repairs the
`agentCanvasLagsToolCallCompletion` e2e spec that #18586 landed with,
which fails `typecheck:browser` on the current branch tip.

## Changes

- **What**: `cherry-pick -x` of #17568, #17628, #16491, #18453, #17767
and #18603, in `main` merge order. The spec fix uses `entryButton` and
the "Worked for" summary instead of the labels #18622 removed, and adds
`HostDoc.graph()` to the conversation host-doc fixture. #18391 itself is
already on the line via #18586 and is unchanged here.
- **Excluded**: #18066 (Christian's request), #16908 (refactor), #18375
(needs its `src/lib/litegraph/` half).

## Review Focus

- #18603 forwards two new onboarding telemetry events for every user,
not only Agent users.
- `AgentPanelRoot.vue` changes come from #16491 and #17767 on top of
#18391's merged code; `useAgentCrdtFollower.ts` is identical to the tip.
- Merging the tip resolved two conflicts: the spec (this copy) and
`AgentPanelRoot.test.ts` (the tip's #18391 test plus these picks).
- Second batch (#16856, #18204, #18229, #17327, #18251, #16985, #18224)
follows on this tip.

Linear: [PM-1656](https://linear.app/comfyorg/issue/PM-1656)

## Screenshots (if applicable)

No new visuals; #17568 and #17767 were reviewed on `main`.

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
christian-byrne added a commit that referenced this pull request Sep 26, 2026
Eight backport carriers each dropped their black-box proof spec because the
agent conversation-replay harness family was never backported, so most agent
CRDT fixes on this line ship with unit coverage only. Christian ruled on
2026-09-26 that 1.54 has another week and the test infra should be carried.

Test infrastructure only; no product file is touched.

Carried from main, byte-identical except where this branch's surface differs:

- browser_tests/fixtures/agentConversationFixture.ts
- browser_tests/fixtures/data/agent/agentConversation.ts (+ .test.ts)
- browser_tests/fixtures/data/agent/agentConversationExpectations.ts
- browser_tests/fixtures/data/agent/agentHumanAddBlueprints.ts
- browser_tests/fixtures/data/agentReplayNodeDefs.ts
- browser_tests/fixtures/utils/agentReplayNodeContract.ts (+ .test.ts)
- browser_tests/tests/agent/agentConversationReplay.spec.ts
- browser_tests/tests/agent/agentWidgetTypingReconcile.spec.ts
- browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts

Branch adaptations, each with a comment at the site saying why:

- agentConversation.ts drops the messageDraft slot of zAgentWsEvent.
  zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not
  on this branch.
- agentPanelFixture.ts gains mockWorkflowPersistence and the vueNodes boot
  option. UserDataFullInfo comes from @/schemas/apiSchema, not main's
  @/platform/remote/comfyui/types, which does not exist here -- the same
  adaptation savedWorkflowPersistence.ts already carries.
- agentConversationFixture.ts waits on PrimeVue's .p-blockui-mask instead of
  data-testid="app-loading-overlay", which App.vue does not render here.
- agentConversationHostDoc.ts apply() takes RecordedGraphOperation[].
- Topbar gains tabs; selectors gains topbar.workflowTab, whose test id
  WorkflowTab.vue already renders on this branch.
- globals.d.ts gains TabSwitchLens and window.__tabSwitchLens.
- Four exports in agentConversation.ts are module-local here; their only
  consumer on main is scripts/agentConversationAssemble.ts, not backported.

The 15 recorded conversation JSON files are already on this branch and
byte-identical to main (#18585/#18586), so this is harness code only.

Not carried, deliberately: main's agentFollowerHostSocket.ts, whose newer
members this harness does not use and which imports
@/platform/remote/comfyui/execution/types -- absent here, the same missing
module that left core/1.54 red for six hours (#18722); the recording-authoring
tools under scripts/ and tools/test-recorder; agentConversationCapabilityMatrix.
christian-byrne added a commit that referenced this pull request Sep 26, 2026
Eight backport carriers each dropped their black-box proof spec because the
agent conversation-replay harness family was never backported, so most agent
CRDT fixes on this line ship with unit coverage only. Christian ruled on
2026-09-26 that 1.54 has another week and the test infra should be carried.

Test infrastructure only; no product file is touched.

Carried from main, byte-identical except where this branch's surface differs:

- browser_tests/fixtures/agentConversationFixture.ts
- browser_tests/fixtures/data/agent/agentConversation.ts (+ .test.ts)
- browser_tests/fixtures/data/agent/agentConversationExpectations.ts
- browser_tests/fixtures/data/agent/agentHumanAddBlueprints.ts
- browser_tests/fixtures/data/agentReplayNodeDefs.ts
- browser_tests/fixtures/utils/agentReplayNodeContract.ts (+ .test.ts)
- browser_tests/tests/agent/agentConversationReplay.spec.ts
- browser_tests/tests/agent/agentWidgetTypingReconcile.spec.ts
- browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts

Branch adaptations, each with a comment at the site saying why:

- agentConversation.ts drops the messageDraft slot of zAgentWsEvent.
  zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not
  on this branch.
- agentPanelFixture.ts gains mockWorkflowPersistence and the vueNodes boot
  option. UserDataFullInfo comes from @/schemas/apiSchema, not main's
  @/platform/remote/comfyui/types, which does not exist here -- the same
  adaptation savedWorkflowPersistence.ts already carries.
- agentConversationFixture.ts waits on PrimeVue's .p-blockui-mask instead of
  data-testid="app-loading-overlay", which App.vue does not render here.
- agentConversationHostDoc.ts apply() takes RecordedGraphOperation[].
- Topbar gains tabs; selectors gains topbar.workflowTab, whose test id
  WorkflowTab.vue already renders on this branch.
- globals.d.ts gains TabSwitchLens and window.__tabSwitchLens.
- Four exports in agentConversation.ts are module-local here; their only
  consumer on main is scripts/agentConversationAssemble.ts, not backported.

The 15 recorded conversation JSON files are already on this branch and
byte-identical to main (#18585/#18586), so this is harness code only.

Not carried, deliberately: main's agentFollowerHostSocket.ts, whose newer
members this harness does not use and which imports
@/platform/remote/comfyui/execution/types -- absent here, the same missing
module that left core/1.54 red for six hours (#18722); the recording-authoring
tools under scripts/ and tools/test-recorder; agentConversationCapabilityMatrix.
christian-byrne added a commit that referenced this pull request Sep 26, 2026
…18968)

## Summary

Backports the agent conversation-replay test harness to `cloud/1.54` so
the release line can replay the 15 recorded agent conversations it
already carries. Test infrastructure only — no product file is touched.

## Changes

- **What**: the harness family (`agentConversationFixture.ts`,
`data/agent/agentConversation.ts`, `agentConversationExpectations.ts`,
`agentHumanAddBlueprints.ts`, `data/agentReplayNodeDefs.ts`,
`utils/agentReplayNodeContract.ts`), the two harness self-tests, and
three black-box specs that consume it. Small additive hunks to
`agentPanelFixture.ts`, `agentConversationHostDoc.ts`,
`components/Topbar.ts`, `selectors.ts` and `types/globals.d.ts`.
- **Dependencies**: none new. The 17 recorded-conversation JSON files
landed earlier (#18585/#18586) and are byte-identical to `main`.

### Why

Eight carriers each dropped their black-box proof spec one at a time,
for the same reason: this harness family (from unbackported #16764 /
#17537 / #17875 / #18164) does not exist on the 1.54 pair, so most agent
CRDT fixes on this line ship with unit coverage only. #18758 recorded
the intended remedy — "left for a follow-up once the agent Playwright
fixture infrastructure itself is backported". Christian ruled on
2026-09-26 that 1.54 has another week and the test infra should be
carried, which is this PR.

`agentWidgetTypingReconcile.spec.ts` is the payoff worth naming: it is
the black-box proof of the widget-typing garble fix (PM-1191/PM-1697), a
P0 that is live in production on this line with no e2e coverage here
until now.

## Review Focus

Everything came from `main` byte-identical except the adaptations below,
each commented at the site:

| Adaptation | Why |
|---|---|
| `agentConversation.ts` drops the `messageDraft` slot of
`zAgentWsEvent` | `zAgentMessageDraftEvent` arrived with #18551
(streaming reply), which is not on this branch. Re-add it if #18551 is
carried. |
| `mockWorkflowPersistence` reads `UserDataFullInfo` from
`@/schemas/apiSchema` | `main` reads it from
`@/platform/remote/comfyui/types`, which does not exist here.
`browser_tests/fixtures/utils/savedWorkflowPersistence.ts` already
carries exactly this adaptation. |
| `reloadWithoutLocalWorkflow()` waits on `.p-blockui-mask` | `App.vue`
on this branch renders PrimeVue `BlockUI`, not
`data-testid="app-loading-overlay"`. `ComfyPage` already matches the
mask this way. |
| `HostDoc.apply()` takes `RecordedGraphOperation[]` | matches `main`;
the applier is the only judge of a recorded op. |
| `Topbar.tabs` + `TestIds.topbar.workflowTab` | `WorkflowTab.vue`
already renders `data-testid="workflow-tab"` on this branch. |
| four exports in `agentConversation.ts` are module-local | their only
consumer on `main` is `scripts/agentConversationAssemble.ts`, which is
not backported. |

**Deliberately not carried**, and the one that matters for review:

- `main`'s newer `agentFollowerHostSocket.ts`. This harness uses none of
its added members, and it imports
`@/platform/remote/comfyui/execution/types` — absent on this branch.
That is the same missing-module shape that left `core/1.54` red for six
hours after #18722, so the branch's existing socket is kept as-is.
- The recording-authoring side
(`scripts/agentConversation{Assemble,FromLangfuse,Record}.ts`,
`tools/test-recorder/.../agentReplay.ts`,
`agentConversationCapabilityMatrix`). A release branch needs to replay
the recordings it has, not author new ones.

Verified locally against this branch: `pnpm typecheck` and `pnpm
typecheck:browser` clean, `pnpm knip` clean, `pnpm lint` 0 errors, the
three carried vitest files 33/33 green, and `playwright --project=cloud`
on `agentConversationReplay.spec.ts` 19/20 and
`agentWidgetTypingReconcile.spec.ts` 1/1. Two `agentHumanAddTabSwitch`
subgraph-blueprint cases and the one `@screenshot` case cannot be judged
outside the CI container — both behave identically on a `main` checkout
in the same local setup, so CI is the arbiter for those three.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants