Skip to content

[backport cloud/1.54] fix: agent tool-call chat completion lags canvas materialization (PM-1575/PM-1576) - #18593

Merged
christian-byrne merged 6 commits into
backport-be11470-fixtures-to-cloud-1.54from
backport-18391-to-cloud-1.54
Sep 23, 2026
Merged

christian-byrne merged 6 commits into
backport-be11470-fixtures-to-cloud-1.54from
backport-18391-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Before

An agent tool call that touches the canvas (e.g. adding a node) reports done — the tool's own row flips straight to its settled icon — while the canvas itself still shows nothing for the new content, for a stretch that can run close to 10 real seconds. agentEventTransport.ts's ingest() flipped a tool part's state to 'done' purely from the chat-channel agent_tool_call frame's own status field, with zero coupling to whether the corresponding CRDT doc_update had actually reached and been projected onto the canvas.

After

createAgentEventTransport now takes an optional shouldAwaitCanvasSync gate. While it returns true, a tool call that reports done holds its part's displayed state at 'streaming' instead of flipping straight to 'done', until either notifyCanvasCaughtUp() is called or STALE_AFTER_MS (30s) elapses. agentConversationStore.ts threads this gate through every transport it creates and exposes setCanvasSyncGate / notifyCanvasCaughtUp; AgentPanelRoot.vue wires the gate to agentPanelStore.enabled and calls notifyCanvasCaughtUp() whenever the CRDT follower's outcomes.appliedLive counter increases for the bound workflow. The gate defaults to always-false, so any caller that never wires it up keeps the old immediate-done behavior unchanged.

How

Cherry-picked #18391's merge commit onto cloud/1.54 (stacked on #18586, which backports the JSON fixture corpus this PR's new regression test reads off disk). cloud/1.54 has diverged architecturally from main in this area since PM-1355/#18179: useAgentCrdtFollower.ts inlines outcome tracking in its onUpdate handler instead of the incrementOutcome/applyAndReconcile helpers #18391 was written against, so the two real conflicts there were resolved by porting #18391's actual upstream diff (the appliedLive/!update.catchUp classification) into cloud/1.54's current handler rather than reintroducing stale helper functions. Three follow-up fixes for other main-only references that only surfaced once the build/tests ran (not as git conflicts): STALE_AFTER_MS now imports from useAgentCrdtFollower.ts (its current home on this branch, not the agentCrdtDocLifecycle.ts split that hasn't landed here), and the new e2e spec's UserDataFullInfo import, open-agent button i18n key, and HostDoc node-presence check were pointed at their current cloud/1.54 equivalents. pnpm lint, pnpm typecheck, pnpm typecheck:browser, and the full targeted unit suite (agentEventTransport.test.ts, agentConversationStore.test.ts, useAgentCrdtFollower.test.ts — 155/155) all pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NQDb2pk4BuLEgzkga3GhEs


Generated by Claude Code

@claude claude Bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 11:37am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 228fe546-e5b4-44b6-acb1-9adb8c9358f2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 11:39:34 AM UTC

Links

🎭 Playwright: ✅ 1945 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1924 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 145ms TBT · 80.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.8 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 99ms TBT · 167.6 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 540ms TBT · 168.7 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 567ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.6 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 909ms
canvas-mouse-sweep: script duration 165ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.2 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -179
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 402ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 75.3 MB
canvas-zoom-sweep: DOM nodes -51
canvas-zoom-sweep: event listeners -63
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 463ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 641ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.4 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1741ms
large-graph-pan: script duration 849ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.4 MB
large-graph-pan: DOM nodes -277
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1845ms
large-graph-zoom: script duration 814ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes -286
large-graph-zoom: event listeners -192
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 2026ms
legacy-node-drag: script duration 990ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.9 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 631ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.2 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -162
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 13ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 431ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.7 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 539ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.0 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 908ms
subgraph-mouse-sweep: script duration 124ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.8 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -240
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 966ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 80.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6225ms
viewport-pan-sweep: script duration 2847ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 78.1 MB
viewport-pan-sweep: DOM nodes -273
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16901ms
vue-large-graph-idle: script duration 321ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.8 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 171
vue-large-graph-pan: task duration 21098ms
vue-large-graph-pan: script duration 980ms
vue-large-graph-pan: TBT 99ms
vue-large-graph-pan: heap used 167.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14925
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 29ms
vue-node-resize-workload: style recalc duration 87ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6188ms
vue-node-resize-workload: script duration 117ms
vue-node-resize-workload: TBT 540ms
vue-node-resize-workload: heap used 168.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8468ms
vue-zoom-out-idle: script duration 146ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 76ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.9 MB
workflow-execution: DOM nodes 108
workflow-execution: event listeners 33
Raw data
{
  "timestamp": "2026-09-23T11:49:08.999Z",
  "gitSha": "f65fdb4b22030f7688716116e65c6e1f2244c3ae",
  "branch": "backport-18391-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2047.8060000000369,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.0470000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 591.031,
      "heapDeltaBytes": 1762572,
      "heapUsedBytes": 72120680,
      "domNodes": -282,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.119000000000003,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.3109999999842,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.028,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.9300000000001,
      "heapDeltaBytes": 9969100,
      "heapUsedBytes": 80073016,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.090000000000002,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1834.3570000000682,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 31.275,
      "layouts": 14,
      "layoutDurationMs": 4.304,
      "taskDurationMs": 906.9000000000001,
      "heapDeltaBytes": -12068120,
      "heapUsedBytes": 58732928,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 167.128,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1855.7909999999538,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 30.875000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.364,
      "taskDurationMs": 911.0939999999998,
      "heapDeltaBytes": 11019376,
      "heapUsedBytes": 82176376,
      "domNodes": -280,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 162.522,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1728.4799999999905,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.701,
      "layouts": 6,
      "layoutDurationMs": 1.2069999999999999,
      "taskDurationMs": 421.188,
      "heapDeltaBytes": 17791432,
      "heapUsedBytes": 82318412,
      "domNodes": -177,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 12.786999999999999,
      "eventListeners": -145,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.9330000000882,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.608999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.05,
      "taskDurationMs": 383.29,
      "heapDeltaBytes": 4642060,
      "heapUsedBytes": 75691680,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.376000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 679.9730000000181,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.205000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.99700000000007,
      "heapDeltaBytes": -8234616,
      "heapUsedBytes": 62888840,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 163.121,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.672000000045,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.192,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.35200000000003,
      "heapDeltaBytes": 18360388,
      "heapUsedBytes": 88744860,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 166.03099999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2035.2789999999459,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9089999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.1159999999999,
      "heapDeltaBytes": 10933940,
      "heapUsedBytes": 87506160,
      "domNodes": -273,
      "jsHeapTotalBytes": -2727936,
      "scriptDurationMs": 35.82200000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2059.3959999999925,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.116999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 631.856,
      "heapDeltaBytes": 11036488,
      "heapUsedBytes": 87441260,
      "domNodes": -271,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 38.126000000000005,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2492.729000000054,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.433,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1787.1339999999998,
      "heapDeltaBytes": 2273004,
      "heapUsedBytes": 79089328,
      "domNodes": -282,
      "jsHeapTotalBytes": 905216,
      "scriptDurationMs": 859.849,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2328.547999999955,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.700999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1694.0839999999996,
      "heapDeltaBytes": 8011432,
      "heapUsedBytes": 85403236,
      "domNodes": -272,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 837.425,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3721.108999999956,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.129000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.735,
      "taskDurationMs": 1851.8179999999998,
      "heapDeltaBytes": -3241596,
      "heapUsedBytes": 75356464,
      "domNodes": -290,
      "jsHeapTotalBytes": 3563520,
      "scriptDurationMs": 808.413,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3785.9789999999975,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.902,
      "layouts": 60,
      "layoutDurationMs": 12.119000000000002,
      "taskDurationMs": 1838.178,
      "heapDeltaBytes": -2454528,
      "heapUsedBytes": 76545100,
      "domNodes": -282,
      "jsHeapTotalBytes": -2465792,
      "scriptDurationMs": 819.975,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3117.5230000000056,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.9750000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1962.764,
      "heapDeltaBytes": 22498868,
      "heapUsedBytes": 90081704,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 964.0330000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3214.807999999948,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 11.493,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2088.714,
      "heapDeltaBytes": 9309868,
      "heapUsedBytes": 89990960,
      "domNodes": -284,
      "jsHeapTotalBytes": 49152,
      "scriptDurationMs": 1014.9860000000002,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.0979999999663,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.2180000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 602.829,
      "heapDeltaBytes": 21735560,
      "heapUsedBytes": 88570376,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.452,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2027.2269999999253,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.855,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 659.031,
      "heapDeltaBytes": 9631348,
      "heapUsedBytes": 88014116,
      "domNodes": -273,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 36.274,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 650.2820000000611,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 15.156,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.45900000000006,
      "heapDeltaBytes": 15029280,
      "heapUsedBytes": 88378784,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 141.403,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 623.5520000000179,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.066999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.169,
      "heapDeltaBytes": 14582012,
      "heapUsedBytes": 87100844,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 149.02499999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.6099999999724,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.220999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 539.7729999999999,
      "heapDeltaBytes": 7309888,
      "heapUsedBytes": 80660772,
      "domNodes": -293,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.198000000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.3910000000178,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.159999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 537.698,
      "heapDeltaBytes": -8579856,
      "heapUsedBytes": 63986564,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 9.468,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1786.7519999999786,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 31.391000000000002,
      "layouts": 18,
      "layoutDurationMs": 5.745,
      "taskDurationMs": 918.6350000000001,
      "heapDeltaBytes": -5986352,
      "heapUsedBytes": 67312828,
      "domNodes": -298,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 126.804,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1768.7670000000253,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.483000000000004,
      "layouts": 18,
      "layoutDurationMs": 5.777,
      "taskDurationMs": 896.543,
      "heapDeltaBytes": -6791872,
      "heapUsedBytes": 66531028,
      "domNodes": -298,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 120.789,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.0240000000676,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 32.745000000000005,
      "layouts": 16,
      "layoutDurationMs": 16.017999999999997,
      "taskDurationMs": 965.8210000000003,
      "heapDeltaBytes": -5281916,
      "heapUsedBytes": 84677680,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 32.162,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9105.187999999998,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.136,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6243.937,
      "heapDeltaBytes": -6335376,
      "heapUsedBytes": 69652104,
      "domNodes": -279,
      "jsHeapTotalBytes": 4612096,
      "scriptDurationMs": 2853.1229999999996,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9194.113000000016,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.771,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6205.095,
      "heapDeltaBytes": -9682736,
      "heapUsedBytes": 94130440,
      "domNodes": -267,
      "jsHeapTotalBytes": -925696,
      "scriptDurationMs": 2841.299,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17719.47399999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16988.045,
      "heapDeltaBytes": -58154268,
      "heapUsedBytes": 178385760,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16953344,
      "scriptDurationMs": 362.104,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17508.078999999954,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16813.626,
      "heapDeltaBytes": -57566320,
      "heapUsedBytes": 179896072,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16678912,
      "scriptDurationMs": 280.28799999999995,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21420.18100000007,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 18.85500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21051.719,
      "heapDeltaBytes": -56017756,
      "heapUsedBytes": 182660164,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16678912,
      "scriptDurationMs": 1015.7470000000002,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 87,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21526.33000000003,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 19.86100000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21144.597,
      "heapDeltaBytes": -57027712,
      "heapUsedBytes": 168875632,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16932864,
      "scriptDurationMs": 944.972,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 110,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6323.820000000069,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.32000000000001,
      "layouts": 20,
      "layoutDurationMs": 23.771000000000015,
      "taskDurationMs": 6205.714,
      "heapDeltaBytes": -35390608,
      "heapUsedBytes": 176620268,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4280320,
      "scriptDurationMs": 123.71799999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 472,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6290.200000000027,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 93.74700000000003,
      "layouts": 20,
      "layoutDurationMs": 34.951999999999984,
      "taskDurationMs": 6170.706,
      "heapDeltaBytes": -42188784,
      "heapUsedBytes": 177230964,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10428416,
      "scriptDurationMs": 110.472,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 608,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8759.01900000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8508.461000000001,
      "heapDeltaBytes": 18665920,
      "heapUsedBytes": 182249820,
      "domNodes": 0,
      "jsHeapTotalBytes": -14942208,
      "scriptDurationMs": 143.68500000000006,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8632.810000000063,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8428.15,
      "heapDeltaBytes": 5905148,
      "heapUsedBytes": 177102388,
      "domNodes": 0,
      "jsHeapTotalBytes": -8388608,
      "scriptDurationMs": 149.08200000000005,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 126.72099999997499,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 15.288,
      "layouts": 2,
      "layoutDurationMs": 0.72,
      "taskDurationMs": 79.817,
      "heapDeltaBytes": 3015356,
      "heapUsedBytes": 72118104,
      "domNodes": 110,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.299,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 104.16599999996379,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.158000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.608,
      "taskDurationMs": 71.76199999999999,
      "heapDeltaBytes": 3003436,
      "heapUsedBytes": 72306136,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.060000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50385 75571 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

claude Bot and others added 3 commits September 23, 2026 10:28
…1575/PM-1576) (#18391)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054750260419?thread_ts=1790054750.260419&cid=C0BGH348Z0C)_

Fixes PM-1575/PM-1576: the agent's chat-side tool-call-completion
affordance ("done" spinner, "Worked for Xs" summary) settled well before
the resulting graph change actually rendered on canvas, with nothing in
the UI indicating the canvas hadn't caught up. This PR now contains both
the failing repro test (red) and the minimal client-side fix (green).

**Before (bug):** an agent tool call that touches the canvas (e.g.
adding a node) reports done — the tool's own row flips straight to its
settled icon — while the canvas itself still shows nothing for the new
content, for a stretch that (per the stagingcloud report) is close to 10
real seconds. `agentEventTransport.ts`'s `ingest()` flipped a tool
part's `state` to `'done'` purely from the chat-channel
`agent_tool_call` frame's own `status` field, with zero coupling to
whether the corresponding CRDT `doc_update` had actually reached and
been projected onto the canvas (`useAgentCrdtFollower.ts` /
`LayoutFollowerBridge`) — two structurally disjoint listeners, never
consulting each other.

**After (fixed):** `createAgentEventTransport` now takes an optional
`shouldAwaitCanvasSync` gate. While it returns `true`, a tool call that
reports done holds its part's displayed `state` at `'streaming'` (the
same spinner glyph it showed while running) instead of flipping straight
to `'done'`, until either `notifyCanvasCaughtUp()` is called or
`STALE_AFTER_MS` (30s) elapses — reusing the CRDT follower's own
passive-heartbeat bound (`agentCrdtDocLifecycle.ts`) rather than
inventing a new magic number. The gate defaults to always-`false`, so
any caller that never wires it up (including every pre-existing unit
test) keeps the old immediate-done behavior unchanged.

`agentConversationStore.ts` threads this gate through to every transport
it creates and exposes `setCanvasSyncGate` / `notifyCanvasCaughtUp` so a
host can register the gate and forward catch-up signals to the active
turn and any stashed background ones. `AgentPanelRoot.vue` wires the
gate to `agentPanelStore.enabled` (the same flag that gates the CRDT
follower itself) and calls `notifyCanvasCaughtUp()` whenever
`useAgentCrdtFollower`'s `outcomes.applied` counter increases for the
bound workflow — i.e. the moment a fresh doc update actually lands.

**Relationship to PM-1355 (`#18179`,
`agentCanvasBlanksDuringRunTurn.spec.ts`):** this mirrors that fix's
*shape* (a bounded catch-up-confirmation signal) rather than reusing its
primitive directly. PM-1355's
`AgentCrdtDocLifecycle`/`SUBSCRIBE_CATCHUP_GRACE_MS` answers "is THIS
subscribe's own catch-up frame overdue" — a question scoped to one
resubscribe. This bug needed a different question answered: "has some
later doc update landed since this tool call reported done", which lives
one level up, at the chat-transport/composable boundary rather than
inside the subscribe lifecycle. Both do reuse the same `STALE_AFTER_MS`
bound as their fallback timeout, per the design guidance, rather than
adding a second magic number.

**Out of scope:** the actual backend ~10s doc-broadcast propagation
delay itself is not addressed here — this fix only makes the client
accurately reflect canvas state instead of eliminating the underlying
lag. Root-causing that lag is still open (see the file-header RCA in the
spec).

-
`browser_tests/tests/agent/agentCanvasLagsToolCallCompletion.spec.ts`'s
first test (previously `test.fail()`) now asserts the fix directly:
after the `add_node` tool call reports `success`, its row (expanded from
the "Worked for Xs" summary) stays on the spinner glyph — not the
settled one — while the canvas still has zero nodes; once the delayed
`doc_update` lands, the row flips to done in the same moment the node
appears.
- The second test (node eventually lands once the delayed `doc_update`
arrives) is unchanged and still passes.
- `eslint`, `vue-tsc --noEmit`, and `playwright test --list` (both tests
listed and named correctly) all pass. Every existing agent-suite unit
test (125 files, ~1956 tests) still passes unchanged, since the new gate
defaults to off unless a caller opts in.
- Could not run a real browser in this sandbox (Playwright's
Chromium/headless-shell download is CDN-blocked here, same known
limitation as before).

N/A — this is a Playwright spec + client-side logic change; no visual/UI
screenshot to attach.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01VR48ZgDstU3S7MKeC1q3bH

---
_Generated by [Claude
Code](https://claude.ai/code/session_01VR48ZgDstU3S7MKeC1q3bH)_

---------
The cherry-picked PM-1575 fix imports STALE_AFTER_MS from
agentCrdtDocLifecycle.ts, a module split out of useAgentCrdtFollower.ts
by PM-1355 (#18179) on main. That split has not been backported to
cloud/1.54, where STALE_AFTER_MS is still exported directly from
useAgentCrdtFollower.ts, so point both the fix and its test at the
constant's current location on this branch.
Two more references in the cherry-picked spec point at main-only
locations: UserDataFullInfo now lives at @/schemas/apiSchema on this
branch (not @/platform/remote/comfyui/types), the open-agent button's
i18n key is agent.askComfyAgent (not agent.entryButton), and HostDoc
here only exposes projection() (WorkflowJSON), not graph()
(GraphSnapshot via readGraph) -- checking node presence through the
projection's node list instead.
@claude
claude Bot force-pushed the backport-18391-to-cloud-1.54 branch from 9c7579c to fbe2b45 Compare September 23, 2026 10:29
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.64804% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 60.00% 4 Missing ⚠️
...sions/agent/stores/agent/agentConversationStore.ts 96.55% 2 Missing ⚠️
@@                            Coverage Diff                            @@
##           backport-be11470-fixtures-to-cloud-1.54   #18593    +/-   ##
=========================================================================
  Coverage                                    83.66%   83.67%            
=========================================================================
  Files                                         2105     2105            
  Lines                                       124599   124712   +113     
  Branches                                     31587    31602    +15     
=========================================================================
+ Hits                                        104249   104355   +106     
- Misses                                       20171    20178     +7     
  Partials                                       179      179            
Flag Coverage Δ
e2e 66.68% <ø> (-0.01%) ⬇️
unit 78.71% <96.64%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 97.65% <100.00%> (+<0.01%) ⬆️
...nsions/agent/services/agent/agentEventTransport.ts 100.00% <100.00%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 97.36% <96.55%> (-0.47%) ⬇️
src/workbench/extensions/agent/AgentPanelRoot.vue 91.54% <60.00%> (-0.57%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The cherry-picked test asserted on a "Working..." composing-status
label (AgentMessage.vue's composing/status computed) that does not
exist on this branch yet -- cloud/1.54's AgentMessage.vue uses a
different grouping/rendering scheme without that affordance. Assert
on the conversation store's own tool-part state instead, which is
exactly what the regression comment says the gate wiring is protecting.
The cherry-picked spec looked for a button matching /^Worked/ -- main's
AgentMessage.vue WorkSummary label. cloud/1.54 has ToolCallGroup
instead, whose CollapsibleTrigger accessible name is always
"Ran N tool call(s)[ for Xs]" regardless of running/done state (only
the leading icon changes, via toolGlyph's loader-circle for
'streaming') -- confirmed against ToolCallGroup.vue/agentToolGlyph.ts,
and matching the same adaptation #18582 already made for a different
persisted-tool-summary spec on this branch. Row-level assertions
(loader-circle class, "Add node" label) already matched this branch's
DOM and needed no change.
ToolCallGroup.vue auto-expands (open ref forced true by its own watch)
while any of its tool parts is 'streaming', which is exactly this
test's row state -- the whole point of "stays visibly syncing". The
spec's leftover .click() (written against main's default-collapsed
WorkSummary) was toggling an already-open trigger closed instead of
opening it, so the following aria-expanded assertion failed. Drop the
click for this one test; the other test in this file whose row settles
to 'done' quickly (and so is closed by the same watch) still needs and
keeps its own click.
@claude

claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

playwright-tests (cloud) / e2e-status are red only because of agentToolCallHistoryPersistence.spec.ts ("keeps a completed turn work summary after a browser refresh"), which is not this PR's failure:

All of #18391's own e2e coverage (agentCanvasLagsToolCallCompletion.spec.ts) passes on this branch. Worth filing a separate ticket to fix agentToolCallHistoryPersistence.spec.ts's label the same way #18582 did — out of scope here.

@christian-byrne
christian-byrne merged commit 5a50c5d into backport-be11470-fixtures-to-cloud-1.54 Sep 23, 2026
89 of 91 checks passed
@christian-byrne
christian-byrne deleted the backport-18391-to-cloud-1.54 branch September 23, 2026 17:41
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants