Repository navigation
[backport cloud/1.54] fix: agent tool-call chat completion lags canvas materialization (PM-1575/PM-1576) - #18593
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1945 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T11:49:08.999Z",
"gitSha": "f65fdb4b22030f7688716116e65c6e1f2244c3ae",
"branch": "backport-18391-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2047.8060000000369,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.0470000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.031,
"heapDeltaBytes": 1762572,
"heapUsedBytes": 72120680,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.119000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2054.3109999999842,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.9300000000001,
"heapDeltaBytes": 9969100,
"heapUsedBytes": 80073016,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.090000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.3570000000682,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.275,
"layouts": 14,
"layoutDurationMs": 4.304,
"taskDurationMs": 906.9000000000001,
"heapDeltaBytes": -12068120,
"heapUsedBytes": 58732928,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 167.128,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.7909999999538,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.875000000000004,
"layouts": 14,
"layoutDurationMs": 4.364,
"taskDurationMs": 911.0939999999998,
"heapDeltaBytes": 11019376,
"heapUsedBytes": 82176376,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 162.522,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.4799999999905,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.701,
"layouts": 6,
"layoutDurationMs": 1.2069999999999999,
"taskDurationMs": 421.188,
"heapDeltaBytes": 17791432,
"heapUsedBytes": 82318412,
"domNodes": -177,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 12.786999999999999,
"eventListeners": -145,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.9330000000882,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.608999999999998,
"layouts": 6,
"layoutDurationMs": 1.05,
"taskDurationMs": 383.29,
"heapDeltaBytes": 4642060,
"heapUsedBytes": 75691680,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.376000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 679.9730000000181,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.205000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.99700000000007,
"heapDeltaBytes": -8234616,
"heapUsedBytes": 62888840,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 163.121,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 710.672000000045,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.192,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.35200000000003,
"heapDeltaBytes": 18360388,
"heapUsedBytes": 88744860,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 166.03099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.2789999999459,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9089999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.1159999999999,
"heapDeltaBytes": 10933940,
"heapUsedBytes": 87506160,
"domNodes": -273,
"jsHeapTotalBytes": -2727936,
"scriptDurationMs": 35.82200000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2059.3959999999925,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.116999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.856,
"heapDeltaBytes": 11036488,
"heapUsedBytes": 87441260,
"domNodes": -271,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 38.126000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2492.729000000054,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.433,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1787.1339999999998,
"heapDeltaBytes": 2273004,
"heapUsedBytes": 79089328,
"domNodes": -282,
"jsHeapTotalBytes": 905216,
"scriptDurationMs": 859.849,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2328.547999999955,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.700999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1694.0839999999996,
"heapDeltaBytes": 8011432,
"heapUsedBytes": 85403236,
"domNodes": -272,
"jsHeapTotalBytes": 380928,
"scriptDurationMs": 837.425,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3721.108999999956,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.129000000000001,
"layouts": 60,
"layoutDurationMs": 12.735,
"taskDurationMs": 1851.8179999999998,
"heapDeltaBytes": -3241596,
"heapUsedBytes": 75356464,
"domNodes": -290,
"jsHeapTotalBytes": 3563520,
"scriptDurationMs": 808.413,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3785.9789999999975,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.902,
"layouts": 60,
"layoutDurationMs": 12.119000000000002,
"taskDurationMs": 1838.178,
"heapDeltaBytes": -2454528,
"heapUsedBytes": 76545100,
"domNodes": -282,
"jsHeapTotalBytes": -2465792,
"scriptDurationMs": 819.975,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3117.5230000000056,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.9750000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1962.764,
"heapDeltaBytes": 22498868,
"heapUsedBytes": 90081704,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 964.0330000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3214.807999999948,
"styleRecalcs": 43,
"styleRecalcDurationMs": 11.493,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2088.714,
"heapDeltaBytes": 9309868,
"heapUsedBytes": 89990960,
"domNodes": -284,
"jsHeapTotalBytes": 49152,
"scriptDurationMs": 1014.9860000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.0979999999663,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.2180000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.829,
"heapDeltaBytes": 21735560,
"heapUsedBytes": 88570376,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.452,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.2269999999253,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.855,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.031,
"heapDeltaBytes": 9631348,
"heapUsedBytes": 88014116,
"domNodes": -273,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 36.274,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 650.2820000000611,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.156,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.45900000000006,
"heapDeltaBytes": 15029280,
"heapUsedBytes": 88378784,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.403,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.5520000000179,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.066999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.169,
"heapDeltaBytes": 14582012,
"heapUsedBytes": 87100844,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.02499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2037.6099999999724,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.220999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.7729999999999,
"heapDeltaBytes": 7309888,
"heapUsedBytes": 80660772,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.198000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.3910000000178,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.159999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.698,
"heapDeltaBytes": -8579856,
"heapUsedBytes": 63986564,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 9.468,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1786.7519999999786,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.391000000000002,
"layouts": 18,
"layoutDurationMs": 5.745,
"taskDurationMs": 918.6350000000001,
"heapDeltaBytes": -5986352,
"heapUsedBytes": 67312828,
"domNodes": -298,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 126.804,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1768.7670000000253,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.483000000000004,
"layouts": 18,
"layoutDurationMs": 5.777,
"taskDurationMs": 896.543,
"heapDeltaBytes": -6791872,
"heapUsedBytes": 66531028,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 120.789,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0240000000676,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.745000000000005,
"layouts": 16,
"layoutDurationMs": 16.017999999999997,
"taskDurationMs": 965.8210000000003,
"heapDeltaBytes": -5281916,
"heapUsedBytes": 84677680,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 32.162,
"eventListeners": 2385,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9105.187999999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6243.937,
"heapDeltaBytes": -6335376,
"heapUsedBytes": 69652104,
"domNodes": -279,
"jsHeapTotalBytes": 4612096,
"scriptDurationMs": 2853.1229999999996,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9194.113000000016,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.771,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6205.095,
"heapDeltaBytes": -9682736,
"heapUsedBytes": 94130440,
"domNodes": -267,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2841.299,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17719.47399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16988.045,
"heapDeltaBytes": -58154268,
"heapUsedBytes": 178385760,
"domNodes": -8068,
"jsHeapTotalBytes": -16953344,
"scriptDurationMs": 362.104,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17508.078999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16813.626,
"heapDeltaBytes": -57566320,
"heapUsedBytes": 179896072,
"domNodes": -8068,
"jsHeapTotalBytes": -16678912,
"scriptDurationMs": 280.28799999999995,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21420.18100000007,
"styleRecalcs": 165,
"styleRecalcDurationMs": 18.85500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21051.719,
"heapDeltaBytes": -56017756,
"heapUsedBytes": 182660164,
"domNodes": -8068,
"jsHeapTotalBytes": -16678912,
"scriptDurationMs": 1015.7470000000002,
"eventListeners": -14925,
"totalBlockingTimeMs": 87,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21526.33000000003,
"styleRecalcs": 176,
"styleRecalcDurationMs": 19.86100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21144.597,
"heapDeltaBytes": -57027712,
"heapUsedBytes": 168875632,
"domNodes": -8068,
"jsHeapTotalBytes": -16932864,
"scriptDurationMs": 944.972,
"eventListeners": -14925,
"totalBlockingTimeMs": 110,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6323.820000000069,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.32000000000001,
"layouts": 20,
"layoutDurationMs": 23.771000000000015,
"taskDurationMs": 6205.714,
"heapDeltaBytes": -35390608,
"heapUsedBytes": 176620268,
"domNodes": -8068,
"jsHeapTotalBytes": 4280320,
"scriptDurationMs": 123.71799999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 472,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6290.200000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 93.74700000000003,
"layouts": 20,
"layoutDurationMs": 34.951999999999984,
"taskDurationMs": 6170.706,
"heapDeltaBytes": -42188784,
"heapUsedBytes": 177230964,
"domNodes": -8068,
"jsHeapTotalBytes": 10428416,
"scriptDurationMs": 110.472,
"eventListeners": -14927,
"totalBlockingTimeMs": 608,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8759.01900000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8508.461000000001,
"heapDeltaBytes": 18665920,
"heapUsedBytes": 182249820,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 143.68500000000006,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8632.810000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8428.15,
"heapDeltaBytes": 5905148,
"heapUsedBytes": 177102388,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 149.08200000000005,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 126.72099999997499,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.288,
"layouts": 2,
"layoutDurationMs": 0.72,
"taskDurationMs": 79.817,
"heapDeltaBytes": 3015356,
"heapUsedBytes": 72118104,
"domNodes": 110,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.299,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 104.16599999996379,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.158000000000001,
"layouts": 2,
"layoutDurationMs": 0.608,
"taskDurationMs": 71.76199999999999,
"heapDeltaBytes": 3003436,
"heapUsedBytes": 72306136,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.060000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
…1575/PM-1576) (#18391) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054750260419?thread_ts=1790054750.260419&cid=C0BGH348Z0C)_ Fixes PM-1575/PM-1576: the agent's chat-side tool-call-completion affordance ("done" spinner, "Worked for Xs" summary) settled well before the resulting graph change actually rendered on canvas, with nothing in the UI indicating the canvas hadn't caught up. This PR now contains both the failing repro test (red) and the minimal client-side fix (green). **Before (bug):** an agent tool call that touches the canvas (e.g. adding a node) reports done — the tool's own row flips straight to its settled icon — while the canvas itself still shows nothing for the new content, for a stretch that (per the stagingcloud report) is close to 10 real seconds. `agentEventTransport.ts`'s `ingest()` flipped a tool part's `state` to `'done'` purely from the chat-channel `agent_tool_call` frame's own `status` field, with zero coupling to whether the corresponding CRDT `doc_update` had actually reached and been projected onto the canvas (`useAgentCrdtFollower.ts` / `LayoutFollowerBridge`) — two structurally disjoint listeners, never consulting each other. **After (fixed):** `createAgentEventTransport` now takes an optional `shouldAwaitCanvasSync` gate. While it returns `true`, a tool call that reports done holds its part's displayed `state` at `'streaming'` (the same spinner glyph it showed while running) instead of flipping straight to `'done'`, until either `notifyCanvasCaughtUp()` is called or `STALE_AFTER_MS` (30s) elapses — reusing the CRDT follower's own passive-heartbeat bound (`agentCrdtDocLifecycle.ts`) rather than inventing a new magic number. The gate defaults to always-`false`, so any caller that never wires it up (including every pre-existing unit test) keeps the old immediate-done behavior unchanged. `agentConversationStore.ts` threads this gate through to every transport it creates and exposes `setCanvasSyncGate` / `notifyCanvasCaughtUp` so a host can register the gate and forward catch-up signals to the active turn and any stashed background ones. `AgentPanelRoot.vue` wires the gate to `agentPanelStore.enabled` (the same flag that gates the CRDT follower itself) and calls `notifyCanvasCaughtUp()` whenever `useAgentCrdtFollower`'s `outcomes.applied` counter increases for the bound workflow — i.e. the moment a fresh doc update actually lands. **Relationship to PM-1355 (`#18179`, `agentCanvasBlanksDuringRunTurn.spec.ts`):** this mirrors that fix's *shape* (a bounded catch-up-confirmation signal) rather than reusing its primitive directly. PM-1355's `AgentCrdtDocLifecycle`/`SUBSCRIBE_CATCHUP_GRACE_MS` answers "is THIS subscribe's own catch-up frame overdue" — a question scoped to one resubscribe. This bug needed a different question answered: "has some later doc update landed since this tool call reported done", which lives one level up, at the chat-transport/composable boundary rather than inside the subscribe lifecycle. Both do reuse the same `STALE_AFTER_MS` bound as their fallback timeout, per the design guidance, rather than adding a second magic number. **Out of scope:** the actual backend ~10s doc-broadcast propagation delay itself is not addressed here — this fix only makes the client accurately reflect canvas state instead of eliminating the underlying lag. Root-causing that lag is still open (see the file-header RCA in the spec). - `browser_tests/tests/agent/agentCanvasLagsToolCallCompletion.spec.ts`'s first test (previously `test.fail()`) now asserts the fix directly: after the `add_node` tool call reports `success`, its row (expanded from the "Worked for Xs" summary) stays on the spinner glyph — not the settled one — while the canvas still has zero nodes; once the delayed `doc_update` lands, the row flips to done in the same moment the node appears. - The second test (node eventually lands once the delayed `doc_update` arrives) is unchanged and still passes. - `eslint`, `vue-tsc --noEmit`, and `playwright test --list` (both tests listed and named correctly) all pass. Every existing agent-suite unit test (125 files, ~1956 tests) still passes unchanged, since the new gate defaults to off unless a caller opts in. - Could not run a real browser in this sandbox (Playwright's Chromium/headless-shell download is CDN-blocked here, same known limitation as before). N/A — this is a Playwright spec + client-side logic change; no visual/UI screenshot to attach. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01VR48ZgDstU3S7MKeC1q3bH --- _Generated by [Claude Code](https://claude.ai/code/session_01VR48ZgDstU3S7MKeC1q3bH)_ ---------
The cherry-picked PM-1575 fix imports STALE_AFTER_MS from agentCrdtDocLifecycle.ts, a module split out of useAgentCrdtFollower.ts by PM-1355 (#18179) on main. That split has not been backported to cloud/1.54, where STALE_AFTER_MS is still exported directly from useAgentCrdtFollower.ts, so point both the fix and its test at the constant's current location on this branch.
Two more references in the cherry-picked spec point at main-only locations: UserDataFullInfo now lives at @/schemas/apiSchema on this branch (not @/platform/remote/comfyui/types), the open-agent button's i18n key is agent.askComfyAgent (not agent.entryButton), and HostDoc here only exposes projection() (WorkflowJSON), not graph() (GraphSnapshot via readGraph) -- checking node presence through the projection's node list instead.
9c7579c to
fbe2b45
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## backport-be11470-fixtures-to-cloud-1.54 #18593 +/- ##
=========================================================================
Coverage 83.66% 83.67%
=========================================================================
Files 2105 2105
Lines 124599 124712 +113
Branches 31587 31602 +15
=========================================================================
+ Hits 104249 104355 +106
- Misses 20171 20178 +7
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The cherry-picked test asserted on a "Working..." composing-status label (AgentMessage.vue's composing/status computed) that does not exist on this branch yet -- cloud/1.54's AgentMessage.vue uses a different grouping/rendering scheme without that affordance. Assert on the conversation store's own tool-part state instead, which is exactly what the regression comment says the gate wiring is protecting.
The cherry-picked spec looked for a button matching /^Worked/ -- main's AgentMessage.vue WorkSummary label. cloud/1.54 has ToolCallGroup instead, whose CollapsibleTrigger accessible name is always "Ran N tool call(s)[ for Xs]" regardless of running/done state (only the leading icon changes, via toolGlyph's loader-circle for 'streaming') -- confirmed against ToolCallGroup.vue/agentToolGlyph.ts, and matching the same adaptation #18582 already made for a different persisted-tool-summary spec on this branch. Row-level assertions (loader-circle class, "Add node" label) already matched this branch's DOM and needed no change.
ToolCallGroup.vue auto-expands (open ref forced true by its own watch) while any of its tool parts is 'streaming', which is exactly this test's row state -- the whole point of "stays visibly syncing". The spec's leftover .click() (written against main's default-collapsed WorkSummary) was toggling an already-open trigger closed instead of opening it, so the following aria-expanded assertion failed. Drop the click for this one test; the other test in this file whose row settles to 'done' quickly (and so is closed by the same watch) still needs and keeps its own click.
|
All of #18391's own e2e coverage ( |
5a50c5d
into
backport-be11470-fixtures-to-cloud-1.54
Requested by Christian Byrne · Slack thread
Before
An agent tool call that touches the canvas (e.g. adding a node) reports done — the tool's own row flips straight to its settled icon — while the canvas itself still shows nothing for the new content, for a stretch that can run close to 10 real seconds.
agentEventTransport.ts'singest()flipped a tool part'sstateto'done'purely from the chat-channelagent_tool_callframe's ownstatusfield, with zero coupling to whether the corresponding CRDTdoc_updatehad actually reached and been projected onto the canvas.After
createAgentEventTransportnow takes an optionalshouldAwaitCanvasSyncgate. While it returnstrue, a tool call that reports done holds its part's displayedstateat'streaming'instead of flipping straight to'done', until eithernotifyCanvasCaughtUp()is called orSTALE_AFTER_MS(30s) elapses.agentConversationStore.tsthreads this gate through every transport it creates and exposessetCanvasSyncGate/notifyCanvasCaughtUp;AgentPanelRoot.vuewires the gate toagentPanelStore.enabledand callsnotifyCanvasCaughtUp()whenever the CRDT follower'soutcomes.appliedLivecounter increases for the bound workflow. The gate defaults to always-false, so any caller that never wires it up keeps the old immediate-done behavior unchanged.How
Cherry-picked #18391's merge commit onto
cloud/1.54(stacked on #18586, which backports the JSON fixture corpus this PR's new regression test reads off disk).cloud/1.54has diverged architecturally frommainin this area since PM-1355/#18179:useAgentCrdtFollower.tsinlines outcome tracking in itsonUpdatehandler instead of theincrementOutcome/applyAndReconcilehelpers #18391 was written against, so the two real conflicts there were resolved by porting #18391's actual upstream diff (theappliedLive/!update.catchUpclassification) intocloud/1.54's current handler rather than reintroducing stale helper functions. Three follow-up fixes for other main-only references that only surfaced once the build/tests ran (not as git conflicts):STALE_AFTER_MSnow imports fromuseAgentCrdtFollower.ts(its current home on this branch, not theagentCrdtDocLifecycle.tssplit that hasn't landed here), and the new e2e spec'sUserDataFullInfoimport, open-agent button i18n key, andHostDocnode-presence check were pointed at their current cloud/1.54 equivalents.pnpm lint,pnpm typecheck,pnpm typecheck:browser, and the full targeted unit suite (agentEventTransport.test.ts,agentConversationStore.test.ts,useAgentCrdtFollower.test.ts— 155/155) all pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01NQDb2pk4BuLEgzkga3GhEs
Generated by Claude Code