Repository navigation
[backport core/1.54] chore: backport BE-11470 conversation-replay fixtures - #18585
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1946 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T10:33:10.877Z",
"gitSha": "00ab85c400ac203b36ff83adf7afec27d729aa57",
"branch": "backport-be11470-fixtures-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.8700000000308,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.611999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.864,
"heapDeltaBytes": 5810716,
"heapUsedBytes": 76072152,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.813999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2019.2160000000285,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.69,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.777,
"heapDeltaBytes": 9924500,
"heapUsedBytes": 80503964,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.046999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.124999999981,
"styleRecalcs": 75,
"styleRecalcDurationMs": 24.569,
"layouts": 14,
"layoutDurationMs": 4.0569999999999995,
"taskDurationMs": 797.267,
"heapDeltaBytes": 453984,
"heapUsedBytes": 70773668,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 133.011,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.0520000000124,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.073999999999998,
"layouts": 14,
"layoutDurationMs": 4.649,
"taskDurationMs": 858.587,
"heapDeltaBytes": 2932340,
"heapUsedBytes": 73225412,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 146.051,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.862000000007,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.117,
"layouts": 6,
"layoutDurationMs": 1.5000000000000002,
"taskDurationMs": 363.227,
"heapDeltaBytes": 4638272,
"heapUsedBytes": 75584180,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.233,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1743.3409999999867,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.907,
"layouts": 6,
"layoutDurationMs": 1.3800000000000001,
"taskDurationMs": 404.76499999999993,
"heapDeltaBytes": 4319772,
"heapUsedBytes": 74616532,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.761,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 788.5829999999601,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.505999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.01399999999995,
"heapDeltaBytes": -7947456,
"heapUsedBytes": 63308212,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 168.517,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 647.8020000000697,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.855,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.02099999999996,
"heapDeltaBytes": -7889604,
"heapUsedBytes": 63220740,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 142.824,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2052.024999999958,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.258999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.1320000000001,
"heapDeltaBytes": 5089892,
"heapUsedBytes": 81414756,
"domNodes": -274,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 34.223,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2044.3169999999782,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.401999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.598,
"heapDeltaBytes": 10413336,
"heapUsedBytes": 86969432,
"domNodes": -275,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 40.988000000000014,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2554.916999999989,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.035999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1677.158,
"heapDeltaBytes": 15679680,
"heapUsedBytes": 92828964,
"domNodes": -275,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 786.808,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2464.099000000033,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.284000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1601.963,
"heapDeltaBytes": 22717756,
"heapUsedBytes": 88842644,
"domNodes": -276,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 761.791,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3686.16899999995,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.986,
"layouts": 60,
"layoutDurationMs": 14.293999999999999,
"taskDurationMs": 1700.689,
"heapDeltaBytes": 8055908,
"heapUsedBytes": 76314104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 721.175,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3731.3369999999395,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.859000000000002,
"layouts": 60,
"layoutDurationMs": 15.043000000000001,
"taskDurationMs": 1774.6229999999998,
"heapDeltaBytes": 8179612,
"heapUsedBytes": 76097348,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 761.4649999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3094.9489999999855,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.680000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1887.1799999999998,
"heapDeltaBytes": 23684840,
"heapUsedBytes": 93184016,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 880.992,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3380.2369999999655,
"styleRecalcs": 42,
"styleRecalcDurationMs": 9.234000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2220.9919999999997,
"heapDeltaBytes": 7079564,
"heapUsedBytes": 87321188,
"domNodes": -289,
"jsHeapTotalBytes": -737280,
"scriptDurationMs": 1009.506,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2049.8549999999796,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7540000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.963,
"heapDeltaBytes": 9321736,
"heapUsedBytes": 87649024,
"domNodes": -270,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 34.249999999999986,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2025.184999999965,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.880000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.246,
"heapDeltaBytes": 22147728,
"heapUsedBytes": 87929468,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.139,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.327999999985,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.557,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.895,
"heapDeltaBytes": 15063956,
"heapUsedBytes": 87818620,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 128.196,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.8429999999662,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.176,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.591,
"heapDeltaBytes": 15036768,
"heapUsedBytes": 88162928,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 132.172,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.5719999999915,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.60900000000004,
"heapDeltaBytes": -12847656,
"heapUsedBytes": 60255676,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.043,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.9329999999954,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.573000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.509,
"heapDeltaBytes": 9408580,
"heapUsedBytes": 82537376,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.036000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.4430000000357,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.555,
"layouts": 18,
"layoutDurationMs": 4.525,
"taskDurationMs": 795.441,
"heapDeltaBytes": -8844024,
"heapUsedBytes": 63579696,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 95.19500000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1768.322000000012,
"styleRecalcs": 79,
"styleRecalcDurationMs": 30.18,
"layouts": 18,
"layoutDurationMs": 5.757,
"taskDurationMs": 941.9119999999998,
"heapDeltaBytes": -2480940,
"heapUsedBytes": 69899716,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.73100000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1415.9530000000586,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.32,
"layouts": 14,
"layoutDurationMs": 14.016,
"taskDurationMs": 930.6560000000002,
"heapDeltaBytes": 21097704,
"heapUsedBytes": 110178636,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 33.409,
"eventListeners": 2387,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9072.999000000038,
"styleRecalcs": 247,
"styleRecalcDurationMs": 45.989000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5891.811000000001,
"heapDeltaBytes": -13794408,
"heapUsedBytes": 90041112,
"domNodes": -267,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 2599.957,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9733.523999999989,
"styleRecalcs": 246,
"styleRecalcDurationMs": 45.278999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6209.331999999999,
"heapDeltaBytes": 17560324,
"heapUsedBytes": 93347416,
"domNodes": -270,
"jsHeapTotalBytes": -700416,
"scriptDurationMs": 2679.892,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15232.85599999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14638.098,
"heapDeltaBytes": -34827364,
"heapUsedBytes": 182857888,
"domNodes": -8068,
"jsHeapTotalBytes": -2895872,
"scriptDurationMs": 260.288,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15599.661999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15105.855000000001,
"heapDeltaBytes": -58945108,
"heapUsedBytes": 179028416,
"domNodes": -8068,
"jsHeapTotalBytes": -17727488,
"scriptDurationMs": 277.705,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18212.553999999953,
"styleRecalcs": 140,
"styleRecalcDurationMs": 20.660999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17943.491,
"heapDeltaBytes": -52144540,
"heapUsedBytes": 179694388,
"domNodes": -8068,
"jsHeapTotalBytes": -19050496,
"scriptDurationMs": 985.161,
"eventListeners": -14933,
"totalBlockingTimeMs": 105,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18701.340000000073,
"styleRecalcs": 140,
"styleRecalcDurationMs": 22.40700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18372.440000000002,
"heapDeltaBytes": -66064464,
"heapUsedBytes": 164943828,
"domNodes": -8068,
"jsHeapTotalBytes": -19574784,
"scriptDurationMs": 891.022,
"eventListeners": -14931,
"totalBlockingTimeMs": 31,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5497.347999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.68399999999997,
"layouts": 20,
"layoutDurationMs": 25.187,
"taskDurationMs": 5404.773999999999,
"heapDeltaBytes": -46468344,
"heapUsedBytes": 187430492,
"domNodes": -8068,
"jsHeapTotalBytes": 7950336,
"scriptDurationMs": 113.48400000000001,
"eventListeners": -14935,
"totalBlockingTimeMs": 203,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5569.0949999999475,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.61899999999999,
"layouts": 20,
"layoutDurationMs": 28.070999999999998,
"taskDurationMs": 5492.388999999999,
"heapDeltaBytes": -60984008,
"heapUsedBytes": 174920444,
"domNodes": -8068,
"jsHeapTotalBytes": 10387456,
"scriptDurationMs": 110.284,
"eventListeners": -14929,
"totalBlockingTimeMs": 366,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7681.120000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7474.722,
"heapDeltaBytes": 1811088,
"heapUsedBytes": 177228732,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 132.42100000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7693.898999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7397.694999999999,
"heapDeltaBytes": -13483028,
"heapUsedBytes": 177351108,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 129.83300000000008,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 490.2439999999615,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.565000000000005,
"layouts": 3,
"layoutDurationMs": 1.709,
"taskDurationMs": 116.133,
"heapDeltaBytes": 4990088,
"heapUsedBytes": 73644956,
"domNodes": 143,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.78499999996438,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.467000000000002,
"layouts": 2,
"layoutDurationMs": 1.0959999999999996,
"taskDurationMs": 71.735,
"heapDeltaBytes": 2991828,
"heapUsedBytes": 72177088,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.674999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Backport of the fixture corpus from #16764 and #17416 to core/1.54: 14 recorded agent-conversation JSON fixtures plus the derived empty- workflow seed, under browser_tests/fixtures/data/agent/. Data-only backport (no code): the loader (agentConversation.ts), the Playwright replay harness, and the production repaint fix bundled into #16764 are intentionally left out — none of it is needed for what requires this corpus on core/1.54 right now (the CANVAS_MUTATING_TOOLS pinning test added by PR #18391's backport), and the harness/mock-helper changes carry real conflict risk against core/1.54's independently- drifted test infra. This can be extended with the loader/harness in a follow-up if core/1.54 ever needs the full E2E replay spec. Verified byte-identical to origin/main's copies of the same files. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_
1aebd3b to
5601ae5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18585 +/- ##
============================================
Coverage 83.64% 83.64%
============================================
Files 2098 2098
Lines 123971 123971
Branches 31584 33434 +1850
============================================
+ Hits 103692 103695 +3
+ Misses 20100 20097 -3
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…1575/PM-1576) (#18391) Backport of #18391 to core/1.54. Cherry-picked the squash-merge commit fce6d77 onto a new branch from origin/core/1.54. The automated backport failed with conflicts in src/scripts/api.logs.test.ts, src/workbench/extensions/agent/AgentPanelRoot.vue, src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts, src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts, and src/workbench/extensions/agent/stores/agent/agentConversationStore.ts. Conflict resolution: - src/scripts/api.logs.test.ts: modify/delete. The file doesn't exist on core/1.54 because its introducing PR (#17773) was never backported here. Dropped rather than smuggling in unrelated test scaffolding. - useAgentCrdtFollower.ts: core/1.54 has an older, pre-refactor version of this file. The fix's `appliedLive` outcome counter needs to distinguish a live doc update from a subscribe's one-time catch-up frame; core/1.54's LayoutFollowerBridge already computed that distinction internally but never exposed it. Added a small, additive `ClassifiedDocUpdate` type to layoutFollowerBridge.ts (not one of the reported conflicts, but a necessary minimal dependency, mirroring main's own pre-existing mechanism) to expose the flag on the already-dispatched `doc_update` event, then wired `appliedLive` counting off it. - AgentPanelRoot.vue: kept the PR's teardown fix (reset canvasSyncGate on unmount); dropped `agentMinimapLayer.dispose()`, an unrelated feature not present on core/1.54. - agentConversationStore.ts / .test.ts: diff-alignment conflicts from upstream reordering; merged both sides' real content, kept core/1.54's Pinia test setup. - agentEventTransport.ts / .test.ts (auto-merged, not a reported conflict): imported STALE_AFTER_MS from agentCrdtDocLifecycle.ts, a module that doesn't exist on core/1.54 (a later extraction refactor not yet backported). Repointed both to useAgentCrdtFollower.ts, which still exports that same constant on this branch's older file layout. - browser_tests/tests/agent/agentCanvasLagsToolCallCompletion.spec.ts (new file, auto-merged): referenced @/platform/remote/comfyui/types (moved from @/schemas/apiSchema on main, not yet backported) and agent.entryButton (renamed from agent.askComfyAgent on main). Repointed to core/1.54's current locations/copy. Also called HostDoc.graph(), a method main's harness has that core/1.54's didn't; added it to agentConversationHostDoc.ts mirroring main exactly (readGraph from the already-installed @comfyorg/comfy-multi-player package). Its assertions also expected `WorkSummary.vue`'s "Worked for Xs" collapsing summary button, a UI feature from #17339 never backported to core/1.54. core/1.54's own equivalent is `ToolCallGroup.vue`, using the same reka-ui Collapsible primitive but a different trigger label ("Ran N tool call(s) [for Xs]" via agent.ranToolCalls/ranToolCallsTimed, not agent.worked). Retargeted the three `/^Worked/` button-name matchers to `/^Ran/` to match; the underlying mechanics under test (the tool row's own spinner/done glyph, role="listitem" rows, aria-expanded on the trigger) are identical between the two components. The CANVAS_MUTATING_TOOLS pinning unit test (agentEventTransport.test.ts) depends on the BE-11470 conversation-replay fixture corpus, backported separately in #18585 (which this branch is based on). Verification: pnpm typecheck, pnpm typecheck:browser, pnpm eslint, pnpm exec oxfmt all clean. Targeted pnpm vitest run across useAgentCrdtFollower, followerSubscription, AgentPanelRoot, agentConversationStore, agentEventTransport, CrdtDevPanel, crdtDebugReport: all green except 3 pre-existing Media-card upload failures (confirmed identical on unmodified origin/core/1.54, matching a prior backport's own documented note). <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_
…1575/PM-1576) (#18391) Backport of #18391 to core/1.54. Cherry-picked the squash-merge commit fce6d77 onto a new branch from origin/core/1.54. The automated backport failed with conflicts in src/scripts/api.logs.test.ts, src/workbench/extensions/agent/AgentPanelRoot.vue, src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts, src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts, and src/workbench/extensions/agent/stores/agent/agentConversationStore.ts. Conflict resolution: - src/scripts/api.logs.test.ts: modify/delete. The file doesn't exist on core/1.54 because its introducing PR (#17773) was never backported here. Dropped rather than smuggling in unrelated test scaffolding. - useAgentCrdtFollower.ts: core/1.54 has an older, pre-refactor version of this file. The fix's `appliedLive` outcome counter needs to distinguish a live doc update from a subscribe's one-time catch-up frame; core/1.54's LayoutFollowerBridge already computed that distinction internally but never exposed it. Added a small, additive `ClassifiedDocUpdate` type to layoutFollowerBridge.ts (not one of the reported conflicts, but a necessary minimal dependency, mirroring main's own pre-existing mechanism) to expose the flag on the already-dispatched `doc_update` event, then wired `appliedLive` counting off it. - AgentPanelRoot.vue: kept the PR's teardown fix (reset canvasSyncGate on unmount); dropped `agentMinimapLayer.dispose()`, an unrelated feature not present on core/1.54. - agentConversationStore.ts / .test.ts: diff-alignment conflicts from upstream reordering; merged both sides' real content, kept core/1.54's Pinia test setup. - agentEventTransport.ts / .test.ts (auto-merged, not a reported conflict): imported STALE_AFTER_MS from agentCrdtDocLifecycle.ts, a module that doesn't exist on core/1.54 (a later extraction refactor not yet backported). Repointed both to useAgentCrdtFollower.ts, which still exports that same constant on this branch's older file layout. - browser_tests/tests/agent/agentCanvasLagsToolCallCompletion.spec.ts (new file, auto-merged): referenced @/platform/remote/comfyui/types (moved from @/schemas/apiSchema on main, not yet backported) and agent.entryButton (renamed from agent.askComfyAgent on main). Repointed to core/1.54's current locations/copy. Also called HostDoc.graph(), a method main's harness has that core/1.54's didn't; added it to agentConversationHostDoc.ts mirroring main exactly (readGraph from the already-installed @comfyorg/comfy-multi-player package). Its assertions also expected `WorkSummary.vue`'s "Worked for Xs" collapsing summary button, a UI feature from #17339 never backported to core/1.54. core/1.54's own equivalent is `ToolCallGroup.vue`, using the same reka-ui Collapsible primitive but a different trigger label ("Ran N tool call(s) [for Xs]" via agent.ranToolCalls/ranToolCallsTimed, not agent.worked). Retargeted the three `/^Worked/` button-name matchers to `/^Ran/` to match; the underlying mechanics under test (the tool row's own spinner/done glyph, role="listitem" rows, aria-expanded on the trigger) are identical between the two components. One more difference surfaced by CI: core/1.54's ToolCallGroup.vue keeps itself expanded for as long as any tool part is still 'streaming' (a v-model tied to that state), which main's WorkSummary.vue does not do -- so in the very scenario this fix creates (a tool part held at 'streaming' past the turn's own settle), the trigger is already open when the test gets to it, and an unconditional click was closing it instead of opening it. Added an expandToolCallGroup() helper that checks aria-expanded before clicking, used at both call sites. The CANVAS_MUTATING_TOOLS pinning unit test (agentEventTransport.test.ts) depends on the BE-11470 conversation-replay fixture corpus, backported separately in #18585 (which this branch is based on). Verification: pnpm typecheck, pnpm typecheck:browser, pnpm eslint, pnpm exec oxfmt all clean. Targeted pnpm vitest run across useAgentCrdtFollower, followerSubscription, AgentPanelRoot, agentConversationStore, agentEventTransport, CrdtDevPanel, crdtDebugReport: all green except 3 pre-existing Media-card upload failures (confirmed identical on unmodified origin/core/1.54, matching a prior backport's own documented note). <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_
… materialization (PM-1575/PM-1576) (#18595) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054937773959?thread_ts=1790054937.773959&cid=C0BGH348Z0C)_ Backport of #18391 to `core/1.54`. Stacked on #18585 (BE-11470 conversation-replay fixture corpus), which this branch is based on and which must merge first. ## Before An agent tool call that touches the canvas (e.g. adding a node) reports done — the tool's row flips straight to its settled icon — while the canvas itself still shows nothing for the new content, for a stretch that can be close to 10 real seconds. `agentEventTransport.ts`'s `ingest()` flipped a tool part's `state` to `'done'` purely from the chat-channel `agent_tool_call` frame's own `status` field, with zero coupling to whether the corresponding CRDT `doc_update` had actually reached and been projected onto the canvas. ## After `createAgentEventTransport` now takes an optional `shouldAwaitCanvasSync` gate. While it returns `true`, a tool call that reports done holds its part's displayed `state` at `'streaming'` instead of flipping straight to `'done'`, until either `notifyCanvasCaughtUp()` is called or `STALE_AFTER_MS` (30s) elapses. `agentConversationStore.ts` threads this gate through every transport it creates; `AgentPanelRoot.vue` wires it to the CRDT follower's own catch-up signal. ## How (backport-specific) Cherry-picked squash-merge commit `fce6d77e36b3f3ec7c00ce405c56628eabc55a12`. The automated backport failed with conflicts in the 5 files it named; each is resolved and explained in the commit message. Two notable adaptations for `core/1.54`'s older code shape: - `useAgentCrdtFollower.ts` / `layoutFollowerBridge.ts`: the fix's `appliedLive` outcome counter needs to distinguish a live doc update from a subscribe's one-time catch-up frame. `core/1.54`'s `LayoutFollowerBridge` already computed that distinction internally but never exposed it — added a small, additive `ClassifiedDocUpdate` type (mirroring `main`'s own pre-existing mechanism) to expose it on the already-dispatched `doc_update` event. - The PR's own new Playwright spec (`agentCanvasLagsToolCallCompletion.spec.ts`) referenced a module path, an i18n key, and a `HostDoc` method that only exist on `main`'s newer code shape. Repointed to `core/1.54`'s current equivalents (`@/schemas/apiSchema`, `agent.askComfyAgent`) and added the missing `HostDoc.graph()` method to the shared test harness, mirroring `main` exactly. ## Verification `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm eslint`, `pnpm exec oxfmt` all clean. Targeted `pnpm vitest run` across the touched agent test suites: all green except 3 pre-existing "Media-card" upload failures, confirmed identical on unmodified `origin/core/1.54` (a documented pre-existing gap from an earlier backport). --- _Generated by [Claude Code](https://claude.ai/code/session_01NQDb2pk4BuLEgzkga3GhEs)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
Eight backport carriers each dropped their black-box proof spec because the agent conversation-replay harness family was never backported, so most agent CRDT fixes on this line ship with unit coverage only. Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried. Test infrastructure only; no product file is touched. Carried from main, byte-identical except where this branch's surface differs: - browser_tests/fixtures/agentConversationFixture.ts - browser_tests/fixtures/data/agent/agentConversation.ts (+ .test.ts) - browser_tests/fixtures/data/agent/agentConversationExpectations.ts - browser_tests/fixtures/data/agent/agentHumanAddBlueprints.ts - browser_tests/fixtures/data/agentReplayNodeDefs.ts - browser_tests/fixtures/utils/agentReplayNodeContract.ts (+ .test.ts) - browser_tests/tests/agent/agentConversationReplay.spec.ts - browser_tests/tests/agent/agentWidgetTypingReconcile.spec.ts - browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts Branch adaptations, each with a comment at the site saying why: - agentConversation.ts drops the messageDraft slot of zAgentWsEvent. zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not on this branch. - agentPanelFixture.ts gains mockWorkflowPersistence and the vueNodes boot option. UserDataFullInfo comes from @/schemas/apiSchema, not main's @/platform/remote/comfyui/types, which does not exist here -- the same adaptation savedWorkflowPersistence.ts already carries. - agentConversationFixture.ts waits on PrimeVue's .p-blockui-mask instead of data-testid="app-loading-overlay", which App.vue does not render here. - agentConversationHostDoc.ts apply() takes RecordedGraphOperation[]. - Topbar gains tabs; selectors gains topbar.workflowTab, whose test id WorkflowTab.vue already renders on this branch. - globals.d.ts gains TabSwitchLens and window.__tabSwitchLens. - Four exports in agentConversation.ts are module-local here; their only consumer on main is scripts/agentConversationAssemble.ts, not backported. The 15 recorded conversation JSON files are already on this branch and byte-identical to main (#18585/#18586), so this is harness code only. Not carried, deliberately: main's agentFollowerHostSocket.ts, whose newer members this harness does not use and which imports @/platform/remote/comfyui/execution/types -- absent here, the same missing module that left core/1.54 red for six hours (#18722); the recording-authoring tools under scripts/ and tools/test-recorder; agentConversationCapabilityMatrix.
Eight backport carriers each dropped their black-box proof spec because the agent conversation-replay harness family was never backported, so most agent CRDT fixes on this line ship with unit coverage only. Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried. Test infrastructure only; no product file is touched. Carried from main, byte-identical except where this branch's surface differs: - browser_tests/fixtures/agentConversationFixture.ts - browser_tests/fixtures/data/agent/agentConversation.ts (+ .test.ts) - browser_tests/fixtures/data/agent/agentConversationExpectations.ts - browser_tests/fixtures/data/agent/agentHumanAddBlueprints.ts - browser_tests/fixtures/data/agentReplayNodeDefs.ts - browser_tests/fixtures/utils/agentReplayNodeContract.ts (+ .test.ts) - browser_tests/tests/agent/agentConversationReplay.spec.ts - browser_tests/tests/agent/agentWidgetTypingReconcile.spec.ts - browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts Branch adaptations, each with a comment at the site saying why: - agentConversation.ts drops the messageDraft slot of zAgentWsEvent. zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not on this branch. - agentPanelFixture.ts gains mockWorkflowPersistence and the vueNodes boot option. UserDataFullInfo comes from @/schemas/apiSchema, not main's @/platform/remote/comfyui/types, which does not exist here -- the same adaptation savedWorkflowPersistence.ts already carries. - agentConversationFixture.ts waits on PrimeVue's .p-blockui-mask instead of data-testid="app-loading-overlay", which App.vue does not render here. - agentConversationHostDoc.ts apply() takes RecordedGraphOperation[]. - Topbar gains tabs; selectors gains topbar.workflowTab, whose test id WorkflowTab.vue already renders on this branch. - globals.d.ts gains TabSwitchLens and window.__tabSwitchLens. - Four exports in agentConversation.ts are module-local here; their only consumer on main is scripts/agentConversationAssemble.ts, not backported. The 15 recorded conversation JSON files are already on this branch and byte-identical to main (#18585/#18586), so this is harness code only. Not carried, deliberately: main's agentFollowerHostSocket.ts, whose newer members this harness does not use and which imports @/platform/remote/comfyui/execution/types -- absent here, the same missing module that left core/1.54 red for six hours (#18722); the recording-authoring tools under scripts/ and tools/test-recorder; agentConversationCapabilityMatrix.
…18968) ## Summary Backports the agent conversation-replay test harness to `cloud/1.54` so the release line can replay the 15 recorded agent conversations it already carries. Test infrastructure only — no product file is touched. ## Changes - **What**: the harness family (`agentConversationFixture.ts`, `data/agent/agentConversation.ts`, `agentConversationExpectations.ts`, `agentHumanAddBlueprints.ts`, `data/agentReplayNodeDefs.ts`, `utils/agentReplayNodeContract.ts`), the two harness self-tests, and three black-box specs that consume it. Small additive hunks to `agentPanelFixture.ts`, `agentConversationHostDoc.ts`, `components/Topbar.ts`, `selectors.ts` and `types/globals.d.ts`. - **Dependencies**: none new. The 17 recorded-conversation JSON files landed earlier (#18585/#18586) and are byte-identical to `main`. ### Why Eight carriers each dropped their black-box proof spec one at a time, for the same reason: this harness family (from unbackported #16764 / #17537 / #17875 / #18164) does not exist on the 1.54 pair, so most agent CRDT fixes on this line ship with unit coverage only. #18758 recorded the intended remedy — "left for a follow-up once the agent Playwright fixture infrastructure itself is backported". Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried, which is this PR. `agentWidgetTypingReconcile.spec.ts` is the payoff worth naming: it is the black-box proof of the widget-typing garble fix (PM-1191/PM-1697), a P0 that is live in production on this line with no e2e coverage here until now. ## Review Focus Everything came from `main` byte-identical except the adaptations below, each commented at the site: | Adaptation | Why | |---|---| | `agentConversation.ts` drops the `messageDraft` slot of `zAgentWsEvent` | `zAgentMessageDraftEvent` arrived with #18551 (streaming reply), which is not on this branch. Re-add it if #18551 is carried. | | `mockWorkflowPersistence` reads `UserDataFullInfo` from `@/schemas/apiSchema` | `main` reads it from `@/platform/remote/comfyui/types`, which does not exist here. `browser_tests/fixtures/utils/savedWorkflowPersistence.ts` already carries exactly this adaptation. | | `reloadWithoutLocalWorkflow()` waits on `.p-blockui-mask` | `App.vue` on this branch renders PrimeVue `BlockUI`, not `data-testid="app-loading-overlay"`. `ComfyPage` already matches the mask this way. | | `HostDoc.apply()` takes `RecordedGraphOperation[]` | matches `main`; the applier is the only judge of a recorded op. | | `Topbar.tabs` + `TestIds.topbar.workflowTab` | `WorkflowTab.vue` already renders `data-testid="workflow-tab"` on this branch. | | four exports in `agentConversation.ts` are module-local | their only consumer on `main` is `scripts/agentConversationAssemble.ts`, which is not backported. | **Deliberately not carried**, and the one that matters for review: - `main`'s newer `agentFollowerHostSocket.ts`. This harness uses none of its added members, and it imports `@/platform/remote/comfyui/execution/types` — absent on this branch. That is the same missing-module shape that left `core/1.54` red for six hours after #18722, so the branch's existing socket is kept as-is. - The recording-authoring side (`scripts/agentConversation{Assemble,FromLangfuse,Record}.ts`, `tools/test-recorder/.../agentReplay.ts`, `agentConversationCapabilityMatrix`). A release branch needs to replay the recordings it has, not author new ones. Verified locally against this branch: `pnpm typecheck` and `pnpm typecheck:browser` clean, `pnpm knip` clean, `pnpm lint` 0 errors, the three carried vitest files 33/33 green, and `playwright --project=cloud` on `agentConversationReplay.spec.ts` 19/20 and `agentWidgetTypingReconcile.spec.ts` 1/1. Two `agentHumanAddTabSwitch` subgraph-blueprint cases and the one `@screenshot` case cannot be judged outside the CI container — both behave identically on a `main` checkout in the same local setup, so CI is the arbiter for those three.
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Before
core/1.54has no recorded agent-conversation fixture corpus at all. Aneeds-backportlabel re-run of PR #18391's backport failed withENOENTonbrowser_tests/fixtures/data/agent/conversations— one of #18391's own new unit tests (agentEventTransport CANVAS_MUTATING_TOOLS pinning (PM-1575)) walks that directory's JSON fixtures directly to guard against a newly-added, unreviewed agent tool name silently defaulting to "not canvas-mutating."After
Backports the 14 recorded conversation JSON fixtures plus the derived empty-workflow seed fixture from
#16764and#17416(BE-11470) tocore/1.54, unblocking that test. Every file is byte-identical to its copy onmain(verified withdiffagainstorigin/main).This is a deliberately data-only backport. It leaves out:
agentConversation.ts/.test.ts)agentConversationFixture.ts,agentConversationHostDoc.ts,agentConversationReplay.spec.ts, capability-matrix files)CloudWorkspaceMockHelper.ts,agentPanelMocks.ts,cloudBootMocks.ts) that BE-11470: test(agent): replay recorded agent conversations turn by turn #16764 also toucheduseAgentCrdtFollower.ts/agentNodeMaterializer.ts) bundled into BE-11470: test(agent): replay recorded agent conversations turn by turn #16764None of that is needed for what actually requires this corpus on
core/1.54right now, and the mock-helper refactors carry real conflict risk against this branch's independently-drifted test infra. It can be extended with the loader/harness in a follow-up ifcore/1.54ever needs the full E2E replay spec.How
git show origin/main:<path> > <path>for each of the 13 files, into the same pathsmainuses. No other files touched.🤖 Generated with Claude Code
https://claude.ai/code/session_01NQDb2pk4BuLEgzkga3GhEs
Generated by Claude Code