Repository navigation
fix: agent delete-all doesn't clear canvas until next message - #18404
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2140 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8ec223dab2b6760514363172a4a8b3a6fef21f86
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 10 MB gzip 🟢 -737 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.99 MB (baseline 3.99 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 576 kB (baseline 578 kB) • 🟢 -1.33 kBHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • 🟢 -414 BBundles that do not match a named category
Status: 76 added / 76 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T05:33:29.985Z",
"gitSha": "36b796cb41356284ae70cf3abf82a95b374cd707",
"branch": "fix/agent-delete-all-scope-drop-retry",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1997.0870000000218,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.077000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.614,
"heapDeltaBytes": 8089848,
"heapUsedBytes": 70437288,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.238000000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2005.5740000000242,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4610000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.47099999999995,
"heapDeltaBytes": 5807612,
"heapUsedBytes": 68222284,
"domNodes": -228,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.748999999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.8070000000089,
"styleRecalcs": 72,
"styleRecalcDurationMs": 18.759,
"layouts": 12,
"layoutDurationMs": 4.825,
"taskDurationMs": 888.0679999999999,
"heapDeltaBytes": 1423268,
"heapUsedBytes": 64165088,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 176.991,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.903000000054,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.583,
"layouts": 12,
"layoutDurationMs": 5.164000000000001,
"taskDurationMs": 848.144,
"heapDeltaBytes": -3237256,
"heapUsedBytes": 59267784,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 172.317,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.5489999999718,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.161999999999999,
"layouts": 6,
"layoutDurationMs": 1.0870000000000002,
"taskDurationMs": 318.605,
"heapDeltaBytes": 2629168,
"heapUsedBytes": 70096844,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.198000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.5880000000398,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.87,
"layouts": 6,
"layoutDurationMs": 1.3399999999999999,
"taskDurationMs": 341.978,
"heapDeltaBytes": 2583460,
"heapUsedBytes": 70308028,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.556000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 712.128000000007,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.822000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.73699999999997,
"heapDeltaBytes": 18716076,
"heapUsedBytes": 81189144,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.27599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 677.0850000000337,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6270000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.57499999999993,
"heapDeltaBytes": 18958524,
"heapUsedBytes": 80956852,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 168.88500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.820000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 874.921,
"heapDeltaBytes": 35259764,
"heapUsedBytes": 103601756,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 74.654,
"eventListeners": 0,
"totalBlockingTimeMs": 593,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.912000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 916.308,
"heapDeltaBytes": -12481892,
"heapUsedBytes": 73837588,
"domNodes": -259,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 70.41799999999999,
"eventListeners": -207,
"totalBlockingTimeMs": 554,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.9350000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.87600000000003,
"heapDeltaBytes": 14055548,
"heapUsedBytes": 90221788,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.089,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.412999999894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.42499999999933,
"heapDeltaBytes": 15083936,
"heapUsedBytes": 91846900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.46299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11440.489000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10377.845000000001,
"heapDeltaBytes": -13844996,
"heapUsedBytes": 69055608,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8556.342,
"eventListeners": 0,
"totalBlockingTimeMs": 1721,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9530.348000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8710.930999999999,
"heapDeltaBytes": 11718588,
"heapUsedBytes": 94314320,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7404.932000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1175,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10486.949999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9582.496000000001,
"heapDeltaBytes": -499552,
"heapUsedBytes": 82476584,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8165.111,
"eventListeners": 0,
"totalBlockingTimeMs": 1782,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11574.977999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10629.492,
"heapDeltaBytes": -4441368,
"heapUsedBytes": 73183812,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8892.68,
"eventListeners": -164,
"totalBlockingTimeMs": 1677,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2054.581999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.365,
"heapDeltaBytes": -6126384,
"heapUsedBytes": 75273476,
"domNodes": -228,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 34.714000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2054.108999999926,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.763000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.998,
"heapDeltaBytes": -6365700,
"heapUsedBytes": 74957916,
"domNodes": -228,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 33.96500000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2421.956000000023,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.203,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1656.7910000000002,
"heapDeltaBytes": -2692220,
"heapUsedBytes": 84826720,
"domNodes": -228,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 850.334,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2439.367000000061,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.415,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1673.048,
"heapDeltaBytes": -1319680,
"heapUsedBytes": 81077612,
"domNodes": -228,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 859.26,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3618.0060000000367,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.56,
"layouts": 60,
"layoutDurationMs": 13.655000000000001,
"taskDurationMs": 1704.729,
"heapDeltaBytes": 8045824,
"heapUsedBytes": 74621660,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 798.4879999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3670.3130000000783,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.219,
"layouts": 60,
"layoutDurationMs": 13.672,
"taskDurationMs": 1722.9,
"heapDeltaBytes": 9537748,
"heapUsedBytes": 74917700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 805.635,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3206.7069999999944,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.707000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2041.4690000000003,
"heapDeltaBytes": -3622312,
"heapUsedBytes": 81444256,
"domNodes": -228,
"jsHeapTotalBytes": 6213632,
"scriptDurationMs": 1008.751,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3158.064999999965,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.296999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.887,
"heapDeltaBytes": 3247596,
"heapUsedBytes": 88756736,
"domNodes": -198,
"jsHeapTotalBytes": 1495040,
"scriptDurationMs": 1041.319,
"eventListeners": 38,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2060.9000000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8989999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.3470000000001,
"heapDeltaBytes": -6027952,
"heapUsedBytes": 82194648,
"domNodes": -228,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 34.733,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.5189999999648,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.6769999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.9789999999998,
"heapDeltaBytes": -4778992,
"heapUsedBytes": 83965948,
"domNodes": -228,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 31.494999999999994,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.375,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.445999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.05,
"heapDeltaBytes": 13950252,
"heapUsedBytes": 76675168,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.793,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.9879999999057,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.241999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.22,
"heapDeltaBytes": 14115564,
"heapUsedBytes": 76899616,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.21900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.8060000000073,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.195000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.3290000000001,
"heapDeltaBytes": 10236500,
"heapUsedBytes": 74017596,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.879000000000003,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.4110000000182,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.69699999999995,
"heapDeltaBytes": 3712788,
"heapUsedBytes": 67076100,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.66,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.6149999999852,
"styleRecalcs": 61,
"styleRecalcDurationMs": 18.253999999999998,
"layouts": 16,
"layoutDurationMs": 6.899,
"taskDurationMs": 813.9150000000001,
"heapDeltaBytes": 3310304,
"heapUsedBytes": 66208800,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 121.15,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.2509999999656,
"styleRecalcs": 60,
"styleRecalcDurationMs": 17.057,
"layouts": 16,
"layoutDurationMs": 5.7989999999999995,
"taskDurationMs": 727.323,
"heapDeltaBytes": 18345928,
"heapUsedBytes": 80300072,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 113.409,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.9309999999987,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.19100000000001,
"layouts": 5,
"layoutDurationMs": 13.112000000000002,
"taskDurationMs": 923.8839999999999,
"heapDeltaBytes": 20295144,
"heapUsedBytes": 103907736,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.12200000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8757.251999999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5981.579,
"heapDeltaBytes": 135052,
"heapUsedBytes": 80678448,
"domNodes": -228,
"jsHeapTotalBytes": 1757184,
"scriptDurationMs": 2845.9570000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8540.62399999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5767.146000000001,
"heapDeltaBytes": -509260,
"heapUsedBytes": 80770996,
"domNodes": -228,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2815.954,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16886.769000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16362.071999999998,
"heapDeltaBytes": -70994404,
"heapUsedBytes": 171456512,
"domNodes": -8053,
"jsHeapTotalBytes": -16691200,
"scriptDurationMs": 256.72799999999995,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16828.447999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16438.14,
"heapDeltaBytes": -48373180,
"heapUsedBytes": 178834068,
"domNodes": -8049,
"jsHeapTotalBytes": -17502208,
"scriptDurationMs": 264.71099999999996,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20399.11699999999,
"styleRecalcs": 166,
"styleRecalcDurationMs": 16.702999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20054.628999999997,
"heapDeltaBytes": -49781636,
"heapUsedBytes": 169551256,
"domNodes": -8049,
"jsHeapTotalBytes": -21651456,
"scriptDurationMs": 870.949,
"eventListeners": -14923,
"totalBlockingTimeMs": 139,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20602.85699999997,
"styleRecalcs": 159,
"styleRecalcDurationMs": 17.27799999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20303.278000000002,
"heapDeltaBytes": -31848704,
"heapUsedBytes": 193127184,
"domNodes": -8049,
"jsHeapTotalBytes": -16592896,
"scriptDurationMs": 869.814,
"eventListeners": -14923,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6225.918000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.46799999999998,
"layouts": 20,
"layoutDurationMs": 22.119,
"taskDurationMs": 6149.031000000001,
"heapDeltaBytes": -51601716,
"heapUsedBytes": 189237444,
"domNodes": -8049,
"jsHeapTotalBytes": 5701632,
"scriptDurationMs": 135.525,
"eventListeners": -14923,
"totalBlockingTimeMs": 381,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6165.9499999999525,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.30399999999999,
"layouts": 20,
"layoutDurationMs": 22.73,
"taskDurationMs": 6096.344,
"heapDeltaBytes": -40573144,
"heapUsedBytes": 196701396,
"domNodes": -8049,
"jsHeapTotalBytes": 13697024,
"scriptDurationMs": 114.796,
"eventListeners": -14923,
"totalBlockingTimeMs": 328,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8462.660000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8266.22,
"heapDeltaBytes": -21914064,
"heapUsedBytes": 172417632,
"domNodes": 0,
"jsHeapTotalBytes": -24641536,
"scriptDurationMs": 128.84400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8611.365000000093,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8427.123,
"heapDeltaBytes": 2821176,
"heapUsedBytes": 197713468,
"domNodes": 0,
"jsHeapTotalBytes": -28049408,
"scriptDurationMs": 131.04500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 441.0679999999729,
"styleRecalcs": 16,
"styleRecalcDurationMs": 17.508000000000003,
"layouts": 4,
"layoutDurationMs": 2.128,
"taskDurationMs": 112.994,
"heapDeltaBytes": 4987592,
"heapUsedBytes": 66147436,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.897,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 480.275000000006,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.723000000000003,
"layouts": 4,
"layoutDurationMs": 2.033,
"taskDurationMs": 142.451,
"heapDeltaBytes": 5058928,
"heapUsedBytes": 67106756,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.809000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
…nvas Reproduces PM-1500/PM-1504: when the agent's mutation batch is rejected because getScope() briefly can't resolve the bound workflow tab, the only existing recovery arms reconcileNextFrame for whatever incoming frame happens to land next. If no further frame ever arrives (the user doesn't send another agent message), the stale doc/live mismatch is never cleaned up. This test asserts the adapter recovers on its own once scope becomes available again, without a new frame arriving; it fails against current code since nothing retries proactively.
…he next frame EcsFollowerAdapter.applyQueuedFrame already arms reconcileNextFrame when a batch is rejected for lack of scope, but the only trigger for that reconcile was whatever frame happened to arrive next. If the agent's delete-all lands during a brief getScope() race and the user never sends another message, the stale nodes stayed on the canvas indefinitely (a refresh doesn't help since it hits the same race). Add a bounded, self-driven retry: on a rejected batch, schedule a short timer that replays the pending reconcile directly, independent of any new incoming frame, until it commits or a retry budget is exhausted (falling back to the existing next-frame behavior).
b212e28 to
5f12a64
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 3 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18404 +/- ##
==========================================
+ Coverage 84.07% 84.99% +0.91%
==========================================
Files 3161 2311 -850
Lines 154612 133368 -21244
Branches 41985 36141 -5844
==========================================
- Hits 129989 113352 -16637
+ Misses 23019 19697 -3322
+ Partials 1604 319 -1285
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 857 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ive sweep) Addresses 7 Cursor review findings against the self-driven reconcile retry from the previous commit: - clearForReset and discardPending now also call clearReconcileRetry and disarm reconcileNextFrame, so a pending retry can no longer fire after a lineage reset or a schema-rejected batch and resurrect state those paths deliberately cleared. - The retry now routes a successful commit through a new onReconcileRetryCommitted hook, which AgentCrdtProjection wires to reconcileLiveGraph. Previously the retry only updated the ECS stores via the adapter's own applyFrame, so the canvas was never swept and a stale node could still be saved even after the retry "succeeded". - The retry timer's applyFrame call is now wrapped in try/catch and reports via reportError instead of dying as an unhandled global error and silently killing the retry chain. - GraphMutations gains an optional hasScope() check; the adapter only arms a retry for a scope-unavailable rejection now, not for every batch() rejection (a deterministic prepare() validation failure can never be fixed by waiting). - reconcileRetryAttempt resets when a new rejection episode starts (a real frame rejected while no retry is currently pending), not only on success/unbind, so the 20-attempt budget no longer has to cover multiple unrelated episodes in one session. - The retry resubmits the actual rejected DocUpdate (same seq/actor/ opIds) instead of a synthetic seq: -1 frame with no attribution. Extends the adapter-level retry test to assert the new commit hook fires, adds a test proving a deterministic rejection never arms a retry, and adds a projection-level integration test that proves the live graph (not just the store) is actually swept once the retry recovers, closing the gap the previous test left.
|
I am carrying this PR through readiness for the Agent milestone under Christian’s takeover instruction. I merged current |
This comment has been minimized.
This comment has been minimized.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested because retry recovery can still permanently split the store from the live canvas.
I found one blocking failure in the new recovery path and several cases where the tests do not distinguish the intended behavior from plausible regressions. The focused unit suite, typechecks, changed-file lint, formatting, and Fallow checks pass at 255dbbbf3cda1103c861864c5b68002f8745ad9b; the two new cloud Playwright tests were discovered but not executed.
PR-body corrections:
- P2: The retry is not bounded. Only the first 20 attempts are bounded to 200 ms; it then retries every 2 seconds until commit, reset, or unbind. Please remove the “budget exhausted” and next-frame-only fallback wording.
- P3: “Existing next-frame recovery path is unchanged” is too strong. The mechanism remains, but the new classifier and timer now alter its state and timing. “The existing next-frame reconcile remains as a recovery path” is accurate.
- P3: The verification count is stale. The reviewed head ran both changed integration files: 25 passed and 2 expected failures, not the adapter-only 20-test result.
- P3: The refresh/persistence and real-agent journey language exceeds the evidence. The projection test proves in-process store and live-graph removal after scope returns; it does not perform save/reload or refresh, and the browser tests were only listed. Please scope the claim to that evidence.
Disposition of existing feedback:
- Live-graph sweep: I confirmed the successful-callback case is fixed by the projection callback and real-graph integration test. A callback throw still leaves a distinct blocking split-state failure, called out inline.
- Reset/discard cleanup: I confirmed the production fix. Regression coverage for reset, discard, and unbind cancellation is still missing, called out inline.
- Timer-driven batch throw: I confirmed the catch/report/reschedule code fix. Its observable reporting and continued-recovery behavior remain untested, called out inline.
- Finite retry budget: I confirmed sustained slow retry fixes the finite budget. The PR prose remains stale, and cadence/episode boundaries are not falsified by tests.
- Deterministic rejection: I confirmed the fix for
createGraphMutations, but the optional interface fallback still retries an unclassified deterministicfalse; called out inline. - Synthetic frame/provenance: I confirmed the single-rejected-frame fix. Tests still accept fallback
replayattribution, and a later rejection can replace the armed episode’s provenance; both are called out inline. - Live-graph test gap: I confirmed the projection integration test closes this gap.
- Codecov’s nine uncovered changed lines: I confirmed meaningful gaps in cancellation, timer-error, provenance, and cadence coverage; the specific missing falsifiers are called out inline.
- Earlier lint/format failures: I contest this for the reviewed head; changed-file ESLint and oxfmt checks both pass locally.
Other lane dispositions: the duplicated rejection side channels and the five-field retry lifecycle are confirmed maintainability/type-model issues; repeated explanatory comments and the literal assertion are confirmed nits. I found no forbidden any/double assertions, suppressions, raw telemetry sinks, god-object growth, layout-command bypass, Tailwind/i18n/PrimeVue violations, or Playwright interaction-style violations in the diff.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
christian-byrne
left a comment
There was a problem hiding this comment.
No new finding at b6a464cc53. The merge-queue failure was caused by agentCrdtReconcileOverwrite.spec.ts still passing the removed callback form of replayResponse; current main expects ReplayResponseOptions, so the callback was both a browser type error and ignored at runtime. The test now supplies the same hook as beforeFirstGraphOps, preserving the intended ordering before the first agent graph mutation.
The refreshed stack passes browser typecheck, touched-file formatting, ESLint, type-aware pre-commit lint, git diff --check, Knip, and incremental Fallow with zero introduced findings. I did not start a browser or dev server; the fresh hosted matrix is now running. DrJKL remains assigned for the qualifying approval, with no review_requested entry.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: approved; the main merge and replay-options adaptation preserve the reviewed behavior.
I re-reviewed the follow-up against current main. The merge has no manual conflict-resolution delta. The sole authored hunk replaces the removed positional replayResponse callback with beforeFirstGraphOps, which is awaited at the same point: after subscription readiness and before the first host graph mutation is applied or delivered. The completed-widget-edit regression retains both independent oracles—the unrelated agent edit lands and the completed local value survives.
The two prior Fallow findings remain fixed. Browser typecheck, focused ESLint and formatting, diff checks, and scoped Fallow pass at this head. I found no new finding. FE-2504 remains the architectural follow-up for eliminating the underlying dual-authority reconciliation layer.
|
|
## Summary Backports the user-visible delete-all recovery from #18404 (db5e105) to cloud/1.55. It preserves the 1.55 numeric link-ID validation and retained projection/subscription surfaces, including their required batchResult contract updates. It also carries the hardened clear-canvas proof from #18969 with the pre-marker emptiness assertion. ## Verification - Focused follower and graph-mutation vitest: 142 passed, 3 pre-existing expected failures - Cloud Playwright: 5 cases executed; 4 passed initially and the target-native tab locator adaptation made the fifth pass on rerun - Pre-marker mutation: changing the pre-marker total canvas assertion from 0 to 1 failed at that assertion with received 0; mutation reverted - App and browser vue-tsc passed - oxfmt, type-aware oxlint, ESLint, and commit hooks passed - No AI co-author trailer ## Source - Source PR: #18404 - Source merge: db5e105 - Hardened black-box proof: #18969 / c6b4d27 ## Merge conditions Do not merge until hosted checks, review threads, the target-aware exact-head gate, and target ancestry are current at this head.
## Summary Backports the user-visible delete-all recovery from #18404 (db5e105) to core/1.55. It preserves the 1.55 numeric link-ID validation and retained projection/subscription surfaces, including their required batchResult contract updates. It also carries the hardened clear-canvas proof from #18969 with the pre-marker emptiness assertion. ## Verification - Focused follower and graph-mutation vitest: 142 passed, 3 pre-existing expected failures - Cloud Playwright: 5 cases executed; 4 passed initially and the target-native tab locator adaptation made the fifth pass on rerun - Pre-marker mutation: changing the pre-marker total canvas assertion from 0 to 1 failed at that assertion with received 0; mutation reverted - App and browser vue-tsc passed - oxfmt, type-aware oxlint, ESLint, and commit hooks passed - No AI co-author trailer ## Source - Source PR: #18404 - Source merge: db5e105 - Hardened black-box proof: #18969 / c6b4d27 ## Merge conditions Do not merge until hosted checks, review threads, the target-aware exact-head gate, and target ancestry are current at this head.
…on canvas (Comfy-Org#18969) ## Summary Re-authors the regression guard from Comfy-Org#18702 — closed without merging — as a black-box `browser_tests/` case, so the live bug it covered (ask the agent to clear the canvas, the turn reports the tab is empty, the nodes stay on screen — PM-1500, PM-1504) has a test again. ## Changes - **What**: new `browser_tests/tests/agent/agentClearedWorkflowStaysCleared.spec.ts` (two cases) plus one `browser_tests/types/globals.d.ts` declaration. Test-only; no production code touched. ## Why re-authored rather than reopened Comfy-Org#18702's base was `fix/agent-delete-all-scope-drop-retry` (Comfy-Org#18404), which is not landing, and it asserted against `AgentCrdtProjection` and `EcsFollowerAdapter` — both deleted by Comfy-Org#18700. Rebasing it would have restored a test onto a base that cannot merge, stated in code that is being removed. This states the same property where the user reads it: the rendered canvas. Every API it touches was checked against Comfy-Org#18700 and survives — `agentConversationTest` / `conversationCase`, `addedNodeIds`, `runTurns`, `subscribeCount`, `VueNodeHelpers.nodes` / `getNodeLocator`, `Topbar`, and the `agent-rec-clear-workflow` fixture. It asserts nothing in `agentCrdtProjection`, `ecsFollowerAdapter`, `graphMutations`, `agentNodeMaterializer` or `agentSubgraphHostSlots`, and `globals.d.ts` is untouched by Comfy-Org#18700, so there is no conflict there either. ## Review Focus **It closes a vacuous-pass hole, which is most of the point.** The recorded turn adds one node and then clears the workflow, so asserting only that the canvas ends empty cannot distinguish *the clear landed* from *neither operation did*. That is the failure mode flagged as PM-1755 — a recorded replay can skip a clear and still report a pass — and it is real here, measured, not hypothetical: | fault injected into the replay | `agentConversationReplay` (recorded case) | `agentDeleteAndClearWorkflow` on Comfy-Org#18700 | this spec | | --- | --- | --- | --- | | none | pass | pass | pass | | clear frame withheld from the client (the live bug) | **fail** | — | **fail** | | whole turn's graph ops withheld | pass | pass | **fail** | The distinguishing assertion records every `data-node-id` the DOM mounts, so it reads only what the user sees and does not care which graph API removed the node. **This lands green — it is a pin, not a live repro, and the PR does not claim a fix is needed.** The mechanism Comfy-Org#18702 drove the bug through was a mutation batch rejected because the app briefly could not resolve which workflow tab the edit was bound to. Comfy-Org#18700 removes that mechanism rather than fixing it: `AgentPanelRoot.vue` there has no `getScope` and no `createGraphMutations`, and `graphMutations.ts` / `ecsFollowerAdapter.ts` are deleted. So there is no surviving surface to inject the race from, and Comfy-Org#18404's `dropWorkflowScope()` — which reached into Pinia to delete `tab.activeState.id` — would be asserting against the very thing being deleted. What is worth holding across that change is the user-visible outcome, on both sides of it. **Second case, tab round trip.** Returning to the tab re-subscribes the follower, which replays the bound document over the tab's own snapshot; the case waits for that subscribe before asserting, so it is about the catch-up rather than about a canvas nothing has touched yet. `agentConversationReplay` never switches tabs, so this was unpinned. ## Verification Local, against a `DISTRIBUTION=cloud` dev server over a containerised ComfyUI backend with devtools: ``` PLAYWRIGHT_LOCAL=1 DISTRIBUTION=cloud pnpm exec playwright test \ browser_tests/tests/agent/agentClearedWorkflowStaysCleared.spec.ts --project=cloud ``` - `main` (9cb7f5b): 2 passed - Comfy-Org#18700 (540a2b8), spec copied in unchanged: 2 passed - red/green table above reproduced by temporary, uncommitted edits to `replayResponse` in `agentConversationFixture.ts` - `oxfmt`, `eslint`, `oxlint --type-aware`, `pnpm typecheck:browser`: clean (pre-commit hook ran all four) ## Note for Comfy-Org#18700 Comfy-Org#18700 adds its own `browser_tests/tests/agent/agentDeleteAndClearWorkflow.spec.ts`. This is a **different file**, deliberately, so there is no add/add conflict on rebase. Its `clear_canvas` case is the one that passes vacuously in the table above; the two can coexist, or that case can be dropped in favour of this one. --------- Co-authored-by: Amp <amp@ampcode.com>
## Summary Backports the production scope-race recovery from #18404 (`db5e105e9af91fe1fea22e25795edf62a7e285e9`) to `core/1.54`. Core 1.54 deliberately does not contain the Agent conversation fixture, so this carrier does not resurrect that Cloud-only browser harness, `agentDeleteAndClearWorkflow.spec.ts`, or the deleted legacy reconciliation specs/modules. It carries the shared follower retry and target-native unit coverage only, preserving Core’s numeric link handling and release-specific graph mutation behavior. ## Verification - `NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts src/workbench/extensions/agent/crdt/graphMutations.test.ts` — 144 passed, 3 pre-existing expected failures - app `vue-tsc` — passed - oxfmt, type-aware oxlint, eslint, commit hooks — passed - black-box case deliberately excluded: `core/1.54` has no `browser_tests/fixtures/agentConversationFixture.ts` or exposed Agent surface; restoring Cloud harness files would violate the target’s intentional deletion - no AI co-author trailer ## Source - Source PR: #18404 - Source merge: `db5e105e9af91fe1fea22e25795edf62a7e285e9` - Failed automation: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36399580042 ## Merge conditions Do not merge until hosted checks, target-aware exact-head gate, and review disposition are current at this head. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
## Summary Backports the user-visible delete-all recovery from #18404 (`db5e105e9af91fe1fea22e25795edf62a7e285e9`) to `cloud/1.54`. The retry clears a stale canvas after workflow scope returns without requiring another agent frame. This target deliberately keeps its release-native numeric link handling and the deletions of `agentCrdtProjection.ts`, `followerSubscription.test.ts`, `agentCrdtReconcileOverwrite.spec.ts`, and `agentTabSwitchRunSubmission.spec.ts`; those old reconciliation surfaces are not resurrected. The new `agentDeleteAndClearWorkflow.spec.ts` and its fixture support are carried. ## Verification - `NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts src/workbench/extensions/agent/crdt/graphMutations.test.ts` — 144 passed, 3 pre-existing expected failures - app and browser `vue-tsc` — passed - oxfmt, type-aware oxlint, eslint, commit hooks — passed - local Cloud Playwright reaches the release app but the Agent launcher is absent, matching the known `cloud/1.54` local-harness limitation recorded by #18346; hosted Cloud Playwright is required for browser acceptance and the pre-clear assertion mutation check - no AI co-author trailer ## Source - Source PR: #18404 - Source merge: `db5e105e9af91fe1fea22e25795edf62a7e285e9` - Failed automation: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36399580042 ## Merge conditions Do not merge until hosted checks, the focused Cloud browser case (including mutation evidence for the pre-clear canvas assertion), target-aware exact-head gate, and review disposition are current at this head. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
ELI5
When the in-app agent deletes every node on the canvas, sometimes the nodes stay on screen looking deleted-but-not. This PR makes the app retry on its own so the canvas catches up without you needing to send another message.
Motivation
Fixes the agent delete-all not clearing the canvas until the next message. The underlying mutation batch can be silently dropped when the app briefly can't resolve which workflow tab the agent's edit is bound to (a timing race on tab binding), and the only existing recovery path replayed that dropped work on whatever frame happened to arrive next — which may never come if the user just looks at the stale canvas and gives up rather than sending another message.
Linear
Provenance
src/workbench/extensions/agent/crdt/suite: 964 passed, 15 expected failures;agentDeleteAndClearWorkflow.spec.ts: 3 passed; the focused no-retry mutant failed with the stale node still present;pnpm typecheck: passed;pnpm typecheck:browser: passed; changed-file lint and formatting: clean;pnpm knip: clean.Reviewer context
Summary
EcsFollowerAdapteralready arms a full reconcile (reconcileNextFrame) when a mutation batch is rejected for lack of scope, but the only thing that ever triggered that reconcile was whichever frame happened to arrive nextunbind/clearForReset/discardPendinghad cancelled recoveryBefore / After
Test plan
ecsFollowerAdapter.integration.test.ts) proving the adapter retries and clears stale nodes on its own, without a new frame ever arrivingclearForReset/discardPending/unbind) proving each lifecycle action prevents a later retry mutation or callbackAgentCrdtProjection+ realLGraph) test proving a live node is actually removed once a live-graph sweep that threw once is retried; fixed that test to advance the slow (2s) retry cadence instead of the fast (200ms) one, which the focused run had been failing onclearForReset/discardPending/unbindstill cancel recovery afterwardAgentConversationHarnessto observe the same graph/node identity throughout: it waits for the clear frame while scope is absent, asserts the recorded node survives the rejected clear, then restores scope and proves the same graph clears without another frame🤖 Generated with Claude Code
https://claude.ai/code/session_01RqPA48WFa1viY7pogkESQm
Generated by Claude Code