Repository navigation
[backport cloud/1.54] Fix agent delete-all recovery (#18404) - #19222
Conversation
Backports db5e105 onto cloud/1.54. Preserve the release line’s deleted legacy reconciliation surfaces and numeric link handling while carrying the scope-race retry and its canvas-level regression.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1958 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T19:37:09.941Z",
"gitSha": "6bd982cfd6f537df196bc1ca1b67d70c4cdaec45",
"branch": "cbyrne/backport-18404-cloud-154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2012.4230000000125,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.1560000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.83299999999997,
"heapDeltaBytes": -9773580,
"heapUsedBytes": 60699792,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.625000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.578999999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.245999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.62,
"heapDeltaBytes": -9986636,
"heapUsedBytes": 60466964,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.085000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1732.184000000018,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.752000000000002,
"layouts": 14,
"layoutDurationMs": 3.994,
"taskDurationMs": 625.8710000000001,
"heapDeltaBytes": 6043212,
"heapUsedBytes": 76510328,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.023,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.0659999999598,
"styleRecalcs": 76,
"styleRecalcDurationMs": 22.323999999999998,
"layouts": 14,
"layoutDurationMs": 3.793,
"taskDurationMs": 556.115,
"heapDeltaBytes": -1904568,
"heapUsedBytes": 67822040,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 95.265,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.2079999999783,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.327,
"layouts": 6,
"layoutDurationMs": 0.8660000000000001,
"taskDurationMs": 200.05800000000002,
"heapDeltaBytes": 4261888,
"heapUsedBytes": 74467456,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6.568,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.3290000000138,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.624999999999998,
"layouts": 6,
"layoutDurationMs": 1.066,
"taskDurationMs": 351.41499999999996,
"heapDeltaBytes": 4639252,
"heapUsedBytes": 75923144,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.973999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 532.3130000000162,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.546000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.486,
"heapDeltaBytes": -7568352,
"heapUsedBytes": 62671620,
"domNodes": 22,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 106.365,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 643.3650000000171,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.763999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.88,
"heapDeltaBytes": -7715564,
"heapUsedBytes": 62868680,
"domNodes": 14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 126.35199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.6410000000114,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.776,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.509,
"heapDeltaBytes": 7331452,
"heapUsedBytes": 84202232,
"domNodes": -264,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 23.723000000000003,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.290000000041,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.44999999999993,
"heapDeltaBytes": 9029328,
"heapUsedBytes": 85720428,
"domNodes": -265,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 26.825999999999997,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2197.195000000022,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.95,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1136.2740000000001,
"heapDeltaBytes": 4141812,
"heapUsedBytes": 80906692,
"domNodes": -272,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 525.007,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2165.6679999999824,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.283999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1093.405,
"heapDeltaBytes": -9782976,
"heapUsedBytes": 67279544,
"domNodes": -276,
"jsHeapTotalBytes": 684032,
"scriptDurationMs": 529.913,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3266.278,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.347999999999999,
"layouts": 60,
"layoutDurationMs": 13.181,
"taskDurationMs": 1176.76,
"heapDeltaBytes": 934496,
"heapUsedBytes": 80003164,
"domNodes": -288,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 495.052,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3438.692000000003,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.634000000000004,
"layouts": 60,
"layoutDurationMs": 13.787,
"taskDurationMs": 1309.8229999999999,
"heapDeltaBytes": 13023012,
"heapUsedBytes": 91629912,
"domNodes": -286,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 546.813,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2421.5200000000436,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.429999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1294.03,
"heapDeltaBytes": 21119080,
"heapUsedBytes": 88842600,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 631.204,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2523.7339999999904,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.630000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1349.296,
"heapDeltaBytes": 17198800,
"heapUsedBytes": 85104252,
"domNodes": 6,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 654.856,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1998.0869999999982,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.312,
"heapDeltaBytes": 21850852,
"heapUsedBytes": 87834528,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.546,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.143000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.990000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.779,
"heapDeltaBytes": 8721632,
"heapUsedBytes": 87081548,
"domNodes": -266,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 33.081999999999994,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 380.0700000000461,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 255.954,
"heapDeltaBytes": 14673652,
"heapUsedBytes": 86734288,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 87.833,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 537.5990000000002,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.648,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.334,
"heapDeltaBytes": 15073136,
"heapUsedBytes": 88123868,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 107.398,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1991.6479999999979,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.482999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.305,
"heapDeltaBytes": 8292880,
"heapUsedBytes": 80281752,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.411,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1988.8770000000022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.425999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 282.93999999999994,
"heapDeltaBytes": -10531720,
"heapUsedBytes": 62070024,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4.716999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.1999999999866,
"styleRecalcs": 79,
"styleRecalcDurationMs": 25.342000000000002,
"layouts": 18,
"layoutDurationMs": 5.871,
"taskDurationMs": 616.765,
"heapDeltaBytes": -6893060,
"heapUsedBytes": 66301680,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 88.74900000000001,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.7150000000074,
"styleRecalcs": 79,
"styleRecalcDurationMs": 20.858999999999998,
"layouts": 18,
"layoutDurationMs": 4.424000000000001,
"taskDurationMs": 501.64699999999993,
"heapDeltaBytes": -6208132,
"heapUsedBytes": 66884016,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 69.837,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 799.8839999999632,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.000999999999998,
"layouts": 16,
"layoutDurationMs": 9.996000000000002,
"taskDurationMs": 546.1850000000001,
"heapDeltaBytes": 21985112,
"heapUsedBytes": 105781296,
"domNodes": 13831,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 17.440000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 65,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8184.981999999991,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3616.676,
"heapDeltaBytes": 10324756,
"heapUsedBytes": 86535900,
"domNodes": -239,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 1758.614,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9960.817000000021,
"styleRecalcs": 249,
"styleRecalcDurationMs": 46.53300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4743.632,
"heapDeltaBytes": 24950520,
"heapUsedBytes": 90636728,
"domNodes": -266,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 2102.007,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10637.211000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9787.98,
"heapDeltaBytes": -34993580,
"heapUsedBytes": 184201612,
"domNodes": -8068,
"jsHeapTotalBytes": -4726784,
"scriptDurationMs": 140.214,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13014.988999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12496.449999999999,
"heapDeltaBytes": -55981360,
"heapUsedBytes": 178619088,
"domNodes": -8068,
"jsHeapTotalBytes": -18485248,
"scriptDurationMs": 206.67799999999997,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13939.418000000045,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.811999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13166.423999999999,
"heapDeltaBytes": -50319052,
"heapUsedBytes": 170474472,
"domNodes": -8068,
"jsHeapTotalBytes": -14749696,
"scriptDurationMs": 580.4469999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14330.589999999973,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.740000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13876.44,
"heapDeltaBytes": -43106920,
"heapUsedBytes": 177017248,
"domNodes": -8068,
"jsHeapTotalBytes": -5021696,
"scriptDurationMs": 600.651,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4013.7149999999906,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.812,
"layouts": 20,
"layoutDurationMs": 19.246,
"taskDurationMs": 3911.074,
"heapDeltaBytes": -41675976,
"heapUsedBytes": 183605508,
"domNodes": -8067,
"jsHeapTotalBytes": 8708096,
"scriptDurationMs": 61.74400000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 53,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4191.685000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.43600000000001,
"layouts": 20,
"layoutDurationMs": 20.95000000000001,
"taskDurationMs": 4086.4399999999996,
"heapDeltaBytes": -42978820,
"heapUsedBytes": 177709816,
"domNodes": -8068,
"jsHeapTotalBytes": 10690560,
"scriptDurationMs": 71.455,
"eventListeners": -14931,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5388.703000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5066.41,
"heapDeltaBytes": 16674008,
"heapUsedBytes": 184824280,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 74.181,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5957.630999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5614.871000000001,
"heapDeltaBytes": 15953224,
"heapUsedBytes": 187817768,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 77.72600000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 65.56100000000242,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.655,
"layouts": 2,
"layoutDurationMs": 0.9269999999999999,
"taskDurationMs": 45.717,
"heapDeltaBytes": 3083892,
"heapUsedBytes": 71049464,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.489,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 59.06300000003739,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.971000000000002,
"layouts": 2,
"layoutDurationMs": 0.9889999999999999,
"taskDurationMs": 41.69900000000001,
"heapDeltaBytes": 2978772,
"heapUsedBytes": 71263148,
"domNodes": 122,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 2.8930000000000016,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Carries the hardened black-box proof from c6b4d27, including the pre-marker canvas assertion that prevents a later reconcile from repairing a false green.
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head 980208f5adcb3b4746d520e2dd943446b5f34f61 under the standing 1.54 backport grant. I compared the production changes to source merge db5e105e9a, retained Cloud 1.54’s numeric-link behavior, and confirmed the carrier does not resurrect the release-deleted projection/subscription specs. Focused follower/graph-mutation suites passed 144 with 3 pre-existing expected failures; app/browser typechecks and changed-file lint passed. The hardened clear-workflow spec from c6b4d27e80 is present with the emptiness assertion before the barrier frame. Local Cloud cannot expose the Agent launcher (known 1.54 harness limitation), so hosted Cloud Playwright remains a blocking acceptance gate. No human objection found; this is a COMMENT, not self-approval.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19222 +/- ##
=============================================
Coverage ? 83.94%
=============================================
Files ? 2117
Lines ? 126452
Branches ? 34196
=============================================
Hits ? 106155
Misses ? 20119
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review at 90054a9 under the standing Agent 1.54 backport grant. Reviewed the target-native diff and conflict resolution: activation now refreshes missing-model state after graph reconciliation, without changing the semantic op path. The focused follower suite and mutation proof pass locally; hosted release browser coverage confirms the tab-return warning and clear-workflow invariants pass. Awaiting terminal hosted checks before merge.
## Summary Cloud backport tags have failed whenever the merged commit contains workflow changes. This replaces `git push` with GitHub's refs API, adds manual recovery, and prevents concurrent runs from silently losing or misdirecting a tag. ## Changes - **What**: Creates `cloud/vX.Y.Z` refs through the GitHub API, supports manual recovery for a `cloud/x.y` branch, preserves every merged-commit run, and rejects an existing tag that points at the wrong commit. - **Tests**: Adds a focused workflow-contract test covering recovery, concurrency identity, API tag creation, race handling, and SHA validation. ## Review Focus Please check the manual recovery target selection and the existing/concurrent tag SHA guards. The immediate failure was reproduced three times in the [cloud/1.54 tag workflow](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36492388168); `cloud/v1.54.16` has since been recovered at the intended [#19222 merge commit](354d02d). Validation: `actionlint`, `oxfmt`, pre-commit type/lint checks, and `pnpm exec vitest run scripts/cicd/cloud-backport-tag.test.ts` (4/4). ## Screenshots (if applicable) Not applicable. This changes release automation only.
Summary
Backports the user-visible delete-all recovery from #18404 (
db5e105e9af91fe1fea22e25795edf62a7e285e9) tocloud/1.54. The retry clears a stale canvas after workflow scope returns without requiring another agent frame.This target deliberately keeps its release-native numeric link handling and the deletions of
agentCrdtProjection.ts,followerSubscription.test.ts,agentCrdtReconcileOverwrite.spec.ts, andagentTabSwitchRunSubmission.spec.ts; those old reconciliation surfaces are not resurrected. The newagentDeleteAndClearWorkflow.spec.tsand its fixture support are carried.Verification
NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts src/workbench/extensions/agent/crdt/graphMutations.test.ts— 144 passed, 3 pre-existing expected failuresvue-tsc— passedcloud/1.54local-harness limitation recorded by [backport cloud/1.54] Release disowned Agent workflow bindings #18346; hosted Cloud Playwright is required for browser acceptance and the pre-clear assertion mutation checkSource
db5e105e9af91fe1fea22e25795edf62a7e285e9Merge conditions
Do not merge until hosted checks, the focused Cloud browser case (including mutation evidence for the pre-clear canvas assertion), target-aware exact-head gate, and review disposition are current at this head.