Repository navigation
[backport core/1.55] Fix agent delete-all recovery (#18404) - #19229
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2119 passed, 0 failed · 3 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (15 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a6d9028a5fc31b934d06e6528dd016cdd4e745cb
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-28T10:50:37.564Z",
"gitSha": "b899c4bf0deaa7f9543813981d6d613db7ed235b",
"branch": "cbyrne/backport-18404-core-155",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.2600000000116,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.646,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.077,
"heapDeltaBytes": 7638356,
"heapUsedBytes": 75404700,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.124000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2011.109999999917,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.080999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.617,
"heapDeltaBytes": 10328616,
"heapUsedBytes": 77866748,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.433000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.1110000000244,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.158,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 878.023,
"heapDeltaBytes": 308420,
"heapUsedBytes": 68204244,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 168.70600000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.3269999999475,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 881.443,
"heapDeltaBytes": 4674328,
"heapUsedBytes": 72229112,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 172.011,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.920999999942,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.139999999999997,
"layouts": 6,
"layoutDurationMs": 1.078,
"taskDurationMs": 285.99800000000005,
"heapDeltaBytes": 3160844,
"heapUsedBytes": 70654328,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.441999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.238999999974,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.318,
"layouts": 6,
"layoutDurationMs": 1.056,
"taskDurationMs": 364.592,
"heapDeltaBytes": 3095584,
"heapUsedBytes": 70789364,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.731000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 719.5330000000126,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.821000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.677,
"heapDeltaBytes": 18850008,
"heapUsedBytes": 86599460,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 169.04399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 719.387000000097,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.19999999999993,
"heapDeltaBytes": 18837460,
"heapUsedBytes": 86443060,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 168.85,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1236.4539999999806,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 931.076,
"heapDeltaBytes": 38494584,
"heapUsedBytes": 108414060,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 71.77900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 623,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1226.6839999999775,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 917.4409999999999,
"heapDeltaBytes": -16617476,
"heapUsedBytes": 73764528,
"domNodes": -295,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 74.52900000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 552,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.9000000000287,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.9549999999996,
"heapDeltaBytes": 13934392,
"heapUsedBytes": 90886380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.624,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 866.3180000000921,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.2669999999996,
"heapDeltaBytes": 14414820,
"heapUsedBytes": 90446440,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.70899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 246,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10938.45399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10056.293,
"heapDeltaBytes": -750160,
"heapUsedBytes": 81455712,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8287.398,
"eventListeners": 0,
"totalBlockingTimeMs": 1438,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11213.139000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10182.743999999999,
"heapDeltaBytes": -8796248,
"heapUsedBytes": 72928992,
"domNodes": -14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8734.389000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1520,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11854.305000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10937.86,
"heapDeltaBytes": -11505460,
"heapUsedBytes": 71363416,
"domNodes": -16,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 9111.237000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 2055,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11067.274999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10169.295,
"heapDeltaBytes": -12577028,
"heapUsedBytes": 69967944,
"domNodes": -12,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8422.545999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 1408,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2022.7820000000065,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.716,
"heapDeltaBytes": -3802876,
"heapUsedBytes": 83118836,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.862000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2071.7579999999316,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.420000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.712,
"heapDeltaBytes": -4584236,
"heapUsedBytes": 82297164,
"domNodes": -244,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 47.42099999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2286.6219999999657,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.485000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1667.3500000000001,
"heapDeltaBytes": 19045812,
"heapUsedBytes": 83803796,
"domNodes": -250,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 867.8199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2441.834999999969,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.350000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1609.6529999999998,
"heapDeltaBytes": 15263332,
"heapUsedBytes": 79680752,
"domNodes": 8,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 902.23,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3570.0649999999996,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.616000000000001,
"layouts": 60,
"layoutDurationMs": 13.488999999999997,
"taskDurationMs": 1723.938,
"heapDeltaBytes": 8460988,
"heapUsedBytes": 74452584,
"domNodes": -3,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 799.6150000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3608.325000000036,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.963000000000001,
"layouts": 60,
"layoutDurationMs": 14.036000000000001,
"taskDurationMs": 1770.14,
"heapDeltaBytes": 8419492,
"heapUsedBytes": 74146184,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 823.213,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3114.3730000000005,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.611999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1922.9699999999998,
"heapDeltaBytes": 23731704,
"heapUsedBytes": 89799704,
"domNodes": 4,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 990.464,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3218.8169999999445,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.826,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2024.6959999999997,
"heapDeltaBytes": 28941660,
"heapUsedBytes": 94916520,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1036.658,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2039.327999999955,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.2810000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 705.908,
"heapDeltaBytes": -4106956,
"heapUsedBytes": 84504512,
"domNodes": -246,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 42.238,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.648000000042,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.298000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.42,
"heapDeltaBytes": -4929412,
"heapUsedBytes": 84199400,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.25700000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.1110000000645,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.678999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.857,
"heapDeltaBytes": 14095996,
"heapUsedBytes": 83940688,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.19100000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.0829999999687,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.088000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.97700000000003,
"heapDeltaBytes": 13723036,
"heapUsedBytes": 83704720,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.537,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.573999999991,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.551,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.77500000000003,
"heapDeltaBytes": -5515612,
"heapUsedBytes": 64559944,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.703000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.5010000000148,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.176,
"heapDeltaBytes": 9519124,
"heapUsedBytes": 79420272,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.227000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.9320000000184,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.033999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 727.878,
"heapDeltaBytes": -11197040,
"heapUsedBytes": 58887076,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 104.345,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.4369999999944,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.094,
"heapDeltaBytes": 6332740,
"heapUsedBytes": 76438060,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 116.123,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.9259999999267,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.521000000000008,
"layouts": 5,
"layoutDurationMs": 12.996,
"taskDurationMs": 952.714,
"heapDeltaBytes": -6430856,
"heapUsedBytes": 86734396,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.459,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8915.759999999977,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.444,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6232.196,
"heapDeltaBytes": -6308156,
"heapUsedBytes": 80541740,
"domNodes": -242,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2943.3790000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8535.591000000068,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.245000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6051.433,
"heapDeltaBytes": -6014236,
"heapUsedBytes": 80225312,
"domNodes": -241,
"jsHeapTotalBytes": 1007616,
"scriptDurationMs": 2853.1000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17446.552999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17246.941,
"heapDeltaBytes": -24075700,
"heapUsedBytes": 193985720,
"domNodes": -8061,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 270.781,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17702.04699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17270.863999999998,
"heapDeltaBytes": -16087380,
"heapUsedBytes": 198107040,
"domNodes": -8061,
"jsHeapTotalBytes": -11546624,
"scriptDurationMs": 273.07599999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22042.17499999993,
"styleRecalcs": 159,
"styleRecalcDurationMs": 22.351999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21914.121,
"heapDeltaBytes": -49155108,
"heapUsedBytes": 169521568,
"domNodes": -8061,
"jsHeapTotalBytes": -18096128,
"scriptDurationMs": 1020.9389999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 118,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21306.061999999998,
"styleRecalcs": 154,
"styleRecalcDurationMs": 20.153000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21167.876999999997,
"heapDeltaBytes": -46381208,
"heapUsedBytes": 191602500,
"domNodes": -8061,
"jsHeapTotalBytes": -17829888,
"scriptDurationMs": 922.4760000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6236.509999999953,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.56600000000003,
"layouts": 20,
"layoutDurationMs": 24.49399999999999,
"taskDurationMs": 6180.234,
"heapDeltaBytes": -21084752,
"heapUsedBytes": 162703800,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 115.22200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 408,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6328.0209999999215,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.49699999999999,
"layouts": 20,
"layoutDurationMs": 23.252999999999997,
"taskDurationMs": 6251.877,
"heapDeltaBytes": -58175168,
"heapUsedBytes": 182261960,
"domNodes": -8061,
"jsHeapTotalBytes": 11640832,
"scriptDurationMs": 108.62899999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 398,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8836.02099999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8631.987,
"heapDeltaBytes": -31233072,
"heapUsedBytes": 171002888,
"domNodes": 0,
"jsHeapTotalBytes": -31719424,
"scriptDurationMs": 134.49800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8731.05600000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8630.365000000002,
"heapDeltaBytes": 4574560,
"heapUsedBytes": 182898448,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 142.119,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 119.15599999997539,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.948,
"layouts": 5,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 103.54799999999997,
"heapDeltaBytes": 3304912,
"heapUsedBytes": 68898120,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.887,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 481.8760000000566,
"styleRecalcs": 21,
"styleRecalcDurationMs": 28.811999999999998,
"layouts": 4,
"layoutDurationMs": 2.0280000000000005,
"taskDurationMs": 131.05000000000004,
"heapDeltaBytes": 5029384,
"heapUsedBytes": 70672948,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.361999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head for f61062e on core/1.55 under the standing 1.55 backport grant. I compared the production and harness changes to source merge db5e105 and the hardened proof at c6b4d27. The carrier preserves 1.55 numeric link-ID validation, retains and updates its projection/subscription tests, and does not import graph-API rewrite content. Focused follower/graph suites passed 142 with 3 pre-existing expected failures; all five cloud cases are green after the target-native tab-locator adaptation; the temporary pre-marker assertion mutation failed at the intended pre-marker line on received zero and was reverted. App/browser typechecks and changed-file lint passed. No human objection found at review time. This is a COMMENT, not self-approval.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19229 +/- ##
=============================================
+ Coverage 84.66% 84.67% +0.01%
=============================================
Files 2301 2301
Lines 132083 132188 +105
Branches 35679 33817 -1862
=============================================
+ Hits 111823 111928 +105
+ Misses 19937 19936 -1
- Partials 323 324 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head 9c9a6e9 against core/1.55 under the standing 1.55 backport grant. I independently inspected the actual carrier diff and repair commit, confirmed source db5e105 is merged, and found no blocking issue. The repair restores target-native strict link validation (non-negative safe-integer tuple ID equal to the numeric map key) without changing the delete/clear recovery behavior. The carrier includes black-box delete/clear, pre-marker tab-return, and mutation coverage; the repair receipt records 157 focused tests plus 5 Playwright cases green and a deliberate mutation failing at the intended assertion. The target-aware gate is green at this exact head with 103 terminal non-adverse checks, current target ancestry, fresh receipts, and no unresolved thread or human objection. This is an honest COMMENT review, not self-approval.
Summary
Backports the user-visible delete-all recovery from #18404 (db5e105) to core/1.55. It preserves the 1.55 numeric link-ID validation and retained projection/subscription surfaces, including their required batchResult contract updates. It also carries the hardened clear-canvas proof from #18969 with the pre-marker emptiness assertion.
Verification
Source
Merge conditions
Do not merge until hosted checks, review threads, the target-aware exact-head gate, and target ancestry are current at this head.