Repository navigation
[backport cloud/1.55] Fix agent delete-all recovery (#18404) - #19228
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2125 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (15 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 45f2da1b0310dc6fa6ca360b899526cd0902257e
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T10:45:27.879Z",
"gitSha": "a0bf298a7a2eb6c580499f5f4d0a49eec20e9093",
"branch": "cbyrne/backport-18404-cloud-155",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.3829999999712,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.428,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.274,
"heapDeltaBytes": 7608204,
"heapUsedBytes": 74954368,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.294000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2000.4880000000185,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.81700000000006,
"heapDeltaBytes": 7450596,
"heapUsedBytes": 74976596,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 14.249999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1785.2330000000052,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.165999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 874.1909999999999,
"heapDeltaBytes": -5212848,
"heapUsedBytes": 62400552,
"domNodes": -261,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 165.52100000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.0669999999373,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.456,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.441,
"heapDeltaBytes": 7997164,
"heapUsedBytes": 75567664,
"domNodes": -259,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 175.37,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.1600000000267,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.037999999999997,
"layouts": 6,
"layoutDurationMs": 1.2,
"taskDurationMs": 425.767,
"heapDeltaBytes": 3104020,
"heapUsedBytes": 70848852,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 17.179,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1679.9849999999878,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.604,
"layouts": 6,
"layoutDurationMs": 1.3840000000000001,
"taskDurationMs": 399.435,
"heapDeltaBytes": 3097892,
"heapUsedBytes": 70808944,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.135,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.8119999999799,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.674999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.64599999999996,
"heapDeltaBytes": 18960660,
"heapUsedBytes": 86594904,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 172.274,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 729.3839999999818,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.746999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.046,
"heapDeltaBytes": 18878952,
"heapUsedBytes": 80267624,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 171.85500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.6100000000115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 856.505,
"heapDeltaBytes": 37923636,
"heapUsedBytes": 108208520,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 71.62700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 582,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1268.8359999999648,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 977.471,
"heapDeltaBytes": 35263132,
"heapUsedBytes": 103263864,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 75.464,
"eventListeners": 0,
"totalBlockingTimeMs": 636,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.9709999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.7880000000003,
"heapDeltaBytes": 14658568,
"heapUsedBytes": 91129936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.161,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 878.6239999999452,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.1900000000002,
"heapDeltaBytes": 16199588,
"heapUsedBytes": 92790024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.09900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10489.043999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9485.624,
"heapDeltaBytes": -10501528,
"heapUsedBytes": 71750328,
"domNodes": -12,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8011.208,
"eventListeners": 0,
"totalBlockingTimeMs": 1384,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11942.948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11052.163,
"heapDeltaBytes": -1780408,
"heapUsedBytes": 80414476,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9170.525,
"eventListeners": 0,
"totalBlockingTimeMs": 1597,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11231.019000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10359.055,
"heapDeltaBytes": -1771644,
"heapUsedBytes": 74274824,
"domNodes": -8,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 8608.777000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1778,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11921.196000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10983.516,
"heapDeltaBytes": -6614620,
"heapUsedBytes": 69413280,
"domNodes": -6,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 9101.973,
"eventListeners": 0,
"totalBlockingTimeMs": 1909,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "large-graph-idle",
"durationMs": 2041.1849999999845,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.824000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.0339999999999,
"heapDeltaBytes": -4083664,
"heapUsedBytes": 83319480,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 39.331,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.328000000045,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.814999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 748.6669999999999,
"heapDeltaBytes": -3333180,
"heapUsedBytes": 83335648,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 45.712,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2490.43800000004,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.828999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1769.8109999999997,
"heapDeltaBytes": -6484236,
"heapUsedBytes": 80784320,
"domNodes": -218,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 896.4540000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2762.4379999999746,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.891000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1847.9709999999998,
"heapDeltaBytes": 24454632,
"heapUsedBytes": 88857604,
"domNodes": 10,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 953.5719999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3904.640000000029,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.602,
"layouts": 60,
"layoutDurationMs": 14.341999999999999,
"taskDurationMs": 1907.9240000000002,
"heapDeltaBytes": 8780536,
"heapUsedBytes": 74751356,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 878.127,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3831.0020000000122,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.959000000000001,
"layouts": 60,
"layoutDurationMs": 13.841,
"taskDurationMs": 1873.546,
"heapDeltaBytes": 8608268,
"heapUsedBytes": 74887156,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 869.3649999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3200.597000000016,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.756999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1986.876,
"heapDeltaBytes": 25899280,
"heapUsedBytes": 91612064,
"domNodes": 6,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 1015.193,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3210.762000000045,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.339000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2046.608,
"heapDeltaBytes": 27358356,
"heapUsedBytes": 92998416,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1039.843,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.503000000033,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.1719999999999,
"heapDeltaBytes": 20164000,
"heapUsedBytes": 84705224,
"domNodes": -5,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.39999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2005.186999999978,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9059999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.069,
"heapDeltaBytes": 20237096,
"heapUsedBytes": 84698132,
"domNodes": -253,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.998999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.3059999999568,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.557999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.91400000000004,
"heapDeltaBytes": 14085568,
"heapUsedBytes": 83996448,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.38899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.82599999999,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.837,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.79699999999997,
"heapDeltaBytes": 14068804,
"heapUsedBytes": 84035536,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 149.515,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2001.1069999999904,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.49,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.37199999999996,
"heapDeltaBytes": -5048816,
"heapUsedBytes": 64834872,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.637,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2022.6780000000417,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.243000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.841,
"heapDeltaBytes": -14807696,
"heapUsedBytes": 55256432,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 11.826,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.3959999999975,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.258000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.671,
"heapDeltaBytes": 2759900,
"heapUsedBytes": 72322984,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 113.49199999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.1220000000421,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.675,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.0240000000001,
"heapDeltaBytes": -10397892,
"heapUsedBytes": 58948784,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 120.639,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.2210000000014,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.981,
"layouts": 5,
"layoutDurationMs": 13.699,
"taskDurationMs": 1000.364,
"heapDeltaBytes": 19360608,
"heapUsedBytes": 107113852,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 33.187000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8939.63100000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.793000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6241.758,
"heapDeltaBytes": -2449764,
"heapUsedBytes": 84359756,
"domNodes": -248,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2928.176,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8482.547999999952,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5618.907,
"heapDeltaBytes": -6124704,
"heapUsedBytes": 80596088,
"domNodes": -239,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2912.214,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17426.28400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17147.414999999997,
"heapDeltaBytes": -44479932,
"heapUsedBytes": 197260088,
"domNodes": -8061,
"jsHeapTotalBytes": -19075072,
"scriptDurationMs": 278.041,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17441.90500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17029.788,
"heapDeltaBytes": -48133972,
"heapUsedBytes": 187003248,
"domNodes": -8061,
"jsHeapTotalBytes": -6676480,
"scriptDurationMs": 275.334,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21599.947000000044,
"styleRecalcs": 156,
"styleRecalcDurationMs": 20.64200000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21448.63,
"heapDeltaBytes": -73898840,
"heapUsedBytes": 167411292,
"domNodes": -8061,
"jsHeapTotalBytes": -22220800,
"scriptDurationMs": 950.6719999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21559.436000000005,
"styleRecalcs": 156,
"styleRecalcDurationMs": 22.086999999999968,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21308.839,
"heapDeltaBytes": -26746092,
"heapUsedBytes": 191827912,
"domNodes": -8061,
"jsHeapTotalBytes": -18690048,
"scriptDurationMs": 963.7979999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 111,
"frameDurationMs": 18.333333333333453,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6323.599000000058,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.21400000000001,
"layouts": 20,
"layoutDurationMs": 27.754,
"taskDurationMs": 6243.36,
"heapDeltaBytes": -37657908,
"heapUsedBytes": 182102184,
"domNodes": -8061,
"jsHeapTotalBytes": 11468800,
"scriptDurationMs": 113.449,
"eventListeners": -14928,
"totalBlockingTimeMs": 412,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4944.108000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.45599999999997,
"layouts": 20,
"layoutDurationMs": 24.756999999999987,
"taskDurationMs": 4864.457,
"heapDeltaBytes": -13877972,
"heapUsedBytes": 200172360,
"domNodes": -8065,
"jsHeapTotalBytes": 24367104,
"scriptDurationMs": 102.75000000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 187,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8991.664000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8755.322999999999,
"heapDeltaBytes": 10534104,
"heapUsedBytes": 190184716,
"domNodes": 0,
"jsHeapTotalBytes": -30146560,
"scriptDurationMs": 155.52899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8579.420000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8387.706000000002,
"heapDeltaBytes": -20126784,
"heapUsedBytes": 172488484,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 135.35600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 125.81000000000131,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.548,
"layouts": 2,
"layoutDurationMs": 0.955,
"taskDurationMs": 91.93,
"heapDeltaBytes": 3216300,
"heapUsedBytes": 65205064,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.815,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 479.4619999998986,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.822000000000003,
"layouts": 4,
"layoutDurationMs": 1.5250000000000001,
"taskDurationMs": 125.744,
"heapDeltaBytes": 5056652,
"heapUsedBytes": 70963344,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.662,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head for 61397ba on cloud/1.55 under the standing 1.55 backport grant. I compared the production and harness changes to source merge db5e105 and the hardened proof at c6b4d27. The carrier preserves 1.55 numeric link-ID validation, retains and updates its projection/subscription tests, and does not import graph-API rewrite content. Focused follower/graph suites passed 142 with 3 pre-existing expected failures; all five cloud cases are green after the target-native tab-locator adaptation; the temporary pre-marker assertion mutation failed at the intended pre-marker line on received zero and was reverted. App/browser typechecks and changed-file lint passed. No human objection found at review time. This is a COMMENT, not self-approval.
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19228 +/- ##
=============================================
Coverage ? 84.67%
=============================================
Files ? 2301
Lines ? 132261
Branches ? 33569
=============================================
Hits ? 111994
Misses ? 19943
Partials ? 324
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head 828762f against cloud/1.55 under the standing 1.55 backport grant. I independently inspected the actual carrier diff and repair commit, confirmed source db5e105 is merged, and found no blocking issue. The repair restores target-native strict link validation (non-negative safe-integer tuple ID equal to the numeric map key) without changing the delete/clear recovery behavior. The carrier includes black-box delete/clear, pre-marker tab-return, and mutation coverage; the repair receipt records 157 focused tests plus 5 Playwright cases green and a deliberate mutation failing at the intended assertion. The target-aware gate is green at this exact head with 103 terminal non-adverse checks, current target ancestry, fresh receipts, and no unresolved thread or human objection. This is an honest COMMENT review, not self-approval.
Summary
Backports the user-visible delete-all recovery from #18404 (db5e105) to cloud/1.55. It preserves the 1.55 numeric link-ID validation and retained projection/subscription surfaces, including their required batchResult contract updates. It also carries the hardened clear-canvas proof from #18969 with the pre-marker emptiness assertion.
Verification
Source
Merge conditions
Do not merge until hosted checks, review threads, the target-aware exact-head gate, and target ancestry are current at this head.