Repository navigation
[backport core/1.54] Fix agent delete-all recovery (#18404) - #19223
Conversation
Backports the production retry from db5e105 onto core/1.54. The Core line deliberately has no Agent conversation fixture, so this carrier does not resurrect that deleted Cloud-only harness or the retired reconciliation surfaces.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1959 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head 04e2d3f2f569f3914a04153b7ba04c31e4a63b65 under the standing 1.54 backport grant. I compared the production changes to source merge db5e105e9a, retained Core 1.54’s target-specific graph mutation and numeric-link behavior, and confirmed the carrier does not resurrect the Cloud-only Agent conversation fixture or deleted reconciliation surfaces. Focused follower/graph-mutation suites passed 144 with 3 pre-existing expected failures; app typecheck and changed-file lint passed. Core has no supported Agent browser surface, so the Cloud-only black-box case is deliberately excluded. No human objection found; this is a COMMENT, not self-approval.
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19223 +/- ##
============================================
Coverage 83.87% 83.88%
============================================
Files 2109 2109
Lines 125362 125464 +102
Branches 33649 31811 -1838
============================================
+ Hits 105145 105243 +98
- Misses 20039 20042 +3
- Partials 178 179 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review at 27a4b1b under the standing Agent 1.54 backport grant. Reviewed the target-native diff and conflict resolution: activation now refreshes missing-model state after graph reconciliation, without changing the semantic op path. The focused follower suite and mutation proof pass locally; the hosted release browser suite is green, including the tab-return warning and clear-workflow invariants. Awaiting terminal hosted checks before merge.
Summary
Backports the production scope-race recovery from #18404 (
db5e105e9af91fe1fea22e25795edf62a7e285e9) tocore/1.54.Core 1.54 deliberately does not contain the Agent conversation fixture, so this carrier does not resurrect that Cloud-only browser harness,
agentDeleteAndClearWorkflow.spec.ts, or the deleted legacy reconciliation specs/modules. It carries the shared follower retry and target-native unit coverage only, preserving Core’s numeric link handling and release-specific graph mutation behavior.Verification
NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts src/workbench/extensions/agent/crdt/graphMutations.test.ts— 144 passed, 3 pre-existing expected failuresvue-tsc— passedcore/1.54has nobrowser_tests/fixtures/agentConversationFixture.tsor exposed Agent surface; restoring Cloud harness files would violate the target’s intentional deletionSource
db5e105e9af91fe1fea22e25795edf62a7e285e9Merge conditions
Do not merge until hosted checks, target-aware exact-head gate, and review disposition are current at this head.