Skip to content

[backport core/1.54] Fix agent delete-all recovery (#18404) - #19223

Merged
christian-byrne merged 4 commits into
core/1.54from
cbyrne/backport-18404-core-154
Sep 28, 2026
Merged

christian-byrne merged 4 commits into
core/1.54from
cbyrne/backport-18404-core-154

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports the production scope-race recovery from #18404 (db5e105e9af91fe1fea22e25795edf62a7e285e9) to core/1.54.

Core 1.54 deliberately does not contain the Agent conversation fixture, so this carrier does not resurrect that Cloud-only browser harness, agentDeleteAndClearWorkflow.spec.ts, or the deleted legacy reconciliation specs/modules. It carries the shared follower retry and target-native unit coverage only, preserving Core’s numeric link handling and release-specific graph mutation behavior.

Verification

  • NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts src/workbench/extensions/agent/crdt/graphMutations.test.ts — 144 passed, 3 pre-existing expected failures
  • app vue-tsc — passed
  • oxfmt, type-aware oxlint, eslint, commit hooks — passed
  • black-box case deliberately excluded: core/1.54 has no browser_tests/fixtures/agentConversationFixture.ts or exposed Agent surface; restoring Cloud harness files would violate the target’s intentional deletion
  • no AI co-author trailer

Source

Merge conditions

Do not merge until hosted checks, target-aware exact-head gate, and review disposition are current at this head.

Backports the production retry from db5e105 onto core/1.54. The Core line deliberately has no Agent conversation fixture, so this carrier does not resurrect that deleted Cloud-only harness or the retired reconciliation surfaces.
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 28, 2026
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 28, 2026 5:51pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 5:51pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 6b14278a-a544-45c6-873e-6161ee18f569

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@DrJKL
DrJKL self-requested a review September 28, 2026 09:33
@github-actions
github-actions Bot requested a review from huang47 September 28, 2026 09:33
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1959 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1938 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 10:37:10 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 04e2d3f2f569f3914a04153b7ba04c31e4a63b65 under the standing 1.54 backport grant. I compared the production changes to source merge db5e105e9a, retained Core 1.54’s target-specific graph mutation and numeric-link behavior, and confirmed the carrier does not resurrect the Cloud-only Agent conversation fixture or deleted reconciliation surfaces. Focused follower/graph-mutation suites passed 144 with 3 pre-existing expected failures; app typecheck and changed-file lint passed. Core has no supported Agent browser surface, so the Cloud-only black-box case is deliberately excluded. No human objection found; this is a COMMENT, not self-approval.

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.56098% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...kbench/extensions/agent/crdt/ecsFollowerAdapter.ts 97.05% 4 Missing and 1 partial ⚠️
@@             Coverage Diff              @@
##           core/1.54   #19223     +/-   ##
============================================
  Coverage      83.87%   83.88%             
============================================
  Files           2109     2109             
  Lines         125362   125464    +102     
  Branches       33649    31811   -1838     
============================================
+ Hits          105145   105243     +98     
- Misses         20039    20042      +3     
- Partials         178      179      +1     
Flag Coverage Δ
e2e 66.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../workbench/extensions/agent/crdt/graphMutations.ts 94.17% <100.00%> (+0.15%) ⬆️
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 98.03% <ø> (-0.01%) ⬇️
...kbench/extensions/agent/crdt/ecsFollowerAdapter.ts 97.36% <97.05%> (+0.57%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head review at 27a4b1b under the standing Agent 1.54 backport grant. Reviewed the target-native diff and conflict resolution: activation now refreshes missing-model state after graph reconciliation, without changing the semantic op path. The focused follower suite and mutation proof pass locally; the hosted release browser suite is green, including the tab-return warning and clear-workflow invariants. Awaiting terminal hosted checks before merge.

@christian-byrne
christian-byrne merged commit d66992c into core/1.54 Sep 28, 2026
63 of 64 checks passed
@christian-byrne
christian-byrne deleted the cbyrne/backport-18404-core-154 branch September 28, 2026 22:04

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — f869ec9b Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants