Repository navigation
[backport cloud/1.54] fix: avoid TDZ crash restoring saved multiline widget value - #18355
Conversation
Manual backport of #18324 to cloud/1.54 (the automated backport bot errored out before reaching this target). setValue in useStringWidget.ts's addMultilineWidget() closed over the outer widget const to read widget.options, but node.addDOMWidget(...) can invoke setValue synchronously while restoring a previously saved value during workflow load, before the const widget = node.addDOMWidget(...) assignment completes. Reading widget.options at that point threw a ReferenceError from the temporal dead zone. The fix hoists the widget's options object into its own widgetOptions const, declared and fully initialized before addDOMWidget is called, and has setValue reference that instead of the outer widget binding. Fixes Sentry issue CLOUD-FRONTEND-STAGING-4M6.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1934 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T04:48:58.979Z",
"gitSha": "c8eb3e879799741630717513386bfa74d00ec095",
"branch": "backport-18324-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2067.8800000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.246999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.852,
"heapDeltaBytes": -12487304,
"heapUsedBytes": 56534316,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.286000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2049.8570000000313,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.54600000000005,
"heapDeltaBytes": -11421104,
"heapUsedBytes": 58492788,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.290000000000003,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2033.6060000000202,
"styleRecalcs": 79,
"styleRecalcDurationMs": 34.927,
"layouts": 14,
"layoutDurationMs": 4.4510000000000005,
"taskDurationMs": 1036.3149999999998,
"heapDeltaBytes": 4886684,
"heapUsedBytes": 74804300,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 182.622,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1924.4679999999903,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.506,
"layouts": 14,
"layoutDurationMs": 4.807,
"taskDurationMs": 919.4389999999999,
"heapDeltaBytes": 10967284,
"heapUsedBytes": 81118432,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 174.143,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.7370000000242,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.56,
"layouts": 6,
"layoutDurationMs": 1.175,
"taskDurationMs": 365.2890000000001,
"heapDeltaBytes": 4648312,
"heapUsedBytes": 74829656,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.816999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6470000000145,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.584,
"layouts": 6,
"layoutDurationMs": 1.2289999999999999,
"taskDurationMs": 364.57099999999997,
"heapDeltaBytes": 4656296,
"heapUsedBytes": 75564780,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.346000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 725.6780000000163,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.484000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.663,
"heapDeltaBytes": 18721628,
"heapUsedBytes": 88384188,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 165.601,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 709.0779999999768,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.491,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.281,
"heapDeltaBytes": -7463008,
"heapUsedBytes": 63251484,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 173.14100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.3349999999882,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.686000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.1709999999999,
"heapDeltaBytes": 21831764,
"heapUsedBytes": 87373780,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.321000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.616999999993,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.398000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.2689999999999,
"heapDeltaBytes": -15970404,
"heapUsedBytes": 87044012,
"domNodes": -267,
"jsHeapTotalBytes": -331776,
"scriptDurationMs": 35.302,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2409.113999999988,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.899999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1699.484,
"heapDeltaBytes": 21314416,
"heapUsedBytes": 87920300,
"domNodes": 2,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 847.5109999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2443.1640000000243,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.736,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1740.783,
"heapDeltaBytes": 7975176,
"heapUsedBytes": 85302648,
"domNodes": -271,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 865.517,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3682.2899999999663,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.666999999999998,
"layouts": 60,
"layoutDurationMs": 12.184000000000001,
"taskDurationMs": 1778.0399999999997,
"heapDeltaBytes": 12410072,
"heapUsedBytes": 80845480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 810.232,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3747.2179999999753,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.802000000000001,
"layouts": 60,
"layoutDurationMs": 12.059000000000001,
"taskDurationMs": 1824.8160000000003,
"heapDeltaBytes": -2828392,
"heapUsedBytes": 76157580,
"domNodes": -287,
"jsHeapTotalBytes": 3563520,
"scriptDurationMs": 803.7379999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3190.1019999999676,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.800000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2039.4899999999998,
"heapDeltaBytes": 9785160,
"heapUsedBytes": 89841028,
"domNodes": -282,
"jsHeapTotalBytes": -212992,
"scriptDurationMs": 990.3349999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3166.6289999999435,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.281,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2025.2949999999998,
"heapDeltaBytes": 12602312,
"heapUsedBytes": 93537956,
"domNodes": -282,
"jsHeapTotalBytes": -737280,
"scriptDurationMs": 979.4970000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2069.9169999999754,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.311000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.4099999999999,
"heapDeltaBytes": 6866708,
"heapUsedBytes": 84096988,
"domNodes": -273,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 34.27899999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2078.1809999999723,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.722999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.7739999999999,
"heapDeltaBytes": 5844640,
"heapUsedBytes": 83085992,
"domNodes": -279,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 34.371,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.6360000000232,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.636999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.87,
"heapDeltaBytes": 15091380,
"heapUsedBytes": 88185736,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.65099999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.6599999999389,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.419999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.73100000000005,
"heapDeltaBytes": 14731304,
"heapUsedBytes": 87923456,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 155.612,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.5390000000143,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.108999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.90600000000006,
"heapDeltaBytes": -8047824,
"heapUsedBytes": 63652864,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.084,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.910999999965,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.280999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.90700000000004,
"heapDeltaBytes": -14019320,
"heapUsedBytes": 58977060,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.168000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1790.9870000000296,
"styleRecalcs": 79,
"styleRecalcDurationMs": 31.299,
"layouts": 18,
"layoutDurationMs": 5.57,
"taskDurationMs": 872.405,
"heapDeltaBytes": 10819884,
"heapUsedBytes": 83794856,
"domNodes": -295,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 118.81199999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.4159999999679,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.801,
"layouts": 18,
"layoutDurationMs": 5.605,
"taskDurationMs": 878.208,
"heapDeltaBytes": -15494612,
"heapUsedBytes": 57203252,
"domNodes": -299,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 123.137,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.78299999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.57300000000001,
"layouts": 16,
"layoutDurationMs": 16.094000000000005,
"taskDurationMs": 924.3940000000001,
"heapDeltaBytes": -7133612,
"heapUsedBytes": 82750356,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.771,
"eventListeners": 2385,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8996.991000000036,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6199.379000000001,
"heapDeltaBytes": 836012,
"heapUsedBytes": 77321600,
"domNodes": -283,
"jsHeapTotalBytes": 348160,
"scriptDurationMs": 2852.333,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8605.545000000006,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6092.66,
"heapDeltaBytes": -7288088,
"heapUsedBytes": 69186876,
"domNodes": -281,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 2814.3830000000003,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16860.162000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16351.802,
"heapDeltaBytes": -41598976,
"heapUsedBytes": 176302744,
"domNodes": -8068,
"jsHeapTotalBytes": -12333056,
"scriptDurationMs": 285.62399999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16763.57100000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16173.64,
"heapDeltaBytes": -41286816,
"heapUsedBytes": 177086052,
"domNodes": -8068,
"jsHeapTotalBytes": -11853824,
"scriptDurationMs": 273.335,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21284.368000000028,
"styleRecalcs": 178,
"styleRecalcDurationMs": 18.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20880.703,
"heapDeltaBytes": -25033016,
"heapUsedBytes": 192942352,
"domNodes": -8068,
"jsHeapTotalBytes": -9256960,
"scriptDurationMs": 954.275,
"eventListeners": -14927,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21045.905999999944,
"styleRecalcs": 176,
"styleRecalcDurationMs": 19.006999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20666.739999999998,
"heapDeltaBytes": -43209096,
"heapUsedBytes": 182606756,
"domNodes": -8068,
"jsHeapTotalBytes": -16998400,
"scriptDurationMs": 959.7610000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 89,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6121.466999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.866,
"layouts": 20,
"layoutDurationMs": 24.262999999999995,
"taskDurationMs": 6004.624,
"heapDeltaBytes": -36636420,
"heapUsedBytes": 182058388,
"domNodes": -8066,
"jsHeapTotalBytes": 16744448,
"scriptDurationMs": 112.46599999999998,
"eventListeners": -14927,
"totalBlockingTimeMs": 489,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6163.131000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.62399999999998,
"layouts": 20,
"layoutDurationMs": 23.785999999999987,
"taskDurationMs": 6032.095000000001,
"heapDeltaBytes": -56305204,
"heapUsedBytes": 174250644,
"domNodes": -8068,
"jsHeapTotalBytes": 1396736,
"scriptDurationMs": 134.825,
"eventListeners": -14931,
"totalBlockingTimeMs": 401,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8514.876999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8232.285999999998,
"heapDeltaBytes": 23955472,
"heapUsedBytes": 182006640,
"domNodes": 0,
"jsHeapTotalBytes": -5505024,
"scriptDurationMs": 134.3660000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8484.377999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8288.185,
"heapDeltaBytes": 14117820,
"heapUsedBytes": 178714084,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 131.72300000000004,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 479.5689999999695,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.86,
"layouts": 4,
"layoutDurationMs": 1.9729999999999999,
"taskDurationMs": 121.297,
"heapDeltaBytes": 4884572,
"heapUsedBytes": 73815936,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.049999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 110.01999999996315,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.472999999999999,
"layouts": 2,
"layoutDurationMs": 0.7309999999999999,
"taskDurationMs": 75.761,
"heapDeltaBytes": 3029088,
"heapUsedBytes": 71898708,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.596000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18355 +/- ##
=============================================
Coverage ? 83.57%
=============================================
Files ? 2094
Lines ? 123667
Branches ? 33424
=============================================
Hits ? 103349
Misses ? 20140
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… Image node bypassing upload (#18465) Automated backport of #18180 to `cloud/1.54`. The bot's auto-backport (`comfy-pr-bot`) failed on this branch with merge conflicts in: - `src/extensions/core/load3d/Load3DConfiguration.test.ts` - `src/extensions/core/load3d/Load3DConfiguration.ts` - `src/utils/createAnnotatedPath.test.ts` ## Root cause of the conflict Not a stacking conflict against any of the PRs the bot listed as still-open on `cloud/1.54` (#18418, #18411, #18370, #18367, #18355, #18351) — none of them touch these files. The real cause is identical to the `core/1.54` backport: `cloud/1.54` never received an **already-merged, unrelated** PR, #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR: - added a `DEFAULT_GIZMO`/`GizmoConfig` block to `Load3DConfiguration.ts` right next to the `parseAnnotatedFilename` helper that #18180 deletes (textual adjacency, not a real dependency — the gizmo code was left out, since it's out of scope here and `cloud/1.54` has no other reference to it), and added `ComfyApi`/`ComfyApp` test imports unused on this branch (dropped), - moved the `ResultItem` type from `@/schemas/apiSchema` to `@/platform/remote/comfyui/execution/types` on `main`, which `cloud/1.54` hasn't picked up (kept the branch's existing `@/schemas/apiSchema` import), and - added an `app.getRandParam()` call inside `nodeOutputStore.ts` (already present on `cloud/1.54` from an earlier point, unrelated to #18180) whose test mock in `nodeOutputStore.test.ts` was missing `getRandParam`, only surfaced now because #18180's new test is the first to exercise `getNodeImageUrls()` on this file — added the missing mock entry. Resolved by taking #18180's actual change (removing the local `parseAnnotatedFilename` in favor of the shared `parseAnnotatedPath` util) while leaving everything from #17537 out, since it isn't part of this branch. ## Verification - `pnpm exec vitest run` on the touched spec files (`Load3DConfiguration.test.ts`, `createAnnotatedPath.test.ts`, `nodeOutputStore.test.ts`, `imageUtil.test.ts`) — all pass (113/113) - `pnpm typecheck` — clean - `pnpm exec eslint` on changed files — no errors (2 pre-existing `apiSchema` deprecation warnings, unrelated to this change) - `pnpm exec oxfmt --check` on changed files — clean - The new Playwright e2e (`assetPanelDragOntoLoadImageWidget.spec.ts`) was not run locally (no backend available), consistent with the original PR's own review notes. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
…roups (#18275) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789965317152049?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_ Fixes agent-authored nodes with more than one autogrow group (e.g. a reference node with separate image and video reference groups) losing track of which wire goes where after the agent chat materializes the node. **Before:** For a node like `MiniMaxH3ReferenceToVideo`, which has two independent autogrow groups (`ref_images`, `ref_videos`) alongside scalar widgets (`width`, `height`, `length`, `ref_image_size`), both the agent panel and the canvas painted wires onto the wrong inputs after the node was built or reopened — a Load Image could land on `ref_image_size`, a text input on `length`, a Math node on `ref_videos`, and `width`/`height` could show as `0`. The server's own view of the graph was correctly wired, so pressing Run submitted the client's shifted (wrong) values and failed with type errors that didn't actually exist. Reopening the tab reconstructed the slots differently each time. **After:** For a document that is already correctly wired, projecting it onto the live canvas now lands every wire on the input it was actually connected to, and the value submitted on Run matches what's shown on canvas, regardless of how many autogrow groups the node has or how their growth interleaves with each other and with the node's scalar widgets. This covers the document-to-live projection direction only; the outbound leg (minting a link back into the host document) can still corrupt a node's addressing before this projection ever runs on it — see "Known issue" below and #18332. - **What**: `node.configure()` and autogrow growth (`COMFY_AUTOGROW_V3`) can reorder or insert a node's live inputs after the agent CRDT follower has already built its link adapters against the saved document's input *positions*. With one autogrow group this only shifts a couple of neighboring scalar widgets; with two or more groups growing on the same node, the drift compounds across the whole input list. The fix re-points the follower's link adapters, and the incoming reconcile/connect handling, at the input with the same *name* as the saved slot, instead of the same index — reusing the link realignment ordinary node loading already relies on, and extending the reconcile/connect path to resolve by name. A live-only input (one no document occurrence matches) is retained, rather than dropped along with the rest of the document's positional replacement, only when it classifies as a real autogrow group member — via a live query, this follower's own remembered answer, the node type's static `COMFY_AUTOGROW_V3` definition, or (last resort) the name-shape heuristic; a genuine removal still lets the document win. Duplicate input names on one node are matched pairwise by occurrence (the Nth document occurrence against the Nth live occurrence), not by first match. Node-data-store slot arrays are now refilled in place rather than reassigned, so any reactive view already holding that array keeps its identity across a resync. - **How**: Added a regression fixture and CRDT-follower test modeled on a node with two interleaved autogrow groups plus adjacent scalar widgets (the shape a single-group fixture can't exercise) — confirmed it fails on the unfixed code, then confirmed the by-name realignment above (generalized, not per-pair) makes it pass without further special-casing. The live-node autogrow-membership port collapsed "the live node can't answer yet" and "the live node answered no" into the same `undefined`, so an activate/resubscribe race could drop an explicit-name autogrow spare. The port now returns a tagged `unavailable`/`member`/`notMember` result and only the last two are authoritative. When the port is `unavailable`, provenance falls back in this order: this follower's own remembered live answer, then the node type's own static `COMFY_AUTOGROW_V3` definition, and only then the name-shape heuristic. The membership classification against a static schema (explicit `names` list vs. trailing ordinal) is one predicate shared with `dynamicWidgets.ts`'s live registration rather than a second implementation. `graphMutations.ts`) The remembered answers are addressable only from the node incarnation that produced them: - **Graph scope in the key.** One `GraphMutations` instance is retained per cloud workflow while resolving the current local workflow's scope on every batch, so the key is `rootGraphId` + `owningGraphId` + node id for remember, read and forget alike. - **Per-mutation transactional writes.** `batch()` opens a draft before `prepare()`; every `member`/`notMember` write and forget (replace, `deleteNode`, `removeMissing`, `clearSemanticGraph`) is staged into that draft, journaled under the mutation that produced it. `commit()` applies one mutation's journaled writes to the persisted store immediately after that mutation's own graph effect lands, and only when that effect actually landed — a `connect` whose `replaceLink` returns `undefined` (a stale expected occupant, an ID collision, or a newly-occupied target) never publishes the write it staged. A later mutation in the same batch throwing therefore still keeps every earlier mutation's already-applied write, and a `prepare()` rejection leaves the persisted store completely untouched. Within `prepare()` itself, a mutation can still see an earlier mutation's own staged (not yet committed) answer for the same node — its pending overlay chains onto the nearest earlier-indexed mutation's still-pending one, so two mutations prepared back to back in one batch agree on the same name's classification — but nothing outside that single `prepare()`/`commit()` pass, including a later batch's own `currentView()` reads, ever sees a same-batch mutation's answer before its own `commit()` iteration actually applies it. - **Definition-identity revalidation.** Each entry stores the `ComfyNodeDefImpl` it was answered against; a re-registration under the same type name constructs a new one, so the current definition always beats stale memory. Node type is still part of the entry for the case where another writer changes a node's type without this instance observing it. Also fixed a real race in the turn step: `agentConversationStore.ingest` only routes `agent_message_done` while the store already holds the ack's `message_id`, so the host must not answer before the assistant placeholder `startTurn` renders, or the turn hangs on a live Stop button forever. `agentCrdtMultiAutogrowRealign.spec.ts` sets sentinel widget values through the UI and inspects the submitted-prompt payload by name across three scenarios: a same-page tab-switch resubscribe, an actual save-and-reload of the same workflow, and a reload of a workflow whose saved bytes were corrupted after the save. The tab-switch case fills its sentinels *before* switching tabs and re-verifies those same values afterward, so a reconcile that resets or shifts an existing scalar during replay fails it, not just one that mis-wires a link. Three defects in the reload path (the second and third scenarios) are fixed here: - `mockSavedWorkflowPersistence` never served the `GET /api/userdata?dir=workflows&...` listing (its `**/api/userdata/*` pattern cannot match a URL with no path segment after `userdata`), so after a reload `workflowStore`'s `syncEntities` saw an empty listing, dropped the saved path from `openWorkflowPaths`, and the agent panel's workflow picker — which lists `openWorkflows` — came up **empty**. The reopen step then waited on a menu item that could never appear. This is the state the hosted runs were failing in; no timeout could help. - The saved-path GET counter route could never match an `encodeURIComponent`-encoded userdata path (`/api/userdata/workflows%2F<name>.json`), so the "the reopen really read the file" assertion polled a counter stuck at zero. It is now counted inside the persistence mock, and only for GETs it actually answered from retained saved bytes. - Saving under the default `Unsaved Workflow` name made the reopen indistinguishable from the fresh tab a reload always offers; it now saves under an explicit name through the Save As UI. **Spec structure.** The 506-line free-standing scenario function is replaced by a fixture-owned harness (`browser_tests/fixtures/helpers/MultiAutogrowRealignHarness.ts`, registered via `browser_tests/fixtures/multiAutogrowRealignFixture.ts`), per `browser_tests/README.md`. The spec file now contains only imports, `test.describe`, `test.describe.configure` and three `test()` bodies whose acts and assertions read in order. Per-test budgets drop from 240s to 90s/120s/120s. With the empty picker fixed, the second-turn reattach case reaches its assertions for the first time and fails deterministically: after save → reload → reattach, a link is dropped with `error_reconciling_agent_incompatible_link_type`. The live graph is correct (origin `VIDEO`, target `VIDEO`); the **host document** is not — node 2's doc inputs are in document name order (`prompt` at index 4, `ref_videos.ref_video_1` at index 7) but the link values were written by LIVE position, so `"link": 204` sits on the `prompt` (`STRING`) input and the link tuple reads `[204, 1, 3, 2, 4, "VIDEO"]`. `excludeIncompatibleLinks` then correctly refuses it. That is the same positional-vs-named confusion this PR fixes on the inbound path, occurring on the page → host doc leg through the real `applyOps` from `@comfyorg/comfy-multi-player`. Fixing it means changing the mint/outbound leg, which is a different code path needing its own design and regressions. **This defect is NOT covered by this PR.** It is not exercised by `agentCrdtMultiAutogrowRealign.spec.ts` (verifies the inbound/reconcile path only) and it is not exercised by `agentFollowerReloadBinding.spec.ts` either — that spec reattaches an ordinary scalar widget edit on a single-input node, never a multi-autogrow node, and never mints an outbound link at all. Rather than ship a red test or weaken an assertion in this PR, the reproduction is tracked separately with a real failing unit test: #18332 (branch `test/agent-crdt-outbound-link-position-bug`, `src/workbench/extensions/agent/crdt/linkMintOutboundPositionCorruption.test.ts`). - `realignInputLinkSlots` (already used by ordinary graph loading) is now also invoked after agent materialization; it iterates all of a node's named links in passes, so it isn't limited to a single autogrow group. - `mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in `graphMutations.ts`: a live-only input only survives when it is a widget-promoted input slot (the wire format never carries one as a named input either way) or classifies as an autogrow group member (and, unless the caller opts into `preserveLinkedAutogrow`, is unlinked); any other live-only input means the whole input set changed, and the document's list and order replace it positionally. See `docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md` for the full rule. - `createAutogrowMemory`'s read contract: an entry is trusted only when the graph scope, the node type, and the node definition object all still match. Its writes are gated on the producing mutation's own commit result — see "Autogrow memory lifecycle" above. - [x] **Red/green on each of the cache and commit-ordering blockers.** Each fix was reverted in isolation and the matching case confirmed to fail, then restored: - dropping the graph scope from the key fails `does not let one graph scope read another scope's remembered autogrow answer on the same GraphMutations instance` - making `remember()` write straight to the real map fails `does not leak the live answer a rejected batch resolved while preparing` - dropping the `nodeDef` identity clause fails `prefers a re-registered node definition over an autogrow answer remembered under the definition it replaced` - dropping the `nodeType` clause fails `does not apply a remembered autogrow answer to a node id another writer has since given a different type` - moving `beginMutation` back to prepare-only fails `journals a connect mutation's commit-time autogrow answer under its own index, not the batch's last-prepared one` - removing the `committed` gate on `connect`'s memory publication fails `does not publish a connect mutation's staged autogrow answer when its own replaceLink fails to land` - reverting `refillArray` to a spread-based `splice` fails `updateNode refills a slot list long enough to overflow a spread-based splice, without changing array identity` - **(round 8)** ordering `nodeStore.registerNode()` before `deps.layout.createNode()` (the pre-fix shape) fails `keeps an earlier mutation's remembered autogrow answer when a later mutation in the same batch throws`'s new node-3-absence assertion - **(round 8)** reverting the autogrow-memory draft to a single shared `shadow` (no per-mutation pending overlay / `rollbackMutation`) fails `does not leak a failed connect's staged autogrow answer to a later connect in the same batch` - **(round 9)** deleting the incumbent before `deps.layout.createNode()` in a type-changing `replaceNode` (the pre-fix shape) fails `keeps the incumbent node fully intact when a type-changing replace throws creating its layout` - **(round 9)** reverting `currentView` to check only the current mutation's own pending overlay and the confirmed shadow fails `lets a mutation see an earlier mutation's still-pending autogrow answer from the same batch`, while `does not leak a failed connect's staged autogrow answer to a later connect in the same batch` (round 8) keeps passing under the fixed, chained version - **(round 9)** restoring `preserveLinkedAutogrow`'s blanket non-plain-object early return fails `drops a linked, non-plain runtime slot the document dropped, even with preserveLinkedAutogrow set` - **(round 9)** removing the new widget-promoted-slot exception fails `retains a widget-promoted input slot no document snapshot ever lists`, and (caught only by the full suite, not this file's own unit tests) regresses `agentNodeMaterializer.inputOrder.test.ts`'s `preserves named targets when an agent reconnect follows growth that moves width` - [x] `pnpm exec vue-tsc --noEmit` and `pnpm exec vue-tsc --noEmit -p browser_tests/tsconfig.json` — clean - [x] `pnpm oxlint` (type-aware, whole repo) — no new warnings on `graphMutations.ts`/`nodeDataStore.ts`; `pnpm exec eslint src/workbench/extensions/agent/crdt/graphMutations.ts src/workbench/extensions/agent/crdt/graphMutations.test.ts src/stores/nodeDataStore.ts src/stores/nodeDataStore.test.ts` — clean; `pnpm exec oxfmt --check .` — clean; `pnpm knip` — clean - [x] `pnpm fallow audit --base origin/main` — `complexity_introduced: 2`, `dead_code_introduced: 0`, `duplication_introduced: 0`; the 2 introduced complexity findings are `LGraphCanvas.deselectAll` and `widgetMap.adoptConcreteWidget`, neither touched this round or by this PR — `graphMutations.ts`'s own `prepare`/`commit` findings are still `introduced: false` (pre-existing baseline). The overall verdict is `fail` only from those two plus unrelated inherited styling/complexity drift on `main` since this branch's base; nothing under `src/workbench/extensions/agent/crdt/` or `src/stores/nodeDataStore.ts` is newly introduced. - [x] `pnpm vitest run src/workbench/extensions/agent/crdt/ src/stores/nodeDataStore.test.ts` — 57 files, **885 passed, 5 expected fail** - [ ] The browser spec reorder (fill-then-switch-then-reverify) was not re-executed locally this round — this session had no dev server or backend available. It only reorders existing `test.step`s around already-existing harness methods (`fillSentinelWidgetValues`, `expectSentinelWidgetValues`, `switchTabsAwayAndBack`), with no new harness API surface, and typechecks clean. Hosted CI is the authority for this file, as it was for the prior round's own claim. **Known CI blocker (not addressed here):** `Check for AI agent co-author trailers` fails on 2 pre-existing commits on this branch that need a history rewrite (rewording). Destructive git history operations are outside what this session's own permission system allows regardless of reviewer sign-off; a human with push access to this branch needs to do that reword directly. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Automated backport of #18275 hit cherry-pick conflicts; resolved manually: - browser_tests/fixtures/agentConversationFixture.ts: dropped from this backport. The file doesn't exist on cloud/1.54 (added by the still- unbackported #17875) and nothing on this branch imports it, including the new agentCrdtMultiAutogrowRealign.spec.ts. - src/lib/litegraph/src/LGraphCanvas.ts (selectItems): kept cloud/1.54's existing body. The only diff here was an unrelated Array.from -> spread refactor picked up as context noise from #17048 (ownsSelectable filter), which also isn't on cloud/1.54. - src/core/graph/widgets/dynamicWidgets.ts, AgentPanelRoot.vue: additive conflicts, took the incoming side. Dropped an incoming useSettingStore import in AgentPanelRoot.vue that belonged to a separate, unbackported PR (#17730) and was unused on this branch. - src/workbench/extensions/agent/crdt/graphMutations.ts: took the new by-name `connect` handler wholesale (the actual fix). This uncovered a missing dependency: linkPresentationStore, introduced by unbackported #17875 and used (in code already present before #18275 on main) to preserve link presentation across a replace/displace. Ported src/types/linkPresentation.ts and src/stores/linkPresentationStore.ts (+ its unit test) from main, and added the missing `const linkPresentationStore = useLinkPresentationStore()` wiring that #18275's diff never touched because it already existed upstream of the cherry-pick's base. - graphMutations.test.ts: same missing-dependency shape, but for the test file the only pre-existing usages of linkPresentationStore live in other unbackported PRs' test blocks that aren't part of this branch, so the import ended up unused; removed it. - Checked open backport PRs against cloud/1.54 stacking on the same files (#18475, #18473, #18418, #18411, #18370, #18367, #18355, #18351): none of them are merged into cloud/1.54 yet, so no additional stacking conflicts applied. Verification: pnpm typecheck clean; pnpm vitest run on the directly relevant suites (graphMutations.test.ts, dynamicWidgets.test.ts, linkStore.test.ts, nodeDataStore.test.ts, linkPresentationStore.test.ts, crdtSession.test.ts, agentNodeMaterializer.multiAutogrow.test.ts) is 209 passed / 1 expected-fail; eslint and oxlint clean on all changed files.
…ss multiple autogrow groups (#18479) Backport of #18275 to `cloud/1.54`. Manual backport: the automated backport bot hit cherry-pick conflicts and requested a manual one. ## Conflict resolution notes - `browser_tests/fixtures/agentConversationFixture.ts`: dropped from this backport. The file doesn't exist on `cloud/1.54` (added by the still-unbackported #17875) and nothing on this branch imports it, including the new `agentCrdtMultiAutogrowRealign.spec.ts`. - `src/lib/litegraph/src/LGraphCanvas.ts` (`selectItems`): kept `cloud/1.54`'s existing body. The only diff here was an unrelated `Array.from` -> spread refactor picked up as context noise from #17048's `ownsSelectable` filter, which also isn't on `cloud/1.54`. - `src/core/graph/widgets/dynamicWidgets.ts`, `AgentPanelRoot.vue`: additive conflicts, took the incoming side. Dropped an incoming `useSettingStore` import in `AgentPanelRoot.vue` that belonged to a separate, unbackported PR (#17730) and was unused on this branch. - `src/workbench/extensions/agent/crdt/graphMutations.ts`: took the new by-name `connect` handler wholesale (the actual fix). This uncovered a missing dependency: `linkPresentationStore`, introduced by unbackported #17875 and used (in code already present before #18275 on `main`) to preserve link presentation across a replace/displace. Ported `src/types/linkPresentation.ts` and `src/stores/linkPresentationStore.ts` (+ its unit test) from `main`, and added the missing `const linkPresentationStore = useLinkPresentationStore()` wiring that #18275's diff never touched because it already existed upstream of the cherry-pick's base. - `graphMutations.test.ts`: same missing-dependency shape, but for the test file the only pre-existing usages of `linkPresentationStore` live in other unbackported PRs' test blocks that aren't part of this branch, so the import ended up unused; removed it. - Checked open backport PRs against `cloud/1.54` stacking on the same files (#18475, #18473, #18418, #18411, #18370, #18367, #18355, #18351): none of them are merged into `cloud/1.54` yet, so no additional stacking conflicts applied. ## Verification - `pnpm typecheck`: clean - `pnpm vitest run` on the directly relevant suites (`graphMutations.test.ts`, `dynamicWidgets.test.ts`, `linkStore.test.ts`, `nodeDataStore.test.ts`, `linkPresentationStore.test.ts`, `crdtSession.test.ts`, `agentNodeMaterializer.multiAutogrow.test.ts`): 209 passed, 1 expected fail - `eslint` / `oxlint` on all changed files: clean 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv --- _Generated by [Claude Code](https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv)_ --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Requested via Slack thread
Manual backport of #18324 to
cloud/1.54. This target was never attempted by the automatedpr-backport.yamlbot: it errored out after processingcore/1.53andcloud/1.53and never reachedcore/1.54orcloud/1.54, despite #18324 carrying thecloud/1.54label.What the original PR fixed
setValueinuseStringWidget.ts'saddMultilineWidget()closed over the outerwidgetconst to readwidget.options, butnode.addDOMWidget(...)can invokesetValuesynchronously (while restoring a previously saved value during workflow load) before theconst widget = node.addDOMWidget(...)assignment completes. Readingwidget.optionsat that point threw aReferenceErrorfrom the temporal dead zone (TDZ), crashing the app when loading a workflow with a saved multiline STRING widget value.The fix hoists the widget's
optionsobject into its ownwidgetOptionsconst, declared and fully initialized beforeaddDOMWidgetis called, and hassetValuereference that instead of the outerwidgetbinding.Conflict resolution
Cherry-picking
eefd88f4f424803e102c367d296106ecd749d798(single-parent commit, plaingit cherry-pick) ontocloud/1.54auto-merged cleanly in bothuseStringWidget.tsanduseStringWidget.test.tswith no manual conflict resolution needed.Verification
useStringWidget.test.ts: 5/5 tests passpnpm typecheck: clean, no errorspnpm installsucceeded with no lockfile conflicts🤖 Generated with Claude Code
https://claude.ai/code/session_01KQEWS3P3LxaJx8jVvy5TUb
Generated by Claude Code