Repository navigation
Backport #18200 to cloud/1.54 - #19170
Conversation
Keep expanding prompt widgets usable when an image preview appears after generation. - Reserve preview height only for image nodes with expanding widgets. Image-only galleries keep their flexible sizing. - Remove the transient preview allowance when saving a user resize, avoiding repeated-generation size growth. - Turn the remaining expected failure from #18098 into a passing regression test. Preview height allocation and authored versus rendered node size. This fixes the reproduced prompt-collapse symptom, not every reported workflow-overwrite issue in [the Flux incident](https://linear.app/comfyorg/issue/PM-1303) and [its reproduction task](https://linear.app/comfyorg/issue/PM-1310). Those incidents and release acceptance remain open with the program completion owner. <details><summary>Full context for agent readers</summary> Validated on Node 26.8.2: five Flux repeated-generation browser cases plus the existing image-grid vertical/horizontal resize case; 22 LGraphNode component tests; main/browser typechecks; targeted lint/format and commit hooks. The parent independently repeated all six browser cases and inspected the after-second-generation screenshot. The initial broad preview allocation failed image-grid resizing and was corrected before publication. The preview allowance is 220px minimum image height + 8px preview margin + 4px content gap. It applies only when the widget registry says a rendered widget expands. No backend or persisted workflow schema changes. Tracking: program task claude-handoff-9 retains the original incident, stale-document overwrite discrimination and core/1.54 plus cloud/1.54 qualification. Backport labels require independent release-target qualification; this source PR alone is not release completion. </details> (cherry picked from commit a7f3773) (cherry picked from commit e476187b6e615d98a9bcab4d23d254d3423b35c2)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T03:31:07.928Z",
"gitSha": "e4690b05462a5930666ffb61825ad3b5f307ff6d",
"branch": "christian-byrne/backport-18200-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2116.639999999961,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.510000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.331,
"heapDeltaBytes": 6836864,
"heapUsedBytes": 77168660,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.532000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2023.471000000029,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.458,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.447,
"heapDeltaBytes": 10003680,
"heapUsedBytes": 80789728,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.9090000000000025,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1738.0929999999921,
"styleRecalcs": 75,
"styleRecalcDurationMs": 23.523000000000003,
"layouts": 14,
"layoutDurationMs": 3.568,
"taskDurationMs": 702.3000000000001,
"heapDeltaBytes": -4213740,
"heapUsedBytes": 67176012,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 117.26700000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.5289999999895,
"styleRecalcs": 74,
"styleRecalcDurationMs": 22.954999999999995,
"layouts": 14,
"layoutDurationMs": 3.437,
"taskDurationMs": 696.229,
"heapDeltaBytes": 12590336,
"heapUsedBytes": 83677304,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 116.689,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.0940000000155,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.749,
"layouts": 6,
"layoutDurationMs": 0.941,
"taskDurationMs": 303.624,
"heapDeltaBytes": 4637700,
"heapUsedBytes": 75986548,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.361,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.7930000000142,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.886000000000001,
"layouts": 6,
"layoutDurationMs": 0.913,
"taskDurationMs": 294.55899999999997,
"heapDeltaBytes": 4688596,
"heapUsedBytes": 75008528,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.438,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 523.3870000000138,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.752999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.0249999999999,
"heapDeltaBytes": 18731712,
"heapUsedBytes": 89234564,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 126.29600000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 525.5029999999579,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.06300000000005,
"heapDeltaBytes": -7696560,
"heapUsedBytes": 62892300,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 124.996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2008.312999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.466999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.7760000000001,
"heapDeltaBytes": 4425300,
"heapUsedBytes": 80923292,
"domNodes": -278,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 34.82900000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.1149999999243,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.598000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.0029999999999,
"heapDeltaBytes": 4199220,
"heapUsedBytes": 81120852,
"domNodes": -281,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 30.15299999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2142.037000000016,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.328000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1328.9489999999998,
"heapDeltaBytes": 20101856,
"heapUsedBytes": 86342316,
"domNodes": 6,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 659.0109999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2140.2930000000424,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.248,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1296.337,
"heapDeltaBytes": 19993560,
"heapUsedBytes": 86118056,
"domNodes": -275,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 629.2099999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3218.988999999965,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.474,
"layouts": 60,
"layoutDurationMs": 12.181,
"taskDurationMs": 1477.8219999999997,
"heapDeltaBytes": -3349812,
"heapUsedBytes": 75740496,
"domNodes": -291,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 637.7710000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3251.410000000078,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.535,
"layouts": 60,
"layoutDurationMs": 12.116999999999999,
"taskDurationMs": 1469.6429999999998,
"heapDeltaBytes": -2971536,
"heapUsedBytes": 76069220,
"domNodes": -282,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 635.8470000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2244.3309999999883,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.9540000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1565.7549999999999,
"heapDeltaBytes": 21557840,
"heapUsedBytes": 87757208,
"domNodes": -277,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 768.6659999999999,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2446.4530000000195,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.205999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1701.8939999999998,
"heapDeltaBytes": -5708104,
"heapUsedBytes": 75856608,
"domNodes": -253,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 841.366,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.8460000000255,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.7779999999999,
"heapDeltaBytes": 7459972,
"heapUsedBytes": 86059788,
"domNodes": -268,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 28.857000000000006,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.3399999999483,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.357999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.6870000000001,
"heapDeltaBytes": 8033000,
"heapUsedBytes": 86740068,
"domNodes": -270,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 32.617999999999995,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 538.0710000000022,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.538000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.241,
"heapDeltaBytes": 14164268,
"heapUsedBytes": 80170892,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 112.335,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.1470000000372,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.542000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.96999999999997,
"heapDeltaBytes": 14835464,
"heapUsedBytes": 88253936,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 113.443,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.4479999999912,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.13100000000003,
"heapDeltaBytes": -5937168,
"heapUsedBytes": 67225220,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.304000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.4859999999953,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7219999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.36600000000004,
"heapDeltaBytes": 1863820,
"heapUsedBytes": 75356792,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.43,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.4599999999982,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.531999999999996,
"layouts": 18,
"layoutDurationMs": 4.383,
"taskDurationMs": 670.891,
"heapDeltaBytes": 1534268,
"heapUsedBytes": 74190608,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 87.535,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.4820000000318,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.189999999999998,
"layouts": 18,
"layoutDurationMs": 4.223,
"taskDurationMs": 702.093,
"heapDeltaBytes": -6971332,
"heapUsedBytes": 66559456,
"domNodes": -294,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 90.847,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.6089999999786,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.426000000000005,
"layouts": 15,
"layoutDurationMs": 11.514000000000001,
"taskDurationMs": 716.7330000000001,
"heapDeltaBytes": 22037440,
"heapUsedBytes": 105565648,
"domNodes": 13831,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 22.691000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 97,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.909999999963,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.737,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4741.6900000000005,
"heapDeltaBytes": 1140468,
"heapUsedBytes": 77748792,
"domNodes": -275,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2173.801,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8295.323999999937,
"styleRecalcs": 248,
"styleRecalcDurationMs": 42.972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4816.616,
"heapDeltaBytes": 13394264,
"heapUsedBytes": 89796316,
"domNodes": -271,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 2149.195,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15053.750000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14570.426,
"heapDeltaBytes": -49001732,
"heapUsedBytes": 183126056,
"domNodes": -8068,
"jsHeapTotalBytes": -16232448,
"scriptDurationMs": 229.412,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15140.269999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14694.007000000001,
"heapDeltaBytes": -34691240,
"heapUsedBytes": 180568576,
"domNodes": -8068,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 239.876,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17484.207999999966,
"styleRecalcs": 125,
"styleRecalcDurationMs": 15.668000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17306.443000000003,
"heapDeltaBytes": -28365480,
"heapUsedBytes": 189988508,
"domNodes": -8146,
"jsHeapTotalBytes": -11599872,
"scriptDurationMs": 760.957,
"eventListeners": -14933,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18095.257999999943,
"styleRecalcs": 128,
"styleRecalcDurationMs": 17.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17894.563000000002,
"heapDeltaBytes": -33903792,
"heapUsedBytes": 185124300,
"domNodes": -8068,
"jsHeapTotalBytes": -10481664,
"scriptDurationMs": 778.6229999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5382.337000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.98300000000001,
"layouts": 20,
"layoutDurationMs": 22.130999999999997,
"taskDurationMs": 5307.996999999999,
"heapDeltaBytes": -47945252,
"heapUsedBytes": 181802872,
"domNodes": -8068,
"jsHeapTotalBytes": 10313728,
"scriptDurationMs": 94.828,
"eventListeners": -14931,
"totalBlockingTimeMs": 209,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5448.428999999919,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.80100000000003,
"layouts": 20,
"layoutDurationMs": 28.75499999999999,
"taskDurationMs": 5375.19,
"heapDeltaBytes": -53888028,
"heapUsedBytes": 177684824,
"domNodes": -8101,
"jsHeapTotalBytes": 5189632,
"scriptDurationMs": 93.98899999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 413,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7420.917999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7268.0740000000005,
"heapDeltaBytes": 14874740,
"heapUsedBytes": 180370344,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 112.72299999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7447.671000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7333.639,
"heapDeltaBytes": -6243456,
"heapUsedBytes": 190711612,
"domNodes": 0,
"jsHeapTotalBytes": -23855104,
"scriptDurationMs": 111.70299999999995,
"eventListeners": 18,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 449.23,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.561000000000003,
"layouts": 4,
"layoutDurationMs": 1.571,
"taskDurationMs": 93.73299999999999,
"heapDeltaBytes": 4954004,
"heapUsedBytes": 73210728,
"domNodes": 152,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.519,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 82.41299999997409,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.540000000000001,
"layouts": 2,
"layoutDurationMs": 0.687,
"taskDurationMs": 54.065000000000005,
"heapDeltaBytes": 3005980,
"heapUsedBytes": 67737004,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.589,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 20569fb | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19170 +/- ##
=============================================
Coverage ? 83.96%
=============================================
Files ? 2119
Lines ? 126225
Branches ? 34155
=============================================
Hits ? 105989
Misses ? 20059
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Self-review complete. This is the same target-native adaptation as #19169 on cloud/1.54. The only conflict was the older test fixture API; production behavior matches #18200. Local focused tests, typecheck, and formatting passed on the core-equivalent implementation; cloud CI provides the branch-specific black-box gate. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 3 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
| width: Math.max(result.size.width, MIN_NODE_WIDTH), | ||
| height: removeNodeTitleHeight(result.size.height) | ||
| height: | ||
| removeNodeTitleHeight(result.size.height) - imagePreviewGrowth.value |
There was a problem hiding this comment.
🟠 High — useNodeResize derives result.size.height from resizeStartSize captured once at pointerdown, but this subtracts the reactive imagePreviewGrowth read at pointermove time, so the two can describe different layout states. If outputs arrive or clear mid-drag (routine when a generation finishes while the user is resizing), the persisted height is off by exactly IMAGE_PREVIEW_HEIGHT_RESERVE and that wrong value is written to the layout store and serialized into the workflow. Latch the reserve in effect at pointerdown, or carry the reserve used by startSize in the resize payload. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
| : { | ||
| '--node-width': `${size.value.width}px`, | ||
| '--node-height': `${size.value.height + LiteGraph.NODE_TITLE_HEIGHT}px` | ||
| '--node-height': `${size.value.height + LiteGraph.NODE_TITLE_HEIGHT + imagePreviewGrowth.value}px` |
There was a problem hiding this comment.
🟠 High — This inflates the rendered height while the layout store keeps the un-inflated value, silently changing what a stored height means: existing workflows whose saved size already accommodated a visible preview now render 232px taller, and a size authored in the Vue renderer loads 232px short in the Classic renderer, with no migration or marker to tell the two meanings apart. The divergence also feeds back — the shared ResizeObserver reports the inflated height through reportContentSize, so LGraphNode.renderingSize becomes authored + 232 and any read-modify-write of it (e.g. node.setSize([...node.renderingSize])) bakes the reserve into the authored size and compounds it. Raised by 4 of 8 reviewers (gpt-5.6-sol-max edge-case, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).
| { | ||
| width: Math.max(result.size.width, MIN_NODE_WIDTH), | ||
| height: removeNodeTitleHeight(result.size.height) | ||
| height: |
There was a problem hiding this comment.
🟡 Medium — The width is floored with Math.max(result.size.width, MIN_NODE_WIDTH) but the height gets no floor after the subtraction, and removeNodeTitleHeight's own Math.max(0, ...) is applied before it. Any state where the incoming height was measured without the preview contributing (the mid-drag flip above, or a degenerate getBoundingClientRect().height) produces a zero or negative authored height that propagates verbatim into the layout-store rect, the spatial index, and serialize(). Clamp the subtracted result to a sane minimum. Raised by 4 of 8 reviewers (gemini-3.1-pro edge-case, claude-opus-5-thinking-max edge-case, gemini-3.1-pro adversarial, claude-opus-5-thinking-max adversarial).
| ) | ||
| const hasExpandingWidget = computed(() => | ||
| processedWidgets.value.some( | ||
| (widget) => widget.visible && shouldExpand(widget.simplified.type) |
There was a problem hiding this comment.
🟡 Medium — WidgetGrid makes a row expandable when shouldExpand(widget.simplified.type) || widget.hasLayoutSize, but this predicate checks only shouldExpand. A node whose only expanding row qualifies via hasLayoutSize — any DOM/custom widget implementing computeLayoutSize, common in custom nodes — still gets the flex: 1 grid but neither the height reserve nor shrink-0, so the preview squeezes it exactly as before. Use the same predicate as WidgetGrid, keeping the visibility filter. Raised by 4 of 8 reviewers (gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial).
| const { position, size, zIndex } = useNodeLayout(() => nodeData.id) | ||
|
|
||
| const imagePreviewGrowth = computed(() => | ||
| nodeMedia.value?.type === 'image' && hasExpandingWidget.value |
There was a problem hiding this comment.
🟡 Medium — The reserve keys off nodeMedia alone, but the same block renders one NodeContent per promotedPreviews entry plus LivePreview, each carrying the identical 220px floor. nodeMedia is forced to undefined for SubgraphNode while promotedPreviews is non-empty only for SubgraphNode, so a subgraph with a promoted image preview and an expanding widget can never satisfy this condition and still reproduces the squeeze; VideoPreview/LivePreview are uncovered too (and still use a literal min-h-55 that can now drift from IMAGE_PREVIEW_CONTENT_MIN_HEIGHT), and N previews need N reserves rather than one. Raised by 5 of 8 reviewers (gpt-5.6-sol-max edge-case, kimi-k3-max edge-case, gemini-3.1-pro edge-case, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial).
| }) | ||
|
|
||
| const hasRenderableWidgets = computed(() => renderedWidgetIds.value.length > 0) | ||
| const { processedWidgets } = useProcessedWidgets( |
There was a problem hiding this comment.
🟢 Low — This repeats the useProcessedWidgets(() => nodeData, () => renderedWidgetIds) call the child NodeWidgets already makes with identical inputs, so every node runs the full slot-metadata/link-lookup/promoted-source/tooltip-allocation pass twice on each invalidation of widget values, link state, or execution errors — a real per-frame cost on large graphs for what is only a boolean. Derive the flag from the widget ids directly, or hoist the single computation and pass it down. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
|
Merge judgment: the full sharded browser suite, including the Flux.2 prompt-height regression changed by this PR, passed. The cloud-project gate failed twice only on the unrelated PM-1135 asset-grid screenshot (134 pixels / 0.01%, unchanged by this node-preview-only diff); the second run otherwise passed 277 tests. Core-equivalent #19169 is already merged. Treating that release-baseline mismatch as non-blocking for this targeted cloud/1.54 backport. |
Backports #18200 (preserves prompt height beside generated image previews) to cloud/1.54.
The automated backport conflicted only in the release branch test file because 1.54 uses the older widget render-state API. This adapts that fixture without changing production behavior.
Validation: