Repository navigation
[backport core/1.54] fix: preserve prompt height beside generated image previews (#18200) - #19179
Merged
Merged
Conversation
Keep expanding prompt widgets usable when an image preview appears after generation. - Reserve preview height only for image nodes with expanding widgets. Image-only galleries keep their flexible sizing. - Remove the transient preview allowance when saving a user resize, avoiding repeated-generation size growth. - Turn the remaining expected failure from #18098 into a passing regression test. Preview height allocation and authored versus rendered node size. This fixes the reproduced prompt-collapse symptom, not every reported workflow-overwrite issue in [the Flux incident](https://linear.app/comfyorg/issue/PM-1303) and [its reproduction task](https://linear.app/comfyorg/issue/PM-1310). Those incidents and release acceptance remain open with the program completion owner. <details><summary>Full context for agent readers</summary> Validated on Node 26.8.2: five Flux repeated-generation browser cases plus the existing image-grid vertical/horizontal resize case; 22 LGraphNode component tests; main/browser typechecks; targeted lint/format and commit hooks. The parent independently repeated all six browser cases and inspected the after-second-generation screenshot. The initial broad preview allocation failed image-grid resizing and was corrected before publication. The preview allowance is 220px minimum image height + 8px preview margin + 4px content gap. It applies only when the widget registry says a rendered widget expands. No backend or persisted workflow schema changes. Tracking: program task claude-handoff-9 retains the original incident, stale-document overwrite discrimination and core/1.54 plus cloud/1.54 qualification. Backport labels require independent release-target qualification; this source PR alone is not release completion. </details>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
|
…o-core-1.54 # Conflicts: # src/renderer/extensions/vueNodes/components/LGraphNode.test.ts
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport #18200 to the 1.54 release line.
Validation
vuefire; hosted CI is the release-native validation gate.Source: #18200