Skip to content

[backport cloud/1.54] fix: preserve prompt height beside generated image previews (#18200) - #19180

Merged
christian-byrne merged 5 commits into
cloud/1.54from
backport-18200-to-cloud-1.54
Sep 28, 2026
Merged

christian-byrne merged 5 commits into
cloud/1.54from
backport-18200-to-cloud-1.54

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Backport #18200 to the 1.54 release line.

Validation

  • Production changes cherry-picked cleanly.
  • Resolved the sole test conflict by preserving the 1.54 graph traversal mock while retaining the new resize callback assertions.
  • Local focused test collection is blocked by the borrowed dependency tree missing vuefire; hosted CI is the release-native validation gate.

Source: #18200

Keep expanding prompt widgets usable when an image preview appears after
generation.

- Reserve preview height only for image nodes with expanding widgets.
Image-only galleries keep their flexible sizing.
- Remove the transient preview allowance when saving a user resize,
avoiding repeated-generation size growth.
- Turn the remaining expected failure from
#18098 into a passing
regression test.

Preview height allocation and authored versus rendered node size. This
fixes the reproduced prompt-collapse symptom, not every reported
workflow-overwrite issue in [the Flux
incident](https://linear.app/comfyorg/issue/PM-1303) and [its
reproduction task](https://linear.app/comfyorg/issue/PM-1310). Those
incidents and release acceptance remain open with the program completion
owner.

<details><summary>Full context for agent readers</summary>

Validated on Node 26.8.2: five Flux repeated-generation browser cases
plus the existing image-grid vertical/horizontal resize case; 22
LGraphNode component tests; main/browser typechecks; targeted
lint/format and commit hooks. The parent independently repeated all six
browser cases and inspected the after-second-generation screenshot. The
initial broad preview allocation failed image-grid resizing and was
corrected before publication.

The preview allowance is 220px minimum image height + 8px preview margin
+ 4px content gap. It applies only when the widget registry says a
rendered widget expands. No backend or persisted workflow schema
changes.

Tracking: program task claude-handoff-9 retains the original incident,
stale-document overwrite discrimination and core/1.54 plus cloud/1.54
qualification. Backport labels require independent release-target
qualification; this source PR alone is not release completion.

</details>
@christian-byrne
christian-byrne requested a review from a team as a code owner September 28, 2026 03:39
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 28, 2026 4:25am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 4:25am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: fbdd4616-b30d-461e-a850-36de591b5321

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 21 passed, 0 failed

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 04:06:19 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing as duplicate: the intended backport already merged in #19170.

@christian-byrne
christian-byrne deleted the backport-18200-to-cloud-1.54 branch September 28, 2026 04:11
@christian-byrne
christian-byrne enabled auto-merge (squash) September 28, 2026 04:25
@christian-byrne
christian-byrne merged commit ba7b4ac into cloud/1.54 Sep 28, 2026
63 of 64 checks passed

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — bbd93ae5 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants