Repository navigation
[backport cloud/1.54] fix: preserve prompt height beside generated image previews (#18200) - #19180
Conversation
Keep expanding prompt widgets usable when an image preview appears after generation. - Reserve preview height only for image nodes with expanding widgets. Image-only galleries keep their flexible sizing. - Remove the transient preview allowance when saving a user resize, avoiding repeated-generation size growth. - Turn the remaining expected failure from #18098 into a passing regression test. Preview height allocation and authored versus rendered node size. This fixes the reproduced prompt-collapse symptom, not every reported workflow-overwrite issue in [the Flux incident](https://linear.app/comfyorg/issue/PM-1303) and [its reproduction task](https://linear.app/comfyorg/issue/PM-1310). Those incidents and release acceptance remain open with the program completion owner. <details><summary>Full context for agent readers</summary> Validated on Node 26.8.2: five Flux repeated-generation browser cases plus the existing image-grid vertical/horizontal resize case; 22 LGraphNode component tests; main/browser typechecks; targeted lint/format and commit hooks. The parent independently repeated all six browser cases and inspected the after-second-generation screenshot. The initial broad preview allocation failed image-grid resizing and was corrected before publication. The preview allowance is 220px minimum image height + 8px preview margin + 4px content gap. It applies only when the widget registry says a rendered widget expands. No backend or persisted workflow schema changes. Tracking: program task claude-handoff-9 retains the original incident, stale-document overwrite discrimination and core/1.54 plus cloud/1.54 qualification. Backport labels require independent release-target qualification; this source PR alone is not release completion. </details>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 21 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
|
|
Closing as duplicate: the intended backport already merged in #19170. |
Summary
Backport #18200 to the 1.54 release line.
Validation
vuefire; hosted CI is the release-native validation gate.Source: #18200