Repository navigation
Backport #18200 to core/1.54 - #19169
Conversation
Keep expanding prompt widgets usable when an image preview appears after generation. - Reserve preview height only for image nodes with expanding widgets. Image-only galleries keep their flexible sizing. - Remove the transient preview allowance when saving a user resize, avoiding repeated-generation size growth. - Turn the remaining expected failure from #18098 into a passing regression test. Preview height allocation and authored versus rendered node size. This fixes the reproduced prompt-collapse symptom, not every reported workflow-overwrite issue in [the Flux incident](https://linear.app/comfyorg/issue/PM-1303) and [its reproduction task](https://linear.app/comfyorg/issue/PM-1310). Those incidents and release acceptance remain open with the program completion owner. <details><summary>Full context for agent readers</summary> Validated on Node 26.8.2: five Flux repeated-generation browser cases plus the existing image-grid vertical/horizontal resize case; 22 LGraphNode component tests; main/browser typechecks; targeted lint/format and commit hooks. The parent independently repeated all six browser cases and inspected the after-second-generation screenshot. The initial broad preview allocation failed image-grid resizing and was corrected before publication. The preview allowance is 220px minimum image height + 8px preview margin + 4px content gap. It applies only when the widget registry says a rendered widget expands. No backend or persisted workflow schema changes. Tracking: program task claude-handoff-9 retains the original incident, stale-document overwrite discrimination and core/1.54 plus cloud/1.54 qualification. Backport labels require independent release-target qualification; this source PR alone is not release completion. </details> (cherry picked from commit a7f3773)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1959 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-28T03:33:16.226Z",
"gitSha": "3a9448e5467a436205a5d3439a0381ec13c18fe7",
"branch": "christian-byrne/backport-18200-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2069.402000000025,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.703999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.777,
"heapDeltaBytes": -11136748,
"heapUsedBytes": 59133696,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 13.086,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2086.301999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.573999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.555,
"heapDeltaBytes": -7031852,
"heapUsedBytes": 64241376,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 14.435,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2132.8080000000114,
"styleRecalcs": 79,
"styleRecalcDurationMs": 38.094,
"layouts": 14,
"layoutDurationMs": 4.674,
"taskDurationMs": 1096.9489999999998,
"heapDeltaBytes": -5456268,
"heapUsedBytes": 64979284,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 191.789,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2001.0370000001103,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.949000000000005,
"layouts": 14,
"layoutDurationMs": 4.462,
"taskDurationMs": 1021.483,
"heapDeltaBytes": -3388196,
"heapUsedBytes": 66964392,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 178.10999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.0279999999802,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.549,
"layouts": 6,
"layoutDurationMs": 1.097,
"taskDurationMs": 440.211,
"heapDeltaBytes": 4676232,
"heapUsedBytes": 75588844,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 16.412999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.2980000000862,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.106,
"layouts": 6,
"layoutDurationMs": 1.3930000000000002,
"taskDurationMs": 482.689,
"heapDeltaBytes": 4215528,
"heapUsedBytes": 74776944,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 17.992,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 733.6329999999975,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.688999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.40200000000004,
"heapDeltaBytes": -7557856,
"heapUsedBytes": 63596844,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 179.77599999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 747.8580000000647,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.862999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.5369999999999,
"heapDeltaBytes": 17784988,
"heapUsedBytes": 88927812,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 182.78100000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2039.7909999999797,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.792000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.0799999999999,
"heapDeltaBytes": -16392748,
"heapUsedBytes": 87424212,
"domNodes": -268,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 42.711,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.3139999999194,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.6899999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 819.8449999999999,
"heapDeltaBytes": -15866052,
"heapUsedBytes": 87923208,
"domNodes": -272,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 49.07,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2949.87100000003,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.670999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.8890000000001,
"heapDeltaBytes": 12865860,
"heapUsedBytes": 90088676,
"domNodes": -275,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 923.678,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3152.4500000000444,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.874000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1972.367,
"heapDeltaBytes": 15876796,
"heapUsedBytes": 93413116,
"domNodes": -273,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 959.1270000000001,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3954.5699999999897,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.069000000000003,
"layouts": 60,
"layoutDurationMs": 13.424,
"taskDurationMs": 1909.104,
"heapDeltaBytes": 11769088,
"heapUsedBytes": 80311420,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 843.7750000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 4112.275999999952,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.879999999999999,
"layouts": 60,
"layoutDurationMs": 13.537,
"taskDurationMs": 2060.1440000000002,
"heapDeltaBytes": -2802328,
"heapUsedBytes": 76049812,
"domNodes": -283,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 912.5150000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3201.1620000000107,
"styleRecalcs": 41,
"styleRecalcDurationMs": 7.034999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2218.761,
"heapDeltaBytes": 1590240,
"heapUsedBytes": 82191060,
"domNodes": -285,
"jsHeapTotalBytes": 53248,
"scriptDurationMs": 1057.345,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3266.9990000000553,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.523999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2223.8230000000003,
"heapDeltaBytes": 7636044,
"heapUsedBytes": 88247876,
"domNodes": -287,
"jsHeapTotalBytes": -471040,
"scriptDurationMs": 1048.2520000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2074.662999999987,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.814,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 768.3709999999999,
"heapDeltaBytes": 5647044,
"heapUsedBytes": 83253136,
"domNodes": -282,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 39.48799999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.2750000000124,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.9740000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.677,
"heapDeltaBytes": 21800536,
"heapUsedBytes": 87951184,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.054,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 706.8550000000187,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.299,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.69300000000004,
"heapDeltaBytes": 14255748,
"heapUsedBytes": 80071868,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.107,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 717.155000000048,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.040999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.54499999999996,
"heapDeltaBytes": 15122500,
"heapUsedBytes": 88463604,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.443,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2031.9240000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.496,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.668,
"heapDeltaBytes": -4998812,
"heapUsedBytes": 68403372,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 12.781999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2068.087999999989,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.584,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.6080000000001,
"heapDeltaBytes": -7333504,
"heapUsedBytes": 65240036,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.869000000000003,
"eventListeners": -244,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.0370000000348,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.827000000000005,
"layouts": 18,
"layoutDurationMs": 5.696,
"taskDurationMs": 935.081,
"heapDeltaBytes": 6834656,
"heapUsedBytes": 79898328,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 129.36999999999998,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1840.3599999999187,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.875,
"layouts": 18,
"layoutDurationMs": 5.912,
"taskDurationMs": 965.1279999999999,
"heapDeltaBytes": 8205324,
"heapUsedBytes": 81184976,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 126.24600000000002,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.6339999999836,
"styleRecalcs": 19,
"styleRecalcDurationMs": 34.944,
"layouts": 15,
"layoutDurationMs": 16.485000000000003,
"taskDurationMs": 1075.079,
"heapDeltaBytes": -6985844,
"heapUsedBytes": 83541040,
"domNodes": 13831,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 34.874999999999986,
"eventListeners": 2387,
"totalBlockingTimeMs": 163,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10029.26500000001,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.313,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6553.573,
"heapDeltaBytes": 13149896,
"heapUsedBytes": 89637232,
"domNodes": -269,
"jsHeapTotalBytes": -434176,
"scriptDurationMs": 2928.6020000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11167.552,
"styleRecalcs": 247,
"styleRecalcDurationMs": 41.647000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6951.332,
"heapDeltaBytes": 9394024,
"heapUsedBytes": 85347144,
"domNodes": -284,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 3131.405,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18253.02700000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17586.568,
"heapDeltaBytes": -60820024,
"heapUsedBytes": 177185836,
"domNodes": -8068,
"jsHeapTotalBytes": -27045888,
"scriptDurationMs": 379.189,
"eventListeners": -14931,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18546.883999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18005.532000000003,
"heapDeltaBytes": -53155352,
"heapUsedBytes": 181226616,
"domNodes": -8068,
"jsHeapTotalBytes": -14045184,
"scriptDurationMs": 332.208,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22767.75299999997,
"styleRecalcs": 173,
"styleRecalcDurationMs": 25.226000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22535.159,
"heapDeltaBytes": -60525160,
"heapUsedBytes": 179537116,
"domNodes": -8068,
"jsHeapTotalBytes": -18288640,
"scriptDurationMs": 1015.933,
"eventListeners": -14931,
"totalBlockingTimeMs": 168,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22934.210000000006,
"styleRecalcs": 171,
"styleRecalcDurationMs": 25.083999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22616.99,
"heapDeltaBytes": -46973712,
"heapUsedBytes": 172194292,
"domNodes": -8068,
"jsHeapTotalBytes": -6041600,
"scriptDurationMs": 1010.0170000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 175,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6637.455000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.08900000000003,
"layouts": 20,
"layoutDurationMs": 28.12400000000001,
"taskDurationMs": 6592.097999999999,
"heapDeltaBytes": -36447568,
"heapUsedBytes": 183301256,
"domNodes": -8068,
"jsHeapTotalBytes": 10678272,
"scriptDurationMs": 147.55400000000003,
"eventListeners": -14931,
"totalBlockingTimeMs": 518,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6708.356999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.37699999999998,
"layouts": 20,
"layoutDurationMs": 26.90899999999999,
"taskDurationMs": 6599.546000000001,
"heapDeltaBytes": -37494684,
"heapUsedBytes": 182262896,
"domNodes": -8068,
"jsHeapTotalBytes": 16834560,
"scriptDurationMs": 134.353,
"eventListeners": -14927,
"totalBlockingTimeMs": 570,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9287.300999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8976.849000000002,
"heapDeltaBytes": 24297480,
"heapUsedBytes": 181843852,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 165.97799999999995,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9227.596999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8957.144999999999,
"heapDeltaBytes": 4140928,
"heapUsedBytes": 189087540,
"domNodes": 0,
"jsHeapTotalBytes": -28311552,
"scriptDurationMs": 153.78500000000005,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 489.8350000000278,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.32,
"layouts": 3,
"layoutDurationMs": 1.4649999999999999,
"taskDurationMs": 132.54300000000003,
"heapDeltaBytes": 4999280,
"heapUsedBytes": 74198940,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.815,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 128.9440000000468,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.444000000000003,
"layouts": 2,
"layoutDurationMs": 1.002,
"taskDurationMs": 83.80300000000001,
"heapDeltaBytes": 2996840,
"heapUsedBytes": 72327508,
"domNodes": 130,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.263000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19169 +/- ##
=============================================
- Coverage 83.85% 83.82% -0.03%
=============================================
Files 2110 2111 +1
Lines 125247 125401 +154
Branches 31748 33652 +1904
=============================================
+ Hits 105022 105121 +99
- Misses 20047 20102 +55
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Self-review complete. The release adaptation changes only the 1.54 test fixture API; production code matches #18200. Local evidence: 24 focused tests, typecheck, formatting, and pre-push dependency checks passed. The existing Flux.2 browser regression remains in the diff. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| width: Math.max(result.size.width, MIN_NODE_WIDTH), | ||
| height: removeNodeTitleHeight(result.size.height) | ||
| height: | ||
| removeNodeTitleHeight(result.size.height) - imagePreviewGrowth.value |
There was a problem hiding this comment.
🟠 High — removeNodeTitleHeight() clamps its result to >= 0, but the 232px reserve is subtracted after that clamp and neither resizeNodeLayout nor layoutStore.handleResizeNode clamps, so a negative height can be written straight into the layout rect and serialized into the workflow's size. Width already has Math.max(result.size.width, MIN_NODE_WIDTH); height needs the symmetric floor. Reachable whenever the measured min-content height lacks the preview while imagePreviewGrowth is still 232 — e.g. NodeContent's onErrorCaptured boundary swaps ImagePreview for the error div while nodeMedia.type stays 'image'. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case).
| { | ||
| width: Math.max(result.size.width, MIN_NODE_WIDTH), | ||
| height: removeNodeTitleHeight(result.size.height) | ||
| height: |
There was a problem hiding this comment.
🟠 High — useNodeResize captures resizeStartSize once at pointerdown from getBoundingClientRect(), so the reserve is frozen into that baseline, while this callback reads imagePreviewGrowth.value fresh on every pointermove. An output arriving or being cleared mid-drag (websocket completion, hideOutputImages toggle, a new execution starting) flips the reserve between 0 and 232 against the stale baseline, so the next pointermove persists a height off by the full reserve, and the effect compounds across preview cycles. Freeze the growth value at drag start, or re-measure the element when the reserve changes during an active resize. Raised by 5 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).
| :class=" | ||
| cn( | ||
| 'flex min-h-0 flex-col', | ||
| nodeMedia?.type === 'image' && hasExpandingWidget |
There was a problem hiding this comment.
🟡 Medium — Both this shrink-0 decision and imagePreviewGrowth key off nodeMedia alone, but this wrapper also renders every promotedPreviews entry through the same ImagePreview, and nodeMedia is undefined for SubgraphNode. A subgraph node with a promoted image preview plus an expanding widget therefore keeps flex-1 and gets no reserve, so the original collapse persists and resizing while the promoted preview is visible bakes the preview height into the stored size (min-content includes it, the reserve subtracts 0). Conversely, nodeMedia alongside N promoted previews turns the wrapper shrink-0 while reserving only one 220px block. Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| ) | ||
| const hasExpandingWidget = computed(() => | ||
| processedWidgets.value.some( | ||
| (widget) => widget.visible && shouldExpand(widget.simplified.type) |
There was a problem hiding this comment.
🟡 Medium — WidgetGrid grows a row when !isConvertedWidget(widget) && (shouldExpand(type) || widget.hasLayoutSize), filtered by shouldRenderRow, but this predicate checks only shouldExpand and filters on visible. A node whose only growing row comes from a DOM/custom widget's computeLayoutSize gets a growing grid with no reserve, reproducing exactly the squeeze this change is meant to fix; deriving both the grid rows and the reserve from one shared helper would stop the two predicates drifting. Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case).
| const { position, size, zIndex } = useNodeLayout(() => nodeData.id) | ||
|
|
||
| const imagePreviewGrowth = computed(() => | ||
| nodeMedia.value?.type === 'image' && hasExpandingWidget.value |
There was a problem hiding this comment.
🟡 Medium — The reserve is gated on type === 'image', yet VideoPreview.vue (min-h-55 size-full) and LivePreview.vue (min-h-55 w-full flex-1) impose the identical 220px minimum. Video outputs and the live preview that renders during every execution stay unreserved flex-1 siblings of the widget grid, so the collapse remains on those paths — including the transient-progress path the e2e test header now claims to guard — and resizing while a video preview is shown stores a height that includes the transient preview. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case, gpt-5.6-sol-max adversarial).
| }) | ||
|
|
||
| const hasRenderableWidgets = computed(() => renderedWidgetIds.value.length > 0) | ||
| const { processedWidgets } = useProcessedWidgets( |
There was a problem hiding this comment.
🟡 Medium — NodeWidgets.vue already calls useProcessedWidgets with the same nodeData/widgetIds, so this adds a second identical instance of one of the heaviest computations in the app (five store lookups plus live-widget map and slot-metadata construction) to every node, and doubles the reactive dependency set so both copies recompute on any execution-error / missing-model / widget-value change. hasExpandingWidget only needs widget types, which can be read from widgetValueStore.getWidget(id) over renderedWidgetIds without building the render model. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
|
|
||
| const { position, size, zIndex } = useNodeLayout(() => nodeData.id) | ||
|
|
||
| const imagePreviewGrowth = computed(() => |
There was a problem hiding this comment.
🟢 Low — imagePreviewGrowth dereferences nodeMedia (~line 720) and hasExpandingWidget (~line 685), both const bindings declared hundreds of lines later; this works only because computed getters are lazy and nothing reads it during setup. Any future eager read — a watch with immediate, a synchronous .value access, or a refactor to a plain function — throws ReferenceError: Cannot access 'nodeMedia' before initialization at setup time, which onErrorCaptured cannot recover from, blanking the node. Move the declaration below its dependencies. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
| const { position, size, zIndex } = useNodeLayout(() => nodeData.id) | ||
|
|
||
| const imagePreviewGrowth = computed(() => | ||
| nodeMedia.value?.type === 'image' && hasExpandingWidget.value |
There was a problem hiding this comment.
🟢 Low — This condition is weaker than the one the preview actually renders under: ImagePreview is v-if="imageUrls.length > 0" and NodeContent additionally requires hasMedia, so a nodeMedia of type image whose urls array is empty or not yet resolved reserves 232px of empty space and feeds that same phantom reserve into the resize subtraction. Gate the reserve on the same non-empty-urls condition the preview uses. Raised by 1 of 8 reviewers (gemini-3.1-pro edge-case).
Backports #18200 (preserves prompt height beside generated image previews) to core/1.54.
The automated backport conflicted only in the release branch test file because 1.54 uses the older widget render-state API. This adapts that fixture without changing production behavior.
Validation: