Repository navigation
test(agent): refresh the two-turn wire cloud snapshot - #18168
Conversation
#17730 pinned the replay catalog and painted graph-activity chrome. The wire is unchanged; the 3182-pixel fail is the taller Vue nodes and SaveImage filename the pinned defs now project. Co-authored-by: ShihChi Huang <huge.huang+github@gmail.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2039 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 298 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T01:13:01.477Z",
"gitSha": "64b80e11fb73c2b0867f9580b28a6a00c45661d2",
"branch": "cursor/agent-wire-snapshot-56b2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.0919999999678,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.002999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.81600000000003,
"heapDeltaBytes": 6126172,
"heapUsedBytes": 72698244,
"domNodes": -257,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 7.713000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.0059999999667,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.347,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.38,
"heapDeltaBytes": 8844880,
"heapUsedBytes": 70832404,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.8770000000000024,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1813.1440000000794,
"styleRecalcs": 74,
"styleRecalcDurationMs": 24.816,
"layouts": 14,
"layoutDurationMs": 3.718,
"taskDurationMs": 798.421,
"heapDeltaBytes": 15429536,
"heapUsedBytes": 77120488,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 156.295,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1819.970000000012,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.047,
"layouts": 14,
"layoutDurationMs": 3.7880000000000003,
"taskDurationMs": 797.8850000000001,
"heapDeltaBytes": 5628364,
"heapUsedBytes": 67356828,
"domNodes": -263,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 156.07999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.7310000000716,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.614,
"layouts": 6,
"layoutDurationMs": 1.047,
"taskDurationMs": 313.483,
"heapDeltaBytes": 2184276,
"heapUsedBytes": 64160216,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.356,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.5889999999945,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.204,
"layouts": 6,
"layoutDurationMs": 1.112,
"taskDurationMs": 311.836,
"heapDeltaBytes": 2092968,
"heapUsedBytes": 64181876,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.584999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 612.7609999999777,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.751999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.758,
"heapDeltaBytes": 18133784,
"heapUsedBytes": 80068112,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 165.04100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 624.6229999999287,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.556999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.1809999999999,
"heapDeltaBytes": 17567536,
"heapUsedBytes": 79599732,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 164.786,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.4439999999504,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.3420000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.695,
"heapDeltaBytes": 3459892,
"heapUsedBytes": 82998780,
"domNodes": -251,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 27.54999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2019.6180000000368,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.305999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.8799999999999,
"heapDeltaBytes": 2960600,
"heapUsedBytes": 82449668,
"domNodes": -246,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 28.58000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2133.0310000000736,
"styleRecalcs": 63,
"styleRecalcDurationMs": 7.993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1497.795,
"heapDeltaBytes": 18656988,
"heapUsedBytes": 83137604,
"domNodes": 2,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 795.274,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2166.598000000022,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1514.374,
"heapDeltaBytes": 14788504,
"heapUsedBytes": 78902120,
"domNodes": 4,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 803.71,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3453.277000000071,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.363999999999997,
"layouts": 60,
"layoutDurationMs": 11.871,
"taskDurationMs": 1584.9039999999998,
"heapDeltaBytes": 8491516,
"heapUsedBytes": 73982568,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 762.9560000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3425.9450000000697,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.984000000000004,
"layouts": 60,
"layoutDurationMs": 12.152999999999999,
"taskDurationMs": 1621.6779999999999,
"heapDeltaBytes": 10248104,
"heapUsedBytes": 73730580,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 767.771,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3084.7420000000056,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.424999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1846.6239999999998,
"heapDeltaBytes": 20593292,
"heapUsedBytes": 86258548,
"domNodes": 2,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 977.518,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2975.738999999976,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.461,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1821.0970000000002,
"heapDeltaBytes": 18992708,
"heapUsedBytes": 84510400,
"domNodes": -258,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 955.817,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.8570000000964,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.3320000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.093,
"heapDeltaBytes": -4257880,
"heapUsedBytes": 83518292,
"domNodes": -252,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 28.643,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.38799999995,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.669000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.4089999999999,
"heapDeltaBytes": -4338328,
"heapUsedBytes": 83654804,
"domNodes": -252,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 28.704999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.4910000000091,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.243000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.892,
"heapDeltaBytes": 14224912,
"heapUsedBytes": 83705656,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.516,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.0970000000889,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.172,
"heapDeltaBytes": 13219376,
"heapUsedBytes": 76555716,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 140.931,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.4680000000508,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.071,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.98,
"heapDeltaBytes": -7082252,
"heapUsedBytes": 56068128,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.349,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.373000000077,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.604000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.09999999999997,
"heapDeltaBytes": 407544,
"heapUsedBytes": 62825420,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.582999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.475999999957,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.080999999999996,
"layouts": 18,
"layoutDurationMs": 4.307,
"taskDurationMs": 716.572,
"heapDeltaBytes": -1847652,
"heapUsedBytes": 60806440,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 95.67699999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.149999999976,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.698,
"layouts": 18,
"layoutDurationMs": 4.734,
"taskDurationMs": 727.515,
"heapDeltaBytes": -7303292,
"heapUsedBytes": 55868084,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 97.49400000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.7569999999832,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.263,
"layouts": 5,
"layoutDurationMs": 13.072999999999999,
"taskDurationMs": 856.1860000000001,
"heapDeltaBytes": -6628480,
"heapUsedBytes": 84400404,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 28.409000000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8232.017000000042,
"styleRecalcs": 246,
"styleRecalcDurationMs": 31.742,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5424.254,
"heapDeltaBytes": 11396672,
"heapUsedBytes": 75043168,
"domNodes": -251,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 2674.7810000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8350.385000000075,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.112,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5520.702,
"heapDeltaBytes": -13375988,
"heapUsedBytes": 66011496,
"domNodes": -251,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 2711.262,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15920.661999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14972.456,
"heapDeltaBytes": -42633144,
"heapUsedBytes": 180376208,
"domNodes": -8061,
"jsHeapTotalBytes": -9900032,
"scriptDurationMs": 226.72500000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16401.626999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15319.594,
"heapDeltaBytes": -60972884,
"heapUsedBytes": 174835196,
"domNodes": -8061,
"jsHeapTotalBytes": -17629184,
"scriptDurationMs": 259.23600000000005,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19770.894999999997,
"styleRecalcs": 163,
"styleRecalcDurationMs": 15.310999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19360.557999999997,
"heapDeltaBytes": -67718952,
"heapUsedBytes": 167098220,
"domNodes": -8061,
"jsHeapTotalBytes": -16785408,
"scriptDurationMs": 908.034,
"eventListeners": -14928,
"totalBlockingTimeMs": 61,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19484.931999999957,
"styleRecalcs": 163,
"styleRecalcDurationMs": 14.547000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19166.693,
"heapDeltaBytes": -19942536,
"heapUsedBytes": 189979512,
"domNodes": -8061,
"jsHeapTotalBytes": -12460032,
"scriptDurationMs": 851.495,
"eventListeners": -14928,
"totalBlockingTimeMs": 135,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5740.580000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 100.82199999999997,
"layouts": 20,
"layoutDurationMs": 28.506000000000018,
"taskDurationMs": 5619.47,
"heapDeltaBytes": -34177892,
"heapUsedBytes": 175747608,
"domNodes": -8061,
"jsHeapTotalBytes": 12775424,
"scriptDurationMs": 119.39999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 327,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4405.383000000029,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.78600000000003,
"layouts": 20,
"layoutDurationMs": 22.080000000000002,
"taskDurationMs": 4239.365000000001,
"heapDeltaBytes": -12533428,
"heapUsedBytes": 195981860,
"domNodes": -3063,
"jsHeapTotalBytes": 21454848,
"scriptDurationMs": 80.98599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 114,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8088.030000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7643.280000000001,
"heapDeltaBytes": -3490092,
"heapUsedBytes": 189382884,
"domNodes": 0,
"jsHeapTotalBytes": -28573696,
"scriptDurationMs": 114.57700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8184.879000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7673.660999999999,
"heapDeltaBytes": -3601324,
"heapUsedBytes": 187502596,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 153.83899999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 460.98800000004303,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.898000000000003,
"layouts": 4,
"layoutDurationMs": 2.045,
"taskDurationMs": 128.94100000000003,
"heapDeltaBytes": 5230936,
"heapUsedBytes": 66901392,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.786999999999995,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 466.18899999998575,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.052999999999997,
"layouts": 3,
"layoutDurationMs": 1.274,
"taskDurationMs": 114.082,
"heapDeltaBytes": 4989372,
"heapUsedBytes": 66556756,
"domNodes": 146,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.206999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Ports the golden refresh from #18168 so the cloud Playwright job can pass on this branch; it becomes a no-op once main carries the same file.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18168 +/- ##
==========================================
+ Coverage 82.79% 83.81% +1.01%
==========================================
Files 2946 2250 -696
Lines 145057 128030 -17027
Branches 39230 34481 -4749
==========================================
- Hits 120095 107303 -12792
+ Misses 23696 20437 -3259
+ Partials 1266 290 -976
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
- Nested subgraphs render editable promoted text. - Reader dependency landed; this PR now changes tests and fixtures only. - Hosted checks complete; human review remains. Transport is mocked. <details><summary>Current verification: September 20, 05:05 UTC</summary> [The unchanged head](f08492c) has 103 terminal checks/statuses with no adverse or pending result, including [cloud Playwright](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35488913372/job/106020696630). This supersedes the pending-check statements below, not their historical execution limits. Hosted tests use the committed package pin, not the temporary 0.3.0 substitution. [The remaining bot suggestion](#17585 (comment)) is resolved with an independently checked explanation: scenario-specific node definitions intentionally override shared boot routes, and no caller combines them with server-catalog mode. CodeRabbit acknowledged the reasoning. No source restriction was added merely to clear the comment. Eight human threads remain for DrJKL: five already classified as non-blocking follow-ups and three with linked fix replies. Their review disposition is not overridden here; GitHub still reports changes requested. No human approval transfers from an older revision. This is not live-service schema-4 acceptance or merge authorization. </details> <details><summary>Reader landed: September 20, 04:08 UTC</summary> [Reader PR18148](#18148) merged. [Current browser head](f08492c) ordinarily incorporates [that main revision](c4604d2). The diff now contains seven browser test/fixture files and no production or dependency changes. The merge adds main's subscription-dialog fix without changing this PR's browser assertions. Fresh validation: 26 reader/subscription-dialog tests, browser typecheck and push-hook Knip pass. Remote head matches. The prior five-case browser result below covers its linked revision, not a new run on this head. Hosted checks are running again. Earlier intermittent boot failures remain unexplained and retained; no timeout or assertion was weakened. Human review threads remain open for their reviewers. No new 0.3.0, real-service acceptance, or merge-readiness claim is made. </details> <details><summary>Control results: September 20, 03:50 UTC</summary> On unchanged [current head](3cfcb9e), all five browser cases pass in 52.0 seconds with pinned package 0.2.1. Before this full run, the isolated export/reload case passed on [the previous green revision](0f555fc) in 22.1 seconds and then on the unchanged current revision in 21.8 seconds, using separate fresh Vite servers and the same setup. These controls do not establish a source regression or prove a root cause for the earlier failures. The final reload screenshot was inspected: the workflow is populated, including the positive prompt `a photo of a pier` and its connected sampling/output nodes. The executed test also compares rendered widget rows before export and after reload, checks the recorded second-turn graph, and verifies import did not subscribe again. This is file reload with mocked authentication/transport, not cloud persistence or live-service schema-4 acceptance. No timeout, assertion, fixture or production source changed during these controls. Earlier failed traces remain retained; intermittent app boot is not declared fixed. Private evidence: `adoption/fe/control-0347-playwright.log`, `current-0350-reload.log`, `current-0351-suite.log` and `current-0351-suite/`. Fresh hosted checks remain pending at this checkpoint. No new 0.3.0 execution or merge-readiness claim. </details> <details><summary>Latest integration: September 20, 03:37 UTC</summary> [Current head](3cfcb9e) ordinarily integrates [main](94a06f5), including telemetry, materializer tests and the save-dialog import fix. No PR-specific implementation or assertion was changed. Frozen install, browser typecheck and 731 focused unit tests pass, plus one existing expected failure. Local execution against pinned 0.2.1: four of five browser cases pass. The nested promoted widget visibly reads `edited prompt`; both tab cases and document reconnect pass. The export/reload case timed out in app boot after reload. The retained trace shows outstanding frontend module requests; a two-execution unchanged control also failed at app boot, once during initial fixture setup and once after reload. The machine had elevated load and swap use, but that is not proof of causation. Root cause remains unresolved. No timeout, assertion, fixture, screenshot baseline or production code was changed to hide the failures. Fresh hosted checks must evaluate this head. Previous review and hosted success apply only to their linked older revisions. No new 0.3.0 test, live-service, deployment or merge-readiness claim is made. Private logs and traces are retained under `adoption/fe/browser-0332-*` and `browser-0335-reload-control*` in the recovery evidence directory. </details> <details><summary>Historical implementation and verification</summary> The following describes the original revision, not the September 19 head. Its original stack on [PR17202](#17202) was replaced by mainline. The [agent subgraph technical design](https://www.notion.so/3d16d73d365081719b85ed515af98276) remains historical context. The spec enables the CRDT follower, boots the cloud-only agent panel with mocked APIs and typed node definitions, sends a prompt to bind the workflow, observes the Yjs `doc_subscribe`, and injects real Yjs updates built with the frozen `@comfyorg/comfy-multi-player` op set. It then asserts the registered subgraph definition, materialized host node, promoted text widget/input, source-to-host link topology, and follow-up `set_widget` result directly from `window.app.graph`. `insert_workflow` was not present on the original PR17202 branch. That stack used `@comfyorg/comfy-multi-player@0.2.1`, whose available operations included `add_node`, `connect`, `set_widget`, `delete_node` (corrected from the original description's `delete`), and `clear`. This test covers host materialization, not the `insert_workflow` tool. Fixture-only support extends `bootAgentApp` with optional typed node definitions and a mocked accepted turn, plus the API mocks required for that interaction. No production files are changed. Local verification: - `pnpm install --frozen-lockfile` — passed; lockfile already up to date. - `DISTRIBUTION=cloud pnpm dev --host 0.0.0.0` — dev server used for the cloud-only panel. - `pnpm test:browser:local --project=cloud browser_tests/tests/agent/agentSubgraphFollower.spec.ts` — 1 passed (9.3s). - `pnpm typecheck` — passed. - `pnpm typecheck:browser` — passed. - `pnpm lint` — passed with 0 errors and 225 pre-existing warnings. </details> <details><summary>Full context for agent readers: September 20 verification</summary> Christian authorized ownership of this existing branch. [Current head](0f555fc) ordinarily merges [frontend main](d20ef20) and [reader PR18148](#18148), preserving the original branch and reviews. The latest main merge changes only the inherited screenshot baseline; production and test source are identical to [the dual-package tested revision](b26f048). Until that reader lands, this PR includes its four production/test files; the reader must land first. Dependency manifests remain unchanged. The nested fixture now contains an inner definition. Its final assertion reads the visible Vue text widget, not only graph internals. Two recorded-conversation cases add missed-edit document reconnect and export/clear/page-reload/import checks. These use the real multiplayer package and existing host helper; authentication and transport are mocked. File reload is not cloud persistence. This does not cover the separately owned conversation-reconnect defect or authorize schema cutover. Author-reported local checks on this head's source: five browser cases passed with registry 0.2.1 (26.6s) and the exact published 0.3.0 tarball (24.3s) from [package release PR223](Comfy-Org/comfy-multi-player#223). The temporary 0.3.0 substitution has private retained logs, not a linked immutable CI artifact; it is not independently attested by this PR's hosted checks. The five comprise this nested case, two existing tab-return cases, and two new document cases. The 0.3.0 run used a fresh forced Vite dependency build; version and schema 4 were checked before/after, and the original package symlink was restored. Tarball SHA-256: `9add4d028a21df15aecc4de379c12b1f1e9af594dbf6ec38dec1dfd3af5cec2e`. Screenshots were inspected. Scoped ESLint, type-aware Oxlint, formatting, frontend/workspace typechecks, browser typecheck, and push-hook Knip passed. Hosted checks have since completed on this head with pinned 0.2.1; they do not attest 0.3.0 or deployed-service acceptance. The preceding 0.3.0 run exposed a tab-creation race: the blank tab existed and its canvas was empty before workflow loading activated it. Returning to the original tab at that point could be overwritten by the delayed activation. The test now waits for the blank tab's active state before returning. The failed run is retained; the corrected case passes five consecutive executions (34.6s) plus both full five-case runs. No timeout or product behavior changed. The existing [baseline repair PR18168](#18168) landed and is incorporated unchanged. Local reader and independent unmodified-main runs still show a different arrangement from the CI golden; their captures agree on graph layout and visible wire, differing only in the developer overlay. No snapshot was regenerated here. Fresh hosted checks must verify the incorporated baseline; no local or hosted failure is waived. One initial registry run stalled on the backend `/api/object_info` request after reload. An unchanged six-execution rerun and the final combined runs passed; the failed trace is retained. No timeout was increased. Earlier nested-reader red/green and removed-catch-up negative-control evidence remains historical; it is not a new mutation score. Review continuity: - [Panel readiness helpers](#17585 (comment)) now use `AgentPanel.open()` and `selectWorkflow()` in [the focused fix](ef132567d7). - [Undefined acronym](#17585 (comment)) is expanded to the package name and a readable suite title in [the focused fix](a5ca5ca). - [Typed boot-mock finding](#17585 (comment)): fixed invalid `manual` mode and missing pagination with generated response types. Broader composable-fixture consolidation remains its existing non-blocking follow-up. - [Onboarding finding](#17585 (comment)): retained main's explicit onboarding option and conditional storage initialization during conflict resolution; no additional onboarding redesign. - Existing non-blocking [shared frame ownership](#17585 (comment)), [multi-widget routing coverage](#17585 (comment)), and [named test phases](#17585 (comment)) remain tracked, not silently declared fixed. - DrJKL's September 15 ready-to-approve comment covered the old head only. His rejection of the conflicting-node-options bot suggestion is retained. No human threads were resolved and no old approval transfers to this head. Glossary: CMP is the standalone multiplayer package; CRDT is replicated shared-document state; Vue is the frontend's node renderer; schema 4 is the recovered document layout; catch-up replays missed document changes after reconnect. </details> --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Classification: (A) intentional visual from #17730 — snapshot-only. Not a wiring/layout regression, not flake.
#graph-canvassnapshottwo-turn-dependent-edit-wired.pngfailed at 3182 pixels (ratio 0.01) on7806755(#17730) and again on tipc1583e4, identical across four retries. Topology is unchanged: same nodes, same second-turn wire.What the 3182 pixels actually are (Playwright official diff, exact red-pixel count):
filename_prefixrow (agent_replay) — the dominant content changeCause (file:line):
browser_tests/fixtures/agentConversationFixture.ts:230— feat(agent): show graph activity while the agent writes nodes #17730 replaced liveobjectInfo: 'server'with the pinnedagentReplayNodeDefsbrowser_tests/fixtures/data/agentReplayNodeDefs.ts:88-99— that catalog declaresSaveImage.filename_prefix, which Vue nodes now projectsrc/workbench/extensions/agent/AgentPanelRoot.vue:248-252— graph-activity also forces the minimap open (already in the old golden; the 1px shift is leftover chrome)Last green main (
9d81d164) still used the server catalog. Product wiring is intact, so the golden is updated from the stable cloud actual. No product change.Verification
Compared expected vs actual from https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35479156066 (job
playwright-tests (cloud)). Three retry actuals differ by 7–24 pixels from each other; all differ from the old golden by the same 3182 Playwright pixels. New golden is that CI actual.Playwright official diff (red = the 3182 pixels):
Playwright official diff
Before (old golden) vs after (CI actual / new golden):
Before expected cloud snapshot
After CI actual used as new golden
Crops, expected left / actual right:
SaveImage filename widget appeared
Load Checkpoint selection border moved down
KSampler extra widget chrome
Minimap 1px top shift
Cloud
@screenshotre-check is the merge gate. Snapshot-only; no product fix.To show artifacts inline, enable in settings.