Repository navigation
fix(agent-crdt): keep a human delete across a workflow tab switch - #18063
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2069 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.95 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T20:54:13.012Z",
"gitSha": "f5b325e0884497f200b1503caa1f1b1d357f2ad8",
"branch": "test/pm-1327-agent-delete-tab-switch-race",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.2550000000147,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.86499999999995,
"heapDeltaBytes": -7338060,
"heapUsedBytes": 55002796,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.301,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2001.1130000000321,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.2459999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.242,
"heapDeltaBytes": 17815256,
"heapUsedBytes": 79735792,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.133000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.3659999999782,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.055999999999997,
"layouts": 14,
"layoutDurationMs": 4.720000000000001,
"taskDurationMs": 815.176,
"heapDeltaBytes": 1178700,
"heapUsedBytes": 63266556,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 146.347,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1811.0550000000103,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.199,
"layouts": 14,
"layoutDurationMs": 4.670999999999999,
"taskDurationMs": 820.3679999999999,
"heapDeltaBytes": 2035256,
"heapUsedBytes": 64079268,
"domNodes": -265,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 152.134,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.8659999999522,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.815999999999999,
"layouts": 6,
"layoutDurationMs": 1.1969999999999998,
"taskDurationMs": 321.83099999999996,
"heapDeltaBytes": 3174948,
"heapUsedBytes": 70643548,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.311000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.716999999975,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.362000000000002,
"layouts": 6,
"layoutDurationMs": 1.1710000000000003,
"taskDurationMs": 313.362,
"heapDeltaBytes": 2165360,
"heapUsedBytes": 64319684,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.082,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 625.4020000000082,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.104999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.0299999999999,
"heapDeltaBytes": 18538260,
"heapUsedBytes": 80645992,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 159.90099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 601.6779999999926,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.788999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.16599999999994,
"heapDeltaBytes": 18747868,
"heapUsedBytes": 80151672,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 152.32199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2054.349000000002,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.833999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.328,
"heapDeltaBytes": 307432,
"heapUsedBytes": 82067028,
"domNodes": -250,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 33.57300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.0189999999438,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.433,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.837,
"heapDeltaBytes": 1385840,
"heapUsedBytes": 82747924,
"domNodes": -249,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 38.71100000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2138.196999999991,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.521000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1522.4879999999998,
"heapDeltaBytes": 15388876,
"heapUsedBytes": 79532080,
"domNodes": -252,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 780.7180000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2164.04,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.018000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1527.2580000000003,
"heapDeltaBytes": -1763460,
"heapUsedBytes": 80454092,
"domNodes": -252,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 769.447,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3450.2109999999675,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.305000000000003,
"layouts": 60,
"layoutDurationMs": 14.720999999999998,
"taskDurationMs": 1626.651,
"heapDeltaBytes": 9769988,
"heapUsedBytes": 75113956,
"domNodes": -11,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 766.918,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3434.1660000000047,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.212000000000003,
"layouts": 60,
"layoutDurationMs": 14.974999999999998,
"taskDurationMs": 1636.4969999999998,
"heapDeltaBytes": 9668724,
"heapUsedBytes": 74888252,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 757.288,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2829.6569999999974,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.1439999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1693.3100000000002,
"heapDeltaBytes": 16836128,
"heapUsedBytes": 82618748,
"domNodes": -254,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 946.44,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3040.112000000022,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.011999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1874.457,
"heapDeltaBytes": 26545628,
"heapUsedBytes": 92842288,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 977.637,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2063.1050000000073,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.041999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.647,
"heapDeltaBytes": -2349584,
"heapUsedBytes": 79821596,
"domNodes": -259,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 34.714999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.6220000000603,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.938000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.5779999999999,
"heapDeltaBytes": -6732312,
"heapUsedBytes": 82041420,
"domNodes": -255,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.711000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.7409999999977,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.418,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.35200000000003,
"heapDeltaBytes": 14663524,
"heapUsedBytes": 78256160,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 139.263,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.596999999987,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.325,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.90899999999993,
"heapDeltaBytes": 14562560,
"heapUsedBytes": 78136288,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.163,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.3809999999567,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.9399999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.9120000000001,
"heapDeltaBytes": -399768,
"heapUsedBytes": 63140392,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.805,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.7760000000353,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.27099999999996,
"heapDeltaBytes": 6793108,
"heapUsedBytes": 70309260,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.394999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.1710000000076,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.427999999999997,
"layouts": 18,
"layoutDurationMs": 5.4879999999999995,
"taskDurationMs": 787.3220000000001,
"heapDeltaBytes": 7101544,
"heapUsedBytes": 70630824,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 105.85799999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.6439999999166,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.268,
"layouts": 18,
"layoutDurationMs": 5.386,
"taskDurationMs": 746.592,
"heapDeltaBytes": 17651384,
"heapUsedBytes": 81031840,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 101.444,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1300.7180000000744,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.103,
"layouts": 5,
"layoutDurationMs": 11.378,
"taskDurationMs": 838.3139999999997,
"heapDeltaBytes": -6460700,
"heapUsedBytes": 81097904,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.191000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8356.48500000002,
"styleRecalcs": 247,
"styleRecalcDurationMs": 41.76100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5580.398999999999,
"heapDeltaBytes": -4661708,
"heapUsedBytes": 76590152,
"domNodes": -250,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2655.318,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8207.967999999937,
"styleRecalcs": 247,
"styleRecalcDurationMs": 42.150999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5608.995,
"heapDeltaBytes": -4690612,
"heapUsedBytes": 76632912,
"domNodes": -250,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2629.562,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17291.455999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16892.783000000003,
"heapDeltaBytes": -59875280,
"heapUsedBytes": 178593196,
"domNodes": -8061,
"jsHeapTotalBytes": -15233024,
"scriptDurationMs": 274.959,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17151.479999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16874.51,
"heapDeltaBytes": -31146436,
"heapUsedBytes": 190733724,
"domNodes": -8061,
"jsHeapTotalBytes": -14266368,
"scriptDurationMs": 280.99,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21236.424999999996,
"styleRecalcs": 154,
"styleRecalcDurationMs": 19.728999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21071.509,
"heapDeltaBytes": -58587368,
"heapUsedBytes": 177433184,
"domNodes": -8065,
"jsHeapTotalBytes": -13873152,
"scriptDurationMs": 935.616,
"eventListeners": -14928,
"totalBlockingTimeMs": 30,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21283.843000000048,
"styleRecalcs": 157,
"styleRecalcDurationMs": 19.692999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21088.470999999998,
"heapDeltaBytes": -40540472,
"heapUsedBytes": 179914096,
"domNodes": -8061,
"jsHeapTotalBytes": -12779520,
"scriptDurationMs": 880.6890000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6212.943999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.18099999999998,
"layouts": 20,
"layoutDurationMs": 32.096,
"taskDurationMs": 6188.233000000001,
"heapDeltaBytes": -45941864,
"heapUsedBytes": 175941372,
"domNodes": -8061,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 158.43200000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 553,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6289.024999999924,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.154,
"layouts": 20,
"layoutDurationMs": 24.818999999999996,
"taskDurationMs": 6256.912999999999,
"heapDeltaBytes": -35756496,
"heapUsedBytes": 175721332,
"domNodes": -8061,
"jsHeapTotalBytes": 10280960,
"scriptDurationMs": 142.28099999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 426,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8656.950000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8571.418,
"heapDeltaBytes": -10159868,
"heapUsedBytes": 183699676,
"domNodes": 0,
"jsHeapTotalBytes": -23068672,
"scriptDurationMs": 138.01100000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8601.898000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8481.354,
"heapDeltaBytes": 11941060,
"heapUsedBytes": 198596012,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 138.96900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 461.9799999999259,
"styleRecalcs": 12,
"styleRecalcDurationMs": 21.176000000000002,
"layouts": 3,
"layoutDurationMs": 0.904,
"taskDurationMs": 116.31399999999998,
"heapDeltaBytes": 5027736,
"heapUsedBytes": 66749988,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.268,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 455.4120000000239,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.921999999999997,
"layouts": 2,
"layoutDurationMs": 0.642,
"taskDurationMs": 103.33999999999999,
"heapDeltaBytes": 4862364,
"heapUsedBytes": 66739420,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.288999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (15 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f822b232b27501bf9c451ebe32047eb73ec272fe
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
94c40d3 to
5db97e9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18063 +/- ##
==========================================
+ Coverage 82.99% 83.99% +0.99%
==========================================
Files 2956 2260 -696
Lines 145704 128747 -16957
Branches 39431 32827 -6604
==========================================
- Hits 120931 108140 -12791
+ Misses 23503 20317 -3186
+ Partials 1270 290 -980
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 699 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Fix plan (this is not trivial — needs a design decision before implementing)Root cause: Why this isn't a one-function patch: the "never retarget a queued batch" behavior is an existing, deliberate, well-tested invariant (guards against a worse bug: cross-workflow op contamination). Any real fix has to either add new local state with its own lifecycle, or change a write-leg contract with test coverage explicitly asserting the current behavior — that's a design decision, not a drop-in correctness fix. Candidate approaches:
Recommendation: approach 2 is the most targeted for this specific symptom without reopening the write-leg's retargeting contract, but the tombstone lifecycle (duration, scope, interaction with existing reconcile cases) is a real design call, not something to guess at unreviewed. Approach 1 alone is insufficient. Approach 3 is the most complete fix but the biggest change. Recommend a short design pass to pick between 2 and 3 before implementation. 🤖 Generated with Claude Code |
5db97e9 to
4b3ccf9
Compare
|
The design decision from the plan comment above is made and implemented; this PR is now the fix, not just the repro.
Design record with alternatives and residuals: Generated by Claude Code |
|
CI note on
No fix to port. I will re-run the failed jobs once the run completes; if that is not possible from here, a maintainer re-run of the failed jobs is all that is needed. Generated by Claude Code |
e5be0ca to
5815136
Compare
|
CI note: Update: the rerun failed identically, and the same check is red on main at c1583e4. Ported the one-file golden refresh from #18168 into this PR as 74b4d70 so the cloud job can pass here; it is a no-op once main carries the same file. Generated by Claude Code |
74b4d70 to
a2a5dc7
Compare
Adds a failing (it.fails) Vitest repro: opSender drops a delete_node op as undeliverable when it is still queued behind an in-flight batch as the workflow tab switches, so the server never learns of the delete. On tab reactivation, EcsFollowerAdapter rebinds and forces a full reconcile of the next frame, re-adding the node's record from the server's still-current document; agentNodeMaterializer then recreates the node the user deleted. Drives the real opSender, EcsFollowerAdapter, FollowerDoc and reconcileAgentAdapters (no mocks of any of them), forcing the queued-batch race deterministically instead of relying on timing. Repro only, no fix.
…ension Adds ADR-CRDT-WRITE-0035: distinguish a paused follower subscription (a workflow tab going inactive) from a lost one, park the sender's pending batches instead of settling them undeliverable, and let the rebind reconcile skip a document node whose human delete is still in flight. Records the alternatives considered and the residual gaps.
…s inactive The bound workflow's tab going inactive must hold the queued batch rather than settle it undeliverable, a return to that tab must send it to the same workflow, an offline return must send it once the subscribe is acknowledged, and a rebind, detach or refused subscribe must still abort.
…is inactive A workflow tab switch pauses the follower's subscription without rebinding the agent session, but the sender treated it as a lost subscription: the in-flight batch was aborted and every queued batch behind it settled undeliverable at transmit, so a delete made just before the switch never reached the host and the node came back on return. opSender gains suspend()/resume(): while suspended, transmit() parks a batch instead of sending or settling it, and resume() re-transmits only a parked batch through the unchanged mint-time binding check, so a batch is delayed but never re-addressed. pendingOps() exposes the unsettled batches. useAgentCrdtFollower suspends only when the tab of the bound workflow goes inactive, remembers that workflow, skips the eager abort for it on return, and resumes once the subscribe has actually left the transport or is acknowledged. A rebind, a detach or a refused subscribe still abort.
…esurrecting it The repro now models the switch as production does: the sender is suspended and send reality goes null, then the same workflow rebinds and resumes. The held delete is delivered and the node stays gone once its effect lands. A second, still-failing case delivers the resubscribe catch-up before the delete has landed on the host: the rebind reconcile recreates the node whose delete is still in flight.
… reconcile Returning to a workflow tab rebinds the follower session and the first frame runs a full document-to-store reconcile. The document is authoritative for everything except the local human's own edits the host has not yet confirmed, so a node whose delete is still on its way was recreated until the delete's effect frame arrived. EcsFollowerAdapter takes an optional LocalIntent port; the full reconcile filters out document nodes with a pending human delete and their incident links so the batch still commits. useAgentCrdtFollower implements the port from the sender's unsettled batches plus acknowledged deletes, which stay pending until the document no longer holds the node.
christian-byrne
left a comment
There was a problem hiding this comment.
The pending-delete/tab-return fix passes its regression. Broader incident remains open. Required CI must finish before merge.
Full context for agent readers
Reviewed the refreshed head against integrated main. The refresh retains both pending-delete suppression and main's incompatible-link filtering. Suspension parks queued operations without changing their minted workflow or operation IDs; real retarget/refusal retains the normal abort path. Full reconciliation excludes pending-deleted nodes and their incident links. Applied acknowledgements preserve suppression until the document reflects deletion.
Verification: 49 replication suites, 733 passing tests and five existing expected failures; source/browser/website typechecks and lint/format hooks pass. The new browser regression deletes two nodes, holds host results, returns to the tab, and checks both deleted nodes stay absent while three unaffected nodes survive visibly and in live, serialized and active workflow state. Removing only the local-intent wiring reproduces resurrection; restoring it passes. The screenshot was inspected.
The combined browser run is not all green: two pass, one existing checkpoint-warning retention test fails after tab return. That failure remains under its existing owner and is not suppressed here. This recorded-host replay does not certify the original live-model Save Video incident.
Independent review's proposal to retain unknown-result deletion suppression forever was not adopted: terminal result-silence behavior predates this patch, and indefinite suppression can hide legitimate host state. The design record now explicitly retains immediate catch-up/lost-write feedback as follow-up work. Incremental resurrection, the original unwanted-node cause, original workflow acceptance and both 1.54 release qualifications remain owned in the program and original incident. Approval applies to this bounded source improvement, not incident closure or release acceptance.
Glossary: reconciliation copies authoritative document state to the visible graph; local intent is the pending human edit that reconciliation must preserve; unknown-result means the operation was sent without a definitive host result.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Backports the reviewed human-delete tab-switch fix from PR #18063 onto cloud/1.54.
Backport adaptation: test-only. The #18063 carrier's race test mints its ops by hand with the three-part stamp of comfy-multi-player 0.2.1. core/1.54 runs 0.3.6, whose applyOps rejects that stamp as malformed_op, so two cases failed during setup. Cloud made the same fix when it adopted 0.3.2 (#18304): the test now mints through the runtime's mintWireOps. This takes main's file, which is byte-identical to cloud's after #18304. No runtime file changes, and #18304 changed none of the carrier's runtime code either.
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
…t a cloud carrier (#18257) ## Summary Eight merged `main` Agent fixes that had no `cloud/1.54` carrier are cherry-picked onto the current release tip. Two sources need hand re-expression and are excluded. Runtime source is unmodified from the eight sources; seven follow-up commits are test-only adaptations to the release's module surface. Verification at the current head `2991cfc3f8` is hosted CI (77 success, 16 skipped, 0 failed) plus DrJKL's local run (see below); the picked browser specs had not been run against the target before this PR. Open gates: release-scope sign-off on the three non-Agent carries and exact-head human re-approval on `2991cfc3f8`, both tracked in [blocked-on-christian 825](christian-byrne/blocked-on-christian#825). Replaces [18254](#18254): six picks there inherited `Co-authored-by: Claude` trailers from the `main` squash commits and failed the AI co-author check. Runtime source is byte-identical to that PR's head `d1f35ac622`; two test files differ (listed under Adaptations). <details><summary>Full context for agent readers</summary> ## Changes Sources, all `cherry-pick -x -m 1`, clean, in merge order: - [18104](#18104) prefer previewUrl for dragged batch-output attachments - [18110](#18110) re-measure Vue node slot offsets after graph reload - [18117](#18117) record an undo entry when a link is dropped from a Vue node slot - [18118](#18118) stop a canvas click after redo from pushing a spurious undo entry - [18124](#18124) never silently no-op the subscription-required dialog - [18127](#18127) restore autogrow inputs after Agent reconciliation - [18191](#18191) keep the ghost placement flag out of the CRDT document - [18196](#18196) retarget new Agent chat to the workflow tab on screen Adaptations, all test-only, no runtime change: - `NodeSlots` reload unit test uses `createTestingPinia` + `setActivePinia` instead of `getActivePinia()!`, because the shared test Pinia setup from [17237](#17237) is `main`-only. - Browser fixture gains `NodeSlotReference.expectLinkCount` (same body as `main`, from [17403](#17403)); three picked Agent specs open the panel with the label the release UI renders, `agent.askComfyAgent`, because `agent.entryButton` from [17621](#17621) does not exist on this line. - `useSlotLinkInteraction.autoPan.test.ts`: the `globalEnums` mock is dropped (the picked composable now reads `RenderShape` from the real module, as on `main`), and the `@vueuse/core` mock spreads the actual module so release-native transitive imports such as `useStorage` resolve while the event-listener overrides stay focused. - `useSlotLinkInteraction.autoPan.test.ts` (`249123390c`): the workflow store is mocked at its seam instead of a partial module mock, per dante01yoon's review. - `subgraphPromotedWidgetExternalLink.spec.ts` (`2991cfc3f8`): the plain CLIPTextEncode "hides the text control" case and its two constants are deleted, because it asserts [17576](#17576) behavior (WidgetGrid retains labels for connected inputs) that is not on `cloud/1.54`. Re-add when 17576 lands on this line; the 17576 decision is [blocked-on-christian 824](christian-byrne/blocked-on-christian#824). Dependencies: none added; release lockfile pins preserved. Exclusions: [18063](#18063) and [18073](#18073) conflict because they edit `agentCrdtProjection.ts` and `agentCrdtDocLifecycle.ts`, files created by the follower split in [16908](#16908), which `cloud/1.54` never received. They need focused hand re-expression onto the pre-split follower, following [18219](#18219) and [18195](#18195); tracked as separate program rows. ## Review focus - Every source commit is an unmodified cherry-pick; review effort belongs on the test-only adaptation commits and on whether the eight sources are wanted on this line at all. - Sources 18110, 18117, and 18118 touch undo/redo and slot measurement outside the Agent panel, so they change behavior for users who never open the Agent. - This is not behavioral acceptance or a merge-check waiver; no target-native browser acceptance has run outside hosted CI. ## Exact-head verification Head history: `210e191fc9` (approved by DrJKL) received five test-only follow-ups: `a9ab888243` (module-surface alignment), `a63fef35ae` (`test.fixme` instead of `test.skip`, which the release's oxlint config rejects), `118ac5e9c6` (restore VueUse exports in the auto-pan mock, fixing the suite-collection failure DrJKL found at `a63fef35ae`), `249123390c` (workflow-store seam mock), and `2991cfc3f8` (delete the plain CLIPTextEncode browser case). - `210e191fc9`, local on top of `cloud/1.54` tip `1bbcdc66fa`: cherry-pick dry run of all 10 candidates, 8 clean individually and as a sequential stack, 2 conflicting as described above; `vitest run` on the 9 touched unit test files 405 passed; both `vue-tsc` projects exit 0; `oxfmt` and `eslint` clean; lint-staged and knip passed in hooks. - `a63fef35ae`, hosted: `lint-and-format` passed. DrJKL's local focused run: 405 passed plus one suite-collection failure in `useSlotLinkInteraction.autoPan.test.ts` (`useStorage` missing from the total `@vueuse/core` mock). Fixed in `118ac5e9c6`. - `118ac5e9c6`: hosted CI green; the unit `test` job covers the collection fix. - `2991cfc3f8` (current head): hosted CI 77 success, 16 skipped, 0 failed. DrJKL's local run on this head: both typecheck projects, ESLint, Oxlint, format, and Knip clean; Vitest 4 of 4 on the auto-pan suite; Playwright discovery 43 tests across 7 specs; Fallow clean. Author-side local verification is not run on this head (host resource hold); hosted CI plus DrJKL's run are the verification of record. Program receipt: [2026-09-21-ms215-gap-backport-cloud154.md](https://github.com/christian-byrne/in-app-agent-program/blob/main/reports/pr-ownership/2026-09-21-ms215-gap-backport-cloud154.md). </details> --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: test-bot <test-bot@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
…FE-1969) (Comfy-Org#21147) ## Summary After a full page reload the panel restores its target from the thread's own transcript — the tab reopens, the picker repaints, the transcript is back — but the session binding is not restored, so the CRDT follower never resubscribes. Every host edit between the reload and the **next turn ack** reaches nobody, and during a turn recovered across the reload the user cannot send that next turn, so there is no way out of it. This binds the restored workflow, taken from the id the server's transcript carries. The guard is deliberately narrow: bind only when the restored workflow is both the panel's selected target and the active tab, which is what a restoration itself produces. `onWorkflowRestored` also reports success when there was nothing to restore (an already-decided target on a remount), so that cannot be the only condition, and a background target must never be subscribed. No binding or document id is read from client-side storage. `agentCrdtDocLifecycle`'s persisted doc-id record still refuses a pre-reload page-session nonce, which is deliberate and unchanged; the restored id comes from the service. The one thing kept in `sessionStorage` is a list of workflow ids whose canvas may hold edits the shared document lacks (see below); it can only stop the automatic bind, never cause one. <!-- updated by agent oploop-904h, 2026-10-22 --> Extends [FE-1969](https://linear.app/comfyorg/issue/FE-1969/crdt-follower-cannot-restore-persisted-binding-through-agentpanelroot). ## Verification Measured on `main` at `f2c829248b`, where a production-shaped reload (transcript naming the bound workflow) restores the target automatically, leaves the follower subscribe count unchanged, and drops a host edit pushed afterwards. On this head the same sequence resubscribes and the edit paints. - **Browser regression** `browser_tests/tests/agent/agentFollowerRestoredBindingReload.spec.ts`: red on the parent commit (post-reload subscribe count never rises, so the host edit never arrives), green here. The asserted value was never saved or recorded and no turn is sent after the reload, so only a live subscription can deliver it. - **Harness capability**: `agentConversationFixture` can now serve a stored transcript (`persistThreadTranscript`). Its history handler answered with an empty array — a thread that never ran — so a reloaded page had no target to restore and no reload case could reach this path at all. This is the gap recorded in Comfy-Org#16849's "why this fix has no `browser_tests/` case" note. - **Component cases** (2, in `AgentPanelRoot.test.ts`): the positive case is red on the parent; the negative case pins that a transcript which restores nothing leaves the session unbound. - Neighbouring reload coverage re-run green: `agentFollowerReloadBinding`, `agentHumanAddReload`, `agentChatRefreshPersistence`, `agentTurnSurvivesRefresh`. The explicit-reattachment case in `agentFollowerReloadBinding` is unchanged — picking a workflow in the switcher is still a target choice, not a live rebind. - `AgentPanelRoot.test.ts` 435/435; `pnpm typecheck`, `pnpm typecheck:browser`, type-aware oxlint, eslint, oxfmt, knip and the Fallow audit all pass; pre-commit and pre-push hooks ran. ### Restore-time precedence (dante01yoon's saved-edit finding) Binding at restore runs the subscribe catch-up, which writes the shared document into the canvas. On `main` a saved edit whose operation never reached the shared document survives a reload: the next message posts the live canvas as its draft, and turn preparation replaces the shared document with it (`ensureDoc` → `replaceDocFromClient` in cloud `services/agent/internal/loop/crdt.go`; [`CRDT-AUTHORITY-0035`](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/CRDT-AUTHORITY-0035-human-canvas-authority-and-draft-reconciliation.md) decision 1). The first version of this PR reversed that: the catch-up overwrote the saved edit at restore ([reproduced](Comfy-Org#21147 (comment)), [confirmed](Comfy-Org#21147 (comment))). That precedence is kept, not re-decided. The follower records which workflows have human operations that are unsettled, or settled without being applied. A restore skips the automatic bind for such a workflow, so the canvas keeps the edit and the next message reconciles it exactly as on `main`. Every other restore binds as before. - The record clears per workflow on `doc_reset` (the draft replaced the document) and, for what an earlier page recorded, when this page subscribes to that workflow. It is carried across further reloads until then. - No operation is stored or replayed; persistence of pending operations across a full reload stays the separate decision [`CRDT-REPLAY-0039`](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/CRDT-REPLAY-0039-retain-exhausted-operations-for-same-page-replay.md) defers. - A stale or duplicated-tab record can only reproduce `main`'s behaviour for that workflow (bind at the next turn). It cannot overwrite or resend anything. - Accepted cost: in that case, live host edits after the reload wait for the next turn, as on `main`. **Browser case** `keeps a saved edit the shared document never received, and posts it with the next message`: the host holds a `set_widget`, Save As, two reloads, then the next message's draft is asserted to carry the edit. It fails with the restore guard removed (canvas reads the older shared value, the exact failure in the review thread), with the follower's admission record removed, and at the second reload if the record is consumed on first read. One component case and three unit cases (`unsyncedHumanOps.test.ts`) pin the rest. The original restored-binding case still binds and receives the host edit. Re-run at `190b7f871e`: 18/18 Chromium cases across the restored-binding spec, `agentFollowerReloadBinding`, `agentHumanAddReload`, `agentHumanAddTabSwitch`, `agentChatRefreshPersistence`, `agentTurnSurvivesRefresh`, `agentMultilineTextEchoGarbling` and `boundCanvasReadPath`; `src/workbench/extensions/agent` 3,917 unit tests; typecheck (app and browser), oxlint, eslint, oxfmt, knip, Fallow audit and the pre-commit and pre-push hooks. Supersedes Comfy-Org#16708, which pursued the same user-visible outcome by adopting the pre-reload `sessionStorage` record across a reload. That approach conflicts with the current deliberate design and with the merged reload coverage; its other three claims — page-session nonce, expiry slide, background suspension — are already on `main` via Comfy-Org#16624, Comfy-Org#18063 and Comfy-Org#16849.
Requested by Christian Byrne · Slack thread
Summary
Before: with the Agent panel bound to a workflow, deleting an agent-added node and then switching workflow tabs away and back brings the node back. The delete queued behind an in-flight batch was settled
undeliverablewhen the tab went inactive (the follower treated a paused subscription like a lost one), so the host never learned of it; on return the rebound follower session ran a full doc-to-store reconcile and recreated the node from the host's still-current document.After: the human write leg is suspended, not aborted, while the bound workflow's tab is inactive, and the held batch is sent to the same workflow once the tab returns and its subscribe has left the transport. The return reconcile skips a document node whose human delete is still pending (and its incident links), so the node stays gone while the delete is in flight.
Design record:
docs/adr/CRDT-WRITE-0035-hold-pending-human-ops-across-tab-suspension.md.Changes
opSender.ts:suspend()/resume()park a batch attransmit()instead of sending or settling it;resume()re-transmits only a parked batch through the unchanged mint-time binding check, so a batch is delayed but never re-addressed.pendingOps()exposes the unsettled batches. A sent batch keeps its result timer while suspended.useAgentCrdtFollower.ts: suspends only when the tab of the workflow it is bound to goes inactive (next === previous[0]), remembers that workflow, skips the eager abort for it on return, and resumes oncebridge.subscribedWorkflowIdmatches (synchronously online, else ondoc_subscribed okor the nextbridge.reconcile()). A rebind to another workflow, a real detach, or a refused subscribe still abort immediately. Implements the adapter'sLocalIntentfromsender.pendingOps()plus acknowledged deletes kept pending until the doc no longer holds the node.ecsFollowerAdapter.ts/agentCrdtProjection.ts: optionalLocalIntentport; the full reconcile filters out doc nodes with a pending human delete and their incident links so the batch still commits.opSender.test.ts(suspension block),useAgentCrdtFollower.test.ts(tab suspension block),ecsFollowerAdapter.integration.test.ts(local intent block), andagentDeleteTabSwitchRace.test.tsre-modelled to production's suspend/resume ordering, with the originalit.failsflipped and a second case covering the catch-up-before-effect window.Review Focus
crossWorkflowPending.test.tsand the existingopSender.test.tsabort cases still pass unchanged; parking only delays a batch and the reality check at transmit still decides.sender.detach()); a refused resubscribe on return still drops them; the incremental frame path still upserts a pending-deleted node if another actor edits it before the delete lands; a delayed delete carries a stalebase_versionand the host applier may LWW-drop it if the node was touched at a higher version meanwhile. A separate per-turn backend cause of the same symptom is tracked internally.test:commits carry only tests and fail at runtime; thefix:commits carry the source plus the tests that could not typecheck before the API existed (the pre-commit hook runspnpm typecheck, so a test namingsender.suspend()cannot land alone).Local verification
pnpm vitest run src/workbench/extensions/agent/crdt: 40 files, 635 passed, 1 expected fail (pre-existing, unrelated).pnpm typecheck,pnpm lint,pnpm knip,pnpm format:check,pnpm adr:check: all clean at the pushed head.🤖 Generated with Claude Code
https://claude.ai/code/session_018RqBx9mYbvgVNJ6zy9Czez