Skip to content

test: regenerate screenshot expectations - #18169

Closed
christian-byrne wants to merge 1 commit into
mainfrom
regen-screenshots/2026-09-19T18
Closed

christian-byrne wants to merge 1 commit into
mainfrom
regen-screenshots/2026-09-19T18

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

A light went walking round a bar,
the minimap came out to see;
the golden PNG, fixed and far,
still holds the graph that used to be.

Three thousand pixels, one eight two —
the same on every branch we tried.
Not flake. Just truth the picture knew
and one stale file that never died.


two-turn-dependent-edit-wired.png in browser_tests/tests/agent/agentConversationReplay.spec.ts went stale.

#17730 (7806755421, "feat(agent): show graph activity while the agent writes nodes") changed what the canvas and minimap paint during an agent turn, but did not regenerate this expectation. That PR's own playwright-tests (cloud) check was red on this exact test when it merged.

Since then playwright-tests (cloud) — and its e2e-status aggregator — fail on every PR whose run starts after 2026-09-20T00:15:37Z.

Evidence it is a stale golden and not a flake:

No source change here — this is the expectation refresh only.

@christian-byrne christian-byrne added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 20, 2026
@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 20, 2026 1:20am UTC

Request Review

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

No description provided.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

replaced by #18168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Browser Test Expectations New browser test screenshot should be set by github action risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant