Repository navigation
test(agent): repro CRDT reconcile wiping node color and input labels - #18079
claude[bot] wants to merge 1 commit into
Conversation
The agent-CRDT follower's node reconcile path wholesale-replaces a live node's presentation-only state from the CRDT document instead of merging onto it. The document never carries a node's color/bgcolor/boxcolor or an autogrow input's client-computed friendly label, so any full reconcile (e.g. the one triggered by switching a workflow tab away and back) blanks a user-picked node color and reverts autogrow input labels to their raw internal names. - graphMutations.test.ts: unit repro against reconcileNode -> nodeDataStore.updateNode/assignNodeFields, covering both the color field and an input slot's friendly label. - agentTabSwitchCatchUp.spec.ts: end-to-end repro that colors a node through the real color picker, forces the same tab-switch reconcile as the adjacent tests in this file, and shows the color does not survive. Both are test.fail/it.fails: no fix included.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2039 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T02:35:10.353Z",
"gitSha": "f56745fcd649a4423eedb214999fa74503918a8e",
"branch": "test/agent-reconcile-wholesale-replace-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.9670000000178,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.271000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.91600000000005,
"heapDeltaBytes": 7852116,
"heapUsedBytes": 68848640,
"domNodes": -264,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.247999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1993.3300000000145,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.864,
"heapDeltaBytes": 16087664,
"heapUsedBytes": 77610720,
"domNodes": -263,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.813,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.0310000000145,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.165,
"layouts": 14,
"layoutDurationMs": 4.383000000000001,
"taskDurationMs": 842.1870000000001,
"heapDeltaBytes": 2631224,
"heapUsedBytes": 64712700,
"domNodes": -264,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 159.504,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.7819999999801,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.305999999999997,
"layouts": 14,
"layoutDurationMs": 4.096,
"taskDurationMs": 840.7659999999998,
"heapDeltaBytes": 1025444,
"heapUsedBytes": 63089604,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 164.44,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.322999999984,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.707,
"layouts": 6,
"layoutDurationMs": 1.023,
"taskDurationMs": 322.021,
"heapDeltaBytes": 2870956,
"heapUsedBytes": 69979252,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.353999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6069999999781,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.616,
"layouts": 6,
"layoutDurationMs": 1.3880000000000001,
"taskDurationMs": 380.219,
"heapDeltaBytes": 2143196,
"heapUsedBytes": 64249284,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.433999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 614.1729999999939,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.882,
"heapDeltaBytes": 18234044,
"heapUsedBytes": 80025824,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.561,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.0409999999492,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.711000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.20399999999995,
"heapDeltaBytes": 18238176,
"heapUsedBytes": 80199816,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 169.796,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.557999999986,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.438999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.414,
"heapDeltaBytes": 2683004,
"heapUsedBytes": 81776500,
"domNodes": -250,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 34.58,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.160000000019,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.209999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.194,
"heapDeltaBytes": -2709008,
"heapUsedBytes": 83036768,
"domNodes": -249,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 36.27799999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2228.1190000000493,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.178,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1635.59,
"heapDeltaBytes": -1232380,
"heapUsedBytes": 79054508,
"domNodes": -252,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 843.288,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2269.117000000051,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.406,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1628.356,
"heapDeltaBytes": 13866692,
"heapUsedBytes": 78444404,
"domNodes": 2,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 852.358,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3520.654000000036,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.854000000000001,
"layouts": 60,
"layoutDurationMs": 13.151000000000002,
"taskDurationMs": 1562.932,
"heapDeltaBytes": 8052164,
"heapUsedBytes": 74218636,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 808.302,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3588.157000000024,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.784000000000002,
"layouts": 60,
"layoutDurationMs": 13.224,
"taskDurationMs": 1736.9489999999998,
"heapDeltaBytes": 7980140,
"heapUsedBytes": 73959388,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 806.739,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3089.743999999996,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.812999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1908.1519999999998,
"heapDeltaBytes": 24921484,
"heapUsedBytes": 90836144,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 986.695,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3128.0140000000074,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.927999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1944.0199999999998,
"heapDeltaBytes": 22780244,
"heapUsedBytes": 88935884,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 999.6279999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2002.5830000000155,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.325999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.6339999999999,
"heapDeltaBytes": 19791164,
"heapUsedBytes": 83969364,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.16100000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1998.6410000000205,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.211000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.0360000000001,
"heapDeltaBytes": 19608416,
"heapUsedBytes": 84167160,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.016,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.588999999989,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.138,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.16300000000007,
"heapDeltaBytes": 13986560,
"heapUsedBytes": 77102704,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 143.937,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.7880000000314,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.277,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.532,
"heapDeltaBytes": 13402284,
"heapUsedBytes": 76719924,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.288,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.0509999999713,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.8450000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.469,
"heapDeltaBytes": -701160,
"heapUsedBytes": 62550636,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.206999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.6180000000268,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.868,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.40100000000007,
"heapDeltaBytes": 15954768,
"heapUsedBytes": 78222592,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.4179999999999975,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.9930000000159,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.122999999999998,
"layouts": 18,
"layoutDurationMs": 5.5600000000000005,
"taskDurationMs": 787.154,
"heapDeltaBytes": 794796,
"heapUsedBytes": 64054648,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 113.86,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1737.7970000000005,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.994999999999997,
"layouts": 18,
"layoutDurationMs": 5.195,
"taskDurationMs": 824.5509999999999,
"heapDeltaBytes": -667776,
"heapUsedBytes": 62730344,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 114.14500000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.343000000058,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.547000000000004,
"layouts": 5,
"layoutDurationMs": 13.04,
"taskDurationMs": 926.4399999999999,
"heapDeltaBytes": 18270468,
"heapUsedBytes": 100302316,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.20400000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8516.558999999972,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.089999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5798.127,
"heapDeltaBytes": -486360,
"heapUsedBytes": 79374504,
"domNodes": -249,
"jsHeapTotalBytes": -339968,
"scriptDurationMs": 2819.023,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8563.401000000113,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.606,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6035.68,
"heapDeltaBytes": -13631356,
"heapUsedBytes": 65417772,
"domNodes": -249,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 2868.388,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13125.732000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12560.478000000001,
"heapDeltaBytes": -27503624,
"heapUsedBytes": 194490320,
"domNodes": -8061,
"jsHeapTotalBytes": -11997184,
"scriptDurationMs": 223.88599999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17246.485000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16751.578999999998,
"heapDeltaBytes": -48680068,
"heapUsedBytes": 182564824,
"domNodes": -8061,
"jsHeapTotalBytes": -8110080,
"scriptDurationMs": 284.05800000000005,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20300.236999999983,
"styleRecalcs": 162,
"styleRecalcDurationMs": 16.84800000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20054.572999999997,
"heapDeltaBytes": -35484508,
"heapUsedBytes": 179702320,
"domNodes": -8061,
"jsHeapTotalBytes": -16453632,
"scriptDurationMs": 876.559,
"eventListeners": -14928,
"totalBlockingTimeMs": 140,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16069.804000000091,
"styleRecalcs": 86,
"styleRecalcDurationMs": 13.184000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15669.618,
"heapDeltaBytes": -45794552,
"heapUsedBytes": 184732304,
"domNodes": -8062,
"jsHeapTotalBytes": -12722176,
"scriptDurationMs": 828.4350000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6104.355999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.571,
"layouts": 20,
"layoutDurationMs": 22.295999999999996,
"taskDurationMs": 5998.007,
"heapDeltaBytes": -41384556,
"heapUsedBytes": 174124312,
"domNodes": -8061,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 111.05299999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 422,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6199.681000000055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.11399999999999,
"layouts": 20,
"layoutDurationMs": 23.514999999999993,
"taskDurationMs": 6092.106,
"heapDeltaBytes": -16314676,
"heapUsedBytes": 197085264,
"domNodes": -8061,
"jsHeapTotalBytes": 16609280,
"scriptDurationMs": 113.55999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 383,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8390.467,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8036.869,
"heapDeltaBytes": 14202720,
"heapUsedBytes": 200102104,
"domNodes": 0,
"jsHeapTotalBytes": -5505024,
"scriptDurationMs": 118.01699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8389.58500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8197.771999999999,
"heapDeltaBytes": -31923936,
"heapUsedBytes": 170297416,
"domNodes": 0,
"jsHeapTotalBytes": -28835840,
"scriptDurationMs": 125.07000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 465.1820000000271,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.951,
"layouts": 4,
"layoutDurationMs": 2.1820000000000004,
"taskDurationMs": 133.73,
"heapDeltaBytes": 5287180,
"heapUsedBytes": 66867116,
"domNodes": 151,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 15.623000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.25599999993574,
"styleRecalcs": 9,
"styleRecalcDurationMs": 19.581,
"layouts": 3,
"layoutDurationMs": 1.6949999999999998,
"taskDurationMs": 80.63000000000001,
"heapDeltaBytes": 3041956,
"heapUsedBytes": 64498240,
"domNodes": 106,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.503999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18079 +/- ##
==========================================
+ Coverage 82.77% 83.80% +1.03%
==========================================
Files 2936 2242 -694
Lines 144482 127635 -16847
Branches 39021 34338 -4683
==========================================
- Hits 119593 106964 -12629
+ Misses 23632 20381 -3251
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Reviewed alongside the two sibling PRs for the same bug family (#18081, #18089). Verdict: superseded by #18081, which fixes the same defect this PR only reproduces. Both PRs target the identical root cause (CRDT reconcile wholesale-replacing Two concrete issues if both are kept open as-is:
Recommendation: close this one in favor of #18081 (a human call, not mine to make) rather than trying to land both. I did not push additional tests here since the coverage gap it partially fills (autogrow label, end-to-end) is already closed more completely by #18081. 🤖 Generated with Claude Code |
|
Closing as superseded by #18081. Both PRs target the same root cause: #18081 goes further than this PR:
Once #18081 merges, this PR's 🤖 Generated with Claude Code |
Summary
The agent-CRDT follower's node reconcile path wholesale-replaces a live node's presentation-only state from the CRDT document instead of merging onto it. The document never carries a node's
color/bgcolor/boxcolor(renderer-owned fields) or an autogrow input's client-computed friendly label (the readable name shown over a raw dotted slot name likemodel.images.image_1), so any full reconcile — for example the one triggered when a workflow tab goes inactive and becomes active again — blanks a user-picked node color and reverts autogrow input labels to their raw internal names.This PR adds only failing regression tests (
test.fail/it.fails); it does not include a fix.What's here
src/workbench/extensions/agent/crdt/graphMutations.test.ts: anit.fails()unit test proving the wholesale-replace directly againstreconcileNode→nodeDataStore.updateNode/assignNodeFields, covering both the node'scolorand an input slot's friendly label in one call.browser_tests/tests/agent/agentTabSwitchCatchUp.spec.ts: atest.fail()end-to-end repro alongside the existing tab-switch-reconcile tests in that file. Runs a recorded agent conversation, colors one of its nodes through the real selection-toolbox color picker, opens and returns from a second workflow tab (the real trigger for the full reconcile), and asserts the color survived. It doesn't, and a screenshot of the blanked node is attached to the test result as evidence.The end-to-end repro covers only the color half of the defect. Reproducing the label loss end-to-end needs a recorded agent conversation against a node type with autogrow (multi-input) slots; none of the currently recorded conversations under
browser_tests/fixtures/data/agent/conversations/include one, and recording a new one needs the live agent/doc-host stack described in that directory's README, which wasn't available while writing this. The Vitest test proves the same code path handles both fields identically, since both are dropped by the sameObject.assign/array-splice inassignNodeFields/updateNode.Verification
Un-inverting the assertion locally (temporarily dropping
.fails) confirms it fails for the right reason:The Playwright test could not be run end-to-end in this environment (no ComfyUI backend available to boot the dev server against). It follows the exact fixture and tab-switch-reconcile trigger already proven by the adjacent tests in the same file (
Agent workflow tab switch,Agent workflow tab switch between two workflows), reusing the sameagentConversationFixture,Topbar, and case.🤖 Generated with Claude Code
https://claude.ai/code/session_01WgCgZKjk1bLPcyYppEr9DZ
Generated by Claude Code