Skip to content

fix(agent-crdt): retain deletes across tab switches (cloud/1.54) - #18266

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18063-cloud-1.54
Sep 21, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18063-cloud-1.54

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Re-expresses the human-delete tab-switch fix from source PR 18063 on the pre-split cloud/1.54 follower.

  • Keeps queued human operations suspended while the bound workflow tab is inactive, then resumes only after the same workflow subscribes again.
  • Prevents a full catch-up reconcile from recreating nodes whose human delete is still pending.
  • Includes target-local unit and integration coverage for suspension, retarget refusal, and the result-to-effect window.
Full context for agent readers

Source: PR 18063 / ddd9299baff1bd045be64b39f440e1f0df85eb60.
Target parent: cloud/1.54 at 1bbcdc66fa00c8462bfb50a8f3a77b48556675fb.

The source fix targets modules introduced by the later follower split in PR 16908. This carrier deliberately does not backport that refactor. It places the same suspension and pending-delete semantics in the release line's existing useAgentCrdtFollower.ts, opSender.ts, and EcsFollowerAdapter seams.

The source's main-only browser spec and ADR were not copied. Release-local unit/integration cases cover the adapted seams. Expensive local test, typecheck, lint, format, build, and browser commands were deferred under the active host resource constraint; hosted CI is the first executable verification of this exact head.

No deployment, release, ruleset, or history mutation is included.

Justification: Owner-authorized guarded release backport — exact-head adaptation review found no blocking defect, the source behavior is preserved on the release-native seams, and 92 hosted checks are terminal non-adverse.

Backport #18063 to cloud/1.54 by re-expressing the fix in the pre-split follower.
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 6186cf5a-6b51-4aa0-b44a-b5d0bdaa3621

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 21, 2026 8:57am UTC

Request Review

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1931 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1910 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/21/2026, 08:59:50 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 138ms TBT · 101.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.0 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 48ms TBT · 159.9 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 396ms TBT · 168.4 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 496ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.9 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -164
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 951ms
canvas-mouse-sweep: script duration 171ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 77.3 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -166
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 345ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 454ms
dom-widget-clipping: script duration 164ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.2 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 602ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.0 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1633ms
large-graph-pan: script duration 833ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.1 MB
large-graph-pan: DOM nodes -272
large-graph-pan: event listeners -78
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1696ms
large-graph-zoom: script duration 774ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes -138
large-graph-zoom: event listeners -90
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1915ms
legacy-node-drag: script duration 963ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 607ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.5 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 410ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.1 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 484ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.8 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 813ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 73.8 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 904ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 138ms
subgraph-transition-enter: heap used 101.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5803ms
viewport-pan-sweep: script duration 2737ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.8 MB
viewport-pan-sweep: DOM nodes -277
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16336ms
vue-large-graph-idle: script duration 282ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 137
vue-large-graph-pan: task duration 18302ms
vue-large-graph-pan: script duration 901ms
vue-large-graph-pan: TBT 48ms
vue-large-graph-pan: heap used 159.9 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14932
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 29ms
vue-node-resize-workload: style recalc duration 92ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6173ms
vue-node-resize-workload: script duration 113ms
vue-node-resize-workload: TBT 396ms
vue-node-resize-workload: heap used 168.4 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8296ms
vue-zoom-out-idle: script duration 133ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 73ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.6 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 26
Raw data
{
  "timestamp": "2026-09-21T09:08:47.108Z",
  "gitSha": "bde4eec4c2807bee82ec2368a76d6dd6f7fb2940",
  "branch": "backport-18063-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.2870000000253,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.076000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.065,
      "heapDeltaBytes": 6474112,
      "heapUsedBytes": 76881748,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.155,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.3989999999367,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.965,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.04400000000004,
      "heapDeltaBytes": 4142928,
      "heapUsedBytes": 73879780,
      "domNodes": -278,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.827000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2052.8620000000046,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 32.45399999999999,
      "layouts": 14,
      "layoutDurationMs": 3.934999999999999,
      "taskDurationMs": 1002.0400000000001,
      "heapDeltaBytes": 8122112,
      "heapUsedBytes": 79049500,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 179.73600000000002,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1873.3170000000428,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 30.487999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.54,
      "taskDurationMs": 900.591,
      "heapDeltaBytes": 13402712,
      "heapUsedBytes": 83158320,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 162.226,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.5590000000134,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.803999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.167,
      "taskDurationMs": 348.687,
      "heapDeltaBytes": 4655988,
      "heapUsedBytes": 75511184,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.797,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.2689999999693,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.060000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1580000000000001,
      "taskDurationMs": 341.23199999999997,
      "heapDeltaBytes": 4340896,
      "heapUsedBytes": 74252344,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.318999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 651.5850000000114,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.799,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.598,
      "heapDeltaBytes": 17861260,
      "heapUsedBytes": 88340104,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 166.94,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 665.538999999967,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.312,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.93699999999995,
      "heapDeltaBytes": -7855604,
      "heapUsedBytes": 63093488,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 160.258,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.990999999986,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.8140000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.0710000000001,
      "heapDeltaBytes": 11058712,
      "heapUsedBytes": 87371516,
      "domNodes": -273,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 34.836999999999996,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.377000000045,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.663000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.8179999999999,
      "heapDeltaBytes": 6344860,
      "heapUsedBytes": 82572928,
      "domNodes": -278,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 33.85300000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2348.165999999992,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.195999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1656.8419999999999,
      "heapDeltaBytes": -16010612,
      "heapUsedBytes": 87919040,
      "domNodes": -272,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 844.354,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2244.7479999999587,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.607000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1609.9940000000004,
      "heapDeltaBytes": 22353608,
      "heapUsedBytes": 88459224,
      "domNodes": -271,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 821.2109999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3518.285999999989,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.498,
      "layouts": 60,
      "layoutDurationMs": 11.66,
      "taskDurationMs": 1645.946,
      "heapDeltaBytes": 8375760,
      "heapUsedBytes": 76311356,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 766.362,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3532.4090000000297,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.137999999999996,
      "layouts": 60,
      "layoutDurationMs": 11.53,
      "taskDurationMs": 1746.7079999999999,
      "heapDeltaBytes": -2637804,
      "heapUsedBytes": 75490828,
      "domNodes": -276,
      "jsHeapTotalBytes": -2465792,
      "scriptDurationMs": 782.334,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3088.0149999999844,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.986000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1879.011,
      "heapDeltaBytes": 18013960,
      "heapUsedBytes": 86284044,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 944.0179999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3161.314999999945,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.855999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1950.1789999999999,
      "heapDeltaBytes": 24075064,
      "heapUsedBytes": 92342004,
      "domNodes": 0,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 981.4359999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.3569999999813,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.203000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 604.641,
      "heapDeltaBytes": 6303472,
      "heapUsedBytes": 83237136,
      "domNodes": -281,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 34.792,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2062.8260000000864,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 12.563999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 608.9519999999999,
      "heapDeltaBytes": 6070096,
      "heapUsedBytes": 83541216,
      "domNodes": -275,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 29.634000000000007,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.4140000000425,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.827000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.787,
      "heapDeltaBytes": 14177032,
      "heapUsedBytes": 80056976,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 139.99200000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 573.6210000000028,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.303,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.97499999999997,
      "heapDeltaBytes": 14749080,
      "heapUsedBytes": 87887296,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 143.892,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.2799999999665,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.277000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.52400000000006,
      "heapDeltaBytes": -6123344,
      "heapUsedBytes": 66986796,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.417,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.7780000001067,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.844999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.8950000000001,
      "heapDeltaBytes": -3598944,
      "heapUsedBytes": 68967212,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.414000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1753.3429999999726,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 26.283,
      "layouts": 18,
      "layoutDurationMs": 5.295,
      "taskDurationMs": 826.2510000000001,
      "heapDeltaBytes": -1800876,
      "heapUsedBytes": 71214220,
      "domNodes": -298,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 114.29299999999999,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1717.1879999999646,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.172999999999995,
      "layouts": 18,
      "layoutDurationMs": 4.707,
      "taskDurationMs": 799.26,
      "heapDeltaBytes": 10804648,
      "heapUsedBytes": 83501296,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 109.98,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.4990000000817,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.282000000000004,
      "layouts": 15,
      "layoutDurationMs": 15.330000000000004,
      "taskDurationMs": 904.3440000000003,
      "heapDeltaBytes": 21963616,
      "heapUsedBytes": 106190292,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 31.552999999999997,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8368.509000000016,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.23,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5773.014,
      "heapDeltaBytes": 8443484,
      "heapUsedBytes": 84742188,
      "domNodes": -271,
      "jsHeapTotalBytes": -700416,
      "scriptDurationMs": 2703.966,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8495.02700000005,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.196999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5832.05,
      "heapDeltaBytes": -8117556,
      "heapUsedBytes": 67953612,
      "domNodes": -283,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 2770.27,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16798.855999999945,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16320.446,
      "heapDeltaBytes": -40400428,
      "heapUsedBytes": 178555588,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8970240,
      "scriptDurationMs": 288.914,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16932.339999999953,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16350.933,
      "heapDeltaBytes": -39157276,
      "heapUsedBytes": 178028300,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10805248,
      "scriptDurationMs": 274.55400000000003,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21124.703000000012,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 18.51900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20888.833000000002,
      "heapDeltaBytes": -53751484,
      "heapUsedBytes": 165033712,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12390400,
      "scriptDurationMs": 926.742,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 80,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16361.536,
      "styleRecalcs": 99,
      "styleRecalcDurationMs": 13.376999999999972,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15714.604000000001,
      "heapDeltaBytes": -68582148,
      "heapUsedBytes": 170336488,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17477632,
      "scriptDurationMs": 874.853,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6219.655000000046,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.78399999999996,
      "layouts": 20,
      "layoutDurationMs": 22.364000000000008,
      "taskDurationMs": 6103.29,
      "heapDeltaBytes": -61022852,
      "heapUsedBytes": 177636720,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4804608,
      "scriptDurationMs": 108.77599999999998,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 421,
      "frameDurationMs": 18.33333333333327,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6370.116000000053,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 103.618,
      "layouts": 20,
      "layoutDurationMs": 35.147999999999996,
      "taskDurationMs": 6243.148,
      "heapDeltaBytes": -48281440,
      "heapUsedBytes": 175435964,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4128768,
      "scriptDurationMs": 117.08099999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 371,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8440.011000000028,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8267.864000000001,
      "heapDeltaBytes": 20028840,
      "heapUsedBytes": 178996052,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 127.7520000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8585.939000000053,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8323.754,
      "heapDeltaBytes": 21554728,
      "heapUsedBytes": 177216840,
      "domNodes": 0,
      "jsHeapTotalBytes": -9699328,
      "scriptDurationMs": 138.46400000000003,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 95.96899999996822,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 11.325000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.72,
      "taskDurationMs": 65.09500000000001,
      "heapDeltaBytes": 3112100,
      "heapUsedBytes": 71109568,
      "domNodes": 108,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.542000000000001,
      "eventListeners": 35,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 115.54499999999734,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 17.386,
      "layouts": 2,
      "layoutDurationMs": 1.4469999999999998,
      "taskDurationMs": 81.602,
      "heapDeltaBytes": 2991076,
      "heapUsedBytes": 70723584,
      "domNodes": 128,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.829999999999998,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50283 75334 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 21, 2026
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18266   +/-   ##
=============================================
  Coverage              ?   83.56%           
=============================================
  Files                 ?     2094           
  Lines                 ?   123580           
  Branches              ?    33404           
=============================================
  Hits                  ?   103268           
  Misses                ?    20134           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.75% <ø> (?)
unit 78.48% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kbench/extensions/agent/crdt/ecsFollowerAdapter.ts 96.78% <100.00%> (ø)
src/workbench/extensions/agent/crdt/opSender.ts 100.00% <100.00%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 97.77% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head adaptation review at 08a891fa18fdd3e499367fae5c53458a873c7ba9 against cloud/1.54 tip 1bbcdc66fa00c8462bfb50a8f3a77b48556675fb: no blocking findings.

I compared the seven-file target-local implementation with source PR #18063, including the op-sender suspension/retarget invariants, pending-delete lifetime, full-reconcile node/link filtering, and inactive-tab/reactivation ordering. The release adaptation preserves the source behavior without importing the later follower split. The automatic merge tree is exactly the reviewed head tree (64f07de35c9a786a808557cb0c0b8a4abf84cab9), and all 91 hosted checks are terminal non-adverse (78 success, 13 skipped; required unit, lint/format, and E2E gates pass).

Local suites were intentionally not rerun under the active host-resource restriction; this review relies on static exact-head inspection and hosted CI. COMMENT only: this records adaptation clearance and does not fabricate an approval.

@christian-byrne
christian-byrne merged commit 4985279 into cloud/1.54 Sep 21, 2026
95 checks passed
@christian-byrne
christian-byrne deleted the backport-18063-cloud-1.54 branch September 21, 2026 09:30
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants