Repository navigation
fix(agent-crdt): retain deletes across tab switches (cloud/1.54) - #18266
Conversation
Backport #18063 to cloud/1.54 by re-expressing the fix in the pre-split follower.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1931 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-21T09:08:47.108Z",
"gitSha": "bde4eec4c2807bee82ec2368a76d6dd6f7fb2940",
"branch": "backport-18063-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.2870000000253,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.076000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.065,
"heapDeltaBytes": 6474112,
"heapUsedBytes": 76881748,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.155,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2037.3989999999367,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.04400000000004,
"heapDeltaBytes": 4142928,
"heapUsedBytes": 73879780,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.827000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2052.8620000000046,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.45399999999999,
"layouts": 14,
"layoutDurationMs": 3.934999999999999,
"taskDurationMs": 1002.0400000000001,
"heapDeltaBytes": 8122112,
"heapUsedBytes": 79049500,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 179.73600000000002,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.3170000000428,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.487999999999996,
"layouts": 14,
"layoutDurationMs": 4.54,
"taskDurationMs": 900.591,
"heapDeltaBytes": 13402712,
"heapUsedBytes": 83158320,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 162.226,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.5590000000134,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.803999999999998,
"layouts": 6,
"layoutDurationMs": 1.167,
"taskDurationMs": 348.687,
"heapDeltaBytes": 4655988,
"heapUsedBytes": 75511184,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.797,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.2689999999693,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.060000000000002,
"layouts": 6,
"layoutDurationMs": 1.1580000000000001,
"taskDurationMs": 341.23199999999997,
"heapDeltaBytes": 4340896,
"heapUsedBytes": 74252344,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.318999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 651.5850000000114,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.598,
"heapDeltaBytes": 17861260,
"heapUsedBytes": 88340104,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 166.94,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 665.538999999967,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.93699999999995,
"heapDeltaBytes": -7855604,
"heapUsedBytes": 63093488,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 160.258,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.990999999986,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.8140000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.0710000000001,
"heapDeltaBytes": 11058712,
"heapUsedBytes": 87371516,
"domNodes": -273,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 34.836999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.377000000045,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.663000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.8179999999999,
"heapDeltaBytes": 6344860,
"heapUsedBytes": 82572928,
"domNodes": -278,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 33.85300000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2348.165999999992,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.195999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1656.8419999999999,
"heapDeltaBytes": -16010612,
"heapUsedBytes": 87919040,
"domNodes": -272,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 844.354,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2244.7479999999587,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.607000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1609.9940000000004,
"heapDeltaBytes": 22353608,
"heapUsedBytes": 88459224,
"domNodes": -271,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 821.2109999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3518.285999999989,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.498,
"layouts": 60,
"layoutDurationMs": 11.66,
"taskDurationMs": 1645.946,
"heapDeltaBytes": 8375760,
"heapUsedBytes": 76311356,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 766.362,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3532.4090000000297,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.137999999999996,
"layouts": 60,
"layoutDurationMs": 11.53,
"taskDurationMs": 1746.7079999999999,
"heapDeltaBytes": -2637804,
"heapUsedBytes": 75490828,
"domNodes": -276,
"jsHeapTotalBytes": -2465792,
"scriptDurationMs": 782.334,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3088.0149999999844,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.986000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1879.011,
"heapDeltaBytes": 18013960,
"heapUsedBytes": 86284044,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 944.0179999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3161.314999999945,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.855999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1950.1789999999999,
"heapDeltaBytes": 24075064,
"heapUsedBytes": 92342004,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 981.4359999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.3569999999813,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.203000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.641,
"heapDeltaBytes": 6303472,
"heapUsedBytes": 83237136,
"domNodes": -281,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 34.792,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2062.8260000000864,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.563999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.9519999999999,
"heapDeltaBytes": 6070096,
"heapUsedBytes": 83541216,
"domNodes": -275,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 29.634000000000007,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.4140000000425,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.827000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.787,
"heapDeltaBytes": 14177032,
"heapUsedBytes": 80056976,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.99200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.6210000000028,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.303,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.97499999999997,
"heapDeltaBytes": 14749080,
"heapUsedBytes": 87887296,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.892,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.2799999999665,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.277000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.52400000000006,
"heapDeltaBytes": -6123344,
"heapUsedBytes": 66986796,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.417,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.7780000001067,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.844999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.8950000000001,
"heapDeltaBytes": -3598944,
"heapUsedBytes": 68967212,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.414000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.3429999999726,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.283,
"layouts": 18,
"layoutDurationMs": 5.295,
"taskDurationMs": 826.2510000000001,
"heapDeltaBytes": -1800876,
"heapUsedBytes": 71214220,
"domNodes": -298,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 114.29299999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.1879999999646,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.172999999999995,
"layouts": 18,
"layoutDurationMs": 4.707,
"taskDurationMs": 799.26,
"heapDeltaBytes": 10804648,
"heapUsedBytes": 83501296,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 109.98,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.4990000000817,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.282000000000004,
"layouts": 15,
"layoutDurationMs": 15.330000000000004,
"taskDurationMs": 904.3440000000003,
"heapDeltaBytes": 21963616,
"heapUsedBytes": 106190292,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.552999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8368.509000000016,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5773.014,
"heapDeltaBytes": 8443484,
"heapUsedBytes": 84742188,
"domNodes": -271,
"jsHeapTotalBytes": -700416,
"scriptDurationMs": 2703.966,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8495.02700000005,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.196999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5832.05,
"heapDeltaBytes": -8117556,
"heapUsedBytes": 67953612,
"domNodes": -283,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 2770.27,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16798.855999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16320.446,
"heapDeltaBytes": -40400428,
"heapUsedBytes": 178555588,
"domNodes": -8068,
"jsHeapTotalBytes": -8970240,
"scriptDurationMs": 288.914,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16932.339999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16350.933,
"heapDeltaBytes": -39157276,
"heapUsedBytes": 178028300,
"domNodes": -8068,
"jsHeapTotalBytes": -10805248,
"scriptDurationMs": 274.55400000000003,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21124.703000000012,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.51900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20888.833000000002,
"heapDeltaBytes": -53751484,
"heapUsedBytes": 165033712,
"domNodes": -8068,
"jsHeapTotalBytes": -12390400,
"scriptDurationMs": 926.742,
"eventListeners": -14931,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16361.536,
"styleRecalcs": 99,
"styleRecalcDurationMs": 13.376999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15714.604000000001,
"heapDeltaBytes": -68582148,
"heapUsedBytes": 170336488,
"domNodes": -8068,
"jsHeapTotalBytes": -17477632,
"scriptDurationMs": 874.853,
"eventListeners": -14933,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6219.655000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.78399999999996,
"layouts": 20,
"layoutDurationMs": 22.364000000000008,
"taskDurationMs": 6103.29,
"heapDeltaBytes": -61022852,
"heapUsedBytes": 177636720,
"domNodes": -8068,
"jsHeapTotalBytes": 4804608,
"scriptDurationMs": 108.77599999999998,
"eventListeners": -14929,
"totalBlockingTimeMs": 421,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6370.116000000053,
"styleRecalcs": 20,
"styleRecalcDurationMs": 103.618,
"layouts": 20,
"layoutDurationMs": 35.147999999999996,
"taskDurationMs": 6243.148,
"heapDeltaBytes": -48281440,
"heapUsedBytes": 175435964,
"domNodes": -8068,
"jsHeapTotalBytes": 4128768,
"scriptDurationMs": 117.08099999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 371,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8440.011000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8267.864000000001,
"heapDeltaBytes": 20028840,
"heapUsedBytes": 178996052,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 127.7520000000001,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8585.939000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8323.754,
"heapDeltaBytes": 21554728,
"heapUsedBytes": 177216840,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 138.46400000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 95.96899999996822,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.325000000000001,
"layouts": 2,
"layoutDurationMs": 0.72,
"taskDurationMs": 65.09500000000001,
"heapDeltaBytes": 3112100,
"heapUsedBytes": 71109568,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.542000000000001,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 115.54499999999734,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.386,
"layouts": 2,
"layoutDurationMs": 1.4469999999999998,
"taskDurationMs": 81.602,
"heapDeltaBytes": 2991076,
"heapUsedBytes": 70723584,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.829999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18266 +/- ##
=============================================
Coverage ? 83.56%
=============================================
Files ? 2094
Lines ? 123580
Branches ? 33404
=============================================
Hits ? 103268
Misses ? 20134
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head adaptation review at 08a891fa18fdd3e499367fae5c53458a873c7ba9 against cloud/1.54 tip 1bbcdc66fa00c8462bfb50a8f3a77b48556675fb: no blocking findings.
I compared the seven-file target-local implementation with source PR #18063, including the op-sender suspension/retarget invariants, pending-delete lifetime, full-reconcile node/link filtering, and inactive-tab/reactivation ordering. The release adaptation preserves the source behavior without importing the later follower split. The automatic merge tree is exactly the reviewed head tree (64f07de35c9a786a808557cb0c0b8a4abf84cab9), and all 91 hosted checks are terminal non-adverse (78 success, 13 skipped; required unit, lint/format, and E2E gates pass).
Local suites were intentionally not rerun under the active host-resource restriction; this review relies on static exact-head inspection and hosted CI. COMMENT only: this records adaptation clearance and does not fabricate an approval.
Re-expresses the human-delete tab-switch fix from source PR 18063 on the pre-split
cloud/1.54follower.Full context for agent readers
Source: PR 18063 /
ddd9299baff1bd045be64b39f440e1f0df85eb60.Target parent:
cloud/1.54at1bbcdc66fa00c8462bfb50a8f3a77b48556675fb.The source fix targets modules introduced by the later follower split in PR 16908. This carrier deliberately does not backport that refactor. It places the same suspension and pending-delete semantics in the release line's existing
useAgentCrdtFollower.ts,opSender.ts, andEcsFollowerAdapterseams.The source's main-only browser spec and ADR were not copied. Release-local unit/integration cases cover the adapted seams. Expensive local test, typecheck, lint, format, build, and browser commands were deferred under the active host resource constraint; hosted CI is the first executable verification of this exact head.
No deployment, release, ruleset, or history mutation is included.
Justification: Owner-authorized guarded release backport — exact-head adaptation review found no blocking defect, the source behavior is preserved on the release-native seams, and 92 hosted checks are terminal non-adverse.