Repository navigation
[backport cloud/1.54] Agent fix gap sweep: 8 merged main fixes without a cloud carrier - #18257
Conversation
…t attachments (#18104) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789446697386139?thread_ts=1789446697.386139&cid=C0BGH348Z0C)_ ## Summary Replaces #18067 (originally a repro-only tests PR; same base branch could not be rewritten to drop an AI attribution trailer, see the comment there). This now includes the real fix plus the flipped tests. Fixes: dragging a non-first output of a multi-output/batch job (the "N layers" stack expansion in the asset sidebar) into the agent chat composer showed the wrong image once the message was sent. ## Root cause `UserMessage.vue`'s `splitAttachments` (`src/workbench/extensions/agent/components/agent/message/UserMessage.vue`) rebuilt the attachment image URL as `/view?filename={item.ref}&type=input` whenever `item.ref` was set, discarding the already-correct `item.previewUrl`. That's right for a genuine file upload, but the asset-drag-to-attach path (`AgentPanelRoot.vue`'s `attachDroppedAsset`) reuses the same `ref` field for an *existing output asset*'s identifier. A job's primary/representative output has a real content hash and happens to round-trip through `/view?...&type=input`. A non-first output reached via the "layers" stack expansion is synthesized client-side (`outputAssetUtil.ts`'s `mapOutputsToAssetItems`) and, by design, never gets a `.hash` — so its `ref` is a bare output filename, which `/view?type=input` does not resolve to the dragged file. Canvas drop and the job's first/primary output were unaffected, matching the original report. ## Fix Prefer `item.previewUrl` when present, and only fall back to the `/view?...&type=input` reconstruction when there's no `previewUrl`. This matches how `AttachmentChip.vue` already treats the same attachment shape in the draft composer — it renders `previewUrl` directly and never reconstructs a URL from `ref`. The fix is a single, isolated change: `item.ref` is used nowhere else for URL construction (its other uses are for uploading and sending the attachment reference to the backend), so no other call sites needed touching. ## Changes - `UserMessage.vue`: `splitAttachments` now prefers `previewUrl` over the `ref`-based reconstruction. - `UserMessage.test.ts`: the regression test that pinned this bug is flipped from `it.fails(...)` to a plain `it(...)` — it now passes. - `browser_tests/tests/agent/agentBatchOutputAttachment.spec.ts`: the `test.fail()` call is removed so the e2e repro is now a normal, expected-to-pass test. ## Test Plan - [x] `pnpm typecheck` passes - [x] `pnpm lint` (oxlint + eslint) passes on the changed files - [x] `pnpm format:check` (oxfmt) passes on the changed files - [x] Vitest: `UserMessage.test.ts` — 17/17 passed (previously 16 passed + 1 expected fail) - [ ] Playwright e2e — not executable in this sandbox (no backend/dev server); typechecks and lints cleanly, follows existing agent-panel spec conventions 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01ADPh3Nvwr5WhoC9HPVm2Ye --------- Co-authored-by: test-bot <test-bot@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit c61d9df)
…tay on their slots through undo/redo (#18110) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789592320785689?thread_ts=1789592320.785689&cid=C0BGH348Z0C)_ ## ELI5 A Vue node measures where each of its slot dots sits and stores the measurements so the canvas knows where to draw the wire end. Undo and redo rebuild the graph from a snapshot, and that rebuild throws all those measurements away, but the node on screen never changes and never re-measures. With no measurement the canvas falls back to its own guess of where the widget row is, and that guess can be a full row off, so the wire visibly lands on the wrong slot. This PR tells mounted Vue nodes to measure again whenever their stored measurements are dropped. ## Motivation Before: wiring a node into a Vue-rendered widget slot, then pressing undo and redo, could leave the wire end drawn on a different row than the slot dot it is connected to (38 px off on a promoted subgraph host with a multiline text widget above the slot, 10 px off on a plain EmptyLatentImage's third widget). The link stayed correct in the graph, only its rendering was wrong, and it stayed wrong until something else resized the node. After: the wire end stays on the slot dot through undo and redo, for subgraph hosts and plain nodes alike. Why: the graph reload behind undo and redo purges every DOM-measured slot offset from the layout store, and nothing re-measured a Vue node that survived the reload with identical rows and size. ## Provenance - **Authored by:** interactive session - **Verified:** Playwright `subgraphPromotedWidgetExternalLink.spec.ts` drift rows on the test-only commit: 2 failed on the drift assertion (host 38 px, plain batch_size 10 px); with the fix: both pass and the rest of the spec keeps its expected outcomes. Vitest `src/renderer/core/layout` + `src/renderer/extensions/vueNodes/components`: 33 files, 262 passed (the new NodeSlots case fails pre-fix with `expected null to deeply equal { x: 0, y: 20 }`). `vue-tsc --noEmit` and `vue-tsc --project browser_tests/tsconfig.json`: clean. eslint, oxlint, oxfmt on the changed files: clean. `knip --cache`: clean. `changeTracker.spec.ts` fails identically in the local sandbox with and without the fix (legacy-canvas collapse clicks and default-workflow node locators), so those failures are environmental there; CI is the arbiter. - **Deviations:** none ## Reviewer context - **Type:** bug fix, Vue node link rendering after undo/redo - **Slots into:** #18085 — test: add failing repros for promoted widget external-link rendering. This PR ports that spec and supersedes its `test.fail()` drift case (`keeps the wire on the promoted width slot dot after undo and redo`), which becomes a real table-driven regression test here with a plain-node row added; #18085 should drop that case once this lands. The label and textarea cases no longer carry `test.fail()`: the width-label cases assert the label stays visible after wiring, and the promoted text case asserts the textarea is enabled before wiring and visible but disabled afterward, with its input slot dot shown. ## How - `layoutStore` gains a reactive `slotOffsetVersion` that is bumped only when measured slot offsets are dropped in bulk (`clearGraph`, `clearViewGeometry`), never on a measurement write, so re-measuring cannot feed back into itself. - `NodeSlots.vue` adds that version to its existing `syncSlotOffsets` watch. Every mounted Vue node renders one `NodeSlots`, and `syncSlotOffsets` measures the whole `[data-node-id]` element, so one trigger per node re-measures every slot (inputs, outputs and widget rows). Purging on clear stays as is; keeping stale offsets would be wrong when the reload does change rows. ## Red-green verification | Commit | CI | Purpose | |---|---|---| | `test: cover the wire drifting off a Vue widget slot after undo and redo` | red | Playwright drift rows (host + plain node) and the NodeSlots re-measure case fail | | `fix: re-measure Vue node slot offsets after the layout store drops them` | green | same tests pass | ## Test plan - [ ] CI red on the test-only commit, green on the fix commit - [ ] Load a workflow with a Vue node whose widget rows differ in height from litegraph's layout (a multiline text widget above a number widget), wire a primitive into the number widget, click the canvas, Ctrl+Z, click elsewhere, Ctrl+Y: the wire end stays on the slot dot - [ ] Enter and leave a subgraph, then check links to widget slots still land on their dots --- _Generated by [Claude Code](https://claude.ai/code/session_01JwD8PkozfznCoUwAG46WAg)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit 38cc119)
…#18117) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789592320785689?thread_ts=1789592320.785689&cid=C0BGH348Z0C)_ ## ELI5 Dragging a wire out of a slot on a Vue node and dropping it on another slot connects the two nodes, but the undo history never hears about it. Press Ctrl+Z straight after the drop and nothing happens; you first have to click somewhere on the canvas, and that click is what finally writes the undo entry. This PR writes the entry the moment the drop finishes, the same way the classic canvas already does. ## Motivation Before: connect two Vue node slots by dragging, press Ctrl+Z: the link stays. Only a later canvas click, key press or widget edit records the connection, so undo looks like it needs two steps or does nothing. After: Ctrl+Z right after the drop removes the link. Why: the change tracker records canvas edits from the window `mouseup` event and from `LGraphCanvas.processMouseUp`. The Vue slot drag calls `preventDefault()` on `pointerdown`, which suppresses the compatibility `mouseup`, and the drop is resolved entirely inside the Vue composable, so neither hook runs and `captureCanvasState()` is never called. ## Provenance - **Authored by:** interactive session - **Verified:** Playwright `linkInteraction.spec.ts`, new case `undo right after dropping a link on a slot removes that link`: fails on the test-only commit (`expected 0, received 1` links after undo) and passes with the fix. The rest of the spec has the same outcome with and without the fix (9 cases fail in the local sandbox either way: 8 `toHaveScreenshot` baselines and one minimap overlay intercepting the subgraph button; a control run with the fix stashed reproduced all 9). A local probe confirmed the undo queue holds exactly one entry right after the drop. Root and `browser_tests` typecheck, full `pnpm lint`, `pnpm format:check`, eslint, oxlint and oxfmt on the changed files: clean. - **Deviations:** none ## Reviewer context - **Type:** bug fix, undo/redo for Vue node link drags - **Slots into:** #18085 (repro and isolation PR). The "undo needs an extra click" symptom surfaced while isolating the link drift there. The spurious undo entry after a redo is a separate tracker bug, fixed in #18118. - No unit test: the composable's pointer flow has no seam short of the ~200-line module-mock harness in `useSlotLinkInteraction.autoPan.test.ts`, so the e2e is the lowest level that proves the wiring. ## How `useSlotLinkInteraction.finishInteraction()` calls `captureCanvasState()` on the active workflow's change tracker after the drop is resolved and the canvas marked dirty, mirroring the `LGraphCanvas.processMouseUp` wrapper the tracker installs for the legacy canvas. `captureCanvasState()` compares against the last snapshot, so a drop that connects nothing pushes no entry, a second capture from any other hook is a no-op, and the legacy path is untouched. ## Red-green verification | Commit | CI | Purpose | |---|---|---| | `test: cover undo right after a Vue node slot drag-connect` (d8f3af7) | red | the new Playwright case fails: the link survives Ctrl+Z (e2e-status failed on shard 14 and the new-tests video job, everything else green) | | `fix: capture the canvas state when a Vue node slot link drag finishes` (2f9f6df) | green | same case passes, all checks green | ## Test plan - [x] CI red on the test-only commit (e2e-status failed on shard 14 and the new-tests video job) - [x] CI green on the fix commit - [ ] Drag a link between two Vue node slots, press Ctrl+Z immediately: the link is removed - [ ] Drag a link out of a slot and drop it on empty canvas, dismiss the search box: the undo queue does not grow --- _Generated by [Claude Code](https://claude.ai/code/session_01JwD8PkozfznCoUwAG46WAg)_ --------- (cherry picked from commit d08de57)
#18118) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789592320785689?thread_ts=1789592320.785689&cid=C0BGH348Z0C)_ ## ELI5 Redo rebuilds the graph from a saved snapshot. While rebuilding, the graph works out afresh the order in which nodes should run and stamps each node with a new number. The undo history then compares the live graph with its snapshot, sees those numbers differ, and concludes you edited something, so the next plain click on the canvas records a phantom "change". Pressing Ctrl+Z after that restores a snapshot that looks identical, so undo appears to do nothing and you have to press it twice. This PR makes the comparison ignore that run-order number, which the user never edits. ## Motivation Before: connect two nodes, undo, redo, click the canvas, press Ctrl+Z: the link stays. The click after the redo pushed an undo entry that differs from the live graph only in node `order`, so the first Ctrl+Z is a visible no-op and the redo queue is wiped. After: the click after a redo records nothing, and Ctrl+Z removes the redone link. Why: `ChangeTracker.graphEqual` deep-compares node objects, including `order`. `order` is the execution index that `LGraph.updateExecutionOrder()` recomputes on every configure, add or remove; a snapshot captured before a reload and the graph rebuilt from it legitimately disagree on it. The auto-queue comparison in the same file already lists `order` among the non-execution node properties it ignores. ## Provenance - **Authored by:** interactive session - **Verified:** Vitest `changeTracker.test.ts`, new case `does not push when only the recomputed node execution order differs`: fails on the test-only commit (`expected [ Array(1) ] to have a length of +0 but got 1`), and the whole file passes with the fix (63/63). Playwright `changeTracker.spec.ts`, new case `Undo after a redo and a canvas click removes the redone link`: fails on the test-only commit at its final assertion (`expected 0, received 1` links) with every earlier step passing, and passes with the fix. The other 6 failing cases in that spec fail identically in the local sandbox with the fix stashed (legacy-menu and subgraph-entry environment issues) and are green in CI. Full `pnpm lint`, `pnpm format:check`, typecheck, eslint, oxlint and oxfmt on the changed files: clean. - **Deviations:** none ## Reviewer context - **Type:** bug fix, undo/redo change detection - **Slots into:** #18085 (repro and isolation PR). The phantom entry was found while isolating the link drift there. The missing undo entry for a Vue node slot drag-connect is a separate bug, fixed in #18117. - The e2e clicks two different empty spots on purpose: two same-spot clicks inside the double-click window open node search, which swallows Ctrl+Z and Ctrl+Y. ## How `graphEqual` compares the two node lists with `order` omitted from every node. Nothing else in the comparison changes. ## Red-green verification | Commit | CI | Purpose | |---|---|---| | `test: cover the spurious undo entry pushed by a canvas click after redo` (e7539e0) | red | the unit case pushes an entry for an order-only difference (unit `test` job failed); the Playwright case leaves the link in place after the post-redo Ctrl+Z (e2e-status failed on shard 2 and the new-tests video job) | | `fix: ignore recomputed node execution order when comparing graph snapshots` (c2cffd8) | green | same cases pass, all checks green | ## Test plan - [x] CI red on the test-only commit (unit `test` job and e2e-status failed, shard 2 and the new-tests video job) - [x] CI green on the fix commit - [ ] Connect two nodes, Ctrl+Z, Ctrl+Y, click empty canvas, Ctrl+Z: the link is removed on the first press - [ ] Move a node, click the canvas, Ctrl+Z: the move is still undone (a real change is still detected) --- _Generated by [Claude Code](https://claude.ai/code/session_01JwD8PkozfznCoUwAG46WAg)_ --------- (cherry picked from commit 5347eda)
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789788571314109?thread_ts=1789788571.314109&cid=C0BGH348Z0C)_ ## Before `showSubscriptionRequiredDialog` — the seam every "Subscribe" CTA routes through, including the in-app agent panel's paywall card (`AgentPaywallCard.vue` → `AgentPanelRoot.vue`'s `onPaywallAction` → `useAccountPreconditionDialog`) — returned early whenever `window.__CONFIG__?.subscription_required` read falsy: ```ts if (!isCloud || !window.__CONFIG__?.subscription_required) { return } ``` `window.__CONFIG__` is only populated once the bootstrap `/features` fetch resolves (`refreshRemoteConfig()`). A caller that fires before that fetch resolves — plausible right after a fresh page load, e.g. a user landing on a cloud surface and immediately triggering the agent paywall — hit a **completely silent no-op**: no dialog, no toast, no telemetry, no retry. The click just did nothing. ## After - If the config hasn't loaded yet (`remoteConfigState` is `'unloaded'`), await one fresh `/features` fetch before deciding. - If the gate is still closed afterward, report it via `reportError()` instead of returning silently, so this is visible in telemetry instead of only surfacing as a user bug report. ## Test plan - `src/services/dialogService.subscriptionRequired.test.ts` (unit, deterministic): covers the non-cloud no-op, the already-loaded happy path, the retry-on-unloaded-config path (the exact timing race this fix targets, via a mocked `remoteConfigState`), and the reported-failure path. Confirmed red against the pre-fix code, green after. - `browser_tests/tests/agent/agentPaywallSubscribe.spec.ts` (new, e2e): drives the real chat panel end to end through the agent-integration fixtures in `browser_tests/tests/agent/` (`agentPanelMocks.ts`'s `agentTest`/`agentPanel`). A mocked `no_funds` turn rejection surfaces the real `AgentPaywallCard`, and clicking its real "Subscribe" button is asserted to: - open the real subscription dialog (`[aria-labelledby="subscription-required"]`) when the config gate is open — with a screenshot of the paywall card and the opened dialog attached as test evidence for visual proof; - otherwise report the failure via the new `reportError()` call (asserted via a captured `console.error` containing `error_opening_subscription_dialog_gate_closed`) instead of silently doing nothing, when the gate stays durably closed. - Note: the literal race this fix guards against (`remoteConfigState === 'unloaded'` at click time) is only reachable in this app while the whole UI — including the agent panel itself, which is gated behind the same `/features`-driven PostHog flag — has not yet booted, so it cannot be driven from a live page through the DOM; that exact branch is what the unit test covers deterministically. The e2e spec instead proves the two real, reachable end states (`subscription_required` true vs. durably false) drive the correct real-browser outcome for this exact regression. - `pnpm exec vitest run src/services/dialogService` — 41/41 passing. - `pnpm exec eslint`, `pnpm exec oxlint --type-aware`, `pnpm exec oxfmt --check` on the new spec — clean. - `pnpm exec vue-tsc --noEmit` — clean (full project, includes `browser_tests`). - The new Playwright spec itself was not run in this sandbox (no browser/backend available here); it was verified via lint/format/typecheck and by tracing every fixture and route it depends on against the existing, passing `browser_tests/tests/agent/agentPanel.spec.ts` for identical patterns (workflow selection, composer/send locators, `agentPanelMocks.ts` route overrides, `subscription.spec.ts`'s remock-then-reload pattern, and `consoleErrorCollector.ts`). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01JbnJ4RxoJA8aRva1EA7g5K --- _Generated by [Claude Code](https://claude.ai/code/session_01JbnJ4RxoJA8aRva1EA7g5K)_ --------- (cherry picked from commit 1fc4bdb)
## Summary Restore the spare autogrow input after Agent reconciliation so dynamic-node wires remain aligned with their user-facing widgets. ## Changes - **What**: Re-run autogrow reconciliation for live Agent-owned nodes and add a regression test that reproduces the omitted spare input. ## Review Focus The repair uses the existing autogrow growth path and preserves the connected input and link while restoring only the missing spare slot. Fixes [PM-1155](https://linear.app/comfyorg/issue/PM-1155/fix-autogrow-widget-wiring-displays-on-the-wrong-widget-despite-a) ## Screenshots (if applicable) Manually verified with the real OpenAI GPT Image 2 node: the Load Image wire lands on `image_1`, `image_2` remains available, and the node retains its normal labels and controls. ## Test Plan - `pnpm test:unit src/workbench/extensions/agent/crdt/agentNodeMaterializer.test.ts` - `pnpm test:unit src/core/graph/widgets/dynamicWidgets.test.ts` - `pnpm typecheck` - targeted oxfmt, oxlint, and ESLint checks --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 3c20214)
…18191) <!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789890737989329?thread_ts=1789890737.989329&cid=C0BGH348Z0C)_ Three commits, red then green, so CI proves the test catches the bug: - `5203929` — the failing repro alone (red) - `b57144d` — the minimal fix (green) - `0c9010e` — coverage for the mint-side branch Rebased onto `81fc722`. The merge queue caught a semantic conflict that neither this branch nor main showed alone: `GraphMutationsDeps` gained a required `placement` port while this was open, so the new test's `createGraphMutations` call no longer compiled once merged. Fixed in the commit that introduces the file, so every commit still typechecks. ## Before A node added through the v2 search box with FollowCursor on renders at 60% opacity with `pointer-events-none` forever. It cannot be clicked, selected, moved, or deleted. A browser reload does not clear it, because the state lives in the document rather than in the tab. ## After Placing a node leaves it fully opaque and interactive, and it stays that way across any number of follower reconciles. Documents already carrying the flag are healed on the next read. ## What was happening `flags.ghost` is transient placement state: "semi-transparent, following cursor" (`src/lib/litegraph/src/interfaces.ts:351`). It should live from the search-box add until the click that drops the node. It leaked into the CRDT document instead: 1. `LGraph.add` sets `node.flags.ghost = true` (`LGraph.ts:1382`) **before** `attachNodeLayout` (`:1404`), and only starts placement afterwards (`:1411`). 2. `attachNodeLayout` fires the `createNode` layout change that `layoutMintPort` turns into `add_node`, whose payload is `serializeNode(...)` — taken while placement is still live, so it carries `flags: { ghost: true }`. 3. Clicking to place runs `finalizeGhostPlacement(false)`, which does `delete node.flags.ghost` and fires `node:property:changed` (`LGraphCanvas.ts:3778-3784`). **Nothing in the CRDT layer listens to that event**, and the three mint ports only cover createNode/deleteNode/clearGraph, links and widgets. No wire op carries the clear, so the document kept `ghost: true` permanently. 4. `flags` is in `RESYNCED_NODE_FIELDS` (`ecsFollowerAdapter.ts:38`). Any full reconcile re-reads every node, `prepareNode` cloned the document's flags verbatim, and `assignNodeFields` replaced `state.flags` wholesale (`nodeDataStore.ts`). 5. `LGraphNode.vue` then rendered it dead: `globalOpacity * 0.6` (`:375`) and `pointer-events-none` (`:24-27`). Neither depends on `isGhostPlacing`, so with placement long finished nothing would ever call `finalizeGhostPlacement` again. The trigger is any full reconcile — a resubscribe after a doc gap, a tab switch, or a rejected batch re-arming. The window is the gap between the clear and the next reconcile, which is why only some placed nodes showed it while the rest sat on the same latent `ghost: true`. ## The fix The document is authoritative data; `ghost` is presentation logic, so it should never have been in there (ADR-CRDT-LAYOUT-0003). Stripped at both boundaries: - **`graphMutations.ts`** — `prepareNode` drops `ghost` from the flags it builds, and from `lastSerialization` (which feeds `serialize()` for unregistered node types, so the flag cannot round-trip into a saved workflow either). A reconcile can no longer resurrect it, and documents already carrying it are healed. - **`layoutMintPort.ts`** — `add_node` omits `ghost` from its mid-placement snapshot, so new documents never record it. Read-side alone would leave every document accumulating the flag; mint-side alone would not help anyone whose document already has it. Both are needed. The local placement preview is untouched: `LGraph.add` sets the flag directly on the node's own state, never through `prepareNode`. Interaction during placement is gated by `isGhostPlacing`, not by the flag, so only the document's copy is affected. ## How it is proven `ghostPlacementFlag.test.ts` drives the real `createGraphMutations` seam: add a node whose payload carries `flags.ghost`, delete the flag the way placement does, reconcile from the document, assert the live node is no longer ghosted. Asserted at the invariant rather than at a chosen fix site. `layoutMintPort.test.ts` covers the mint side: a node serialized mid-placement mints an `add_node` with `ghost` gone and its other flags intact. Reverting the two source files puts both back to red. Patch coverage 100%. Related symptoms are collected in the internal agent-feedback tracker; this PR covers the ghost-node half only, not the separate links-not-rendering report filed alongside it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_016jorVkGmycSkD6j7A6sdJV --------- (cherry picked from commit dad05c5)
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789893497566839)_ ## Summary **Before:** Starting a new chat in the agent panel kept targeting whatever workflow tab the *previous* chat was pointed at, even after you had switched to a different tab (or opened a brand new one). Telling the agent to do something "in this workflow" could silently act on a tab that was no longer on screen. **After:** Starting a new chat now targets whichever workflow tab is on screen at that moment - whether you got there by switching to an already-open tab or by creating a fresh one. ## Changes - **What**: `onNewChat()` in `AgentPanelRoot.vue` now sets the agent panel's workflow target to `workflowStore.activeWorkflow` before starting the new chat, instead of leaving the previous chat's target in place. This mirrors `onSelectHistory()`, which already resets the target before loading a different thread. - **Breaking**: none ## Review Focus - `AgentPanelRoot.test.ts`: updated `retains an explicitly chosen target across panel reopen and New Chat` (renamed to `... across a plain panel reopen`) because it asserted the stale-target carryover as intentional; a plain panel reopen (no New Chat) still keeps the explicit target, which is unchanged. - Added tests: New Chat retargets to a tab switched to, to a freshly created/unsaved tab, and clears to "no target" when no tab is open. - Added a Playwright e2e spec, `browser_tests/tests/agent/agentNewChatTargetWorkflow.spec.ts`, covering the same tab-switch and tab-creation flows end to end (with screenshot attachments so a video is captured for this area). - Supersedes the repro-only PR #18080. That PR's test asserted a blank "select a workflow" state after New Chat; the accepted PM-1321 acceptance criteria call for the tab on screen instead, so this PR ships its own e2e spec rather than extending that one. Fixes PM-1321, PM-1322, PM-1415 ## Tests run - `pnpm typecheck` - clean - `pnpm lint` (eslint/oxlint/oxfmt scoped to the changed files, plus the repo's pre-commit/pre-push hooks) - clean - `pnpm test:unit -- src/workbench/extensions/agent/AgentPanelRoot.test.ts` - 226/226 passed - `pnpm test:unit -- src/workbench/extensions/agent/stores/agent/agentPanelTarget.test.ts` - 2/2 passed - Full unit suite (`pnpm test:unit`) - 22367 passed, 14 expected fail, 7 skipped, 0 regressions ## Screenshots (if applicable) See the attached screenshots/video on the new Playwright spec's test run in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_015KZNRdWz5cXQPvyefA7ChC (cherry picked from commit ef479c2)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T03:41:37.155Z",
"gitSha": "8287a915d8053cdbe3dce9f8a12e1d1f5c9493ad",
"branch": "backport-cloud-1.54-ms215-gap-20260921b",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2113.125000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.5540000000001,
"heapDeltaBytes": -10948116,
"heapUsedBytes": 58873940,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.532999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2045.5189999999561,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.9469999999999,
"heapDeltaBytes": -10566240,
"heapUsedBytes": 59777452,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.720000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1833.6180000000013,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.139,
"layouts": 14,
"layoutDurationMs": 4.15,
"taskDurationMs": 879.419,
"heapDeltaBytes": -13136304,
"heapUsedBytes": 57636436,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 162.33700000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1897.1669999999676,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.486,
"layouts": 14,
"layoutDurationMs": 4.122,
"taskDurationMs": 881.2070000000001,
"heapDeltaBytes": 4674808,
"heapUsedBytes": 75783232,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 163.36800000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.1369999999756,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.317,
"layouts": 6,
"layoutDurationMs": 1.5810000000000002,
"taskDurationMs": 373.53499999999997,
"heapDeltaBytes": 4536688,
"heapUsedBytes": 75480896,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.764999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.1679999999442,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.000000000000004,
"layouts": 6,
"layoutDurationMs": 0.9490000000000002,
"taskDurationMs": 349.20400000000006,
"heapDeltaBytes": 3555296,
"heapUsedBytes": 68811092,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.446000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 645.3240000000164,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.581,
"heapDeltaBytes": -7247016,
"heapUsedBytes": 63130780,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 164.52999999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 665.6270000000859,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.348,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.11199999999997,
"heapDeltaBytes": -7547432,
"heapUsedBytes": 63376900,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 163.464,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2034.1620000000376,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.477000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.084,
"heapDeltaBytes": 11107656,
"heapUsedBytes": 87391592,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 36.19900000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2057.515999999964,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.6530000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.931,
"heapDeltaBytes": 10783336,
"heapUsedBytes": 87036312,
"domNodes": -269,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 34.04399999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2326.252000000011,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.264000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1725.428,
"heapDeltaBytes": 1038644,
"heapUsedBytes": 78226824,
"domNodes": -285,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 859.093,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2326.4900000000353,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.402000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1666.656,
"heapDeltaBytes": 8527160,
"heapUsedBytes": 86117312,
"domNodes": -275,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 829.9949999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3533.0230000000142,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.836,
"layouts": 60,
"layoutDurationMs": 11.792999999999997,
"taskDurationMs": 1691.306,
"heapDeltaBytes": 11790588,
"heapUsedBytes": 80319160,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.19,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3609.9179999999933,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.545999999999998,
"layouts": 60,
"layoutDurationMs": 12.094000000000001,
"taskDurationMs": 1723.3719999999998,
"heapDeltaBytes": 10384920,
"heapUsedBytes": 76309916,
"domNodes": -279,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 776.011,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3095.6620000000044,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.841999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1957.0499999999997,
"heapDeltaBytes": 20826648,
"heapUsedBytes": 88928760,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 962.5719999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3144.241000000079,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.624,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1953.4159999999997,
"heapDeltaBytes": 25144264,
"heapUsedBytes": 92686884,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 957.9859999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.032999999998,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9430000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.336,
"heapDeltaBytes": 21696888,
"heapUsedBytes": 88832856,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.712999999999994,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2071.898000000033,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.402000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.0049999999999,
"heapDeltaBytes": 4152504,
"heapUsedBytes": 81855880,
"domNodes": -285,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 33.817,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.323999999976,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.945000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.509,
"heapDeltaBytes": 14766856,
"heapUsedBytes": 88134944,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 137.902,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.3020000000224,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.87800000000004,
"heapDeltaBytes": 14383884,
"heapUsedBytes": 86647896,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.279,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.216000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.18399999999997,
"heapDeltaBytes": -8555252,
"heapUsedBytes": 63948372,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 7.800999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.5349999999244,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.688,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.8419999999999,
"heapDeltaBytes": 10066232,
"heapUsedBytes": 83016504,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.093999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.2470000000149,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.571000000000005,
"layouts": 18,
"layoutDurationMs": 4.443,
"taskDurationMs": 812.5290000000001,
"heapDeltaBytes": -8969120,
"heapUsedBytes": 63681924,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 108.02300000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.6659999999993,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.087,
"layouts": 18,
"layoutDurationMs": 5.088,
"taskDurationMs": 828.5010000000002,
"heapDeltaBytes": 4091876,
"heapUsedBytes": 77492716,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 113.23999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.2070000000408,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.06900000000001,
"layouts": 15,
"layoutDurationMs": 15.952999999999998,
"taskDurationMs": 939.1709999999999,
"heapDeltaBytes": 21945164,
"heapUsedBytes": 105279328,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.613,
"eventListeners": 2385,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8567.045999999948,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.566,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5954.708999999999,
"heapDeltaBytes": -8531404,
"heapUsedBytes": 67656340,
"domNodes": -269,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 2742.067,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8863.18499999993,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.313,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6066.298,
"heapDeltaBytes": -34162936,
"heapUsedBytes": 68823336,
"domNodes": -265,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 2833.9660000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17142.93600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16706.087,
"heapDeltaBytes": -60353480,
"heapUsedBytes": 179679560,
"domNodes": -8068,
"jsHeapTotalBytes": -16953344,
"scriptDurationMs": 274.925,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17289.500999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16749.385,
"heapDeltaBytes": -60127508,
"heapUsedBytes": 177109788,
"domNodes": -8068,
"jsHeapTotalBytes": -20099072,
"scriptDurationMs": 273.76599999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20772.81099999999,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.843999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20455.265,
"heapDeltaBytes": -42044216,
"heapUsedBytes": 181849832,
"domNodes": -8068,
"jsHeapTotalBytes": -14704640,
"scriptDurationMs": 892.495,
"eventListeners": -14929,
"totalBlockingTimeMs": 138,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21026.742999999897,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.91799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20693.674000000003,
"heapDeltaBytes": -69175648,
"heapUsedBytes": 170146544,
"domNodes": -8068,
"jsHeapTotalBytes": -18526208,
"scriptDurationMs": 953.554,
"eventListeners": -14929,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6238.091999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.21299999999998,
"layouts": 20,
"layoutDurationMs": 22.308999999999994,
"taskDurationMs": 6159.456999999999,
"heapDeltaBytes": -54024264,
"heapUsedBytes": 184754136,
"domNodes": -8068,
"jsHeapTotalBytes": 12943360,
"scriptDurationMs": 112.77199999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 377,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6204.864000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.95399999999998,
"layouts": 20,
"layoutDurationMs": 23.826000000000015,
"taskDurationMs": 6110.4220000000005,
"heapDeltaBytes": -57492704,
"heapUsedBytes": 182190732,
"domNodes": -8068,
"jsHeapTotalBytes": 8974336,
"scriptDurationMs": 109.257,
"eventListeners": -14931,
"totalBlockingTimeMs": 521,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8963.285999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8479.996,
"heapDeltaBytes": 7014924,
"heapUsedBytes": 178960152,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 143.265,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8801.932999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8468.491,
"heapDeltaBytes": 6586392,
"heapUsedBytes": 178579472,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 142.58500000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 105.02999999999929,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.342,
"layouts": 2,
"layoutDurationMs": 0.993,
"taskDurationMs": 74.60599999999998,
"heapDeltaBytes": 3019356,
"heapUsedBytes": 71531824,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.142,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 130.6920000000673,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.284,
"layouts": 2,
"layoutDurationMs": 0.693,
"taskDurationMs": 80.931,
"heapDeltaBytes": 3010156,
"heapUsedBytes": 71171700,
"domNodes": 106,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.938,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18257 +/- ##
=============================================
Coverage ? 83.81%
=============================================
Files ? 2113
Lines ? 125654
Branches ? 33939
=============================================
Hits ? 105315
Misses ? 20160
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- Drop the globalEnums mock in useSlotLinkInteraction.autoPan.test.ts: the picked useSlotLinkInteraction change now pulls draw.ts/BaseWidget.ts, which read RenderShape from the real module (main has no such mock either). - Skip the 'hides the text control' case in subgraphPromotedWidgetExternalLink.spec.ts: it asserts #17576 behavior (WidgetGrid retains labels for connected inputs) that is not on cloud/1.54. Re-enable when #17576 is backported.
|
New head Full context for agent readersBoth failures were test surface mismatches between
Commit: |
oxlint playwright/no-skipped-test rejects .skip(); test.fixme is the convention already used on this branch for deferred browser cases.
|
Head moved to a63fef35ae: the deferred browser case now uses |
There was a problem hiding this comment.
Verdict: changes requested
Pre-merge blockers:
- P1: the touched
useSlotLinkInteraction.autoPan.test.tssuite fails during collection at this exact head because its total@vueuse/coremock omitsuseStorage. The focused run completed with 405 passing tests but one failed suite and zero tests from that file.
Findings without an anchorable line
- P3, PR description: the exact-head verification says "405 passed, 0 failed," but the exact-head run has 405 passing tests and one collection failure. It also still describes two adaptation commits even though this head has four, and the byte-identical-tree claim names the earlier
d1f35ac622tree; the current tree differs in two test files. - P3, changed browser specs: the long multi-action regression flows in
agentBatchOutputAttachment.spec.ts,agentNewChatTargetWorkflow.spec.ts,agentUploadedImageAttachment.spec.ts,changeTracker.spec.ts,subgraphPromotedWidgetExternalLink.spec.ts, andlinkInteraction.spec.tshave notest.stepboundaries. Please name the major user phases so a CI failure identifies the broken phase rather than only the whole test.
Existing findings confirmed or contested
- The prior DrJKL review had no inline findings. Its approval applied to
210e191fc9, not this head.
Checked and cleared
- I compared all eight source PR merge commits. Five patch IDs match exactly. The other three differences are release-context differences or the documented Pinia adaptation: #18104 applies the same
previewUrlhunk over the release's existingonErrorpath, #18110 differs in test setup, and #18127 differs only in surrounding imports. I found no dropped runtime source hunk. - The
test.fixmedoes not hide an #18110 regression row; it defers behavior from #17576 that is absent fromcloud/1.54. I still left a maintainability finding because a permanently disabled test is not executable release coverage. - I did not treat the closed subscription gate's telemetry-only response or retry-only-while-
unloadedbehavior as new defects. Those choices match source PR #18124's stated design. - I did not require another unit test for the link-drop capture. The carried Playwright regression covers the pointer wiring that the existing unit harness does not expose.
- Findings from lens passes against files outside the 32-file PR diff were rejected as not introduced by this PR.
- Full lint completed with 0 errors and baseline warnings only. Main and browser typechecks and format check passed.
Coverage
Deep review at a63fef35aef5d145a1e1c85c196d56339ed6fbf0 against cloud/1.54. I ran correctness, maintainability, idiomaticity, tests, and documentation lanes across browser, core/renderer/services, Agent UI, and Agent CRDT ownership shards, plus every applicable deep specialist lens. I read the repository guidance, browser test rulebook, and CRDT/ECS ADRs. Local checks: focused unit run 405 passed plus 1 failed collection suite; pnpm typecheck, pnpm typecheck:browser, pnpm lint, and pnpm format:check passed. Hosted checks were mostly green, with unit test, one Playwright shard, and perf still in progress in the required one-time snapshot.
Additional P2/P3 findings
- P2,
src/services/dialogService.ts:483-521: the generic dialog service now owns cloud feature readiness, subscription-gate policy, and feature-specific telemetry before dynamically importing a subscription composable that itself imports the dialog service. Move the cloud bootstrap/gate policy to the subscription boundary so this service remains a dialog primitive and the dependency direction is one-way. - P3 Nit,
src/services/dialogService.subscriptionRequired.test.ts:1-8,84-86,src/workbench/extensions/agent/AgentPanelRoot.test.ts:3033-3036,3085-3087, andsrc/workbench/extensions/agent/components/agent/message/UserMessage.test.ts:184-190: these added comments restate the test titles, fixture values, and assertions. Remove them. - P3 Nit,
src/services/dialogService.ts:488-507andsrc/workbench/extensions/agent/AgentPanelRoot.vue:894-896: these production comments paraphrase the following branches and assignment. Keep the code and remove the narration. - P3 Nit,
src/workbench/extensions/agent/crdt/graphMutations.ts:223-229,src/workbench/extensions/agent/crdt/layoutMintPort.ts:74-79, andghostPlacementFlag.test.ts:29-41,84-91: these blocks repeat the same ghost lifecycle at length. Once the policy has one owner, keep one concise contract there and delete the repeated explanations. - P3,
src/renderer/extensions/vueNodes/components/NodeSlots.test.ts:259-319: the three adjacent slot-offset tests repeat Pinia, graph/canvas wiring, geometry spies, node data, render, and the first tick. Move that invariant setup to the narrow describe/test lifecycle and leave each scenario's trigger and assertion in the test. - P3,
src/workbench/extensions/agent/crdt/ghostPlacementFlag.test.ts:61-65: Vitest already resets mocks before each test in this configuration, so this localmockResethook is redundant. - P3,
src/workbench/extensions/agent/AgentPanelRoot.test.ts:3071: avoid the non-null assertion on nullableactiveWorkflow; capture/assert the workflow created by setup before passing it tocloseWorkflow. - P3,
browser_tests/tests/subgraph/subgraphPromotedWidgetExternalLink.spec.ts:71-74: replace the two non-null DOM assertions inpage.evaluatewith explicit runtime checks so a missing node/canvas fails with a useful boundary error. - P3 Nit, PR description: split the eight-source semicolon chain into one scannable item per source PR, and update the adaptation and tree-identity claims for the current head.
| @@ -204,10 +204,6 @@ vi.mock('@/lib/litegraph/src/LLink', () => ({ | |||
| slotFloatingLinks: () => [] | |||
There was a problem hiding this comment.
P1: This suite no longer collects at this head. The total @vueuse/core mock above exposes only useEventListener and tryOnScopeDispose, while the changed composable now reaches remoteConfig.ts, which imports useStorage. The focused run fails with No useStorage export is defined and runs zero tests from this file. Please preserve the real exports with a partial mock, or add the missing typed export, and rerun this file.
There was a problem hiding this comment.
Fixed in 249123390c: narrow VueUse mock restored; useWorkflowStore seam mocked instead.
Full context for agent readers
The @vueuse/core mock is back to the useEventListener/tryOnScopeDispose shape from a63fef35ae. The project-owned @/platform/workflow/management/stores/workflowStore is mocked to { activeWorkflow: null } so the suite collects without loading the store/remote-config graph. Hosted CI on 2991cfc3f8 is the verification of record.
| type: payload.type, | ||
| title: nodeTitle(payload.title, payload.type), | ||
| flags: cloneRecord(payload.flags), | ||
| flags, |
There was a problem hiding this comment.
P2: This replacement introduces a placement race. A locally minted add_node now omits ghost; if its echo reconciles before the placement click, prepareNode replaces the incumbent flags with this empty set and the node becomes fully opaque while it is still following the cursor. isGhostPlacing keeps it inert, but LGraphNode.vue derives the 60% preview opacity from flags.ghost. Please preserve the incumbent local ghost bit while placement is active and add the echo-before-click case to ghostPlacementFlag.test.ts.
| lastSerialization: structuredClone({ | ||
| ...payload, | ||
| flags | ||
| }) as unknown as ISerialisedNode, |
There was a problem hiding this comment.
P2: This new object is forced through unknown into ISerialisedNode, so TypeScript does not verify that the filtered payload still satisfies the serialized-node contract. Repository guidance explicitly forbids as unknown as. Please construct or validate the authoritative serialized shape instead of overriding the compiler.
| * record it: the placement click clears the flag locally and mints no op, so the | ||
| * document's copy would outlive the placement it describes. | ||
| */ | ||
| function withoutGhostFlag(node: WorkflowNode): WorkflowNode { |
There was a problem hiding this comment.
P2: The same persistence rule is now implemented independently here and in graphMutations.cloneNodeFlags(). Correctness depends on every future document producer and consumer remembering that ghost is transient. Please put this rule in one serialization boundary/type and reuse it at mint and follower ingress rather than maintaining two filters and two explanations.
|
|
||
| type RemoteConfigState = 'unloaded' | 'anonymous' | 'authenticated' | 'error' | ||
| const remoteConfigState = vi.hoisted( | ||
| () => ({ value: 'unloaded' }) as Ref<RemoteConfigState> |
There was a problem hiding this comment.
P3: This duplicates the private production state union and casts a plain object to Vue's Ref, although it is not a ref. The copy can drift without a compiler error. Please export/derive the authoritative state type and use ref(), or type this holder only by the minimal { value: ... } contract the mocked consumer needs.
| await Promise.resolve() | ||
| } | ||
|
|
||
| it('restores a usable spare autogrow input omitted by reconciliation', async () => { |
There was a problem hiding this comment.
P3: This regression is nested under with mint ports attached and pays for full mint wiring even though it never inspects minted operations. Please place it under the narrower reconciliation setup so the test owns only the collaborators needed by reconcileAutogrowInputs.
| const result = await options.upload(file) | ||
| options.update(id, { ref: result.ref, uploading: false }) | ||
| options.update(id, { | ||
| ref: result.ref, |
There was a problem hiding this comment.
P3: The sole upload contract calls this value url, then this composable immediately translates it to previewUrl. Please name the field previewUrl at the producer contract so readers do not have to infer that these two names are the same concept.
|
|
||
| test.use({ connectWebSocketToServer: false }) | ||
|
|
||
| // Dragging a non-first output of a multi-output/batch job (the "layers" |
There was a problem hiding this comment.
P3 Nit: This large opening block and the later Lens 1/2 comments narrate the bug, fixture data, and assertions that the test name and values already show. Please keep only the non-obvious ProseMirror constraint and remove the rest of the narration.
|
|
||
| const test = mergeTests(agentTest, workflowSelectionTest) | ||
|
|
||
| // PM-1321 (parent) / PM-1322 (tab switch) / PM-1415 (tab creation): New Chat |
There was a problem hiding this comment.
P3 Nit: The file header and step-by-step comments restate the test names and immediately following actions. Please remove the narrative comments and retain only constraints the code cannot express.
| return this._contentSizeVersion | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
P3 Nit: This docblock records the current regression rather than the counter's stable contract. A concise description such as Reactive revision for bulk slot-offset invalidation would stay accurate when another consumer is added.
Keep the focused event-listener overrides while allowing release-native transitive imports such as useStorage.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: carrier fixes are ready; current-head documentation and release sign-off remain.
I reviewed 2991cfc3f8a0f5cdb7a0fe8fccb1889a6cd2d03f. The two carrier-specific findings are addressed: 249123390c mocks the project-owned workflow-store seam and restores the narrow VueUse mock, and 2991cfc3f8 removes the release-inapplicable static fixme while preserving both active #18110 undo/redo rows. The focused auto-pan suite passes 4/4 with 124 ms import time, down from 8.37 seconds at the prior partial-mock head.
I will not hold this carrier on the 29 unchanged P2/P3 findings that are byte-identical to merged source code. They remain valid non-blocking findings, but the non-divergent path is to fix them on main and re-pick them onto release branches. The own-echo ghost-opacity race remains the most material of those follow-ups.
New findings:
- P3, PR body Summary and Exact-head verification: the body still says there are five test-only adaptations, identifies
118ac5e9c6as current, and says no current-head local verification ran. The live head has seven adaptations and is2991cfc3f8; this round locally passed both typechecks, scoped lint/Oxlint/format, Knip, focused Vitest, and Playwright discovery. Please update the count, head history, current SHA, and verification account. - P3, PR body Adaptations: the body still says the plain CLIPTextEncode case remains
test.fixmeand should be re-enabled later, but2991cfc3f8deletes the case and its breadcrumb. Please describe the deletion and link the durable tracker that now owns restoring the coverage.
I confirmed dante01yoon's partial-mock and fixme comments are addressed by the two new commits and did not duplicate them. Their release-scope question remains unanswered: the carry is mechanically faithful, but the release owner still needs to confirm that the non-Agent undo/redo and slot-measurement changes are wanted on cloud/1.54.
Local checks passed: frozen install; main and browser typechecks; changed-file ESLint; type-aware Oxlint; format; Knip; focused Vitest (4/4); Playwright discovery (43 tests in 7 specs); Fallow (no issues). Hosted snapshot at this head: 38 success, 14 skipped, 29 in progress, 0 failed. Because this is a hand-authored backport and required checks are still running, this is a COMMENT rather than an approval.
|
Green on PM-1155 target inclusion update: the corrected source implementation is now frontend PR 18275 at Full context for agent readers
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: product judgment remains; exact-head code review is complete.
I re-reviewed the author activity at unchanged head 2991cfc3f8a0f5cdb7a0fe8fccb1889a6cd2d03f. The two prior PR-description findings are addressed, as are dante01yoon's partial-mock and fixme comments. The exact-head checks are now fully settled with no failures, and my prior local verification still applies because no code changed.
I am not holding this carrier on the 29 source-identical P2/P3 findings; those remain non-blocking main follow-ups to re-pick. I also did not duplicate dante01yoon's release-scope question. It is routed, but the linked tracker is inaccessible to this reviewer and no release-owner sign-off is visible on the PR, so that product gate remains open as the author states.
New findings:
- P3 Nit, PR body Summary and Exact-head verification: the exact CI totals are already stale. The body records 77 success and 16 skipped; the current exact-head snapshot has 78 success and 19 skipped because later label/merge-eligibility automation added four runs. The substantive all-green claim is correct, but exact totals mix stable test evidence with volatile PR automation. Please say all hosted checks completed with no failures, or name stable required gates instead.
- P3 Nit, PR body Adaptations: one bullet still says the current VueUse mock spreads the actual module, immediately before the next bullet says
249123390creplaced that partial mock with the workflow-store seam. The live file uses the seam plus a narrow two-function VueUse mock. Please collapse these into the final adaptation state and leave the superseded118ac5e9c6strategy only in Head history.
No local checks were rerun because this is the same exact head already verified. Current REST evidence: 78 success, 19 skipped, 0 failed or pending. This remains a COMMENT because the PR is hand-authored and release-scope sign-off is still a product decision.
dante01yoon
left a comment
There was a problem hiding this comment.
Re-review at 2991cfc3 — commenting. Both of my non-blocking suggestions are resolved, one of them exactly as suggested. The release-scope question that was my stated reason for commenting last time is now owned but still not answered, so I am holding at COMMENT rather than approving.
Prior findings
| # | Finding | Location | Verdict |
|---|---|---|---|
| 1 | suggestion: — prefer test.fail() over test.fixme so the #17576 deferral self-trips |
subgraphPromotedWidgetExternalLink.spec.ts:159 |
Resolved — differently and acceptably: 2991cfc3 deletes the case and its two constants outright |
| 2 | suggestion: — the real-VueUse partial mock widens the boundary; mock the project-owned workflow-store seam instead |
useSlotLinkInteraction.autoPan.test.ts |
Resolved as suggested in 249123390c |
| 3 | question: — who owns release-scope sign-off for withoutExecutionOrder changing graphEqual for every 1.54 user |
src/scripts/changeTracker.ts:28 |
Partially resolved — owner named and merge gated, sign-off not yet on record |
On (2) I checked the mechanism rather than the claim. 249123390c mocks @/platform/workflow/management/stores/workflowStore and returns @vueuse/core to a total mock, dropping both the importOriginal spread and the now-unused import type * as VueUse. That is coherent: the reason useStorage had to resolve at all was carried #18117's static useWorkflowStore import reaching remoteConfig.ts, and mocking that seam means the real module — and its module-scope useStorage calls — is never loaded. The total VueUse mock no longer provides useStorage, and the suite still collects and passes, which is itself the proof that nothing else reaches it at import time. The widened boundary is gone, not merely documented. This is the narrower fix and it is the right one.
On (1), deletion resolves what I raised — the release branch no longer carries a case that can never report. One small consequence under Unanchored.
On (3), the reply names christian-byrne as PR assignee and cloud/1.54 carrier owner, links christian-byrne/blocked-on-christian#825, and states "No merge until that is on record." That answers who, and the explicit gate is the right instinct. What it does not do is put the sign-off itself on the record, which was the bar I set last time. Three of the eight carries — #18110, #18117, #18118 — change undo/redo and slot measurement for every 1.54 user rather than only Agent users, and an approval from me would clear the last review gate on that while the decision is still outstanding. So: COMMENT. This flips to APPROVE the moment the sign-off is linked here; nothing else is outstanding from my side, and the carry itself remains clean.
I am not adopting @DrJKL's open set. On the question you put to reviewers at 11:32 — hold on the 21, or accept "identical to main" as the bar — my view, offered only because it bears on the house rule about faithful backports: identical-to-main is the right bar on a release branch, and those follow-ups belong on main with a re-pick. Diverging cloud/1.54 to fix style on faithfully carried code trades a real risk (a pick that no longer matches its source) for a cosmetic gain. That is @DrJKL's call on their own findings, not mine to overrule.
Unanchored
browser_tests/tests/subgraph/subgraphPromotedWidgetExternalLink.spec.ts— not anchorable: the file isaddedin this PR's diff, so the case deleted in2991cfc3never appears in the diff and GitHub has no line to attach to.suggestion:the deletion took the in-file// Re-enable once #17576 is backported to cloud/1.54comment with it, so nothing inside this repository now points at the re-add. The tracking lives in the PR description and inchristian-byrne/blocked-on-christian#824— neither of which a future #17576 backporter greppingComfyUI_frontendfor "17576" will find. A one-line comment left where the case was, naming #17576, would keep the breadcrumb on the branch that actually needs it. Non-blocking, and strictly smaller than what I originally asked for.
Validation
CI at 2991cfc3 is green — 80 pass, 13 skipping, 0 fail. I executed nothing locally (no install, no suites), same as last time: my checks on (1) and (2) are a static read of the two commits' diffs plus the green unit job, and the (3) verdict is a read of the thread and the PR description. I did not re-verify the eight carries' fidelity — that was done mechanically at 118ac5e9, and the runtime source is untouched since, which I confirmed from the file list of the two new commits (both test-only).
| return JSON.parse(JSON.stringify(obj)) | ||
| } | ||
|
|
||
| function withoutExecutionOrder(nodes: ComfyWorkflowJSON['nodes']) { |
There was a problem hiding this comment.
question: (carrying forward, still the one open item) — verdict at this head: partially resolved.
Your reply named the owner, which is real progress: christian-byrne as PR assignee and cloud/1.54 carrier owner, tracked in blocked-on-christian#825, with "No merge until that is on record." I appreciate the explicit gate, and I am not re-litigating the carry — withoutExecutionOrder here is still change-line-identical to 5347edacca on main, and I am not asking you to diverge.
What is still missing is the sign-off itself. My bar last time was "confirm the release owner has signed off on the non-Agent behaviour change, and link that here", and that link does not exist yet. The reason I am keeping it open rather than trusting the gate: this function changes graphEqual, the single predicate deciding what counts as an undoable change for every user of this release, and it is one of three carries (#18110, #18117, #18118) that alter behaviour outside the Agent panel under an Agent-scoped PR title. An approval from me removes the last review gate on that while the release decision is unresolved, and the author's merge hold is voluntary where a review verdict is not.
Concretely, what flips this to APPROVE: a comment on this PR from the cloud/1.54 release owner signing off on all eight carries — or a list of carries to drop, in which case the rebuilt carrier needs a fresh look anyway. Nothing else from me is outstanding.
|
Conflict repair: merged |
|
Conflict repair: merged |
…xture helper (#17403) (#18876) ## Summary Restores fixture-contract parity with `main` and `cloud/1.54`: adds the `NodeSlotReference.expectLinkCount` helper from #17403 to `browser_tests/fixtures/utils/litegraphUtils.ts`. The file is **byte-identical to both `origin/main` and `origin/cloud/1.54`** (blob `d3a1e76d0e`). ## Why Program audit row `bpaudit-1` (silently-dropped backport collateral, follow-up to the #17730/#18860 fixture-semantics incident) found this as the one remaining undecided test-infrastructure divergence on the 1.54 pair: - `cloud/1.54` received this exact hunk as a hand-carried adaptation inside #18257 because a picked spec needed it. - `core/1.54` never received #17403 by any route, so the next spec backport written against main's fixture contract that calls `expectLinkCount` fails on core only — the same failure shape that cost three days on #18512 (see #18860). ## Scope - Test infrastructure only: one fixture method, 3 lines, no product code. - No consumer on this branch yet; `getLinkCount` (which it wraps) already exists here. - No behavior change to any existing test. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Eight merged
mainAgent fixes that had nocloud/1.54carrier are cherry-picked onto the current release tip. Two sources need hand re-expression and are excluded. Runtime source is unmodified from the eight sources; seven follow-up commits are test-only adaptations to the release's module surface. Verification at the current head2991cfc3f8is hosted CI (77 success, 16 skipped, 0 failed) plus DrJKL's local run (see below); the picked browser specs had not been run against the target before this PR.Open gates: release-scope sign-off on the three non-Agent carries and exact-head human re-approval on
2991cfc3f8, both tracked in blocked-on-christian 825.Replaces 18254: six picks there inherited
Co-authored-by: Claudetrailers from themainsquash commits and failed the AI co-author check. Runtime source is byte-identical to that PR's headd1f35ac622; two test files differ (listed under Adaptations).Full context for agent readers
Changes
Sources, all
cherry-pick -x -m 1, clean, in merge order:Adaptations, all test-only, no runtime change:
NodeSlotsreload unit test usescreateTestingPinia+setActivePiniainstead ofgetActivePinia()!, because the shared test Pinia setup from 17237 ismain-only.NodeSlotReference.expectLinkCount(same body asmain, from 17403); three picked Agent specs open the panel with the label the release UI renders,agent.askComfyAgent, becauseagent.entryButtonfrom 17621 does not exist on this line.useSlotLinkInteraction.autoPan.test.ts: theglobalEnumsmock is dropped (the picked composable now readsRenderShapefrom the real module, as onmain), and the@vueuse/coremock spreads the actual module so release-native transitive imports such asuseStorageresolve while the event-listener overrides stay focused.useSlotLinkInteraction.autoPan.test.ts(249123390c): the workflow store is mocked at its seam instead of a partial module mock, per dante01yoon's review.subgraphPromotedWidgetExternalLink.spec.ts(2991cfc3f8): the plain CLIPTextEncode "hides the text control" case and its two constants are deleted, because it asserts 17576 behavior (WidgetGrid retains labels for connected inputs) that is not oncloud/1.54. Re-add when 17576 lands on this line; the 17576 decision is blocked-on-christian 824.Dependencies: none added; release lockfile pins preserved.
Exclusions: 18063 and 18073 conflict because they edit
agentCrdtProjection.tsandagentCrdtDocLifecycle.ts, files created by the follower split in 16908, whichcloud/1.54never received. They need focused hand re-expression onto the pre-split follower, following 18219 and 18195; tracked as separate program rows.Review focus
Exact-head verification
Head history:
210e191fc9(approved by DrJKL) received five test-only follow-ups:a9ab888243(module-surface alignment),a63fef35ae(test.fixmeinstead oftest.skip, which the release's oxlint config rejects),118ac5e9c6(restore VueUse exports in the auto-pan mock, fixing the suite-collection failure DrJKL found ata63fef35ae),249123390c(workflow-store seam mock), and2991cfc3f8(delete the plain CLIPTextEncode browser case).210e191fc9, local on top ofcloud/1.54tip1bbcdc66fa: cherry-pick dry run of all 10 candidates, 8 clean individually and as a sequential stack, 2 conflicting as described above;vitest runon the 9 touched unit test files 405 passed; bothvue-tscprojects exit 0;oxfmtandeslintclean; lint-staged and knip passed in hooks.a63fef35ae, hosted:lint-and-formatpassed. DrJKL's local focused run: 405 passed plus one suite-collection failure inuseSlotLinkInteraction.autoPan.test.ts(useStoragemissing from the total@vueuse/coremock). Fixed in118ac5e9c6.118ac5e9c6: hosted CI green; the unittestjob covers the collection fix.2991cfc3f8(current head): hosted CI 77 success, 16 skipped, 0 failed. DrJKL's local run on this head: both typecheck projects, ESLint, Oxlint, format, and Knip clean; Vitest 4 of 4 on the auto-pan suite; Playwright discovery 43 tests across 7 specs; Fallow clean. Author-side local verification is not run on this head (host resource hold); hosted CI plus DrJKL's run are the verification of record.Program receipt: 2026-09-21-ms215-gap-backport-cloud154.md.