Repository navigation
fix(models): accept the Comfy custom Stripe checkout domain - #17668
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe checkout URL validation now trusts ChangesCheckout host validation
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The checkout validator supports both trusted domains while retaining hostname safety checks, so the change is ready to merge. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 inconclusive)
✅ Passed checks (5 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The review context identifies the changed files and PR description, but it does not provide the PR title or the actual commit subjects. The custom check requires those fields to determine whether bug-fix language is present. The available metadata shows changes only under Full details: Website End-To-End Regression CoverageExplanation The PR changes website runtime behavior in
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-17668.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-dzwaupdht-comfyui.vercel.app Last updated: 2026-09-14T19:39:11Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17668 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 2763 2763
Lines 139124 139125 +1
Branches 35765 35765
=======================================
+ Hits 115224 115225 +1
Misses 22799 22799
Partials 1101 1101
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
benjcooley
left a comment
There was a problem hiding this comment.
Verified the changed validator and its caller, the custom-domain DNS target, and the focused regression coverage. The exact hostname allowlist preserves the existing HTTPS, no-port, and no-credentials protections.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
No actionable issues found.
8390ad9 to
ca12b7b
Compare
The top-up checkout validator only accepted checkout.stripe.com, but the Comfy Stripe account serves hosted Checkout from its custom domain checkout.comfy.org in every environment. A valid 200 response was rejected as INVALID_RESPONSE, so Continue surfaced "Checkout could not start" even though the backend had created the session. Allowlist both hosts, keeping the https/no-port/no-credentials guards and exact-hostname matching so look-alikes are still refused.
9e4a0b7 to
5597ec6
Compare
benjcooley
left a comment
There was a problem hiding this comment.
Re-reviewed only the replacement commit after the rebase. Its two file patches are byte-for-byte identical to the previously approved commit; only the parent changed to merged PR #17466 on main. There were no prior inline threads to resolve.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
No new actionable issues found.
Summary
Stacked on #17466. The top-up "Buy credits" dialog showed "Checkout could not start" on every Continue click, even though the backend was creating the Stripe session fine.
The client validator in
buy-credits.tsonly acceptedcheckout.stripe.com, but the Comfy Stripe account serves its hosted Checkout page from a custom domain,checkout.comfy.org, in every environment (confirmed in the cloud repo'senvironments/prod/api_checkout_test.tf). So a valid 200 with acheckout.comfy.orgURL was rejected asINVALID_RESPONSE, which falls through to the generic failure state. The backend had already opened the session, so the user was blocked on a checkout that actually existed.Reproduced locally against staging: Continue returned 200 with
checkout_url: https://checkout.comfy.org/c/pay/cs_test_...and the dialog still failed.Changes
checkout.stripe.comandcheckout.comfy.orgin the checkout-URL validator, via an exact-match Set. All the other guards stay (https only, no port, no embedded credentials), so look-alikes likecheckout.comfy.org.evil.testare still refused.Review Focus
checkout.comfy.orgis the only additional host prod emits.Testing
vitest run src/lib/workshop/buy-credits.test.ts— 11 pass (2 new)vitest run src/components/workshop/BuyCreditsDialog.test.ts— 17 passastro check— 0 errors, 0 warningseslint/oxfmton changed files — clean