Repository navigation
FE-2218 feat(billing): mint billing-web entries from the shared contract when the hosted destination says billing_web - #17860
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 2029 passed, 2 failed · 1 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-17T06:09:34.039Z",
"gitSha": "19f076dbae3c5504ea01bf003c1996797359e1d6",
"branch": "jaewon/fe-2218-hosted-billing-routes",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.141000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.2,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.02700000000004,
"heapDeltaBytes": 421976,
"heapUsedBytes": 63056356,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.424999999999999,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1992.2369999999887,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.1320000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.79,
"heapDeltaBytes": 8695876,
"heapUsedBytes": 70686252,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 11.683,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1971.7840000000137,
"styleRecalcs": 79,
"styleRecalcDurationMs": 34.592,
"layouts": 14,
"layoutDurationMs": 4.875,
"taskDurationMs": 915.4609999999999,
"heapDeltaBytes": -5989936,
"heapUsedBytes": 55911212,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 154.42700000000002,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1691.6429999999991,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.942,
"layouts": 14,
"layoutDurationMs": 4.417,
"taskDurationMs": 735.91,
"heapDeltaBytes": 4862160,
"heapUsedBytes": 66318056,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 129.49300000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.3360000000216,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.622,
"layouts": 6,
"layoutDurationMs": 1.0750000000000002,
"taskDurationMs": 296.933,
"heapDeltaBytes": 1885896,
"heapUsedBytes": 64637544,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.286999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0420000000013,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.094999999999999,
"layouts": 6,
"layoutDurationMs": 1.283,
"taskDurationMs": 328.477,
"heapDeltaBytes": 2141784,
"heapUsedBytes": 64634724,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.740000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 575.6749999999897,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.75,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.247,
"heapDeltaBytes": 17941840,
"heapUsedBytes": 80153764,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.63500000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 563.8280000000009,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.598000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.63000000000005,
"heapDeltaBytes": 18051760,
"heapUsedBytes": 80044712,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 136.106,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2057.208000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.6789999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.578,
"heapDeltaBytes": -3610864,
"heapUsedBytes": 75648396,
"domNodes": -254,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 40.551,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.1190000000697,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.091000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.8040000000001,
"heapDeltaBytes": 3000088,
"heapUsedBytes": 83367856,
"domNodes": -242,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 34.578,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2135.7610000000022,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.510999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1364.2289999999998,
"heapDeltaBytes": 14826300,
"heapUsedBytes": 79361668,
"domNodes": -251,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 681.021,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2229.752000000076,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.141999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1423.628,
"heapDeltaBytes": -15100516,
"heapUsedBytes": 66373728,
"domNodes": -252,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 680.293,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3367.5590000000284,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.443999999999996,
"layouts": 60,
"layoutDurationMs": 14.01,
"taskDurationMs": 1555.531,
"heapDeltaBytes": 11255616,
"heapUsedBytes": 78073868,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 701.103,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3285.2080000000115,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.909999999999997,
"layouts": 60,
"layoutDurationMs": 13.661,
"taskDurationMs": 1504.173,
"heapDeltaBytes": 8374028,
"heapUsedBytes": 74619232,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 668.221,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2737.6760000000218,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.123,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1793.4320000000002,
"heapDeltaBytes": -14395868,
"heapUsedBytes": 71100592,
"domNodes": -227,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 895.116,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2715.1839999999083,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.471999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1710.203,
"heapDeltaBytes": 17503056,
"heapUsedBytes": 101178860,
"domNodes": 10,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 849.0869999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.5910000000395,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.106,
"heapDeltaBytes": 19450180,
"heapUsedBytes": 83863908,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.26599999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2020.9310000000187,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.083,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.3620000000001,
"heapDeltaBytes": -4492428,
"heapUsedBytes": 83662744,
"domNodes": -245,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.846,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.4869999999942,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.12600000000003,
"heapDeltaBytes": 13270076,
"heapUsedBytes": 77087676,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 120.437,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 562.8289999999652,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.219999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.838,
"heapDeltaBytes": 13399348,
"heapUsedBytes": 77093368,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 122.51899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2087.2550000000274,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.188,
"heapDeltaBytes": 6963652,
"heapUsedBytes": 70525852,
"domNodes": -273,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.651999999999997,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.309000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.31800000000004,
"heapDeltaBytes": 1399116,
"heapUsedBytes": 64848520,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.094999999999999,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.8069999999734,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.268,
"layouts": 18,
"layoutDurationMs": 5.526,
"taskDurationMs": 697.692,
"heapDeltaBytes": -5481792,
"heapUsedBytes": 58229256,
"domNodes": -272,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 97.14699999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.7789999999304,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.493,
"layouts": 18,
"layoutDurationMs": 4.919,
"taskDurationMs": 696.047,
"heapDeltaBytes": 11024176,
"heapUsedBytes": 74757832,
"domNodes": -273,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 93.79599999999999,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1301.0320000000206,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.903000000000006,
"layouts": 5,
"layoutDurationMs": 9.961,
"taskDurationMs": 817.1670000000001,
"heapDeltaBytes": 19358112,
"heapUsedBytes": 101450812,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 27.762,
"eventListeners": 2385,
"totalBlockingTimeMs": 96,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8174.795000000017,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.468,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4928.624,
"heapDeltaBytes": -5650560,
"heapUsedBytes": 75867688,
"domNodes": -246,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2291.5930000000003,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8701.792999999952,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.738,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5357.228,
"heapDeltaBytes": -11616592,
"heapUsedBytes": 69736556,
"domNodes": -250,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 2462.196,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14631.736999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14515.197,
"heapDeltaBytes": -12301672,
"heapUsedBytes": 198025832,
"domNodes": -8061,
"jsHeapTotalBytes": -10264576,
"scriptDurationMs": 221.20399999999995,
"eventListeners": -14926,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14889.384000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14798.110999999999,
"heapDeltaBytes": -37765488,
"heapUsedBytes": 180941660,
"domNodes": -8062,
"jsHeapTotalBytes": -16101376,
"scriptDurationMs": 234.043,
"eventListeners": -14930,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17727.773000000012,
"styleRecalcs": 119,
"styleRecalcDurationMs": 17.170999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17651.79,
"heapDeltaBytes": -28862516,
"heapUsedBytes": 190598536,
"domNodes": -8061,
"jsHeapTotalBytes": -14073856,
"scriptDurationMs": 730.615,
"eventListeners": -14924,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17702.20100000006,
"styleRecalcs": 125,
"styleRecalcDurationMs": 17.24099999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17655.254,
"heapDeltaBytes": -23886924,
"heapUsedBytes": 188119100,
"domNodes": -8061,
"jsHeapTotalBytes": -17743872,
"scriptDurationMs": 784.926,
"eventListeners": -14924,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5409.613999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.71500000000002,
"layouts": 20,
"layoutDurationMs": 22.427000000000003,
"taskDurationMs": 5390.571000000001,
"heapDeltaBytes": -39360244,
"heapUsedBytes": 197916376,
"domNodes": -8061,
"jsHeapTotalBytes": 16371712,
"scriptDurationMs": 87.556,
"eventListeners": -14926,
"totalBlockingTimeMs": 228,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5487.7270000000635,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.12899999999999,
"layouts": 20,
"layoutDurationMs": 26.101,
"taskDurationMs": 5473.840999999999,
"heapDeltaBytes": -19854668,
"heapUsedBytes": 196941932,
"domNodes": -8061,
"jsHeapTotalBytes": 19939328,
"scriptDurationMs": 97.69699999999999,
"eventListeners": -14924,
"totalBlockingTimeMs": 289,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7682.968000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7618.649000000001,
"heapDeltaBytes": 5317284,
"heapUsedBytes": 184827608,
"domNodes": -1,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 120.07600000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7358.352000000082,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7329.481999999999,
"heapDeltaBytes": 9967456,
"heapUsedBytes": 186679212,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 101.76300000000005,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 96.3869999999929,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.794,
"layouts": 3,
"layoutDurationMs": 0.8490000000000001,
"taskDurationMs": 69.15199999999999,
"heapDeltaBytes": 3215148,
"heapUsedBytes": 65558412,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.5569999999999995,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 86.87900000006721,
"styleRecalcs": 5,
"styleRecalcDurationMs": 12.695,
"layouts": 3,
"layoutDurationMs": 1.3880000000000001,
"taskDurationMs": 67.42300000000002,
"heapDeltaBytes": 2982852,
"heapUsedBytes": 65324696,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.829999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jaewon/fe-2216-plan-change #17860 +/- ##
==============================================================
- Coverage 82.67% 82.67% -0.01%
==============================================================
Files 2888 2889 +1
Lines 142947 142983 +36
Branches 38619 36787 -1832
==============================================================
+ Hits 118185 118209 +24
- Misses 23528 23540 +12
Partials 1234 1234
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
078b435 to
9f05244
Compare
a176720 to
a23f020
Compare
9f05244 to
58133a5
Compare
a23f020 to
2b4cac8
Compare
58133a5 to
074e2c9
Compare
2b4cac8 to
e6be1b3
Compare
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Nothing blocking: the route module and both consumers do what the body says on every path traced; the notes are an orphaned flag getter, a skipped error reset, a cloned Playwright boot and test hygiene, plus one product item that gates the flag flip rather than the merge: "Billing & invoices" lands on payment-methods while invoices is still coming soon on billing-web. Merges after #17856 and #17783.
Severity: Minor
What: src/composables/useFeatureFlags.ts:231-233 hostedBillingWebEnabled keeps no production reader after this PR removes the popover's (CurrentUserPopoverWorkspace.vue:398 at the base); three assertions and two mock entries remain.
Why this is an issue: it answers true where hostedBillingRoute fails closed to the provider, so the next surface that reads it re-creates the bare-origin open this PR removes, and knip cannot see an object getter.
Proposed Fix: delete the getter, the three assertions and the two mock entries.
Severity: Minor
What: PR body AS-IS/TO-BE the settings control labeled "Billing & invoices" (main.json:2832, three bindings in SubscriptionPanelContentWorkspace.vue) mints payment-methods on billing_web while billing-web maps invoices to a coming-soon view (apps/billing-web/src/router.ts:32); the swap reaches only the workspace billing context (the legacy useLegacyBilling.ts:188 arm still opens the provider portal).
Why this is an issue: flipping the flag removes the only in-app route to invoices and receipts, and two customers on the same flag value get different destinations depending on their billing context.
Proposed Fix: qualify the TO-BE row with the context scope and the surface list, and gate the flag flip on an invoices entry point, or keep the settings control on the provider until billing-web serves invoices.
Severity: Minor
What: PR body, How bullet 2 it says the in-app dialog keeps "the popup-blocked fallback" while the next bullet and the head remove it (the handler ignores the window.open result).
Why this is an issue: a reader approves billing_web believing popup-blocked customers still get the pricing table.
Proposed Fix: delete the clause.
2dfdfc2 to
4bbcf3d
Compare
fb8a89b to
444b8d7
Compare
|
Three of the seven Minors from review 5231015757 never got an answer — 4033096278, 4033096282 and 4033096291 still have no reply, while two others got a duplicate. Answering them here because the inline reply endpoint returns 422 4033096282 — dead expected-family column ( 4033096291 — unmocked 4033096278 — boot-block duplication in the cloud spec: understood and deliberately not actioned. You are right on all three counts, including that |
…FE-2218) Layer C of the rollout needs one place that turns the server's hosted_billing_destination into a URL shape: the contract's /v1/<intent> entry when the flag says billing_web, and the provider URL the backend already handed back when it says stripe. Everything unresolved fails closed to the provider - no configured origin, a backend family whose return target has no destination, an entry the contract refuses to build.
…on (FE-2218) Plans & pricing opened the billing-web root with no intent and no way back; it now opens the contract's pricing entry with return_to. Manage subscription reads the destination before it picks a rail, so on billing_web neither the SDK nor the legacy client is asked for a portal URL the customer will never open, and the portal-return refresh still re-reads status on the way back.
…ud (FE-2218) Billing & invoices is the surface both destinations share, so the spec drives it twice: stripe opens the portal URL the mocked backend returns, billing_web opens the minted payment-methods entry and never asks for a portal URL at all. The hosted origin is a build-time value, so the cloud e2e artifact now carries a reserved one. It is reachable only when the server flag says billing_web, which no deployment default does.
…allback (FE-2218) `window.open` with `noopener` always returns null per the HTML spec, so treating a falsy handle as a blocked popup fired the in-app fallback on every click: the customer got the billing-web tab and the "Choose a Plan" dialog stacked on top of it. Open the tab and stop. A genuinely blocked popup is the browser's own affordance, and `noopener,noreferrer` stays because billing-web is a separate origin that must not receive `window.opener`.
…E-2218) The spec's `window.open` stub returned a window for every call, so a `noopener` open looked successful to the app and the double-open went unseen. The stub now answers as a browser does — null for `noopener`, a window otherwise — and two cases assert the avatar menu's Plans and pricing entry lands on exactly one surface per destination. The dialog's frame is pushed synchronously by the click handler while its contents are lazily imported, so asserting on the frame settles the negative case instead of racing the import.
…on opens The billing_web branch of manageSubscription returned without clearing error, so a failure from a previous attempt survived a successful hosted open on the composable's public error, unlike the SDK-rail and legacy branches that clear it first. Type RETURN_TO as the contract's ReturnTarget and key the deploy-env map with a DeployEnv union exported from initDatadogRum, so a typo in either fails typecheck instead of silently degrading every customer to the provider page.
…nv mapping The hosted rows asserted the minted URL and the skipped rails but never the return refresh, so replacing openPortalWindow with a bare window.open dropped the re-read and stayed green. Dispatch visibilitychange after the open and assert the status re-read. Cover the stale error the hosted branch now clears, and mock getComfyCloudBaseUrl in both suites so the environment leg no longer depends on the checkout's build-time staging base URL.
…ssert The table carried an expected-family column the callback never read and asserted one URL on all three rows, under a title claiming it derives the family. What the rows prove is that each known backend mints an entry rather than falling back to the provider, so they now say that.
444b8d7 to
d89db10
Compare
|
Sha correction on my previous comment: the branch was rebased while I was writing it (444b8d7 -> d89db10), so the two commits I cited are no longer ancestors of the head. Same changes, current shas:
The rebase also picked up d83d82f from the base branch (#17856), which routes a declined plan change through the localized projection instead of |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed this as the first producer against the return_to registry I audited on #17795, and for the double-open claim. Both hold up, and the second is a better find than the description makes it sound.
The double-open was not a duplicate tab, it was a tab plus a modal
The old code:
const hostedTab = flags.hostedBillingWebEnabled && billingWebUrl
? window.open(billingWebUrl.href, '_blank', 'noopener,noreferrer')
: null
if (!hostedTab) { subscriptionDialog.showPricingTable(...) }window.open(..., 'noopener') returns null by specification — withholding the handle is the entire purpose of the flag. So hostedTab was always null, !hostedTab was always true, and every click on Plans & pricing opened the billing-web tab and put the in-app pricing modal up behind it. Not an edge case; the default path since #17370.
The fix is the right shape: branch on route.kind === 'billing_web' rather than on a return value that could never be truthy. Branching on intent instead of on a handle is what stops this recurring.
The noopener asymmetry is deliberate, and I want it to stay documented
Two call sites now make opposite choices, which is exactly the kind of thing a later reviewer "fixes" into a regression:
// pricing — no handle wanted
window.open(route.url.href, '_blank', 'noopener,noreferrer')
// portal — handle required
// The handle arms the return refresh, so adding `noopener` here (which
// nulls it) silently stops billing state from re-reading on return.
const portalWindow = window.open(url, '_blank')
if (portalWindow) refreshOnPortalReturn()The comment is doing real work: it names both the mechanism and that the failure is silent. Without it, adding noopener to the portal call looks like a pure hardening win and quietly breaks the refresh-on-return.
Worth recording that this is the same tension as #17771 on the Workshop side, where nulling the opener broke the return leg, and the two surfaces have landed on opposite answers for good reasons. The portal keeps the handle and accepts that the opened origin can reach window.opener; that is a trusted-vendor tradeoff rather than an oversight, and it is bounded by the portal being the only URL opened that way.
The registry boundary holds
hostedBillingRoutes.ts builds entries through @comfyorg/billing-contract rather than composing URLs locally — "the one definition of that route surface" — so the closed-set property from #17795 is preserved at its first real producer. A host can pick an intent; it cannot invent a return_to.
The Layer C ordering comment is also worth keeping:
Layer C before Layer A: where the customer lands is the server's call, so the rail the host would otherwise take never gets asked for a portal URL it would not open.
That is the fail-closed direction — the destination decision happens before anything requests a URL it would discard.
CI has two checks still running; nothing outstanding from me once they land.
christian-byrne
left a comment
There was a problem hiding this comment.
Approving — the two checks that were still running have landed green and the thread is cleared. Everything I looked at last pass stands: the double-open fix branches on intent rather than on a handle that could never be truthy, the noopener asymmetry between pricing and the portal is deliberate and documented, and hostedBillingRoutes.ts builds entries through @comfyorg/billing-contract so the closed-set property from #17795 survives its first producer.
ef5e9fa
into
jaewon/fe-2216-plan-change
…act when the hosted destination says billing_web (#17860) Stacked on #17856 (base branch `jaewon/fe-2216-plan-change`) → #17853 → Rollout layer C (`hosted_billing_destination`, `stripe` | `billing_web`, PostHog at 100% `stripe`) decides where a hosted billing action lands. The plan says the host reads the flag, hands it to the SDK (#17783) and, when it says `billing_web`, mints a `/v1/<intent>` entry with `return_to` from `@comfyorg/billing-contract`, the one definition of that route surface (#17795); when it says `stripe`, the backend's URL is opened unchanged. Today the host only opens the bare billing-web origin from the user popover (#17716) with no intent and no `return_to`, and "Billing & invoices" in the settings panel always goes to the Stripe portal. This is the last un-opened code item before the Phase 7 host proof. - `src/platform/workspace/billing/hostedBillingRoutes.ts`: `hostedBillingRoute(destination, intent)` returns `{ kind: 'billing_web', url }` built by `buildBillingEntryUrl({ billingOrigin, intent, product: 'comfyui', returnTo: 'comfyui_workspace' })`, or `{ kind: 'provider' }` meaning "use the server's URL". The environment is derived, not hardcoded: the cloud base URL's hostname through the existing `resolveDeployEnv` map (`prod-v2 | stg-v2 | test-v2` → `production | staging | test`), which also classifies a local dev session by the backend it talks to. Fails closed to the provider on: no configured origin, an unknown backend family, a return target with no destination in that family, or an entry the contract refuses. A path-prefixed `VITE_BILLING_WEB_URL` keeps its prefix under the minted route. - Consumers: the popover's "Plans and pricing" mints the `pricing` intent (billing-web routes it to the subscription view; the in-app dialog stays the `stripe` behaviour and the popup-blocked fallback); `useWorkspaceBilling.manageSubscription()` mints `payment-methods` **before** either rail is consulted, so on `billing_web` no portal URL is requested on the SDK rail or the legacy one, and `openPortalWindow` + `refreshOnPortalReturn` still run so the return re-reads status, balance and capabilities. - Also fixed on the way: the popover treated a falsy `window.open(…, "noopener,noreferrer")` result as a blocked popup and showed the in-app pricing dialog as a fallback. Per the HTML spec `noopener` always returns `null`, so on `billing_web` the tab and the dialog opened together — a latent defect inherited from #17370 on `main`, caught by this PR's evidence run. The fallback is gone; the E2E `window.open` stub now returns `null` for `noopener` like a browser does, and a popover case covers both destinations. - Left on the provider on purpose: `useSubscriptionCheckout.recoverOutstandingPayment` and the `payment_method_url` steps inside an operation are mid-checkout provider steps, not hosted management; `invoices` and `result` are not served by billing-web yet (`ComingSoonView`), so nothing mints them; the legacy `/customers` rail's `accessBillingPortal` is being retired by the personal-billing flip and is not touched. - `@comfyorg/billing-contract` becomes a root `workspace:*` dependency. The CI cloud build for E2E (`.github/actions/build-cloud-frontend`, used only by `ci-tests-e2e.yaml` and `pr-update-playwright-expectations.yaml`, never by a deploy) gets `VITE_BILLING_WEB_URL=https://billing-web.example`, a reserved origin the spec stubs, reachable only when the server flag says `billing_web`. - No frontend-derived server state: the destination is the flag as-is; the host chooses only the URL shape. | AS-IS — `hosted_billing_destination: stripe` | TO-BE — `hosted_billing_destination: billing_web` | | --- | --- | | **1. User popover, "Plans and pricing" hovered**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-popover-plans.png"><br>Same menu item, unchanged by the flag. | **1. User popover, "Plans and pricing" hovered**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-popover-plans.png"><br>Same menu item, unchanged by the flag. | | **2. After clicking "Plans and pricing"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-plans-result.png"><br>In-app "Choose a Plan" dialog, no tab opened. | **2. After clicking "Plans and pricing"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-plans-result.png"><br>`billing-web.example/v1/pricing?product=comfyui&return_to=comfyui_workspace` tab opens and nothing else: `window.open` returns `null` under `noopener` as the spec requires, and no in-app dialog is left behind. | | **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-settings-billing.png"><br>Identical panel; the destination is only read on click. | **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-settings-billing.png"><br>Identical panel; the destination is only read on click. | | **4. After clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-manage-result.png"><br>`POST /api/billing/payment-portal` recorded, and the URL it returned (`https://billing.example/portal`) opened. | **4. After clicking "Billing & invoices"**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-manage-result.png"><br>No request to `/api/billing/payment-portal` on either rail; `billing-web.example/v1/payment-methods?product=comfyui&return_to=comfyui_workspace` minted and opened. | | **5. Return trip — refocusing the app tab after the hosted tab opened**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-return-refresh.png"><br>`/api/billing/status`, `/balance` and `/capabilities` re-read. | **5. Return trip — refocusing the app tab after the hosted tab opened**<br><img width="480" src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-return-refresh.png"><br>Same three reads; `openPortalWindow` + `refreshOnPortalReturn` still run on the minted route. | - AS-IS (`stripe`, today's default): popover → in-app pricing dialog; settings → Stripe portal via `POST /billing/payment-portal`. - TO-BE (`billing_web`): popover → `<billing-web>/v1/pricing?product=comfyui&return_to=comfyui_workspace`; settings → `<billing-web>/v1/payment-methods?…`, no portal request on either rail; the app re-reads billing state on return. | Gate | Result | | --- | --- | | `vitest run src/platform/workspace src/composables/billing src/composables/useFeatureFlags src/config` | 91 files, 1890 tests (19 new route cases: intent × destination × env × prefix × each fail-closed branch; 3 new adapter cases; 3 popover cases re-pointed) | | `packages/billing-contract` vitest | 3 files, 62 tests | | `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit 0 | | `fallow audit --changed-since origin/jaewon/fe-2216-plan-change` | no issues in 10 changed files | | `PLAYWRIGHT_TEST_URL=http://localhost:5431 pnpm exec playwright test --project=cloud browser_tests/tests/dialogs/hostedBillingDestination.spec.ts --reporter=list`, against `VITE_BILLING_WEB_URL=https://billing-web.example pnpm dev:cloud` | `4 passed (4.6s)` — settings on both destinations, plus the two new avatar-menu cases: `opens the in-app pricing table from the avatar menu while the destination is stripe` and `opens the billing-web pricing entry alone from the avatar menu while the destination is billing_web` | Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (#17662, #17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | #17783 (review) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | #17851 (review) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (#17827, #17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (#17798) | | 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2a | Cancel, resubscribe and payment portal through the SDK behind `billing_sdk_subscription_enabled` | FE-2216 | #17853 (review) | | 5 slice 2b | Subscribe and plan change through the SDK, priced by the server | FE-2216 | #17856 (review; parent of this PR) | | 7 / rollout C | Host mints billing-web `/v1/<intent>` entries with `return_to` when `hosted_billing_destination` is `billing_web` | FE-2218 | **this PR** | | follow-up | One `needsCustomerAttention` predicate (from the #17665 review) | FE-2216 | merged (#17792) | | follow-up | Opaque `BillingServerCode` (from the #17656 review) | FE-2227 | merged (#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799 review) | FE-2215 | merged (#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged (#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"] S2B["PR 17856 slice 2b subscribe + plan change"] LC["Layer C: host mints billing-web entries"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2B HD --> S2A S2A --> S2B S2B --> LC RB --> LC HD --> LC LC --> P7 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style LC stroke:#0366d6,stroke-width:4px ```
…contract and ingest-types (Comfy-Org#17882) ## Why `@comfyorg/account-core`, `@comfyorg/billing-contract` and `@comfyorg/ingest-types` are about to be installed by Platform from the public registry, and today none of them can be packed: `exports` point at `src/*.ts`, there is no `files` allowlist, no build, and the core still reaches into a private workspace utility. The release workflows on Comfy-Org#17881 assume `build` and `smoke:pack` exist; this PR is the part that makes a tarball installable in plain Node. Built on Comfy-Org#17854 (auth Vue surface → `account-ui`, now merged) so the core builds from a Vue-free tree, and it reproduces Maanil's Comfy-Org#17838 / Comfy-Org#17839 / Comfy-Org#17840 on the renamed tree as agreed in the review thread there. Base is `main`. ## How - **Private-utility cut** — the one remaining reach out of the core was `turnstileScript.ts` → `@comfyorg/shared-frontend-utils/loadExternalScript`. The loader is now package-owned (`packages/account-core/src/loadExternalScript.ts`, byte-identical) and `@comfyorg/shared-frontend-utils` leaves the core's dependencies. `publishBoundary.test.ts` fails on any future `workspace:` dependency that is not itself published (`@comfyorg/ingest-types` is the only allowed one). - **Manifests** — `files: ["dist"]`, `sideEffects: false`, `repository`/`homepage`/`author`, MIT `LICENSE` per package, `publishConfig.exports` mapping every dev `exports` entry to `dist/*.js` + `.d.ts`, `./package.json` export, `access: public`. `@comfyorg/ingest-types` moves `zod` to a peer so a consumer never gets two zod copies. `private: true` stays on all three (`ingest-types` had no `private` at all; it now has the latch). Flipping `private` is a one-line change per manifest in a later reviewed PR. - **Build** — `tsconfig.build.json` per package (`declaration`, `noEmitOnError`, `types: []`, tests and fixtures excluded), `build` = `clean` + `tsc -p`, `prepack` runs it. Relative imports carry `.js` so the emitted ESM resolves under `nodenext`; `openapi-ts.config.ts` sets `importFileExtension: '.js'` so regeneration keeps it. - **Smoke pack** — `scripts/smokePack.ts` (run as `pnpm --filter @comfyorg/account-core smoke:pack`) packs all three, checks each tarball (no source/test/fixture files, every export target present, no unrewritten `catalog:`/`workspace:`), installs them into a throwaway npm project, imports all 21 entries from plain Node ESM, and type-checks a `nodenext` consumer. Dropping one `.js` extension makes the typed step fail with `TS2835`, which the plain-Node step alone would not catch. - **CI** — `ci-packages-pack.yaml` on `pull_request` for the three package paths: matrix job per package (typecheck → build → `check:pack`) plus one `smoke-consumer` job. The tarball rules live in one pure module, `publishableTarball.ts`, with its own test file; the CLI and the smoke test are two entry points onto it, so CI and the smoke test cannot drift. Deliberate divergences from Comfy-Org#17839: no `region` export and no deletion in `shared-frontend-utils/networkUtil.ts` (the region gate moved to `account-ui` with the Vue surface and three app suites still import it); `createScriptLoader` stays in the shared package for its three `src/platform` callers. Open point: the root `LICENSE` is GPL-3.0 while all three manifests already declare MIT (as `@comfyorg/design-system` publishes). Without a per-package file pnpm would inject the GPL text into a tarball whose manifest says MIT, so the MIT files fix the actual defect; whether the SDK packages should be MIT at all is a call for the reviewer to confirm. ## AS-IS / TO-BE No UI change; packages, scripts and CI only. - AS-IS: `pnpm pack` on any of the three ships `src/*.ts` (or nothing) with `exports` a consumer cannot resolve, and the core depends on a private workspace package. - TO-BE: `smoke:pack` proves the three tarballs install and import from plain Node with types, and CI runs that proof on every change to the packages. ## Testing | Check | Result | | --- | --- | | `build` account-core / billing-contract / ingest-types | 92 / 18 / 6 dist files | | `smoke:pack` | 3 packed, 21 entries imported under Node ESM, `nodenext` tsc clean | | vitest account-core / account-ui / billing-contract / billing-web | 675 / 79 / 62 / 90 pass | | `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip` (with `dist` on disk) | exit 0 | | `yamllint` on the new workflow | clean | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | merged (Comfy-Org#17851) | | 7 prep | Auth Vue surface → `account-ui`; core Vue-free by construction | FE-2215 | merged (Comfy-Org#17854) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (Comfy-Org#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (Comfy-Org#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (Comfy-Org#17798) | | 7 | Package release workflows + versioning ADR (bump PR → publish on merge, snapshots) | FE-2218 | Comfy-Org#17881 (review) | | 7 | Publish readiness: dist build, files allowlist, pack smoke test, private-utility cut | FE-2218 | **this PR** | | 7 | First publish (`private` off), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 / Comfy-Org#17860 (review) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename (merged)"] AV["auth Vue surface to account-ui (merged)"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] RW["PR 17881 release workflows + ADR"] PR["publish readiness: dist, files, smoke pack"] PUB["first publish account-core / billing-contract / ingest-types"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> AV AV --> PR RW --> PUB PR --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style RN fill:#d4edda,stroke:#155724 style AV fill:#d4edda,stroke:#155724 style PR stroke:#0366d6,stroke-width:4px ```
…codes (Comfy-Org#17829) Linear FE-2217. ## Why The billing SDK core decodes generated zod schemas from `@comfyorg/ingest-types/zod`, which a bot regenerates from the cloud OpenAPI whenever the backend moves. Today a regen that renames a field, drops it, or widens an enum the reducer switches on surfaces either as a typecheck error somewhere deep in the core or, worse, as a runtime `MALFORMED_RESPONSE` in front of a customer mid-payment. Nothing states, in one readable place, which fields of which schema the SDK actually depends on. This adds a contract test per generated schema the core decodes. Each pins the fields the core reads and the enum members it branches on, at the type level and at parse time, so a regen that changes one of them fails a named block whose name says what broke — the parse rows under `vitest run`, the `expectTypeOf` exhaustiveness pins under the package typecheck. A failure here means the backend contract moved: fix the SDK, not the test. These are pins, not behaviour: reader and command behaviour stays covered by the existing `credits.test.ts`, `status.test.ts`, `capabilities.test.ts`, `operationState.test.ts`, `subscriptionCommands.test.ts`, and `topup.test.ts`. ## How New folder `packages/account-core/src/core/billing/contracts/`, one file per endpoint contract, picked up by the package's existing `src/core/**/*.{test,spec}.ts` include. Each file holds a canonical fixture typed as `z.input<typeof schema>` built by a small typed builder (no casts), parses it with `safeParse`, pins the output type with `expectTypeOf`, and runs one `it.for` row per enum value the SDK branches on. | Schema | Module that decodes it | Fields pinned | | --- | --- | --- | | `zBillingBalanceResponse` | `credits.ts` (read by `topup.ts`, `balanceWatch.ts`) | `amount_micros` as a number; the four optional breakdown micros | | `zBillingStatusResponse` | `status.ts` (read by `operationLifecycle.ts`, `subscriptionCommands.ts`, `presentation.ts`) | `billing_rail` (3), `pending_billing_op_id`, `pending_billing_op_type` (2), `action_url`, `payment_intent_client_secret`, `is_active`, `subscription_tier` (7), `subscription_status` (3) | | `zBillingCapabilitiesResponse`, `zBillingCapabilities`, `zBillingCapabilityScope`, `zBillingCapabilityRolloutDefaults` | `capabilities.ts` (which parses the three named pieces, not the response schema) | the five response keys the reader recomposes into its own schema, reading `expires_at` as a plain string and `revision` as a number; all seven capability booleans; `resolved_for.user_id` / `workspace_id`; `expires_at`; `revision` as an int64 bounded to the JavaScript-safe range the reader reads it back as a number over; `denied_reasons` absent from the contract, which is why `capabilityDenials.ts` decodes it off the raw body | | `zBillingOpStatusResponse` | `operationLifecycle.ts`, `operationState.ts` | `id`; `status` (the 4 the reducer handles); `authentication_state` (the 5 it reads or assigns); `decline_reason` (8, incl. the `generic` fallback); `recovery_action` (4); `phase` (3); `action_url`; `payment_intent_client_secret`; `retryable` optional | | `zErrorResponse` | `billingErrorBody.ts` | `code` as an open string the commands match against their own closed set; a body without `message` yields no code | | `zSubscribeRequest`, `zSubscribeResponse` | `subscriptionCommands.ts` | `confirmation_token`, `saved_payment_method_id` (`pm_` prefix), `idempotency_key`, `confirm_reactivation`; `billing_op_id`, `status` (3), optional `payment_method_url` | | `zResubscribeResponse` | `subscriptionCommands.ts` | `billing_op_id` regardless of `status` (2) | | `zCancelSubscriptionResponse2` | `subscriptionCommands.ts` | `billing_op_id` on both members of the response union | | `zPaymentPortalResponse` | `subscriptionCommands.ts` | `url` required, and not https-checked by the schema, which is why the command re-checks it | | `zPreviewSubscribeRequest`, `zPreviewSubscribeResponse` | `subscriptionCommands.ts` | `plan_slug` required and the three optional request fields; `allowed`, `is_immediate`, `effective_at`, `transition_type` (4), the int64 money fields and their JSON-number coercion, `discounts`, `requires_reactivation_confirmation` | | `zCreateTopupRequest`, `zCreateTopupResponse` | `topup.ts` | `amount_cents` minimum and its int64 coercion of the JSON number the command validates but does not send; `idempotency_key`; `billing_op_id` regardless of `status` (3) | | `zCreateTopupCheckoutRequest`, `zCreateTopupCheckoutResponse` | `topup.ts` | the amount bounds and the `return_url` URL rule, pinned by the issue **path** the command reads to tell the two apart; `checkout_url` required, `session_id` optional | `capabilityDenials.ts` is the one billing module that decodes without a generated schema — deliberately, since a strict enum parse would lose the whole capability set the first time the server names an unfamiliar policy branch. Its absence from the generated contract is pinned in `billingCapabilities.contract.test.ts`. ## AS-IS / TO-BE No UI. A regenerated `zBillingOpStatusResponse` that adds a fifth `status`: - AS-IS: the new value falls through `terminalFromStatus` into the pending branch; the operation polls until its budget runs out and reports `timed_out`. - TO-BE: `billingOpStatus.contract.test.ts` fails on the regen PR, naming the reducer as what needs updating. Two gates, and which one fires depends on the pin: the enum rows (`accepts the %s status`) fail under `vitest run`, while the exhaustiveness pin at `billingOpStatus.contract.test.ts:36` sits at module scope and fails as a TS2344 under the package typecheck, not in the test run. ## Testing - `cd packages/account-core && vitest run src/core/billing/contracts` — 12 files, 90 tests, all passing. The type pins are not among them: they sit at module scope and fail `pnpm --filter @comfyorg/account-core typecheck` instead, because nothing here runs `vitest --typecheck`. - `cd packages/account-core && tsc --noEmit` — clean - `pnpm typecheck` — passing; verified the type pins bite by injecting a spurious enum member and watching `expectTypeOf` fail with TS2344 - `pnpm lint`, `pnpm format`, `pnpm knip` — passing - `fallow audit --changed-since origin/main` — no issues in the 13 changed files ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | open (Comfy-Org#17783, carries slice 2a) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | merged (Comfy-Org#17851) — this PR sits on it | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (Comfy-Org#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (Comfy-Org#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (Comfy-Org#17798) | | 7 | Publish readiness: dist build, files allowlist, pack smoke test | FE-2218 | merged (Comfy-Org#17882) | | 7 | Package release workflows + versioning ADR | FE-2218 | open (Comfy-Org#17881) | | 7 | First publish (`private` off), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | **this PR** | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | open (Comfy-Org#17856, Comfy-Org#17860) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | open (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style P6C stroke:#0366d6,stroke-width:4px ```
…nt UI package (Comfy-Org#17927) Linear FE-2218. ## Why `@comfyorg/account-ui` is the only workspace package that ships Vue — `@comfyorg/design-system` ships CSS and icons, `@comfyorg/tailwind-utils` ships `cn()`, and neither exports a component. So "put this component somewhere shared" has exactly one destination, and what belongs there has never been written down: `git grep account-ui docs/` returns nothing. The question stopped being theoretical. `apps/billing-web` renders `/v1/checkout` as a static mock with `checkout-enabled` false. The working flow is `src/platform/workspace/components/UnifiedStripePaymentSelector.vue` — 383 lines that mount Stripe Elements, call `createConfirmationToken`, and hand the token to `subscribe` for the lifecycle to drive through 3DS — and `apps/billing-web` cannot import it, because its only Vite alias is `@` onto its own `src`. Hosted checkout is a choice between promoting that component and writing a second one. ## Root cause of the ambiguity The boundary exists only as an export map plus one header comment, and that comment says the opposite of what we now want. `packages/account-ui/src/billing/index.ts`: > routing, windows, dialogs, the payment provider's SDK, and styling all stay > with the host. Read literally, provider-bound payment UI is out of scope for the package — which would leave duplication as the only path. Meanwhile ADR-AUTH-BILLING-0032 rule 4 forbids exactly that for the neighbouring case, naming embedded checkout among the surfaces that "do not get a site-local implementation … they wait for the shared command layer." The command layer landed. Nothing said where the view half of it lives, so the two rules point in opposite directions with no document resolving them. ## How One ADR, no code change. `PACKAGES-ACCOUNT-UI-0034` records five points: 1. Payment presentation — card element, confirmation token, authentication challenge — is in scope for `@comfyorg/account-ui`. 2. The header contract above changes with it, rather than being quietly contradicted. Routing, windows, dialogs and styling stay with the host. 3. The provider SDK enters behind `./billing/stripe` with `@stripe/stripe-js` as an optional peer, so a consumer wanting only composables does not take it on. No host has stated a requirement either way; this is the reversible direction, since collapsing two entry points is cheaper than splitting one consumers already import. 4. Promoted components take host couplings as inputs — `Button` by slot, telemetry by port — so the package stays unstyled. 5. Transport, commands and readers stay in `@comfyorg/account-core`. Moving a surface does not make it shareable: `useNextInvoice.ts` assembles an invoice amount from several server fields and its own docstring defers to an authoritative amount the backend does not expose, so it is not promoted. The identifier follows the grammar in `docs/adr/README.md`: `PACKAGES` is the owning subsystem, `ACCOUNT-UI` the narrower concern, two tags, broad to narrow. ## Review focus **Point 3 is the one I picked rather than derived.** Whether the Stripe entry point is separate or folded into `./billing` depends on whether the Platform install wants the payment UI, which nobody has told me. I took the split because it is the reversible error. If Platform is known to want checkout, folding it into `./billing` is simpler and this should change before the ADR is accepted. **Point 2 reverses something written down.** Anyone who read that header and kept provider code in a host was following the documented rule. Worth confirming the reversal is what we want rather than a gap being papered over. **The cost named under Consequences is real and lands before the first promotion.** `account-ui` has no `tsconfig.build.json` and no Vite config; the three SDK packages build with `tsc`, which cannot emit `.vue`. Making it publishable needs library-mode bundling plus `vue-tsc` declarations — new tooling, not a copy of what Comfy-Org#17882 did. ## AS IS / TO BE Documentation only; no runtime or UI change. `pnpm adr:check` passes (naming, identifier uniqueness, index row). - **AS IS** — the boundary is an export map and a header comment that excludes the provider SDK; `apps/billing-web` has no path to a real checkout that does not duplicate the cloud app. - **TO BE** — the boundary is a document, the header is scheduled to change with it, and promotion is the sanctioned path. ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | 5 slice 2 | Subscribe / plan change on the SDK rail | FE-2216 | merged (Comfy-Org#17856, Comfy-Org#17922) | | rollout C | `hosted_billing_destination` + `hostedDestination` port | FE-2218 | merged (Comfy-Org#17716, Comfy-Org#17783, Comfy-Org#17860) | | 6 | Contract tests per generated schema | FE-2217 | merged (Comfy-Org#17829) | | 7 | billing-web session, sign-in, `/v1` surfaces | FE-2218 | merged (Comfy-Org#17798) | | 7 | Publish readiness for account-core / billing-contract / ingest-types | FE-2218 | merged (Comfy-Org#17882) | | 7 | Package release workflows + versioning ADR | FE-2218 | open (Comfy-Org#17881) | | 7 | billing-web Vercel deployment config | FE-2218 | open (Comfy-Org#17788) | | 7 | **What belongs in `@comfyorg/account-ui`** | FE-2218 | **this PR** | | 7 | `account-ui` publish readiness + Vue library build | FE-2218 | todo (depends on this) | | 7 | First publish (`private` off), Platform install | FE-2218 | todo | | 8 ui | Promote the Stripe payment UI into `account-ui` | FE-2331 | todo (depends on this) | | 8 ui | billing-web `/v1/checkout` on the real flow, `/v1/result` | FE-2331 | todo | | 8 ui | billing-web subscription write actions | FE-2331 | todo | | 8 ui | `/v1/invoices` opens the provider portal, matching the cloud app | FE-2331 | todo | | 9 | Cloud app readers move onto the SDK rail | FE-2331 | todo | | 6 | Live E2E per flow x consumer + evidence table | FE-2217 | todo (needs staging flags) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui composables (merged)"] P5["Phase 5 top-up + subscription rails (merged)"] BWV["billing-web /v1 surfaces (merged)"] PUBR["publish readiness: 3 SDK packages (merged)"] REL["release workflows + ADR-0033"] VER["billing-web Vercel config"] ADR["ADR-0034 what belongs in account-ui"] UIPK["account-ui publish readiness + Vue build"] PROMO["promote Stripe payment UI"] CHK["billing-web real checkout + /v1/result"] SUBW["billing-web subscription writes"] INV["/v1/invoices to provider portal"] RD["cloud app readers on the SDK rail"] PUB["first publish + Platform install"] E2E["live E2E evidence"] P3 --> P4 P4 --> P5 P4 --> BWV PUBR --> REL REL --> PUB ADR --> UIPK ADR --> PROMO UIPK --> PUB PROMO --> CHK BWV --> CHK BWV --> SUBW BWV --> INV VER --> E2E CHK --> E2E P5 --> RD style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style PUBR fill:#d4edda,stroke:#155724 style ADR stroke:#0366d6,stroke-width:4px ```
…Rs, with the versioning ADR (Comfy-Org#17881) ## Why `@comfyorg/account-core`, `@comfyorg/billing-contract` and `@comfyorg/ingest-types` are about to be installed by Platform from the public registry, and the plan had nothing on how their versions are cut. The monorepo already releases one package (`@comfyorg/design-system`) through a version-bump PR that publishes on merge; the decision (2026-09-16) is to follow that pattern for the SDK packages, generalized over a package input rather than copied, and to defer Changesets with the revisit conditions written down. ## How - `version-bump-package.yaml` — `workflow_dispatch` with `package` (account-core / billing-contract / ingest-types), `version_type`, `pre_release`; bumps on `main` and opens a `Release`-labelled PR titled `<package> <version>` (same pinned `create-pull-request` action as the design-system workflow). - `publish-package.yaml` — reusable (`workflow_dispatch` + `workflow_call`): name/version match, an explicit failure while `"private": true`, `build` and `smoke:pack` via `--if-present` (works before and after the publish-readiness PR lands), `npm view` skip on an existing version, `pnpm publish --access public --tag … --provenance` under `id-token: write`. - `publish-package-on-merge.yaml` — on a merged `Release` PR touching one of the three manifests, publishes every package whose `version` changed against the first parent (matrix), posts the release-links comment per package and the Slack notice. - `.github/actions/comment-release-links` — three additive cases so each package's summary has its own section. - `packages/{account-core,billing-contract,ingest-types}/package.json` — `"private": true` removed. Comfy-Org#17882 is merged and its smoke test proves the three tarballs install from plain Node, so the latch comes off here, in the same reviewed PR as the machinery that checks it. Nothing publishes on this merge: the on-merge job needs a `Release` label and a version change, and neither is present. - `docs/adr/RELEASES-PACKAGES-0033-sdk-packages-release-through-version-bump-prs.md` (+ index): context, the decision and each workflow's rationale, the versioning policy (`1.0.0-alpha.N` on `next` until the Phase 7 host proof, then `1.0.0`; generated-contract additions minor, removals major, decided on the regeneration PR), alternatives (Changesets, release-please, semantic-release, per-package copies) and the explicit "when to revisit Changesets" list. Written against the post-rename names (`packages/account-core`); the on-merge path filter matches once Comfy-Org#17851 lands. Design-system workflows are untouched. Not in this PR, on purpose: the `ingest-types` regeneration bump — the generator lives in Comfy-Org/cloud; the one-step change needed there is recorded in the ADR's follow-ups. **Snapshot publishing is not in this PR.** A `pull_request` run executes the workflow definition from the pull request's own merge ref, so a publish step triggered that way is PR-authored code holding `NPM_TOKEN`, and on `main` today no `pull_request` workflow reaches that secret. It returns in its own PR, publishing from a `workflow_run` job that runs the default branch's definition over an artifact the pull-request job produces. ## AS-IS / TO-BE No UI change; CI and docs only. - AS-IS: only `@comfyorg/design-system` has a release path; the SDK packages have no bump, no publish, no policy. - TO-BE: one dispatch bumps any of the three, the merged `Release` PR publishes with provenance, and the ADR records why Changesets waits and what the snapshot follow-up has to satisfy. ## Testing | Check | Result | | --- | --- | | `actionlint` on the four workflows | 0 findings | | `zizmor --min-severity medium` | clean apart from the repo-exempt `actions/checkout@v7` / `setup-node@v6` pins (`.pinact.yaml`); workflow-level `permissions: contents: read` added after its finding | | `yamllint` (as `ci-yaml-validation.yaml` runs it) | clean | | `pnpm adr:check`, `pnpm lint`, `pnpm format:check`, `pnpm knip` | exit 0 | After the second review round (860ef8a, 8f7972f, 41793c7): `publish-package.yaml` rejects a prerelease on `latest` and reports whether it published or skipped, and `version-bump-package.yaml` holds `account-core` and `billing-contract` on the `1.0.0-alpha.N` line, since `patch`, `minor` and `major` all turn `1.0.0-alpha.0` into `1.0.0`. The hardening that round added to the snapshot workflow left with it in 25b09c3. After the first review round (23b854e, 5985af7): the manual publish no longer takes a caller-supplied `ref` (it publishes the ref it was dispatched on), and the ADR scopes the prerelease-first gate to the hand-written packages, putting `ingest-types` outside it. The Slack notice posts to `#proj-billing` (`C0BNGQG2LCW`), not the design-system channel. Open points for review: `--provenance` is new relative to the design-system publish and is confirmed on the first real run; Follow-ups, not in this PR: a protected `environment` with required reviewers and an environment-scoped `NPM_TOKEN` on the publish job (repo configuration), and the same `ref` removal on `publish-design-system.yaml`. ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | Comfy-Org#17851 (queued) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (Comfy-Org#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (Comfy-Org#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (Comfy-Org#17798) | | 7 | Package release workflows + versioning ADR (bump dispatch → publish on merge) | FE-2218 | **this PR** | | 7 | Pre-merge snapshots from a default-branch `workflow_run` job | FE-2218 | todo (split out of this PR) | | 7 | Publish readiness: dist build, files allowlist, pack smoke test, private-utility cut | FE-2218 | merged (Comfy-Org#17882) | | 7 | `private` off on the three manifests | FE-2218 | **this PR** | | 7 | First publish (bump PRs: ingest-types, then billing-contract, account-core), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 / Comfy-Org#17860 (review) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] RW["release workflows + ADR"] PUB["npm publish account-core / billing-contract"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> PUB RW --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style RW stroke:#0366d6,stroke-width:4px ```
Stacked on #17856 (base branch
jaewon/fe-2216-plan-change) → #17853 → #17783; merge those first.Why
Rollout layer C (
hosted_billing_destination,stripe|billing_web, PostHog at 100%stripe) decides where a hosted billing action lands. The plan says the host reads the flag, hands it to the SDK (#17783) and, when it saysbilling_web, mints a/v1/<intent>entry withreturn_tofrom@comfyorg/billing-contract, the one definition of that route surface (#17795); when it saysstripe, the backend's URL is opened unchanged. Today the host only opens the bare billing-web origin from the user popover (#17716) with no intent and noreturn_to, and "Billing & invoices" in the settings panel always goes to the Stripe portal. This is the last un-opened code item before the Phase 7 host proof.How
src/platform/workspace/billing/hostedBillingRoutes.ts:hostedBillingRoute(destination, intent)returns{ kind: 'billing_web', url }built bybuildBillingEntryUrl({ billingOrigin, intent, product: 'comfyui', returnTo: 'comfyui_workspace' }), or{ kind: 'provider' }meaning "use the server's URL". The environment is derived, not hardcoded: the cloud base URL's hostname through the existingresolveDeployEnvmap (prod-v2 | stg-v2 | test-v2→production | staging | test), which also classifies a local dev session by the backend it talks to. Fails closed to the provider on: no configured origin, an unknown backend family, a return target with no destination in that family, or an entry the contract refuses. A path-prefixedVITE_BILLING_WEB_URLkeeps its prefix under the minted route.pricingintent (billing-web routes it to the subscription view; the in-app dialog stays thestripebehaviour and the popup-blocked fallback);useWorkspaceBilling.manageSubscription()mintspayment-methodsbefore either rail is consulted, so onbilling_webno portal URL is requested on the SDK rail or the legacy one, andopenPortalWindow+refreshOnPortalReturnstill run so the return re-reads status, balance and capabilities.window.open(…, "noopener,noreferrer")result as a blocked popup and showed the in-app pricing dialog as a fallback. Per the HTML specnoopeneralways returnsnull, so onbilling_webthe tab and the dialog opened together — a latent defect inherited from feat: scaffold hosted billing web app #17370 onmain, caught by this PR's evidence run. The fallback is gone; the E2Ewindow.openstub now returnsnullfornoopenerlike a browser does, and a popover case covers both destinations.useSubscriptionCheckout.recoverOutstandingPaymentand thepayment_method_urlsteps inside an operation are mid-checkout provider steps, not hosted management;invoicesandresultare not served by billing-web yet (ComingSoonView), so nothing mints them; the legacy/customersrail'saccessBillingPortalis being retired by the personal-billing flip and is not touched.@comfyorg/billing-contractbecomes a rootworkspace:*dependency. The CI cloud build for E2E (.github/actions/build-cloud-frontend, used only byci-tests-e2e.yamlandpr-update-playwright-expectations.yaml, never by a deploy) getsVITE_BILLING_WEB_URL=https://billing-web.example, a reserved origin the spec stubs, reachable only when the server flag saysbilling_web.AS-IS / TO-BE
hosted_billing_destination: stripehosted_billing_destination: billing_webSame menu item, unchanged by the flag.
Same menu item, unchanged by the flag.
In-app "Choose a Plan" dialog, no tab opened.
billing-web.example/v1/pricing?product=comfyui&return_to=comfyui_workspacetab opens and nothing else:window.openreturnsnullundernoopeneras the spec requires, and no in-app dialog is left behind.Identical panel; the destination is only read on click.
Identical panel; the destination is only read on click.
POST /api/billing/payment-portalrecorded, and the URL it returned (https://billing.example/portal) opened.No request to
/api/billing/payment-portalon either rail;billing-web.example/v1/payment-methods?product=comfyui&return_to=comfyui_workspaceminted and opened./api/billing/status,/balanceand/capabilitiesre-read.Same three reads;
openPortalWindow+refreshOnPortalReturnstill run on the minted route.stripe, today's default): popover → in-app pricing dialog; settings → Stripe portal viaPOST /billing/payment-portal.billing_web): popover →<billing-web>/v1/pricing?product=comfyui&return_to=comfyui_workspace; settings →<billing-web>/v1/payment-methods?…, no portal request on either rail; the app re-reads billing state on return.Testing
vitest run src/platform/workspace src/composables/billing src/composables/useFeatureFlags src/configpackages/billing-contractvitestpnpm typecheck,typecheck:browser,lint,format,knipfallow audit --changed-since origin/jaewon/fe-2216-plan-changePLAYWRIGHT_TEST_URL=http://localhost:5431 pnpm exec playwright test --project=cloud browser_tests/tests/dialogs/hostedBillingDestination.spec.ts --reporter=list, againstVITE_BILLING_WEB_URL=https://billing-web.example pnpm dev:cloud4 passed (4.6s)— settings on both destinations, plus the two new avatar-menu cases:opens the in-app pricing table from the avatar menu while the destination is stripeandopens the billing-web pricing entry alone from the avatar menu while the destination is billing_webWhere this sits in the plan
Billing SDK track FE-2210 (implementation plan V2). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app.
@comfyorg/account-uicomposables +CheckoutStepsbilling_sdk_topup_enabledhosted_billing_destinationserver flag read by the hosthostedDestinationport on the lifecycle, value on operation state@comfyorg/account→@comfyorg/account-corerenamebilling-contractroute builder +return_toregistrycreateHostedTopupCheckoutpreviewSubscribecommandusePlans,usePaymentMethods,usePreviewSubscribe)ci-billing-web-unit.yaml)/v1entry routing + subscription / payment-method surfacesingest-types,account-core,billing-contract), Platform install, billing-web live top-upbilling_sdk_subscription_enabled/v1/<intent>entries withreturn_towhenhosted_billing_destinationisbilling_webneedsCustomerAttentionpredicate (from the #17665 review)BillingServerCode(from the #17656 review)useCreditsclears onSUPERSEDED(from the #17799 review)SUPERSEDED(from the #17798 review)