Skip to content

FE-2218 refactor(account): rename @comfyorg/account to @comfyorg/account-core - #17851

Merged
dante01yoon merged 4 commits into
mainfrom
jaewon/fe-2218-account-core-rename
Sep 17, 2026
Merged

dante01yoon merged 4 commits into
mainfrom
jaewon/fe-2218-account-core-rename

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Stacked on #17798 (base branch jaewon/fe-2331-plans-payment-methods-readers); merge that first, then this rebases to main with no content change.

Why

Phase 7 (FE-2218) publishes the framework-free billing core to npm so Platform can install it from a clean non-workspace checkout, and the plan fixes the physical account-core / account-ui split as the boundary that gets published, not the transitional packages/account. The view package @comfyorg/account-ui already exists; the core still carries the old name. This is the one mechanical rename PR the plan schedules after Phase 5 slice 1 and before the first publish.

How

Two commits so the review is trivial:

  1. git mv packages/account packages/account-core — 95 files, 0 insertions, 0 deletions, every path a 100% rename.
  2. The specifier and config edits — package name @comfyorg/account → @comfyorg/account-core, every workspace:* dependency (root, apps/billing-web, apps/website, packages/account-ui), every import specifier under src/, packages/, apps/, browser_tests/, the root typecheck / lint scripts (typecheck:account → typecheck:account-core), knip.config.ts, eslint.config.ts, the per-package loop and codecov file list in ci-tests-unit.yaml, the lockfile importer keys, and the two ADRs that name the package in prose. The delta over a 1:1 swap is oxfmt reflowing import lines the five extra characters pushed past 80 columns.

Left alone on purpose: the ./vue entry (the auth Vue pieces move to account-ui in the next PR of this stack), the Firebase app name comfy-account in ADR-0028, and the ADR filenames and headings (renaming those would break the ADR index and inbound links). git grep "@comfyorg/account\b" and git grep "packages/account/" return nothing after this change.

The replay script lives under temp/scripts/rename-account-core.sh (gitignored); if a sibling PR merges first, re-running it on a fresh base reproduces this diff.

AS-IS / TO-BE

No user-facing change; package boundary only.

  • AS-IS: packages/account publishes as @comfyorg/account and is the name Platform would have to install, while the view layer is already @comfyorg/account-ui.
  • TO-BE: packages/account-core publishes as @comfyorg/account-core; account-ui and billing-web depend on it by the final name.

Testing

Gate Result
pnpm install --frozen-lockfile resolves with the new name
packages/account-core vitest 41 files, 674 tests
packages/account-ui vitest 9 files, 41 tests
@comfyorg/billing-web test:unit / build 10 files, 90 tests / built
@comfyorg/website typecheck 0 errors
root pnpm typecheck, lint, format, knip all exit 0
vitest run src/platform/workspace/billing 5 files, 50 tests
pnpm typecheck:browser, typecheck:website (pre-commit) green

Where this sits in the plan

Billing SDK track FE-2210 (implementation plan V2). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app.

Phase Item Ticket Status
1-2 Session core, transport, readers FE-2211/2212/2213 merged
3 Operation lifecycle, commands, eight-state projection FE-2227/2214/2223 merged (#17655)
4 @comfyorg/account-ui composables + CheckoutSteps FE-2215 merged (#17662, #17663)
5 slice 1 Top-up through the SDK behind billing_sdk_topup_enabled FE-2216 merged (#17665)
rollout C hosted_billing_destination server flag read by the host FE-2218 merged (#17716)
rollout C hostedDestination port on the lifecycle, value on operation state FE-2210/2218 #17783 (review)
7 prep Scope-source port + credentialed transport (BFF / cookie hosts) FE-2218 merged (#17782)
7 prep @comfyorg/account → @comfyorg/account-core rename FE-2218 this PR
7 prep billing-contract route builder + return_to registry FE-2218 merged (#17795)
3A-3 Workshop adapter over createHostedTopupCheckout FE-2214 merged (#17793)
8 core previewSubscribe command FE-2331 merged (#17797)
8 core Plans + saved payment-methods readers FE-2331 #17798 (review)
8 ui account-ui composables (usePlans, usePaymentMethods, usePreviewSubscribe) FE-2331 #17798 (review)
7 billing-web own-origin session, sign-in, SDK composition FE-2218 #17798 (review)
7 billing-web unit tests in CI (ci-billing-web-unit.yaml) FE-2218 merged (#17827); #17844 follow-up (review)
7 ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) FE-2218 merged (Comfy-Org/cloud#9512)
8 ui billing-web /v1 entry routing + subscription / payment-method surfaces FE-2331 #17798 (review)
7 npm publish (ingest-types, account-core, billing-contract), Platform install, billing-web live top-up FE-2218 todo
6 Contract tests per generated schema (package layer) FE-2217 #17829 (review)
6 Live E2E per flow × consumer + evidence table FE-2217 todo (needs staging flags)
5 slice 2 Subscription flows through the SDK FE-2216 todo (plan-change decision)
follow-up One needsCustomerAttention predicate (from the #17665 review) FE-2216 merged (#17792)
follow-up Opaque BillingServerCode (from the #17656 review) FE-2227 merged (#17794)
follow-up useCredits clears on SUPERSEDED (from the #17799 review) FE-2215 merged (#17824)
follow-up credits / status / capabilities readers fence a late failure as SUPERSEDED (from the #17798 review) FE-2331 merged (#17828)
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style RN stroke:#0366d6,stroke-width:4px
Loading

@vercel

vercel Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 16, 2026 11:41pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3a2751e1-fa99-4609-9acf-e9ae12282cbe

📥 Commits

Reviewing files that changed from the base of the PR and between 7dc3692 and 35552fe.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (206)
  • .github/workflows/ci-oss-assets-validation.yaml
  • .github/workflows/ci-tests-unit.yaml
  • apps/billing-web/README.md
  • apps/billing-web/package.json
  • apps/billing-web/src/auth/returnTo.ts
  • apps/billing-web/src/auth/signInState.ts
  • apps/billing-web/src/auth/useSignInController.ts
  • apps/billing-web/src/components/PaymentMethodsPanel.vue
  • apps/billing-web/src/components/SubscriptionPanel.vue
  • apps/billing-web/src/components/SubscriptionQuote.vue
  • apps/billing-web/src/components/auth/SignInEmailForm.vue
  • apps/billing-web/src/config/firebase.ts
  • apps/billing-web/src/router.ts
  • apps/billing-web/src/session/billingWebClient.test.ts
  • apps/billing-web/src/session/billingWebClient.ts
  • apps/billing-web/src/session/billingWebSession.test.ts
  • apps/billing-web/src/session/billingWebSession.ts
  • apps/billing-web/src/test/fakeBillingClient.ts
  • apps/billing-web/src/views/PaymentMethodsView.test.ts
  • apps/billing-web/src/views/SignInView.vue
  • apps/billing-web/src/views/SubscriptionView.test.ts
  • apps/website/MODELS_LOCAL_PREVIEW.md
  • apps/website/package.json
  • apps/website/src/components/auth/AuthEmailForm.test.ts
  • apps/website/src/components/auth/AuthEmailForm.vue
  • apps/website/src/components/auth/AuthForgotPassword.vue
  • apps/website/src/components/auth/AuthSignIn.test.ts
  • apps/website/src/components/auth/AuthSignInPanel.vue
  • apps/website/src/components/auth/useAuthSignInController.ts
  • apps/website/src/components/workshop/ModelDetail.test.ts
  • apps/website/src/config/auth-schemas.ts
  • apps/website/src/config/auth-sign-in-state.test.ts
  • apps/website/src/config/auth-sign-in-state.ts
  • apps/website/src/config/workshop-account.test.ts
  • apps/website/src/config/workshop-account.ts
  • apps/website/src/config/workshop-balance.test.ts
  • apps/website/src/config/workshop-balance.ts
  • apps/website/src/config/workshop-billing-sdk.test.ts
  • apps/website/src/config/workshop-billing-sdk.ts
  • apps/website/src/config/workshop-credits.ts
  • apps/website/src/config/workshop-features.test.ts
  • apps/website/src/config/workshop-features.ts
  • apps/website/src/config/workshop-firebase.test.ts
  • apps/website/src/config/workshop-firebase.ts
  • apps/website/src/config/workshop-return.ts
  • apps/website/src/config/workshop-session-state.failure.test.ts
  • apps/website/src/config/workshop-session-state.scope.test.ts
  • apps/website/src/config/workshop-session-state.settled.test.ts
  • apps/website/src/config/workshop-session-state.test.ts
  • apps/website/src/config/workshop-session-state.ts
  • apps/website/src/lib/workshop/buy-credits-sdk.test.ts
  • apps/website/src/lib/workshop/buy-credits-sdk.ts
  • apps/website/src/scripts/posthog.test.ts
  • apps/website/src/scripts/posthog.ts
  • browser_tests/tests/dialogs/signInDialogPasswordRules.spec.ts
  • docs/adr/AUTH-BILLING-0032-billing-stays-outside-the-account-package-in-v1.md
  • docs/adr/AUTH-IDENTITY-0028-account-package-firebase-entry-delivers-cloud-identity.md
  • eslint.config.ts
  • knip.config.ts
  • package.json
  • packages/account-core/package.json
  • packages/account-core/src/core/billing/balanceWatch.test.ts
  • packages/account-core/src/core/billing/balanceWatch.ts
  • packages/account-core/src/core/billing/billingContracts.test.ts
  • packages/account-core/src/core/billing/billingContracts.ts
  • packages/account-core/src/core/billing/billingErrorBody.ts
  • packages/account-core/src/core/billing/billingScope.test.ts
  • packages/account-core/src/core/billing/billingScope.ts
  • packages/account-core/src/core/billing/capabilities.test.ts
  • packages/account-core/src/core/billing/capabilities.ts
  • packages/account-core/src/core/billing/capabilityDenials.ts
  • packages/account-core/src/core/billing/challengeDriver.test.ts
  • packages/account-core/src/core/billing/challengeDriver.ts
  • packages/account-core/src/core/billing/credentialedTransport.ts
  • packages/account-core/src/core/billing/credits.test.ts
  • packages/account-core/src/core/billing/credits.ts
  • packages/account-core/src/core/billing/httpStatus.ts
  • packages/account-core/src/core/billing/index.ts
  • packages/account-core/src/core/billing/operationLifecycle.test.ts
  • packages/account-core/src/core/billing/operationLifecycle.ts
  • packages/account-core/src/core/billing/operationPointer.test.ts
  • packages/account-core/src/core/billing/operationPointer.ts
  • packages/account-core/src/core/billing/operationPolicy.ts
  • packages/account-core/src/core/billing/operationState.test.ts
  • packages/account-core/src/core/billing/operationState.ts
  • packages/account-core/src/core/billing/paymentCopy.test.ts
  • packages/account-core/src/core/billing/paymentCopy.ts
  • packages/account-core/src/core/billing/paymentMethods.test.ts
  • packages/account-core/src/core/billing/paymentMethods.ts
  • packages/account-core/src/core/billing/paymentProjection.test.ts
  • packages/account-core/src/core/billing/paymentProjection.ts
  • packages/account-core/src/core/billing/plans.test.ts
  • packages/account-core/src/core/billing/plans.ts
  • packages/account-core/src/core/billing/presentation.test.ts
  • packages/account-core/src/core/billing/presentation.ts
  • packages/account-core/src/core/billing/sharedRead.test.ts
  • packages/account-core/src/core/billing/sharedRead.ts
  • packages/account-core/src/core/billing/status.test.ts
  • packages/account-core/src/core/billing/status.ts
  • packages/account-core/src/core/billing/subscriptionCommands.test.ts
  • packages/account-core/src/core/billing/subscriptionCommands.ts
  • packages/account-core/src/core/billing/topup.test.ts
  • packages/account-core/src/core/billing/topup.ts
  • packages/account-core/src/core/billing/transport.test.ts
  • packages/account-core/src/core/billing/transport.ts
  • packages/account-core/src/core/billing/transportExchange.ts
  • packages/account-core/src/core/boundedOperation.test.ts
  • packages/account-core/src/core/boundedOperation.ts
  • packages/account-core/src/core/customerRecovery.test.ts
  • packages/account-core/src/core/customerRecovery.ts
  • packages/account-core/src/core/exchange.ts
  • packages/account-core/src/core/identity.test.ts
  • packages/account-core/src/core/identity.ts
  • packages/account-core/src/core/importGuard.test.ts
  • packages/account-core/src/core/refreshScheduler.ts
  • packages/account-core/src/core/session.scheduler.test.ts
  • packages/account-core/src/core/session.test.ts
  • packages/account-core/src/core/session.ts
  • packages/account-core/src/core/sessionContracts.ts
  • packages/account-core/src/firebase/index.test.ts
  • packages/account-core/src/firebase/index.ts
  • packages/account-core/src/firebaseAuthError.test.ts
  • packages/account-core/src/firebaseAuthError.ts
  • packages/account-core/src/provisioning.test.ts
  • packages/account-core/src/provisioning.ts
  • packages/account-core/src/redirect.test.ts
  • packages/account-core/src/redirect.ts
  • packages/account-core/src/signInSchemas.test.ts
  • packages/account-core/src/signInSchemas.ts
  • packages/account-core/src/telemetry.ts
  • packages/account-core/src/testing.ts
  • packages/account-core/src/turnstile.test.ts
  • packages/account-core/src/turnstile.ts
  • packages/account-core/src/turnstileScript.test.ts
  • packages/account-core/src/turnstileScript.ts
  • packages/account-core/src/vue/PasswordRules.test.ts
  • packages/account-core/src/vue/PasswordRules.vue
  • packages/account-core/src/vue/SocialAuthButtons.test.ts
  • packages/account-core/src/vue/SocialAuthButtons.vue
  • packages/account-core/src/vue/TurnstileWidget.test.ts
  • packages/account-core/src/vue/TurnstileWidget.vue
  • packages/account-core/src/vue/lifecycleScope.test.ts
  • packages/account-core/src/vue/lifecycleScope.ts
  • packages/account-core/src/vue/regionGate.test.ts
  • packages/account-core/src/vue/regionGate.ts
  • packages/account-core/src/vue/turnstileGate.test.ts
  • packages/account-core/src/vue/turnstileGate.ts
  • packages/account-core/src/vue/useGenerationGuard.test.ts
  • packages/account-core/src/vue/useGenerationGuard.ts
  • packages/account-core/src/vueBoundary.test.ts
  • packages/account-core/src/web/crossTabRefresh.test.ts
  • packages/account-core/src/web/crossTabRefresh.ts
  • packages/account-core/src/webviewDetection.test.ts
  • packages/account-core/src/webviewDetection.ts
  • packages/account-core/tsconfig.json
  • packages/account-core/vitest.config.ts
  • packages/account-ui/package.json
  • packages/account-ui/src/billing/CheckoutSteps.test.ts
  • packages/account-ui/src/billing/CheckoutSteps.vue
  • packages/account-ui/src/billing/__fixtures__/billingHarness.ts
  • packages/account-ui/src/billing/billingClient.test.ts
  • packages/account-ui/src/billing/billingClient.ts
  • packages/account-ui/src/billing/index.ts
  • packages/account-ui/src/billing/useBillingOperation.test.ts
  • packages/account-ui/src/billing/useBillingOperation.ts
  • packages/account-ui/src/billing/useCheckout.test.ts
  • packages/account-ui/src/billing/useCheckout.ts
  • packages/account-ui/src/billing/useCredits.test.ts
  • packages/account-ui/src/billing/useCredits.ts
  • packages/account-ui/src/billing/usePaymentAttempt.ts
  • packages/account-ui/src/billing/usePaymentMethods.test.ts
  • packages/account-ui/src/billing/usePaymentMethods.ts
  • packages/account-ui/src/billing/usePlans.test.ts
  • packages/account-ui/src/billing/usePlans.ts
  • packages/account-ui/src/billing/usePreviewSubscribe.test.ts
  • packages/account-ui/src/billing/usePreviewSubscribe.ts
  • packages/account-ui/src/billing/useTopUp.test.ts
  • packages/account-ui/src/billing/useTopUp.ts
  • src/components/dialog/content/SignInContent.test.ts
  • src/components/dialog/content/SignInContent.vue
  • src/components/dialog/content/signin/PasswordFields.vue
  • src/components/dialog/content/signin/TurnstileWidget.render.test.ts
  • src/components/dialog/content/signin/TurnstileWidget.test.ts
  • src/components/dialog/content/signin/TurnstileWidget.vue
  • src/composables/auth/useAuthActions.ts
  • src/composables/auth/useTurnstile.test.ts
  • src/composables/auth/useTurnstile.ts
  • src/locales/authCopy.package.test.ts
  • src/platform/cloud/onboarding/CloudLoginView.test.ts
  • src/platform/cloud/onboarding/CloudSignupView.test.ts
  • src/platform/cloud/onboarding/CloudSignupView.vue
  • src/platform/cloud/onboarding/components/CloudSocialAuthButtons.vue
  • src/platform/cloud/onboarding/composables/useCloudAuthPage.ts
  • src/platform/cloud/onboarding/utils/previousFullPath.ts
  • src/platform/remoteConfig/types.ts
  • src/platform/telemetry/types.ts
  • src/platform/workspace/billing/sdk/billingSdkStore.ts
  • src/platform/workspace/billing/sdk/billingSdkTelemetry.ts
  • src/platform/workspace/billing/sdk/billingSdkTestUtils.ts
  • src/platform/workspace/billing/sdk/createBillingSdk.test.ts
  • src/platform/workspace/billing/sdk/createBillingSdk.ts
  • src/platform/workspace/billing/sdk/topupOperationView.ts
  • src/platform/workspace/stores/workspaceAuthStore.copy.test.ts
  • src/platform/workspace/stores/workspaceAuthStore.ts
  • src/schemas/signInSchema.ts
  • src/stores/authStore.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The pull request renames @comfyorg/account to @comfyorg/account-core across workspace metadata, applications, UI packages, tests, documentation, CI workflows, and package-internal references. Runtime logic and imported identifiers remain unchanged.

Changes

Account-core package migration

Layer / File(s) Summary
Package metadata and CI migration
.github/workflows/*, package.json, packages/account-core/*, packages/account-ui/package.json, eslint.config.ts, knip.config.ts, docs/adr/*, apps/*/README.md, apps/website/MODELS_LOCAL_PREVIEW.md
Package names, workspace scripts, dependencies, CI paths, license exclusions, documentation references, and package-internal identifiers now use account-core.
Application and UI import migration
apps/billing-web/..., apps/website/..., packages/account-ui/src/..., src/..., browser_tests/...
Application, UI, test, mock, re-export, telemetry, authentication, billing, session, Firebase, and Turnstile module paths now use @comfyorg/account-core subpaths. Existing logic and assertions remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Refactor

Suggested reviewers: maanilverma

Merge Risk: ⚪ Minimal · up to 35552

This package rename is ready to merge; active imports, workspace metadata, and lockfile entries resolve to account-core.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR title and both commit subjects use refactor/rename language. They do not contain bug-fix language such as fix, fixed, fixes, fixing, bugfix, or hotfix. The custom check therefore does not apply…
Website End-To-End Regression Coverage ✅ Passed The PR changes files under apps/website/src/, so the check applies. The listed website changes only rename @comfyorg/account import paths and update comments; they do not change a route, page, for…
Adr Compliance For Entity/Litegraph Changes ✅ Passed PASS. The changed-file list contains no files under src/lib/litegraph/ or src/ecs/, and no files related to graph entities such as nodes, links, widgets, slots, reroutes, groups, or subgraphs. The…
Title check ✅ Passed The title clearly identifies the main change: renaming the account package to @comfyorg/account-core.
Description check ✅ Passed The description is detailed and covers the change rationale, implementation, scope, breaking impact, dependencies, testing, review context, and plan placement. It uses custom headings instead of the t…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaewon/fe-2218-account-core-rename

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2030 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2009 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/16/2026, 11:47:27 PM UTC

Links

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-17851.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-655p6hhex-comfyui.vercel.app

Last updated: 2026-09-16T23:44:29Z for 8ca1c81

📦 Bundle: 10 MB gzip 🔴 +69 B

Details

Summary

  • Raw size: 42.6 MB baseline 42.6 MB — 🔴 +235 B
  • Gzip: 10 MB baseline 10 MB — 🔴 +69 B
  • Brotli: 7.08 MB baseline 7.08 MB — 🔴 +314 B
  • Bundles: 452 current • 452 baseline • 157 added / 157 removed

Category Glance
Data & Services 🔴 +170 B (3.81 MB) · User & Accounts 🔴 +35 B (32.3 kB) · Other 🔴 +15 B (17.5 MB) · Views & Navigation 🔴 +15 B (132 kB) · Vendor & Third-Party ⚪ 0 B (18.2 MB) · Graph Workspace ⚪ 0 B (1.44 MB) · + 5 more

App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-C1P_pApB.js (removed) 3.73 kB — 🟢 -3.73 kB 🟢 -1.87 kB 🟢 -1.64 kB
assets/index-DH7kwqaW.js (new) — 3.73 kB 🔴 +3.73 kB 🔴 +1.87 kB 🔴 +1.61 kB

Status: 1 added / 1 removed

Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-Bv5UWEZP.js (new) — 1.43 MB 🔴 +1.43 MB 🔴 +314 kB 🔴 +235 kB
assets/GraphView-CgkDTapK.js (removed) 1.43 MB — 🟢 -1.43 MB 🟢 -314 kB 🟢 -235 kB
assets/WidgetCompositor-BGdE-t4Z.js (new) — 8.5 kB 🔴 +8.5 kB 🔴 +2.8 kB 🔴 +2.48 kB
assets/WidgetCompositor-WxB1SClE.js (removed) 8.5 kB — 🟢 -8.5 kB 🟢 -2.8 kB 🟢 -2.48 kB

Status: 2 added / 2 removed / 1 unchanged

Views & Navigation — 132 kB (baseline 132 kB) • 🔴 +15 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-COrSCUP3.js (new) — 25 kB 🔴 +25 kB 🔴 +6.25 kB 🔴 +5.51 kB
assets/CloudSurveyView-ffU_0SeB.js (removed) 25 kB — 🟢 -25 kB 🟢 -6.24 kB 🟢 -5.53 kB
assets/CloudLayoutView-DxFgaS-u.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -6.56 kB 🟢 -5.72 kB
assets/CloudLayoutView-hrMpkNM5.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +6.55 kB 🔴 +5.75 kB
assets/useCloudAuthPage-QdN-jibT.js (new) — 11.1 kB 🔴 +11.1 kB 🔴 +4.18 kB 🔴 +3.53 kB
assets/useCloudAuthPage-CClyjcpl.js (removed) 11 kB — 🟢 -11 kB 🟢 -4.17 kB 🟢 -3.53 kB
assets/CloudLoginView-CSQPjcfV.js (removed) 8.74 kB — 🟢 -8.74 kB 🟢 -2.55 kB 🟢 -2.26 kB
assets/CloudLoginView-qk_0tsyH.js (new) — 8.74 kB 🔴 +8.74 kB 🔴 +2.56 kB 🔴 +2.26 kB
assets/UserCheckView-BwKCnY0L.js (removed) 8.51 kB — 🟢 -8.51 kB 🟢 -2.13 kB 🟢 -1.86 kB
assets/UserCheckView-DKCBMpC8.js (new) — 8.51 kB 🔴 +8.51 kB 🔴 +2.13 kB 🔴 +1.86 kB
assets/CloudSignupView-C_sGnnip.js (new) — 6.96 kB 🔴 +6.96 kB 🔴 +2.28 kB 🔴 +1.99 kB
assets/CloudSignupView-CYFtX5uo.js (removed) 6.96 kB — 🟢 -6.96 kB 🟢 -2.28 kB 🟢 -2 kB
assets/WidgetTextPreview-BHb9U-9S.js (removed) 6.06 kB — 🟢 -6.06 kB 🟢 -2.12 kB 🟢 -1.89 kB
assets/WidgetTextPreview-DFJnFEZ8.js (new) — 6.06 kB 🔴 +6.06 kB 🔴 +2.12 kB 🔴 +1.9 kB
assets/CloudSubscriptionRedirectView-Bgt_793u.js (new) — 5.69 kB 🔴 +5.69 kB 🔴 +1.93 kB 🔴 +1.69 kB
assets/CloudSubscriptionRedirectView-Bmhew_-X.js (removed) 5.69 kB — 🟢 -5.69 kB 🟢 -1.93 kB 🟢 -1.7 kB
assets/UserSelectView-Ck0aUORz.js (removed) 5.63 kB — 🟢 -5.63 kB 🟢 -2 kB 🟢 -1.75 kB
assets/UserSelectView-Dh3fu4rq.js (new) — 5.63 kB 🔴 +5.63 kB 🔴 +2 kB 🔴 +1.75 kB
assets/CloudForgotPasswordView-CByrQMDh.js (new) — 5 kB 🔴 +5 kB 🔴 +1.72 kB 🔴 +1.5 kB
assets/CloudForgotPasswordView-DnmZZyIA.js (removed) 5 kB — 🟢 -5 kB 🟢 -1.72 kB 🟢 -1.5 kB
assets/CloudAuthTimeoutView-BPzj8OSZ.js (removed) 4.43 kB — 🟢 -4.43 kB 🟢 -1.54 kB 🟢 -1.33 kB
assets/CloudAuthTimeoutView-D5D7qj9D.js (new) — 4.43 kB 🔴 +4.43 kB 🔴 +1.54 kB 🔴 +1.33 kB
assets/WidgetResolutionPreview-_taL71Lu.js (new) — 3.78 kB 🔴 +3.78 kB 🔴 +1.49 kB 🔴 +1.33 kB
assets/WidgetResolutionPreview-CocK18ms.js (removed) 3.78 kB — 🟢 -3.78 kB 🟢 -1.49 kB 🟢 -1.33 kB
assets/OAuthLayoutView-B1sAh2B8.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +706 B 🔴 +595 B
assets/OAuthLayoutView-B77Hz6e7.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -706 B 🟢 -596 B
assets/WidgetTextPreview-B6Ygm7Yt.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -87 B
assets/WidgetTextPreview-Rm8akgSP.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +89 B

Status: 14 added / 14 removed / 4 unchanged

Panels & Settings — 623 kB (baseline 623 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-Cmq6x2F_.js (removed) 49.4 kB — 🟢 -49.4 kB 🟢 -9.95 kB 🟢 -8.82 kB
assets/KeybindingPanel-DMnKLivb.js (new) — 49.4 kB 🔴 +49.4 kB 🔴 +9.95 kB 🔴 +8.8 kB
assets/CreditsPanel-Bbu0O29w.js (new) — 38 kB 🔴 +38 kB 🔴 +9.12 kB 🔴 +8 kB
assets/CreditsPanel-BTi2G_h6.js (removed) 38 kB — 🟢 -38 kB 🟢 -9.12 kB 🟢 -8.01 kB
assets/SecretsPanel-Cz255vFR.js (new) — 33.8 kB 🔴 +33.8 kB 🔴 +7.9 kB 🔴 +6.92 kB
assets/SecretsPanel-jrDIGGrT.js (removed) 33.8 kB — 🟢 -33.8 kB 🟢 -7.9 kB 🟢 -6.93 kB
assets/AboutPanel-CcPOX2je.js (removed) 11.4 kB — 🟢 -11.4 kB 🟢 -3.14 kB 🟢 -2.8 kB
assets/AboutPanel-UxdeKhiq.js (new) — 11.4 kB 🔴 +11.4 kB 🔴 +3.14 kB 🔴 +2.82 kB
assets/ExtensionPanel-DV_DlvIm.js (removed) 9.19 kB — 🟢 -9.19 kB 🟢 -2.51 kB 🟢 -2.23 kB
assets/ExtensionPanel-Q4XrOUxP.js (new) — 9.19 kB 🔴 +9.19 kB 🔴 +2.51 kB 🔴 +2.24 kB
assets/ServerConfigPanel-C_FqXuw_.js (removed) 6.15 kB — 🟢 -6.15 kB 🟢 -1.96 kB 🟢 -1.74 kB
assets/ServerConfigPanel-CRrP-jNn.js (new) — 6.15 kB 🔴 +6.15 kB 🔴 +1.96 kB 🔴 +1.74 kB
assets/UserPanel-DHSlD3fo.js (new) — 5.76 kB 🔴 +5.76 kB 🔴 +1.8 kB 🔴 +1.55 kB
assets/UserPanel-rrlipTZY.js (removed) 5.76 kB — 🟢 -5.76 kB 🟢 -1.8 kB 🟢 -1.55 kB
assets/refreshRemoteConfig-BkHXvQeM.js (removed) 4.54 kB — 🟢 -4.54 kB 🟢 -1.6 kB 🟢 -1.43 kB
assets/refreshRemoteConfig-DP_TjZfq.js (new) — 4.54 kB 🔴 +4.54 kB 🔴 +1.6 kB 🔴 +1.43 kB
assets/CreditsPanel-CwOmbLHw.js (new) — 116 B 🔴 +116 B 🔴 +95 B 🔴 +92 B
assets/CreditsPanel-Dapb8rNe.js (removed) 116 B — 🟢 -116 B 🟢 -95 B 🟢 -93 B
assets/refreshRemoteConfig-CXcM3itD.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -86 B
assets/refreshRemoteConfig-DCdUqU4W.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +86 B

Status: 10 added / 10 removed / 17 unchanged

User & Accounts — 32.3 kB (baseline 32.3 kB) • 🔴 +35 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-BwFSb3lz.js (new) — 15.8 kB 🔴 +15.8 kB 🔴 +5.1 kB 🔴 +4.44 kB
assets/SignUpForm-C8VhAsJX.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -5.1 kB 🟢 -4.43 kB
assets/PasswordFields-C6YNPXpG.js (new) — 6.22 kB 🔴 +6.22 kB 🔴 +1.87 kB 🔴 +1.64 kB
assets/PasswordFields-CfZxAgul.js (removed) 6.21 kB — 🟢 -6.21 kB 🟢 -1.86 kB 🟢 -1.63 kB
assets/auth-BaSch-lo.js (removed) 3.48 kB — 🟢 -3.48 kB 🟢 -1.2 kB 🟢 -1.01 kB
assets/auth-DiaJWbfA.js (new) — 3.48 kB 🔴 +3.48 kB 🔴 +1.2 kB 🔴 +1.01 kB
assets/UpdatePasswordContent-CXga8KJi.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -841 B 🟢 -731 B
assets/UpdatePasswordContent-Da6mQgGP.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +844 B 🔴 +735 B
assets/authStore-Ce6TBg61.js (new) — 126 B 🔴 +126 B 🔴 +106 B 🔴 +102 B
assets/authStore-Doc3wqax.js (removed) 126 B — 🟢 -126 B 🟢 -106 B 🟢 -102 B
assets/workspaceAuthStore-CbHFWRBr.js (new) — 108 B 🔴 +108 B 🔴 +99 B 🔴 +108 B
assets/workspaceAuthStore-CvyZTxqN.js (removed) 108 B — 🟢 -108 B 🟢 -99 B 🟢 -105 B
assets/auth-DQEvgzNw.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -84 B
assets/auth-zesEyJms.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +80 B

Status: 7 added / 7 removed / 4 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-BTS47XEZ.js (new) — 90.8 kB 🔴 +90.8 kB 🔴 +19.3 kB 🔴 +16.5 kB
assets/ComfyHubPublishDialog-DyRJF2hp.js (removed) 90.8 kB — 🟢 -90.8 kB 🟢 -19.3 kB 🟢 -16.6 kB
assets/useShareDialog-BFfC3tLC.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.74 kB 🔴 +5.08 kB
assets/useShareDialog-CA1_ETNT.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.74 kB 🟢 -5.08 kB
assets/feedbackDialog-B9AywHOi.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.86 kB 🟢 -1.59 kB
assets/feedbackDialog-DsLjSXre.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.86 kB 🔴 +1.59 kB
assets/useRangeEditor-DlCUJdwj.js (removed) 3.29 kB — 🟢 -3.29 kB 🟢 -1.14 kB 🟢 -1.04 kB
assets/useRangeEditor-DXdDGVSM.js (new) — 3.29 kB 🔴 +3.29 kB 🔴 +1.14 kB 🔴 +1.03 kB
assets/useLayerEditor-CoQHS8V3.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -563 B 🟢 -507 B
assets/useLayerEditor-DKgXP3b8.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +564 B 🔴 +487 B
assets/ComfyHubPublishDialog-B5HjT-XO.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -88 B
assets/ComfyHubPublishDialog-rrUTxVcY.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +89 B
assets/useSubscriptionDialog-Dm7_FShn.js (new) — 107 B 🔴 +107 B 🔴 +101 B 🔴 +91 B
assets/useSubscriptionDialog-DsOqLlCj.js (removed) 107 B — 🟢 -107 B 🟢 -101 B 🟢 -94 B

Status: 7 added / 7 removed / 1 unchanged

UI Components — 124 kB (baseline 124 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-BXzRxNM-.js (removed) 47.8 kB — 🟢 -47.8 kB 🟢 -11.5 kB 🟢 -9.98 kB
assets/useMoreOptionsMenu-C--UoKHf.js (new) — 47.8 kB 🔴 +47.8 kB 🔴 +11.5 kB 🔴 +9.97 kB
assets/ComfyQueueButton-Bvk7-7uD.js (new) — 14.6 kB 🔴 +14.6 kB 🔴 +3.98 kB 🔴 +3.53 kB
assets/ComfyQueueButton-CL6-uJu9.js (removed) 14.6 kB — 🟢 -14.6 kB 🟢 -3.98 kB 🟢 -3.53 kB
assets/useTerminalTabs-625Iycgl.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.71 kB 🟢 -3.28 kB
assets/useTerminalTabs-Bi2WjkaR.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.71 kB 🔴 +3.29 kB
assets/InviteMembersForm-3Mp2vF3Z.js (new) — 10.5 kB 🔴 +10.5 kB 🔴 +3.15 kB 🔴 +2.81 kB
assets/InviteMembersForm-D0KPsOGs.js (removed) 10.5 kB — 🟢 -10.5 kB 🟢 -3.15 kB 🟢 -2.81 kB
assets/SubscribeButton-BNdU826T.js (new) — 2.15 kB 🔴 +2.15 kB 🔴 +969 B 🔴 +848 B
assets/SubscribeButton-CegO1h31.js (removed) 2.15 kB — 🟢 -2.15 kB 🟢 -969 B 🟢 -847 B
assets/cloudFeedbackTopbarButton-ChIiwieu.js (removed) 701 B — 🟢 -701 B 🟢 -418 B 🟢 -375 B
assets/cloudFeedbackTopbarButton-CPYB6Fsj.js (new) — 701 B 🔴 +701 B 🔴 +418 B 🔴 +376 B
assets/ComfyQueueButton-BCoo0hF_.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +89 B
assets/ComfyQueueButton-BG8ZKFuO.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -94 B

Status: 7 added / 7 removed / 9 unchanged

Data & Services — 3.81 MB (baseline 3.81 MB) • 🔴 +170 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settingStore-BIf1-QDx.js (new) — 3.48 MB 🔴 +3.48 MB 🔴 +827 kB 🔴 +624 kB
assets/settingStore-7lJ24rsi.js (removed) 3.48 MB — 🟢 -3.48 MB 🟢 -827 kB 🟢 -624 kB
assets/api-BMPPDlcw.js (new) — 181 kB 🔴 +181 kB 🔴 +41.5 kB 🔴 +35 kB
assets/api-Cbqx8Pun.js (removed) 181 kB — 🟢 -181 kB 🟢 -41.5 kB 🟢 -34.9 kB
assets/load3dService-DS-NyIo6.js (new) — 87 kB 🔴 +87 kB 🔴 +20.3 kB 🔴 +17.6 kB
assets/load3dService-IL-2Y5iV.js (removed) 87 kB — 🟢 -87 kB 🟢 -20.3 kB 🟢 -17.6 kB
assets/releaseStore-CtIIeleP.js (new) — 23.8 kB 🔴 +23.8 kB 🔴 +7.07 kB 🔴 +6.21 kB
assets/releaseStore-CWtvsT-_.js (removed) 23.8 kB — 🟢 -23.8 kB 🟢 -7.06 kB 🟢 -6.21 kB
assets/workflowShareService-BjUCAAYE.js (removed) 17 kB — 🟢 -17 kB 🟢 -5.06 kB 🟢 -4.46 kB
assets/workflowShareService-DyY_7Gvj.js (new) — 17 kB 🔴 +17 kB 🔴 +5.06 kB 🔴 +4.47 kB
assets/keybindingService-4rCYddve.js (new) — 6.95 kB 🔴 +6.95 kB 🔴 +1.74 kB 🔴 +1.52 kB
assets/keybindingService-D0TuUNR1.js (removed) 6.95 kB — 🟢 -6.95 kB 🟢 -1.74 kB 🟢 -1.51 kB
assets/userStore-CEXx39lC.js (removed) 2.38 kB — 🟢 -2.38 kB 🟢 -898 B 🟢 -794 B
assets/userStore-D6AV-u-0.js (new) — 2.38 kB 🔴 +2.38 kB 🔴 +898 B 🔴 +795 B
assets/audioService-BVSSkK8R.js (new) — 1.71 kB 🔴 +1.71 kB 🔴 +829 B 🔴 +725 B
assets/audioService-DTODERYg.js (removed) 1.71 kB — 🟢 -1.71 kB 🟢 -829 B 🟢 -735 B
assets/dialogService-BmN6piji.js (removed) 97 B — 🟢 -97 B 🟢 -96 B 🟢 -85 B
assets/dialogService-DbjGylh_.js (new) — 97 B 🔴 +97 B 🔴 +96 B 🔴 +81 B
assets/releaseStore-D9kiPsO9.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +84 B
assets/releaseStore-jxqa9kd3.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -78 B
assets/settingStore-CTgnqCPi.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +86 B
assets/settingStore-zl6V28bN.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -87 B
assets/assetsStore-CL21wa_c.js (removed) 94 B — 🟢 -94 B 🟢 -92 B 🟢 -84 B
assets/assetsStore-tjSm6ZQO.js (new) — 94 B 🔴 +94 B 🔴 +92 B 🔴 +85 B
assets/api-CTuea8Pc.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B
assets/api-CWDUCyin.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B

Status: 13 added / 13 removed / 3 unchanged

Utilities & Hooks — 561 kB (baseline 561 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-BMcZmf-m.js (new) — 235 kB 🔴 +235 kB 🔴 +53 kB 🔴 +43.2 kB
assets/useConflictDetection-C3pq2uYt.js (removed) 235 kB — 🟢 -235 kB 🟢 -53 kB 🟢 -43.2 kB
assets/useLayerEditorSession-BpR2Gr3-.js (removed) 159 kB — 🟢 -159 kB 🟢 -41 kB 🟢 -34.5 kB
assets/useLayerEditorSession-DWBc9UWO.js (new) — 159 kB 🔴 +159 kB 🔴 +41 kB 🔴 +34.5 kB
assets/useLoad3d-DntBC1vA.js (removed) 26.3 kB — 🟢 -26.3 kB 🟢 -5.95 kB 🟢 -5.28 kB
assets/useLoad3d-DxZZOwyD.js (new) — 26.3 kB 🔴 +26.3 kB 🔴 +5.95 kB 🔴 +5.28 kB
assets/useLoad3dViewer-BlzbG2Pi.js (new) — 21.9 kB 🔴 +21.9 kB 🔴 +5.24 kB 🔴 +4.58 kB
assets/useLoad3dViewer-Cuevyxw5.js (removed) 21.9 kB — 🟢 -21.9 kB 🟢 -5.25 kB 🟢 -4.59 kB
assets/useImageCrop-C-3qG8De.js (removed) 15.3 kB — 🟢 -15.3 kB 🟢 -3.53 kB 🟢 -3.08 kB
assets/useImageCrop-DAkCK-Oy.js (new) — 15.3 kB 🔴 +15.3 kB 🔴 +3.53 kB 🔴 +3.08 kB
assets/useDowngradeToPersonal-6P4Dk7vp.js (new) — 11 kB 🔴 +11 kB 🔴 +2.78 kB 🔴 +2.39 kB
assets/useDowngradeToPersonal-BRrimvZJ.js (removed) 11 kB — 🟢 -11 kB 🟢 -2.78 kB 🟢 -2.39 kB
assets/useFeatureFlags-BjNm0ANc.js (removed) 9.35 kB — 🟢 -9.35 kB 🟢 -2.63 kB 🟢 -2.24 kB
assets/useFeatureFlags-D6ONDJ3c.js (new) — 9.35 kB 🔴 +9.35 kB 🔴 +2.63 kB 🔴 +2.24 kB
assets/useExternalLink-BHQQ3xWm.js (new) — 7.57 kB 🔴 +7.57 kB 🔴 +2.55 kB 🔴 +2.17 kB
assets/useExternalLink-CZuhxLQG.js (removed) 7.57 kB — 🟢 -7.57 kB 🟢 -2.55 kB 🟢 -2.17 kB
assets/usePricingTableUrlLoader-CKAn6qc0.js (removed) 4.81 kB — 🟢 -4.81 kB 🟢 -1.66 kB 🟢 -1.41 kB
assets/usePricingTableUrlLoader-D4ScjfKu.js (new) — 4.81 kB 🔴 +4.81 kB 🔴 +1.65 kB 🔴 +1.41 kB
assets/useCompositorLayers-BrExN32K.js (new) — 2.93 kB 🔴 +2.93 kB 🔴 +858 B 🔴 +776 B
assets/useCompositorLayers-Dyrl0mCZ.js (removed) 2.93 kB — 🟢 -2.93 kB 🟢 -857 B 🟢 -778 B
assets/useScheduledPlanChange-Dh8rlgHJ.js (removed) 2.4 kB — 🟢 -2.4 kB 🟢 -962 B 🟢 -832 B
assets/useScheduledPlanChange-DkQ5kSEZ.js (new) — 2.4 kB 🔴 +2.4 kB 🔴 +962 B 🔴 +836 B
assets/useUpstreamValue-m3nmLveP.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +750 B 🔴 +697 B
assets/useUpstreamValue-xpEURLyf.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -750 B 🟢 -663 B
assets/useWorkspaceTierLabel-CpOt9wk2.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -843 B 🟢 -713 B
assets/useWorkspaceTierLabel-j6xxjNvD.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +843 B 🔴 +712 B
assets/useSessionCookie-BUWzf1Ue.js (new) — 688 B 🔴 +688 B 🔴 +353 B 🔴 +308 B
assets/useSessionCookie-Dwldn2HP.js (removed) 688 B — 🟢 -688 B 🟢 -352 B 🟢 -307 B
assets/useLoad3d-BhN2Nlqc.js (removed) 311 B — 🟢 -311 B 🟢 -163 B 🟢 -147 B
assets/useLoad3d-CFHR8Wuj.js (new) — 311 B 🔴 +311 B 🔴 +163 B 🔴 +148 B
assets/useSessionCookie-B_IMZFEJ.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +76 B
assets/useSessionCookie-BKJTPzGs.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -86 B
assets/useFeatureFlags-Cl50tmEI.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -79 B
assets/useFeatureFlags-OKEoHDv9.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +90 B
assets/useLoad3dViewer-CWCZKwKG.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +85 B
assets/useLoad3dViewer-qX0s75_-.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -84 B
assets/useCurrentUser-DYepnUL-.js (new) — 93 B 🔴 +93 B 🔴 +94 B 🔴 +86 B
assets/useCurrentUser-WbPkwTSj.js (removed) 93 B — 🟢 -93 B 🟢 -94 B 🟢 -87 B

Status: 19 added / 19 removed / 18 unchanged

Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 17.5 MB (baseline 17.5 MB) • 🔴 +15 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-CkafwfcN.js (removed) 118 kB — 🟢 -118 kB 🟢 -30.8 kB 🟢 -26 kB
assets/core-DVNVHfdx.js (new) — 118 kB 🔴 +118 kB 🔴 +30.8 kB 🔴 +26 kB
assets/WorkspaceSettingsPanelContent-B_gWPzmm.js (removed) 111 kB — 🟢 -111 kB 🟢 -21.8 kB 🟢 -18.2 kB
assets/WorkspaceSettingsPanelContent-B8fHwAAw.js (new) — 111 kB 🔴 +111 kB 🔴 +21.8 kB 🔴 +18.2 kB
assets/SubscriptionTransitionPreviewWorkspace-B1yXSSS8.js (new) — 104 kB 🔴 +104 kB 🔴 +20.3 kB 🔴 +17.2 kB
assets/SubscriptionTransitionPreviewWorkspace-Bowt1Mw9.js (removed) 104 kB — 🟢 -104 kB 🟢 -20.3 kB 🟢 -17.2 kB
assets/WidgetSelect-C-IfO2G1.js (removed) 88.6 kB — 🟢 -88.6 kB 🟢 -20.1 kB 🟢 -17.1 kB
assets/WidgetSelect-Dge_W937.js (new) — 88.6 kB 🔴 +88.6 kB 🔴 +20.1 kB 🔴 +17.1 kB
assets/Load3D-BNeD0kdN.js (removed) 82.4 kB — 🟢 -82.4 kB 🟢 -13.6 kB 🟢 -11.5 kB
assets/Load3D-BSv9hLF4.js (new) — 82.4 kB 🔴 +82.4 kB 🔴 +13.6 kB 🔴 +11.4 kB
assets/WidgetVideoEdit-D0nkzvHM.js (new) — 73.2 kB 🔴 +73.2 kB 🔴 +17.4 kB 🔴 +15.2 kB
assets/WidgetVideoEdit-xfZsyyrz.js (removed) 73.2 kB — 🟢 -73.2 kB 🟢 -17.4 kB 🟢 -15.2 kB
assets/CameraInfo-BAGqSfLU.js (removed) 67.3 kB — 🟢 -67.3 kB 🟢 -14.6 kB 🟢 -12.8 kB
assets/CameraInfo-CiFk97P1.js (new) — 67.3 kB 🔴 +67.3 kB 🔴 +14.6 kB 🔴 +12.8 kB
assets/Preview3d-CxEQXt5O.js (new) — 52.6 kB 🔴 +52.6 kB 🔴 +8.6 kB 🔴 +7.51 kB
assets/Preview3d-jUA1-5Lu.js (removed) 52.6 kB — 🟢 -52.6 kB 🟢 -8.59 kB 🟢 -7.51 kB
assets/SubscriptionRequiredDialogContentUnified-CsTyL8St.js (removed) 52.4 kB — 🟢 -52.4 kB 🟢 -11 kB 🟢 -9.64 kB
assets/SubscriptionRequiredDialogContentUnified-DhToAKd_.js (new) — 52.4 kB 🔴 +52.4 kB 🔴 +11 kB 🔴 +9.63 kB
assets/Viewport3d-1UKUKwzc.js (removed) 48 kB — 🟢 -48 kB 🟢 -10.2 kB 🟢 -9.01 kB
assets/Viewport3d-a2rJv_BH.js (new) — 48 kB 🔴 +48 kB 🔴 +10.2 kB 🔴 +9.02 kB
assets/LayerEditorContent-CGyyvj9I.js (new) — 45.4 kB 🔴 +45.4 kB 🔴 +10.6 kB 🔴 +9.27 kB
assets/LayerEditorContent-GJhNodkY.js (removed) 45.4 kB — 🟢 -45.4 kB 🟢 -10.6 kB 🟢 -9.25 kB
assets/main-B0dLtT8Y.js (removed) 44.4 kB — 🟢 -44.4 kB 🟢 -13.3 kB 🟢 -11.5 kB
assets/main-CE4Gf20E.js (new) — 44.4 kB 🔴 +44.4 kB 🔴 +13.3 kB 🔴 +11.5 kB
assets/WidgetBoundingBoxes-2O-PnvBa.js (new) — 33.8 kB 🔴 +33.8 kB 🔴 +9.18 kB 🔴 +8.13 kB
assets/WidgetBoundingBoxes-C-Ss4Ed4.js (removed) 33.8 kB — 🟢 -33.8 kB 🟢 -9.17 kB 🟢 -8.12 kB
assets/WidgetPainter-BKfF-bn-.js (removed) 32.1 kB — 🟢 -32.1 kB 🟢 -7.89 kB 🟢 -6.98 kB
assets/WidgetPainter-Cmp6bw7g.js (new) — 32.1 kB 🔴 +32.1 kB 🔴 +7.89 kB 🔴 +6.99 kB
assets/Load3dViewerContent-ArPuUA-q.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.21 kB 🔴 +5.37 kB
assets/Load3dViewerContent-Bj8-rGHf.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.2 kB 🟢 -5.37 kB
assets/SubscriptionRequiredDialogContent-CRx5H6vU.js (new) — 27.1 kB 🔴 +27.1 kB 🔴 +6.4 kB 🔴 +5.63 kB
assets/SubscriptionRequiredDialogContent-DWbeKFJK.js (removed) 27.1 kB — 🟢 -27.1 kB 🟢 -6.4 kB 🟢 -5.64 kB
assets/SubscriptionRequiredDialogContentWorkspace-CfsLkEih.js (new) — 26.5 kB 🔴 +26.5 kB 🔴 +6.09 kB 🔴 +5.37 kB
assets/SubscriptionRequiredDialogContentWorkspace-f63t5dPU.js (removed) 26.5 kB — 🟢 -26.5 kB 🟢 -6.08 kB 🟢 -5.36 kB
assets/initHostTelemetry-1g-NR44b.js (removed) 25.8 kB — 🟢 -25.8 kB 🟢 -5.94 kB 🟢 -4.93 kB
assets/initHostTelemetry-ueeu4DWS.js (new) — 25.8 kB 🔴 +25.8 kB 🔴 +5.94 kB 🔴 +4.93 kB
assets/load3d-CMZbvAxH.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.42 kB 🟢 -4.69 kB
assets/load3d-DA2ucyEQ.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.42 kB 🔴 +4.68 kB
assets/SignInContent-BojLr-j0.js (new) — 20.7 kB 🔴 +20.7 kB 🔴 +5.24 kB 🔴 +4.57 kB
assets/SignInContent-D5h2mEPm.js (removed) 20.7 kB — 🟢 -20.7 kB 🟢 -5.23 kB 🟢 -4.56 kB
assets/CurrentUserPopoverWorkspace-0VbDzOef.js (new) — 18 kB 🔴 +18 kB 🔴 +4.17 kB 🔴 +3.68 kB
assets/CurrentUserPopoverWorkspace-DnFNPaPw.js (removed) 18 kB — 🟢 -18 kB 🟢 -4.17 kB 🟢 -3.69 kB
assets/WidgetRecordAudio-313qrOhQ.js (removed) 16.5 kB — 🟢 -16.5 kB 🟢 -4.59 kB 🟢 -4.09 kB
assets/WidgetRecordAudio-CtN_Cmxy.js (new) — 16.5 kB 🔴 +16.5 kB 🔴 +4.59 kB 🔴 +4.1 kB
assets/WidgetInputNumber-bjBhOFgU.js (removed) 13.9 kB — 🟢 -13.9 kB 🟢 -3.63 kB 🟢 -3.21 kB
assets/WidgetInputNumber-Cj-quYfQ.js (new) — 13.9 kB 🔴 +13.9 kB 🔴 +3.63 kB 🔴 +3.2 kB
assets/WidgetRange-BmvYQ88T.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.55 kB 🔴 +3.13 kB
assets/WidgetRange-C0BQqAG8.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.54 kB 🟢 -3.13 kB
assets/WaveAudioPlayer-BiRFVzfv.js (removed) 12.9 kB — 🟢 -12.9 kB 🟢 -3.49 kB 🟢 -3.05 kB
assets/WaveAudioPlayer-C6g44i_K.js (new) — 12.9 kB 🔴 +12.9 kB 🔴 +3.49 kB 🔴 +3.06 kB
assets/GlobalToast-BSRui7jS.js (removed) 12.2 kB — 🟢 -12.2 kB 🟢 -4.01 kB 🟢 -3.48 kB
assets/GlobalToast-kI5aqeel.js (new) — 12.2 kB 🔴 +12.2 kB 🔴 +4.01 kB 🔴 +3.49 kB
assets/WidgetCurve-CzlU-I_x.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.48 kB 🟢 -3.15 kB
assets/WidgetCurve-UqVr555n.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.48 kB 🔴 +3.15 kB
assets/TeamWorkspacesDialogContent-Bhp-qyOz.js (new) — 10.4 kB 🔴 +10.4 kB 🔴 +2.99 kB 🔴 +2.65 kB
assets/TeamWorkspacesDialogContent-CRsv2JOP.js (removed) 10.4 kB — 🟢 -10.4 kB 🟢 -2.99 kB 🟢 -2.65 kB
assets/types-C3eLKewM.js (new) — 9.77 kB 🔴 +9.77 kB 🔴 +3.15 kB 🔴 +2.56 kB
assets/types-DsD1IEsA.js (removed) 9.77 kB — 🟢 -9.77 kB 🟢 -3.15 kB 🟢 -2.55 kB
assets/onboardingCloudRoutes-cTiTQYdH.js (new) — 9.76 kB 🔴 +9.76 kB 🔴 +2.87 kB 🔴 +2.46 kB
assets/onboardingCloudRoutes-msvN0_sC.js (removed) 9.76 kB — 🟢 -9.76 kB 🟢 -2.87 kB 🟢 -2.45 kB
assets/InviteMemberDialogContent-ClisKP7e.js (removed) 9.65 kB — 🟢 -9.65 kB 🟢 -2.86 kB 🟢 -2.56 kB
assets/InviteMemberDialogContent-D3Xq2Zyw.js (new) — 9.65 kB 🔴 +9.65 kB 🔴 +2.86 kB 🔴 +2.56 kB
assets/Load3DConfiguration--r2Xdl1c.js (new) — 8.88 kB 🔴 +8.88 kB 🔴 +2.59 kB 🔴 +2.29 kB
assets/Load3DConfiguration-ChKLjaYS.js (removed) 8.88 kB — 🟢 -8.88 kB 🟢 -2.59 kB 🟢 -2.29 kB
assets/nodeTemplates-C7hULvzV.js (removed) 8.64 kB — 🟢 -8.64 kB 🟢 -2.97 kB 🟢 -2.61 kB
assets/nodeTemplates-DLvxHvG3.js (new) — 8.64 kB 🔴 +8.64 kB 🔴 +2.97 kB 🔴 +2.61 kB
assets/WidgetImageCrop-Cv-vBgBB.js (removed) 8.49 kB — 🟢 -8.49 kB 🟢 -2.66 kB 🟢 -2.34 kB
assets/WidgetImageCrop-WtGa7k8f.js (new) — 8.49 kB 🔴 +8.49 kB 🔴 +2.66 kB 🔴 +2.34 kB
assets/SetMemberCreditLimitDialogContent-CoXiICKh.js (removed) 8.47 kB — 🟢 -8.47 kB 🟢 -2.34 kB 🟢 -2.04 kB
assets/SetMemberCreditLimitDialogContent-YRsEmAg0.js (new) — 8.47 kB 🔴 +8.47 kB 🔴 +2.34 kB 🔴 +2.05 kB
assets/CloudRunButtonWrapper-CXN7oL5C.js (new) — 8.15 kB 🔴 +8.15 kB 🔴 +2.45 kB 🔴 +2.16 kB
assets/CloudRunButtonWrapper-Da1_SXx3.js (removed) 8.15 kB — 🟢 -8.15 kB 🟢 -2.45 kB 🟢 -2.15 kB
assets/WorkspaceSwitcherPopover-ByLb_M26.js (removed) 8.08 kB — 🟢 -8.08 kB 🟢 -2.39 kB 🟢 -2.13 kB
assets/WorkspaceSwitcherPopover-D9ht5tkB.js (new) — 8.08 kB 🔴 +8.08 kB 🔴 +2.39 kB 🔴 +2.13 kB
assets/NightlySurveyController-Cbv_s9Uj.js (new) — 7.5 kB 🔴 +7.5 kB 🔴 +2.56 kB 🔴 +2.25 kB
assets/NightlySurveyController-Dx0vI2nE.js (removed) 7.5 kB — 🟢 -7.5 kB 🟢 -2.56 kB 🟢 -2.26 kB
assets/LayoutDefault--C4YocBX.js (removed) 7.41 kB — 🟢 -7.41 kB 🟢 -2.44 kB 🟢 -2.14 kB
assets/LayoutDefault-CXqurJZD.js (new) — 7.41 kB 🔴 +7.41 kB 🔴 +2.44 kB 🔴 +2.15 kB
assets/missingModelMetadata-BWU4Muwv.js (removed) 6.52 kB — 🟢 -6.52 kB 🟢 -2.22 kB 🟢 -1.95 kB
assets/missingModelMetadata-D71GKEXE.js (new) — 6.52 kB 🔴 +6.52 kB 🔴 +2.22 kB 🔴 +1.94 kB
assets/WidgetWithControl-ClnmKEmk.js (removed) 6.46 kB — 🟢 -6.46 kB 🟢 -2.64 kB 🟢 -2.34 kB
assets/WidgetWithControl-Dt_hDwm4.js (new) — 6.46 kB 🔴 +6.46 kB 🔴 +2.64 kB 🔴 +2.34 kB
assets/CancelSubscriptionDialogContent-0hy9v7w0.js (removed) 6.05 kB — 🟢 -6.05 kB 🟢 -2.01 kB 🟢 -1.76 kB
assets/CancelSubscriptionDialogContent-BOWdPKn2.js (new) — 6.05 kB 🔴 +6.05 kB 🔴 +2.01 kB 🔴 +1.76 kB
assets/load3dPreviewExtensions-DimbQWMb.js (removed) 5.88 kB — 🟢 -5.88 kB 🟢 -1.81 kB 🟢 -1.6 kB
assets/load3dPreviewExtensions-Qsb67n_x.js (new) — 5.88 kB 🔴 +5.88 kB 🔴 +1.81 kB 🔴 +1.6 kB
assets/ApiNodesSignInContent-CtvUkd-N.js (new) — 5.68 kB 🔴 +5.68 kB 🔴 +2.02 kB 🔴 +1.8 kB
assets/ApiNodesSignInContent-DfpJokFF.js (removed) 5.68 kB — 🟢 -5.68 kB 🟢 -2.02 kB 🟢 -1.78 kB
assets/launchCancellationFlow-CNB5l3WA.js (removed) 5.18 kB — 🟢 -5.18 kB 🟢 -1.78 kB 🟢 -1.56 kB
assets/launchCancellationFlow-DGVUbNef.js (new) — 5.18 kB 🔴 +5.18 kB 🔴 +1.78 kB 🔴 +1.57 kB
assets/CreateWorkspaceDialogContent-BePe38hB.js (new) — 5.12 kB 🔴 +5.12 kB 🔴 +1.8 kB 🔴 +1.55 kB
assets/CreateWorkspaceDialogContent-rKWAqMbE.js (removed) 5.12 kB — 🟢 -5.12 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/ChangeMemberRoleDialogContent-CyptUlUp.js (removed) 4.97 kB — 🟢 -4.97 kB 🟢 -1.64 kB 🟢 -1.43 kB
assets/ChangeMemberRoleDialogContent-CZkEMIus.js (new) — 4.97 kB 🔴 +4.97 kB 🔴 +1.64 kB 🔴 +1.43 kB
assets/EditWorkspaceDialogContent-Bo47BGtY.js (new) — 4.93 kB 🔴 +4.93 kB 🔴 +1.76 kB 🔴 +1.53 kB
assets/EditWorkspaceDialogContent-BVTkMc_S.js (removed) 4.93 kB — 🟢 -4.93 kB 🟢 -1.76 kB 🟢 -1.53 kB
assets/WidgetTextarea-BebQ_H89.js (new) — 4.83 kB 🔴 +4.83 kB 🔴 +1.88 kB 🔴 +1.64 kB
assets/WidgetTextarea-s9NvoTxy.js (removed) 4.83 kB — 🟢 -4.83 kB 🟢 -1.88 kB 🟢 -1.64 kB
assets/saveMesh-BJQVHJXy.js (removed) 4.72 kB — 🟢 -4.72 kB 🟢 -1.5 kB 🟢 -1.32 kB
assets/saveMesh-yfz3Tprb.js (new) — 4.72 kB 🔴 +4.72 kB 🔴 +1.5 kB 🔴 +1.33 kB
assets/ValueControlPopover-Duwv2wcX.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.55 kB 🔴 +1.38 kB
assets/ValueControlPopover-u79w_lof.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.55 kB 🟢 -1.38 kB
assets/DeleteWorkspaceDialogContent-Cd6xZNHh.js (new) — 3.84 kB 🔴 +3.84 kB 🔴 +1.44 kB 🔴 +1.24 kB
assets/DeleteWorkspaceDialogContent-DmMlVd0o.js (removed) 3.84 kB — 🟢 -3.84 kB 🟢 -1.44 kB 🟢 -1.24 kB
assets/RemoveMemberDialogContent-BwbKt5yg.js (new) — 3.76 kB 🔴 +3.76 kB 🔴 +1.38 kB 🔴 +1.2 kB
assets/RemoveMemberDialogContent-CyiPWEiZ.js (removed) 3.76 kB — 🟢 -3.76 kB 🟢 -1.38 kB 🟢 -1.19 kB
assets/RevokeInviteDialogContent-CsuSeh1v.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.39 kB 🟢 -1.21 kB
assets/RevokeInviteDialogContent-V97CfQPL.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.39 kB 🔴 +1.21 kB
assets/LeaveWorkspaceDialogContent-CTUDnPul.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.38 kB 🟢 -1.19 kB
assets/LeaveWorkspaceDialogContent-D7zNtZVP.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/InviteMemberUpsellDialogContent-CdzBCcdu.js (removed) 3.47 kB — 🟢 -3.47 kB 🟢 -1.24 kB 🟢 -1.09 kB
assets/InviteMemberUpsellDialogContent-DeCVrkIl.js (new) — 3.47 kB 🔴 +3.47 kB 🔴 +1.24 kB 🔴 +1.06 kB
assets/SubscribeToRun-Bt__Jtqy.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -1.42 kB 🟢 -1.21 kB
assets/SubscribeToRun-DeYOfTlS.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +1.42 kB 🔴 +1.21 kB
assets/Media3DTop-CP1EpkeC.js (removed) 3.21 kB — 🟢 -3.21 kB 🟢 -1.27 kB 🟢 -1.1 kB
assets/Media3DTop-DdKL-pid.js (new) — 3.21 kB 🔴 +3.21 kB 🔴 +1.27 kB 🔴 +1.1 kB
assets/signInSchema-JVSO5I0P.js (new) — 2.85 kB 🔴 +2.85 kB 🔴 +1.02 kB 🔴 +863 B
assets/signInSchema-Ov1sxcaE.js (removed) 2.85 kB — 🟢 -2.85 kB 🟢 -1.01 kB 🟢 -858 B
assets/load3dAdvanced-CEHvHmnl.js (new) — 2.82 kB 🔴 +2.82 kB 🔴 +1.09 kB 🔴 +955 B
assets/load3dAdvanced-CtB-OzB8.js (removed) 2.82 kB — 🟢 -2.82 kB 🟢 -1.1 kB 🟢 -955 B
assets/LocalRunButtonWrapper-BV70TjkZ.js (new) — 2.49 kB 🔴 +2.49 kB 🔴 +1.14 kB 🔴 +996 B
assets/LocalRunButtonWrapper-CbO23Hti.js (removed) 2.49 kB — 🟢 -2.49 kB 🟢 -1.14 kB 🟢 -1.04 kB
assets/inviteLinks-Cio0q5xy.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +1.03 kB 🔴 +802 B
assets/inviteLinks-uGhVACZK.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -1.03 kB 🟢 -803 B
assets/webviewDetection-B2yqLssv.js (new) — 1.69 kB 🔴 +1.69 kB 🔴 +729 B 🔴 +597 B
assets/webviewDetection-_NOImfSy.js (removed) 1.69 kB — 🟢 -1.69 kB 🟢 -725 B 🟢 -596 B
assets/MediaAudioTop-CFZPGZwJ.js (new) — 1.62 kB 🔴 +1.62 kB 🔴 +809 B 🔴 +667 B
assets/MediaAudioTop-N79iz750.js (removed) 1.62 kB — 🟢 -1.62 kB 🟢 -808 B 🟢 -670 B
assets/paymentReturnUrl-B1MxPna7.js (removed) 1.58 kB — 🟢 -1.58 kB 🟢 -784 B 🟢 -620 B
assets/paymentReturnUrl-Fu3Omkyt.js (new) — 1.58 kB 🔴 +1.58 kB 🔴 +784 B 🔴 +631 B
assets/cameraInfo-CaZWFHJz.js (new) — 1.1 kB 🔴 +1.1 kB 🔴 +571 B 🔴 +492 B
assets/cameraInfo-DezTTYIN.js (removed) 1.1 kB — 🟢 -1.1 kB 🟢 -573 B 🟢 -492 B
assets/Load3DAdvanced-BPLWYdPP.js (new) — 761 B 🔴 +761 B 🔴 +423 B 🔴 +362 B
assets/Load3DAdvanced-BRyWCrZW.js (removed) 761 B — 🟢 -761 B 🟢 -422 B 🟢 -359 B
assets/nightlyBadges-BydJQ6JV.js (removed) 411 B — 🟢 -411 B 🟢 -271 B 🟢 -268 B
assets/nightlyBadges-DAXdpD0v.js (new) — 411 B 🔴 +411 B 🔴 +272 B 🔴 +231 B
assets/Load3dViewerContent-DwyzNHrW.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +95 B
assets/Load3dViewerContent-JEafVG2S.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -92 B
assets/missingModelMetadata-BJFJuwAu.js (new) — 125 B 🔴 +125 B 🔴 +103 B 🔴 +110 B
assets/missingModelMetadata-DftzT-fD.js (removed) 125 B — 🟢 -125 B 🟢 -103 B 🟢 -103 B
assets/Load3DAdvanced-B7_xQ_6A.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +87 B
assets/Load3DAdvanced-BGP_dYTN.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -88 B
assets/LayoutDefault-1WmUmn0u.js (removed) 119 B — 🟢 -119 B 🟢 -92 B 🟢 -82 B
assets/LayoutDefault-zkPOUHiK.js (new) — 119 B 🔴 +119 B 🔴 +92 B 🔴 +85 B
assets/WidgetLegacy-BT96OjCr.js (removed) 117 B — 🟢 -117 B 🟢 -106 B 🟢 -102 B
assets/WidgetLegacy-D5Ej9M-H.js (new) — 117 B 🔴 +117 B 🔴 +106 B 🔴 +102 B
assets/workflowDraftStoreV2-CTh7XmN8.js (removed) 112 B — 🟢 -112 B 🟢 -101 B 🟢 -115 B
assets/workflowDraftStoreV2-DyI9e-iP.js (new) — 112 B 🔴 +112 B 🔴 +101 B 🔴 +109 B
assets/CameraInfo-BAMKHUjn.js (removed) 110 B — 🟢 -110 B 🟢 -93 B 🟢 -92 B
assets/CameraInfo-CvqI1mmS.js (new) — 110 B 🔴 +110 B 🔴 +93 B 🔴 +92 B
assets/Load3D-B3vFgtPs.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -77 B
assets/Load3D-BXldm3bT.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +83 B
assets/changeTracker-CTT0VFAl.js (new) — 92 B 🔴 +92 B 🔴 +94 B 🔴 +88 B
assets/changeTracker-CwmI30c9.js (removed) 92 B — 🟢 -92 B 🟢 -94 B 🟢 -86 B

Status: 77 added / 77 removed / 220 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 134ms TBT · 98.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 157.4 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 15ms TBT · 171.2 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 176ms TBT · 166.5 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 180.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap

⚠️ 5 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-mouse-sweep: p95 frame time 17ms 17ms +1% ⚠️ z=2.6
large-graph-idle: style recalc duration 7ms 8ms +27% ⚠️ z=2.9
subgraph-idle: p95 frame time 17ms 17ms +1% ⚠️ z=2.2
subgraph-idle: heap used 67.7 MB 73.7 MB +9% ⚠️ z=2.9
vue-node-resize-workload: layout duration 24ms 31ms +28% ⚠️ z=2.0
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.9
canvas-idle: p95 frame time 17ms 17ms -1% z=-1.4
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 7ms 7ms -6% z=-0.4
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 9 -6% z=-0.2
canvas-idle: task duration 439ms 442ms +1% z=0.6
canvas-idle: script duration 11ms 10ms -9% z=1.2
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 71.0 MB 65.2 MB -8% z=-0.2
canvas-idle: DOM nodes -259 -262 +1% z=-0.9
canvas-idle: event listeners -156 -155 -1% z=-1.0
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.7
canvas-mouse-sweep: p95 frame time 17ms 17ms +1% ⚠️ z=2.6
canvas-mouse-sweep: layout duration 4ms 5ms +5% z=0.7
canvas-mouse-sweep: style recalc duration 26ms 27ms +3% z=-0.4
canvas-mouse-sweep: layout count 14 14 +0% —
canvas-mouse-sweep: style recalc count 73 75 +2% z=-0.3
canvas-mouse-sweep: task duration 779ms 777ms -0% z=-0.4
canvas-mouse-sweep: script duration 135ms 147ms +9% z=-0.4
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 56.6 MB 63.3 MB +12% z=-0.3
canvas-mouse-sweep: DOM nodes -261 -263 +1% z=-0.3
canvas-mouse-sweep: event listeners -186 -170 -9% z=-0.5
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-1.9
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% z=-1.5
canvas-zoom-sweep: layout duration 1ms 1ms +6% z=0.2
canvas-zoom-sweep: style recalc duration 15ms 15ms -4% z=-0.5
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 30 -3% z=-1.7
canvas-zoom-sweep: task duration 325ms 337ms +4% z=0.4
canvas-zoom-sweep: script duration 13ms 12ms -5% z=1.1
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 61.7 MB 61.5 MB -0% z=-0.7
canvas-zoom-sweep: DOM nodes 76 75 -1% z=-1.3
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.4
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.2
dom-widget-clipping: p95 frame time 17ms 17ms +0% z=-1.5
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 7ms 7ms +4% z=0.0
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 12 +5% z=1.4
dom-widget-clipping: task duration 402ms 416ms +3% z=0.0
dom-widget-clipping: script duration 139ms 147ms +5% z=-0.4
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 76.3 MB 76.4 MB +0% z=0.1
dom-widget-clipping: DOM nodes 18 19 +6% z=1.5
dom-widget-clipping: event listeners 0 2 — z=0.4
large-graph-idle: avg frame time 17ms 17ms +0% z=-1.8
large-graph-idle: p95 frame time 17ms 17ms +0% z=0.0
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 7ms 8ms +27% ⚠️ z=2.9
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 8 7 -13% z=0.5
large-graph-idle: task duration 539ms 594ms +10% z=0.8
large-graph-idle: script duration 33ms 36ms +8% z=0.9
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 73.0 MB 74.8 MB +3% z=-1.4
large-graph-idle: DOM nodes -253 -254 +0% z=-0.3
large-graph-idle: event listeners -180 -182 +1% z=-1.0
large-graph-pan: avg frame time 17ms 17ms +0% z=0.5
large-graph-pan: p95 frame time 17ms 17ms +0% z=0.2
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 14ms 13ms -8% z=0.6
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 66 -3% z=-0.4
large-graph-pan: task duration 1487ms 1524ms +3% z=-0.2
large-graph-pan: script duration 695ms 753ms +8% z=-0.4
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 62.6 MB 76.3 MB +22% z=1.0
large-graph-pan: DOM nodes -256 -249 -3% z=-0.8
large-graph-pan: event listeners -180 -73 -59% z=1.3
large-graph-zoom: avg frame time 17ms 17ms +0% z=1.6
large-graph-zoom: p95 frame time 17ms 17ms +0% z=-0.1
large-graph-zoom: layout duration 13ms 15ms +11% z=1.3
large-graph-zoom: style recalc duration 12ms 15ms +18% z=1.8
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 62 63 +2% z=1.0
large-graph-zoom: task duration 1521ms 1576ms +4% z=-0.3
large-graph-zoom: script duration 672ms 714ms +6% z=-0.5
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 71.6 MB 68.3 MB -5% z=-1.0
large-graph-zoom: DOM nodes -256 -253 -1% z=-1.9
large-graph-zoom: event listeners -178 -86 -52% z=-0.4
legacy-node-drag: avg frame time 17ms 17ms -0% z=-0.7
legacy-node-drag: p95 frame time 17ms 17ms -0% z=-1.6
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 8ms 7ms -9% z=0.4
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 44 42 -5% z=-0.2
legacy-node-drag: task duration 1742ms 1850ms +6% z=0.1
legacy-node-drag: script duration 864ms 904ms +5% z=-0.3
legacy-node-drag: TBT 0ms 0ms +0% variance too high
legacy-node-drag: heap used 68.2 MB 80.4 MB +18% z=0.5
legacy-node-drag: DOM nodes 4 -128 -3288% z=-1.1
legacy-node-drag: event listeners 186 95 -49% z=-0.7
minimap-idle: avg frame time 17ms 17ms -0% z=-1.1
minimap-idle: p95 frame time 17ms 17ms +0% z=-1.9
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 7ms 4ms -43% z=-0.8
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 7 4 -43% z=-1.3
minimap-idle: task duration 603ms 520ms -14% z=-0.3
minimap-idle: script duration 33ms 34ms +2% z=0.2
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 73.3 MB 80.1 MB +9% z=1.5
minimap-idle: DOM nodes -258 -251 -3% z=-0.3
minimap-idle: event listeners -180 -153 -15% z=0.2
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.8
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -1% z=-1.5
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 10ms -13% z=-1.1
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 47 -3% z=-0.5
subgraph-dom-widget-clipping: task duration 355ms 372ms +5% z=-0.2
subgraph-dom-widget-clipping: script duration 121ms 130ms +8% z=-0.4
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 73.5 MB 73.8 MB +0% z=0.1
subgraph-dom-widget-clipping: DOM nodes 22 19 -14% z=-0.5
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=1.2
subgraph-idle: avg frame time 17ms 17ms +0% z=-2.1
subgraph-idle: p95 frame time 17ms 17ms +1% ⚠️ z=2.2
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 8ms 8ms -0% z=-0.9
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 10 +0% z=0.3
subgraph-idle: task duration 464ms 454ms -2% z=0.3
subgraph-idle: script duration 10ms 10ms -6% z=1.7
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 67.7 MB 73.7 MB +9% ⚠️ z=2.9
subgraph-idle: DOM nodes -274 -274 +0% z=-0.3
subgraph-idle: event listeners -202 -201 -0% z=0.1
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.6
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% z=0.1
subgraph-mouse-sweep: layout duration 5ms 6ms +15% z=1.4
subgraph-mouse-sweep: style recalc duration 25ms 27ms +8% z=0.5
subgraph-mouse-sweep: layout count 18 18 +0% —
subgraph-mouse-sweep: style recalc count 77 78 +1% z=-0.0
subgraph-mouse-sweep: task duration 709ms 785ms +11% z=0.7
subgraph-mouse-sweep: script duration 95ms 102ms +7% z=-0.1
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 56.2 MB 68.7 MB +22% z=1.5
subgraph-mouse-sweep: DOM nodes -273 -274 +0% z=0.7
subgraph-mouse-sweep: event listeners -230 -201 -13% z=1.9
subgraph-transition-enter: avg frame time 17ms 17ms -0% z=-1.2
subgraph-transition-enter: p95 frame time 17ms 17ms +0% z=-0.6
subgraph-transition-enter: layout duration 10ms 10ms -0% z=-1.3
subgraph-transition-enter: style recalc duration 25ms 25ms +3% z=-0.7
subgraph-transition-enter: layout count 5 5 +0% —
subgraph-transition-enter: style recalc count 18 18 +0% z=0.8
subgraph-transition-enter: task duration 818ms 837ms +2% z=0.0
subgraph-transition-enter: script duration 36ms 29ms -19% z=0.0
subgraph-transition-enter: TBT 93ms 134ms +44% z=0.4
subgraph-transition-enter: heap used 93.3 MB 98.6 MB +6% z=1.1
subgraph-transition-enter: DOM nodes 13587 13587 +0% —
subgraph-transition-enter: event listeners 2385 2387 +0% z=0.9
viewport-pan-sweep: avg frame time 17ms 17ms +0% z=0.8
viewport-pan-sweep: p95 frame time 17ms 17ms -0% z=0.3
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 39ms 41ms +5% z=1.2
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 249 -0% z=0.4
viewport-pan-sweep: task duration 5118ms 5322ms +4% z=-0.3
viewport-pan-sweep: script duration 2319ms 2464ms +6% z=-0.6
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 71.9 MB 77.1 MB +7% z=1.2
viewport-pan-sweep: DOM nodes -242 -240 -1% z=0.8
viewport-pan-sweep: event listeners -136 -165 +21% z=-1.4
vue-large-graph-idle: avg frame time 18ms 17ms -3% z=-1.7
vue-large-graph-idle: p95 frame time 17ms 17ms +0% z=1.1
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 14497ms 12068ms -17% z=-2.2
vue-large-graph-idle: script duration 220ms 212ms -4% z=-1.2
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 179.0 MB 157.4 MB -12% z=-4.0
vue-large-graph-idle: DOM nodes -8061 -8063 +0% z=-10.3
vue-large-graph-idle: event listeners -14928 -14928 +0% z=-1.3
vue-large-graph-pan: avg frame time 18ms 17ms -3% z=-1.6
vue-large-graph-pan: p95 frame time 17ms 17ms -0% z=-0.3
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 16ms 18ms +10% z=0.3
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 121 128 +5% z=-0.5
vue-large-graph-pan: task duration 17364ms 17023ms -2% z=-0.8
vue-large-graph-pan: script duration 727ms 807ms +11% z=-0.4
vue-large-graph-pan: TBT 24ms 15ms -40% variance too high
vue-large-graph-pan: heap used 159.2 MB 171.2 MB +8% z=0.6
vue-large-graph-pan: DOM nodes -8061 -8061 +0% z=0.6
vue-large-graph-pan: event listeners -14924 -14922 -0% z=0.0
vue-node-resize-workload: avg frame time 18ms 18ms -2% z=-0.8
vue-node-resize-workload: p95 frame time 17ms 17ms -0% z=0.9
vue-node-resize-workload: layout duration 24ms 31ms +28% ⚠️ z=2.0
vue-node-resize-workload: style recalc duration 64ms 74ms +15% z=-0.1
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 5412ms 5086ms -6% z=-1.1
vue-node-resize-workload: script duration 93ms 99ms +6% z=-0.4
vue-node-resize-workload: TBT 307ms 176ms -43% z=-1.3
vue-node-resize-workload: heap used 164.9 MB 166.5 MB +1% z=-0.9
vue-node-resize-workload: DOM nodes -8061 -8061 +0% z=0.4
vue-node-resize-workload: event listeners -14924 -14926 +0% z=-2.5
vue-zoom-out-idle: avg frame time 17ms 17ms -0% z=-1.8
vue-zoom-out-idle: p95 frame time 17ms 17ms +0% z=1.7
vue-zoom-out-idle: layout duration 0ms 0ms +0% —
vue-zoom-out-idle: style recalc duration 0ms 0ms +0% —
vue-zoom-out-idle: layout count 0 0 +0% —
vue-zoom-out-idle: style recalc count 0 0 +0% —
vue-zoom-out-idle: task duration 7385ms 6850ms -7% z=-1.2
vue-zoom-out-idle: script duration 115ms 114ms -1% z=-0.8
vue-zoom-out-idle: TBT 0ms 0ms +0% —
vue-zoom-out-idle: heap used 162.8 MB 180.8 MB +11% z=1.0
vue-zoom-out-idle: DOM nodes 0 -2499 — z=-5.6
vue-zoom-out-idle: event listeners -12 -10 -17% z=1.2
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms +0% z=1.6
workflow-execution: layout duration 2ms 1ms -28% z=-1.4
workflow-execution: style recalc duration 20ms 17ms -15% z=-0.6
workflow-execution: layout count 4 3 -38% z=-2.1
workflow-execution: style recalc count 14 11 -25% z=-0.4
workflow-execution: task duration 104ms 92ms -11% z=-0.3
workflow-execution: script duration 9ms 9ms +4% z=0.1
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 63.8 MB 63.1 MB -1% z=0.1
workflow-execution: DOM nodes 125 124 -1% z=-0.6
workflow-execution: event listeners 81 41 -49% z=-0.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: p95 frame time 17ms 0ms 0.2%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 7ms 1ms 8.5%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 9 1 7.7%
canvas-idle: task duration 416ms 45ms 10.9%
canvas-idle: script duration 9ms 1ms 13.9%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: heap used 65.7 MB 3.3 MB 4.9%
canvas-idle: DOM nodes -206 59 0.0%
canvas-idle: event listeners -124 33 0.0%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: p95 frame time 17ms 0ms 0.2%
canvas-mouse-sweep: layout duration 4ms 0ms 6.8%
canvas-mouse-sweep: style recalc duration 28ms 4ms 12.6%
canvas-mouse-sweep: layout count 14 0 0.0%
canvas-mouse-sweep: style recalc count 75 2 2.5%
canvas-mouse-sweep: task duration 816ms 96ms 11.8%
canvas-mouse-sweep: script duration 155ms 19ms 12.1%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: heap used 64.2 MB 3.5 MB 5.4%
canvas-mouse-sweep: DOM nodes -255 26 0.0%
canvas-mouse-sweep: event listeners -163 14 0.0%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: p95 frame time 17ms 0ms 0.2%
canvas-zoom-sweep: layout duration 1ms 0ms 7.2%
canvas-zoom-sweep: style recalc duration 15ms 2ms 10.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 1 2.3%
canvas-zoom-sweep: task duration 324ms 35ms 10.8%
canvas-zoom-sweep: script duration 11ms 1ms 9.0%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: heap used 61.6 MB 126.5 KB 0.2%
canvas-zoom-sweep: DOM nodes 76 1 0.7%
canvas-zoom-sweep: event listeners 19 1 3.1%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: p95 frame time 17ms 0ms 0.1%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 7ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 11 0 3.9%
dom-widget-clipping: task duration 415ms 46ms 11.2%
dom-widget-clipping: script duration 154ms 19ms 12.4%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: heap used 76.4 MB 330.7 KB 0.4%
dom-widget-clipping: DOM nodes 18 1 4.6%
dom-widget-clipping: event listeners 2 0 21.7%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: p95 frame time 17ms 0ms 0.2%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 6ms 1ms 14.8%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 6 1 19.9%
large-graph-idle: task duration 546ms 62ms 11.4%
large-graph-idle: script duration 33ms 3ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: heap used 76.7 MB 1.4 MB 1.8%
large-graph-idle: DOM nodes -246 23 0.0%
large-graph-idle: event listeners -159 23 0.0%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: p95 frame time 17ms 0ms 0.2%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 12ms 2ms 12.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 67 1 1.8%
large-graph-pan: task duration 1548ms 148ms 9.5%
large-graph-pan: script duration 792ms 90ms 11.3%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: heap used 72.6 MB 3.7 MB 5.0%
large-graph-pan: DOM nodes -209 53 0.0%
large-graph-pan: event listeners -133 46 0.0%
large-graph-zoom: avg frame time 17ms 0ms 0.0%
large-graph-zoom: p95 frame time 17ms 0ms 0.2%
large-graph-zoom: layout duration 13ms 1ms 8.9%
large-graph-zoom: style recalc duration 12ms 1ms 12.5%
large-graph-zoom: layout count 60 0 0.0%
large-graph-zoom: style recalc count 62 1 1.9%
large-graph-zoom: task duration 1620ms 171ms 10.6%
large-graph-zoom: script duration 757ms 86ms 11.3%
large-graph-zoom: TBT 0ms 0ms 0.0%
large-graph-zoom: heap used 70.6 MB 2.3 MB 3.3%
large-graph-zoom: DOM nodes -107 78 0.0%
large-graph-zoom: event listeners -66 55 0.0%
legacy-node-drag: avg frame time 17ms 0ms 0.0%
legacy-node-drag: p95 frame time 17ms 0ms 0.2%
legacy-node-drag: layout duration 0ms 0ms 0.0%
legacy-node-drag: style recalc duration 7ms 1ms 17.9%
legacy-node-drag: layout count 0 0 0.0%
legacy-node-drag: style recalc count 42 2 3.6%
legacy-node-drag: task duration 1828ms 186ms 10.2%
legacy-node-drag: script duration 932ms 106ms 11.3%
legacy-node-drag: TBT 0ms 1ms 296.1%
legacy-node-drag: heap used 78.8 MB 3.6 MB 4.5%
legacy-node-drag: DOM nodes -64 58 0.0%
legacy-node-drag: event listeners 138 59 42.5%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: p95 frame time 17ms 0ms 0.2%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 5ms 2ms 31.1%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 6 1 23.1%
minimap-idle: task duration 543ms 78ms 14.4%
minimap-idle: script duration 33ms 3ms 9.9%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: heap used 77.6 MB 1.7 MB 2.1%
minimap-idle: DOM nodes -242 31 0.0%
minimap-idle: event listeners -158 26 0.0%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 10ms 1ms 6.6%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 47 1 1.3%
subgraph-dom-widget-clipping: task duration 381ms 38ms 9.9%
subgraph-dom-widget-clipping: script duration 135ms 14ms 10.6%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: heap used 73.7 MB 572.0 KB 0.8%
subgraph-dom-widget-clipping: DOM nodes 20 1 6.0%
subgraph-dom-widget-clipping: event listeners 7 1 7.2%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: p95 frame time 17ms 0ms 0.2%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 8ms 1ms 7.3%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 10 1 5.1%
subgraph-idle: task duration 436ms 54ms 12.5%
subgraph-idle: script duration 8ms 1ms 12.6%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: heap used 62.9 MB 3.7 MB 5.9%
subgraph-idle: DOM nodes -262 34 0.0%
subgraph-idle: event listeners -202 26 0.0%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: p95 frame time 17ms 0ms 0.2%
subgraph-mouse-sweep: layout duration 5ms 0ms 8.7%
subgraph-mouse-sweep: style recalc duration 26ms 2ms 7.6%
subgraph-mouse-sweep: layout count 18 0 0.0%
subgraph-mouse-sweep: style recalc count 78 0 0.5%
subgraph-mouse-sweep: task duration 733ms 73ms 9.9%
subgraph-mouse-sweep: script duration 103ms 9ms 9.1%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: heap used 62.4 MB 4.2 MB 6.8%
subgraph-mouse-sweep: DOM nodes -275 1 0.0%
subgraph-mouse-sweep: event listeners -216 8 0.0%
subgraph-transition-enter: avg frame time 17ms 0ms 0.0%
subgraph-transition-enter: p95 frame time 17ms 0ms 0.3%
subgraph-transition-enter: layout duration 12ms 2ms 12.5%
subgraph-transition-enter: style recalc duration 27ms 3ms 11.2%
subgraph-transition-enter: layout count 5 0 0.0%
subgraph-transition-enter: style recalc count 17 1 4.7%
subgraph-transition-enter: task duration 835ms 99ms 11.8%
subgraph-transition-enter: script duration 29ms 4ms 14.2%
subgraph-transition-enter: TBT 124ms 23ms 18.9%
subgraph-transition-enter: heap used 87.5 MB 9.8 MB 11.2%
subgraph-transition-enter: DOM nodes 13587 0 0.0%
subgraph-transition-enter: event listeners 2386 1 0.0%
viewport-pan-sweep: avg frame time 17ms 0ms 0.0%
viewport-pan-sweep: p95 frame time 17ms 0ms 0.2%
viewport-pan-sweep: layout duration 0ms 0ms 0.0%
viewport-pan-sweep: style recalc duration 37ms 3ms 8.9%
viewport-pan-sweep: layout count 0 0 0.0%
viewport-pan-sweep: style recalc count 248 1 0.4%
viewport-pan-sweep: task duration 5505ms 543ms 9.9%
viewport-pan-sweep: script duration 2644ms 284ms 10.7%
viewport-pan-sweep: TBT 0ms 0ms 0.0%
viewport-pan-sweep: heap used 71.9 MB 4.4 MB 6.1%
viewport-pan-sweep: DOM nodes -245 7 0.0%
viewport-pan-sweep: event listeners -150 11 0.0%
vue-large-graph-idle: avg frame time 18ms 0ms 1.3%
vue-large-graph-idle: p95 frame time 17ms 0ms 0.2%
vue-large-graph-idle: layout duration 0ms 0ms 0.0%
vue-large-graph-idle: style recalc duration 0ms 0ms 0.0%
vue-large-graph-idle: layout count 0 0 0.0%
vue-large-graph-idle: style recalc count 0 0 0.0%
vue-large-graph-idle: task duration 15639ms 1616ms 10.3%
vue-large-graph-idle: script duration 260ms 39ms 14.9%
vue-large-graph-idle: TBT 0ms 0ms 0.0%
vue-large-graph-idle: heap used 172.8 MB 3.9 MB 2.2%
vue-large-graph-idle: DOM nodes -8061 0 0.0%
vue-large-graph-idle: event listeners -14926 1 0.0%
vue-large-graph-pan: avg frame time 18ms 0ms 1.5%
vue-large-graph-pan: p95 frame time 17ms 1ms 8.3%
vue-large-graph-pan: layout duration 0ms 0ms 0.0%
vue-large-graph-pan: style recalc duration 17ms 3ms 17.3%
vue-large-graph-pan: layout count 0 0 0.0%
vue-large-graph-pan: style recalc count 142 29 20.4%
vue-large-graph-pan: task duration 19059ms 2518ms 13.2%
vue-large-graph-pan: script duration 844ms 95ms 11.2%
vue-large-graph-pan: TBT 80ms 59ms 74.1%
vue-large-graph-pan: heap used 168.3 MB 5.1 MB 3.0%
vue-large-graph-pan: DOM nodes -8061 0 0.0%
vue-large-graph-pan: event listeners -14922 2 0.0%
vue-node-resize-workload: avg frame time 18ms 0ms 1.5%
vue-node-resize-workload: p95 frame time 17ms 0ms 0.1%
vue-node-resize-workload: layout duration 25ms 3ms 12.0%
vue-node-resize-workload: style recalc duration 75ms 11ms 14.1%
vue-node-resize-workload: layout count 20 0 0.0%
vue-node-resize-workload: style recalc count 20 0 0.0%
vue-node-resize-workload: task duration 5702ms 575ms 10.1%
vue-node-resize-workload: script duration 106ms 17ms 15.7%
vue-node-resize-workload: TBT 333ms 120ms 36.1%
vue-node-resize-workload: heap used 171.6 MB 5.8 MB 3.4%
vue-node-resize-workload: DOM nodes -8062 3 0.0%
vue-node-resize-workload: event listeners -14923 1 0.0%
vue-zoom-out-idle: avg frame time 18ms 0ms 1.2%
vue-zoom-out-idle: p95 frame time 17ms 0ms 0.1%
vue-zoom-out-idle: layout duration 0ms 0ms 0.0%
vue-zoom-out-idle: style recalc duration 0ms 0ms 0.0%
vue-zoom-out-idle: layout count 0 0 0.0%
vue-zoom-out-idle: style recalc count 0 0 0.0%
vue-zoom-out-idle: task duration 7804ms 810ms 10.4%
vue-zoom-out-idle: script duration 131ms 22ms 16.7%
vue-zoom-out-idle: TBT 0ms 0ms 0.0%
vue-zoom-out-idle: heap used 173.7 MB 7.1 MB 4.1%
vue-zoom-out-idle: DOM nodes -111 430 0.0%
vue-zoom-out-idle: event listeners -12 1 0.0%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: p95 frame time 17ms 0ms 0.2%
workflow-execution: layout duration 2ms 0ms 14.5%
workflow-execution: style recalc duration 19ms 3ms 15.5%
workflow-execution: layout count 3 0 12.4%
workflow-execution: style recalc count 12 4 29.7%
workflow-execution: task duration 96ms 16ms 16.2%
workflow-execution: script duration 9ms 2ms 16.6%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: heap used 63.0 MB 622.1 KB 1.0%
workflow-execution: DOM nodes 130 10 7.5%
workflow-execution: event listeners 51 17 33.9%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▁▆▁▃▆▆▆▁█▃▆▃▃▆▃ ➡️ 17ms
canvas-idle: p95 frame time ▆▃▁▃▆▃▆▆▃█▁█▃▁▆ ➡️ 17ms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▁▄▅▇█▄▇▃▄▆▄▅▃▄▅ ➡️ 7ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count ▅▂█▄▅▃▁▃▂▃▃▄▇▂▆ ➡️ 9
canvas-idle: task duration ▂▆▁▇▆▃▅▄█▆██▁▄▅ ➡️ 423ms
canvas-idle: script duration ▁▄▃▅▄▃█▁▁▂▅▂▂▂▇ ➡️ 11ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ▃▂▄▁▃▅▂▁▃▃▆▇▅▄█ ➡️ 72.6 MB
canvas-idle: DOM nodes ▅▁▁▁▁█▅▅▁▅▅▅▁▁▅ ➡️ -167
canvas-idle: event listeners ▄▁▁▁▁█▄▄▁▅▅▄▁▁▄ ➡️ -103
canvas-mouse-sweep: avg frame time ▆▆▄▁▆▆▃▃█▆▄▆▆▄▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ▁▃▃▁▃▃▁▃▆▃▃▃█▃▁ ➡️ 17ms
canvas-mouse-sweep: layout duration ▁▅▇▇▅▅▅▁▁▃█▅▂▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▁▆▃█▆▅▅▃▄▆█▆▂▄▄ ➡️ 27ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 14
canvas-mouse-sweep: style recalc count ▁▃▁▆█▅▆▄▄▃▇█▁▄▁ ➡️ 73
canvas-mouse-sweep: task duration ▂▇▁█▇▇▇▆▆▆█▆▂▅▄ ➡️ 767ms
canvas-mouse-sweep: script duration ▂▆▁█▇▇█▇▇███▂▇▃ ➡️ 135ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ▄▇█▃▂▆▂▃▆▂▅▆▁▁▃ ➡️ 62.2 MB
canvas-mouse-sweep: DOM nodes ▁▁▁▁▁█▁▁▁▁▁▁▁▁▁ ➡️ -262
canvas-mouse-sweep: event listeners ▃▂▄▄▂█▂▁▄▁▂▄▂▁▁ ➡️ -175
canvas-zoom-sweep: avg frame time ▆▃▆▆▆▆▆▃▆▆▁▆█▆▆ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ▁▃█▆▃▆▃▆▃██▁▆▃▃ ➡️ 17ms
canvas-zoom-sweep: layout duration ▁▅▄█▅▅▇▄▄▅▆▄▃▄▄ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▁▄▂▇▆▅█▃▅▇▆▄▂▇▄ ➡️ 15ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▃▅▂▄▅▁▄▁▅█▃▁▂▄▄ ➡️ 31
canvas-zoom-sweep: task duration ▂▆▁▇▇▆█▅▆▆▅▆▃▆▆ ➡️ 327ms
canvas-zoom-sweep: script duration ▂▄▅▇▅▅▇▁▃▄▅▄▃▄█ ➡️ 13ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ▄▁▄▅▆█▇▃▁▆▅█▆▇▇ ➡️ 61.7 MB
canvas-zoom-sweep: DOM nodes █▇▇▇▄▂▇▂▇█▁▄▄▇▇ ➡️ 76
canvas-zoom-sweep: event listeners ▆▁▁▁▁▁▁▁▁▁▁▁█▁▁ ➡️ 19
dom-widget-clipping: avg frame time █▁▅▁▅█▅▁▅█▁▁▁█▅ ➡️ 17ms
dom-widget-clipping: p95 frame time ▅█▁▄█▅██▁▁▅█▄▄▅ ➡️ 17ms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▂▅▁▄█▃▅▄▄▄▃▅▁▆▃ ➡️ 7ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▆▆▆▃█▃▃▅▁▃▁▁▆▅▅ ➡️ 11
dom-widget-clipping: task duration ▄▇▁████▇▇█▇▆▃▇▅ ➡️ 398ms
dom-widget-clipping: script duration ▃▇▁▇█▇█▇▇█▇█▄█▅ ➡️ 139ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ▅▇▅▅▆▇█▇▇▃▇▃▆▃▁ ➡️ 75.7 MB
dom-widget-clipping: DOM nodes ▆▆▅▃█▃▃▅▁▃▁▁▅▅▅ ➡️ 18
dom-widget-clipping: event listeners █▄▄███████████▁ ➡️ 1
large-graph-idle: avg frame time ▆▃▆▃▁▁██▁▁██▆▁▁ ➡️ 17ms
large-graph-idle: p95 frame time █▃▃▁█▃▁█▆▆▃▁▆▆▃ ➡️ 17ms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▄▁▅▄▃▄▃▃█▅▃▂▄▅▆ ➡️ 7ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count ▇▂█▄▄▃▃▃▆▄▄▁▆▅▆ ➡️ 8
large-graph-idle: task duration ▃▆▁█▇▇▅▆▇▆▇▅▃▅▆ ➡️ 554ms
large-graph-idle: script duration ▃▅▁█▅█▅▃▄▇▇▅▂▆▅ ➡️ 33ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ▅█▄▄▆▆▇█▆▆▅▇▆▁▂ ➡️ 74.7 MB
large-graph-idle: DOM nodes ▂█▂▁▁▁▁▂▂▁▁▁▂▁▂ ➡️ -251
large-graph-idle: event listeners ▃▇▂▂▂▃█▃▂▇▂▃▃▁▂ ➡️ -172
large-graph-pan: avg frame time ▃▃▃▃▆█▃▆█▁▃▆▆▆▆ ➡️ 17ms
large-graph-pan: p95 frame time ▁▁▆▁▃▆▃█▆▃█▁▆▆▁ ➡️ 17ms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▄█▆▄▅▅▅▄▁▇▃▅▃▇ ➡️ 14ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▅▅█▄▃▅▆▆▆▁▆▄█▅█ ➡️ 68
large-graph-pan: task duration ▂▆▁█▇▇█▇▇▇▇▆▂▇▄ ➡️ 1465ms
large-graph-pan: script duration ▂▆▁▇▇▆▇█▇▇▆▇▂▆▃ ➡️ 707ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ▅▄▃▆▆▅▄▃▆██▇▂▃▁ ➡️ 65.8 MB
large-graph-pan: DOM nodes █▂▁▅▅▂▁▂▂▅▂▅▂▅▂ ➡️ -244
large-graph-pan: event listeners █▅▂▄▅▂▁▁▂█▁▅▄▅▁ ➡️ -180
large-graph-zoom: avg frame time ▅▁█▁▅▆▅▁▅▁▃▅▅▁▄ ➡️ 17ms
large-graph-zoom: p95 frame time ▃▆▃█▃▆▆▁▆▃▃██▆▁ ➡️ 17ms
large-graph-zoom: layout duration ▂▅██▄▇▃▁▁▃█▂▁▂▃ ➡️ 13ms
large-graph-zoom: style recalc duration ▅▅█▆▅▅▅▁▂▃▇▃▅▂▅ ➡️ 12ms
large-graph-zoom: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 60
large-graph-zoom: style recalc count ▇▄█▂▄▃▅▁▂▂▄▂▇▂▅ ➡️ 62
large-graph-zoom: task duration ▂▆▁█▇▇▇▆▆▇█▅▂▆▅ ➡️ 1559ms
large-graph-zoom: script duration ▃▇▁██▇▇▇▇▇▇▇▃▆▄ ➡️ 691ms
large-graph-zoom: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-zoom: heap used ▃▃▂▂▃▁▁▃▄█▂▄▁▃▂ ➡️ 70.0 MB
large-graph-zoom: DOM nodes ▆▃▆▆▃▆▄█▆█▁▄▆█▄ ➡️ -169
large-graph-zoom: event listeners ▆▃▆▆▃▆▃█▆█▁▆▆█▃ 📉 -117
legacy-node-drag: avg frame time ▄▆█▁▆▃▆▅▄▆▆▃▄▄▄ ➡️ 17ms
legacy-node-drag: p95 frame time █▆▃▁▃▆▃▃▁▃▆▆▃▆▃ ➡️ 17ms
legacy-node-drag: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: style recalc duration ▄▄█▁▁▃▂▂▁▂▅▂▅▂▅ ➡️ 8ms
legacy-node-drag: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: style recalc count ▆▄█▁▂▃▃▃▃▂▅▃▆▃▆ ➡️ 44
legacy-node-drag: task duration ▃▇▁██▇█▆▆██▇▃▇▅ ➡️ 1739ms
legacy-node-drag: script duration ▃█▁████▇▇██▇▃▇▄ ➡️ 847ms
legacy-node-drag: TBT ▁▁▁▁▁█▁▁▄▁▁▁▁▁▁ 📉 0ms
legacy-node-drag: heap used ▂▅▆██▄▇▃▁▆▅▆▆▅▄ ➡️ 77.5 MB
legacy-node-drag: DOM nodes █▅▅███▄▁█▄▁▄▅▄▅ 📈 -70
legacy-node-drag: event listeners ██▆███▃▃█▆▁▆▆█▆ 📉 125
minimap-idle: avg frame time ▆██▅▆▁▃▅▄▆█▆▆█▆ ➡️ 17ms
minimap-idle: p95 frame time ▆▆▃▃▃▁▆▆▃▆▃██▆▃ ➡️ 17ms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▂▅▃▁▃▄▃▃▂▂▂▃▃█▆ ➡️ 7ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▇▇█▁▅▄▅▅▃▃▄▅▇▇▇ ➡️ 7
minimap-idle: task duration ▃▇▁█▇▇▇▆▄▅▆▆▄▇▇ ➡️ 591ms
minimap-idle: script duration ▃▅▁█▆▆▄▂▄▄▆▆▂▆▄ ➡️ 33ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ▅▃▆█▆▆▄▆▆█▅▄▆▄▁ ➡️ 73.7 MB
minimap-idle: DOM nodes ▂▁█▁▁▁▁▁▇▁▁▁▂▁▁ ➡️ -258
minimap-idle: event listeners ▃▁█▃▂▃▂▃█▄█▁▃▂▁ ➡️ -180
subgraph-dom-widget-clipping: avg frame time ▆█▆▅▅▆█▅▃█▅▅▁▅▅ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ▃▆▃▃▁▃▆▆▃▃▃▁▃▃█ ➡️ 17ms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▁▄▇▆▄▃▆▃▄█▆▆▁▅▇ ➡️ 11ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▂▃█▂▂▁▃▃▃▆▂▃▅▃█ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▇▁█▇▇▇▆▇▇█▇▂▇▅ ➡️ 361ms
subgraph-dom-widget-clipping: script duration ▃▇▁█▇██▇▇███▃▇▄ ➡️ 122ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ▁▂▁▂▂▁▃▁▂▂▂▂▁█▂ ➡️ 73.6 MB
subgraph-dom-widget-clipping: DOM nodes ▂▃█▂▂▁▃▃▃▆▂▃▅▃█ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▁█▃▆▆██▆▆▆▆▆▆█▆ ➡️ 7
subgraph-idle: avg frame time ▄▆▆█▆▄▃▆▆▄▄▅█▁▃ ➡️ 17ms
subgraph-idle: p95 frame time ▁▅███▅██▁█▅▅█▅▁ ➡️ 17ms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▃▄▆█▅▃▅▃▄▅▅▇▁▆▃ ➡️ 8ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▅▃█▃▂▂▁▁▃▁▂▂▂▂▃ ➡️ 10
subgraph-idle: task duration ▃▄▁██▇█▆▅▆█▇▄▆▇ ➡️ 468ms
subgraph-idle: script duration ▂▂▂▆▆▃▅▁▁▃▅▃▃▂█ ➡️ 10ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ▃▅▅▆██▅▇▁▇▅▅▁▂▆ ➡️ 64.2 MB
subgraph-idle: DOM nodes ▁▁▁▁▁█▁▁▁▁▁▁█▁▁ ➡️ -274
subgraph-idle: event listeners ▂▂▄▃▃█▃▃▁▃▃▃█▃▂ ➡️ -212
subgraph-mouse-sweep: avg frame time ▄▅▄█▄▂▂▅▇▄▅▄▁▂▅ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time █▆▃▆▁▁█▃▆▃▆█▁▁▃ ➡️ 17ms
subgraph-mouse-sweep: layout duration ▁▆▇▆▄▅▇▂▄▄█▆▁▃▄ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▁▅▅▇▆▆▆▃▃▇█▆▁▅▄ ➡️ 26ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 18
subgraph-mouse-sweep: style recalc count ▆▃▅▅▅█▁▃▃▅▃▁▅▃▃ ➡️ 77
subgraph-mouse-sweep: task duration ▁▆▁██▇▇▆▆██▄▂▇▃ ➡️ 673ms
subgraph-mouse-sweep: script duration ▁▄▂▇▇▅█▅▅▇▇▇▁▆▃ ➡️ 95ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ▆▄▁█▃▅▆▄▅▃▃▄▂▃▁ ➡️ 56.2 MB
subgraph-mouse-sweep: DOM nodes █▆▇▄▄▅▁▅▃▆▂▄▇▅▆ ➡️ -274
subgraph-mouse-sweep: event listeners ▆▃▁█▃▆▅▃▆▆▆▅▁▃▃ ➡️ -221
subgraph-transition-enter: avg frame time █▁███▁█▁███▁▁▁█ ➡️ 17ms
subgraph-transition-enter: p95 frame time ▁▁█▁▁▁██▁█▁▁▁▁▁ ➡️ 17ms
subgraph-transition-enter: layout duration ▇▅▁▆▇▅█▇▇█▅▇▁▇▃ ➡️ 10ms
subgraph-transition-enter: style recalc duration ▃▅▁▇▇▆█▆▆▇▆▇▁▇▃ ➡️ 25ms
subgraph-transition-enter: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 5
subgraph-transition-enter: style recalc count ▃▃▆█▁▆▃▆▃▁▃▃▆▃▆ ➡️ 18
subgraph-transition-enter: task duration ▂▆▁▇▇█▃▆▆▇█▇▂▆▅ ➡️ 818ms
subgraph-transition-enter: script duration ▂▅▂▅▆▇▄▅▅▆▅▅▁▆█ ➡️ 36ms
subgraph-transition-enter: TBT ▃▅▁▇▇▆█▇▇▇▆▇▂█▃ ➡️ 93ms
subgraph-transition-enter: heap used ▆▁█▇▁▁▁▁▁█▁█▇▇▆ ➡️ 93.3 MB
subgraph-transition-enter: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 13587
subgraph-transition-enter: event listeners ▁█▁███▁█▁██▁▁█▁ ➡️ 2385
viewport-pan-sweep: avg frame time ▆█▅▆▅▆▆▁▃▆▅▁▁▅▅ ➡️ 17ms
viewport-pan-sweep: p95 frame time ▆▆▃▃▃▃▁▃▆▁▆▃█▁▆ ➡️ 17ms
viewport-pan-sweep: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: style recalc duration ▃▄█▆▄▅▂▁▁▃▇▂▃▂▅ ➡️ 39ms
viewport-pan-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
viewport-pan-sweep: style recalc count █▄▆▂▄▄▁▃▄▅▄▃▇▅▇ ➡️ 249
viewport-pan-sweep: task duration ▂▇▁█▇▇▇▇▆▇▇▇▃▇▄ ➡️ 5145ms
viewport-pan-sweep: script duration ▂▇▁██▇██▇█▇▇▃▇▃ ➡️ 2314ms
viewport-pan-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: heap used ▃▃▄▃▇▃▄▃▂█▁▁▆▃▃ ➡️ 70.1 MB
viewport-pan-sweep: DOM nodes █▅▅▃▂▃▂▃▅▁▃▃▆▄▄ ➡️ -246
viewport-pan-sweep: event listeners ▁▁█▇▃▃▇▅▅▃▅▇▃▃▆ ➡️ -145
vue-large-graph-idle: avg frame time ▆▆▁▆▆█▄▁▃▆▆▃▃▆▅ ➡️ 18ms
vue-large-graph-idle: p95 frame time ▄███▁█▁█▁▁█▁▄▅▄ ➡️ 17ms
vue-large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: task duration ▄▇▁█▇█▇▅▆▇█▄▄▇▄ ➡️ 14529ms
vue-large-graph-idle: script duration ▂▅▁█▆▇▅▄▄▆▇▅▂▆▃ ➡️ 226ms
vue-large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: heap used █▁▇▄▃▅▆▇▅▄▆▆▃▄▇ ➡️ 176.5 MB
vue-large-graph-idle: DOM nodes ██▁█████████▅██ ➡️ -8061
vue-large-graph-idle: event listeners ▂▅▁██▅▇▃▇▇▆▃▆▇▂ ➡️ -14928
vue-large-graph-pan: avg frame time ▅▇▁█▅█▅▇▂▅▇▄▅▇█ ➡️ 18ms
vue-large-graph-pan: p95 frame time ▁▁▁▁▁▁▁▁▁▁▁▁█▁▁ ➡️ 17ms
vue-large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-pan: style recalc duration ▁▅▂█▄▆▄▃▃▄▆▁▁▃▃ ➡️ 17ms
vue-large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-pan: style recalc count ▅█▁▇█▇▆████▄▄█▅ ➡️ 122
vue-large-graph-pan: task duration ▄▇▁█▇█▆▆▆▇█▄▃▆▄ ➡️ 17416ms
vue-large-graph-pan: script duration ▂▇▁██▇█▆▆██▇▂▆▃ ➡️ 729ms
vue-large-graph-pan: TBT ▁▆▃█▂▆▂▂▃▄▃▃▁▄▁ 📉 20ms
vue-large-graph-pan: heap used ▆▄▁▃▄▄▆▄▆▄▅▂█▂▂ ➡️ 162.0 MB
vue-large-graph-pan: DOM nodes ██▄█▁█▁█▆█▆█▆██ ➡️ -8061
vue-large-graph-pan: event listeners ▃▆▁▇▆▆▆▇▇▇█▆▁█▃ ➡️ -14925
vue-node-resize-workload: avg frame time ▂█▁█▅▅▄▅▅▄▇▂▄▅▅ ➡️ 18ms
vue-node-resize-workload: p95 frame time █▄▄██▁▅████▄▄▄▄ ➡️ 17ms
vue-node-resize-workload: layout duration ▁▃▃▅▃█▇▂▁▂▄▄▁▃▄ ➡️ 25ms
vue-node-resize-workload: style recalc duration ▂▅▁▅▆▇█▆▆▆▅▇▂▆▃ ➡️ 64ms
vue-node-resize-workload: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: task duration ▃▇▁█▇▇▅▅▅▅▇▅▃▆▄ ➡️ 5453ms
vue-node-resize-workload: script duration ▂▆▁▆▅█▄▃▄▅▆▄▂▆▃ ➡️ 94ms
vue-node-resize-workload: TBT ▃▇▁███▅▆▇▅█▅▄▆▅ ➡️ 304ms
vue-node-resize-workload: heap used ▆▅▆▅▇▃▂▄▃▄▂▁█▆▁ ➡️ 163.0 MB
vue-node-resize-workload: DOM nodes █▁▇██▁█████████ ➡️ -8061
vue-node-resize-workload: event listeners ▆▅▁█▅▅▃▃▆▃▅▂▃▇▄ ➡️ -14924
vue-zoom-out-idle: avg frame time ▃█▁▆▆██▁▃███▆█▃ ➡️ 17ms
vue-zoom-out-idle: p95 frame time ▅▄▄▄▄▄▄██▄▄▄▁█▄ ➡️ 17ms
vue-zoom-out-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: task duration ▃█▁▆▅█▇▅▄▇█▆▃▆▄ ➡️ 7361ms
vue-zoom-out-idle: script duration ▂▆▁▆▆▇▅▄▄██▅▂▄▄ ➡️ 120ms
vue-zoom-out-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: heap used ▆▇█▂▃▇▄▅▄▄▇▁▆█▃ ➡️ 165.9 MB
vue-zoom-out-idle: DOM nodes █████▁█████████ 📉 0
vue-zoom-out-idle: event listeners ▄▁█▂▃▄▄▅▅▃▃▂▅▃▄ ➡️ -11
workflow-execution: avg frame time ▁█▄█▄███▄██▄███ ➡️ 17ms
workflow-execution: p95 frame time ▁▃▁▃▆▃▆▆▆▁█▆▁▃█ ➡️ 17ms
workflow-execution: layout duration ▄▇▃▅▄▇▅▅█▁█▆▆▇▇ ➡️ 2ms
workflow-execution: style recalc duration ▅█▁▃▃▅▅▄█▃▆▅▃▅▅ ➡️ 19ms
workflow-execution: layout count ▆▅▁▅▃▆▅▃█▁▅█▆▆▆ ➡️ 4
workflow-execution: style recalc count ██▂▂▁▅▃▃▇▂▅▅▃▄▅ ➡️ 13
workflow-execution: task duration ▅█▁▄▄▆▅▅▇▄▇▆▃▅▅ ➡️ 95ms
workflow-execution: script duration ▄▆▁▃▃▅▄▄█▄▇▆▃▅▄ 📈 9ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used █▇▃▁▁▄▃▃▆▃▅▅▃▄▅ ➡️ 63.2 MB
workflow-execution: DOM nodes ▇█▂▂▂▄▂▂▇▁▇▄▁▅▄ ➡️ 132
workflow-execution: event listeners ██▂▁▂▅▄▄▅▃▆▅▄▃▅ ➡️ 60
Raw data
{
  "timestamp": "2026-09-16T23:55:52.934Z",
  "gitSha": "4b8f79fd578408baef71dfdded220ee80faf0c4f",
  "branch": "jaewon/fe-2218-account-core-rename",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2029.4059999999945,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.587000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.2059999999999,
      "heapDeltaBytes": 7153392,
      "heapUsedBytes": 69220804,
      "domNodes": -262,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.606000000000002,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2004.6820000000025,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.473999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.50000000000006,
      "heapDeltaBytes": 4774128,
      "heapUsedBytes": 67497504,
      "domNodes": -261,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.696,
      "eventListeners": -156,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1844.157999999993,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 27.213999999999995,
      "layouts": 14,
      "layoutDurationMs": 4.574,
      "taskDurationMs": 831.2910000000002,
      "heapDeltaBytes": 9977884,
      "heapUsedBytes": 72363988,
      "domNodes": -264,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 149.325,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1741.3179999999784,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.932,
      "layouts": 14,
      "layoutDurationMs": 4.795,
      "taskDurationMs": 723.155,
      "heapDeltaBytes": -2076496,
      "heapUsedBytes": 60352652,
      "domNodes": -262,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 144.541,
      "eventListeners": -186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.3640000000369,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.610999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.2009999999999998,
      "taskDurationMs": 345.978,
      "heapDeltaBytes": 1875888,
      "heapUsedBytes": 64507000,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 13.330000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.0799999999954,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 13.918999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.2550000000000003,
      "taskDurationMs": 327.23199999999997,
      "heapDeltaBytes": 1882088,
      "heapUsedBytes": 64412456,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.385,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 613.5889999999904,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.998999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.771,
      "heapDeltaBytes": 17956644,
      "heapUsedBytes": 79876604,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 146.215,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 609.595000000013,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.862999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.6650000000001,
      "heapDeltaBytes": 17771224,
      "heapUsedBytes": 80374812,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 147.958,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2043.6849999999822,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.408,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 610.8040000000001,
      "heapDeltaBytes": -2257716,
      "heapUsedBytes": 77882828,
      "domNodes": -255,
      "jsHeapTotalBytes": -532480,
      "scriptDurationMs": 36.537,
      "eventListeners": -180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2049.2100000000164,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.282000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.735,
      "heapDeltaBytes": 263464,
      "heapUsedBytes": 79056736,
      "domNodes": -252,
      "jsHeapTotalBytes": -8192,
      "scriptDurationMs": 35.243,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2211.05799999998,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.745000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1564.5819999999997,
      "heapDeltaBytes": 15623864,
      "heapUsedBytes": 80494700,
      "domNodes": -250,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 780.342,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2127.0489999999427,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.104999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1484.3709999999999,
      "heapDeltaBytes": 15198136,
      "heapUsedBytes": 79599444,
      "domNodes": -247,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 726.205,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3557.296000000008,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.938,
      "layouts": 60,
      "layoutDurationMs": 15.255,
      "taskDurationMs": 1577.575,
      "heapDeltaBytes": -9770520,
      "heapUsedBytes": 72986396,
      "domNodes": -255,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 724.484,
      "eventListeners": -180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3503.509000000008,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 13.379999999999999,
      "layouts": 60,
      "layoutDurationMs": 14.755,
      "taskDurationMs": 1575.2289999999998,
      "heapDeltaBytes": 4337900,
      "heapUsedBytes": 70273916,
      "domNodes": -251,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 703.0200000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3164.9469999999837,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.273,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1950.368,
      "heapDeltaBytes": 2300484,
      "heapUsedBytes": 85905004,
      "domNodes": -257,
      "jsHeapTotalBytes": 1458176,
      "scriptDurationMs": 938.178,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2967.2409999999445,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.533,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1748.866,
      "heapDeltaBytes": 16691108,
      "heapUsedBytes": 82745136,
      "domNodes": 2,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 869.777,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.1619999999948,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.521000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 535.0870000000001,
      "heapDeltaBytes": -4111792,
      "heapUsedBytes": 83924052,
      "domNodes": -249,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 31.215999999999994,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.8430000000508,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.581,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.332,
      "heapDeltaBytes": 19710708,
      "heapUsedBytes": 83988596,
      "domNodes": -252,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.78000000000001,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.8389999999927,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.838999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 382.127,
      "heapDeltaBytes": 13857516,
      "heapUsedBytes": 77579232,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 135.75799999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 552.473999999961,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.372000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.408,
      "heapDeltaBytes": 13374608,
      "heapUsedBytes": 77188428,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 124.623,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1997.7609999999686,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.619,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.55899999999997,
      "heapDeltaBytes": 14207356,
      "heapUsedBytes": 77911564,
      "domNodes": -276,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.691000000000003,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2019.3520000000262,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.564,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.48,
      "heapDeltaBytes": 13082960,
      "heapUsedBytes": 76647480,
      "domNodes": -272,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.411,
      "eventListeners": -202,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.6740000000304,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.181000000000004,
      "layouts": 18,
      "layoutDurationMs": 5.607,
      "taskDurationMs": 768.9599999999999,
      "heapDeltaBytes": 8287548,
      "heapUsedBytes": 71883088,
      "domNodes": -274,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 100.42200000000001,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1721.6589999999314,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.602000000000004,
      "layouts": 18,
      "layoutDurationMs": 6.291999999999999,
      "taskDurationMs": 801.362,
      "heapDeltaBytes": 8569260,
      "heapUsedBytes": 72230304,
      "domNodes": -274,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 103.923,
      "eventListeners": -202,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1366.9160000000034,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 25.346999999999994,
      "layouts": 5,
      "layoutDurationMs": 10.200000000000001,
      "taskDurationMs": 837.1469999999998,
      "heapDeltaBytes": 20080992,
      "heapUsedBytes": 103380896,
      "domNodes": 13587,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 29.184,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 134,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8266.921999999966,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.81,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5416.5380000000005,
      "heapDeltaBytes": -14939120,
      "heapUsedBytes": 65378240,
      "domNodes": -256,
      "jsHeapTotalBytes": 2351104,
      "scriptDurationMs": 2493.7590000000005,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8192.000000000007,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.669,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5228.116,
      "heapDeltaBytes": 16757600,
      "heapUsedBytes": 96357352,
      "domNodes": -223,
      "jsHeapTotalBytes": 1527808,
      "scriptDurationMs": 2435.0139999999997,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14248.427999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13992.028999999999,
      "heapDeltaBytes": -68606856,
      "heapUsedBytes": 162109764,
      "domNodes": -8065,
      "jsHeapTotalBytes": -12390400,
      "scriptDurationMs": 243.06499999999997,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10653.031000000055,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10143.158,
      "heapDeltaBytes": -54281920,
      "heapUsedBytes": 168001736,
      "domNodes": -8061,
      "jsHeapTotalBytes": -11472896,
      "scriptDurationMs": 181.45900000000003,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17194.70000000001,
      "styleRecalcs": 128,
      "styleRecalcDurationMs": 18.136999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16984.435,
      "heapDeltaBytes": -47817716,
      "heapUsedBytes": 167771096,
      "domNodes": -8061,
      "jsHeapTotalBytes": -19075072,
      "scriptDurationMs": 814.264,
      "eventListeners": -14922,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17298.60800000006,
      "styleRecalcs": 127,
      "styleRecalcDurationMs": 17.989999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17062.125,
      "heapDeltaBytes": -23265860,
      "heapUsedBytes": 191344176,
      "domNodes": -8061,
      "jsHeapTotalBytes": -14917632,
      "scriptDurationMs": 800.102,
      "eventListeners": -14922,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5183.626000000004,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.70999999999998,
      "layouts": 20,
      "layoutDurationMs": 37.00000000000001,
      "taskDurationMs": 5129.099999999999,
      "heapDeltaBytes": -47682168,
      "heapUsedBytes": 168482720,
      "domNodes": -8061,
      "jsHeapTotalBytes": 4255744,
      "scriptDurationMs": 98.62599999999999,
      "eventListeners": -14924,
      "totalBlockingTimeMs": 182,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5114.9350000000595,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.40900000000002,
      "layouts": 20,
      "layoutDurationMs": 24.067000000000004,
      "taskDurationMs": 5043.244000000001,
      "heapDeltaBytes": -36490024,
      "heapUsedBytes": 180735920,
      "domNodes": -8061,
      "jsHeapTotalBytes": 16707584,
      "scriptDurationMs": 99.42099999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 170,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7106.342000000041,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6877.036999999999,
      "heapDeltaBytes": 12602308,
      "heapUsedBytes": 189501624,
      "domNodes": 0,
      "jsHeapTotalBytes": -23330816,
      "scriptDurationMs": 114.16099999999996,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7096.580000000017,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6823.822,
      "heapDeltaBytes": 8385632,
      "heapUsedBytes": 189583548,
      "domNodes": -4998,
      "jsHeapTotalBytes": -18612224,
      "scriptDurationMs": 113.80299999999993,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 113.02599999999074,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.994000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.822,
      "taskDurationMs": 87.37100000000001,
      "heapDeltaBytes": 3144892,
      "heapUsedBytes": 65323972,
      "domNodes": 131,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.519,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 445.57399999996505,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 17.842,
      "layouts": 2,
      "layoutDurationMs": 0.7819999999999999,
      "taskDurationMs": 95.96,
      "heapDeltaBytes": 4714460,
      "heapUsedBytes": 66906104,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.29,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 51072 77342 66.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.7% 1159
src/LGraphNode.ts 69.9% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/workspaceAuthStore.ts 33.1% 331
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/LGraph.ts 79.1% 263
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 71.8% 254
src/core/billing/operationLifecycle.ts 0.9% 226

@codecov

codecov Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #17851      +/-   ##
==========================================
- Coverage   82.63%   82.06%   -0.57%     
==========================================
  Files        2885     2925      +40     
  Lines      142735   143915    +1180     
  Branches    36718    36718              
==========================================
+ Hits       117946   118108     +162     
- Misses      23553    24568    +1015     
- Partials     1236     1239       +3     
Flag Coverage Δ
billing-web-unit 77.35% <ø> (ø)
e2e 66.03% <ø> (+0.01%) ⬆️
unit 78.76% <100.00%> (ø)
website-unit 74.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/billing-web/src/auth/returnTo.ts 75.00% <ø> (ø)
apps/billing-web/src/auth/signInState.ts 0.00% <ø> (ø)
apps/billing-web/src/auth/useSignInController.ts 0.00% <ø> (ø)
...billing-web/src/components/PaymentMethodsPanel.vue 87.50% <ø> (ø)
...s/billing-web/src/components/SubscriptionPanel.vue 100.00% <ø> (ø)
...s/billing-web/src/components/SubscriptionQuote.vue 85.00% <ø> (ø)
...illing-web/src/components/auth/SignInEmailForm.vue 88.63% <ø> (ø)
apps/billing-web/src/config/firebase.ts 50.00% <ø> (ø)
apps/billing-web/src/router.ts 100.00% <ø> (ø)
apps/billing-web/src/session/billingWebClient.ts 57.89% <ø> (ø)
... and 97 more

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: chromium

Recorded test titles:

  • all tests in browser_tests/tests/dialogs/signInDialogPasswordRules.spec.ts

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Sequencing note: Maanil's account package stack (#17830 → #17840) touches the same package and lands first. This PR is regenerated on top of it afterwards (the rename is a replay script; the Vue move is re-applied on the renamed tree), so review the shape now, but expect a rebase before merge. The design alignment for the published surface is on #17840.

@dante01yoon
dante01yoon force-pushed the jaewon/fe-2218-account-core-rename branch from b8fc84d to 35552fe Compare September 16, 2026 19:24
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 16, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Sequencing update: this lands ahead of Maanil's account stack (#17830 → #17840) rather than after it. The overlapping parts of that stack are called out on #17830, #17838, #17839 and #17840 for its rebase. Ready for review as-is; one more mechanical replay follows once #17852 (reader skeleton, approved) merges, since it edits files under the renamed directory.

@dante01yoon
dante01yoon force-pushed the jaewon/fe-2218-account-core-rename branch from 35552fe to 0e0e7e2 Compare September 16, 2026 21:12
dante01yoon added a commit that referenced this pull request Sep 16, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

## Why

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

## How

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

## AS-IS / TO-BE

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

## Testing

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
Merged via the queue into main with commit d9d27e7 Sep 17, 2026
110 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-2218-account-core-rename branch September 17, 2026 01:11
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 17, 2026
)

<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## Summary

Main E2E hard-failed `widgetValuePersistence` LoadImageOutput on
Chromium shard 16/16 at `d9d27e7` (Comfy-Org#17851). `@slow` is a grep tag only;
Chromium still uses the 15s project timeout unless `test.slow()` runs.
This case does save + full reload + dropdown/preview checks and burned
the fuse on all 4 retries. The `extensionManager` / `app never became
ready` errors are teardown and `waitForAppReady` getting clipped by that
same 15s budget after the page closed — not an `Comfy-Org#17851` account-core
rename or a LoadImageOutput product regression. Sibling save/reopen in
the same file already calls `test.slow()`. This adds the same call in
the LoadImageOutput `beforeEach`.

## Verification

```bash
pnpm exec playwright test browser_tests/tests/vueNodes/widgets/widgetValuePersistence.spec.ts --grep "LoadImageOutput"
```

Expected: pass, including save/reload of the non-first output.

Local agent VM has no Docker, ComfyUI backend, or `node_modules`, so
that command could not be executed here. CI E2E on this PR is the live
check:
https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35172440622

Failing-run evidence:
https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35169610435 —
all four attempts `Test timeout of 15000ms exceeded`; retries 2–3
reached the reloaded widget.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-7d1a4c1e-6c05-5c29-b3b8-f8378ca8db96?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-7d1a4c1e-6c05-5c29-b3b8-f8378ca8db96&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…ling core (Comfy-Org#17854)

Stacked on Comfy-Org#17851 (base branch `jaewon/fe-2218-account-core-rename`),
which stacks on Comfy-Org#17798; merge those first.

## Why

The plan's first decision was that the Vue layer leaves the account
package: composables and unstyled components ship from
`@comfyorg/account-ui`, and the core keeps zero Vue coupling by
construction rather than by an import-guard test. The auth Vue pieces
(`PasswordRules`, `SocialAuthButtons`, `TurnstileWidget`, the region and
Turnstile gates, the lifecycle scope and generation guard) had shipped
in the core's `./vue` entry days before that decision and were
deliberately left for a later follow-up so the fresh auth stack was not
destabilised. With the rename in Comfy-Org#17851 fixing `account-core` as the
boundary that gets published (Phase 7), this is that follow-up: the
published core must not drag `vue`, `@vueuse/core` or a `.vue` entry to
Platform.

## How

- `packages/account-core/src/vue/**` → `packages/account-ui/src/auth/**`
with `git mv` (7 modules + their 7 tests; git records every file as a
rename). The framework-free helpers stay in the core and keep their
public subpaths (`/signInSchemas`, `/turnstileScript`,
`/boundedOperation`); the moved files reach them through those.
- `@comfyorg/account-ui` gains per-module `./auth/*` exports (mirroring
how consumers already import these individually and how the app-side
test mocks target one module each) plus the two workspace deps the moved
files need (`@comfyorg/shared-frontend-utils`,
`@comfyorg/tailwind-utils`; both fine in the view package, neither
allowed in the core).
- The core drops the `./vue/*` exports, `vue`, `@vueuse/core`,
`vue-tsc`, `@vitejs/plugin-vue`, `@testing-library/vue|user-event`,
`@comfyorg/tailwind-utils` and the `peerDependenciesMeta` block;
`typecheck` becomes `tsc --noEmit`; the vitest `account-vue` project
becomes `account-firebase` (happy-dom for `src/firebase/**` only).
- `vueBoundary.test.ts` now proves the boundary three ways: no `vue` /
`@vueuse` import anywhere under `src` (the old `vue/` carve-out is
gone), no Vue dependency in any manifest field, and no `.vue` file
behind any export.
- 17 import sites in 13 files repointed (`apps/billing-web`,
`apps/website`, `src/`); root and `apps/website` gain
`@comfyorg/account-ui: workspace:*`.

A pure `git mv` commit was not possible: the pre-commit hook lints and
type-checks the staged tree, and a rename without repoints leaves 17
unresolved imports. Commit 1 is therefore the rename plus the mechanical
repoints; commit 2 is the boundary guard.

## AS-IS / TO-BE

No user-facing change; package boundary only.

- AS-IS: `@comfyorg/account-core` exports `./vue/*` and depends on
`vue`; a Platform install of the core would pull Vue and `.vue` files.
- TO-BE: `@comfyorg/account-core` has no view entry and no Vue
dependency; the sign-in pieces ship from `@comfyorg/account-ui/auth/*`
next to `./billing`.

## Testing

| Gate | Result |
| --- | --- |
| `packages/account-core` vitest | 34 files, 638 tests |
| `packages/account-ui` vitest | 16 files, 79 tests (7 moved suites) |
| `@comfyorg/billing-web` test:unit / build | 10 files, 90 tests / built
|
| `@comfyorg/website` typecheck | 0 errors |
| root `pnpm typecheck`, `lint`, `format`, `knip` | exit 0 |
| `vitest run src/components/dialog/content/signin src/components/auth
src/platform/workspace/billing` | 11 files, 94 tests |
| `git grep "account-core/vue"` | no matches |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (review; parent of this PR) |
| 4 follow-up | auth Vue pieces leave the core for
`@comfyorg/account-ui` (`./auth/*`) | FE-2215 | **this PR** |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| Comfy-Org#17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | Comfy-Org#17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["PR 17851 account-core rename"]
  VUE["auth Vue pieces to account-ui"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RN --> VUE
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style VUE stroke:#0366d6,stroke-width:4px
```
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…act when the hosted destination says billing_web (#17860)

Stacked on #17856 (base branch `jaewon/fe-2216-plan-change`) → #17853 →
#17783; merge those first.

## Why

Rollout layer C (`hosted_billing_destination`, `stripe` | `billing_web`,
PostHog at 100% `stripe`) decides where a hosted billing action lands.
The plan says the host reads the flag, hands it to the SDK (#17783) and,
when it says `billing_web`, mints a `/v1/<intent>` entry with
`return_to` from `@comfyorg/billing-contract`, the one definition of
that route surface (#17795); when it says `stripe`, the backend's URL is
opened unchanged. Today the host only opens the bare billing-web origin
from the user popover (#17716) with no intent and no `return_to`, and
"Billing & invoices" in the settings panel always goes to the Stripe
portal. This is the last un-opened code item before the Phase 7 host
proof.

## How

- `src/platform/workspace/billing/hostedBillingRoutes.ts`:
`hostedBillingRoute(destination, intent)` returns `{ kind:
'billing_web', url }` built by `buildBillingEntryUrl({ billingOrigin,
intent, product: 'comfyui', returnTo: 'comfyui_workspace' })`, or `{
kind: 'provider' }` meaning "use the server's URL". The environment is
derived, not hardcoded: the cloud base URL's hostname through the
existing `resolveDeployEnv` map (`prod-v2 | stg-v2 | test-v2` →
`production | staging | test`), which also classifies a local dev
session by the backend it talks to. Fails closed to the provider on: no
configured origin, an unknown backend family, a return target with no
destination in that family, or an entry the contract refuses. A
path-prefixed `VITE_BILLING_WEB_URL` keeps its prefix under the minted
route.
- Consumers: the popover's "Plans and pricing" mints the `pricing`
intent (billing-web routes it to the subscription view; the in-app
dialog stays the `stripe` behaviour and the popup-blocked fallback);
`useWorkspaceBilling.manageSubscription()` mints `payment-methods`
**before** either rail is consulted, so on `billing_web` no portal URL
is requested on the SDK rail or the legacy one, and `openPortalWindow` +
`refreshOnPortalReturn` still run so the return re-reads status, balance
and capabilities.
- Also fixed on the way: the popover treated a falsy `window.open(…,
"noopener,noreferrer")` result as a blocked popup and showed the in-app
pricing dialog as a fallback. Per the HTML spec `noopener` always
returns `null`, so on `billing_web` the tab and the dialog opened
together — a latent defect inherited from #17370 on `main`, caught by
this PR's evidence run. The fallback is gone; the E2E `window.open` stub
now returns `null` for `noopener` like a browser does, and a popover
case covers both destinations.
- Left on the provider on purpose:
`useSubscriptionCheckout.recoverOutstandingPayment` and the
`payment_method_url` steps inside an operation are mid-checkout provider
steps, not hosted management; `invoices` and `result` are not served by
billing-web yet (`ComingSoonView`), so nothing mints them; the legacy
`/customers` rail's `accessBillingPortal` is being retired by the
personal-billing flip and is not touched.
- `@comfyorg/billing-contract` becomes a root `workspace:*` dependency.
The CI cloud build for E2E (`.github/actions/build-cloud-frontend`, used
only by `ci-tests-e2e.yaml` and
`pr-update-playwright-expectations.yaml`, never by a deploy) gets
`VITE_BILLING_WEB_URL=https://billing-web.example`, a reserved origin
the spec stubs, reachable only when the server flag says `billing_web`.
- No frontend-derived server state: the destination is the flag as-is;
the host chooses only the URL shape.

## AS-IS / TO-BE

| AS-IS — `hosted_billing_destination: stripe` | TO-BE —
`hosted_billing_destination: billing_web` |
| --- | --- |
| **1. User popover, "Plans and pricing" hovered**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-popover-plans.png"><br>Same
menu item, unchanged by the flag. | **1. User popover, "Plans and
pricing" hovered**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-popover-plans.png"><br>Same
menu item, unchanged by the flag. |
| **2. After clicking "Plans and pricing"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-plans-result.png"><br>In-app
"Choose a Plan" dialog, no tab opened. | **2. After clicking "Plans and
pricing"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-plans-result.png"><br>`billing-web.example/v1/pricing?product=comfyui&return_to=comfyui_workspace`
tab opens and nothing else: `window.open` returns `null` under
`noopener` as the spec requires, and no in-app dialog is left behind. |
| **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing &
invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-settings-billing.png"><br>Identical
panel; the destination is only read on click. | **3. Settings ▸
Workspace ▸ Plan & Credits, before clicking "Billing &
invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-settings-billing.png"><br>Identical
panel; the destination is only read on click. |
| **4. After clicking "Billing & invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-manage-result.png"><br>`POST
/api/billing/payment-portal` recorded, and the URL it returned
(`https://billing.example/portal`) opened. | **4. After clicking
"Billing & invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-manage-result.png"><br>No
request to `/api/billing/payment-portal` on either rail;
`billing-web.example/v1/payment-methods?product=comfyui&return_to=comfyui_workspace`
minted and opened. |
| **5. Return trip — refocusing the app tab after the hosted tab
opened**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-return-refresh.png"><br>`/api/billing/status`,
`/balance` and `/capabilities` re-read. | **5. Return trip — refocusing
the app tab after the hosted tab opened**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-return-refresh.png"><br>Same
three reads; `openPortalWindow` + `refreshOnPortalReturn` still run on
the minted route. |

- AS-IS (`stripe`, today's default): popover → in-app pricing dialog;
settings → Stripe portal via `POST /billing/payment-portal`.
- TO-BE (`billing_web`): popover →
`<billing-web>/v1/pricing?product=comfyui&return_to=comfyui_workspace`;
settings → `<billing-web>/v1/payment-methods?…`, no portal request on
either rail; the app re-reads billing state on return.

## Testing

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace src/composables/billing
src/composables/useFeatureFlags src/config` | 91 files, 1890 tests (19
new route cases: intent × destination × env × prefix × each fail-closed
branch; 3 new adapter cases; 3 popover cases re-pointed) |
| `packages/billing-contract` vitest | 3 files, 62 tests |
| `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit
0 |
| `fallow audit --changed-since origin/jaewon/fe-2216-plan-change` | no
issues in 10 changed files |
| `PLAYWRIGHT_TEST_URL=http://localhost:5431 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/hostedBillingDestination.spec.ts
--reporter=list`, against
`VITE_BILLING_WEB_URL=https://billing-web.example pnpm dev:cloud` | `4
passed (4.6s)` — settings on both destinations, plus the two new
avatar-menu cases: `opens the in-app pricing table from the avatar menu
while the destination is stripe` and `opens the billing-web pricing
entry alone from the avatar menu while the destination is billing_web` |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827, #17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (#17798) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | #17853 (review) |
| 5 slice 2b | Subscribe and plan change through the SDK, priced by the
server | FE-2216 | #17856 (review; parent of this PR) |
| 7 / rollout C | Host mints billing-web `/v1/<intent>` entries with
`return_to` when `hosted_billing_destination` is `billing_web` | FE-2218
| **this PR** |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"]
  S2B["PR 17856 slice 2b subscribe + plan change"]
  LC["Layer C: host mints billing-web entries"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  S2B --> LC
  RB --> LC
  HD --> LC
  LC --> P7
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style LC stroke:#0366d6,stroke-width:4px
```
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…act when the hosted destination says billing_web (#17860)

Stacked on #17856 (base branch `jaewon/fe-2216-plan-change`) → #17853 →

Rollout layer C (`hosted_billing_destination`, `stripe` | `billing_web`,
PostHog at 100% `stripe`) decides where a hosted billing action lands.
The plan says the host reads the flag, hands it to the SDK (#17783) and,
when it says `billing_web`, mints a `/v1/<intent>` entry with
`return_to` from `@comfyorg/billing-contract`, the one definition of
that route surface (#17795); when it says `stripe`, the backend's URL is
opened unchanged. Today the host only opens the bare billing-web origin
from the user popover (#17716) with no intent and no `return_to`, and
"Billing & invoices" in the settings panel always goes to the Stripe
portal. This is the last un-opened code item before the Phase 7 host
proof.

- `src/platform/workspace/billing/hostedBillingRoutes.ts`:
`hostedBillingRoute(destination, intent)` returns `{ kind:
'billing_web', url }` built by `buildBillingEntryUrl({ billingOrigin,
intent, product: 'comfyui', returnTo: 'comfyui_workspace' })`, or `{
kind: 'provider' }` meaning "use the server's URL". The environment is
derived, not hardcoded: the cloud base URL's hostname through the
existing `resolveDeployEnv` map (`prod-v2 | stg-v2 | test-v2` →
`production | staging | test`), which also classifies a local dev
session by the backend it talks to. Fails closed to the provider on: no
configured origin, an unknown backend family, a return target with no
destination in that family, or an entry the contract refuses. A
path-prefixed `VITE_BILLING_WEB_URL` keeps its prefix under the minted
route.
- Consumers: the popover's "Plans and pricing" mints the `pricing`
intent (billing-web routes it to the subscription view; the in-app
dialog stays the `stripe` behaviour and the popup-blocked fallback);
`useWorkspaceBilling.manageSubscription()` mints `payment-methods`
**before** either rail is consulted, so on `billing_web` no portal URL
is requested on the SDK rail or the legacy one, and `openPortalWindow` +
`refreshOnPortalReturn` still run so the return re-reads status, balance
and capabilities.
- Also fixed on the way: the popover treated a falsy `window.open(…,
"noopener,noreferrer")` result as a blocked popup and showed the in-app
pricing dialog as a fallback. Per the HTML spec `noopener` always
returns `null`, so on `billing_web` the tab and the dialog opened
together — a latent defect inherited from #17370 on `main`, caught by
this PR's evidence run. The fallback is gone; the E2E `window.open` stub
now returns `null` for `noopener` like a browser does, and a popover
case covers both destinations.
- Left on the provider on purpose:
`useSubscriptionCheckout.recoverOutstandingPayment` and the
`payment_method_url` steps inside an operation are mid-checkout provider
steps, not hosted management; `invoices` and `result` are not served by
billing-web yet (`ComingSoonView`), so nothing mints them; the legacy
`/customers` rail's `accessBillingPortal` is being retired by the
personal-billing flip and is not touched.
- `@comfyorg/billing-contract` becomes a root `workspace:*` dependency.
The CI cloud build for E2E (`.github/actions/build-cloud-frontend`, used
only by `ci-tests-e2e.yaml` and
`pr-update-playwright-expectations.yaml`, never by a deploy) gets
`VITE_BILLING_WEB_URL=https://billing-web.example`, a reserved origin
the spec stubs, reachable only when the server flag says `billing_web`.
- No frontend-derived server state: the destination is the flag as-is;
the host chooses only the URL shape.

| AS-IS — `hosted_billing_destination: stripe` | TO-BE —
`hosted_billing_destination: billing_web` |
| --- | --- |
| **1. User popover, "Plans and pricing" hovered**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-popover-plans.png"><br>Same
menu item, unchanged by the flag. | **1. User popover, "Plans and
pricing" hovered**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-popover-plans.png"><br>Same
menu item, unchanged by the flag. |
| **2. After clicking "Plans and pricing"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-plans-result.png"><br>In-app
"Choose a Plan" dialog, no tab opened. | **2. After clicking "Plans and
pricing"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-plans-result.png"><br>`billing-web.example/v1/pricing?product=comfyui&return_to=comfyui_workspace`
tab opens and nothing else: `window.open` returns `null` under
`noopener` as the spec requires, and no in-app dialog is left behind. |
| **3. Settings ▸ Workspace ▸ Plan & Credits, before clicking "Billing &
invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-settings-billing.png"><br>Identical
panel; the destination is only read on click. | **3. Settings ▸
Workspace ▸ Plan & Credits, before clicking "Billing &
invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-settings-billing.png"><br>Identical
panel; the destination is only read on click. |
| **4. After clicking "Billing & invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-manage-result.png"><br>`POST
/api/billing/payment-portal` recorded, and the URL it returned
(`https://billing.example/portal`) opened. | **4. After clicking
"Billing & invoices"**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-manage-result.png"><br>No
request to `/api/billing/payment-portal` on either rail;
`billing-web.example/v1/payment-methods?product=comfyui&return_to=comfyui_workspace`
minted and opened. |
| **5. Return trip — refocusing the app tab after the hosted tab
opened**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/as-is-return-refresh.png"><br>`/api/billing/status`,
`/balance` and `/capabilities` re-read. | **5. Return trip — refocusing
the app tab after the hosted tab opened**<br><img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17860-screenshots/screenshots/to-be-return-refresh.png"><br>Same
three reads; `openPortalWindow` + `refreshOnPortalReturn` still run on
the minted route. |

- AS-IS (`stripe`, today's default): popover → in-app pricing dialog;
settings → Stripe portal via `POST /billing/payment-portal`.
- TO-BE (`billing_web`): popover →
`<billing-web>/v1/pricing?product=comfyui&return_to=comfyui_workspace`;
settings → `<billing-web>/v1/payment-methods?…`, no portal request on
either rail; the app re-reads billing state on return.

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace src/composables/billing
src/composables/useFeatureFlags src/config` | 91 files, 1890 tests (19
new route cases: intent × destination × env × prefix × each fail-closed
branch; 3 new adapter cases; 3 popover cases re-pointed) |
| `packages/billing-contract` vitest | 3 files, 62 tests |
| `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit
0 |
| `fallow audit --changed-since origin/jaewon/fe-2216-plan-change` | no
issues in 10 changed files |
| `PLAYWRIGHT_TEST_URL=http://localhost:5431 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/hostedBillingDestination.spec.ts
--reporter=list`, against
`VITE_BILLING_WEB_URL=https://billing-web.example pnpm dev:cloud` | `4
passed (4.6s)` — settings on both destinations, plus the two new
avatar-menu cases: `opens the in-app pricing table from the avatar menu
while the destination is stripe` and `opens the billing-web pricing
entry alone from the avatar menu while the destination is billing_web` |

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827, #17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (#17798) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | #17853 (review) |
| 5 slice 2b | Subscribe and plan change through the SDK, priced by the
server | FE-2216 | #17856 (review; parent of this PR) |
| 7 / rollout C | Host mints billing-web `/v1/<intent>` entries with
`return_to` when `hosted_billing_destination` is `billing_web` | FE-2218
| **this PR** |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"]
  S2B["PR 17856 slice 2b subscribe + plan change"]
  LC["Layer C: host mints billing-web entries"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  S2B --> LC
  RB --> LC
  HD --> LC
  LC --> P7
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style LC stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…contract and ingest-types (Comfy-Org#17882)

## Why

`@comfyorg/account-core`, `@comfyorg/billing-contract` and
`@comfyorg/ingest-types` are about to be installed by Platform from the
public registry, and today none of them can be packed: `exports` point
at `src/*.ts`, there is no `files` allowlist, no build, and the core
still reaches into a private workspace utility. The release workflows on
Comfy-Org#17881 assume `build` and `smoke:pack` exist; this PR is the part that
makes a tarball installable in plain Node.

Built on Comfy-Org#17854 (auth Vue surface → `account-ui`, now merged) so the
core builds from a Vue-free tree, and it reproduces Maanil's Comfy-Org#17838 /
Comfy-Org#17839 / Comfy-Org#17840 on the renamed tree as agreed in the review thread
there. Base is `main`.

## How

- **Private-utility cut** — the one remaining reach out of the core was
`turnstileScript.ts` →
`@comfyorg/shared-frontend-utils/loadExternalScript`. The loader is now
package-owned (`packages/account-core/src/loadExternalScript.ts`,
byte-identical) and `@comfyorg/shared-frontend-utils` leaves the core's
dependencies. `publishBoundary.test.ts` fails on any future `workspace:`
dependency that is not itself published (`@comfyorg/ingest-types` is the
only allowed one).
- **Manifests** — `files: ["dist"]`, `sideEffects: false`,
`repository`/`homepage`/`author`, MIT `LICENSE` per package,
`publishConfig.exports` mapping every dev `exports` entry to `dist/*.js`
+ `.d.ts`, `./package.json` export, `access: public`.
`@comfyorg/ingest-types` moves `zod` to a peer so a consumer never gets
two zod copies. `private: true` stays on all three (`ingest-types` had
no `private` at all; it now has the latch). Flipping `private` is a
one-line change per manifest in a later reviewed PR.
- **Build** — `tsconfig.build.json` per package (`declaration`,
`noEmitOnError`, `types: []`, tests and fixtures excluded), `build` =
`clean` + `tsc -p`, `prepack` runs it. Relative imports carry `.js` so
the emitted ESM resolves under `nodenext`; `openapi-ts.config.ts` sets
`importFileExtension: '.js'` so regeneration keeps it.
- **Smoke pack** — `scripts/smokePack.ts` (run as `pnpm --filter
@comfyorg/account-core smoke:pack`) packs all three, checks each tarball
(no source/test/fixture files, every export target present, no
unrewritten `catalog:`/`workspace:`), installs them into a throwaway npm
project, imports all 21 entries from plain Node ESM, and type-checks a
`nodenext` consumer. Dropping one `.js` extension makes the typed step
fail with `TS2835`, which the plain-Node step alone would not catch.
- **CI** — `ci-packages-pack.yaml` on `pull_request` for the three
package paths: matrix job per package (typecheck → build → `check:pack`)
plus one `smoke-consumer` job. The tarball rules live in one pure
module, `publishableTarball.ts`, with its own test file; the CLI and the
smoke test are two entry points onto it, so CI and the smoke test cannot
drift.

Deliberate divergences from Comfy-Org#17839: no `region` export and no deletion
in `shared-frontend-utils/networkUtil.ts` (the region gate moved to
`account-ui` with the Vue surface and three app suites still import it);
`createScriptLoader` stays in the shared package for its three
`src/platform` callers.

Open point: the root `LICENSE` is GPL-3.0 while all three manifests
already declare MIT (as `@comfyorg/design-system` publishes). Without a
per-package file pnpm would inject the GPL text into a tarball whose
manifest says MIT, so the MIT files fix the actual defect; whether the
SDK packages should be MIT at all is a call for the reviewer to confirm.

## AS-IS / TO-BE

No UI change; packages, scripts and CI only.

- AS-IS: `pnpm pack` on any of the three ships `src/*.ts` (or nothing)
with `exports` a consumer cannot resolve, and the core depends on a
private workspace package.
- TO-BE: `smoke:pack` proves the three tarballs install and import from
plain Node with types, and CI runs that proof on every change to the
packages.

## Testing

| Check | Result |
| --- | --- |
| `build` account-core / billing-contract / ingest-types | 92 / 18 / 6
dist files |
| `smoke:pack` | 3 packed, 21 entries imported under Node ESM,
`nodenext` tsc clean |
| vitest account-core / account-ui / billing-contract / billing-web |
675 / 79 / 62 / 90 pass |
| `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip` (with
`dist` on disk) | exit 0 |
| `yamllint` on the new workflow | clean |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | merged (Comfy-Org#17851) |
| 7 prep | Auth Vue surface → `account-ui`; core Vue-free by
construction | FE-2215 | merged (Comfy-Org#17854) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(Comfy-Org#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (Comfy-Org#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (Comfy-Org#17798) |
| 7 | Package release workflows + versioning ADR (bump PR → publish on
merge, snapshots) | FE-2218 | Comfy-Org#17881 (review) |
| 7 | Publish readiness: dist build, files allowlist, pack smoke test,
private-utility cut | FE-2218 | **this PR** |
| 7 | First publish (`private` off), Platform install, billing-web live
top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 /
Comfy-Org#17860 (review) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename (merged)"]
  AV["auth Vue surface to account-ui (merged)"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  RW["PR 17881 release workflows + ADR"]
  PR["publish readiness: dist, files, smoke pack"]
  PUB["first publish account-core / billing-contract / ingest-types"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> AV
  AV --> PR
  RW --> PUB
  PR --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style RN fill:#d4edda,stroke:#155724
  style AV fill:#d4edda,stroke:#155724
  style PR stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…codes (Comfy-Org#17829)

Linear FE-2217.

## Why

The billing SDK core decodes generated zod schemas from
`@comfyorg/ingest-types/zod`, which a bot regenerates from the cloud
OpenAPI whenever the backend moves. Today a regen that renames a field,
drops it, or widens an enum the reducer switches on surfaces either as a
typecheck error somewhere deep in the core or, worse, as a runtime
`MALFORMED_RESPONSE` in front of a customer mid-payment. Nothing states,
in one readable place, which fields of which schema the SDK actually
depends on.

This adds a contract test per generated schema the core decodes. Each
pins the fields the core reads and the enum members it branches on, at
the type level and at parse time, so a regen that changes one of them
fails a named block whose name says what broke — the parse rows under
`vitest run`, the `expectTypeOf` exhaustiveness pins under the package
typecheck. A failure here means the backend contract moved: fix the SDK,
not the test.

These are pins, not behaviour: reader and command behaviour stays
covered by the existing `credits.test.ts`, `status.test.ts`,
`capabilities.test.ts`, `operationState.test.ts`,
`subscriptionCommands.test.ts`, and `topup.test.ts`.

## How

New folder `packages/account-core/src/core/billing/contracts/`, one file
per endpoint contract, picked up by the package's existing
`src/core/**/*.{test,spec}.ts` include. Each file holds a canonical
fixture typed as `z.input<typeof schema>` built by a small typed builder
(no casts), parses it with `safeParse`, pins the output type with
`expectTypeOf`, and runs one `it.for` row per enum value the SDK
branches on.

| Schema | Module that decodes it | Fields pinned |
| --- | --- | --- |
| `zBillingBalanceResponse` | `credits.ts` (read by `topup.ts`,
`balanceWatch.ts`) | `amount_micros` as a number; the four optional
breakdown micros |
| `zBillingStatusResponse` | `status.ts` (read by
`operationLifecycle.ts`, `subscriptionCommands.ts`, `presentation.ts`) |
`billing_rail` (3), `pending_billing_op_id`, `pending_billing_op_type`
(2), `action_url`, `payment_intent_client_secret`, `is_active`,
`subscription_tier` (7), `subscription_status` (3) |
| `zBillingCapabilitiesResponse`, `zBillingCapabilities`,
`zBillingCapabilityScope`, `zBillingCapabilityRolloutDefaults` |
`capabilities.ts` (which parses the three named pieces, not the response
schema) | the five response keys the reader recomposes into its own
schema, reading `expires_at` as a plain string and `revision` as a
number; all seven capability booleans; `resolved_for.user_id` /
`workspace_id`; `expires_at`; `revision` as an int64 bounded to the
JavaScript-safe range the reader reads it back as a number over;
`denied_reasons` absent from the contract, which is why
`capabilityDenials.ts` decodes it off the raw body |
| `zBillingOpStatusResponse` | `operationLifecycle.ts`,
`operationState.ts` | `id`; `status` (the 4 the reducer handles);
`authentication_state` (the 5 it reads or assigns); `decline_reason` (8,
incl. the `generic` fallback); `recovery_action` (4); `phase` (3);
`action_url`; `payment_intent_client_secret`; `retryable` optional |
| `zErrorResponse` | `billingErrorBody.ts` | `code` as an open string
the commands match against their own closed set; a body without
`message` yields no code |
| `zSubscribeRequest`, `zSubscribeResponse` | `subscriptionCommands.ts`
| `confirmation_token`, `saved_payment_method_id` (`pm_` prefix),
`idempotency_key`, `confirm_reactivation`; `billing_op_id`, `status`
(3), optional `payment_method_url` |
| `zResubscribeResponse` | `subscriptionCommands.ts` | `billing_op_id`
regardless of `status` (2) |
| `zCancelSubscriptionResponse2` | `subscriptionCommands.ts` |
`billing_op_id` on both members of the response union |
| `zPaymentPortalResponse` | `subscriptionCommands.ts` | `url` required,
and not https-checked by the schema, which is why the command re-checks
it |
| `zPreviewSubscribeRequest`, `zPreviewSubscribeResponse` |
`subscriptionCommands.ts` | `plan_slug` required and the three optional
request fields; `allowed`, `is_immediate`, `effective_at`,
`transition_type` (4), the int64 money fields and their JSON-number
coercion, `discounts`, `requires_reactivation_confirmation` |
| `zCreateTopupRequest`, `zCreateTopupResponse` | `topup.ts` |
`amount_cents` minimum and its int64 coercion of the JSON number the
command validates but does not send; `idempotency_key`; `billing_op_id`
regardless of `status` (3) |
| `zCreateTopupCheckoutRequest`, `zCreateTopupCheckoutResponse` |
`topup.ts` | the amount bounds and the `return_url` URL rule, pinned by
the issue **path** the command reads to tell the two apart;
`checkout_url` required, `session_id` optional |

`capabilityDenials.ts` is the one billing module that decodes without a
generated schema — deliberately, since a strict enum parse would lose
the whole capability set the first time the server names an unfamiliar
policy branch. Its absence from the generated contract is pinned in
`billingCapabilities.contract.test.ts`.

## AS-IS / TO-BE

No UI. A regenerated `zBillingOpStatusResponse` that adds a fifth
`status`:

- AS-IS: the new value falls through `terminalFromStatus` into the
pending branch; the operation polls until its budget runs out and
reports `timed_out`.
- TO-BE: `billingOpStatus.contract.test.ts` fails on the regen PR,
naming the reducer as what needs updating. Two gates, and which one
fires depends on the pin: the enum rows (`accepts the %s status`) fail
under `vitest run`, while the exhaustiveness pin at
`billingOpStatus.contract.test.ts:36` sits at module scope and fails as
a TS2344 under the package typecheck, not in the test run.

## Testing

- `cd packages/account-core && vitest run src/core/billing/contracts` —
12 files, 90 tests, all passing. The type pins are not among them: they
sit at module scope and fail `pnpm --filter @comfyorg/account-core
typecheck` instead, because nothing here runs `vitest --typecheck`.
- `cd packages/account-core && tsc --noEmit` — clean
- `pnpm typecheck` — passing; verified the type pins bite by injecting a
spurious enum member and watching `expectTypeOf` fail with TS2344
- `pnpm lint`, `pnpm format`, `pnpm knip` — passing
- `fallow audit --changed-since origin/main` — no issues in the 13
changed files
## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | open (Comfy-Org#17783, carries slice 2a) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | merged (Comfy-Org#17851) — this PR sits on it |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(Comfy-Org#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (Comfy-Org#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (Comfy-Org#17798) |
| 7 | Publish readiness: dist build, files allowlist, pack smoke test |
FE-2218 | merged (Comfy-Org#17882) |
| 7 | Package release workflows + versioning ADR | FE-2218 | open
(Comfy-Org#17881) |
| 7 | First publish (`private` off), Platform install, billing-web live
top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
**this PR** |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | open
(Comfy-Org#17856, Comfy-Org#17860) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | open
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style P6C stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…ced by the server (Comfy-Org#17856)

Stacked on Comfy-Org#17853 (base branch `jaewon/fe-2216-subscription-rail`),
which stacks on Comfy-Org#17783; merge those first.

## Why

Slice 2a (Comfy-Org#17853) put cancel, resubscribe and the payment portal on the
SDK rail. Subscribe — new subscriptions and plan changes — was left on
the legacy call because the SDK's `subscribe` refused an active
subscription on the client (`active → ALREADY_HELD`) and routed a
scheduled cancel to `resubscribe()`, which carries no plan. Both
contradict what the host already does: `useWorkspaceBilling.subscribe`
posts `/billing/subscribe` whatever the subscription state,
`useSubscriptionCheckout` quotes the change first with
`previewSubscribe`, and the server prices the change, reactivates or
refuses (`REACTIVATION_CONFIRMATION_REQUIRED` exists for exactly that).
Decision (2026-09-16): mirror the host; no product change.

## How

- **Core.** `subscribe()` issues `POST /billing/subscribe` for every
subscription state and never short-circuits; the client-side eligibility
switch, `eligibilityOf` and its type are gone (nothing else read them).
`resubscribe()` stays the explicit "resume" command.
`docs/billing-command-eligibility.md` (the path the module doc already
referenced) now records the route per command and that the status read
decides nothing for subscribe.
- **Core, quote decoding.** The generated zod for the preview coerces
every int64 to `bigint` while the generated TS type for the same fields
is `number`, so the SDK's quote was not assignable to the host's
`PreviewSubscribeResponse`. The cents fields are decoded as `z.number()`
via `.extend` on the generated schemas (the precedent `capabilities.ts`
sets for `revision`; money on this route is bounded to cents well inside
the safe range). The two types are now structurally identical and `pnpm
typecheck` proves the assignment with no hand-written projection.
- **Host.** On the rail (read once per action, as in 2a)
`useWorkspaceBilling.subscribe` maps `SubscribeOptions → SubscribeInput`
field for field (`confirmationToken` / `savedPaymentMethodId` empty →
dropped, as the workspace client does; nothing dropped otherwise) and
runs `sdk.commands.subscribe`; `previewSubscribe` runs
`sdk.commands.previewSubscribe`. Both share 2a's route latch (404 →
legacy once), and every other failure is thrown as a `WorkspaceApiError`
whose `.code` carries the server code verbatim, so
`useSubscriptionCheckout` and `useDowngradeToPersonal` keep branching on
`REACTIVATION_CONFIRMATION_REQUIRED`, `SUBSCRIPTION_PAYMENT_REQUIRED`,
`OUTSTANDING_PAYMENT_REQUIRED`, `TRANSITION_NOT_ALLOWED`,
`PRORATION_QUOTE_EXPIRED`, `SUBSCRIPTION_QUOTE_STALE` unchanged.
- **Customer steps.** The SDK settles the operation inside
`subscribe()`, so nothing else watches it: the store's lifecycle
subscriber now handles non-topup pending states — the existing in-page
challenge driver, and a once-per-operation `window.open(actionUrl)` with
the same popup-blocked toast the checkout shows. Without both, a 3DS
plan change or a `needs_payment_method` answer would time out with
nothing on screen.
- **Settled response.** A settled subscribe projects to the `{
billing_op_id, status: 'subscribed' }` body `handleSubscribeResponse`
already handles; `needs_payment_method` / `pending_payment` never reach
the host because the lifecycle drove them first.
- Not on the rail: `teamSubscriptionCheckoutUtil.ts` calls
`workspaceApi.subscribe` directly and stays legacy on both rails;
`savePendingSubscriptionCheckout` and checkout-journey `billing_op_id`
linking run after settlement rather than at issue, because the SDK does
not surface the issued operation (recovery across reloads is the
lifecycle's `recover()`).

## AS-IS / TO-BE

Same journey on both: `?pricing=creator&cycle=yearly` against an active
`standard-annual` subscription on the `stripe` rail, 1280×800, every
endpoint mocked.

| State | AS-IS — `billing_sdk_subscription_enabled: false` | TO-BE —
`billing_sdk_subscription_enabled: true` |
| --- | --- | --- |
| "Confirm your upgrade" with the quote | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-confirm-upgrade.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-confirm-upgrade.png">
|
| "You're all set" after confirming | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-all-set.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-all-set.png">
|
| Recorded `subscribe` request (quote above it carries no key on either
rail) | no `Idempotency-Key` <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-subscribe-headers.png">
| `Idempotency-Key` present and echoed as `idempotency_key` <br> <img
width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-subscribe-headers.png">
|
| `POST /billing/subscribe` answers 404 | one POST, the click fails
("Request failed with status code 404") <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-404-fallback.png">
| two POSTs from one click — first with the key → 404, second without →
200, "You're all set" <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-404-fallback.png">
|
| Server answers `REACTIVATION_CONFIRMATION_REQUIRED` | re-quotes, shows
the reactivation panel and the coded toast <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/as-is-reactivation-required.png">
| identical panel, toast and CTA on the rail <br> <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17856-screenshots/screenshots/to-be-reactivation-required.png">
|

- AS-IS (flag off): quote and subscribe go through the workspace API; a
3DS or payment-method step is driven by the checkout composable off the
raw response.
- TO-BE (flag on): the same screens and copy; quote and subscribe go
through the SDK transport (`Idempotency-Key` on the subscribe POST),
settlement through the operation lifecycle; a 404 falls back to the
legacy call.

## Testing

| Gate | Result |
| --- | --- |
| `packages/account` vitest | 39 files, 634 tests (new: active plan
change issues the request; canceled carries `plan_slug` +
`confirm_reactivation`; `REACTIVATION_CONFIRMATION_REQUIRED` surfaces
coded) |
| host vitest (billing sdk, composables/billing, workspace composables +
stores, feature flags) | 41 files, 1151 tests |
| `pnpm typecheck`, `typecheck:browser`, `lint`, `format`, `knip` | exit
0 |
| `fallow audit --changed-since origin/jaewon/fe-2216-subscription-rail`
| no issues in 10 changed files, complexity 0, duplication 0 |
| Playwright cloud: `planChangeSdkRail.spec.ts` (3) +
`cancelSubscriptionSdkRail.spec.ts` (3) | `6 passed (11.5s)` —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud browser_tests/tests/dialogs/planChangeSdkRail.spec.ts
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list` against a `pnpm dev:cloud` vite server, all endpoints
mocked |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(Comfy-Org#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (Comfy-Org#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (Comfy-Org#17798) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | Comfy-Org#17853 (review;
parent of this PR) |
| 5 slice 2b | Subscribe and plan change through the SDK: quote, then
subscribe; the SDK never short-circuits on the client | FE-2216 | **this
PR** |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["PR 17853 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2B stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 17, 2026
… boundary (Comfy-Org#17830)

## Summary
The session client's state now changes in exactly one place, and the
closure no longer owns the credential cache or single-flight minting. A
pure `transition(state, event)` in the new `core/sessionState.ts` owns
every commit, `createSessionClient` only runs the ordered effects it
hands back, and the storage codec and in-flight dedup live in
`credentialCache.ts` and `mintCoordinator.ts`. This is the decomposition
DrJKL asked for before the client becomes the shared auth foundation,
and it changes no behavior except the two tightenings called out under
Review Focus.

Fixes FE-2191

## Changes
- `packages/account-core/src/core/sessionState.ts` is new. It holds one
`SessionState` record, a `SessionEvent` union (identity changed or
detached, invalidated, mint started, mint committed or rejected by
caller or scheduler, credential adopted or expired), and `transition`,
which returns the next state plus an ordered list of effects (`persist`,
`armScheduler`, `clearStorage`, `stopScheduler`, `abandonInFlight`,
`publish`). Effects carry their own payload, so the runner never reads
state after the fact.
- The same module has `arbitrateMint`, which is `refreshWith`'s old
guard ladder (invalidation epoch, mint sequence, popup path,
settled-null block, joiner reuse) lifted out as a pure verdict, and
`scheduledMintHolds`, the old inline `guardsHold`. The guards inside
`arbitrateMint` are named by the verdict they return
(`userMismatchBlocksCommit`, `popupSettled`, `lostRace`), not by the
situation they detect.
- `createSessionClient` in `session.ts` keeps one `let state` and one
`commit(event)`. The eleven places that used to set `credential`,
`credentialTarget`, `failure`, `committedMint` and the epochs by hand
are gone; the scheduler's `RefreshHost` callbacks call `commit` with the
matching event. `session.ts` goes from 742 lines to 541, and the closure
body from 512 to 330.
- `credentialCache.ts` owns the cached-credential schema, the pure
encode and decode (uid-filtered for the cache, unfiltered for a
cross-tab message), `createCredentialCache`, which wraps the host's
`CredentialStorage` with the same swallowed read, write and clear
failures as before, and the freshness policy: `isCredentialFresh` and
`selectFreshCredential`, the memory-then-storage, exact-target,
first-fresh-wins rule that `ensureCore` used to inline.
`CredentialStorage` and `isCredentialFresh` are re-exported from
`session.ts`, so nothing a host imports moved.
- `mintCoordinator.ts` owns only the in-flight mint: `canJoin` and the
`.finally` that clears it while it is still the same promise.
- `RefreshHost.commitRefreshed` now takes the `mintId` the scheduler
minted with, so the recorded `committedMint` names an explicit id
instead of reading the sequence at commit time.
- `identity.ts` imports `AccountUser` from `sessionContracts` instead of
`session`, which removes a type cycle.
- `core/__fixtures__/sessionFakes.ts` holds the storage, user,
credential, identity and exchange fakes the session suites share. The
three new suites and the two existing ones import from it instead of
carrying their own copies; no assertion changed.
- `sessionState.test.ts` is a table over state × event, including the
pairs that must be no-ops (a preserved transient failure, expiry of a
credential that is no longer live even when value-equal) and the
reference-identity cases that `arbitrateMint` and `credential-expired`
depend on. `credentialCache.test.ts` and `mintCoordinator.test.ts` cover
the codec rejects, the join-versus-start matrix and the candidate order.

## Review Focus
- The claim that nothing changed rests on `session.test.ts` and
`session.scheduler.test.ts` passing with their assertions untouched; the
only edits to those two files swap their local helpers for the shared
fixture imports. If you want to spot-check one site, the asymmetries are
the ones worth a look: a caller-side permanent failure stops the
scheduler and clears the target, a scheduler-side one only clears
storage (`sessionState.ts`, the `mint-rejected` case). Those match the
old code on purpose.
- `commitExpired` in `session.ts` commits only when the expiring
credential is still the live one, by reference, and returns the failure
the transition produced. The value-equal clone row in the table pins
that a stale copy is a no-op.
- `mint-started` is a separate event solely so `mintSequence` lives in
the one state record. It has no effects.
- Tightening one: the popup mint now requires exactly one identity event
since it started. `popupSettled` in `sessionState.ts` checks
`identityEpoch === startEpoch + 1`; the old code accepted any number of
events as long as the uid matched. The `sessionState.test.ts` row "a
popup mint that crossed two identity events is superseded even when the
uid matches again" pins it.
- Tightening two: the stored-credential read is lazy.
`selectFreshCredential` takes thunks (`credentialCache.ts`), so storage
is not touched when the in-memory credential is fresh; the old inline
code read storage every time. `session.test.ts` "serves a fresh
in-memory credential without touching storage" pins it.
- `selectFreshCredential` checks the uid on both candidates where the
old inline code checked only the in-memory one. The stored candidate is
already uid-filtered by `decodeCached`, so no outcome changes; flagging
it because it reads like a tightening.

## QA
- [x] Unit: `pnpm --filter @comfyorg/account-core test` 39 files, 716
tests
- [x] Test diff against the base (`git diff --numstat
origin/maanil/fe-2188-localization-sso...HEAD -- '**/*.test.ts'`):
`credentialCache.test.ts` +210/-0, `mintCoordinator.test.ts` +157/-0,
`sessionState.test.ts` +541/-0 (new files), `session.test.ts` +31/-70
and `session.scheduler.test.ts` +43/-91 (helper definitions replaced by
fixture imports, plus one new test in `session.test.ts`); the shared
fixture `__fixtures__/sessionFakes.ts` is +110/-0. No assertion was
removed from an existing test.
- [x] Consumers: `src/platform/workspace/stores` 326 tests, website
`src/config` 2459 tests, all green
- [x] Coverage: the two new modules are fully covered; `session.ts`
keeps the same three pre-existing uncovered items (the fetch fallback
chain, the expiry no-op return, the no-user early return) and nothing
new
- [x] fallow cyclomatic on `session.ts`: `refreshWith` 38 → 10,
`ensureCore` 12 → 7
- [x] `pnpm typecheck` (root and package), `pnpm lint`, `oxfmt --check`,
`pnpm knip` all clean
- Not covered: no e2e run. This change is package-internal and
flag-independent; the cloud store's delegation call sites are unchanged.

This PR stacks on Comfy-Org#17643 and merges after it.

Resolves review comment from @DrJKL on Comfy-Org#17283:
[r3976008869](Comfy-Org#17283 (comment)).

Linear:
[FE-2191](https://linear.app/comfyorg/issue/FE-2191/refactor-centralize-account-session-commit-ownership)

<details>
<summary>Stack (merge bottom-up; each PR targets the one below
it)</summary>

Base: Comfy-Org#17643 hosts own the auth copy. The package is
`@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue
pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation
(files allowlist, dependency cut, `dist` build) now ships from the
billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are
drafts kept for reference.

1. Comfy-Org#17830 the session client's state changes in one pure transition;
cache and in-flight mint become their own modules ← this PR
2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction;
`dispose()` tears it down
3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates
minting only
4. Comfy-Org#17833 the website binds identity through a lazily activated port so
Firebase stays a lazy chunk
5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no
longer does
6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033
records the outcome
7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable
module and its hot paths are split into named steps
8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go
</details>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…pose (Comfy-Org#17831)

## Summary
`createSessionClient` can now take the identity as its second argument
and subscribe to it at construction, with a `dispose()` to tear that
down. `attachIdentity` still works and is still deprecated; this PR adds
the shape the two hosts migrate onto next, and changes nothing for them
yet.

Part of FE-2196

## Changes
- `createSessionClient(options, identity?)` in `session.ts` subscribes
at construction when an identity is passed. It runs the same closure
function `attachIdentity` now delegates to, so the brand gate, the
identity-changed commit and the auto-mint are one code path.
- `SessionClientOptions.autoMint` (default true) controls the
constructed identity only. `AttachIdentityOptions.autoMint` keeps
governing `attachIdentity`, unchanged.
- `SessionClient.dispose()` detaches whichever identity is current,
constructed or attached, with today's detach semantics (epoch bump,
scheduler stopped, snapshot back to pending). It's idempotent and a
no-op when nothing is attached; the client stays attachable afterwards,
as after a detach today.
- `attachIdentity`'s deprecation note now points at the constructor
argument, and the brand-guard error no longer names `attachIdentity`,
since the constructor path throws it too. The one existing test that
asserted the old text was updated to the new string.
- `session.identity.test.ts` covers construction-with-identity and
dispose. Its fakes live in `src/core/__fixtures__/sessionFakes.ts`, the
same shared fixture the PR below introduces, so the merge-down
reconciles onto one file; `session.test.ts` and
`session.scheduler.test.ts` move onto it in that PR. One fixture in
`packages/account-ui` grew a `dispose` stub because the interface member
is required.
- The subscription re-checks that it is still the current one after the
identity-changed publish and before the auto-mint. A subscriber that
disposes the client during that publish no longer gets an auto-mint
fired at a disposed client. This is a deliberate tightening, covered by
a new test in `session.test.ts`.
- `dispose()` keeps the non-terminal detach semantics for explicit-user
mints: `ensureFresh(user)` after dispose still resolves from the stored
credential without publishing it, exactly as after a detach today, and
that stays the contract until Comfy-Org#17835 retires `attachIdentity`.
- The package is now `@comfyorg/account-core`.

## Review Focus
- Construction subscribes after the scheduler is created (`session.ts`,
just before the return). A port that fires synchronously during
construction commits through the scheduler, so the order matters; a
listener registered later gets the current snapshot from `subscribe` as
before.
- `dispose` is required on the interface rather than optional. Optional
would let a host forget it; the only hand-built client in the repo is
the account-ui billing fixture, updated here.
- No telemetry hook was added to the options. Hosts keep deriving
refresh telemetry from the snapshot and scheduler outcome, which is the
current model.

## QA
- [x] Red first: the new test file failed 9/9 against the base before
the implementation (verbatim run saved with the PR notes; the red could
not be committed separately because the pre-commit typecheck rejects
references to members that do not exist yet)
- [x] Unit: `pnpm --filter @comfyorg/account-core test` 40 files, 728
tests
- [x] Mutation check: hardcoding the constructed identity to always
auto-mint fails the `autoMint: false` row (the row settles time and
asserts the full phase array plus the fetch count)
- [x] `session.scheduler.test.ts` unmodified; `session.test.ts` +32/-2
(the guard-message substring plus the dispose-during-first-delivery
test); `session.identity.test.ts` +208 new
- [x] Consumers: `src/platform/workspace/stores` 326 tests, website
`src/config` 2459 tests
- [x] `pnpm typecheck` (root and package), `pnpm lint`, `oxfmt --check`,
`pnpm knip` clean
- Not covered: no host uses the new constructor argument yet; that is
the cloud store PR and the website PR after it.

This PR stacks on Comfy-Org#17830 and merges after it.

Linear:
[FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity)

<details>
<summary>Stack (merge bottom-up; each PR targets the one below
it)</summary>

Base: Comfy-Org#17643 hosts own the auth copy. The package is
`@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue
pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation
(files allowlist, dependency cut, `dist` build) now ships from the
billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are
drafts kept for reference.

1. Comfy-Org#17830 the session client's state changes in one pure transition;
cache and in-flight mint become their own modules
2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction;
`dispose()` tears it down ← this PR
3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates
minting only
4. Comfy-Org#17833 the website binds identity through a lazily activated port so
Firebase stays a lazy chunk
5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no
longer does
6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033
records the outcome
7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable
module and its hot paths are split into named steps
8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go
</details>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…Rs, with the versioning ADR (Comfy-Org#17881)

## Why

`@comfyorg/account-core`, `@comfyorg/billing-contract` and
`@comfyorg/ingest-types` are about to be installed by Platform from the
public registry, and the plan had nothing on how their versions are cut.
The monorepo already releases one package (`@comfyorg/design-system`)
through a version-bump PR that publishes on merge; the decision
(2026-09-16) is to follow that pattern for the SDK packages, generalized
over a package input rather than copied, and to defer Changesets with
the revisit conditions written down.

## How

- `version-bump-package.yaml` — `workflow_dispatch` with `package`
(account-core / billing-contract / ingest-types), `version_type`,
`pre_release`; bumps on `main` and opens a `Release`-labelled PR titled
`<package> <version>` (same pinned `create-pull-request` action as the
design-system workflow).
- `publish-package.yaml` — reusable (`workflow_dispatch` +
`workflow_call`): name/version match, an explicit failure while
`"private": true`, `build` and `smoke:pack` via `--if-present` (works
before and after the publish-readiness PR lands), `npm view` skip on an
existing version, `pnpm publish --access public --tag … --provenance`
under `id-token: write`.
- `publish-package-on-merge.yaml` — on a merged `Release` PR touching
one of the three manifests, publishes every package whose `version`
changed against the first parent (matrix), posts the release-links
comment per package and the Slack notice.
- `.github/actions/comment-release-links` — three additive cases so each
package's summary has its own section.
- `packages/{account-core,billing-contract,ingest-types}/package.json` —
`"private": true` removed. Comfy-Org#17882 is merged and its smoke test proves
the three tarballs install from plain Node, so the latch comes off here,
in the same reviewed PR as the machinery that checks it. Nothing
publishes on this merge: the on-merge job needs a `Release` label and a
version change, and neither is present.
-
`docs/adr/RELEASES-PACKAGES-0033-sdk-packages-release-through-version-bump-prs.md`
(+ index): context, the decision and each workflow's rationale, the
versioning policy (`1.0.0-alpha.N` on `next` until the Phase 7 host
proof, then `1.0.0`; generated-contract additions minor, removals major,
decided on the regeneration PR), alternatives (Changesets,
release-please, semantic-release, per-package copies) and the explicit
"when to revisit Changesets" list.

Written against the post-rename names (`packages/account-core`); the
on-merge path filter matches once Comfy-Org#17851 lands. Design-system workflows
are untouched.

Not in this PR, on purpose: the `ingest-types` regeneration bump — the
generator lives in Comfy-Org/cloud; the one-step change needed there is
recorded in the ADR's follow-ups.

**Snapshot publishing is not in this PR.** A `pull_request` run executes
the workflow definition from the pull request's own merge ref, so a
publish step triggered that way is PR-authored code holding `NPM_TOKEN`,
and on `main` today no `pull_request` workflow reaches that secret. It
returns in its own PR, publishing from a `workflow_run` job that runs
the default branch's definition over an artifact the pull-request job
produces.

## AS-IS / TO-BE

No UI change; CI and docs only.

- AS-IS: only `@comfyorg/design-system` has a release path; the SDK
packages have no bump, no publish, no policy.
- TO-BE: one dispatch bumps any of the three, the merged `Release` PR
publishes with provenance, and the ADR records why Changesets waits and
what the snapshot follow-up has to satisfy.

## Testing

| Check | Result |
| --- | --- |
| `actionlint` on the four workflows | 0 findings |
| `zizmor --min-severity medium` | clean apart from the repo-exempt
`actions/checkout@v7` / `setup-node@v6` pins (`.pinact.yaml`);
workflow-level `permissions: contents: read` added after its finding |
| `yamllint` (as `ci-yaml-validation.yaml` runs it) | clean |
| `pnpm adr:check`, `pnpm lint`, `pnpm format:check`, `pnpm knip` | exit
0 |

After the second review round (860ef8a, 8f7972f, 41793c7):
`publish-package.yaml` rejects a prerelease on `latest` and reports
whether it published or skipped, and `version-bump-package.yaml` holds
`account-core` and `billing-contract` on the `1.0.0-alpha.N` line, since
`patch`, `minor` and `major` all turn `1.0.0-alpha.0` into `1.0.0`. The
hardening that round added to the snapshot workflow left with it in
25b09c3.

After the first review round (23b854e, 5985af7): the manual
publish no longer takes a caller-supplied `ref` (it publishes the ref it
was dispatched on), and the ADR scopes the prerelease-first gate to the
hand-written packages, putting `ingest-types` outside it.

The Slack notice posts to `#proj-billing` (`C0BNGQG2LCW`), not the
design-system channel. Open points for review: `--provenance` is new
relative to the design-system publish and is confirmed on the first real
run; Follow-ups, not in this PR: a protected `environment` with required
reviewers and an environment-scoped `NPM_TOKEN` on the publish job (repo
configuration), and the same `ref` removal on
`publish-design-system.yaml`.

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (queued) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | merged
(Comfy-Org#17798) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| merged (Comfy-Org#17798) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | merged (Comfy-Org#17798) |
| 7 | Package release workflows + versioning ADR (bump dispatch →
publish on merge) | FE-2218 | **this PR** |
| 7 | Pre-merge snapshots from a default-branch `workflow_run` job |
FE-2218 | todo (split out of this PR) |
| 7 | Publish readiness: dist build, files allowlist, pack smoke test,
private-utility cut | FE-2218 | merged (Comfy-Org#17882) |
| 7 | `private` off on the three manifests | FE-2218 | **this PR** |
| 7 | First publish (bump PRs: ingest-types, then billing-contract,
account-core), Platform install, billing-web live top-up | FE-2218 |
todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 /
Comfy-Org#17860 (review) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  RW["release workflows + ADR"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RW --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style BWV fill:#d4edda,stroke:#155724
  style BWS fill:#d4edda,stroke:#155724
  style P8 fill:#d4edda,stroke:#155724
  style P8RD fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style RW stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 18, 2026
…rkspace auth store (Comfy-Org#17832)

## Summary
The cloud workspace auth store now hands its identity to the session
client at construction and stops attaching and detaching it by hand. The
`unified_cloud_auth` flag gates minting only; identity is bound for the
store's lifetime. This deletes the host side of the transitional adapter
that ADR-0028 marked for removal, and the ADR is amended in the same
change.

Part of FE-2196

## Changes
- `workspaceAuthStore.ts` constructs the client as
`createSessionClient({ ..., autoMint: false },
useAuthStore().identity)`. `ensureUnifiedIdentityAttached`,
`detachUnifiedIdentity` and the attach call inside `unifiedUser()` are
gone.
- The flag watch keeps its two jobs but not the attach half: on turns
the rail on by minting the current target, off calls
`clearUnifiedContext()`, whose `invalidate()` drops the credential,
stops the scheduler and releases the cross-tab lease. The port stays
subscribed but inert, because the store drives every mint itself.
- The three flag-gated helpers (`mintAtLogin`, `remintUnifiedOnce`,
`switchUnifiedWorkspace`) re-check `unified_cloud_auth` after awaiting
`unifiedUser()`, not only before. A mint parked on the identity when a
rollback flips the flag off now fails closed instead of committing a
token, since `invalidate()` alone preserves the user.
- `destroy()` calls `dispose()` on the client in place of the stored
detach handle. Ordering is unchanged.
- `docs/adr/AUTH-IDENTITY-0028` rules 1 and 4 are amended: identity is
passed at construction, and with the flag off the port is subscribed but
no token, network call or timer exists.
- `src/utils/__tests__/stubAccountIdentityPort.ts` holds the two test
seams for this binding: `stubAccountIdentityPort()` keeps a suite's
construction-time subscription off Firebase (six suites use it), and
`replayIdentityPort()` fakes the auth-state registration and replays the
user on a microtask by default, the way the SDK does, or synchronously
on request. Both `authStore.test.ts` blocks and
`useWorkspaceAuth.test.ts` drive their identity events through it, so
the first delivery is modelled one way.
- `useWorkspaceAuth.test.ts` rewrites the four lifecycle cases to the
new contract.
- New tests:
- `authStore.test.ts`, store construction order: building the workspace
store first subscribes its port and mints once Firebase delivers on its
microtask.
- `authStore.test.ts`, unified identity source: now pins that both the
store listener and the port registered at construction.
- `useWorkspaceAuth.test.ts`: a port that delivers synchronously inside
`onUserChanged` still leaves the store subscribed and minting for that
user.
- `useWorkspaceAuth.test.ts`, destroy: a mint after `destroy()` waits
the settle ceiling and resolves false.

## Review Focus
- Fail-closed on rollback: the flag-gated helpers re-check
`unified_cloud_auth` after `await unifiedUser()`, so a mint that parked
on the identity before the flip commits nothing. Pinned by
`useWorkspaceAuth.test.ts` "refuses a mint that parked on the identity
before the flag went off" (red without the re-check).
- The flag-off contract changed on purpose: the port used to be
detached, now it stays subscribed and the client is invalidated. The
test at "turning the flag OFF keeps the identity subscribed..." pins the
gate in `mintAtLogin`; removing that guard fails it.
- Construction-order coupling: `workspaceAuthStore` reads
`useAuthStore().identity` during its own setup while `authStore`'s
listener calls back into `workspaceAuthStore`. This holds because
Firebase delivers a new observer's first callback on a microtask, after
persistence resolves, so each store finishes setup before the other can
re-enter it. A synchronous identity source in that seat would re-enter a
half-built store and leave the client unsubscribed, with every mint
waiting its ceiling. The two-store failure is reproduced by the `store
construction order` test in `authStore.test.ts` (which drives the real
pair with `replayIdentityPort(..., 'sync')`); the
`useWorkspaceAuth.test.ts` sync case pins only the session-client half,
since its `onAuthStateChanged` is a no-op so `authStore`'s listener
never re-enters. The comment at the call site and ADR-0028 rule 3 name
the dependency. Comfy-Org#17834 removes the coupling by importing the identity
module directly instead of reading it off `authStore`.
- Under flag off with a signed-in user the client's snapshot reads
`minting` instead of `pending`. The only phase reader outside the store
is the billing transport, which runs only under a flag that requires
unified auth.
- `dispose()` is not terminal: a disposed client would still honor an
explicit-user mint. Nothing calls the store after `destroy()` today, so
this stays as it was; noted for the legacy-rail retirement.

## QA
- [x] Unit: `pnpm exec vitest run src/platform/workspace src/stores
src/platform/auth` 132 files, 2869 passed, 1 expected fail, 1 skipped;
the one failure is `checkoutJourney.test.ts`, a known local-only failure
unrelated to this change
- [x] Mutation check: removing the `unifiedCloudAuthEnabled` guard in
`mintAtLogin` fails the flag-off lifecycle test
- [x] Package untouched: `pnpm --filter @comfyorg/account-core test` 42
files, 661 tests, no diff under `packages/` (the package is
`@comfyorg/account-core`)
- [x] Website consumers unaffected: `apps/website` `src/config` 2459
tests
- [x] `pnpm typecheck`, `pnpm lint` (0 errors), `oxfmt --check`, `pnpm
knip`, `fallow audit --changed-since` the parent branch: clean
- [ ] Manual, cloud build with `unified_cloud_auth` on: sign in, switch
workspace, wait past the refresh buffer, sign out; confirm the header
keeps a token through the refresh and clears on sign-out
- [ ] Manual, cloud build with the flag off: sign in and confirm no
`/auth/token` request is issued
- Not covered: no e2e in this PR; the auth e2e set is the gate for the
Firebase-init PR that follows.

This PR stacks on Comfy-Org#17831 and merges after it.

Resolves review comment from @DrJKL on Comfy-Org#17283:
[r3976008872](Comfy-Org#17283 (comment)).

Linear:
[FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity)

<details>
<summary>Stack (merge bottom-up; each PR targets the one below
it)</summary>

Base: Comfy-Org#17643 hosts own the auth copy. The package is
`@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue
pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation
(files allowlist, dependency cut, `dist` build) now ships from the
billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are
drafts kept for reference.

1. Comfy-Org#17830 the session client's state changes in one pure transition;
cache and in-flight mint become their own modules
2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction;
`dispose()` tears it down
3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates
minting only ← this PR
4. Comfy-Org#17833 the website binds identity through a lazily activated port so
Firebase stays a lazy chunk
5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no
longer does
6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033
records the outcome
7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable
module and its hot paths are split into named steps
8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go
</details>
kashish00208 pushed a commit to kashish00208/ComfyUI_frontend that referenced this pull request Sep 18, 2026
…identity (Comfy-Org#17833)

## Summary
The website's workshop session client is now constructed with its
identity, like the cloud store, and the last `attachIdentity` caller is
gone. Because the website loads Firebase lazily and its flag can turn
off and on again, the package gains a small lazily activated identity
port; the website activates it when the flag settles on and deactivates
it when the flag turns off.

Part of FE-2196

## Changes
- `packages/account-core/src/core/lazyIdentity.ts` adds
`createLazyIdentity(load)`. It returns a branded identity port whose
`activate()` loads the real identity once, subscribes it, and resolves
after that identity has delivered its current user. `deactivate()`
unsubscribes and delivers null once. Repeated activation shares one
load; a loader failure leaves a retry possible. Exported as
`@comfyorg/account-core/lazyIdentity`.
- `workshop-account.ts` builds the port with a dynamic import of
`workshop-firebase` and passes it to `createSessionClient`. The Firebase
chunk is still only reached through dynamic imports (verified in the
build output).
- `workshop-session-state.ts`: `begin()` awaits `activate()` before
subscribing to the client, so the snapshot it replays is real
post-delivery state, and `stopListeners()` deactivates after
unsubscribing, so the host never observes the null. The flag-off path
keeps clearing the stored credential. The `detachIdentity` handle is
gone.
- Five website suites replace the `attachIdentity` fake with
`activate`/`deactivate` fakes; the Firebase-laziness proof moves to
`workshop-account.test.ts`, which drives the real client through the
port with `workshop-firebase` mocked.
- `workshop-session-state.integration.test.ts` is new and drives the
host over the real lazy port and real session client with only Firebase
stubbed. It pins that flag off then on never shows a signed-out frame,
that the stored credential is cleared on off, that a mint in flight
across off cannot commit, that a flag turned off before the first
Firebase answer installs nothing, and that a begin step failing after a
signed-in delivery clears the stored credential.
- The website session suites share one fakes module
(`config/__fixtures__/workshopSessionFakes.ts`) for the test user and
the token-exchange response, and read the storage keys from the modules
that own them.

## Review Focus
- After `deactivate()` the client's own snapshot is `signed-out` where
the old detach left it `pending`. The host overrides its published
snapshot to pending itself, and the three direct client consumers gate
on `authenticated` only, so nothing observable changes; the OFF→ON test
is the guard.
- `activate()` resolving on first delivery means a Firebase that never
answers leaves the page pending, which is today's behavior for an
unanswered identity.
- One effects change is deliberate: when a begin step fails after a
signed-in delivery, the failed attempt now signs the client out and
clears the stored credential, so the next attempt mints again instead of
reviving the old credential. The old detach kept it. The new integration
case pins the cleared storage.
- This is the only new package surface in the stack. The alternative, a
non-terminal detach on the session client, would have kept a host-driven
attach lifecycle alive, which is what FE-2196 removes.

## QA
- [x] Unit: `pnpm --filter @comfyorg/account-core test` 754 tests;
website `src/config` 79 files, 2562 tests
- [x] Security review fixes, each mutant-proven: the inner delivery
callback drops events from a stale generation (a port that keeps
emitting after unsubscribe, or the previous subscription after
re-activation), and deactivate re-delivers null only after a signed-in
user
- [x] Mutation check: moving `deactivate()` above the snapshot
unsubscribe in `stopListeners` fails the integration case (the host
would publish signed-out on flag off)
- [x] Mutation check: deleting the liveness guard after `activate()` in
`begin` fails the new flag-off case (the host would publish signed-out);
deleting the `deactivate()` call in `stopListeners` fails the new
storage case (the cached credential survives the failed attempt)
- [x] New tests: `lazyIdentity.test.ts` re-activation case now waits on
the second inner subscription instead of bare microtask turns;
integration suite gains the flag-off-before-first-answer case and the
storage-cleared-after-failed-begin case; the abandoned-mint case awaits
the released fetch before asserting on storage; the failure suite pins
that the failed attempt reaches `deactivate()`
- [x] `pnpm exec vitest run src/platform/workspace/stores` 326 tests,
unchanged
- [x] `pnpm --filter @comfyorg/website build` clean; `workshop-firebase`
is a separate chunk with dynamic importers only
- [x] `pnpm typecheck` (root and website), `pnpm lint`, `oxfmt --check`,
`pnpm knip` clean
- [x] `attachIdentity` has zero callers outside `packages/account-core`
- [ ] Manual, website with `workshop-auth` on: load a Workshop page
signed out, confirm no Firebase request until sign-in; sign in, reload,
confirm the session and credits return; toggle the flag off and back on
in a session and confirm the header never flashes the signed-out state
- Not covered: no website e2e in this PR.

This PR stacks on Comfy-Org#17832 and merges after it.

Linear:
[FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity)

<details>
<summary>Stack (merge bottom-up; each PR targets the one below
it)</summary>

Base: Comfy-Org#17643 hosts own the auth copy. The package is
`@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue
pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation
(files allowlist, dependency cut, `dist` build) now ships from the
billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are
drafts kept for reference.

1. Comfy-Org#17830 the session client's state changes in one pure transition;
cache and in-flight mint become their own modules
2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction;
`dispose()` tears it down
3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates
minting only
4. Comfy-Org#17833 the website binds identity through a lazily activated port so
Firebase stays a lazy chunk ← this PR
5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no
longer does
6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033
records the outcome
7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable
module and its hot paths are split into named steps
8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go
</details>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 18, 2026
…pping vuefire (Comfy-Org#17834)

## Summary
The `@comfyorg/account-core` package now initializes Firebase for the
cloud app. `main.ts` no longer creates the app or installs VueFire; one
module builds the package identity from the runtime config under the
default app name with an ordered persistence hierarchy, and `authStore`
subscribes to it. This lifts ADR-0028 rule 5 and is the last piece of
"the package owns identity" before the transitional seam is deleted.

Part of FE-2196

## Changes
- `src/platform/auth/firebaseIdentity.ts` is the cloud app's one
Firebase entry: `createFirebaseIdentity` with `appName: '[DEFAULT]'`,
the config as a thunk, and an ordered persistence hierarchy:
localStorage, then the IndexedDB store vuefire persisted sessions in,
then session storage, with the popup resolver. Firebase restores a user
from the first store that holds one and migrates it into localStorage,
which is what keeps existing sign-ins alive. The package reads the
config thunk once, at first resolution, so the read lands after
`main.ts` has awaited remote config even though this module is evaluated
earlier through the static import graph. Resolving before remote config
has loaded throws in every environment: booting on build-time config
could point auth at the wrong Firebase project, so the module fails
closed instead of falling back.
- The identity is no longer routed through `authStore`:
`workspaceAuthStore` and the shared test stub import the module
directly, which also removes the store's eager `useAuthStore()` at
setup.
- `authStore.ts` drops `useFirebaseAuth`, `setPersistence` and the
direct `onAuthStateChanged`/`onIdTokenChanged` calls in favor of the
identity's `onUserChanged` and `onTokenChanged`. Listener bodies are
unchanged; `authStore` no longer holds or exports an identity, and
`workspaceAuthStore` and the shared test stub import the module
directly.
- `main.ts` removes `initializeApp` and the VueFire plugin; the
`startup/firebase-init` tracer phase now wraps an explicit
`firebaseIdentity.initialize()` in a `try`/`finally`, so the phase is
recorded even when initialization throws.
- `sessionFeatureFlagOverride.ts` reads the current user from the
identity instead of vuefire, keeping its no-`authStore` import rule.
`currentUser()` never initializes Firebase, so a `?ff=` read before
remote config cannot boot the app on build-time config; a test pins
that.
- The package entry passes `popupRedirectResolver` when it initializes
with a persistence (otherwise popup sign-in would throw on the
package-created `Auth`), accepts the options as a thunk, and exposes
`initialize`, `onTokenChanged` and a non-initializing `currentUser`.
- ADR-0028 rule 5 is replaced: the package initializes the cloud app's
Firebase; nothing in `src` creates an app or `Auth`.
- Tests: `firebaseIdentity.test.ts` pins the app name, the persistence
order by identity (localStorage, IndexedDB, session storage) on both the
fresh-app and the `[DEFAULT]` reuse path, the popup resolver, the
deferred config read, and the unloaded guard as one table over DEV on
and off. `useWorkspaceAuth.test.ts` adds a case that constructs the
workspace store before `authStore` exists and shows `mintAtLogin()`
still mints for the port's user, so port-first registration cannot
strand the identity wait. `stubFirebaseAuthHarness()` in
`src/utils/__tests__/stubAccountIdentityPort.ts` performs the three
Firebase stubs (`initializeAuth`, `onAuthStateChanged`,
`onIdTokenChanged`) once; the twelve suites that needed them because
`initializeAuth` now really runs at store creation call it from
`beforeEach`, with no assertion weakened, and the persistence assertion
moved from `authStore.test.ts` to `firebaseIdentity.test.ts`. The
`firebase/auth` automock drops `setPersistence` (no readers left) and
mirrors every `AuthErrorCodes` key `src` reads;
`TopbarSubscribeButton.test.ts` drops its hand-rolled Firebase factories
since nothing under test imports Firebase. `vitest.setup.ts` defaults
`remoteConfigState` to `anonymous` beside the runtime config it already
installs, since the real `authStore` now resolves the identity at
construction; suites that test the unloaded state set it explicitly.

## Review Focus
- The config thunk and guard. An eager `options: getFirebaseConfig()`
would have booted cloud on build-time config; `firebaseIdentity.test.ts`
goes red on that form. A first resolution before remote config has
loaded throws in every environment rather than booting on build-time
config, which could point auth at the wrong Firebase project; the
`main.ts` ordering (remote config awaited before `initialize()`) is the
invariant and the cloud e2e set is what proves it.
- The app name `[DEFAULT]` is load-bearing: persisted sign-ins and the
e2e seed live under `firebase:authUser:<apiKey>:[DEFAULT]`. The package
default would have been `comfy-account`.
- `vuefire` stays in `package.json` for now: 28 suites still mock it.
Dropping the dependency and those inert mocks is a follow-up sweep, not
this PR.
- The cloud auth e2e set (`authAccountSwitch`, `cloudOnboardingAuth*`,
`workspaceAuthRefresh`, `wsReconnectAccountSwitch`,
`workflowDraftForeignWindowSignIn`, `signInDialogAuthErrors`) is the
real gate for this change and runs in CI only.

## QA
- [x] Unit: account 43 files / 692 tests; scoped cloud suites (auth,
workspace, stores, views, topbar, utils) 197 files / 3875 tests, with
only the pre-existing local-only `checkoutJourney.test.ts` failure; full
`pnpm test:unit` fails only the two pre-existing `scripts/cicd` shell
suites
- [x] Mutation checks: the eager config form fails three
`firebaseIdentity.test.ts` cases; an initializing `currentUser` fails
the feature-flag override test in a full-file run; removing the
remote-config guard fails its test
- [x] Error-state fallback pinned: with remote config in `error` (the
fetch ran and failed), the app boots on the build-time config without
asserting, as before; only the unloaded state throws
- [x] `pnpm build:cloud` clean; one `initializeApp` call site outside
the SDK, no vuefire strings in any chunk
- [x] `grep` over non-test `src`: no `initializeApp`, `useFirebaseAuth`,
`VueFire`
- [x] `pnpm typecheck`, `pnpm lint`, `oxfmt --check`, `pnpm knip` clean
- [x] CI: the seven cloud auth e2e specs above pass; the five `@cloud`
specs in the `cloud` project, `wsReconnectAccountSwitch` and
`signInDialogAuthErrors` in the `chromium` shards
- [x] Manual, cloud build: sign in with Google (popup), reload and
confirm the session persists, sign out, sign in with email, switch
workspace, wait past the refresh buffer with the flag on and confirm the
session cookie rotates
- Not covered: no local e2e; Electron/desktop persistence path not
exercised beyond the unit test.

This PR stacks on Comfy-Org#17833 and merges after it.

Linear:
[FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity)

<details>
<summary>Stack (merge bottom-up; each PR targets the one below
it)</summary>

Base: Comfy-Org#17643 hosts own the auth copy. The package is
`@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue
pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation
(files allowlist, dependency cut, `dist` build) now ships from the
billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are
drafts kept for reference.

1. Comfy-Org#17830 the session client's state changes in one pure transition;
cache and in-flight mint become their own modules
2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction;
`dispose()` tears it down
3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates
minting only
4. Comfy-Org#17833 the website binds identity through a lazily activated port so
Firebase stays a lazy chunk
5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no
longer does ← this PR
6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033
records the outcome
7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable
module and its hot paths are split into named steps
8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go
</details>
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 18, 2026
## Summary
The transitional identity seam is gone from `@comfyorg/account-core`:
`attachIdentity`, `AttachIdentityOptions`, and the runtime brand gate.
Identity reaches the session client only at construction, which is what
ADR-0028 called the transitional adapter's removal. ADR-0033 records the
outcome of the whole stack. Along the way it fixes a real gap in the
construction path: a listener that disposed the client during the first
identity publish still started a mint. This closes FE-2196.

Fixes FE-2196

## Changes
- `session.ts` loses `attachIdentity`, `AttachIdentityOptions`, the
`isAccountIdentity` runtime throw and the replace-on-reattach slot.
`subscribeIdentity` runs once at construction, reads `autoMint` from the
client options, and `dispose()` stays idempotent. 557 lines to 533.
- Regression fix: a listener that disposes the client during the
identity publish no longer triggers a mint or re-arms the scheduler.
Before, the identity callback checked for disposal only before
committing the user, so a `dispose()` from inside that publish still
started a post-dispose `getIdToken()` and exchange call, persisted a
credential for a user the client no longer tracked, and re-armed the
refresh timer. The callback now mints only when the delivered user is
still the client's user after the publish. Pinned by `does not mint when
a listener disposes the client during the identity publish` in
`session.identity.test.ts`, written red first.
- `identity.ts` loses `isAccountIdentity`; the brand type stays, so an
unbranded port is a compile error rather than a runtime one. The
`/testing` seam and the two production entries
(`createFirebaseIdentity`, `createLazyIdentity`) still brand at runtime.
`identity.test.ts` now also constructs `createSessionClient` with a
plain port under `@ts-expect-error`, so widening the parameter fails the
typecheck.
- The package suites move their attach call sites (37 in
`session.test.ts`, 34 in `session.scheduler.test.ts`, 2 in
`session.identity.test.ts`) onto construction with the same identity
fakes; `detach()` becomes `dispose()`. No mint, refresh or arbitration
assertion value changed.
- Test tally against the base branch, by name: 12 deleted, 1 added, 3
renamed, plus the regression test above. Deleted: the five
`isAccountIdentity` cases in `identity.test.ts`, replaced by one
compile-time brand case; in `session.identity.test.ts`, re-attach after
dispose, replace-on-attach, and the runtime brand refusal; in
`session.test.ts`, dispose-inside-first-delivery, callback-after-detach,
stale detach from a superseded attach, and the runtime brand refusal
again. Eleven pinned behavior the client no longer has. The twelfth,
dispose-inside-first-delivery, also asserted that no mint follows such a
dispose; dropping it is what let the regression in, and the regression
test above restores that assertion on the construction path. Renamed:
the three `session.test.ts` cases that said detach now say dispose.
- `docs/adr/AUTH-IDENTITY-0033` (Accepted) supersedes ADR-0028's
transitional rules and records the decomposition PR through the
seam-deletion PR as shipped, the preserved credential invariants, and
the rejected alternatives. It names the cloud app's ordered persistence
hierarchy (localStorage, then the IndexedDB store vuefire persisted
into, then session storage) and the popup resolver, and says the brand
is a compile-time gate that the `testing` seam deliberately exposes; the
`identity.ts` docblock says the same. ADR-0028's status block points at
ADR-0033. Index updated.
- The account-ui billing fixture drops its `attachIdentity` stub, and
`billing-web` passes its identity at construction. The Firebase entry
now mints its brand through `brandIdentity` like the lazy port, so there
is one way to mint it.
- The session suites and `credentialCache.test.ts` share their fakes
through `core/__fixtures__/sessionFakes.ts` (memory storage, the
exchange URL and ninety-minute constants, `testUser`, mint body and
response builders, a manual identity with an unsubscribe spy) instead of
drifting copies. The manual identity's `fire` now throws when no client
has subscribed instead of silently doing nothing.

## Review Focus
- The deleted-test tally above is the thing to check: each name says
removed-behavior or covered-elsewhere.
- The regression guard reads the post-publish state rather than the
`active` flag because the type-aware lint narrows that flag to true
across the commit call; the two are equivalent, and the state form also
covers a re-entrant identity change.
- ADR-0033 is `Accepted`, not `Proposed` like its AUTH neighbours,
because the work it records has shipped across this stack; say so if you
want the convention kept instead.
- No runtime defense remains against a JavaScript consumer passing an
unbranded port. The package is private and both consumers are in this
repo; the ADR records the tradeoff for the day it is published.
- Construction subscribes before a test registers its own `subscribe`
listener; the migrated cases rely on `subscribe`'s replay of the current
snapshot, which is the same contract hosts use.

## QA
- [x] Unit: `@comfyorg/account-core` 41 files / 757 tests (base 767;
twelve deleted, two added, three renamed); cloud auth-area suites 132
files / 2824; website config 79 / 2463; account-ui billing 23
- [x] The regression test fails on the base code (post-dispose
`getIdToken()` and exchange call both fire once) and passes with the fix
- [x] `grep` for the three deleted names across `packages`, `src`,
`apps`: none
- [x] `pnpm typecheck`, `pnpm lint`, `oxfmt --check`, `pnpm knip`, `pnpm
adr:check`, `fallow audit` clean
- Not covered: no e2e; nothing user-facing changes in this PR.

This PR stacks on Comfy-Org#17834 and merges after it.

Linear:
[FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity)

<details>
<summary>Stack (merge bottom-up; each PR targets the one below
it)</summary>

Base: Comfy-Org#17643 hosts own the auth copy. The package is
`@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue
pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation
(files allowlist, dependency cut, `dist` build) now ships from the
billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are
drafts kept for reference.

1. Comfy-Org#17830 the session client's state changes in one pure transition;
cache and in-flight mint become their own modules
2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction;
`dispose()` tears it down
3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates
minting only
4. Comfy-Org#17833 the website binds identity through a lazily activated port so
Firebase stays a lazy chunk
5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no
longer does
6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033
records the outcome ← this PR
7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable
module and its hot paths are split into named steps
8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go
</details>
AlexRAV pushed a commit to AlexRAV/ComfyUI_frontend that referenced this pull request Sep 18, 2026
…dule (Comfy-Org#17836)

## Summary
The legacy workspace-token rail moves out of `workspaceAuthStore` into
its own module. The store keeps the flag dispatcher and host projection;
`legacyWorkspaceTokenRail.ts` holds the pre-unified mint, refresh timer,
recovery and token getters as one removable unit. Nothing is deleted:
`unified_cloud_auth` is a PostHog percentage rollout that defaults off,
so this rail still serves production users. When the cut-over completes,
retiring it becomes a file deletion plus a handful of store lines.

The PR has two review surfaces. The first is a verbatim move. The second
splits the rail's two long functions into named steps and, in this
revision, restores the original guard order and exit points that the
split had drifted from.

Part of FE-951 (the cut-over ticket; this PR isolates, it does not
delete)

## Commits
1. `c130ee50` refactor: move the legacy workspace-token rail into its
own module. The code moves verbatim; review with `--color-moved`.
2. `ea210e34` refactor: construct the legacy rail before the computed
that reads it.
3. `bdb1c152` test: pin the legacy rail seam (five cases in
`useWorkspaceAuth.test.ts`).
4. `c0944e6b` test: cover the rail at the factory seam
(`legacyWorkspaceTokenRail.test.ts`).
5. `35b68dae` test: cover the rail's mint, refresh and recovery branches
directly (`legacyWorkspaceTokenRail.lifecycle.test.ts`).
6. `e0bbd162` refactor: split the rail's mint and refresh flows into
named steps.
7. `def7dfa4` test: pin the post-mint owner guard and the foreign-token
refresh exit.
8. `dff474cd` test: drive the seam through the shared feature flag mock.
9. `f0136ca7` refactor: keep the rail's guard order and return after an
exhausted refresh.
10. `c4f7f3c5` test: run the rail suites on a stepped fake clock.

## Review surface 1: the move (`c130ee50`, `ea210e34`)
- `legacyWorkspaceTokenRail.ts` is new:
`createLegacyWorkspaceTokenRail(deps)` returns the legacy surface the
store used to define inline (`workspaceToken`, `initializeFromSession`,
the legacy `switchWorkspace` branch, `refreshToken`,
`ensureWorkspaceToken`, `ensureWorkspaceAuthHeader`, the token getters,
`retireLegacyToken`, `stopRefreshTimer`, `clearLegacyContext`).
- The dependency interface is explicit: the shared refs
(`currentWorkspace`, `isLoading`, `error`), the uid helpers, lazy
`getIdToken`/`hasSignedInUser`/`activeWorkspaceId` closures,
`endWorkspaceSession`, `persistWorkspaceIdentity`,
`clearSessionStorage`, `surfacePermanentAuthError`, and the store's
`switchWorkspace`. That last one matters: the rail's timer-driven
refresh still routes through the flag dispatcher, so with the flag on it
reaches the unified switch exactly as before.
- `workspaceAuthStore.ts` drops from 1179 to 590 lines. Its returned
names and module exports are unchanged; `switchWorkspace` is now only
the flag dispatcher; `clearWorkspaceContext` calls
`clearLegacyContext()` and then its own lines in the original order.
- `WorkspaceAuthError` lives in `workspaceAuthError.ts` (both rails
throw it) and is re-exported from the store.
`MAX_SCHEDULED_REFRESH_RETRIES` moves to `workspaceConstants.ts` since
both rails read it.
- Only five lines inside the moved block differ from the original: three
store reads become injected closures, the flag branch leaves the legacy
switch, and one docblock clause that claimed the unified path reuses
`requestToken` is gone.
- The second commit only moves the rail construction above the
`isAuthenticated` computed that reads it.

## Review surface 2: the named-steps split (`e0bbd162`, then `f0136ca7`)
Why: the repo's complexity gate flagged the moved file.
`performSwitchWorkspace` and `refreshToken` each carried the original
store's two largest bodies, and `ensureWorkspaceToken` was close behind.
The split extracts the steps those functions were already doing in
sequence, with the names the log lines and comments were already using:
`requestToken` (network plus parse, no store writes),
`readStoredSession` and `isUnexpiredSession` under
`initializeFromSession`, `canRecheckAfterInFlightSwitch`,
`canStartRecoveryMint` and `recoverWorkspaceToken` under
`ensureWorkspaceToken`, and `endRefreshOnPermanentError`,
`waitForRefreshBackoff`, `preserveTokenAfterExhaustedRefresh` and
`settleExhaustedRefresh` under `refreshToken`. The rail's highest
per-function cyclomatic goes from 20 to 9.

Behavior is meant to be preserved, and the two suites added in this PR
were written against the original semantics. Review found three places
where the first split drifted; `f0136ca7` puts them back:
- Guard order on restore. `readStoredSession` parsed and
schema-validated the stored workspace before checking who owned the
session; the original short-circuited on the owner check first. The
owner check is back in front of the parse, so a foreign user's blob is
never parsed. Same outcomes in every row of the restore table.
- Exit after an exhausted refresh. `settleExhaustedRefresh` was the last
statement of the catch, so control fell back into the loop and
termination depended on the transient guard. The original returned after
the preserve branch; the `return` is back.
- The recovery target. A one-line helper sat under the docblock that
belongs to `ensureWorkspaceToken`; the expression is inlined, the helper
is gone, and the docblock is back on the function. To keep the
complexity gate green after the inline, the cooldown and
active-workspace gate now opens `recoverWorkspaceToken` instead of
sitting one line above its call, which is the same check in the same
order.
- Two smaller readability points from the same review:
`REFRESH_MAX_RETRIES` is renamed `REFRESH_ATTEMPT_MAX_RETRIES` (it
bounds in-loop attempts; `MAX_SCHEDULED_REFRESH_RETRIES` is the
scheduled budget), and the hand-rolled promise-over-`setTimeout` in
`waitForRefreshBackoff` is `delay` from es-toolkit.

## Review Focus
- Read the move commit with `--color-moved`; every test file is
untouched in it.
- Read `e0bbd162` and `f0136ca7` together against the parent's
`workspaceAuthStore.ts`, checking that every early return and guard
lands in the same order.
- The seam cases in `useWorkspaceAuth.test.ts` drive the rail through
the real store: the legacy refresh deadline and an expired-token
recovery route through the flag dispatcher when unified auth is on (a
rail calling its own legacy switch fails both), the fail-closed return
in `ensureWorkspaceToken` (returning the other workspace's token fails
it), and the injected identity and active-workspace closures resolving
at call time. The other store suites stub the rail's actions.
- This exceeds the usual 300-line guideline on purpose. It is one
verbatim move; a split would have added seven throwaway members to keep
each half green and doubled the review.
- The true boundary today: `WorkspaceTokenResponse` is re-exported from
the store because four Playwright files import it from there
(`browser_tests/tests/authAccountSwitch.spec.ts`,
`browser_tests/tests/currentUserPopoverCredits.spec.ts`,
`browser_tests/fixtures/workspaceSwitcherFixture.ts`,
`browser_tests/fixtures/data/workspaceAuthFixtures.ts`).
`WorkspaceAuthError` is re-exported because `useWorkspaceAuth.test.ts`
imports it from the store; pointing that test at `workspaceAuthError.ts`
would have edited a test file inside the move commit.
- What the eventual deletion looks like, so the boundary can be judged
(this list belongs on FE-951): delete the rail file; remove the twelve
rail-originated names the store destructures (`workspaceToken`,
`initializeFromSession`, `switchLegacyWorkspace`, `refreshToken`,
`ensureWorkspaceToken`, `ensureWorkspaceAuthHeader`,
`getWorkspaceAuthHeader`, `getWorkspaceToken`, `hasValidWorkspaceToken`,
`retireLegacyToken`, `stopRefreshTimer`, `clearLegacyContext`), seven of
which the store also returns; drop the `retireLegacyToken()` call in the
unified snapshot subscriber; drop the three token keys in
`clearSessionStorage`; re-add `currentWorkspace = null` in
`clearWorkspaceContext` (it sits inside `clearLegacyContext` today to
keep the clear order identical); collapse `switchWorkspace` to its
unified branch; drop `initializeFromSession` from `init` and
`stopRefreshTimer` from `destroy`; retarget the four Playwright imports
of `WorkspaceTokenResponse` or drop the type with them, and drop
`WorkspaceTokenResponseSchema` with the file rather than retargeting it
(the generated `zExchangeTokenResponse` already covers this endpoint,
and the unified rail consumes it); and decide what `isLoading` means
once nothing writes it.

## QA
Test files added or changed against the parent branch (`git diff
--numstat <parent>...HEAD -- '**/*.test.ts'`):

| file | added | removed |
| --- | --- | --- |
|
`src/platform/workspace/stores/legacyWorkspaceTokenRail.lifecycle.test.ts`
(new) | 657 | 0 |
| `src/platform/workspace/stores/legacyWorkspaceTokenRail.test.ts` (new)
| 123 | 0 |
| `src/platform/workspace/stores/useWorkspaceAuth.test.ts` | 143 | 1 |

- [x] Move commit: no test file changed in it; the suites are green on
it
- [x] `legacyWorkspaceTokenRail.test.ts`: 6 cases at the factory seam
(mint, owner-scoped validity, clear, refresh timer armed and stopped)
- [x] `legacyWorkspaceTokenRail.lifecycle.test.ts`: 46 cases covering
the mint failure table, session restore, `ensureWorkspaceToken`
(cooldown, coalescing, fail-closed, in-flight join, recovery
classification) and `refreshToken` (permanent-error exit, the doubling
backoff stepped at 999/1, 1999/1 and 3999/1 ms with a fetch count after
each step, pre-exchange failure, expired and foreign held tokens,
abandoned chain, scheduled retry cap). A halved base delay fails the
backoff case at the first step
- [x] `useWorkspaceAuth.test.ts`: five additive seam cases, each proven
against a mutant (flag-dispatch bypass in `refreshToken` and in
`ensureWorkspaceToken`, the downgrade return, eager capture of
`getIdToken`, eager capture of `activeWorkspaceId`); the
refresh-deadline advance now subtracts `TOKEN_REFRESH_BUFFER_MS` rather
than a literal
- [x] Both rail suites and the store suite opt out of the auto-advancing
fake clock (`shouldAdvanceTime: false`), so the 1 ms margins in the
timing rows are real
- [x] `src/platform/workspace`, `src/stores`, `src/platform/auth`: 134
files, 2928 tests green at the tip (the one red case,
`checkoutJourney.test.ts`, is a known local-only failure in a file this
PR does not touch)
- [x] Complexity audit against the parent: pass, nothing newly
introduced; the rail's highest per-function cyclomatic is 9
- [x] `pnpm typecheck`, `pnpm lint` (0 errors), `oxfmt --check`, `pnpm
knip` clean
- Not covered: no e2e; the flag-off production path is exercised only by
the unit suites above. A cloud build with the flag off (sign in, switch
workspace, wait past the refresh buffer) is the manual check if you want
one.

This PR stacks on Comfy-Org#17835 and merges after it.

Addresses the isolate half of
[r3976008872](Comfy-Org#17283 (comment));
the shared exchange contract stays on FE-951.

Linear:
[FE-951](https://linear.app/comfyorg/issue/FE-951/unified-cloud-auth-phase-2-cut-over-to-single-cloud-jwt-remove-legacy)

<details>
<summary>Stack (merge bottom-up; each PR targets the one below
it)</summary>

Base: Comfy-Org#17643 hosts own the auth copy. The package is
`@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue
pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation
(files allowlist, dependency cut, `dist` build) now ships from the
billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are
drafts kept for reference.

1. Comfy-Org#17830 the session client's state changes in one pure transition;
cache and in-flight mint become their own modules
2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction;
`dispose()` tears it down
3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates
minting only
4. Comfy-Org#17833 the website binds identity through a lazily activated port so
Firebase stays a lazy chunk
5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no
longer does
6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033
records the outcome
7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable
module and its hot paths are split into named steps ← this PR
8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go
</details>
AlexRAV pushed a commit to AlexRAV/ComfyUI_frontend that referenced this pull request Sep 18, 2026
…#17837)

## Summary
`vuefire` is gone. After the package-initialized Firebase change nothing
in `src` imports it, so this removes the dependency and the 28 test
mocks that stubbed a module nothing under test loads. Deletion only, no
assertion changes.

Part of FE-2196

## Changes
- `package.json` and the pnpm catalog drop `vuefire`; the lockfile loses
`vuefire` and its optional peer `consola@3.4.2` (the older
`consola@2.15.3` stays, other packages use it).
- 26 suites lose the identical one-line `vi.mock(import('vuefire'),
...)`; two more (`authTokenPriority.test.ts`,
`apiKeyAuthStore.integration.test.ts`) also lose the
`mockReturnValue(... as unknown as ...)` blocks that only existed to
feed that mock, taking one pre-existing double assertion (`as unknown
as`) and one single `as` assertion with them.

## Review Focus
- The diff is deletions only, lockfile included. If a removed mock had
been load-bearing, the suite would import `vuefire` somewhere; none
does.

## QA
- [x] No `vuefire` imports in `src` (two prose mentions remain, in
`firebaseIdentity.ts` and its test, describing where the old default
persisted sessions); nothing in the manifests or the lockfile
- [x] Unit: `src/stores src/platform src/utils src/composables` 597
files / 9785 tests; the 21 touched suites outside those directories 427
tests; all green
- [x] `pnpm typecheck`, `pnpm lint`, `oxfmt --check`, `pnpm knip`, `pnpm
build:cloud` clean

This PR stacks on Comfy-Org#17836 and merges after it.

Linear:
[FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity)

<details>
<summary>Stack (merge bottom-up; each PR targets the one below
it)</summary>

Base: Comfy-Org#17643 hosts own the auth copy. The package is
`@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue
pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation
(files allowlist, dependency cut, `dist` build) now ships from the
billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are
drafts kept for reference.

1. Comfy-Org#17830 the session client's state changes in one pure transition;
cache and in-flight mint become their own modules
2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction;
`dispose()` tears it down
3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates
minting only
4. Comfy-Org#17833 the website binds identity through a lazily activated port so
Firebase stays a lazy chunk
5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no
longer does
6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033
records the outcome
7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable
module and its hot paths are split into named steps
8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go ←
this PR
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants