Repository navigation
test(agent): black-box cover nested subgraph definitions arriving from the document - #18245
Conversation
📦 Bundle: 9.4 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 5.33 kB (baseline 5.33 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 61.1 kB (baseline 61.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 341 kB (baseline 341 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 25 unchanged Utilities & Hooks — 2.29 MB (baseline 2.29 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 62 unchanged Vendor & Third-Party — 14.3 MB (baseline 14.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 19 MB (baseline 19 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 351 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-12T03:16:47.246Z",
"gitSha": "36bfd29b58929e6cd67bbc89e87ff40671744446",
"branch": "qabrowser/nested-subgraph-definition-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.1829999999645,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.543,
"layouts": 13,
"layoutDurationMs": 2.683,
"taskDurationMs": 309.276,
"heapDeltaBytes": -2048184,
"heapUsedBytes": 65753272,
"domNodes": -162,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.167999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.8140000000058,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.885,
"layouts": 12,
"layoutDurationMs": 2.964,
"taskDurationMs": 328.20400000000006,
"heapDeltaBytes": -2822308,
"heapUsedBytes": 64970916,
"domNodes": -162,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.6080000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1814.5660000000134,
"styleRecalcs": 59,
"styleRecalcDurationMs": 13.797999999999998,
"layouts": 13,
"layoutDurationMs": 2.9259999999999997,
"taskDurationMs": 658.886,
"heapDeltaBytes": -138952,
"heapUsedBytes": 67397736,
"domNodes": -162,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 102.505,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064224,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1689.5230000000083,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.163999999999998,
"layouts": 12,
"layoutDurationMs": 2.8720000000000003,
"taskDurationMs": 557.3639999999999,
"heapDeltaBytes": 422856,
"heapUsedBytes": 68137620,
"domNodes": -162,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 99.066,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.3270000000025,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.113,
"layouts": 13,
"layoutDurationMs": 2.643,
"taskDurationMs": 223.36999999999995,
"heapDeltaBytes": 20183144,
"heapUsedBytes": 87977708,
"domNodes": 47,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.226000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1743.4650000000147,
"styleRecalcs": 21,
"styleRecalcDurationMs": 4.939,
"layouts": 15,
"layoutDurationMs": 2.7880000000000003,
"taskDurationMs": 214.345,
"heapDeltaBytes": 20196504,
"heapUsedBytes": 87913916,
"domNodes": 47,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.573999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 383.8489999999979,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.9210000000000007,
"layouts": 12,
"layoutDurationMs": 2.768,
"taskDurationMs": 269.60499999999996,
"heapDeltaBytes": 338324,
"heapUsedBytes": 68085632,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 102.284,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 398.2129999999984,
"styleRecalcs": 17,
"styleRecalcDurationMs": 3.945,
"layouts": 13,
"layoutDurationMs": 3.1529999999999996,
"taskDurationMs": 299.027,
"heapDeltaBytes": 414756,
"heapUsedBytes": 67826864,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 103.50599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000005,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 863.0330000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.20099999999996,
"heapDeltaBytes": -13028804,
"heapUsedBytes": 81119188,
"domNodes": -192,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 34.617999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 234,
"frameDurationMs": 24.759999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 909.4670000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.3370000000001,
"heapDeltaBytes": -11065604,
"heapUsedBytes": 82013040,
"domNodes": -192,
"jsHeapTotalBytes": 19144704,
"scriptDurationMs": 34.270999999999994,
"eventListeners": -106,
"totalBlockingTimeMs": 267,
"frameDurationMs": 25.463888888888885,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 696.1150000000202,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 263.32299999999975,
"heapDeltaBytes": -3840592,
"heapUsedBytes": 76062444,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 85.038,
"eventListeners": 0,
"totalBlockingTimeMs": 78,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 685.8359999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.35799999999966,
"heapDeltaBytes": -6321520,
"heapUsedBytes": 75296528,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 84.13399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 82,
"frameDurationMs": 20.70606060606061,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5932.141999999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2149999999999999,
"layouts": 1,
"layoutDurationMs": 0.2580000000000004,
"taskDurationMs": 4903.942,
"heapDeltaBytes": 6661980,
"heapUsedBytes": 85856676,
"domNodes": -258,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 3852.38,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.54670846394984,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6425.272000000006,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6900000000000006,
"layouts": 5,
"layoutDurationMs": 2.4320000000000004,
"taskDurationMs": 5453.616,
"heapDeltaBytes": -15502408,
"heapUsedBytes": 81392564,
"domNodes": -258,
"jsHeapTotalBytes": 11923456,
"scriptDurationMs": 4219.818,
"eventListeners": -68,
"totalBlockingTimeMs": 22,
"frameDurationMs": 21.824149659863945,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5452.466000000015,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.804,
"layouts": 3,
"layoutDurationMs": 0.6350000000000001,
"taskDurationMs": 4541.334,
"heapDeltaBytes": -7491400,
"heapUsedBytes": 88503028,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 3548.744,
"eventListeners": -67,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.46730769230769,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6062.0240000000085,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0970000000000009,
"layouts": 4,
"layoutDurationMs": 1.1580000000000001,
"taskDurationMs": 4990.911,
"heapDeltaBytes": -7903312,
"heapUsedBytes": 71648256,
"domNodes": -258,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 3778.252,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.332424242424242,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 131.00000000000023,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.139999999999999,
"layouts": 12,
"layoutDurationMs": 3.4450000000000003,
"taskDurationMs": 99.471,
"heapDeltaBytes": -8875420,
"heapUsedBytes": 85698832,
"domNodes": 917,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 5.247000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.042857142857105,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 145.02200000003995,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.634999999999998,
"layouts": 13,
"layoutDurationMs": 3.2939999999999996,
"taskDurationMs": 102.33599999999998,
"heapDeltaBytes": 13001100,
"heapUsedBytes": 93493584,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.885999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.76249999999999,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2026.7160000000217,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1680000000000006,
"layouts": 11,
"layoutDurationMs": 2.398,
"taskDurationMs": 373.53999999999996,
"heapDeltaBytes": -11246192,
"heapUsedBytes": 87409336,
"domNodes": -258,
"jsHeapTotalBytes": 1474560,
"scriptDurationMs": 24.082000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2026.1780000000158,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.606,
"layouts": 10,
"layoutDurationMs": 1.911,
"taskDurationMs": 350.885,
"heapDeltaBytes": -794040,
"heapUsedBytes": 81899448,
"domNodes": -258,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 21.336,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2115.8490000000256,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.984999999999999,
"layouts": 11,
"layoutDurationMs": 2.628,
"taskDurationMs": 1034.1480000000001,
"heapDeltaBytes": -54728,
"heapUsedBytes": 84498856,
"domNodes": -258,
"jsHeapTotalBytes": 1138688,
"scriptDurationMs": 510.00800000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2129.148999999984,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.068999999999999,
"layouts": 11,
"layoutDurationMs": 2.5910000000000006,
"taskDurationMs": 979.784,
"heapDeltaBytes": 1447144,
"heapUsedBytes": 86073220,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 485.393,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665354330708666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3223.175000000026,
"styleRecalcs": 75,
"styleRecalcDurationMs": 8.704,
"layouts": 69,
"layoutDurationMs": 11.583,
"taskDurationMs": 1134.004,
"heapDeltaBytes": -10346124,
"heapUsedBytes": 75198384,
"domNodes": -234,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 483.64699999999993,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3222.171000000003,
"styleRecalcs": 74,
"styleRecalcDurationMs": 8.631,
"layouts": 68,
"layoutDurationMs": 11.046999999999999,
"taskDurationMs": 1142.6319999999998,
"heapDeltaBytes": -1643008,
"heapUsedBytes": 79867488,
"domNodes": -234,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 515.533,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2281.6219999999703,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.346,
"layouts": 9,
"layoutDurationMs": 2.0220000000000002,
"taskDurationMs": 1204.8180000000002,
"heapDeltaBytes": 8640700,
"heapUsedBytes": 96086816,
"domNodes": 0,
"jsHeapTotalBytes": 6709248,
"scriptDurationMs": 612.6120000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665693430656937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2233.4529999999972,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.083999999999999,
"layouts": 8,
"layoutDurationMs": 2.083,
"taskDurationMs": 1168.41,
"heapDeltaBytes": 7508136,
"heapUsedBytes": 96002384,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 591.32,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2021.7679999999518,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4030000000000005,
"layouts": 10,
"layoutDurationMs": 1.952,
"taskDurationMs": 347.543,
"heapDeltaBytes": -2410292,
"heapUsedBytes": 83993640,
"domNodes": -258,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 19.544999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2032.511999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.940999999999999,
"layouts": 11,
"layoutDurationMs": 2.32,
"taskDurationMs": 362.82699999999994,
"heapDeltaBytes": 12913148,
"heapUsedBytes": 90997568,
"domNodes": -258,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 24.704,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 411.4150000000336,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.294999999999999,
"layouts": 12,
"layoutDurationMs": 2.857,
"taskDurationMs": 266.82300000000004,
"heapDeltaBytes": 23023788,
"heapUsedBytes": 90999224,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 88.31599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.18100000004597,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.5680000000000005,
"layouts": 11,
"layoutDurationMs": 2.4749999999999996,
"taskDurationMs": 259.61999999999995,
"heapDeltaBytes": 22862944,
"heapUsedBytes": 91218704,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 88.185,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.3489999999624,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.0339999999999994,
"layouts": 12,
"layoutDurationMs": 2.2729999999999997,
"taskDurationMs": 296.628,
"heapDeltaBytes": 1765544,
"heapUsedBytes": 69781928,
"domNodes": -180,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 5.093,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2010.3130000000533,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9450000000000007,
"layouts": 11,
"layoutDurationMs": 2.114,
"taskDurationMs": 299.36,
"heapDeltaBytes": 2964300,
"heapUsedBytes": 70954284,
"domNodes": -180,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 5.046,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.371999999987,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.384000000000002,
"layouts": 11,
"layoutDurationMs": 2.5170000000000003,
"taskDurationMs": 555.51,
"heapDeltaBytes": 296292,
"heapUsedBytes": 67617136,
"domNodes": -172,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 80.22200000000001,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.7949999999937,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.074,
"layouts": 13,
"layoutDurationMs": 2.706,
"taskDurationMs": 507.20599999999996,
"heapDeltaBytes": 56844,
"heapUsedBytes": 68238372,
"domNodes": -172,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 71.914,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 984.6400000000131,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.404,
"layouts": 5,
"layoutDurationMs": 9.485999999999999,
"taskDurationMs": 719.144,
"heapDeltaBytes": 35982236,
"heapUsedBytes": 116744428,
"domNodes": 15956,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 32.199,
"eventListeners": 3244,
"totalBlockingTimeMs": 82,
"frameDurationMs": 19.282352941176462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.379999999956,
"styleRecalcs": 251,
"styleRecalcDurationMs": 22.74,
"layouts": 11,
"layoutDurationMs": 2.6719999999999997,
"taskDurationMs": 3575.7019999999998,
"heapDeltaBytes": 9711812,
"heapUsedBytes": 92592144,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 1705.5200000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666122448979593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8151.93499999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 21.442,
"layouts": 11,
"layoutDurationMs": 2.353,
"taskDurationMs": 3359.1870000000004,
"heapDeltaBytes": -6416900,
"heapUsedBytes": 92660432,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 1666.674,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605316973415,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15393.98,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14756.279999999999,
"heapDeltaBytes": -51280296,
"heapUsedBytes": 259440440,
"domNodes": -3330,
"jsHeapTotalBytes": 7102464,
"scriptDurationMs": 183.953,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.385248713550602,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 15726.404999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14896.729000000001,
"heapDeltaBytes": -4555064,
"heapUsedBytes": 290746488,
"domNodes": -307,
"jsHeapTotalBytes": 17444864,
"scriptDurationMs": 189.716,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.363321799307954,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 14928.49199999995,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.535000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14317.268000000002,
"heapDeltaBytes": -7677448,
"heapUsedBytes": 295732092,
"domNodes": -3330,
"jsHeapTotalBytes": 17141760,
"scriptDurationMs": 654.412,
"eventListeners": -651,
"totalBlockingTimeMs": 36,
"frameDurationMs": 26.41236749116608,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17606.367999999973,
"styleRecalcs": 142,
"styleRecalcDurationMs": 11.978000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17247.367000000002,
"heapDeltaBytes": -27311000,
"heapUsedBytes": 272464164,
"domNodes": -3330,
"jsHeapTotalBytes": -901120,
"scriptDurationMs": 623.828,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 32.65194805194805,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5817.588999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.475000000000016,
"layouts": 20,
"layoutDurationMs": 22.080000000000002,
"taskDurationMs": 5699.584,
"heapDeltaBytes": -39462764,
"heapUsedBytes": 270440524,
"domNodes": -307,
"jsHeapTotalBytes": 8269824,
"scriptDurationMs": 86.03000000000002,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.62202380952381,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5292.987999999923,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.57,
"layouts": 20,
"layoutDurationMs": 18.506999999999994,
"taskDurationMs": 5201.451999999999,
"heapDeltaBytes": -7547172,
"heapUsedBytes": 291655632,
"domNodes": -3330,
"jsHeapTotalBytes": 13778944,
"scriptDurationMs": 70.14200000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.120000000000005,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6289.792000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5778.879,
"heapDeltaBytes": -27144660,
"heapUsedBytes": 252765748,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.07699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.5914089347079,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8164.792000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7830.973,
"heapDeltaBytes": -20189084,
"heapUsedBytes": 260490228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.767,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.45435540069687,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 444.3099999999731,
"styleRecalcs": 16,
"styleRecalcDurationMs": 12.759,
"layouts": 14,
"layoutDurationMs": 4.317,
"taskDurationMs": 103.455,
"heapDeltaBytes": 7099780,
"heapUsedBytes": 73237832,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.235,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 445.17900000005284,
"styleRecalcs": 19,
"styleRecalcDurationMs": 13.982,
"layouts": 15,
"layoutDurationMs": 4.587,
"taskDurationMs": 95.602,
"heapDeltaBytes": 6679064,
"heapUsedBytes": 73977828,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.265,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 234.9579999998923,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.113,
"layouts": 76,
"layoutDurationMs": 12.943,
"taskDurationMs": 193.468,
"heapDeltaBytes": -9911624,
"heapUsedBytes": 84418676,
"domNodes": 4,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 77.561,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 262.613999999985,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.09,
"layouts": 76,
"layoutDurationMs": 13.181999999999999,
"taskDurationMs": 217.605,
"heapDeltaBytes": 9257100,
"heapUsedBytes": 102980932,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 92.834,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 318.5750000000098,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8550000000000002,
"layouts": 76,
"layoutDurationMs": 13.873,
"taskDurationMs": 278.99800000000005,
"heapDeltaBytes": -2157968,
"heapUsedBytes": 132183224,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 91.821,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 292.68500000000586,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.583,
"layouts": 76,
"layoutDurationMs": 12.012,
"taskDurationMs": 246.903,
"heapDeltaBytes": 17477636,
"heapUsedBytes": 197991400,
"domNodes": 4,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 74.88799999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2264 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 06c73966e9488626c2ff9528b2e38586475bd640
Full docs: ADR-DEVEX-LINT-0015 |
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for filling the black-box gap that #18148 left, and especially for writing down why the paste path is the wrong footing — that comment will save the next person a full rebuild.
I checked the red-proof claim independently and it holds on the substance: readNestedDefinitions / orderedKeys in src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.ts is the only thing that can read the {subgraphs: Y.Map, subgraph_order: [...]} form seedNestedDefinition() builds, and without it hasSafeNestedDefinitions() rejects the id-keyed object, so readDefinition() drops the outer too. The fixture shape matches the reader under test. No production code is touched, and the spec is tagged the same way as its @cloud @agent siblings, so it lands in the cloud Playwright project rather than the default chromium one.
I have a couple of question: items on fixture typing and fidelity below, so I'm leaving this as a comment rather than an approval — none of them are defects in the behaviour under test, and I'm happy to be told the answers are "deliberate".
Validation I could not run: node_modules is unavailable in my checkout, so I did not typecheck or execute the spec locally. lint-and-format, test, and the Playwright shards were still pending at the time of this review.
Unanchored
nit-pick (non-blocking): PR description, "Review Focus" paragraph. The red-proof cites src/workbench/extensions/agent/utils/agentSubgraphDefinitions.ts, but that path does not exist — the file is at src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.ts and git log --all shows it has never lived under utils/. git log c4604d2283..HEAD -- <nonexistent path> is empty for any head, so as written the quoted evidence does not support "restoring that one file removes the fix and nothing else".
The claim itself does check out against the real path — commits touching crdt/agentSubgraphDefinitions.ts up to this head are c4604d2283 (#18148), then d0dc978a1a, eca7d5601e, 9ff3fd7f0e, all before it — so nothing landed on that file after the fix. Could you just correct the path in the description so the evidence someone re-runs actually reproduces?
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18245 +/- ##
==========================================
+ Coverage 86.08% 86.87% +0.79%
==========================================
Files 3644 2594 -1050
Lines 173963 145750 -28213
Branches 45898 39915 -5983
==========================================
- Hits 149750 126620 -23130
+ Misses 22204 18744 -3460
+ Partials 2009 386 -1623
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
This comment has been minimized.
This comment has been minimized.
CodeJuggernaut
left a comment
There was a problem hiding this comment.
One line short of typechecking: the nested subgraphs is optional too.
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
40deb41 to
724964b
Compare
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
724964b to
d627a1e
Compare
…ument (#18148) #18148 fixed the follower's document reader dropping a subgraph definition that carries another subgraph inside it, and shipped with unit cover only. The case is built on the host seeding the definition, not on a local paste. A blueprint pasted on the page registers its definitions on the way in, so it never reaches the document reader at all - a first draft of this spec built on the paste path passed with the fix reverted, which is why the spec says so in its own comment. Proved red by reverting only the fix at this head: with agentSubgraphDefinitions.ts restored to c4604d2^ (no other commit since has touched that file) the follower registers neither definition - the reader rejects the nested map, answers null for the outer, and the root graph ends up with an empty subgraph set. Green with the fix in place.
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Addresses review feedback: #18245 (comment)
Implements the two coverage findings from mrseek-reviews that change what this spec proves: - r4210461045 (P2): the follower poll observed only NESTED_OUTER_ID, so the nested definition — the thing #18148 fixed — could regress without this case noticing. The reviewer demonstrated two partial regressions that stayed green: a reader that keeps the outer and answers `{}` for the nested map, and `registerDefinitions` without the `allSubgraphDefinitions` flattening. The poll now requires both ids to be registered and reports the missing ones, so a failure names which level was lost. - r4210461031 (P2): dropped the host-doc self-check. It read the fixture's own Node-side Y.Doc one line after the fixture wrote it, with no browser or product code in between, so no product regression could fail it — and being the spec's only use of NESTED_INNER_ID it made the case look as though it covered the inner definition when nothing did. NESTED_INNER_ID is now used by the assertion that actually covers it. The suggested `!registry[type]` form is written as `!(type in registry)`: `registered_node_types` is typed as a total record, so oxlint's type-aware `no-unnecessary-condition` rejects the truthiness check as always-falsy. Membership is what is being asserted anyway. Deliberately NOT taken in this commit: the `seedDefinition` mint refactor (r4210460891 / r4210460928) and the eleven P3/Nit comments. Those are fixture-architecture and documentation changes that do not alter what the pin covers; left open with reasoning on the threads.
…e locator Three more mrseek-reviews findings, all cheap and all correct: - r4210461059 (P3): use `agentConversation.vueNodes.getNodeLocator(nodeId)` instead of rebuilding the `[data-node-id="…"]` locator; the harness already owns that selector. - r4210460978 / r4210461073 (Nit, paired): "blueprint" means the paste path in this codebase, which is exactly the path this case avoids, so the seeded definition's name sent the next reader looking for a paste. Renamed to `nested definition` in the fixture and in the title assertion together, plus the fixture docblock above the two ids. Not taken, with reasoning left on the threads: the `seedDefinition` mint refactor (r4210460891 / r4210460928) and the remaining documentation P3s. The refactor's measurement is accepted — minting the outer whole does produce an identical `toJSON()` — but it rewrites two shared fixtures used by other agent specs without changing what this pin covers, so it is not bundled into a landing repair.
…helpers Two findings from the review of the previous head. r4242556627 (Medium, raised by 3 of 6 reviewers) — the point I got wrong in the last commit. Requiring both ids in the registry covers *whether* the definitions were read, not the ORDER they were configured in, and order is what #18148 fixed. Configure the outer before the inner and its interior node becomes a `has_errors` placeholder while the inner type is registered immediately afterwards, so the two-id poll AND the title assertion both still pass over a subgraph whose interior is broken. Now asserts the outer's interior node is typed by the inner definition and carries no `has_errors`. mrseek r4242555... (P3, two threads) — `hostNestedDefinitionIds` and `HostDoc.nestedDefinitionIds` lost their only caller when the host-doc self-check came out, so this PR was adding dead code. Both removed. Also corrects the fixture comment that claimed "the inner must be registered for the outer to configure at all". It is false, and it is the premise the new assertion depends on being false: `LGraph.createSubgraphs` builds the outer either way and marks the interior node `has_errors` when the inner is missing.
d627a1e to
976edec
Compare
|
/swarmhost evaluate |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 976edec has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Summary
Adds the black-box browser case that #18148 shipped without: a subgraph definition that carries another subgraph inside it, arriving through the document rather than through a local paste.
Changes
Review focus
A local paste registers definitions on the page and cannot exercise the follower reader. This fixture sends host-minted document bytes through the follower. The interior-node assertion is the discriminating oracle for #18148: merely observing both registered ids is insufficient because outer-first registration still leaves a broken placeholder.
Evidence