Repository navigation
fix(types): recover checked public operation vocabulary - #204
christian-byrne wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
|
Exact-head Fallow verification completed at Local gates passed for |
|
Superseded by merged combined recovery. Closing this support PR without merge; retaining its branch, commits and collaboration history. Full context for agent readersChristian requested complete migration cleanup, not another implementation of already-landed package work. The combined replacement #206 explicitly integrated these five support branches and merged as 11454e8 . They did not close automatically after its squash merge.
The original source review histories and individually attributed destination records remain intact. No native review is resolved, no historical approval transfers, and no original branch is deleted or rewritten. Existing merged-package verification is retained as dated evidence; no new test was run under the resource hold. The older draft/readiness statements describe their original revisions and are superseded only as instructions to merge these duplicates. This retires redundant package carriers, not frontend adapter work, product acceptance or security findings. The recovery coordinator retains consumer follow-through in https://github.com/christian-byrne/in-app-agent-program/pull/187 . No release, deployment, paid attempt or shared-document cutover follows from closure. Glossary: support PR means a smaller recovery branch integrated into the combined replacement; private keys here are internal document bookkeeping fields, not credentials; product acceptance means observed authenticated application behavior. |
Human owner: christian-byrne
Full context for agent readers
Recovers the public
OpKinddeclaration and its five registry checks from the preserved migration parent, directly onto standalone comfy-multi-player main. These are source-map hunks H060/H061. Frontend relocation remains deferred.The same five source constraints now appear through
Checkedin the emittedOpKinddeclaration rather than unused assertion aliases. The valid union, runtime registries, exports and schema are unchanged. Existing negative-type conventions pin implemented/deferred values and reject an undeclared kind; the directive census was updated. Five isolated bad registry probes fail compilation. Main already rejected those invalid states; this does not claim new runtime safety or a stronger valid union.Node 22.22.2 typecheck/build and public API/batch/type-negative focused tests pass. Full suite: 988 passed. Package purity/import/pin/profile/reviewer-config/corpus gates pass. Hosted checks and fresh review remain pending.
The captured unresolved parent map has no finding anchored to these paths. No historical finding or approval is marked transferred or resolved; other parent type/schema and collaboration work remains separately owned. This preserves the vocabulary exhaustiveness contract without changing operation behavior, dependencies or the widget catalog.
Glossary: CMP = comfy-multi-player; registry partition = implemented/deferred kind lists covering the vocabulary without overlap; emitted declaration = TypeScript types consumed outside the source project.