Skip to content

fix(types): recover checked public operation vocabulary - #204

Closed
christian-byrne wants to merge 2 commits into
mainfrom
christian-byrne/cmprec-23-types
Closed

christian-byrne wants to merge 2 commits into
mainfrom
christian-byrne/cmprec-23-types

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor
  • Recover public vocabulary type checks.
  • Valid operation kinds stay unchanged.
  • Draft; fresh review required.

Human owner: christian-byrne

Full context for agent readers

Recovers the public OpKind declaration and its five registry checks from the preserved migration parent, directly onto standalone comfy-multi-player main. These are source-map hunks H060/H061. Frontend relocation remains deferred.

The same five source constraints now appear through Checked in the emitted OpKind declaration rather than unused assertion aliases. The valid union, runtime registries, exports and schema are unchanged. Existing negative-type conventions pin implemented/deferred values and reject an undeclared kind; the directive census was updated. Five isolated bad registry probes fail compilation. Main already rejected those invalid states; this does not claim new runtime safety or a stronger valid union.

Node 22.22.2 typecheck/build and public API/batch/type-negative focused tests pass. Full suite: 988 passed. Package purity/import/pin/profile/reviewer-config/corpus gates pass. Hosted checks and fresh review remain pending.

The captured unresolved parent map has no finding anchored to these paths. No historical finding or approval is marked transferred or resolved; other parent type/schema and collaboration work remains separately owned. This preserves the vocabulary exhaustiveness contract without changing operation behavior, dependencies or the widget catalog.

Glossary: CMP = comfy-multi-player; registry partition = implemented/deferred kind lists covering the vocabulary without overlap; emitted declaration = TypeScript types consumed outside the source project.

@christian-byrne christian-byrne self-assigned this Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 17, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Exact-head Fallow verification completed at 5c515660eb0782cb33c8537352129a7a430dbdbe against pinned base 3bddfbd6ebe2a7443d2267e71879fb3480dc6a48. The base has no Fallow workflow/configuration or reachable Fallow-introduction commit, so a Fallow-triggered rebase is not applicable. pnpm dlx fallow@3.24.1 completed successfully after dependency installation with no error-severity result; its warning-level complexity/dead-code output is repository-wide, including the intentionally compiled negative-type fixture changed here.

Local gates passed for npm run build, check:purity, check:imports, check:pins, check:profile-claims, check:coderabbit, verify:corpus, focused test/type-negatives.test.ts (2/2), and git diff --check. The repository-wide npm test rerun reached the lane’s two-minute cap without emitting a failure; the exact-head hosted build / purity / test check is green. No product edit, rebase, push, or merge was performed.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by merged combined recovery. Closing this support PR without merge; retaining its branch, commits and collaboration history.

Full context for agent readers

Christian requested complete migration cleanup, not another implementation of already-landed package work. The combined replacement #206 explicitly integrated these five support branches and merged as 11454e8 . They did not close automatically after its squash merge.

Preserved support PR Disposition
#198 Interior connection implementation and ordering regressions incorporated. Frontend adapter delivery remains open at Comfy-Org/ComfyUI_frontend#16818 ; current frontend still rejects interior placement. Historical coverage/dependency observations remain in #198 (comment) and are not waived by retirement.
#201 Definitions plus subsequent fixes incorporated. The landed source contains public-representation digest tests, recursive alias counting, rejected-batch suffix/byte assertions, exact incarnation stamp keys and definition-aware reorder windows. These account for the five native findings in #201 (review) . Frontend private-key cleanup remains Comfy-Org/ComfyUI_frontend#17458 .
#202 Batch-result helper and regression file are byte-identical in the landed combined recovery.
#203 Inconclusive-check protections and regression coverage incorporated with later integration fixes; original attributed records remain in #203 (comment) and #203 (comment) .
#204 Landed OpKind declaration retains all five Checked constraints; type-negative test file is byte-identical. The later Fallow report is historical support-head evidence, not another unlanded code change.

The original source review histories and individually attributed destination records remain intact. No native review is resolved, no historical approval transfers, and no original branch is deleted or rewritten. Existing merged-package verification is retained as dated evidence; no new test was run under the resource hold. The older draft/readiness statements describe their original revisions and are superseded only as instructions to merge these duplicates.

This retires redundant package carriers, not frontend adapter work, product acceptance or security findings. The recovery coordinator retains consumer follow-through in https://github.com/christian-byrne/in-app-agent-program/pull/187 . No release, deployment, paid attempt or shared-document cutover follows from closure.

Glossary: support PR means a smaller recovery branch integrated into the combined replacement; private keys here are internal document bookkeeping fields, not credentials; product acceptance means observed authenticated application behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R1 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant