Repository navigation
[backport cloud/1.54] FE-2033: fix(agent): project define_subgraph definitions cleanly - #18408
Conversation
) - Projects nested `define_subgraph` definitions without cmp-private bookkeeping. - Reuses the app's existing subgraph creation lifecycle before host materialization. - Focused tests and all requested gates are green. Justification: Christian's full integration/admin-merge grant, explicitly confirmed by the [release coordinator](https://ampcode.com/threads/T-01a0a6f4-ce4d-71c8-aa44-be96c230a4e5), authorizes only [c962fcd](c962fcd) after successful hosted checks. The [current-head substantive review](#17458 (review)) finds the mandatory-lookup objection addressed; it is an author-identity COMMENT, not non-author approval. The newer main delta contains only browser documentation/spec changes. This exact-merge compatibility decision supersedes the older program guard's current-main-ancestry and separate-human-approval prerequisites; that guard is not recorded as passing. All 102 checks were terminal before this update: 86 successful and 16 skipped. No reviewer state or thread is dismissed or resolved, and no runtime or release acceptance is claimed. Fresh readback remains required immediately before merge. <details><summary>Full context for agent readers</summary> ## What changed The cmp `define_subgraph` applier writes the normal Yjs definition shape plus `__definition_digest`, a private replay/conflict key. `agentSubgraphDefinitions.ts` now removes that key recursively from root and nested `ExportedSubgraph` projections; its regression tests prove the private field is absent from the projected `ExportedSubgraph` before LiteGraph consumes it. The lifecycle probe found that [the stacked follower change](#17202) already supplies the required frontend lifecycle. Before reconciling root nodes, `reconcileAgentAdapters` registers each missing definition with `rootGraph.createSubgraph`. `LGraph.createSubgraph` normalizes definitions, registers the `Subgraph`, dispatches `subgraph-created`, and configures nested definitions in dependency order. The app event handler then calls `registerNewSubgraph`, which registers the definition id with the `LiteGraph.createNode` factory. Host nodes are subsequently created through that factory and registered by the normal ECS adapter path. Existing integration tests cover: - one `subgraph-created` event per newly observed definition; - a real `SubgraphNode` host created through the registered factory; - no live mutation when a later payload reuses an already registered id; - nested-definition registration, including partially registered trees; - rollback removes a failed definition from `rootGraph.subgraphs` and leaves its host unmaterialized when configuration fails. This PR therefore makes the minimum compatibility change for [the `define_subgraph` applier](#17454) rather than duplicating lifecycle code already owned by the stacked follower branch. Design reference: [agent-added subgraph lifecycle technical design](https://www.notion.so/3d16d73d365081719b85ed515af98276). ## RED to GREEN evidence RED commit `d3057115eb`: ```text Test Files 1 failed (1) Tests 1 failed | 13 passed (14) Received definition retained __definition_digest. ``` GREEN commit `94bce71459`: ```text Test Files 1 passed (1) Tests 14 passed (14) ``` Follow-up commit `3853b94e20` adds a two-level nested regression test. Before the fix, `drops define_subgraph bookkeeping from nested definitions recursively` failed because both nested digests survived; after the fix, all 15 reader tests pass. ## Gates - Focused CRDT Vitest: 3 files, 64 tests passed. - `pnpm typecheck`: passed. - Scoped ESLint, type-aware oxlint, and oxfmt: passed. - Fallow audit: passed with zero introduced findings. ## Vetoable decisions - Keep this stacked on [the existing-subgraph follower change](#17202); the frontend consumes raw Yjs state rather than importing the cmp operation. - Keep `__definition_digest` cmp-private and exclude it from the live `ExportedSubgraph` projection. - Keep creation-only ownership: once an id exists in `rootGraph.subgraphs`, later definition payloads cannot reconfigure the live subgraph. - Do not add a browser test: the deterministic Vitest integration already crosses Yjs mint/update, follower, ECS adapter, real `LGraph`, lifecycle event, factory registration, and `SubgraphNode` materialization without browser-only behavior. </details> --------- Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1935 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T08:12:27.264Z",
"gitSha": "0a4f73bb78bc2bd59e610449b74091ee8545a730",
"branch": "backport-17458-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.6569999999624,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.355999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.93100000000004,
"heapDeltaBytes": -9900228,
"heapUsedBytes": 60263952,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.717,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1997.1080000000256,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.139,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.851,
"heapDeltaBytes": -6600372,
"heapUsedBytes": 64157088,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.524999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1829.2359999999803,
"styleRecalcs": 74,
"styleRecalcDurationMs": 22.764,
"layouts": 14,
"layoutDurationMs": 3.181,
"taskDurationMs": 737.082,
"heapDeltaBytes": -3573348,
"heapUsedBytes": 67211640,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 121.62400000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.6189999999906,
"styleRecalcs": 73,
"styleRecalcDurationMs": 20.227999999999998,
"layouts": 14,
"layoutDurationMs": 3.3560000000000003,
"taskDurationMs": 707.9250000000001,
"heapDeltaBytes": -4587128,
"heapUsedBytes": 65714092,
"domNodes": -280,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 114.932,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.3499999999572,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.659,
"layouts": 6,
"layoutDurationMs": 1.1890000000000003,
"taskDurationMs": 307.69199999999995,
"heapDeltaBytes": 4674896,
"heapUsedBytes": 75453944,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.496,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.9580000000697,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.610999999999999,
"layouts": 6,
"layoutDurationMs": 0.9819999999999998,
"taskDurationMs": 306.221,
"heapDeltaBytes": 4703360,
"heapUsedBytes": 75575060,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.923000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 567.0419999999581,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.416,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.41599999999994,
"heapDeltaBytes": 18384512,
"heapUsedBytes": 88329260,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 126.332,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 535.88400000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.6480000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.324,
"heapDeltaBytes": -7578544,
"heapUsedBytes": 63036548,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 113.07900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2028.5300000000461,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.684999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.98600000000005,
"heapDeltaBytes": 10764816,
"heapUsedBytes": 87222516,
"domNodes": -268,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 31.316999999999997,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.6389999999892,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.886,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.9440000000001,
"heapDeltaBytes": 4955752,
"heapUsedBytes": 81441572,
"domNodes": -278,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 31.773000000000003,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2175.3799999999615,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.046000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1316.89,
"heapDeltaBytes": -9493172,
"heapUsedBytes": 67150004,
"domNodes": -283,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 619.402,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2122.1499999999196,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.727000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1375.413,
"heapDeltaBytes": -9579776,
"heapUsedBytes": 67401708,
"domNodes": -280,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 631.872,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3175.6940000000213,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.323999999999998,
"layouts": 60,
"layoutDurationMs": 11.799999999999999,
"taskDurationMs": 1378.1599999999999,
"heapDeltaBytes": 9117180,
"heapUsedBytes": 75818988,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 588.111,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3298.791999999935,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.142999999999997,
"layouts": 60,
"layoutDurationMs": 13.256,
"taskDurationMs": 1512.2709999999997,
"heapDeltaBytes": -5654088,
"heapUsedBytes": 72265164,
"domNodes": -241,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 642.547,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2287.4929999999836,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.814000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1516.4079999999997,
"heapDeltaBytes": -7721952,
"heapUsedBytes": 71956320,
"domNodes": -250,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 710.9029999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2340.345999999954,
"styleRecalcs": 42,
"styleRecalcDurationMs": 9.065999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1504.3429999999998,
"heapDeltaBytes": 18258116,
"heapUsedBytes": 85758572,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 717.847,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.2400000000157,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.685999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.04,
"heapDeltaBytes": 5764120,
"heapUsedBytes": 82392104,
"domNodes": -276,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 28.596000000000004,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.4509999999846,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.5050000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.93399999999997,
"heapDeltaBytes": 10271384,
"heapUsedBytes": 87968816,
"domNodes": -270,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 29.024,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.4180000000019,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.815999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.385,
"heapDeltaBytes": 14347344,
"heapUsedBytes": 86711980,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 103.019,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.2089999999571,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.373000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.577,
"heapDeltaBytes": 14752324,
"heapUsedBytes": 87801596,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 101.56400000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2001.305000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.729999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.996,
"heapDeltaBytes": -10052740,
"heapUsedBytes": 61732756,
"domNodes": -298,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.959,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.1479999999865,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.9270000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.1619999999999,
"heapDeltaBytes": 8240604,
"heapUsedBytes": 81045508,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.569000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.0470000000314,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.909000000000002,
"layouts": 18,
"layoutDurationMs": 3.641,
"taskDurationMs": 680.933,
"heapDeltaBytes": -836572,
"heapUsedBytes": 71179760,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 75.689,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.1399999999394,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.378,
"layouts": 18,
"layoutDurationMs": 3.927,
"taskDurationMs": 669.519,
"heapDeltaBytes": 8206920,
"heapUsedBytes": 80459776,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 78.401,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.7249999999854,
"styleRecalcs": 21,
"styleRecalcDurationMs": 25.944999999999997,
"layouts": 17,
"layoutDurationMs": 10.914,
"taskDurationMs": 736.5800000000003,
"heapDeltaBytes": 22008948,
"heapUsedBytes": 105983848,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 22.827,
"eventListeners": 2385,
"totalBlockingTimeMs": 116,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8156.115,
"styleRecalcs": 249,
"styleRecalcDurationMs": 28.214999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4482.018,
"heapDeltaBytes": 14067456,
"heapUsedBytes": 89704924,
"domNodes": -270,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 1949.0759999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8184.9959999999555,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.091,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4749.517,
"heapDeltaBytes": -6140936,
"heapUsedBytes": 69601084,
"domNodes": -274,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 2106.444,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13306.579,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12535.104000000001,
"heapDeltaBytes": -34570764,
"heapUsedBytes": 176309128,
"domNodes": -8068,
"jsHeapTotalBytes": -16715776,
"scriptDurationMs": 240.035,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13922.499000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13031.735,
"heapDeltaBytes": -40541384,
"heapUsedBytes": 177409300,
"domNodes": -8068,
"jsHeapTotalBytes": -10760192,
"scriptDurationMs": 254.53300000000002,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16252.701000000001,
"styleRecalcs": 103,
"styleRecalcDurationMs": 15.46,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15719.319000000001,
"heapDeltaBytes": -32544680,
"heapUsedBytes": 185062432,
"domNodes": -8068,
"jsHeapTotalBytes": -10776576,
"scriptDurationMs": 842.606,
"eventListeners": -14929,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16563.70000000004,
"styleRecalcs": 112,
"styleRecalcDurationMs": 16.823000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16069.279999999999,
"heapDeltaBytes": -33420352,
"heapUsedBytes": 193348976,
"domNodes": -8068,
"jsHeapTotalBytes": -17854464,
"scriptDurationMs": 958.0009999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4620.013000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.12400000000002,
"layouts": 20,
"layoutDurationMs": 21.957000000000004,
"taskDurationMs": 4493.609000000001,
"heapDeltaBytes": -49089676,
"heapUsedBytes": 183660920,
"domNodes": -8068,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 83.95,
"eventListeners": -14933,
"totalBlockingTimeMs": 65,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4998.546999999917,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.803999999999974,
"layouts": 20,
"layoutDurationMs": 22.56599999999999,
"taskDurationMs": 4871.268000000001,
"heapDeltaBytes": -55494432,
"heapUsedBytes": 175491608,
"domNodes": -8068,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 99.63599999999998,
"eventListeners": -14931,
"totalBlockingTimeMs": 111,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6915.512000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6498.475000000001,
"heapDeltaBytes": 11924956,
"heapUsedBytes": 176856992,
"domNodes": 0,
"jsHeapTotalBytes": -32505856,
"scriptDurationMs": 106.317,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6995.360000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6571.7339999999995,
"heapDeltaBytes": 20576636,
"heapUsedBytes": 197774344,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 110.46800000000006,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 450.97700000002305,
"styleRecalcs": 18,
"styleRecalcDurationMs": 16.157999999999998,
"layouts": 3,
"layoutDurationMs": 1.3490000000000002,
"taskDurationMs": 88.744,
"heapDeltaBytes": 4975776,
"heapUsedBytes": 72901028,
"domNodes": 145,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.142000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 442.22800000000007,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.589,
"layouts": 2,
"layoutDurationMs": 0.5020000000000001,
"taskDurationMs": 80.575,
"heapDeltaBytes": 4759488,
"heapUsedBytes": 73059216,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.488999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18408 +/- ##
=============================================
Coverage ? 83.60%
=============================================
Files ? 2097
Lines ? 123977
Branches ? 33522
=============================================
Hits ? 103652
Misses ? 20147
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Qualified against the live Cloud target.
Full context for agent readersAdmin-merge justification: necessary Cloud backport under Christian's exact-carrier integration grant. The carrier head is 4b55147a. Immediately before landing, all 102 exact-head checks were terminal: 78 successful and 24 skipped, with no pending or adverse result. The browser aggregate reported 1,935 passed, zero failed, and one flaky test. The Codecov bot reported 96.61% patch coverage with two uncovered lines; this is retained as a nonblocking warning, not represented as green coverage. The live Fresh pagination found no submitted reviews, inline review comments, review threads, latest reviews, or recorded human objection. Existing issue comments are bots only. The source review plus this explicit adjudication supersede separate reviewer-approval and current-target-ancestry formalities for this carrier only. No approval is invented, no review state is dismissed, and no obsolete target-aware guard is described as passing. Landing does not authorize a CI reset, new runtime, deployment, flag change, or product acceptance. Authenticated edit/save/reload acceptance remains separate and open. |
Backport of #17458 to
cloud/1.54Automatically created by backport workflow.