Skip to content

[backport cloud/1.54] FE-2033: fix(agent): project define_subgraph definitions cleanly - #18408

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-17458-to-cloud-1.54
Sep 22, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-17458-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #17458 to cloud/1.54

Automatically created by backport workflow.

)

- Projects nested `define_subgraph` definitions without cmp-private
bookkeeping.
- Reuses the app's existing subgraph creation lifecycle before host
materialization.
- Focused tests and all requested gates are green.

Justification: Christian's full integration/admin-merge grant,
explicitly confirmed by the [release
coordinator](https://ampcode.com/threads/T-01a0a6f4-ce4d-71c8-aa44-be96c230a4e5),
authorizes only
[c962fcd](c962fcd)
after successful hosted checks. The [current-head substantive
review](#17458 (review))
finds the mandatory-lookup objection addressed; it is an author-identity
COMMENT, not non-author approval. The newer main delta contains only
browser documentation/spec changes. This exact-merge compatibility
decision supersedes the older program guard's current-main-ancestry and
separate-human-approval prerequisites; that guard is not recorded as
passing. All 102 checks were terminal before this update: 86 successful
and 16 skipped. No reviewer state or thread is dismissed or resolved,
and no runtime or release acceptance is claimed. Fresh readback remains
required immediately before merge.

<details><summary>Full context for agent readers</summary>

## What changed

The cmp `define_subgraph` applier writes the normal Yjs definition shape
plus `__definition_digest`, a private replay/conflict key.
`agentSubgraphDefinitions.ts` now removes that key recursively from root
and nested `ExportedSubgraph` projections; its regression tests prove
the private field is absent from the projected `ExportedSubgraph` before
LiteGraph consumes it.

The lifecycle probe found that [the stacked follower
change](#17202)
already supplies the required frontend lifecycle. Before reconciling
root nodes, `reconcileAgentAdapters` registers each missing definition
with `rootGraph.createSubgraph`. `LGraph.createSubgraph` normalizes
definitions, registers the `Subgraph`, dispatches `subgraph-created`,
and configures nested definitions in dependency order. The app event
handler then calls `registerNewSubgraph`, which registers the definition
id with the `LiteGraph.createNode` factory. Host nodes are subsequently
created through that factory and registered by the normal ECS adapter
path.

Existing integration tests cover:

- one `subgraph-created` event per newly observed definition;
- a real `SubgraphNode` host created through the registered factory;
- no live mutation when a later payload reuses an already registered id;
- nested-definition registration, including partially registered trees;
- rollback removes a failed definition from `rootGraph.subgraphs` and
leaves its host unmaterialized when configuration fails.

This PR therefore makes the minimum compatibility change for [the
`define_subgraph`
applier](#17454)
rather than duplicating lifecycle code already owned by the stacked
follower branch.

Design reference: [agent-added subgraph lifecycle technical
design](https://www.notion.so/3d16d73d365081719b85ed515af98276).

## RED to GREEN evidence

RED commit `d3057115eb`:

```text
Test Files  1 failed (1)
Tests       1 failed | 13 passed (14)
Received definition retained __definition_digest.
```

GREEN commit `94bce71459`:

```text
Test Files  1 passed (1)
Tests       14 passed (14)
```

Follow-up commit `3853b94e20` adds a two-level nested regression test.
Before the fix, `drops define_subgraph bookkeeping from nested
definitions recursively` failed because both nested digests survived;
after the fix, all 15 reader tests pass.

## Gates

- Focused CRDT Vitest: 3 files, 64 tests passed.
- `pnpm typecheck`: passed.
- Scoped ESLint, type-aware oxlint, and oxfmt: passed.
- Fallow audit: passed with zero introduced findings.

## Vetoable decisions

- Keep this stacked on [the existing-subgraph follower
change](#17202); the
frontend consumes raw Yjs state rather than importing the cmp operation.
- Keep `__definition_digest` cmp-private and exclude it from the live
`ExportedSubgraph` projection.
- Keep creation-only ownership: once an id exists in
`rootGraph.subgraphs`, later definition payloads cannot reconfigure the
live subgraph.
- Do not add a browser test: the deterministic Vitest integration
already crosses Yjs mint/update, follower, ECS adapter, real `LGraph`,
lifecycle event, factory registration, and `SubgraphNode`
materialization without browser-only behavior.

</details>

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 22, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 22, 2026 08:01
@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 8:01am UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1935 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1914 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 08:06:25 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 116ms TBT · 101.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.7 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 64ms TBT · 180.4 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 88ms TBT · 171.3 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 178.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 443ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.3 MB
canvas-idle: DOM nodes -277
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 21ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 723ms
canvas-mouse-sweep: script duration 118ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.4 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 307ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.0 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 350ms
dom-widget-clipping: script duration 120ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.2 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 521ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.4 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -192
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1346ms
large-graph-pan: script duration 626ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.2 MB
large-graph-pan: DOM nodes -282
large-graph-pan: event listeners -191
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1445ms
large-graph-zoom: script duration 615ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.6 MB
large-graph-zoom: DOM nodes -258
large-graph-zoom: event listeners -90
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1510ms
legacy-node-drag: script duration 714ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.2 MB
legacy-node-drag: DOM nodes -123
legacy-node-drag: event listeners 88
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 519ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.2 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -175
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 315ms
subgraph-dom-widget-clipping: script duration 102ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 430ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.1 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -226
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 20ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 675ms
subgraph-mouse-sweep: script duration 77ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 72.3 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -225
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 737ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 116ms
subgraph-transition-enter: heap used 101.1 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4616ms
viewport-pan-sweep: script duration 2028ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.0 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -176
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12783ms
vue-large-graph-idle: script duration 247ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.7 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14935
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 108
vue-large-graph-pan: task duration 15894ms
vue-large-graph-pan: script duration 900ms
vue-large-graph-pan: TBT 64ms
vue-large-graph-pan: heap used 180.4 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 63ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4682ms
vue-node-resize-workload: script duration 92ms
vue-node-resize-workload: TBT 88ms
vue-node-resize-workload: heap used 171.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14932
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6535ms
vue-zoom-out-idle: script duration 108ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 178.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 16
workflow-execution: task duration 85ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.6 MB
workflow-execution: DOM nodes 132
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-22T08:12:27.264Z",
  "gitSha": "0a4f73bb78bc2bd59e610449b74091ee8545a730",
  "branch": "backport-17458-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2030.6569999999624,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.355999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.93100000000004,
      "heapDeltaBytes": -9900228,
      "heapUsedBytes": 60263952,
      "domNodes": -276,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.717,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 1997.1080000000256,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.139,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.851,
      "heapDeltaBytes": -6600372,
      "heapUsedBytes": 64157088,
      "domNodes": -278,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.524999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1829.2359999999803,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 22.764,
      "layouts": 14,
      "layoutDurationMs": 3.181,
      "taskDurationMs": 737.082,
      "heapDeltaBytes": -3573348,
      "heapUsedBytes": 67211640,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 121.62400000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1742.6189999999906,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 20.227999999999998,
      "layouts": 14,
      "layoutDurationMs": 3.3560000000000003,
      "taskDurationMs": 707.9250000000001,
      "heapDeltaBytes": -4587128,
      "heapUsedBytes": 65714092,
      "domNodes": -280,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 114.932,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1688.3499999999572,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.659,
      "layouts": 6,
      "layoutDurationMs": 1.1890000000000003,
      "taskDurationMs": 307.69199999999995,
      "heapDeltaBytes": 4674896,
      "heapUsedBytes": 75453944,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.496,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1664.9580000000697,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.610999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.9819999999999998,
      "taskDurationMs": 306.221,
      "heapDeltaBytes": 4703360,
      "heapUsedBytes": 75575060,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.923000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 567.0419999999581,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.416,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 358.41599999999994,
      "heapDeltaBytes": 18384512,
      "heapUsedBytes": 88329260,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 126.332,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 535.88400000001,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.6480000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 341.324,
      "heapDeltaBytes": -7578544,
      "heapUsedBytes": 63036548,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 113.07900000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.5300000000461,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.684999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 510.98600000000005,
      "heapDeltaBytes": 10764816,
      "heapUsedBytes": 87222516,
      "domNodes": -268,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 31.316999999999997,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.6389999999892,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.886,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.9440000000001,
      "heapDeltaBytes": 4955752,
      "heapUsedBytes": 81441572,
      "domNodes": -278,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 31.773000000000003,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2175.3799999999615,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 10.046000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1316.89,
      "heapDeltaBytes": -9493172,
      "heapUsedBytes": 67150004,
      "domNodes": -283,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 619.402,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2122.1499999999196,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.727000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1375.413,
      "heapDeltaBytes": -9579776,
      "heapUsedBytes": 67401708,
      "domNodes": -280,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 631.872,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3175.6940000000213,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.323999999999998,
      "layouts": 60,
      "layoutDurationMs": 11.799999999999999,
      "taskDurationMs": 1378.1599999999999,
      "heapDeltaBytes": 9117180,
      "heapUsedBytes": 75818988,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 588.111,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3298.791999999935,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.142999999999997,
      "layouts": 60,
      "layoutDurationMs": 13.256,
      "taskDurationMs": 1512.2709999999997,
      "heapDeltaBytes": -5654088,
      "heapUsedBytes": 72265164,
      "domNodes": -241,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 642.547,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2287.4929999999836,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.814000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1516.4079999999997,
      "heapDeltaBytes": -7721952,
      "heapUsedBytes": 71956320,
      "domNodes": -250,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 710.9029999999999,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2340.345999999954,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 9.065999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1504.3429999999998,
      "heapDeltaBytes": 18258116,
      "heapUsedBytes": 85758572,
      "domNodes": 4,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 717.847,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.2400000000157,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.685999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 536.04,
      "heapDeltaBytes": 5764120,
      "heapUsedBytes": 82392104,
      "domNodes": -276,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 28.596000000000004,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.4509999999846,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.5050000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.93399999999997,
      "heapDeltaBytes": 10271384,
      "heapUsedBytes": 87968816,
      "domNodes": -270,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 29.024,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 525.4180000000019,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.815999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 314.385,
      "heapDeltaBytes": 14347344,
      "heapUsedBytes": 86711980,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 103.019,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 542.2089999999571,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.373000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 315.577,
      "heapDeltaBytes": 14752324,
      "heapUsedBytes": 87801596,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 101.56400000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2001.305000000002,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.729999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.996,
      "heapDeltaBytes": -10052740,
      "heapUsedBytes": 61732756,
      "domNodes": -298,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.959,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.1479999999865,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.9270000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.1619999999999,
      "heapDeltaBytes": 8240604,
      "heapUsedBytes": 81045508,
      "domNodes": -293,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.569000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.0470000000314,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 19.909000000000002,
      "layouts": 18,
      "layoutDurationMs": 3.641,
      "taskDurationMs": 680.933,
      "heapDeltaBytes": -836572,
      "heapUsedBytes": 71179760,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 75.689,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1728.1399999999394,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 20.378,
      "layouts": 18,
      "layoutDurationMs": 3.927,
      "taskDurationMs": 669.519,
      "heapDeltaBytes": 8206920,
      "heapUsedBytes": 80459776,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 78.401,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 916.7249999999854,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 25.944999999999997,
      "layouts": 17,
      "layoutDurationMs": 10.914,
      "taskDurationMs": 736.5800000000003,
      "heapDeltaBytes": 22008948,
      "heapUsedBytes": 105983848,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 22.827,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 116,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8156.115,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 28.214999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4482.018,
      "heapDeltaBytes": 14067456,
      "heapUsedBytes": 89704924,
      "domNodes": -270,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 1949.0759999999998,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8184.9959999999555,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.091,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4749.517,
      "heapDeltaBytes": -6140936,
      "heapUsedBytes": 69601084,
      "domNodes": -274,
      "jsHeapTotalBytes": 4349952,
      "scriptDurationMs": 2106.444,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13306.579,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12535.104000000001,
      "heapDeltaBytes": -34570764,
      "heapUsedBytes": 176309128,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16715776,
      "scriptDurationMs": 240.035,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13922.499000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13031.735,
      "heapDeltaBytes": -40541384,
      "heapUsedBytes": 177409300,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10760192,
      "scriptDurationMs": 254.53300000000002,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16252.701000000001,
      "styleRecalcs": 103,
      "styleRecalcDurationMs": 15.46,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15719.319000000001,
      "heapDeltaBytes": -32544680,
      "heapUsedBytes": 185062432,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10776576,
      "scriptDurationMs": 842.606,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 25,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16563.70000000004,
      "styleRecalcs": 112,
      "styleRecalcDurationMs": 16.823000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16069.279999999999,
      "heapDeltaBytes": -33420352,
      "heapUsedBytes": 193348976,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17854464,
      "scriptDurationMs": 958.0009999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 103,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4620.013000000028,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 63.12400000000002,
      "layouts": 20,
      "layoutDurationMs": 21.957000000000004,
      "taskDurationMs": 4493.609000000001,
      "heapDeltaBytes": -49089676,
      "heapUsedBytes": 183660920,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13893632,
      "scriptDurationMs": 83.95,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 65,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4998.546999999917,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 63.803999999999974,
      "layouts": 20,
      "layoutDurationMs": 22.56599999999999,
      "taskDurationMs": 4871.268000000001,
      "heapDeltaBytes": -55494432,
      "heapUsedBytes": 175491608,
      "domNodes": -8068,
      "jsHeapTotalBytes": -860160,
      "scriptDurationMs": 99.63599999999998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 111,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6915.512000000035,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6498.475000000001,
      "heapDeltaBytes": 11924956,
      "heapUsedBytes": 176856992,
      "domNodes": 0,
      "jsHeapTotalBytes": -32505856,
      "scriptDurationMs": 106.317,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6995.360000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6571.7339999999995,
      "heapDeltaBytes": 20576636,
      "heapUsedBytes": 197774344,
      "domNodes": 0,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 110.46800000000006,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 450.97700000002305,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 16.157999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.3490000000000002,
      "taskDurationMs": 88.744,
      "heapDeltaBytes": 4975776,
      "heapUsedBytes": 72901028,
      "domNodes": 145,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.142000000000001,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 442.22800000000007,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 14.589,
      "layouts": 2,
      "layoutDurationMs": 0.5020000000000001,
      "taskDurationMs": 80.575,
      "heapDeltaBytes": 4759488,
      "heapUsedBytes": 73059216,
      "domNodes": 119,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.488999999999998,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50314 75409 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../extensions/agent/crdt/agentSubgraphDefinitions.ts 96.61% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18408   +/-   ##
=============================================
  Coverage              ?   83.60%           
=============================================
  Files                 ?     2097           
  Lines                 ?   123977           
  Branches              ?    33522           
=============================================
  Hits                  ?   103652           
  Misses                ?    20147           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.73% <ø> (?)
unit 78.57% <96.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../extensions/agent/crdt/agentSubgraphDefinitions.ts 94.11% <96.61%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor

Qualified against the live Cloud target.

  • Exact-head checks: 78 successful, 24 skipped.
  • Target delta: zero file overlap; conflict-free merge tree.
  • No reviewer approval or combined hosted-CI run is claimed.
Full context for agent readers

Admin-merge justification: necessary Cloud backport under Christian's exact-carrier integration grant.

The carrier head is 4b55147a. Immediately before landing, all 102 exact-head checks were terminal: 78 successful and 24 skipped, with no pending or adverse result. The browser aggregate reported 1,935 passed, zero failed, and one flaky test. The Codecov bot reported 96.61% patch coverage with two uncovered lines; this is retained as a nonblocking warning, not represented as green coverage.

The live cloud/1.54 target was b06429b7. Its workflow-tab and reconnect-lifecycle changes have zero file overlap with this carrier's definition-schema reader and regression test. A fresh merge-tree calculation was conflict-free and produced fef805177ca970e6bf99c764b59c7001ad27a098. The carrier's stable patch identity matches the merged source repair exactly. This is a source-grounded compatibility adjudication; the combined tree was not run in hosted CI.

Fresh pagination found no submitted reviews, inline review comments, review threads, latest reviews, or recorded human objection. Existing issue comments are bots only. The source review plus this explicit adjudication supersede separate reviewer-approval and current-target-ancestry formalities for this carrier only. No approval is invented, no review state is dismissed, and no obsolete target-aware guard is described as passing.

Landing does not authorize a CI reset, new runtime, deployment, flag change, or product acceptance. Authenticated edit/save/reload acceptance remains separate and open.

@christian-byrne
christian-byrne merged commit 1dfcc88 into cloud/1.54 Sep 22, 2026
104 checks passed
@christian-byrne
christian-byrne deleted the backport-17458-to-cloud-1.54 branch September 22, 2026 08:34
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants